From: Josh Poimboeuf <jpoimboe@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
Mark Rutland <mark.rutland@arm.com>,
Jason Baron <jbaron@akamai.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ard Biesheuvel <ardb@kernel.org>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Paolo Bonzini <pbonzini@redhat.com>,
Sean Christopherson <seanjc@google.com>,
Sami Tolvanen <samitolvanen@google.com>,
Nick Desaulniers <ndesaulniers@google.com>,
Will McVicker <willmcvicker@google.com>,
Kees Cook <keescook@chromium.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 09/11] static_call: Make NULL static calls consistent
Date: Wed, 22 Mar 2023 11:35:29 -0700 [thread overview]
Message-ID: <20230322183529.owu33xouz44sv4re@treble> (raw)
In-Reply-To: <20230322145918.GF2357380@hirez.programming.kicks-ass.net>
On Wed, Mar 22, 2023 at 03:59:18PM +0100, Peter Zijlstra wrote:
> On Tue, Mar 21, 2023 at 09:00:15PM -0700, Josh Poimboeuf wrote:
> > +void __static_call_nop(void)
> > +{
> > +}
> > +EXPORT_SYMBOL_GPL(__static_call_nop);
>
> Kees, is this a ROP target? The above is basically ENDBR;RET, push
> something on the stack, jump there and you're in business or so.
I could add __noendbr, except for the !HAVE_STATIC_CALL + !CFI_CLANG
case which actually needs to indirect call it.
--
Josh
WARNING: multiple messages have this Message-ID (diff)
From: Josh Poimboeuf <jpoimboe@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
Mark Rutland <mark.rutland@arm.com>,
Jason Baron <jbaron@akamai.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ard Biesheuvel <ardb@kernel.org>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Paolo Bonzini <pbonzini@redhat.com>,
Sean Christopherson <seanjc@google.com>,
Sami Tolvanen <samitolvanen@google.com>,
Nick Desaulniers <ndesaulniers@google.com>,
Will McVicker <willmcvicker@google.com>,
Kees Cook <keescook@chromium.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 09/11] static_call: Make NULL static calls consistent
Date: Wed, 22 Mar 2023 11:35:29 -0700 [thread overview]
Message-ID: <20230322183529.owu33xouz44sv4re@treble> (raw)
In-Reply-To: <20230322145918.GF2357380@hirez.programming.kicks-ass.net>
On Wed, Mar 22, 2023 at 03:59:18PM +0100, Peter Zijlstra wrote:
> On Tue, Mar 21, 2023 at 09:00:15PM -0700, Josh Poimboeuf wrote:
> > +void __static_call_nop(void)
> > +{
> > +}
> > +EXPORT_SYMBOL_GPL(__static_call_nop);
>
> Kees, is this a ROP target? The above is basically ENDBR;RET, push
> something on the stack, jump there and you're in business or so.
I could add __noendbr, except for the !HAVE_STATIC_CALL + !CFI_CLANG
case which actually needs to indirect call it.
--
Josh
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-03-22 18:35 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-22 4:00 [PATCH v2 00/11] static_call: Improve NULL/ret0 handling Josh Poimboeuf
2023-03-22 4:00 ` Josh Poimboeuf
2023-03-22 4:00 ` [PATCH v2 01/11] static_call: Improve key type abstraction Josh Poimboeuf
2023-03-22 4:00 ` Josh Poimboeuf
2023-03-22 4:53 ` Josh Poimboeuf
2023-03-22 4:53 ` Josh Poimboeuf
2023-03-22 5:02 ` [PATCH v2.1 " Josh Poimboeuf
2023-03-22 5:02 ` Josh Poimboeuf
2023-03-22 4:00 ` [PATCH v2 02/11] static_call: Flip key type union bit Josh Poimboeuf
2023-03-22 4:00 ` Josh Poimboeuf
2023-03-22 5:03 ` [PATCH v2.1 " Josh Poimboeuf
2023-03-22 5:03 ` Josh Poimboeuf
2023-03-22 4:00 ` [PATCH v2 03/11] static_call: Remove static_call_mod_init() declaration Josh Poimboeuf
2023-03-22 4:00 ` Josh Poimboeuf
2023-03-22 4:00 ` [PATCH v2 04/11] static_call: Remove static_call.h dependency on cpu.h Josh Poimboeuf
2023-03-22 4:00 ` Josh Poimboeuf
2023-03-22 4:00 ` [PATCH v2 05/11] static_call: Make ARCH_ADD_TRAMP_KEY() generic Josh Poimboeuf
2023-03-22 4:00 ` Josh Poimboeuf
2023-03-22 4:00 ` [PATCH v2 06/11] static_call: "EXPORT_STATIC_CALL_TRAMP" -> "EXPORT_STATIC_CALL_RO" Josh Poimboeuf
2023-03-22 4:00 ` Josh Poimboeuf
2023-03-22 4:00 ` [PATCH v2 07/11] static_call: Reorganize static call headers Josh Poimboeuf
2023-03-22 4:00 ` Josh Poimboeuf
2023-03-22 4:00 ` [PATCH v2 08/11] arm64/static_call: Fix static call CFI violations Josh Poimboeuf
2023-03-22 4:00 ` Josh Poimboeuf
2023-03-22 12:22 ` Mark Rutland
2023-03-22 12:22 ` Mark Rutland
2023-03-22 14:19 ` Peter Zijlstra
2023-03-22 14:19 ` Peter Zijlstra
2023-03-22 18:26 ` Josh Poimboeuf
2023-03-22 18:26 ` Josh Poimboeuf
2023-03-22 18:09 ` Josh Poimboeuf
2023-03-22 18:09 ` Josh Poimboeuf
2023-03-22 18:07 ` Sami Tolvanen
2023-03-22 18:07 ` Sami Tolvanen
2023-03-22 18:33 ` Josh Poimboeuf
2023-03-22 18:33 ` Josh Poimboeuf
2023-03-22 4:00 ` [PATCH v2 09/11] static_call: Make NULL static calls consistent Josh Poimboeuf
2023-03-22 4:00 ` Josh Poimboeuf
2023-03-22 14:45 ` Peter Zijlstra
2023-03-22 14:45 ` Peter Zijlstra
2023-03-22 14:59 ` Peter Zijlstra
2023-03-22 14:59 ` Peter Zijlstra
2023-03-22 18:35 ` Josh Poimboeuf [this message]
2023-03-22 18:35 ` Josh Poimboeuf
2023-03-22 15:04 ` Christophe Leroy
2023-03-22 15:04 ` Christophe Leroy
2023-03-22 4:00 ` [PATCH v2 10/11] static_call: Remove static_call_cond() Josh Poimboeuf
2023-03-22 4:00 ` Josh Poimboeuf
2023-03-22 4:00 ` [PATCH v2 11/11] static_call: Remove DEFINE_STATIC_CALL_RET0() Josh Poimboeuf
2023-03-22 4:00 ` Josh Poimboeuf
2023-03-22 15:04 ` Christophe Leroy
2023-03-22 15:04 ` Christophe Leroy
2023-03-22 18:50 ` Josh Poimboeuf
2023-03-22 18:50 ` Josh Poimboeuf
2023-03-22 15:15 ` Peter Zijlstra
2023-03-22 15:15 ` Peter Zijlstra
2023-03-22 18:45 ` Josh Poimboeuf
2023-03-22 18:45 ` Josh Poimboeuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230322183529.owu33xouz44sv4re@treble \
--to=jpoimboe@kernel.org \
--cc=ardb@kernel.org \
--cc=christophe.leroy@csgroup.eu \
--cc=jbaron@akamai.com \
--cc=keescook@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=ndesaulniers@google.com \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=samitolvanen@google.com \
--cc=seanjc@google.com \
--cc=willmcvicker@google.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.