* [PATCH v1 1/1] arch: arm: zynqmp: mp.c: tcminit halt both cores in split mode
@ 2023-03-23 8:25 Neal Frager
2023-03-28 6:37 ` Michal Simek
0 siblings, 1 reply; 2+ messages in thread
From: Neal Frager @ 2023-03-23 8:25 UTC (permalink / raw)
To: u-boot; +Cc: michal.simek, ashok.reddy.soma, Neal Frager
The "zynqmp tcminit split" command should halt both cores and not just RPU1
when configuring the TCM memory for split mode.
Signed-off-by: Neal Frager <neal.frager@amd.com>
---
arch/arm/mach-zynqmp/mp.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/mach-zynqmp/mp.c b/arch/arm/mach-zynqmp/mp.c
index 4f1ed44afb..2407eaf00b 100644
--- a/arch/arm/mach-zynqmp/mp.c
+++ b/arch/arm/mach-zynqmp/mp.c
@@ -244,8 +244,10 @@ void initialize_tcm(bool mode)
release_r5_reset(ZYNQMP_CORE_RPU0, LOCK);
} else {
set_r5_tcm_mode(SPLIT);
+ set_r5_halt_mode(ZYNQMP_CORE_RPU0, HALT, SPLIT);
set_r5_halt_mode(ZYNQMP_CORE_RPU1, HALT, SPLIT);
enable_clock_r5();
+ release_r5_reset(ZYNQMP_CORE_RPU0, SPLIT);
release_r5_reset(ZYNQMP_CORE_RPU1, SPLIT);
}
}
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v1 1/1] arch: arm: zynqmp: mp.c: tcminit halt both cores in split mode
2023-03-23 8:25 [PATCH v1 1/1] arch: arm: zynqmp: mp.c: tcminit halt both cores in split mode Neal Frager
@ 2023-03-28 6:37 ` Michal Simek
0 siblings, 0 replies; 2+ messages in thread
From: Michal Simek @ 2023-03-28 6:37 UTC (permalink / raw)
To: Neal Frager, u-boot; +Cc: ashok.reddy.soma
On 3/23/23 09:25, Neal Frager wrote:
> The "zynqmp tcminit split" command should halt both cores and not just RPU1
> when configuring the TCM memory for split mode.
>
> Signed-off-by: Neal Frager <neal.frager@amd.com>
> ---
> arch/arm/mach-zynqmp/mp.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/mach-zynqmp/mp.c b/arch/arm/mach-zynqmp/mp.c
> index 4f1ed44afb..2407eaf00b 100644
> --- a/arch/arm/mach-zynqmp/mp.c
> +++ b/arch/arm/mach-zynqmp/mp.c
> @@ -244,8 +244,10 @@ void initialize_tcm(bool mode)
> release_r5_reset(ZYNQMP_CORE_RPU0, LOCK);
> } else {
> set_r5_tcm_mode(SPLIT);
> + set_r5_halt_mode(ZYNQMP_CORE_RPU0, HALT, SPLIT);
> set_r5_halt_mode(ZYNQMP_CORE_RPU1, HALT, SPLIT);
> enable_clock_r5();
> + release_r5_reset(ZYNQMP_CORE_RPU0, SPLIT);
> release_r5_reset(ZYNQMP_CORE_RPU1, SPLIT);
> }
> }
Applied.
M
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-28 6:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-23 8:25 [PATCH v1 1/1] arch: arm: zynqmp: mp.c: tcminit halt both cores in split mode Neal Frager
2023-03-28 6:37 ` Michal Simek
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.