All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] phy: allwinner: Use dev_err_probe()
@ 2023-03-23  7:42 ` ye.xingchen
  0 siblings, 0 replies; 6+ messages in thread
From: ye.xingchen @ 2023-03-23  7:42 UTC (permalink / raw)
  To: vkoul
  Cc: kishon, wens, jernej.skrabec, samuel, linux-phy,
	linux-arm-kernel, linux-sunxi, linux-kernel

From: Ye Xingchen <ye.xingchen@zte.com.cn>

Replace the open-code with dev_err_probe() to simplify the code.

Signed-off-by: Ye Xingchen <ye.xingchen@zte.com.cn>
---
 drivers/phy/allwinner/phy-sun50i-usb3.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/phy/allwinner/phy-sun50i-usb3.c b/drivers/phy/allwinner/phy-sun50i-usb3.c
index 84055b720016..c43087b85070 100644
--- a/drivers/phy/allwinner/phy-sun50i-usb3.c
+++ b/drivers/phy/allwinner/phy-sun50i-usb3.c
@@ -140,11 +140,8 @@ static int sun50i_usb3_phy_probe(struct platform_device *pdev)
 		return -ENOMEM;

 	phy->clk = devm_clk_get(dev, NULL);
-	if (IS_ERR(phy->clk)) {
-		if (PTR_ERR(phy->clk) != -EPROBE_DEFER)
-			dev_err(dev, "failed to get phy clock\n");
-		return PTR_ERR(phy->clk);
-	}
+	if (IS_ERR(phy->clk))
+		return dev_err_probe(dev, PTR_ERR(phy->clk), "failed to get phy clock\n");

 	phy->reset = devm_reset_control_get(dev, NULL);
 	if (IS_ERR(phy->reset)) {
-- 
2.25.1

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH] phy: allwinner: Use dev_err_probe()
@ 2023-03-23  7:42 ` ye.xingchen
  0 siblings, 0 replies; 6+ messages in thread
From: ye.xingchen @ 2023-03-23  7:42 UTC (permalink / raw)
  To: vkoul
  Cc: kishon, wens, jernej.skrabec, samuel, linux-phy,
	linux-arm-kernel, linux-sunxi, linux-kernel

From: Ye Xingchen <ye.xingchen@zte.com.cn>

Replace the open-code with dev_err_probe() to simplify the code.

Signed-off-by: Ye Xingchen <ye.xingchen@zte.com.cn>
---
 drivers/phy/allwinner/phy-sun50i-usb3.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/phy/allwinner/phy-sun50i-usb3.c b/drivers/phy/allwinner/phy-sun50i-usb3.c
index 84055b720016..c43087b85070 100644
--- a/drivers/phy/allwinner/phy-sun50i-usb3.c
+++ b/drivers/phy/allwinner/phy-sun50i-usb3.c
@@ -140,11 +140,8 @@ static int sun50i_usb3_phy_probe(struct platform_device *pdev)
 		return -ENOMEM;

 	phy->clk = devm_clk_get(dev, NULL);
-	if (IS_ERR(phy->clk)) {
-		if (PTR_ERR(phy->clk) != -EPROBE_DEFER)
-			dev_err(dev, "failed to get phy clock\n");
-		return PTR_ERR(phy->clk);
-	}
+	if (IS_ERR(phy->clk))
+		return dev_err_probe(dev, PTR_ERR(phy->clk), "failed to get phy clock\n");

 	phy->reset = devm_reset_control_get(dev, NULL);
 	if (IS_ERR(phy->reset)) {
-- 
2.25.1

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH] phy: allwinner: Use dev_err_probe()
@ 2023-03-23  7:42 ` ye.xingchen
  0 siblings, 0 replies; 6+ messages in thread
From: ye.xingchen @ 2023-03-23  7:42 UTC (permalink / raw)
  To: vkoul
  Cc: kishon, wens, jernej.skrabec, samuel, linux-phy,
	linux-arm-kernel, linux-sunxi, linux-kernel

From: Ye Xingchen <ye.xingchen@zte.com.cn>

Replace the open-code with dev_err_probe() to simplify the code.

Signed-off-by: Ye Xingchen <ye.xingchen@zte.com.cn>
---
 drivers/phy/allwinner/phy-sun50i-usb3.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/phy/allwinner/phy-sun50i-usb3.c b/drivers/phy/allwinner/phy-sun50i-usb3.c
index 84055b720016..c43087b85070 100644
--- a/drivers/phy/allwinner/phy-sun50i-usb3.c
+++ b/drivers/phy/allwinner/phy-sun50i-usb3.c
@@ -140,11 +140,8 @@ static int sun50i_usb3_phy_probe(struct platform_device *pdev)
 		return -ENOMEM;

 	phy->clk = devm_clk_get(dev, NULL);
-	if (IS_ERR(phy->clk)) {
-		if (PTR_ERR(phy->clk) != -EPROBE_DEFER)
-			dev_err(dev, "failed to get phy clock\n");
-		return PTR_ERR(phy->clk);
-	}
+	if (IS_ERR(phy->clk))
+		return dev_err_probe(dev, PTR_ERR(phy->clk), "failed to get phy clock\n");

 	phy->reset = devm_reset_control_get(dev, NULL);
 	if (IS_ERR(phy->reset)) {
-- 
2.25.1

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] phy: allwinner: Use dev_err_probe()
  2023-03-23  7:42 ` ye.xingchen
  (?)
@ 2023-03-23 18:47   ` Jernej Škrabec
  -1 siblings, 0 replies; 6+ messages in thread
From: Jernej Škrabec @ 2023-03-23 18:47 UTC (permalink / raw)
  To: vkoul, ye.xingchen
  Cc: kishon, wens, samuel, linux-phy, linux-arm-kernel, linux-sunxi,
	linux-kernel

Dne četrtek, 23. marec 2023 ob 08:42:12 CET je ye.xingchen@zte.com.cn 
napisal(a):
> From: Ye Xingchen <ye.xingchen@zte.com.cn>
> 
> Replace the open-code with dev_err_probe() to simplify the code.
> 
> Signed-off-by: Ye Xingchen <ye.xingchen@zte.com.cn>

Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>

Best regards,
Jernej



^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] phy: allwinner: Use dev_err_probe()
@ 2023-03-23 18:47   ` Jernej Škrabec
  0 siblings, 0 replies; 6+ messages in thread
From: Jernej Škrabec @ 2023-03-23 18:47 UTC (permalink / raw)
  To: vkoul, ye.xingchen
  Cc: kishon, wens, samuel, linux-phy, linux-arm-kernel, linux-sunxi,
	linux-kernel

Dne četrtek, 23. marec 2023 ob 08:42:12 CET je ye.xingchen@zte.com.cn 
napisal(a):
> From: Ye Xingchen <ye.xingchen@zte.com.cn>
> 
> Replace the open-code with dev_err_probe() to simplify the code.
> 
> Signed-off-by: Ye Xingchen <ye.xingchen@zte.com.cn>

Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>

Best regards,
Jernej



-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] phy: allwinner: Use dev_err_probe()
@ 2023-03-23 18:47   ` Jernej Škrabec
  0 siblings, 0 replies; 6+ messages in thread
From: Jernej Škrabec @ 2023-03-23 18:47 UTC (permalink / raw)
  To: vkoul, ye.xingchen
  Cc: kishon, wens, samuel, linux-phy, linux-arm-kernel, linux-sunxi,
	linux-kernel

Dne četrtek, 23. marec 2023 ob 08:42:12 CET je ye.xingchen@zte.com.cn 
napisal(a):
> From: Ye Xingchen <ye.xingchen@zte.com.cn>
> 
> Replace the open-code with dev_err_probe() to simplify the code.
> 
> Signed-off-by: Ye Xingchen <ye.xingchen@zte.com.cn>

Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>

Best regards,
Jernej



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-03-23 18:48 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-23  7:42 [PATCH] phy: allwinner: Use dev_err_probe() ye.xingchen
2023-03-23  7:42 ` ye.xingchen
2023-03-23  7:42 ` ye.xingchen
2023-03-23 18:47 ` Jernej Škrabec
2023-03-23 18:47   ` Jernej Škrabec
2023-03-23 18:47   ` Jernej Škrabec

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.