* [igt-dev] [i-g-t 0/5] Enable ADDFB tests for XE
@ 2023-03-20 10:00 Bhanuprakash Modem
2023-03-20 10:00 ` [igt-dev] [i-g-t 1/5] lib/xe/xe_ioctl: Add a helper to map the buffer Bhanuprakash Modem
` (7 more replies)
0 siblings, 8 replies; 17+ messages in thread
From: Bhanuprakash Modem @ 2023-03-20 10:00 UTC (permalink / raw)
To: igt-dev, zbigniew.kempczynski, mchehab, jani.nikula
Add IGT support to enable ADDFB tests to XE BAT.
Bhanuprakash Modem (5):
lib/xe/xe_ioctl: Add a helper to map the buffer
lib/igt_fb: Add support for allocating buffers for XE
tests/kms_addfb_basic: Add XE support
tests/kms_force_connector_basic: Add XE support
xe-fast-feedback: Add basic kms tests to XE BAT
lib/igt_fb.c | 16 +++++++--
lib/xe/xe_ioctl.c | 14 ++++++--
lib/xe/xe_ioctl.h | 1 +
tests/intel-ci/xe-fast-feedback.testlist | 30 +++++++++++++++++
tests/kms_addfb_basic.c | 42 ++++++++++++++++--------
tests/kms_force_connector_basic.c | 4 ++-
6 files changed, 87 insertions(+), 20 deletions(-)
--
2.40.0
^ permalink raw reply [flat|nested] 17+ messages in thread
* [igt-dev] [i-g-t 1/5] lib/xe/xe_ioctl: Add a helper to map the buffer
2023-03-20 10:00 [igt-dev] [i-g-t 0/5] Enable ADDFB tests for XE Bhanuprakash Modem
@ 2023-03-20 10:00 ` Bhanuprakash Modem
2023-03-20 14:28 ` Das, Nirmoy
2023-03-23 18:57 ` Zbigniew Kempczyński
2023-03-20 10:00 ` [igt-dev] [i-g-t 2/5] lib/igt_fb: Add support for allocating buffers for XE Bhanuprakash Modem
` (6 subsequent siblings)
7 siblings, 2 replies; 17+ messages in thread
From: Bhanuprakash Modem @ 2023-03-20 10:00 UTC (permalink / raw)
To: igt-dev, zbigniew.kempczynski, mchehab, jani.nikula
Create a new helper to map the buffer with the user PROT flags.
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
lib/xe/xe_ioctl.c | 14 ++++++++++++--
lib/xe/xe_ioctl.h | 1 +
2 files changed, 13 insertions(+), 2 deletions(-)
diff --git a/lib/xe/xe_ioctl.c b/lib/xe/xe_ioctl.c
index 9d5793dff..66a8393fe 100644
--- a/lib/xe/xe_ioctl.c
+++ b/lib/xe/xe_ioctl.c
@@ -334,18 +334,28 @@ uint64_t xe_bo_mmap_offset(int fd, uint32_t bo)
return mmo.offset;
}
-void *xe_bo_map(int fd, uint32_t bo, size_t size)
+static void *__xe_bo_map(int fd, uint16_t bo, size_t size, int prot)
{
uint64_t mmo;
void *map;
mmo = xe_bo_mmap_offset(fd, bo);
- map = mmap(NULL, size, PROT_WRITE, MAP_SHARED, fd, mmo);
+ map = mmap(NULL, size, prot, MAP_SHARED, fd, mmo);
igt_assert(map != MAP_FAILED);
return map;
}
+void *xe_bo_map(int fd, uint32_t bo, size_t size)
+{
+ return __xe_bo_map(fd, bo, size, PROT_WRITE);
+}
+
+void *xe_bo_mmap_ext(int fd, uint32_t bo, size_t size, int prot)
+{
+ return __xe_bo_map(fd, bo, size, prot);
+}
+
static int __xe_exec(int fd, struct drm_xe_exec *exec)
{
int err = 0;
diff --git a/lib/xe/xe_ioctl.h b/lib/xe/xe_ioctl.h
index 5c7e773fa..d8c40eda0 100644
--- a/lib/xe/xe_ioctl.h
+++ b/lib/xe/xe_ioctl.h
@@ -73,6 +73,7 @@ uint32_t xe_engine_create_class(int fd, uint32_t vm, uint16_t class);
void xe_engine_destroy(int fd, uint32_t engine);
uint64_t xe_bo_mmap_offset(int fd, uint32_t bo);
void *xe_bo_map(int fd, uint32_t bo, size_t size);
+void *xe_bo_mmap_ext(int fd, uint32_t bo, size_t size, int prot);
void xe_exec(int fd, struct drm_xe_exec *exec);
void xe_exec_sync(int fd, uint32_t engine, uint64_t addr,
struct drm_xe_sync *sync, uint32_t num_syncs);
--
2.40.0
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [igt-dev] [i-g-t 2/5] lib/igt_fb: Add support for allocating buffers for XE
2023-03-20 10:00 [igt-dev] [i-g-t 0/5] Enable ADDFB tests for XE Bhanuprakash Modem
2023-03-20 10:00 ` [igt-dev] [i-g-t 1/5] lib/xe/xe_ioctl: Add a helper to map the buffer Bhanuprakash Modem
@ 2023-03-20 10:00 ` Bhanuprakash Modem
2023-03-23 19:01 ` Zbigniew Kempczyński
2023-03-20 10:00 ` [igt-dev] [i-g-t 3/5] tests/kms_addfb_basic: Add XE support Bhanuprakash Modem
` (5 subsequent siblings)
7 siblings, 1 reply; 17+ messages in thread
From: Bhanuprakash Modem @ 2023-03-20 10:00 UTC (permalink / raw)
To: igt-dev, zbigniew.kempczynski, mchehab, jani.nikula
Add support to create a buffer object to the XE driver.
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
lib/igt_fb.c | 16 +++++++++++++---
1 file changed, 13 insertions(+), 3 deletions(-)
diff --git a/lib/igt_fb.c b/lib/igt_fb.c
index ba89e1f60..63f8923dc 100644
--- a/lib/igt_fb.c
+++ b/lib/igt_fb.c
@@ -49,6 +49,8 @@
#include "intel_batchbuffer.h"
#include "intel_chipset.h"
#include "intel_bufops.h"
+#include "xe/xe_ioctl.h"
+#include "xe/xe_query.h"
/**
* SECTION:igt_fb
@@ -434,7 +436,7 @@ void igt_get_fb_tile_size(int fd, uint64_t modifier, int fb_bpp,
switch (modifier) {
case DRM_FORMAT_MOD_LINEAR :
- if (is_i915_device(fd))
+ if (is_intel_device(fd))
*width_ret = 64;
else
*width_ret = 1;
@@ -924,6 +926,9 @@ static uint64_t calc_fb_size(struct igt_fb *fb)
size += calc_plane_size(fb, plane);
}
+ if (is_xe_device(fb->fd))
+ size = ALIGN(size, xe_get_default_alignment(fb->fd));
+
return size;
}
@@ -1143,8 +1148,8 @@ static int create_bo_for_fb(struct igt_fb *fb, bool prefer_sysmem)
* them, so we need to make sure to use a device BO then.
*/
if (fb->modifier || fb->size || fb->strides[0] ||
- (is_i915_device(fd) && igt_format_is_yuv(fb->drm_format)) ||
- (is_i915_device(fd) && igt_format_is_fp16(fb->drm_format)) ||
+ (is_intel_device(fd) && igt_format_is_yuv(fb->drm_format)) ||
+ (is_intel_device(fd) && igt_format_is_fp16(fb->drm_format)) ||
(is_amdgpu_device(fd) && igt_format_is_yuv(fb->drm_format)) ||
is_nouveau_device(fd))
device_bo = true;
@@ -1168,6 +1173,11 @@ static int create_bo_for_fb(struct igt_fb *fb, bool prefer_sysmem)
fb->strides[0]);
/* If we can't use fences, we won't use ggtt detiling later. */
igt_assert(err == 0 || err == -EOPNOTSUPP);
+ } else if (is_xe_device(fd)) {
+ fb->gem_handle = xe_bo_create_flags(fd, 0, fb->size,
+ xe_has_vram(fd) ?
+ vram_memory(fd, 0) :
+ system_memory(fd));
} else if (is_vc4_device(fd)) {
fb->gem_handle = igt_vc4_create_bo(fd, fb->size);
--
2.40.0
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [igt-dev] [i-g-t 3/5] tests/kms_addfb_basic: Add XE support
2023-03-20 10:00 [igt-dev] [i-g-t 0/5] Enable ADDFB tests for XE Bhanuprakash Modem
2023-03-20 10:00 ` [igt-dev] [i-g-t 1/5] lib/xe/xe_ioctl: Add a helper to map the buffer Bhanuprakash Modem
2023-03-20 10:00 ` [igt-dev] [i-g-t 2/5] lib/igt_fb: Add support for allocating buffers for XE Bhanuprakash Modem
@ 2023-03-20 10:00 ` Bhanuprakash Modem
2023-03-22 8:49 ` Kamil Konieczny
2023-03-23 19:04 ` Zbigniew Kempczyński
2023-03-20 10:00 ` [igt-dev] [i-g-t 4/5] tests/kms_force_connector_basic: " Bhanuprakash Modem
` (4 subsequent siblings)
7 siblings, 2 replies; 17+ messages in thread
From: Bhanuprakash Modem @ 2023-03-20 10:00 UTC (permalink / raw)
To: igt-dev, zbigniew.kempczynski, mchehab, jani.nikula
Add XE driver support for kms tests.
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
tests/kms_addfb_basic.c | 42 +++++++++++++++++++++++++++--------------
1 file changed, 28 insertions(+), 14 deletions(-)
diff --git a/tests/kms_addfb_basic.c b/tests/kms_addfb_basic.c
index b4526eee6..bf90a9aa1 100644
--- a/tests/kms_addfb_basic.c
+++ b/tests/kms_addfb_basic.c
@@ -41,6 +41,8 @@
#include "igt_rand.h"
#include "igt_device.h"
#include "i915/intel_memory_region.h"
+#include "xe/xe_ioctl.h"
+#include "xe/xe_query.h"
uint32_t gem_bo;
uint32_t gem_bo_small;
@@ -121,7 +123,7 @@ static void invalid_tests(int fd)
igt_describe("Check if addfb2 call works for clobbered modifier");
igt_subtest("clobberred-modifier") {
- igt_require_intel(fd);
+ igt_require_i915(fd);
igt_require(gem_available_fences(fd) > 0);
f.flags = 0;
f.modifier[0] = 0;
@@ -139,10 +141,17 @@ static void invalid_tests(int fd)
uint64_t size;
igt_require_intel(fd);
- igt_require(gem_has_lmem(fd));
igt_calc_fb_size(fd, f.width, f.height,
DRM_FORMAT_XRGB8888, 0, &size, &stride);
- handle = gem_create_in_memory_regions(fd, size, REGION_SMEM);
+
+ if (is_i915_device(fd)) {
+ igt_require(gem_has_lmem(fd));
+ handle = gem_create_in_memory_regions(fd, size, REGION_SMEM);
+ } else {
+ igt_require(xe_has_vram(fd));
+ handle = xe_bo_create_flags(fd, 0, size, vram_memory(fd, 0));
+ }
+
f.handles[0] = handle;
do_ioctl_err(fd, DRM_IOCTL_MODE_ADDFB2, &f, EREMOTE);
}
@@ -323,7 +332,7 @@ static void tiling_tests(int fd)
igt_subtest_group {
igt_fixture {
- igt_require_intel(fd);
+ igt_require_i915(fd);
tiled_x_bo = igt_create_bo_with_dimensions(fd, 1024, 1024,
DRM_FORMAT_XRGB8888, I915_FORMAT_MOD_X_TILED,
1024*4, NULL, NULL, NULL);
@@ -494,7 +503,7 @@ static void size_tests(int fd)
igt_describe("Test that addfb2 call fails correctly with small buffer object after changing tile");
igt_subtest("bo-too-small-due-to-tiling") {
- igt_require_intel(fd);
+ igt_require_i915(fd);
igt_require(gem_available_fences(fd) > 0);
gem_set_tiling(fd, gem_bo_small, I915_TILING_X, 1024*4);
do_ioctl_err(fd, DRM_IOCTL_MODE_ADDFB2, &f, EINVAL);
@@ -548,7 +557,7 @@ static void addfb25_tests(int fd)
igt_subtest_group {
igt_fixture {
- igt_require_intel(fd);
+ igt_require_i915(fd);
igt_require(gem_available_fences(fd) > 0);
gem_set_tiling(fd, gem_bo, I915_TILING_X, 1024*4);
igt_require_fb_modifiers(fd);
@@ -594,6 +603,7 @@ static void addfb25_ytile(int fd)
igt_display_t display;
igt_fixture {
+ igt_require_i915(fd);
igt_display_require(&display, fd);
gem_bo = igt_create_bo_with_dimensions(fd, 1024, 1024,
@@ -618,7 +628,6 @@ static void addfb25_ytile(int fd)
igt_describe("Check if addfb2 call works for y-tiling");
igt_subtest("addfb25-y-tiled-legacy") {
igt_require_fb_modifiers(fd);
- igt_require_intel(fd);
f.modifier[0] = I915_FORMAT_MOD_Y_TILED;
igt_assert_eq(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f),
@@ -631,7 +640,6 @@ static void addfb25_ytile(int fd)
igt_describe("Check if addfb2 call works for yf-tiling");
igt_subtest("addfb25-yf-tiled-legacy") {
igt_require_fb_modifiers(fd);
- igt_require_intel(fd);
f.modifier[0] = I915_FORMAT_MOD_Yf_TILED;
igt_assert_eq(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f),
@@ -644,7 +652,6 @@ static void addfb25_ytile(int fd)
igt_describe("Test that addfb2 call fails correctly for y-tiling with given height and modifier");
igt_subtest("addfb25-y-tiled-small-legacy") {
igt_require_fb_modifiers(fd);
- igt_require_intel(fd);
f.modifier[0] = I915_FORMAT_MOD_Y_TILED;
f.height = 1023;
@@ -667,6 +674,7 @@ static void addfb25_4tile(int fd)
igt_display_t display;
igt_fixture {
+ igt_require_i915(fd);
igt_display_require(&display, fd);
gem_bo = igt_create_bo_with_dimensions(fd, 1024, 1024,
@@ -689,7 +697,6 @@ static void addfb25_4tile(int fd)
igt_describe("Check if addfb2 call works for tiling-4");
igt_subtest("addfb25-4-tiled") {
igt_require_fb_modifiers(fd);
- igt_require_intel(fd);
f.modifier[0] = I915_FORMAT_MOD_4_TILED;
igt_assert_eq(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f),
@@ -839,6 +846,9 @@ igt_main
igt_fixture {
fd = drm_open_driver_master(DRIVER_ANY);
igt_require(has_addfb2_iface(fd));
+
+ if (is_xe_device(fd))
+ xe_device_get(fd);
}
invalid_tests(fd);
@@ -847,6 +857,10 @@ igt_main
size_tests(fd);
+ prop_tests(fd);
+
+ master_tests(fd);
+
addfb25_tests(fd);
addfb25_ytile(fd);
@@ -855,10 +869,10 @@ igt_main
tiling_tests(fd);
- prop_tests(fd);
-
- master_tests(fd);
+ igt_fixture {
+ if (is_xe_device(fd))
+ xe_device_put(fd);
- igt_fixture
close(fd);
+ }
}
--
2.40.0
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [igt-dev] [i-g-t 4/5] tests/kms_force_connector_basic: Add XE support
2023-03-20 10:00 [igt-dev] [i-g-t 0/5] Enable ADDFB tests for XE Bhanuprakash Modem
` (2 preceding siblings ...)
2023-03-20 10:00 ` [igt-dev] [i-g-t 3/5] tests/kms_addfb_basic: Add XE support Bhanuprakash Modem
@ 2023-03-20 10:00 ` Bhanuprakash Modem
2023-03-23 19:06 ` Zbigniew Kempczyński
2023-03-20 10:00 ` [igt-dev] [i-g-t 5/5] xe-fast-feedback: Add basic kms tests to XE BAT Bhanuprakash Modem
` (3 subsequent siblings)
7 siblings, 1 reply; 17+ messages in thread
From: Bhanuprakash Modem @ 2023-03-20 10:00 UTC (permalink / raw)
To: igt-dev, zbigniew.kempczynski, mchehab, jani.nikula
Add XE driver support for kms tests.
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
tests/kms_force_connector_basic.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tests/kms_force_connector_basic.c b/tests/kms_force_connector_basic.c
index 4ff1efe3b..6a13fe4ed 100644
--- a/tests/kms_force_connector_basic.c
+++ b/tests/kms_force_connector_basic.c
@@ -53,7 +53,9 @@ static void reset_connectors(void)
drmModeFreeConnector(connector);
}
- igt_set_module_param_int(drm_fd, "load_detect_test", 0);
+ /* FIXME: load_detect_test is not found in XE. */
+ if (is_i915_device(drm_fd))
+ igt_set_module_param_int(drm_fd, "load_detect_test", 0);
close(drm_fd);
}
--
2.40.0
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [igt-dev] [i-g-t 5/5] xe-fast-feedback: Add basic kms tests to XE BAT
2023-03-20 10:00 [igt-dev] [i-g-t 0/5] Enable ADDFB tests for XE Bhanuprakash Modem
` (3 preceding siblings ...)
2023-03-20 10:00 ` [igt-dev] [i-g-t 4/5] tests/kms_force_connector_basic: " Bhanuprakash Modem
@ 2023-03-20 10:00 ` Bhanuprakash Modem
2023-03-20 13:43 ` [igt-dev] ✗ Fi.CI.BAT: failure for Enable ADDFB tests for XE Patchwork
` (2 subsequent siblings)
7 siblings, 0 replies; 17+ messages in thread
From: Bhanuprakash Modem @ 2023-03-20 10:00 UTC (permalink / raw)
To: igt-dev, zbigniew.kempczynski, mchehab, jani.nikula
Add display's connector detect, addfb2 and prop tests to XE BAT.
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
tests/intel-ci/xe-fast-feedback.testlist | 30 ++++++++++++++++++++++++
1 file changed, 30 insertions(+)
diff --git a/tests/intel-ci/xe-fast-feedback.testlist b/tests/intel-ci/xe-fast-feedback.testlist
index 6525b1676..96faa3400 100644
--- a/tests/intel-ci/xe-fast-feedback.testlist
+++ b/tests/intel-ci/xe-fast-feedback.testlist
@@ -137,3 +137,33 @@ igt@xe_vm@munmap-style-unbind-userptr-front
igt@xe_vm@munmap-style-unbind-userptr-inval-end
igt@xe_vm@munmap-style-unbind-userptr-inval-front
igt@xe_waitfence@test
+igt@kms_addfb_basic@addfb25-bad-modifier
+igt@kms_addfb_basic@addfb25-modifier-no-flag
+igt@kms_addfb_basic@bad-pitch-0
+igt@kms_addfb_basic@bad-pitch-1024
+igt@kms_addfb_basic@bad-pitch-128
+igt@kms_addfb_basic@bad-pitch-256
+igt@kms_addfb_basic@bad-pitch-32
+igt@kms_addfb_basic@bad-pitch-63
+igt@kms_addfb_basic@bad-pitch-65536
+igt@kms_addfb_basic@bad-pitch-999
+igt@kms_addfb_basic@basic
+igt@kms_addfb_basic@bo-too-small
+igt@kms_addfb_basic@invalid-get-prop
+igt@kms_addfb_basic@invalid-get-prop-any
+igt@kms_addfb_basic@invalid-set-prop
+igt@kms_addfb_basic@invalid-set-prop-any
+igt@kms_addfb_basic@no-handle
+igt@kms_addfb_basic@size-max
+igt@kms_addfb_basic@small-bo
+igt@kms_addfb_basic@too-high
+igt@kms_addfb_basic@too-wide
+igt@kms_addfb_basic@unused-handle
+igt@kms_addfb_basic@unused-modifier
+igt@kms_addfb_basic@unused-offsets
+igt@kms_addfb_basic@unused-pitches
+igt@kms_force_connector_basic@force-connector-state
+igt@kms_force_connector_basic@force-edid
+igt@kms_force_connector_basic@force-load-detect
+igt@kms_force_connector_basic@prune-stale-modes
+igt@kms_prop_blob@basic
--
2.40.0
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [igt-dev] ✗ Fi.CI.BAT: failure for Enable ADDFB tests for XE
2023-03-20 10:00 [igt-dev] [i-g-t 0/5] Enable ADDFB tests for XE Bhanuprakash Modem
` (4 preceding siblings ...)
2023-03-20 10:00 ` [igt-dev] [i-g-t 5/5] xe-fast-feedback: Add basic kms tests to XE BAT Bhanuprakash Modem
@ 2023-03-20 13:43 ` Patchwork
2023-03-20 14:40 ` [igt-dev] ✓ Fi.CI.BAT: success for Enable ADDFB tests for XE (rev2) Patchwork
2023-03-20 17:29 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
7 siblings, 0 replies; 17+ messages in thread
From: Patchwork @ 2023-03-20 13:43 UTC (permalink / raw)
To: Modem, Bhanuprakash; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 12766 bytes --]
== Series Details ==
Series: Enable ADDFB tests for XE
URL : https://patchwork.freedesktop.org/series/115381/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12883 -> IGTPW_8643
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_8643 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_8643, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8643/index.html
Participating hosts (34 -> 36)
------------------------------
Additional (2): fi-kbl-soraka bat-atsm-1
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_8643:
### IGT changes ###
#### Possible regressions ####
* igt@gem_busy@busy@all-engines:
- bat-rpls-1: [PASS][1] -> [TIMEOUT][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12883/bat-rpls-1/igt@gem_busy@busy@all-engines.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8643/bat-rpls-1/igt@gem_busy@busy@all-engines.html
Known issues
------------
Here are the changes found in IGTPW_8643 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@fbdev@eof:
- bat-atsm-1: NOTRUN -> [SKIP][3] ([i915#2582]) +4 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8643/bat-atsm-1/igt@fbdev@eof.html
* igt@gem_huc_copy@huc-copy:
- fi-kbl-soraka: NOTRUN -> [SKIP][4] ([fdo#109271] / [i915#2190])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8643/fi-kbl-soraka/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@basic:
- fi-kbl-soraka: NOTRUN -> [SKIP][5] ([fdo#109271] / [i915#4613]) +3 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8643/fi-kbl-soraka/igt@gem_lmem_swapping@basic.html
* igt@gem_mmap@basic:
- bat-atsm-1: NOTRUN -> [SKIP][6] ([i915#4083])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8643/bat-atsm-1/igt@gem_mmap@basic.html
* igt@gem_tiled_fence_blits@basic:
- bat-atsm-1: NOTRUN -> [SKIP][7] ([i915#4077]) +2 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8643/bat-atsm-1/igt@gem_tiled_fence_blits@basic.html
* igt@gem_tiled_pread_basic:
- bat-atsm-1: NOTRUN -> [SKIP][8] ([i915#4079]) +1 similar issue
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8643/bat-atsm-1/igt@gem_tiled_pread_basic.html
* igt@i915_pm_rps@basic-api:
- bat-atsm-1: NOTRUN -> [SKIP][9] ([i915#6621])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8643/bat-atsm-1/igt@i915_pm_rps@basic-api.html
* igt@i915_selftest@live@gt_lrc:
- bat-adln-1: [PASS][10] -> [INCOMPLETE][11] ([i915#4983] / [i915#7609])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12883/bat-adln-1/igt@i915_selftest@live@gt_lrc.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8643/bat-adln-1/igt@i915_selftest@live@gt_lrc.html
* igt@i915_selftest@live@gt_pm:
- fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][12] ([i915#1886])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8643/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html
* igt@i915_suspend@basic-s3-without-i915:
- bat-atsm-1: NOTRUN -> [SKIP][13] ([i915#6645])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8643/bat-atsm-1/igt@i915_suspend@basic-s3-without-i915.html
* igt@kms_addfb_basic@size-max:
- bat-atsm-1: NOTRUN -> [SKIP][14] ([i915#6077]) +36 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8643/bat-atsm-1/igt@kms_addfb_basic@size-max.html
* igt@kms_chamelium_frames@hdmi-crc-fast:
- fi-kbl-soraka: NOTRUN -> [SKIP][15] ([fdo#109271]) +16 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8643/fi-kbl-soraka/igt@kms_chamelium_frames@hdmi-crc-fast.html
* igt@kms_cursor_legacy@basic-flip-after-cursor-atomic:
- bat-atsm-1: NOTRUN -> [SKIP][16] ([i915#6078]) +19 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8643/bat-atsm-1/igt@kms_cursor_legacy@basic-flip-after-cursor-atomic.html
* igt@kms_flip@basic-plain-flip:
- bat-atsm-1: NOTRUN -> [SKIP][17] ([i915#6166]) +3 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8643/bat-atsm-1/igt@kms_flip@basic-plain-flip.html
* igt@kms_force_connector_basic@prune-stale-modes:
- bat-atsm-1: NOTRUN -> [SKIP][18] ([i915#6093]) +3 similar issues
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8643/bat-atsm-1/igt@kms_force_connector_basic@prune-stale-modes.html
* igt@kms_pipe_crc_basic@hang-read-crc:
- bat-atsm-1: NOTRUN -> [SKIP][19] ([i915#1836]) +6 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8643/bat-atsm-1/igt@kms_pipe_crc_basic@hang-read-crc.html
* igt@kms_prop_blob@basic:
- bat-atsm-1: NOTRUN -> [SKIP][20] ([i915#7357])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8643/bat-atsm-1/igt@kms_prop_blob@basic.html
* igt@kms_psr@sprite_plane_onoff:
- bat-atsm-1: NOTRUN -> [SKIP][21] ([i915#1072]) +3 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8643/bat-atsm-1/igt@kms_psr@sprite_plane_onoff.html
* igt@kms_setmode@basic-clone-single-crtc:
- bat-atsm-1: NOTRUN -> [SKIP][22] ([i915#6094])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8643/bat-atsm-1/igt@kms_setmode@basic-clone-single-crtc.html
* igt@prime_vgem@basic-fence-flip:
- bat-atsm-1: NOTRUN -> [SKIP][23] ([fdo#109295] / [i915#6078])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8643/bat-atsm-1/igt@prime_vgem@basic-fence-flip.html
* igt@prime_vgem@basic-fence-mmap:
- bat-atsm-1: NOTRUN -> [SKIP][24] ([fdo#109295] / [i915#4077]) +1 similar issue
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8643/bat-atsm-1/igt@prime_vgem@basic-fence-mmap.html
* igt@prime_vgem@basic-write:
- bat-atsm-1: NOTRUN -> [SKIP][25] ([fdo#109295]) +3 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8643/bat-atsm-1/igt@prime_vgem@basic-write.html
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1836]: https://gitlab.freedesktop.org/drm/intel/issues/1836
[i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#6077]: https://gitlab.freedesktop.org/drm/intel/issues/6077
[i915#6078]: https://gitlab.freedesktop.org/drm/intel/issues/6078
[i915#6093]: https://gitlab.freedesktop.org/drm/intel/issues/6093
[i915#6094]: https://gitlab.freedesktop.org/drm/intel/issues/6094
[i915#6166]: https://gitlab.freedesktop.org/drm/intel/issues/6166
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6645]: https://gitlab.freedesktop.org/drm/intel/issues/6645
[i915#7357]: https://gitlab.freedesktop.org/drm/intel/issues/7357
[i915#7609]: https://gitlab.freedesktop.org/drm/intel/issues/7609
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7207 -> IGTPW_8643
CI-20190529: 20190529
CI_DRM_12883: 5619fa2b4a9b93019f6ca27a2f391fc39e152993 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_8643: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8643/index.html
IGT_7207: 51001c91c367464da9e700e617fb712b3b1cecfd @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Testlist changes
----------------
+igt@gem_userptr_blits@access-control
+igt@gem_userptr_blits@coherency-sync
+igt@gem_userptr_blits@coherency-unsync
+igt@gem_userptr_blits@create-destroy-sync
+igt@gem_userptr_blits@create-destroy-unsync
+igt@gem_userptr_blits@dmabuf-sync
+igt@gem_userptr_blits@dmabuf-unsync
+igt@gem_userptr_blits@forbidden-operations
+igt@gem_userptr_blits@forked-access
+igt@gem_userptr_blits@forked-sync-interruptible
+igt@gem_userptr_blits@forked-sync-mempressure-interruptible
+igt@gem_userptr_blits@forked-sync-mempressure-normal
+igt@gem_userptr_blits@forked-sync-multifd-interruptible
+igt@gem_userptr_blits@forked-sync-multifd-mempressure-interruptible
+igt@gem_userptr_blits@forked-sync-multifd-mempressure-normal
+igt@gem_userptr_blits@forked-sync-multifd-normal
+igt@gem_userptr_blits@forked-sync-normal
+igt@gem_userptr_blits@forked-sync-swapping-interruptible
+igt@gem_userptr_blits@forked-sync-swapping-mempressure-interruptible
+igt@gem_userptr_blits@forked-sync-swapping-mempressure-normal
+igt@gem_userptr_blits@forked-sync-swapping-multifd-interruptible
+igt@gem_userptr_blits@forked-sync-swapping-multifd-mempressure-interruptible
+igt@gem_userptr_blits@forked-sync-swapping-multifd-mempressure-normal
+igt@gem_userptr_blits@forked-sync-swapping-multifd-normal
+igt@gem_userptr_blits@forked-sync-swapping-normal
+igt@gem_userptr_blits@forked-unsync-interruptible
+igt@gem_userptr_blits@forked-unsync-mempressure-interruptible
+igt@gem_userptr_blits@forked-unsync-mempressure-normal
+igt@gem_userptr_blits@forked-unsync-multifd-interruptible
+igt@gem_userptr_blits@forked-unsync-multifd-mempressure-interruptible
+igt@gem_userptr_blits@forked-unsync-multifd-mempressure-normal
+igt@gem_userptr_blits@forked-unsync-multifd-normal
+igt@gem_userptr_blits@forked-unsync-normal
+igt@gem_userptr_blits@forked-unsync-swapping-interruptible
+igt@gem_userptr_blits@forked-unsync-swapping-mempressure-interruptible
+igt@gem_userptr_blits@forked-unsync-swapping-mempressure-normal
+igt@gem_userptr_blits@forked-unsync-swapping-multifd-interruptible
+igt@gem_userptr_blits@forked-unsync-swapping-multifd-mempressure-interruptible
+igt@gem_userptr_blits@forked-unsync-swapping-multifd-mempressure-normal
+igt@gem_userptr_blits@forked-unsync-swapping-multifd-normal
+igt@gem_userptr_blits@forked-unsync-swapping-normal
+igt@gem_userptr_blits@huge-split
+igt@gem_userptr_blits@input-checking
+igt@gem_userptr_blits@invalid-mmap-offset-unsync
+igt@gem_userptr_blits@invalid-null-pointer
+igt@gem_userptr_blits@major-normal-sync
+igt@gem_userptr_blits@major-sync-interruptible
+igt@gem_userptr_blits@major-unsync-interruptible
+igt@gem_userptr_blits@major-unsync-normal
+igt@gem_userptr_blits@map-fixed-invalidate
+igt@gem_userptr_blits@map-fixed-invalidate-busy
+igt@gem_userptr_blits@map-fixed-invalidate-overlap
+igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy
+igt@gem_userptr_blits@minor-normal-sync
+igt@gem_userptr_blits@minor-sync-interruptible
+igt@gem_userptr_blits@minor-unsync-interruptible
+igt@gem_userptr_blits@minor-unsync-normal
+igt@gem_userptr_blits@mlocked-normal-sync
+igt@gem_userptr_blits@mlocked-sync-interruptible
+igt@gem_userptr_blits@mlocked-unsync-interruptible
+igt@gem_userptr_blits@mlocked-unsync-normal
+igt@gem_userptr_blits@mmap-offset-banned
+igt@gem_userptr_blits@nohangcheck
+igt@gem_userptr_blits@probe
+igt@gem_userptr_blits@process-exit
+igt@gem_userptr_blits@process-exit-busy
+igt@gem_userptr_blits@readonly-pwrite-unsync
+igt@gem_userptr_blits@readonly-unsync
+igt@gem_userptr_blits@relocations
+igt@gem_userptr_blits@sd-probe
+igt@gem_userptr_blits@set-cache-level
+igt@gem_userptr_blits@stress-mm
+igt@gem_userptr_blits@stress-mm-invalidate-close
+igt@gem_userptr_blits@stress-mm-invalidate-close-overlap
+igt@gem_userptr_blits@stress-purge
+igt@gem_userptr_blits@swapping-normal-sync
+igt@gem_userptr_blits@swapping-sync-interruptible
+igt@gem_userptr_blits@swapping-unsync-interruptible
+igt@gem_userptr_blits@swapping-unsync-normal
+igt@gem_userptr_blits@sync-overlap
+igt@gem_userptr_blits@sync-unmap
+igt@gem_userptr_blits@sync-unmap-after-close
+igt@gem_userptr_blits@sync-unmap-cycles
+igt@gem_userptr_blits@unsync-overlap
+igt@gem_userptr_blits@unsync-unmap
+igt@gem_userptr_blits@unsync-unmap-after-close
+igt@gem_userptr_blits@unsync-unmap-cycles
+igt@gem_userptr_blits@usage-restrictions
+igt@gem_userptr_blits@userfault
+igt@gem_userptr_blits@vma-merge
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8643/index.html
[-- Attachment #2: Type: text/html, Size: 14875 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [igt-dev] [i-g-t 1/5] lib/xe/xe_ioctl: Add a helper to map the buffer
2023-03-20 10:00 ` [igt-dev] [i-g-t 1/5] lib/xe/xe_ioctl: Add a helper to map the buffer Bhanuprakash Modem
@ 2023-03-20 14:28 ` Das, Nirmoy
2023-03-23 18:57 ` Zbigniew Kempczyński
1 sibling, 0 replies; 17+ messages in thread
From: Das, Nirmoy @ 2023-03-20 14:28 UTC (permalink / raw)
To: Bhanuprakash Modem, igt-dev, zbigniew.kempczynski, mchehab, jani.nikula
On 3/20/2023 11:00 AM, Bhanuprakash Modem wrote:
> Create a new helper to map the buffer with the user PROT flags.
>
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Looks good to me. The series is Acked-by: Nirmoy Das <nirmoy.das@intel.com>
> ---
> lib/xe/xe_ioctl.c | 14 ++++++++++++--
> lib/xe/xe_ioctl.h | 1 +
> 2 files changed, 13 insertions(+), 2 deletions(-)
>
> diff --git a/lib/xe/xe_ioctl.c b/lib/xe/xe_ioctl.c
> index 9d5793dff..66a8393fe 100644
> --- a/lib/xe/xe_ioctl.c
> +++ b/lib/xe/xe_ioctl.c
> @@ -334,18 +334,28 @@ uint64_t xe_bo_mmap_offset(int fd, uint32_t bo)
> return mmo.offset;
> }
>
> -void *xe_bo_map(int fd, uint32_t bo, size_t size)
> +static void *__xe_bo_map(int fd, uint16_t bo, size_t size, int prot)
> {
> uint64_t mmo;
> void *map;
>
> mmo = xe_bo_mmap_offset(fd, bo);
> - map = mmap(NULL, size, PROT_WRITE, MAP_SHARED, fd, mmo);
> + map = mmap(NULL, size, prot, MAP_SHARED, fd, mmo);
> igt_assert(map != MAP_FAILED);
>
> return map;
> }
>
> +void *xe_bo_map(int fd, uint32_t bo, size_t size)
> +{
> + return __xe_bo_map(fd, bo, size, PROT_WRITE);
> +}
> +
> +void *xe_bo_mmap_ext(int fd, uint32_t bo, size_t size, int prot)
> +{
> + return __xe_bo_map(fd, bo, size, prot);
> +}
> +
> static int __xe_exec(int fd, struct drm_xe_exec *exec)
> {
> int err = 0;
> diff --git a/lib/xe/xe_ioctl.h b/lib/xe/xe_ioctl.h
> index 5c7e773fa..d8c40eda0 100644
> --- a/lib/xe/xe_ioctl.h
> +++ b/lib/xe/xe_ioctl.h
> @@ -73,6 +73,7 @@ uint32_t xe_engine_create_class(int fd, uint32_t vm, uint16_t class);
> void xe_engine_destroy(int fd, uint32_t engine);
> uint64_t xe_bo_mmap_offset(int fd, uint32_t bo);
> void *xe_bo_map(int fd, uint32_t bo, size_t size);
> +void *xe_bo_mmap_ext(int fd, uint32_t bo, size_t size, int prot);
> void xe_exec(int fd, struct drm_xe_exec *exec);
> void xe_exec_sync(int fd, uint32_t engine, uint64_t addr,
> struct drm_xe_sync *sync, uint32_t num_syncs);
^ permalink raw reply [flat|nested] 17+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for Enable ADDFB tests for XE (rev2)
2023-03-20 10:00 [igt-dev] [i-g-t 0/5] Enable ADDFB tests for XE Bhanuprakash Modem
` (5 preceding siblings ...)
2023-03-20 13:43 ` [igt-dev] ✗ Fi.CI.BAT: failure for Enable ADDFB tests for XE Patchwork
@ 2023-03-20 14:40 ` Patchwork
2023-03-20 17:29 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
7 siblings, 0 replies; 17+ messages in thread
From: Patchwork @ 2023-03-20 14:40 UTC (permalink / raw)
To: Modem, Bhanuprakash; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 8219 bytes --]
== Series Details ==
Series: Enable ADDFB tests for XE (rev2)
URL : https://patchwork.freedesktop.org/series/115381/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12883 -> IGTPW_8645
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8645/index.html
Participating hosts (34 -> 36)
------------------------------
Additional (2): fi-kbl-soraka bat-atsm-1
Known issues
------------
Here are the changes found in IGTPW_8645 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@fbdev@eof:
- bat-atsm-1: NOTRUN -> [SKIP][1] ([i915#2582]) +4 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8645/bat-atsm-1/igt@fbdev@eof.html
* igt@gem_exec_suspend@basic-s3@smem:
- bat-rpls-1: NOTRUN -> [ABORT][2] ([i915#6687] / [i915#7978])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8645/bat-rpls-1/igt@gem_exec_suspend@basic-s3@smem.html
* igt@gem_huc_copy@huc-copy:
- fi-kbl-soraka: NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#2190])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8645/fi-kbl-soraka/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@basic:
- fi-kbl-soraka: NOTRUN -> [SKIP][4] ([fdo#109271] / [i915#4613]) +3 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8645/fi-kbl-soraka/igt@gem_lmem_swapping@basic.html
* igt@gem_mmap@basic:
- bat-atsm-1: NOTRUN -> [SKIP][5] ([i915#4083])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8645/bat-atsm-1/igt@gem_mmap@basic.html
* igt@gem_tiled_fence_blits@basic:
- bat-atsm-1: NOTRUN -> [SKIP][6] ([i915#4077]) +2 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8645/bat-atsm-1/igt@gem_tiled_fence_blits@basic.html
* igt@gem_tiled_pread_basic:
- bat-atsm-1: NOTRUN -> [SKIP][7] ([i915#4079]) +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8645/bat-atsm-1/igt@gem_tiled_pread_basic.html
* igt@i915_pm_rps@basic-api:
- bat-atsm-1: NOTRUN -> [SKIP][8] ([i915#6621])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8645/bat-atsm-1/igt@i915_pm_rps@basic-api.html
* igt@i915_selftest@live@gt_pm:
- fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][9] ([i915#1886])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8645/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html
* igt@i915_selftest@live@slpc:
- bat-rpls-1: NOTRUN -> [DMESG-FAIL][10] ([i915#6367] / [i915#7996])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8645/bat-rpls-1/igt@i915_selftest@live@slpc.html
* igt@i915_suspend@basic-s3-without-i915:
- bat-atsm-1: NOTRUN -> [SKIP][11] ([i915#6645])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8645/bat-atsm-1/igt@i915_suspend@basic-s3-without-i915.html
* igt@kms_addfb_basic@size-max:
- bat-atsm-1: NOTRUN -> [SKIP][12] ([i915#6077]) +36 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8645/bat-atsm-1/igt@kms_addfb_basic@size-max.html
* igt@kms_chamelium_frames@hdmi-crc-fast:
- fi-kbl-soraka: NOTRUN -> [SKIP][13] ([fdo#109271]) +16 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8645/fi-kbl-soraka/igt@kms_chamelium_frames@hdmi-crc-fast.html
* igt@kms_cursor_legacy@basic-flip-after-cursor-atomic:
- bat-atsm-1: NOTRUN -> [SKIP][14] ([i915#6078]) +19 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8645/bat-atsm-1/igt@kms_cursor_legacy@basic-flip-after-cursor-atomic.html
* igt@kms_flip@basic-plain-flip:
- bat-atsm-1: NOTRUN -> [SKIP][15] ([i915#6166]) +3 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8645/bat-atsm-1/igt@kms_flip@basic-plain-flip.html
* igt@kms_force_connector_basic@prune-stale-modes:
- bat-atsm-1: NOTRUN -> [SKIP][16] ([i915#6093]) +3 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8645/bat-atsm-1/igt@kms_force_connector_basic@prune-stale-modes.html
* igt@kms_pipe_crc_basic@hang-read-crc:
- bat-atsm-1: NOTRUN -> [SKIP][17] ([i915#1836]) +6 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8645/bat-atsm-1/igt@kms_pipe_crc_basic@hang-read-crc.html
* igt@kms_prop_blob@basic:
- bat-atsm-1: NOTRUN -> [SKIP][18] ([i915#7357])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8645/bat-atsm-1/igt@kms_prop_blob@basic.html
* igt@kms_psr@sprite_plane_onoff:
- bat-atsm-1: NOTRUN -> [SKIP][19] ([i915#1072]) +3 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8645/bat-atsm-1/igt@kms_psr@sprite_plane_onoff.html
* igt@kms_setmode@basic-clone-single-crtc:
- bat-atsm-1: NOTRUN -> [SKIP][20] ([i915#6094])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8645/bat-atsm-1/igt@kms_setmode@basic-clone-single-crtc.html
* igt@prime_vgem@basic-fence-flip:
- bat-atsm-1: NOTRUN -> [SKIP][21] ([fdo#109295] / [i915#6078])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8645/bat-atsm-1/igt@prime_vgem@basic-fence-flip.html
* igt@prime_vgem@basic-fence-mmap:
- bat-atsm-1: NOTRUN -> [SKIP][22] ([fdo#109295] / [i915#4077]) +1 similar issue
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8645/bat-atsm-1/igt@prime_vgem@basic-fence-mmap.html
* igt@prime_vgem@basic-write:
- bat-atsm-1: NOTRUN -> [SKIP][23] ([fdo#109295]) +3 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8645/bat-atsm-1/igt@prime_vgem@basic-write.html
#### Possible fixes ####
* igt@i915_selftest@live@reset:
- bat-rpls-1: [ABORT][24] ([i915#4983]) -> [PASS][25]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12883/bat-rpls-1/igt@i915_selftest@live@reset.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8645/bat-rpls-1/igt@i915_selftest@live@reset.html
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1836]: https://gitlab.freedesktop.org/drm/intel/issues/1836
[i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#6077]: https://gitlab.freedesktop.org/drm/intel/issues/6077
[i915#6078]: https://gitlab.freedesktop.org/drm/intel/issues/6078
[i915#6093]: https://gitlab.freedesktop.org/drm/intel/issues/6093
[i915#6094]: https://gitlab.freedesktop.org/drm/intel/issues/6094
[i915#6166]: https://gitlab.freedesktop.org/drm/intel/issues/6166
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6645]: https://gitlab.freedesktop.org/drm/intel/issues/6645
[i915#6687]: https://gitlab.freedesktop.org/drm/intel/issues/6687
[i915#7357]: https://gitlab.freedesktop.org/drm/intel/issues/7357
[i915#7978]: https://gitlab.freedesktop.org/drm/intel/issues/7978
[i915#7996]: https://gitlab.freedesktop.org/drm/intel/issues/7996
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7207 -> IGTPW_8645
CI-20190529: 20190529
CI_DRM_12883: 5619fa2b4a9b93019f6ca27a2f391fc39e152993 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_8645: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8645/index.html
IGT_7207: 51001c91c367464da9e700e617fb712b3b1cecfd @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8645/index.html
[-- Attachment #2: Type: text/html, Size: 9807 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for Enable ADDFB tests for XE (rev2)
2023-03-20 10:00 [igt-dev] [i-g-t 0/5] Enable ADDFB tests for XE Bhanuprakash Modem
` (6 preceding siblings ...)
2023-03-20 14:40 ` [igt-dev] ✓ Fi.CI.BAT: success for Enable ADDFB tests for XE (rev2) Patchwork
@ 2023-03-20 17:29 ` Patchwork
7 siblings, 0 replies; 17+ messages in thread
From: Patchwork @ 2023-03-20 17:29 UTC (permalink / raw)
To: Modem, Bhanuprakash; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 23163 bytes --]
== Series Details ==
Series: Enable ADDFB tests for XE (rev2)
URL : https://patchwork.freedesktop.org/series/115381/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12883_full -> IGTPW_8645_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8645/index.html
Participating hosts (7 -> 7)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_8645_full:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@kms_ccs@pipe-d-bad-pixel-format-4_tiled_dg2_mc_ccs:
- {shard-rkl}: [SKIP][1] ([i915#4098]) -> [SKIP][2] +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12883/shard-rkl-5/igt@kms_ccs@pipe-d-bad-pixel-format-4_tiled_dg2_mc_ccs.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8645/shard-rkl-6/igt@kms_ccs@pipe-d-bad-pixel-format-4_tiled_dg2_mc_ccs.html
* igt@kms_ccs@pipe-d-ccs-on-another-bo-yf_tiled_ccs:
- {shard-rkl}: [SKIP][3] ([i915#1845] / [i915#4098]) -> [SKIP][4] +2 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12883/shard-rkl-1/igt@kms_ccs@pipe-d-ccs-on-another-bo-yf_tiled_ccs.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8645/shard-rkl-6/igt@kms_ccs@pipe-d-ccs-on-another-bo-yf_tiled_ccs.html
* igt@kms_display_modes@extended-mode-basic:
- {shard-dg1}: NOTRUN -> [SKIP][5]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8645/shard-dg1-15/igt@kms_display_modes@extended-mode-basic.html
* igt@kms_plane@plane-panning-top-left:
- {shard-tglu}: NOTRUN -> [SKIP][6]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8645/shard-tglu-9/igt@kms_plane@plane-panning-top-left.html
* igt@kms_plane@plane-position-hole-dpms:
- {shard-rkl}: NOTRUN -> [SKIP][7] +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8645/shard-rkl-2/igt@kms_plane@plane-position-hole-dpms.html
Known issues
------------
Here are the changes found in IGTPW_8645_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_userptr_blits@vma-merge:
- shard-glk: NOTRUN -> [FAIL][8] ([i915#3318])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8645/shard-glk8/igt@gem_userptr_blits@vma-merge.html
* igt@kms_async_flips@alternate-sync-async-flip@pipe-b-hdmi-a-1:
- shard-glk: [PASS][9] -> [FAIL][10] ([i915#2521])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12883/shard-glk4/igt@kms_async_flips@alternate-sync-async-flip@pipe-b-hdmi-a-1.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8645/shard-glk9/igt@kms_async_flips@alternate-sync-async-flip@pipe-b-hdmi-a-1.html
* igt@kms_ccs@pipe-a-crc-primary-basic-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][11] ([fdo#109271] / [i915#3886]) +2 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8645/shard-apl3/igt@kms_ccs@pipe-a-crc-primary-basic-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc:
- shard-glk: NOTRUN -> [SKIP][12] ([fdo#109271] / [i915#3886]) +1 similar issue
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8645/shard-glk5/igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-d-bad-pixel-format-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][13] ([fdo#109271]) +82 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8645/shard-apl3/igt@kms_ccs@pipe-d-bad-pixel-format-y_tiled_gen12_mc_ccs.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-apl: [PASS][14] -> [FAIL][15] ([i915#2346])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12883/shard-apl1/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8645/shard-apl3/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_plane_alpha_blend@alpha-opaque-fb@pipe-a-dp-1:
- shard-apl: NOTRUN -> [FAIL][16] ([i915#4573]) +1 similar issue
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8645/shard-apl4/igt@kms_plane_alpha_blend@alpha-opaque-fb@pipe-a-dp-1.html
* igt@kms_psr2_sf@cursor-plane-move-continuous-sf:
- shard-apl: NOTRUN -> [SKIP][17] ([fdo#109271] / [i915#658]) +1 similar issue
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8645/shard-apl3/igt@kms_psr2_sf@cursor-plane-move-continuous-sf.html
* igt@v3d/v3d_perfmon@destroy-invalid-perfmon:
- shard-glk: NOTRUN -> [SKIP][18] ([fdo#109271]) +23 similar issues
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8645/shard-glk4/igt@v3d/v3d_perfmon@destroy-invalid-perfmon.html
#### Possible fixes ####
* igt@drm_fdinfo@virtual-idle:
- {shard-rkl}: [FAIL][19] ([i915#7742]) -> [PASS][20] +1 similar issue
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12883/shard-rkl-1/igt@drm_fdinfo@virtual-idle.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8645/shard-rkl-4/igt@drm_fdinfo@virtual-idle.html
* igt@fbdev@unaligned-read:
- {shard-rkl}: [SKIP][21] ([i915#2582]) -> [PASS][22] +1 similar issue
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12883/shard-rkl-1/igt@fbdev@unaligned-read.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8645/shard-rkl-2/igt@fbdev@unaligned-read.html
* {igt@gem_barrier_race@remote-request@rcs0}:
- {shard-rkl}: [ABORT][23] ([i915#8211]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12883/shard-rkl-1/igt@gem_barrier_race@remote-request@rcs0.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8645/shard-rkl-4/igt@gem_barrier_race@remote-request@rcs0.html
- shard-glk: [ABORT][25] ([i915#8211]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12883/shard-glk9/igt@gem_barrier_race@remote-request@rcs0.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8645/shard-glk7/igt@gem_barrier_race@remote-request@rcs0.html
* igt@gem_ctx_isolation@preservation-s3@bcs0:
- {shard-rkl}: [FAIL][27] ([fdo#103375]) -> [PASS][28] +3 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12883/shard-rkl-4/igt@gem_ctx_isolation@preservation-s3@bcs0.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8645/shard-rkl-5/igt@gem_ctx_isolation@preservation-s3@bcs0.html
* igt@gem_exec_reloc@basic-write-read:
- {shard-rkl}: [SKIP][29] ([i915#3281]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12883/shard-rkl-4/igt@gem_exec_reloc@basic-write-read.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8645/shard-rkl-5/igt@gem_exec_reloc@basic-write-read.html
* igt@gem_exec_schedule@pi-distinct-iova@vecs0:
- shard-glk: [DMESG-WARN][31] ([i915#118]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12883/shard-glk9/igt@gem_exec_schedule@pi-distinct-iova@vecs0.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8645/shard-glk7/igt@gem_exec_schedule@pi-distinct-iova@vecs0.html
* igt@gem_pwrite@basic-random:
- {shard-rkl}: [SKIP][33] ([i915#3282]) -> [PASS][34] +2 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12883/shard-rkl-2/igt@gem_pwrite@basic-random.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8645/shard-rkl-5/igt@gem_pwrite@basic-random.html
* igt@gen9_exec_parse@basic-rejected-ctx-param:
- {shard-rkl}: [SKIP][35] ([i915#2527]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12883/shard-rkl-2/igt@gen9_exec_parse@basic-rejected-ctx-param.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8645/shard-rkl-5/igt@gen9_exec_parse@basic-rejected-ctx-param.html
* igt@i915_pm_dc@dc5-dpms:
- {shard-rkl}: [FAIL][37] ([i915#7330]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12883/shard-rkl-5/igt@i915_pm_dc@dc5-dpms.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8645/shard-rkl-2/igt@i915_pm_dc@dc5-dpms.html
* {igt@i915_pm_dc@dc5-dpms-negative}:
- {shard-tglu}: [SKIP][39] ([i915#8018]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12883/shard-tglu-10/igt@i915_pm_dc@dc5-dpms-negative.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8645/shard-tglu-8/igt@i915_pm_dc@dc5-dpms-negative.html
* igt@i915_pm_dc@dc9-dpms:
- {shard-tglu}: [SKIP][41] ([i915#4281]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12883/shard-tglu-6/igt@i915_pm_dc@dc9-dpms.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8645/shard-tglu-9/igt@i915_pm_dc@dc9-dpms.html
* igt@i915_suspend@fence-restore-untiled:
- {shard-tglu}: [ABORT][43] ([i915#5122]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12883/shard-tglu-9/igt@i915_suspend@fence-restore-untiled.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8645/shard-tglu-3/igt@i915_suspend@fence-restore-untiled.html
* igt@kms_atomic@atomic_plane_damage:
- {shard-rkl}: [SKIP][45] ([i915#4098]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12883/shard-rkl-2/igt@kms_atomic@atomic_plane_damage.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8645/shard-rkl-6/igt@kms_atomic@atomic_plane_damage.html
* igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0:
- {shard-tglu}: [SKIP][47] ([i915#1845] / [i915#7651]) -> [PASS][48] +22 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12883/shard-tglu-9/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8645/shard-tglu-7/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0.html
* igt@kms_ccs@pipe-d-bad-rotation-90-y_tiled_gen12_rc_ccs_cc:
- {shard-tglu}: [SKIP][49] ([i915#1845]) -> [PASS][50] +20 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12883/shard-tglu-10/igt@kms_ccs@pipe-d-bad-rotation-90-y_tiled_gen12_rc_ccs_cc.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8645/shard-tglu-3/igt@kms_ccs@pipe-d-bad-rotation-90-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-apl: [FAIL][51] ([i915#2346]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12883/shard-apl3/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8645/shard-apl6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
* igt@kms_flip@flip-vs-suspend@c-dp1:
- shard-apl: [ABORT][53] ([i915#180]) -> [PASS][54] +1 similar issue
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12883/shard-apl6/igt@kms_flip@flip-vs-suspend@c-dp1.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8645/shard-apl2/igt@kms_flip@flip-vs-suspend@c-dp1.html
* igt@kms_frontbuffer_tracking@fbc-tiling-linear:
- {shard-tglu}: [SKIP][55] ([i915#1849]) -> [PASS][56] +5 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12883/shard-tglu-9/igt@kms_frontbuffer_tracking@fbc-tiling-linear.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8645/shard-tglu-6/igt@kms_frontbuffer_tracking@fbc-tiling-linear.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-mmap-wc:
- {shard-rkl}: [SKIP][57] ([i915#1849] / [i915#4098]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12883/shard-rkl-5/igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-mmap-wc.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8645/shard-rkl-6/igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-mmap-wc.html
* igt@kms_psr@suspend:
- {shard-rkl}: [SKIP][59] ([i915#1072]) -> [PASS][60] +1 similar issue
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12883/shard-rkl-2/igt@kms_psr@suspend.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8645/shard-rkl-6/igt@kms_psr@suspend.html
* igt@kms_vblank@pipe-b-accuracy-idle:
- {shard-rkl}: [SKIP][61] ([i915#1845] / [i915#4098]) -> [PASS][62] +9 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12883/shard-rkl-5/igt@kms_vblank@pipe-b-accuracy-idle.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8645/shard-rkl-6/igt@kms_vblank@pipe-b-accuracy-idle.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1257]: https://gitlab.freedesktop.org/drm/intel/issues/1257
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1722]: https://gitlab.freedesktop.org/drm/intel/issues/1722
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1850]: https://gitlab.freedesktop.org/drm/intel/issues/1850
[i915#1902]: https://gitlab.freedesktop.org/drm/intel/issues/1902
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2433]: https://gitlab.freedesktop.org/drm/intel/issues/2433
[i915#2434]: https://gitlab.freedesktop.org/drm/intel/issues/2434
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2532]: https://gitlab.freedesktop.org/drm/intel/issues/2532
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#284]: https://gitlab.freedesktop.org/drm/intel/issues/284
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318
[i915#3323]: https://gitlab.freedesktop.org/drm/intel/issues/3323
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3361]: https://gitlab.freedesktop.org/drm/intel/issues/3361
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469
[i915#3528]: https://gitlab.freedesktop.org/drm/intel/issues/3528
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3952]: https://gitlab.freedesktop.org/drm/intel/issues/3952
[i915#404]: https://gitlab.freedesktop.org/drm/intel/issues/404
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
[i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#4565]: https://gitlab.freedesktop.org/drm/intel/issues/4565
[i915#4573]: https://gitlab.freedesktop.org/drm/intel/issues/4573
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4771]: https://gitlab.freedesktop.org/drm/intel/issues/4771
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4854]: https://gitlab.freedesktop.org/drm/intel/issues/4854
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#5099]: https://gitlab.freedesktop.org/drm/intel/issues/5099
[i915#5122]: https://gitlab.freedesktop.org/drm/intel/issues/5122
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6230]: https://gitlab.freedesktop.org/drm/intel/issues/6230
[i915#6247]: https://gitlab.freedesktop.org/drm/intel/issues/6247
[i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
[i915#6252]: https://gitlab.freedesktop.org/drm/intel/issues/6252
[i915#6355]: https://gitlab.freedesktop.org/drm/intel/issues/6355
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6590]: https://gitlab.freedesktop.org/drm/intel/issues/6590
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
[i915#6944]: https://gitlab.freedesktop.org/drm/intel/issues/6944
[i915#6953]: https://gitlab.freedesktop.org/drm/intel/issues/6953
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#7128]: https://gitlab.freedesktop.org/drm/intel/issues/7128
[i915#7294]: https://gitlab.freedesktop.org/drm/intel/issues/7294
[i915#7330]: https://gitlab.freedesktop.org/drm/intel/issues/7330
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7651]: https://gitlab.freedesktop.org/drm/intel/issues/7651
[i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#8018]: https://gitlab.freedesktop.org/drm/intel/issues/8018
[i915#8152]: https://gitlab.freedesktop.org/drm/intel/issues/8152
[i915#8154]: https://gitlab.freedesktop.org/drm/intel/issues/8154
[i915#8211]: https://gitlab.freedesktop.org/drm/intel/issues/8211
[i915#8228]: https://gitlab.freedesktop.org/drm/intel/issues/8228
[i915#8282]: https://gitlab.freedesktop.org/drm/intel/issues/8282
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7207 -> IGTPW_8645
* Piglit: piglit_4509 -> None
CI-20190529: 20190529
CI_DRM_12883: 5619fa2b4a9b93019f6ca27a2f391fc39e152993 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_8645: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8645/index.html
IGT_7207: 51001c91c367464da9e700e617fb712b3b1cecfd @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8645/index.html
[-- Attachment #2: Type: text/html, Size: 17952 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [igt-dev] [i-g-t 3/5] tests/kms_addfb_basic: Add XE support
2023-03-20 10:00 ` [igt-dev] [i-g-t 3/5] tests/kms_addfb_basic: Add XE support Bhanuprakash Modem
@ 2023-03-22 8:49 ` Kamil Konieczny
2023-03-23 19:04 ` Zbigniew Kempczyński
1 sibling, 0 replies; 17+ messages in thread
From: Kamil Konieczny @ 2023-03-22 8:49 UTC (permalink / raw)
To: igt-dev; +Cc: Jani Nikula, Nirmoy Das
Hi Bhanuprakash,
On 2023-03-20 at 15:30:15 +0530, Bhanuprakash Modem wrote:
> Add XE driver support for kms tests.
Could you write in commit what tests are added ? From changes
below it looks like only invalid test is added.
Regards,
Kamil
>
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
> tests/kms_addfb_basic.c | 42 +++++++++++++++++++++++++++--------------
> 1 file changed, 28 insertions(+), 14 deletions(-)
>
> diff --git a/tests/kms_addfb_basic.c b/tests/kms_addfb_basic.c
> index b4526eee6..bf90a9aa1 100644
> --- a/tests/kms_addfb_basic.c
> +++ b/tests/kms_addfb_basic.c
> @@ -41,6 +41,8 @@
> #include "igt_rand.h"
> #include "igt_device.h"
> #include "i915/intel_memory_region.h"
> +#include "xe/xe_ioctl.h"
> +#include "xe/xe_query.h"
>
> uint32_t gem_bo;
> uint32_t gem_bo_small;
> @@ -121,7 +123,7 @@ static void invalid_tests(int fd)
>
> igt_describe("Check if addfb2 call works for clobbered modifier");
> igt_subtest("clobberred-modifier") {
> - igt_require_intel(fd);
> + igt_require_i915(fd);
> igt_require(gem_available_fences(fd) > 0);
> f.flags = 0;
> f.modifier[0] = 0;
> @@ -139,10 +141,17 @@ static void invalid_tests(int fd)
> uint64_t size;
>
> igt_require_intel(fd);
> - igt_require(gem_has_lmem(fd));
> igt_calc_fb_size(fd, f.width, f.height,
> DRM_FORMAT_XRGB8888, 0, &size, &stride);
> - handle = gem_create_in_memory_regions(fd, size, REGION_SMEM);
> +
> + if (is_i915_device(fd)) {
> + igt_require(gem_has_lmem(fd));
> + handle = gem_create_in_memory_regions(fd, size, REGION_SMEM);
> + } else {
> + igt_require(xe_has_vram(fd));
> + handle = xe_bo_create_flags(fd, 0, size, vram_memory(fd, 0));
> + }
> +
> f.handles[0] = handle;
> do_ioctl_err(fd, DRM_IOCTL_MODE_ADDFB2, &f, EREMOTE);
> }
> @@ -323,7 +332,7 @@ static void tiling_tests(int fd)
>
> igt_subtest_group {
> igt_fixture {
> - igt_require_intel(fd);
> + igt_require_i915(fd);
> tiled_x_bo = igt_create_bo_with_dimensions(fd, 1024, 1024,
> DRM_FORMAT_XRGB8888, I915_FORMAT_MOD_X_TILED,
> 1024*4, NULL, NULL, NULL);
> @@ -494,7 +503,7 @@ static void size_tests(int fd)
>
> igt_describe("Test that addfb2 call fails correctly with small buffer object after changing tile");
> igt_subtest("bo-too-small-due-to-tiling") {
> - igt_require_intel(fd);
> + igt_require_i915(fd);
> igt_require(gem_available_fences(fd) > 0);
> gem_set_tiling(fd, gem_bo_small, I915_TILING_X, 1024*4);
> do_ioctl_err(fd, DRM_IOCTL_MODE_ADDFB2, &f, EINVAL);
> @@ -548,7 +557,7 @@ static void addfb25_tests(int fd)
>
> igt_subtest_group {
> igt_fixture {
> - igt_require_intel(fd);
> + igt_require_i915(fd);
> igt_require(gem_available_fences(fd) > 0);
> gem_set_tiling(fd, gem_bo, I915_TILING_X, 1024*4);
> igt_require_fb_modifiers(fd);
> @@ -594,6 +603,7 @@ static void addfb25_ytile(int fd)
> igt_display_t display;
>
> igt_fixture {
> + igt_require_i915(fd);
> igt_display_require(&display, fd);
>
> gem_bo = igt_create_bo_with_dimensions(fd, 1024, 1024,
> @@ -618,7 +628,6 @@ static void addfb25_ytile(int fd)
> igt_describe("Check if addfb2 call works for y-tiling");
> igt_subtest("addfb25-y-tiled-legacy") {
> igt_require_fb_modifiers(fd);
> - igt_require_intel(fd);
>
> f.modifier[0] = I915_FORMAT_MOD_Y_TILED;
> igt_assert_eq(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f),
> @@ -631,7 +640,6 @@ static void addfb25_ytile(int fd)
> igt_describe("Check if addfb2 call works for yf-tiling");
> igt_subtest("addfb25-yf-tiled-legacy") {
> igt_require_fb_modifiers(fd);
> - igt_require_intel(fd);
>
> f.modifier[0] = I915_FORMAT_MOD_Yf_TILED;
> igt_assert_eq(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f),
> @@ -644,7 +652,6 @@ static void addfb25_ytile(int fd)
> igt_describe("Test that addfb2 call fails correctly for y-tiling with given height and modifier");
> igt_subtest("addfb25-y-tiled-small-legacy") {
> igt_require_fb_modifiers(fd);
> - igt_require_intel(fd);
>
> f.modifier[0] = I915_FORMAT_MOD_Y_TILED;
> f.height = 1023;
> @@ -667,6 +674,7 @@ static void addfb25_4tile(int fd)
> igt_display_t display;
>
> igt_fixture {
> + igt_require_i915(fd);
> igt_display_require(&display, fd);
>
> gem_bo = igt_create_bo_with_dimensions(fd, 1024, 1024,
> @@ -689,7 +697,6 @@ static void addfb25_4tile(int fd)
> igt_describe("Check if addfb2 call works for tiling-4");
> igt_subtest("addfb25-4-tiled") {
> igt_require_fb_modifiers(fd);
> - igt_require_intel(fd);
>
> f.modifier[0] = I915_FORMAT_MOD_4_TILED;
> igt_assert_eq(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f),
> @@ -839,6 +846,9 @@ igt_main
> igt_fixture {
> fd = drm_open_driver_master(DRIVER_ANY);
> igt_require(has_addfb2_iface(fd));
> +
> + if (is_xe_device(fd))
> + xe_device_get(fd);
> }
>
> invalid_tests(fd);
> @@ -847,6 +857,10 @@ igt_main
>
> size_tests(fd);
>
> + prop_tests(fd);
> +
> + master_tests(fd);
> +
> addfb25_tests(fd);
>
> addfb25_ytile(fd);
> @@ -855,10 +869,10 @@ igt_main
>
> tiling_tests(fd);
>
> - prop_tests(fd);
> -
> - master_tests(fd);
> + igt_fixture {
> + if (is_xe_device(fd))
> + xe_device_put(fd);
>
> - igt_fixture
> close(fd);
> + }
> }
> --
> 2.40.0
>
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [igt-dev] [i-g-t 1/5] lib/xe/xe_ioctl: Add a helper to map the buffer
2023-03-20 10:00 ` [igt-dev] [i-g-t 1/5] lib/xe/xe_ioctl: Add a helper to map the buffer Bhanuprakash Modem
2023-03-20 14:28 ` Das, Nirmoy
@ 2023-03-23 18:57 ` Zbigniew Kempczyński
1 sibling, 0 replies; 17+ messages in thread
From: Zbigniew Kempczyński @ 2023-03-23 18:57 UTC (permalink / raw)
To: Bhanuprakash Modem; +Cc: igt-dev, jani.nikula
On Mon, Mar 20, 2023 at 03:30:13PM +0530, Bhanuprakash Modem wrote:
> Create a new helper to map the buffer with the user PROT flags.
>
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
> lib/xe/xe_ioctl.c | 14 ++++++++++++--
> lib/xe/xe_ioctl.h | 1 +
> 2 files changed, 13 insertions(+), 2 deletions(-)
>
> diff --git a/lib/xe/xe_ioctl.c b/lib/xe/xe_ioctl.c
> index 9d5793dff..66a8393fe 100644
> --- a/lib/xe/xe_ioctl.c
> +++ b/lib/xe/xe_ioctl.c
> @@ -334,18 +334,28 @@ uint64_t xe_bo_mmap_offset(int fd, uint32_t bo)
> return mmo.offset;
> }
>
> -void *xe_bo_map(int fd, uint32_t bo, size_t size)
> +static void *__xe_bo_map(int fd, uint16_t bo, size_t size, int prot)
> {
> uint64_t mmo;
> void *map;
>
> mmo = xe_bo_mmap_offset(fd, bo);
> - map = mmap(NULL, size, PROT_WRITE, MAP_SHARED, fd, mmo);
> + map = mmap(NULL, size, prot, MAP_SHARED, fd, mmo);
> igt_assert(map != MAP_FAILED);
>
> return map;
> }
>
> +void *xe_bo_map(int fd, uint32_t bo, size_t size)
> +{
> + return __xe_bo_map(fd, bo, size, PROT_WRITE);
> +}
> +
> +void *xe_bo_mmap_ext(int fd, uint32_t bo, size_t size, int prot)
> +{
> + return __xe_bo_map(fd, bo, size, prot);
> +}
> +
> static int __xe_exec(int fd, struct drm_xe_exec *exec)
> {
> int err = 0;
> diff --git a/lib/xe/xe_ioctl.h b/lib/xe/xe_ioctl.h
> index 5c7e773fa..d8c40eda0 100644
> --- a/lib/xe/xe_ioctl.h
> +++ b/lib/xe/xe_ioctl.h
> @@ -73,6 +73,7 @@ uint32_t xe_engine_create_class(int fd, uint32_t vm, uint16_t class);
> void xe_engine_destroy(int fd, uint32_t engine);
> uint64_t xe_bo_mmap_offset(int fd, uint32_t bo);
> void *xe_bo_map(int fd, uint32_t bo, size_t size);
> +void *xe_bo_mmap_ext(int fd, uint32_t bo, size_t size, int prot);
> void xe_exec(int fd, struct drm_xe_exec *exec);
> void xe_exec_sync(int fd, uint32_t engine, uint64_t addr,
> struct drm_xe_sync *sync, uint32_t num_syncs);
> --
> 2.40.0
>
Looks good:
Reviewed-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
--
Zbigniew
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [igt-dev] [i-g-t 2/5] lib/igt_fb: Add support for allocating buffers for XE
2023-03-20 10:00 ` [igt-dev] [i-g-t 2/5] lib/igt_fb: Add support for allocating buffers for XE Bhanuprakash Modem
@ 2023-03-23 19:01 ` Zbigniew Kempczyński
0 siblings, 0 replies; 17+ messages in thread
From: Zbigniew Kempczyński @ 2023-03-23 19:01 UTC (permalink / raw)
To: Bhanuprakash Modem; +Cc: igt-dev
On Mon, Mar 20, 2023 at 03:30:14PM +0530, Bhanuprakash Modem wrote:
> Add support to create a buffer object to the XE driver.
>
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
> lib/igt_fb.c | 16 +++++++++++++---
> 1 file changed, 13 insertions(+), 3 deletions(-)
>
> diff --git a/lib/igt_fb.c b/lib/igt_fb.c
> index ba89e1f60..63f8923dc 100644
> --- a/lib/igt_fb.c
> +++ b/lib/igt_fb.c
> @@ -49,6 +49,8 @@
> #include "intel_batchbuffer.h"
> #include "intel_chipset.h"
> #include "intel_bufops.h"
> +#include "xe/xe_ioctl.h"
> +#include "xe/xe_query.h"
>
> /**
> * SECTION:igt_fb
> @@ -434,7 +436,7 @@ void igt_get_fb_tile_size(int fd, uint64_t modifier, int fb_bpp,
>
> switch (modifier) {
> case DRM_FORMAT_MOD_LINEAR :
> - if (is_i915_device(fd))
> + if (is_intel_device(fd))
> *width_ret = 64;
> else
> *width_ret = 1;
> @@ -924,6 +926,9 @@ static uint64_t calc_fb_size(struct igt_fb *fb)
> size += calc_plane_size(fb, plane);
> }
>
> + if (is_xe_device(fb->fd))
> + size = ALIGN(size, xe_get_default_alignment(fb->fd));
> +
> return size;
> }
>
> @@ -1143,8 +1148,8 @@ static int create_bo_for_fb(struct igt_fb *fb, bool prefer_sysmem)
> * them, so we need to make sure to use a device BO then.
> */
> if (fb->modifier || fb->size || fb->strides[0] ||
> - (is_i915_device(fd) && igt_format_is_yuv(fb->drm_format)) ||
> - (is_i915_device(fd) && igt_format_is_fp16(fb->drm_format)) ||
> + (is_intel_device(fd) && igt_format_is_yuv(fb->drm_format)) ||
> + (is_intel_device(fd) && igt_format_is_fp16(fb->drm_format)) ||
> (is_amdgpu_device(fd) && igt_format_is_yuv(fb->drm_format)) ||
> is_nouveau_device(fd))
> device_bo = true;
> @@ -1168,6 +1173,11 @@ static int create_bo_for_fb(struct igt_fb *fb, bool prefer_sysmem)
> fb->strides[0]);
> /* If we can't use fences, we won't use ggtt detiling later. */
> igt_assert(err == 0 || err == -EOPNOTSUPP);
> + } else if (is_xe_device(fd)) {
> + fb->gem_handle = xe_bo_create_flags(fd, 0, fb->size,
> + xe_has_vram(fd) ?
> + vram_memory(fd, 0) :
> + system_memory(fd));
Isn't better to use vram_if_possible(fd, 0)?
With this fixed:
Acked-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
--
Zbigniew
> } else if (is_vc4_device(fd)) {
> fb->gem_handle = igt_vc4_create_bo(fd, fb->size);
>
> --
> 2.40.0
>
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [igt-dev] [i-g-t 3/5] tests/kms_addfb_basic: Add XE support
2023-03-20 10:00 ` [igt-dev] [i-g-t 3/5] tests/kms_addfb_basic: Add XE support Bhanuprakash Modem
2023-03-22 8:49 ` Kamil Konieczny
@ 2023-03-23 19:04 ` Zbigniew Kempczyński
2023-03-31 13:51 ` Modem, Bhanuprakash
1 sibling, 1 reply; 17+ messages in thread
From: Zbigniew Kempczyński @ 2023-03-23 19:04 UTC (permalink / raw)
To: Bhanuprakash Modem; +Cc: igt-dev
On Mon, Mar 20, 2023 at 03:30:15PM +0530, Bhanuprakash Modem wrote:
> Add XE driver support for kms tests.
>
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
> tests/kms_addfb_basic.c | 42 +++++++++++++++++++++++++++--------------
> 1 file changed, 28 insertions(+), 14 deletions(-)
>
> diff --git a/tests/kms_addfb_basic.c b/tests/kms_addfb_basic.c
> index b4526eee6..bf90a9aa1 100644
> --- a/tests/kms_addfb_basic.c
> +++ b/tests/kms_addfb_basic.c
> @@ -41,6 +41,8 @@
> #include "igt_rand.h"
> #include "igt_device.h"
> #include "i915/intel_memory_region.h"
> +#include "xe/xe_ioctl.h"
> +#include "xe/xe_query.h"
>
> uint32_t gem_bo;
> uint32_t gem_bo_small;
> @@ -121,7 +123,7 @@ static void invalid_tests(int fd)
>
> igt_describe("Check if addfb2 call works for clobbered modifier");
> igt_subtest("clobberred-modifier") {
> - igt_require_intel(fd);
> + igt_require_i915(fd);
> igt_require(gem_available_fences(fd) > 0);
> f.flags = 0;
> f.modifier[0] = 0;
> @@ -139,10 +141,17 @@ static void invalid_tests(int fd)
> uint64_t size;
>
> igt_require_intel(fd);
> - igt_require(gem_has_lmem(fd));
> igt_calc_fb_size(fd, f.width, f.height,
> DRM_FORMAT_XRGB8888, 0, &size, &stride);
> - handle = gem_create_in_memory_regions(fd, size, REGION_SMEM);
> +
> + if (is_i915_device(fd)) {
> + igt_require(gem_has_lmem(fd));
> + handle = gem_create_in_memory_regions(fd, size, REGION_SMEM);
> + } else {
> + igt_require(xe_has_vram(fd));
> + handle = xe_bo_create_flags(fd, 0, size, vram_memory(fd, 0));
> + }
> +
> f.handles[0] = handle;
> do_ioctl_err(fd, DRM_IOCTL_MODE_ADDFB2, &f, EREMOTE);
> }
> @@ -323,7 +332,7 @@ static void tiling_tests(int fd)
>
> igt_subtest_group {
> igt_fixture {
> - igt_require_intel(fd);
> + igt_require_i915(fd);
> tiled_x_bo = igt_create_bo_with_dimensions(fd, 1024, 1024,
> DRM_FORMAT_XRGB8888, I915_FORMAT_MOD_X_TILED,
> 1024*4, NULL, NULL, NULL);
> @@ -494,7 +503,7 @@ static void size_tests(int fd)
>
> igt_describe("Test that addfb2 call fails correctly with small buffer object after changing tile");
> igt_subtest("bo-too-small-due-to-tiling") {
> - igt_require_intel(fd);
> + igt_require_i915(fd);
> igt_require(gem_available_fences(fd) > 0);
> gem_set_tiling(fd, gem_bo_small, I915_TILING_X, 1024*4);
> do_ioctl_err(fd, DRM_IOCTL_MODE_ADDFB2, &f, EINVAL);
> @@ -548,7 +557,7 @@ static void addfb25_tests(int fd)
>
> igt_subtest_group {
> igt_fixture {
> - igt_require_intel(fd);
> + igt_require_i915(fd);
> igt_require(gem_available_fences(fd) > 0);
> gem_set_tiling(fd, gem_bo, I915_TILING_X, 1024*4);
> igt_require_fb_modifiers(fd);
> @@ -594,6 +603,7 @@ static void addfb25_ytile(int fd)
> igt_display_t display;
>
> igt_fixture {
> + igt_require_i915(fd);
> igt_display_require(&display, fd);
>
> gem_bo = igt_create_bo_with_dimensions(fd, 1024, 1024,
> @@ -618,7 +628,6 @@ static void addfb25_ytile(int fd)
> igt_describe("Check if addfb2 call works for y-tiling");
> igt_subtest("addfb25-y-tiled-legacy") {
> igt_require_fb_modifiers(fd);
> - igt_require_intel(fd);
>
> f.modifier[0] = I915_FORMAT_MOD_Y_TILED;
> igt_assert_eq(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f),
> @@ -631,7 +640,6 @@ static void addfb25_ytile(int fd)
> igt_describe("Check if addfb2 call works for yf-tiling");
> igt_subtest("addfb25-yf-tiled-legacy") {
> igt_require_fb_modifiers(fd);
> - igt_require_intel(fd);
>
> f.modifier[0] = I915_FORMAT_MOD_Yf_TILED;
> igt_assert_eq(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f),
> @@ -644,7 +652,6 @@ static void addfb25_ytile(int fd)
> igt_describe("Test that addfb2 call fails correctly for y-tiling with given height and modifier");
> igt_subtest("addfb25-y-tiled-small-legacy") {
> igt_require_fb_modifiers(fd);
> - igt_require_intel(fd);
>
> f.modifier[0] = I915_FORMAT_MOD_Y_TILED;
> f.height = 1023;
> @@ -667,6 +674,7 @@ static void addfb25_4tile(int fd)
> igt_display_t display;
>
> igt_fixture {
> + igt_require_i915(fd);
> igt_display_require(&display, fd);
>
> gem_bo = igt_create_bo_with_dimensions(fd, 1024, 1024,
> @@ -689,7 +697,6 @@ static void addfb25_4tile(int fd)
> igt_describe("Check if addfb2 call works for tiling-4");
> igt_subtest("addfb25-4-tiled") {
> igt_require_fb_modifiers(fd);
> - igt_require_intel(fd);
>
> f.modifier[0] = I915_FORMAT_MOD_4_TILED;
> igt_assert_eq(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f),
> @@ -839,6 +846,9 @@ igt_main
> igt_fixture {
> fd = drm_open_driver_master(DRIVER_ANY);
> igt_require(has_addfb2_iface(fd));
> +
> + if (is_xe_device(fd))
> + xe_device_get(fd);
> }
>
> invalid_tests(fd);
> @@ -847,6 +857,10 @@ igt_main
>
> size_tests(fd);
>
> + prop_tests(fd);
> +
> + master_tests(fd);
> +
> addfb25_tests(fd);
>
> addfb25_ytile(fd);
> @@ -855,10 +869,10 @@ igt_main
>
> tiling_tests(fd);
>
> - prop_tests(fd);
> -
> - master_tests(fd);
> + igt_fixture {
> + if (is_xe_device(fd))
> + xe_device_put(fd);
>
> - igt_fixture
> close(fd);
> + }
> }
> --
> 2.40.0
>
Fails on DG2 at invalid-smem-bo-on-discrete subtest.
--
Zbigniew
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [igt-dev] [i-g-t 4/5] tests/kms_force_connector_basic: Add XE support
2023-03-20 10:00 ` [igt-dev] [i-g-t 4/5] tests/kms_force_connector_basic: " Bhanuprakash Modem
@ 2023-03-23 19:06 ` Zbigniew Kempczyński
2023-03-31 13:53 ` Modem, Bhanuprakash
0 siblings, 1 reply; 17+ messages in thread
From: Zbigniew Kempczyński @ 2023-03-23 19:06 UTC (permalink / raw)
To: Bhanuprakash Modem; +Cc: igt-dev, jani.nikula
On Mon, Mar 20, 2023 at 03:30:16PM +0530, Bhanuprakash Modem wrote:
> Add XE driver support for kms tests.
>
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
> tests/kms_force_connector_basic.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tests/kms_force_connector_basic.c b/tests/kms_force_connector_basic.c
> index 4ff1efe3b..6a13fe4ed 100644
> --- a/tests/kms_force_connector_basic.c
> +++ b/tests/kms_force_connector_basic.c
> @@ -53,7 +53,9 @@ static void reset_connectors(void)
> drmModeFreeConnector(connector);
> }
>
> - igt_set_module_param_int(drm_fd, "load_detect_test", 0);
> + /* FIXME: load_detect_test is not found in XE. */
> + if (is_i915_device(drm_fd))
> + igt_set_module_param_int(drm_fd, "load_detect_test", 0);
What's the plan of addressing 'load_detect_test' param? If there will be
none I think "FIXME" should be get rid of here.
--
Zbigniew
>
> close(drm_fd);
> }
> --
> 2.40.0
>
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [igt-dev] [i-g-t 3/5] tests/kms_addfb_basic: Add XE support
2023-03-23 19:04 ` Zbigniew Kempczyński
@ 2023-03-31 13:51 ` Modem, Bhanuprakash
0 siblings, 0 replies; 17+ messages in thread
From: Modem, Bhanuprakash @ 2023-03-31 13:51 UTC (permalink / raw)
To: Zbigniew Kempczyński; +Cc: igt-dev
Hi Zbigniew,
On Fri-24-03-2023 12:34 am, Zbigniew Kempczyński wrote:
> On Mon, Mar 20, 2023 at 03:30:15PM +0530, Bhanuprakash Modem wrote:
>> Add XE driver support for kms tests.
>>
>> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
>> ---
>> tests/kms_addfb_basic.c | 42 +++++++++++++++++++++++++++--------------
>> 1 file changed, 28 insertions(+), 14 deletions(-)
>>
>> diff --git a/tests/kms_addfb_basic.c b/tests/kms_addfb_basic.c
>> index b4526eee6..bf90a9aa1 100644
>> --- a/tests/kms_addfb_basic.c
>> +++ b/tests/kms_addfb_basic.c
>> @@ -41,6 +41,8 @@
>> #include "igt_rand.h"
>> #include "igt_device.h"
>> #include "i915/intel_memory_region.h"
>> +#include "xe/xe_ioctl.h"
>> +#include "xe/xe_query.h"
>>
>> uint32_t gem_bo;
>> uint32_t gem_bo_small;
>> @@ -121,7 +123,7 @@ static void invalid_tests(int fd)
>>
>> igt_describe("Check if addfb2 call works for clobbered modifier");
>> igt_subtest("clobberred-modifier") {
>> - igt_require_intel(fd);
>> + igt_require_i915(fd);
>> igt_require(gem_available_fences(fd) > 0);
>> f.flags = 0;
>> f.modifier[0] = 0;
>> @@ -139,10 +141,17 @@ static void invalid_tests(int fd)
>> uint64_t size;
>>
>> igt_require_intel(fd);
>> - igt_require(gem_has_lmem(fd));
>> igt_calc_fb_size(fd, f.width, f.height,
>> DRM_FORMAT_XRGB8888, 0, &size, &stride);
>> - handle = gem_create_in_memory_regions(fd, size, REGION_SMEM);
>> +
>> + if (is_i915_device(fd)) {
>> + igt_require(gem_has_lmem(fd));
>> + handle = gem_create_in_memory_regions(fd, size, REGION_SMEM);
>> + } else {
>> + igt_require(xe_has_vram(fd));
>> + handle = xe_bo_create_flags(fd, 0, size, vram_memory(fd, 0));
>> + }
>> +
>> f.handles[0] = handle;
>> do_ioctl_err(fd, DRM_IOCTL_MODE_ADDFB2, &f, EREMOTE);
>> }
>> @@ -323,7 +332,7 @@ static void tiling_tests(int fd)
>>
>> igt_subtest_group {
>> igt_fixture {
>> - igt_require_intel(fd);
>> + igt_require_i915(fd);
>> tiled_x_bo = igt_create_bo_with_dimensions(fd, 1024, 1024,
>> DRM_FORMAT_XRGB8888, I915_FORMAT_MOD_X_TILED,
>> 1024*4, NULL, NULL, NULL);
>> @@ -494,7 +503,7 @@ static void size_tests(int fd)
>>
>> igt_describe("Test that addfb2 call fails correctly with small buffer object after changing tile");
>> igt_subtest("bo-too-small-due-to-tiling") {
>> - igt_require_intel(fd);
>> + igt_require_i915(fd);
>> igt_require(gem_available_fences(fd) > 0);
>> gem_set_tiling(fd, gem_bo_small, I915_TILING_X, 1024*4);
>> do_ioctl_err(fd, DRM_IOCTL_MODE_ADDFB2, &f, EINVAL);
>> @@ -548,7 +557,7 @@ static void addfb25_tests(int fd)
>>
>> igt_subtest_group {
>> igt_fixture {
>> - igt_require_intel(fd);
>> + igt_require_i915(fd);
>> igt_require(gem_available_fences(fd) > 0);
>> gem_set_tiling(fd, gem_bo, I915_TILING_X, 1024*4);
>> igt_require_fb_modifiers(fd);
>> @@ -594,6 +603,7 @@ static void addfb25_ytile(int fd)
>> igt_display_t display;
>>
>> igt_fixture {
>> + igt_require_i915(fd);
>> igt_display_require(&display, fd);
>>
>> gem_bo = igt_create_bo_with_dimensions(fd, 1024, 1024,
>> @@ -618,7 +628,6 @@ static void addfb25_ytile(int fd)
>> igt_describe("Check if addfb2 call works for y-tiling");
>> igt_subtest("addfb25-y-tiled-legacy") {
>> igt_require_fb_modifiers(fd);
>> - igt_require_intel(fd);
>>
>> f.modifier[0] = I915_FORMAT_MOD_Y_TILED;
>> igt_assert_eq(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f),
>> @@ -631,7 +640,6 @@ static void addfb25_ytile(int fd)
>> igt_describe("Check if addfb2 call works for yf-tiling");
>> igt_subtest("addfb25-yf-tiled-legacy") {
>> igt_require_fb_modifiers(fd);
>> - igt_require_intel(fd);
>>
>> f.modifier[0] = I915_FORMAT_MOD_Yf_TILED;
>> igt_assert_eq(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f),
>> @@ -644,7 +652,6 @@ static void addfb25_ytile(int fd)
>> igt_describe("Test that addfb2 call fails correctly for y-tiling with given height and modifier");
>> igt_subtest("addfb25-y-tiled-small-legacy") {
>> igt_require_fb_modifiers(fd);
>> - igt_require_intel(fd);
>>
>> f.modifier[0] = I915_FORMAT_MOD_Y_TILED;
>> f.height = 1023;
>> @@ -667,6 +674,7 @@ static void addfb25_4tile(int fd)
>> igt_display_t display;
>>
>> igt_fixture {
>> + igt_require_i915(fd);
>> igt_display_require(&display, fd);
>>
>> gem_bo = igt_create_bo_with_dimensions(fd, 1024, 1024,
>> @@ -689,7 +697,6 @@ static void addfb25_4tile(int fd)
>> igt_describe("Check if addfb2 call works for tiling-4");
>> igt_subtest("addfb25-4-tiled") {
>> igt_require_fb_modifiers(fd);
>> - igt_require_intel(fd);
>>
>> f.modifier[0] = I915_FORMAT_MOD_4_TILED;
>> igt_assert_eq(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f),
>> @@ -839,6 +846,9 @@ igt_main
>> igt_fixture {
>> fd = drm_open_driver_master(DRIVER_ANY);
>> igt_require(has_addfb2_iface(fd));
>> +
>> + if (is_xe_device(fd))
>> + xe_device_get(fd);
>> }
>>
>> invalid_tests(fd);
>> @@ -847,6 +857,10 @@ igt_main
>>
>> size_tests(fd);
>>
>> + prop_tests(fd);
>> +
>> + master_tests(fd);
>> +
>> addfb25_tests(fd);
>>
>> addfb25_ytile(fd);
>> @@ -855,10 +869,10 @@ igt_main
>>
>> tiling_tests(fd);
>>
>> - prop_tests(fd);
>> -
>> - master_tests(fd);
>> + igt_fixture {
>> + if (is_xe_device(fd))
>> + xe_device_put(fd);
>>
>> - igt_fixture
>> close(fd);
>> + }
>> }
>> --
>> 2.40.0
>>
>
> Fails on DG2 at invalid-smem-bo-on-discrete subtest.
Thanks for the review, Fixed in next rev.
- Bhanu
>
> --
> Zbigniew
>
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [igt-dev] [i-g-t 4/5] tests/kms_force_connector_basic: Add XE support
2023-03-23 19:06 ` Zbigniew Kempczyński
@ 2023-03-31 13:53 ` Modem, Bhanuprakash
0 siblings, 0 replies; 17+ messages in thread
From: Modem, Bhanuprakash @ 2023-03-31 13:53 UTC (permalink / raw)
To: Zbigniew Kempczyński; +Cc: igt-dev, jani.nikula
Hi Zbigniew,
On Fri-24-03-2023 12:36 am, Zbigniew Kempczyński wrote:
> On Mon, Mar 20, 2023 at 03:30:16PM +0530, Bhanuprakash Modem wrote:
>> Add XE driver support for kms tests.
>>
>> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
>> ---
>> tests/kms_force_connector_basic.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/tests/kms_force_connector_basic.c b/tests/kms_force_connector_basic.c
>> index 4ff1efe3b..6a13fe4ed 100644
>> --- a/tests/kms_force_connector_basic.c
>> +++ b/tests/kms_force_connector_basic.c
>> @@ -53,7 +53,9 @@ static void reset_connectors(void)
>> drmModeFreeConnector(connector);
>> }
>>
>> - igt_set_module_param_int(drm_fd, "load_detect_test", 0);
>> + /* FIXME: load_detect_test is not found in XE. */
>> + if (is_i915_device(drm_fd))
>> + igt_set_module_param_int(drm_fd, "load_detect_test", 0);
>
> What's the plan of addressing 'load_detect_test' param? If there will be
> none I think "FIXME" should be get rid of here.
Thanks for the review, Fixed in next rev.
- Bhanu
>
> --
> Zbigniew
>
>>
>> close(drm_fd);
>> }
>> --
>> 2.40.0
>>
^ permalink raw reply [flat|nested] 17+ messages in thread
end of thread, other threads:[~2023-03-31 13:53 UTC | newest]
Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-20 10:00 [igt-dev] [i-g-t 0/5] Enable ADDFB tests for XE Bhanuprakash Modem
2023-03-20 10:00 ` [igt-dev] [i-g-t 1/5] lib/xe/xe_ioctl: Add a helper to map the buffer Bhanuprakash Modem
2023-03-20 14:28 ` Das, Nirmoy
2023-03-23 18:57 ` Zbigniew Kempczyński
2023-03-20 10:00 ` [igt-dev] [i-g-t 2/5] lib/igt_fb: Add support for allocating buffers for XE Bhanuprakash Modem
2023-03-23 19:01 ` Zbigniew Kempczyński
2023-03-20 10:00 ` [igt-dev] [i-g-t 3/5] tests/kms_addfb_basic: Add XE support Bhanuprakash Modem
2023-03-22 8:49 ` Kamil Konieczny
2023-03-23 19:04 ` Zbigniew Kempczyński
2023-03-31 13:51 ` Modem, Bhanuprakash
2023-03-20 10:00 ` [igt-dev] [i-g-t 4/5] tests/kms_force_connector_basic: " Bhanuprakash Modem
2023-03-23 19:06 ` Zbigniew Kempczyński
2023-03-31 13:53 ` Modem, Bhanuprakash
2023-03-20 10:00 ` [igt-dev] [i-g-t 5/5] xe-fast-feedback: Add basic kms tests to XE BAT Bhanuprakash Modem
2023-03-20 13:43 ` [igt-dev] ✗ Fi.CI.BAT: failure for Enable ADDFB tests for XE Patchwork
2023-03-20 14:40 ` [igt-dev] ✓ Fi.CI.BAT: success for Enable ADDFB tests for XE (rev2) Patchwork
2023-03-20 17:29 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.