* [dm-devel] [PATCH] libmultipath: use directio checker for LIO targets
@ 2023-03-23 20:53 mwilck
2023-03-28 13:50 ` Benjamin Marzinski
0 siblings, 1 reply; 2+ messages in thread
From: mwilck @ 2023-03-23 20:53 UTC (permalink / raw)
To: Christophe Varoqui, Benjamin Marzinski, lixiaokeng; +Cc: dm-devel, Martin Wilck
From: Martin Wilck <mwilck@suse.com>
LIO always responds with GOOD status to TUR. Thus TUR is
not useful as path checker for LIO targets.
Fixes https://github.com/opensvc/multipath-tools/issues/54
Signed-off-by: Martin Wilck <mwilck@suse.com>
---
libmultipath/hwtable.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index 3c4f866..c2a024c 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -1067,6 +1067,7 @@ static struct hwentry default_hw[] = {
.pgfailback = -FAILBACK_IMMEDIATE,
.no_path_retry = 12,
.prio_name = PRIO_ALUA,
+ .checker_name = DIRECTIO,
},
/*
* DataCore
--
2.39.2
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [dm-devel] [PATCH] libmultipath: use directio checker for LIO targets
2023-03-23 20:53 [dm-devel] [PATCH] libmultipath: use directio checker for LIO targets mwilck
@ 2023-03-28 13:50 ` Benjamin Marzinski
0 siblings, 0 replies; 2+ messages in thread
From: Benjamin Marzinski @ 2023-03-28 13:50 UTC (permalink / raw)
To: mwilck; +Cc: lixiaokeng, dm-devel
On Thu, Mar 23, 2023 at 09:53:58PM +0100, mwilck@suse.com wrote:
> From: Martin Wilck <mwilck@suse.com>
>
> LIO always responds with GOOD status to TUR. Thus TUR is
> not useful as path checker for LIO targets.
>
> Fixes https://github.com/opensvc/multipath-tools/issues/54
>
> Signed-off-by: Martin Wilck <mwilck@suse.com>
Reviewed-by: Benjamin Marzinski <bmarzins@redhat.com>
> ---
> libmultipath/hwtable.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
> index 3c4f866..c2a024c 100644
> --- a/libmultipath/hwtable.c
> +++ b/libmultipath/hwtable.c
> @@ -1067,6 +1067,7 @@ static struct hwentry default_hw[] = {
> .pgfailback = -FAILBACK_IMMEDIATE,
> .no_path_retry = 12,
> .prio_name = PRIO_ALUA,
> + .checker_name = DIRECTIO,
> },
> /*
> * DataCore
> --
> 2.39.2
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-28 13:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-23 20:53 [dm-devel] [PATCH] libmultipath: use directio checker for LIO targets mwilck
2023-03-28 13:50 ` Benjamin Marzinski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.