All of lore.kernel.org
 help / color / mirror / Atom feed
From: Parav Pandit <parav@nvidia.com>
To: <mst@redhat.com>, <virtio-dev@lists.oasis-open.org>,
	<pasic@linux.ibm.com>, <cohuck@redhat.com>
Cc: <virtio-comment@lists.oasis-open.org>, <shahafs@nvidia.com>,
	Parav Pandit <parav@nvidia.com>,
	Max Gurtovoy <mgurtovoy@nvidia.com>
Subject: [virtio-dev] [PATCH 3/3] transport-pci: Improve queue msix vector register desc
Date: Fri, 24 Mar 2023 04:35:34 +0300	[thread overview]
Message-ID: <20230324013534.280820-4-parav@nvidia.com> (raw)
In-Reply-To: <20230324013534.280820-1-parav@nvidia.com>

queue_msix_vector register is for receiving interrupts from the device
for the virtqueue.

"for MSI-X" is confusing term.

Also it is the register that driver "writes" to, similar to
many other registers such as queue_desc, queue_driver etc.

Hence, replace the verb from use to write.

Signed-off-by: Parav Pandit <parav@nvidia.com>
Reviewed-by: Max Gurtovoy <mgurtovoy@nvidia.com>
---
 transport-pci.tex | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/transport-pci.tex b/transport-pci.tex
index 1bc89b4..9d492d5 100644
--- a/transport-pci.tex
+++ b/transport-pci.tex
@@ -367,7 +367,8 @@ \subsubsection{Common configuration structure layout}\label{sec:Virtio Transport
         A 0 means the queue is unavailable.
 
 \item[\field{queue_msix_vector}]
-        The driver uses this to specify the queue vector for MSI-X.
+        The driver writes an MSI-X vector number for receiving
+        virtqueue interrupts.
 
 \item[\field{queue_enable}]
         The driver uses this to selectively prevent the device from executing requests from this virtqueue.
-- 
2.26.2


---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org


WARNING: multiple messages have this Message-ID (diff)
From: Parav Pandit <parav@nvidia.com>
To: <mst@redhat.com>, <virtio-dev@lists.oasis-open.org>,
	<pasic@linux.ibm.com>, <cohuck@redhat.com>
Cc: <virtio-comment@lists.oasis-open.org>, <shahafs@nvidia.com>,
	Parav Pandit <parav@nvidia.com>,
	Max Gurtovoy <mgurtovoy@nvidia.com>
Subject: [virtio-comment] [PATCH 3/3] transport-pci: Improve queue msix vector register desc
Date: Fri, 24 Mar 2023 04:35:34 +0300	[thread overview]
Message-ID: <20230324013534.280820-4-parav@nvidia.com> (raw)
In-Reply-To: <20230324013534.280820-1-parav@nvidia.com>

queue_msix_vector register is for receiving interrupts from the device
for the virtqueue.

"for MSI-X" is confusing term.

Also it is the register that driver "writes" to, similar to
many other registers such as queue_desc, queue_driver etc.

Hence, replace the verb from use to write.

Signed-off-by: Parav Pandit <parav@nvidia.com>
Reviewed-by: Max Gurtovoy <mgurtovoy@nvidia.com>
---
 transport-pci.tex | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/transport-pci.tex b/transport-pci.tex
index 1bc89b4..9d492d5 100644
--- a/transport-pci.tex
+++ b/transport-pci.tex
@@ -367,7 +367,8 @@ \subsubsection{Common configuration structure layout}\label{sec:Virtio Transport
         A 0 means the queue is unavailable.
 
 \item[\field{queue_msix_vector}]
-        The driver uses this to specify the queue vector for MSI-X.
+        The driver writes an MSI-X vector number for receiving
+        virtqueue interrupts.
 
 \item[\field{queue_enable}]
         The driver uses this to selectively prevent the device from executing requests from this virtqueue.
-- 
2.26.2


This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.

Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/


  parent reply	other threads:[~2023-03-24  1:36 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-24  1:35 [virtio-dev] [PATCH 0/3] transport-pci: msix summary update Parav Pandit
2023-03-24  1:35 ` [virtio-comment] " Parav Pandit
2023-03-24  1:35 ` [virtio-dev] [PATCH 1/3] transport-pci: Remove empty line at end of file Parav Pandit
2023-03-24  1:35   ` [virtio-comment] " Parav Pandit
2023-03-27 14:57   ` [virtio-dev] " David Edmondson
2023-03-27 14:57     ` David Edmondson
2023-04-04  7:22   ` [virtio-dev] " Michael S. Tsirkin
2023-04-04  7:22     ` [virtio-comment] " Michael S. Tsirkin
2023-03-24  1:35 ` [virtio-dev] [PATCH 2/3] transport-pci: Improve config msix vector description Parav Pandit
2023-03-24  1:35   ` [virtio-comment] " Parav Pandit
2023-03-24  1:35 ` Parav Pandit [this message]
2023-03-24  1:35   ` [virtio-comment] [PATCH 3/3] transport-pci: Improve queue msix vector register desc Parav Pandit
2023-04-04  7:20   ` [virtio-dev] " Michael S. Tsirkin
2023-04-04  7:20     ` [virtio-comment] " Michael S. Tsirkin
2023-04-04 18:14     ` [virtio-dev] " Parav Pandit
2023-04-04 18:14       ` [virtio-comment] " Parav Pandit
2023-04-04 19:08       ` [virtio-dev] " Michael S. Tsirkin
2023-04-04 19:08         ` [virtio-comment] " Michael S. Tsirkin
2023-03-27  6:09 ` [virtio-dev] Re: [virtio-comment] [PATCH 0/3] transport-pci: msix summary update Xuan Zhuo
2023-03-27  6:09   ` Xuan Zhuo
2023-04-03 22:39   ` [virtio-dev] " Parav Pandit
2023-04-03 22:39     ` Parav Pandit
2023-04-04  8:28     ` [virtio-dev] " Cornelia Huck
2023-04-04  8:28       ` Cornelia Huck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230324013534.280820-4-parav@nvidia.com \
    --to=parav@nvidia.com \
    --cc=cohuck@redhat.com \
    --cc=mgurtovoy@nvidia.com \
    --cc=mst@redhat.com \
    --cc=pasic@linux.ibm.com \
    --cc=shahafs@nvidia.com \
    --cc=virtio-comment@lists.oasis-open.org \
    --cc=virtio-dev@lists.oasis-open.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.