* [PATCH 1/1] cmd: CONFIG_CMD_SCSI depends on CONFIG_SCSI
@ 2023-03-26 17:10 Heinrich Schuchardt
2023-03-27 4:00 ` Simon Glass
2023-04-07 14:50 ` Tom Rini
0 siblings, 2 replies; 3+ messages in thread
From: Heinrich Schuchardt @ 2023-03-26 17:10 UTC (permalink / raw)
To: Tom Rini; +Cc: Simon Glass, u-boot, Heinrich Schuchardt
Compiling with CONFIG_CMD_SCSI=y, CONFIG_SCSI results in
cmd/scsi.c:46: undefined reference to `scsi_scan'
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
---
cmd/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/cmd/Kconfig b/cmd/Kconfig
index 2caa4af71c..5c1b353c90 100644
--- a/cmd/Kconfig
+++ b/cmd/Kconfig
@@ -1436,7 +1436,8 @@ config CMD_SATA
config CMD_SCSI
bool "scsi - Access to SCSI devices"
- default y if SCSI
+ depends on SCSI
+ default y
help
This provides a 'scsi' command which provides access to SCSI (Small
Computer System Interface) devices. The command provides a way to
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] cmd: CONFIG_CMD_SCSI depends on CONFIG_SCSI
2023-03-26 17:10 [PATCH 1/1] cmd: CONFIG_CMD_SCSI depends on CONFIG_SCSI Heinrich Schuchardt
@ 2023-03-27 4:00 ` Simon Glass
2023-04-07 14:50 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Simon Glass @ 2023-03-27 4:00 UTC (permalink / raw)
To: Heinrich Schuchardt; +Cc: Tom Rini, u-boot
On Mon, 27 Mar 2023 at 06:10, Heinrich Schuchardt
<heinrich.schuchardt@canonical.com> wrote:
>
> Compiling with CONFIG_CMD_SCSI=y, CONFIG_SCSI results in
>
> cmd/scsi.c:46: undefined reference to `scsi_scan'
>
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> ---
> cmd/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/cmd/Kconfig b/cmd/Kconfig
> index 2caa4af71c..5c1b353c90 100644
> --- a/cmd/Kconfig
> +++ b/cmd/Kconfig
> @@ -1436,7 +1436,8 @@ config CMD_SATA
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] cmd: CONFIG_CMD_SCSI depends on CONFIG_SCSI
2023-03-26 17:10 [PATCH 1/1] cmd: CONFIG_CMD_SCSI depends on CONFIG_SCSI Heinrich Schuchardt
2023-03-27 4:00 ` Simon Glass
@ 2023-04-07 14:50 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2023-04-07 14:50 UTC (permalink / raw)
To: Heinrich Schuchardt; +Cc: Simon Glass, u-boot
[-- Attachment #1: Type: text/plain, Size: 367 bytes --]
On Sun, Mar 26, 2023 at 07:10:38PM +0200, Heinrich Schuchardt wrote:
> Compiling with CONFIG_CMD_SCSI=y, CONFIG_SCSI results in
>
> cmd/scsi.c:46: undefined reference to `scsi_scan'
>
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
Applied to u-boot/master, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-04-07 14:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-26 17:10 [PATCH 1/1] cmd: CONFIG_CMD_SCSI depends on CONFIG_SCSI Heinrich Schuchardt
2023-03-27 4:00 ` Simon Glass
2023-04-07 14:50 ` Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.