From: Greg Ungerer <gerg@linux-m68k.org> To: peng.fan@oss.nxp.com Cc: Markus.Niebel@ew.tq-group.com, abailon@baylibre.com, abelvesa@kernel.org, aford173@gmail.com, devicetree@vger.kernel.org, djakov@kernel.org, festevam@gmail.com, kernel@pengutronix.de, krzysztof.kozlowski+dt@linaro.org, l.stach@pengutronix.de, laurent.pinchart@ideasonboard.com, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, marex@denx.de, paul.elder@ideasonboard.com, peng.fan@nxp.com, robh+dt@kernel.org, s.hauer@pengutronix.de, shawnguo@kernel.org, gerg@kernel.org Subject: Re: [PATCH V3 7/7] arm64: dts: imx8mp: add interconnect for hsio blk ctrl Date: Mon, 27 Mar 2023 14:50:37 +1000 [thread overview] Message-ID: <20230327045037.593326-1-gerg@linux-m68k.org> (raw) In-Reply-To: <20220703091451.1416264-8-peng.fan@oss.nxp.com> On 2/3/22 17:13, Peng Fan wrote: > From: Peng Fan <peng.fan@nxp.com> > > Add interconnect property for hsio blk ctrl > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > --- > arch/arm64/boot/dts/freescale/imx8mp.dtsi | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > index 08bd57742294..9cceeeeb26be 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > @@ -1109,6 +1109,11 @@ hsio_blk_ctrl: blk-ctrl@32f10000 { > <&pgc_hsiomix>, <&pgc_pcie_phy>; > power-domain-names = "bus", "usb", "usb-phy1", > "usb-phy2", "pcie", "pcie-phy"; > + interconnects = <&noc IMX8MP_ICM_NOC_PCIE &noc IMX8MP_ICN_HSIO>, > + <&noc IMX8MP_ICM_USB1 &noc IMX8MP_ICN_HSIO>, > + <&noc IMX8MP_ICM_USB2 &noc IMX8MP_ICN_HSIO>, > + <&noc IMX8MP_ICM_PCIE &noc IMX8MP_ICN_HSIO>; > + interconnect-names = "noc-pcie", "usb1", "usb2", "pcie"; > #power-domain-cells = <1>; > }; > }; This change completely breaks USB for me on a new iMX8mp platform I am working with. Before this change normal USB probe looks good: xhci-hcd xhci-hcd.0.auto: xHCI Host Controller xhci-hcd xhci-hcd.0.auto: new USB bus registered, assigned bus number 1 xhci-hcd xhci-hcd.0.auto: hcc params 0x0220fe6d hci version 0x110 quirks 0x0000000000010010 xhci-hcd xhci-hcd.0.auto: irq 206, io mem 0x38100000 xhci-hcd xhci-hcd.0.auto: xHCI Host Controller xhci-hcd xhci-hcd.0.auto: new USB bus registered, assigned bus number 2 xhci-hcd xhci-hcd.0.auto: Host supports USB 3.0 SuperSpeed usb usb1: New USB device found, idVendor=1d6b, idProduct=0002, bcdDevice= 6.03 usb usb1: New USB device strings: Mfr=3, Product=2, SerialNumber=1 usb usb1: Product: xHCI Host Controller usb usb1: Manufacturer: Linux 6.3.0-rc4-dirty xhci-hcd .... But after this commit is applied, no USB probe messages at all. USB worked fine in 6.0 for me, but when I switched up to 6.1 USB was broken, I bisected to this as being the offending commit. This is still broken for me in todays 6.3-rc4. If I revert this change (and only this change) USB works again. Any thoughts on why this breaks USB? Regards greg
WARNING: multiple messages have this Message-ID (diff)
From: Greg Ungerer <gerg@linux-m68k.org> To: peng.fan@oss.nxp.com Cc: Markus.Niebel@ew.tq-group.com, abailon@baylibre.com, abelvesa@kernel.org, aford173@gmail.com, devicetree@vger.kernel.org, djakov@kernel.org, festevam@gmail.com, kernel@pengutronix.de, krzysztof.kozlowski+dt@linaro.org, l.stach@pengutronix.de, laurent.pinchart@ideasonboard.com, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, marex@denx.de, paul.elder@ideasonboard.com, peng.fan@nxp.com, robh+dt@kernel.org, s.hauer@pengutronix.de, shawnguo@kernel.org, gerg@kernel.org Subject: Re: [PATCH V3 7/7] arm64: dts: imx8mp: add interconnect for hsio blk ctrl Date: Mon, 27 Mar 2023 14:50:37 +1000 [thread overview] Message-ID: <20230327045037.593326-1-gerg@linux-m68k.org> (raw) In-Reply-To: <20220703091451.1416264-8-peng.fan@oss.nxp.com> On 2/3/22 17:13, Peng Fan wrote: > From: Peng Fan <peng.fan@nxp.com> > > Add interconnect property for hsio blk ctrl > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > --- > arch/arm64/boot/dts/freescale/imx8mp.dtsi | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > index 08bd57742294..9cceeeeb26be 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > @@ -1109,6 +1109,11 @@ hsio_blk_ctrl: blk-ctrl@32f10000 { > <&pgc_hsiomix>, <&pgc_pcie_phy>; > power-domain-names = "bus", "usb", "usb-phy1", > "usb-phy2", "pcie", "pcie-phy"; > + interconnects = <&noc IMX8MP_ICM_NOC_PCIE &noc IMX8MP_ICN_HSIO>, > + <&noc IMX8MP_ICM_USB1 &noc IMX8MP_ICN_HSIO>, > + <&noc IMX8MP_ICM_USB2 &noc IMX8MP_ICN_HSIO>, > + <&noc IMX8MP_ICM_PCIE &noc IMX8MP_ICN_HSIO>; > + interconnect-names = "noc-pcie", "usb1", "usb2", "pcie"; > #power-domain-cells = <1>; > }; > }; This change completely breaks USB for me on a new iMX8mp platform I am working with. Before this change normal USB probe looks good: xhci-hcd xhci-hcd.0.auto: xHCI Host Controller xhci-hcd xhci-hcd.0.auto: new USB bus registered, assigned bus number 1 xhci-hcd xhci-hcd.0.auto: hcc params 0x0220fe6d hci version 0x110 quirks 0x0000000000010010 xhci-hcd xhci-hcd.0.auto: irq 206, io mem 0x38100000 xhci-hcd xhci-hcd.0.auto: xHCI Host Controller xhci-hcd xhci-hcd.0.auto: new USB bus registered, assigned bus number 2 xhci-hcd xhci-hcd.0.auto: Host supports USB 3.0 SuperSpeed usb usb1: New USB device found, idVendor=1d6b, idProduct=0002, bcdDevice= 6.03 usb usb1: New USB device strings: Mfr=3, Product=2, SerialNumber=1 usb usb1: Product: xHCI Host Controller usb usb1: Manufacturer: Linux 6.3.0-rc4-dirty xhci-hcd .... But after this commit is applied, no USB probe messages at all. USB worked fine in 6.0 for me, but when I switched up to 6.1 USB was broken, I bisected to this as being the offending commit. This is still broken for me in todays 6.3-rc4. If I revert this change (and only this change) USB works again. Any thoughts on why this breaks USB? Regards greg _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-03-27 4:50 UTC|newest] Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-07-03 9:14 [PATCH V3 0/7] imx: blk-ctrl: Add interconnect for i.MX8MP Peng Fan (OSS) 2022-07-03 9:14 ` Peng Fan (OSS) 2022-07-03 9:14 ` [PATCH V3 1/7] dt-bindings: soc: imx: add interconnect property for i.MX8MP media blk ctrl Peng Fan (OSS) 2022-07-03 9:14 ` Peng Fan (OSS) 2022-07-03 9:14 ` [PATCH V3 2/7] dt-bindings: soc: imx: add interconnect property for i.MX8MP hdmi " Peng Fan (OSS) 2022-07-03 9:14 ` Peng Fan (OSS) 2022-07-03 9:14 ` [PATCH V3 3/7] dt-bindings: soc: imx: add interconnect property for i.MX8MP hsio " Peng Fan (OSS) 2022-07-03 9:14 ` Peng Fan (OSS) 2022-07-03 9:14 ` [PATCH V3 4/7] soc: imx: add icc paths for i.MX8MP media " Peng Fan (OSS) 2022-07-03 9:14 ` Peng Fan (OSS) 2022-07-03 9:14 ` [PATCH V3 5/7] soc: imx: add icc paths for i.MX8MP hsio/hdmi " Peng Fan (OSS) 2022-07-03 9:14 ` Peng Fan (OSS) 2022-07-03 9:14 ` [PATCH V3 6/7] arm64: dts: imx8mp: add interconnects for media " Peng Fan (OSS) 2022-07-03 9:14 ` Peng Fan (OSS) 2022-07-07 11:38 ` Marco Felsch 2022-07-07 11:38 ` Marco Felsch 2022-07-08 0:06 ` Peng Fan 2022-07-08 0:06 ` Peng Fan 2022-07-03 9:14 ` [PATCH V3 7/7] arm64: dts: imx8mp: add interconnect for hsio " Peng Fan (OSS) 2022-07-03 9:14 ` Peng Fan (OSS) 2023-03-27 4:50 ` Greg Ungerer [this message] 2023-03-27 4:50 ` Greg Ungerer 2023-03-27 6:27 ` Alexander Stein 2023-03-27 6:27 ` Alexander Stein 2023-03-27 7:16 ` Ahmad Fatoum 2023-03-27 7:16 ` Ahmad Fatoum 2023-03-27 8:07 ` Greg Ungerer 2023-03-27 8:07 ` Greg Ungerer 2023-03-28 7:33 ` Marco Felsch 2023-03-28 7:33 ` Marco Felsch 2023-03-28 12:58 ` Greg Ungerer 2023-03-28 12:58 ` Greg Ungerer 2023-03-28 13:42 ` Marco Felsch 2023-03-28 13:42 ` Marco Felsch 2023-03-28 13:51 ` Marco Felsch 2023-03-28 13:51 ` Marco Felsch 2023-03-28 14:34 ` Greg Ungerer 2023-03-28 14:34 ` Greg Ungerer 2023-03-28 15:11 ` Marco Felsch 2023-03-28 15:11 ` Marco Felsch 2023-03-31 5:55 ` Greg Ungerer 2023-03-31 5:55 ` Greg Ungerer 2023-03-31 7:45 ` Markus Niebel 2023-03-31 7:45 ` Markus Niebel 2023-03-31 8:11 ` Ahmad Fatoum 2023-03-31 8:11 ` Ahmad Fatoum 2023-03-31 15:09 ` Greg Ungerer 2023-03-31 15:09 ` Greg Ungerer 2023-03-27 7:51 ` Greg Ungerer 2023-03-27 7:51 ` Greg Ungerer
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230327045037.593326-1-gerg@linux-m68k.org \ --to=gerg@linux-m68k.org \ --cc=Markus.Niebel@ew.tq-group.com \ --cc=abailon@baylibre.com \ --cc=abelvesa@kernel.org \ --cc=aford173@gmail.com \ --cc=devicetree@vger.kernel.org \ --cc=djakov@kernel.org \ --cc=festevam@gmail.com \ --cc=gerg@kernel.org \ --cc=kernel@pengutronix.de \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=l.stach@pengutronix.de \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=marex@denx.de \ --cc=paul.elder@ideasonboard.com \ --cc=peng.fan@nxp.com \ --cc=peng.fan@oss.nxp.com \ --cc=robh+dt@kernel.org \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.