[PATCH] debian/control: Fix missing dependency to gdb

[PATCH] debian/control: Fix missing dependency to gdb

[Florian Bezdeka]

The xenomai testusite - part of the xenomai-runtime package - needs the
gdb binary for testing the gdb support. The dependency was missing so
running the testsuite on a fresh Debian system failed.

Signed-off-by: Florian Bezdeka <florian.bezdeka@siemens.com>
---

Backports to all the stable branches will follow.


 debian/control | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/debian/control b/debian/control
index 857d8ff8f..aba59949c 100644
--- a/debian/control
+++ b/debian/control
@@ -9,7 +9,7 @@ Homepage: http://www.xenomai.org/
 Package: xenomai-runtime
 Section: devel
 Architecture: amd64 arm armeb armel armhf arm64 i386
-Depends: ${shlibs:Depends}, ${misc:Depends}, psmisc, netcat
+Depends: ${shlibs:Depends}, ${misc:Depends}, psmisc, netcat, gdb
 Suggests: xenomai-kernel-source
 Replaces: xenomai
 Conflicts: xenomai
-- 
2.39.2

Re: [PATCH] debian/control: Fix missing dependency to gdb

[Jan Kiszka]

On 27.03.23 12:55, Florian Bezdeka wrote:
> The xenomai testusite - part of the xenomai-runtime package - needs the
> gdb binary for testing the gdb support. The dependency was missing so
> running the testsuite on a fresh Debian system failed.
>
> Signed-off-by: Florian Bezdeka <florian.bezdeka@siemens.com>
> ---
>
> Backports to all the stable branches will follow.
>
>
>  debian/control | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/debian/control b/debian/control
> index 857d8ff8f..aba59949c 100644
> --- a/debian/control
> +++ b/debian/control
> @@ -9,7 +9,7 @@ Homepage: http://www.xenomai.org/
>  Package: xenomai-runtime
>  Section: devel
>  Architecture: amd64 arm armeb armel armhf arm64 i386
> -Depends: ${shlibs:Depends}, ${misc:Depends}, psmisc, netcat
> +Depends: ${shlibs:Depends}, ${misc:Depends}, psmisc, netcat, gdb
>  Suggests: xenomai-kernel-source
>  Replaces: xenomai
>  Conflicts: xenomai

Looks like xenomai-images installed that "manually". Can be dropped once
this fix is in all stable releases.

Eventually, we should split off a testsuite package to allow installing
tools without pulling all those deps of the former...

Jan

Re: [PATCH] debian/control: Fix missing dependency to gdb

[Florian Bezdeka]

On 28.03.23 00:55, Jan Kiszka wrote:
> On 27.03.23 12:55, Florian Bezdeka wrote:
>> The xenomai testusite - part of the xenomai-runtime package - needs the
>> gdb binary for testing the gdb support. The dependency was missing so
>> running the testsuite on a fresh Debian system failed.
>>
>> Signed-off-by: Florian Bezdeka <florian.bezdeka@siemens.com>
>> ---
>>
>> Backports to all the stable branches will follow.
>>
>>
>>  debian/control | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/debian/control b/debian/control
>> index 857d8ff8f..aba59949c 100644
>> --- a/debian/control
>> +++ b/debian/control
>> @@ -9,7 +9,7 @@ Homepage: http://www.xenomai.org/
>>  Package: xenomai-runtime
>>  Section: devel
>>  Architecture: amd64 arm armeb armel armhf arm64 i386
>> -Depends: ${shlibs:Depends}, ${misc:Depends}, psmisc, netcat
>> +Depends: ${shlibs:Depends}, ${misc:Depends}, psmisc, netcat, gdb
>>  Suggests: xenomai-kernel-source
>>  Replaces: xenomai
>>  Conflicts: xenomai
> 
> Looks like xenomai-images installed that "manually". Can be dropped once
> this fix is in all stable releases.
> 
> Eventually, we should split off a testsuite package to allow installing
> tools without pulling all those deps of the former...

Yes, might be the right follow up. I guess the situation is different
for stable branches, so such branches might stay as they are now, right?

> 
> Jan

Re: [PATCH] debian/control: Fix missing dependency to gdb

[Jan Kiszka]

On 28.03.23 16:33, Florian Bezdeka wrote:
> On 28.03.23 00:55, Jan Kiszka wrote:
>> On 27.03.23 12:55, Florian Bezdeka wrote:
>>> The xenomai testusite - part of the xenomai-runtime package - needs the
>>> gdb binary for testing the gdb support. The dependency was missing so
>>> running the testsuite on a fresh Debian system failed.
>>>
>>> Signed-off-by: Florian Bezdeka <florian.bezdeka@siemens.com>
>>> ---
>>>
>>> Backports to all the stable branches will follow.
>>>
>>>
>>>  debian/control | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/debian/control b/debian/control
>>> index 857d8ff8f..aba59949c 100644
>>> --- a/debian/control
>>> +++ b/debian/control
>>> @@ -9,7 +9,7 @@ Homepage: http://www.xenomai.org/
>>>  Package: xenomai-runtime
>>>  Section: devel
>>>  Architecture: amd64 arm armeb armel armhf arm64 i386
>>> -Depends: ${shlibs:Depends}, ${misc:Depends}, psmisc, netcat
>>> +Depends: ${shlibs:Depends}, ${misc:Depends}, psmisc, netcat, gdb
>>>  Suggests: xenomai-kernel-source
>>>  Replaces: xenomai
>>>  Conflicts: xenomai
>>
>> Looks like xenomai-images installed that "manually". Can be dropped once
>> this fix is in all stable releases.
>>
>> Eventually, we should split off a testsuite package to allow installing
>> tools without pulling all those deps of the former...
> 
> Yes, might be the right follow up. I guess the situation is different
> for stable branches, so such branches might stay as they are now, right?
> 

In fact, I would not consider this patch stable-relevant. No one
complained there so far while its side effect is pulling in a rather
large binary. In that light, let's fix this in next and leave stable as
is (manual installation of gdb if testsuite should run those test).

Alternatively, you can make the gdb tests skip in case gdb is missing
for stable.

Jan

-- 
Siemens AG, Technology
Competence Center Embedded Linux

Re: [PATCH] debian/control: Fix missing dependency to gdb

[Florian Bezdeka]

On Mon, 2023-04-03 at 07:14 +0200, Jan Kiszka wrote:
> On 28.03.23 16:33, Florian Bezdeka wrote:
> > On 28.03.23 00:55, Jan Kiszka wrote:
> > > On 27.03.23 12:55, Florian Bezdeka wrote:
> > > > The xenomai testusite - part of the xenomai-runtime package - needs the
> > > > gdb binary for testing the gdb support. The dependency was missing so
> > > > running the testsuite on a fresh Debian system failed.
> > > > 
> > > > Signed-off-by: Florian Bezdeka <florian.bezdeka@siemens.com>
> > > > ---
> > > > 
> > > > Backports to all the stable branches will follow.
> > > > 
> > > > 
> > > >  debian/control | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > > 
> > > > diff --git a/debian/control b/debian/control
> > > > index 857d8ff8f..aba59949c 100644
> > > > --- a/debian/control
> > > > +++ b/debian/control
> > > > @@ -9,7 +9,7 @@ Homepage: http://www.xenomai.org/
> > > >  Package: xenomai-runtime
> > > >  Section: devel
> > > >  Architecture: amd64 arm armeb armel armhf arm64 i386
> > > > -Depends: ${shlibs:Depends}, ${misc:Depends}, psmisc, netcat
> > > > +Depends: ${shlibs:Depends}, ${misc:Depends}, psmisc, netcat, gdb
> > > >  Suggests: xenomai-kernel-source
> > > >  Replaces: xenomai
> > > >  Conflicts: xenomai
> > > 
> > > Looks like xenomai-images installed that "manually". Can be dropped once
> > > this fix is in all stable releases.
> > > 
> > > Eventually, we should split off a testsuite package to allow installing
> > > tools without pulling all those deps of the former...
> > 
> > Yes, might be the right follow up. I guess the situation is different
> > for stable branches, so such branches might stay as they are now, right?
> > 
> 
> In fact, I would not consider this patch stable-relevant. No one
> complained there so far while its side effect is pulling in a rather
> large binary. In that light, let's fix this in next and leave stable as
> is (manual installation of gdb if testsuite should run those test).

I'm fine with that, but to make it clear: We can not clean up xenomai-
images then as we handle all the branches the same way. We have to keep
the manual installation of gdb to make CI happy and gdb tests enabled
(for stable branches).

> 
> Alternatively, you can make the gdb tests skip in case gdb is missing
> for stable.
> 
> Jan
>