* [PATCH] kunit: increase KUNIT_LOG_SIZE to 2048 bytes
@ 2023-03-27 11:53 Heiko Carstens
2023-03-28 18:30 ` Rae Moar
2023-03-29 1:59 ` David Gow
0 siblings, 2 replies; 3+ messages in thread
From: Heiko Carstens @ 2023-03-27 11:53 UTC (permalink / raw)
To: Brendan Higgins, David Gow, Shuah Khan
Cc: Alexander Egorenkov, Vasily Gorbik, Rae Moar, linux-kselftest,
kunit-dev, linux-kernel
The s390 specific test_unwind kunit test has 39 parameterized tests. The
results in debugfs are truncated since the full log doesn't fit into 1500
bytes.
Therefore increase KUNIT_LOG_SIZE to 2048 bytes in a similar way like it
was done recently with commit "kunit: fix bug in debugfs logs of
parameterized tests". With that the whole test result is present.
Reported-by: Alexander Egorenkov <egorenar@linux.ibm.com>
Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
---
include/kunit/test.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/kunit/test.h b/include/kunit/test.h
index 9721584027d8..57b309c6ca27 100644
--- a/include/kunit/test.h
+++ b/include/kunit/test.h
@@ -34,7 +34,7 @@ DECLARE_STATIC_KEY_FALSE(kunit_running);
struct kunit;
/* Size of log associated with test. */
-#define KUNIT_LOG_SIZE 1500
+#define KUNIT_LOG_SIZE 2048
/* Maximum size of parameter description string. */
#define KUNIT_PARAM_DESC_SIZE 128
--
2.37.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] kunit: increase KUNIT_LOG_SIZE to 2048 bytes
2023-03-27 11:53 [PATCH] kunit: increase KUNIT_LOG_SIZE to 2048 bytes Heiko Carstens
@ 2023-03-28 18:30 ` Rae Moar
2023-03-29 1:59 ` David Gow
1 sibling, 0 replies; 3+ messages in thread
From: Rae Moar @ 2023-03-28 18:30 UTC (permalink / raw)
To: Heiko Carstens
Cc: Brendan Higgins, David Gow, Shuah Khan, Alexander Egorenkov,
Vasily Gorbik, linux-kselftest, kunit-dev, linux-kernel
On Mon, Mar 27, 2023 at 7:53 AM Heiko Carstens <hca@linux.ibm.com> wrote:
>
> The s390 specific test_unwind kunit test has 39 parameterized tests. The
> results in debugfs are truncated since the full log doesn't fit into 1500
> bytes.
> Therefore increase KUNIT_LOG_SIZE to 2048 bytes in a similar way like it
> was done recently with commit "kunit: fix bug in debugfs logs of
> parameterized tests". With that the whole test result is present.
>
> Reported-by: Alexander Egorenkov <egorenar@linux.ibm.com>
> Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
> ---
This looks good to me. I don't see an issue increasing the log size.
Maybe eventually we could create a config option or test attribute for
a large log size but for now this seems good. Glad to see people are
starting to get use of the parameterized test logs after the debugfs
fixes.
Thanks!
-Rae
Reviewed-by: Rae Moar <rmoar@google.com>
> include/kunit/test.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/kunit/test.h b/include/kunit/test.h
> index 9721584027d8..57b309c6ca27 100644
> --- a/include/kunit/test.h
> +++ b/include/kunit/test.h
> @@ -34,7 +34,7 @@ DECLARE_STATIC_KEY_FALSE(kunit_running);
> struct kunit;
>
> /* Size of log associated with test. */
> -#define KUNIT_LOG_SIZE 1500
> +#define KUNIT_LOG_SIZE 2048
>
> /* Maximum size of parameter description string. */
> #define KUNIT_PARAM_DESC_SIZE 128
> --
> 2.37.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] kunit: increase KUNIT_LOG_SIZE to 2048 bytes
2023-03-27 11:53 [PATCH] kunit: increase KUNIT_LOG_SIZE to 2048 bytes Heiko Carstens
2023-03-28 18:30 ` Rae Moar
@ 2023-03-29 1:59 ` David Gow
1 sibling, 0 replies; 3+ messages in thread
From: David Gow @ 2023-03-29 1:59 UTC (permalink / raw)
To: Heiko Carstens
Cc: Brendan Higgins, Shuah Khan, Alexander Egorenkov, Vasily Gorbik,
Rae Moar, linux-kselftest, kunit-dev, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1188 bytes --]
On Mon, 27 Mar 2023 at 19:53, Heiko Carstens <hca@linux.ibm.com> wrote:
>
> The s390 specific test_unwind kunit test has 39 parameterized tests. The
> results in debugfs are truncated since the full log doesn't fit into 1500
> bytes.
> Therefore increase KUNIT_LOG_SIZE to 2048 bytes in a similar way like it
> was done recently with commit "kunit: fix bug in debugfs logs of
> parameterized tests". With that the whole test result is present.
>
> Reported-by: Alexander Egorenkov <egorenar@linux.ibm.com>
> Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
> ---
Thanks! This looks fine here.
Reviewed-by: David Gow <davidgow@google.com>
-- David
> include/kunit/test.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/kunit/test.h b/include/kunit/test.h
> index 9721584027d8..57b309c6ca27 100644
> --- a/include/kunit/test.h
> +++ b/include/kunit/test.h
> @@ -34,7 +34,7 @@ DECLARE_STATIC_KEY_FALSE(kunit_running);
> struct kunit;
>
> /* Size of log associated with test. */
> -#define KUNIT_LOG_SIZE 1500
> +#define KUNIT_LOG_SIZE 2048
>
> /* Maximum size of parameter description string. */
> #define KUNIT_PARAM_DESC_SIZE 128
> --
> 2.37.2
>
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4003 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-03-29 1:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-27 11:53 [PATCH] kunit: increase KUNIT_LOG_SIZE to 2048 bytes Heiko Carstens
2023-03-28 18:30 ` Rae Moar
2023-03-29 1:59 ` David Gow
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.