* [PATCH v3 0/2] arm64: dts: rk3399-pinephone-pro: Add display and touchscreen support
@ 2023-03-28 7:33 ` Javier Martinez Canillas
0 siblings, 0 replies; 12+ messages in thread
From: Javier Martinez Canillas @ 2023-03-28 7:33 UTC (permalink / raw)
To: linux-kernel
Cc: Peter Robinson, Tom, Robert Mader, Laurent Pinchart,
Martijn Braam, Ondrej Jirman, Jacopo Mondi, Kamil Trzciński,
Javier Martinez Canillas, Caleb Connolly, Heiko Stuebner,
Jarrah Gosbell, Krzysztof Kozlowski, Rob Herring, devicetree,
linux-arm-kernel, linux-rockchip
Hello,
This series adds support for the display and touchscreen found in the
PinePhone Pro. It's a third version that addresses issues pointed out
by Ondrej Jirman in v2:
http://lists.infradead.org/pipermail/linux-rockchip/2023-March/037889.html
Best regards,
Javier
Changes in v3:
- Fix some ./scripts/checkpatch.pl --strict warnings.
- Add Ondrej Jirman Tested-by tag.
- Change PWM period to 50000 since 20 kHz is recommended (Ondrej Jirman).
- Remove useless comments for the panel regulators (Ondrej Jirman).
- Drop unneeded pinctrl pull down conf for pins that either already have
a pull-down resistor or are already driven by the SoC (Ondrej Jirman).
- Remove "pwm-delay-us" property not supported in mainline (Ondrej Jirman).
- Use the correct "goodix,gt1158" compatible string (Ondrej Jirman).
- Remove "poweroff-in-suspend" not supported in mainline (Ondrej Jirman).
Changes in v2:
- Drop touchscreen node because used the wrong compatible (Ondrej Jirman).
- Fix assigned-clock-parents in vopb node (Ondrej Jirman).
- Add vopl and vopl nodes.
Martijn Braam (2):
arm64: dts: rk3399-pinephone-pro: Add internal display support
arm64: dts: rk3399-pinephone-pro: Add touchscreen support
.../dts/rockchip/rk3399-pinephone-pro.dts | 114 ++++++++++++++++++
1 file changed, 114 insertions(+)
base-commit: 3a93e40326c8f470e71d20b4c42d36767450f38f
--
2.40.0
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v3 0/2] arm64: dts: rk3399-pinephone-pro: Add display and touchscreen support
@ 2023-03-28 7:33 ` Javier Martinez Canillas
0 siblings, 0 replies; 12+ messages in thread
From: Javier Martinez Canillas @ 2023-03-28 7:33 UTC (permalink / raw)
To: linux-kernel
Cc: Peter Robinson, Tom, Robert Mader, Laurent Pinchart,
Martijn Braam, Ondrej Jirman, Jacopo Mondi, Kamil Trzciński,
Javier Martinez Canillas, Caleb Connolly, Heiko Stuebner,
Jarrah Gosbell, Krzysztof Kozlowski, Rob Herring, devicetree,
linux-arm-kernel, linux-rockchip
Hello,
This series adds support for the display and touchscreen found in the
PinePhone Pro. It's a third version that addresses issues pointed out
by Ondrej Jirman in v2:
http://lists.infradead.org/pipermail/linux-rockchip/2023-March/037889.html
Best regards,
Javier
Changes in v3:
- Fix some ./scripts/checkpatch.pl --strict warnings.
- Add Ondrej Jirman Tested-by tag.
- Change PWM period to 50000 since 20 kHz is recommended (Ondrej Jirman).
- Remove useless comments for the panel regulators (Ondrej Jirman).
- Drop unneeded pinctrl pull down conf for pins that either already have
a pull-down resistor or are already driven by the SoC (Ondrej Jirman).
- Remove "pwm-delay-us" property not supported in mainline (Ondrej Jirman).
- Use the correct "goodix,gt1158" compatible string (Ondrej Jirman).
- Remove "poweroff-in-suspend" not supported in mainline (Ondrej Jirman).
Changes in v2:
- Drop touchscreen node because used the wrong compatible (Ondrej Jirman).
- Fix assigned-clock-parents in vopb node (Ondrej Jirman).
- Add vopl and vopl nodes.
Martijn Braam (2):
arm64: dts: rk3399-pinephone-pro: Add internal display support
arm64: dts: rk3399-pinephone-pro: Add touchscreen support
.../dts/rockchip/rk3399-pinephone-pro.dts | 114 ++++++++++++++++++
1 file changed, 114 insertions(+)
base-commit: 3a93e40326c8f470e71d20b4c42d36767450f38f
--
2.40.0
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v3 0/2] arm64: dts: rk3399-pinephone-pro: Add display and touchscreen support
@ 2023-03-28 7:33 ` Javier Martinez Canillas
0 siblings, 0 replies; 12+ messages in thread
From: Javier Martinez Canillas @ 2023-03-28 7:33 UTC (permalink / raw)
To: linux-kernel
Cc: Peter Robinson, Tom, Robert Mader, Laurent Pinchart,
Martijn Braam, Ondrej Jirman, Jacopo Mondi, Kamil Trzciński,
Javier Martinez Canillas, Caleb Connolly, Heiko Stuebner,
Jarrah Gosbell, Krzysztof Kozlowski, Rob Herring, devicetree,
linux-arm-kernel, linux-rockchip
Hello,
This series adds support for the display and touchscreen found in the
PinePhone Pro. It's a third version that addresses issues pointed out
by Ondrej Jirman in v2:
http://lists.infradead.org/pipermail/linux-rockchip/2023-March/037889.html
Best regards,
Javier
Changes in v3:
- Fix some ./scripts/checkpatch.pl --strict warnings.
- Add Ondrej Jirman Tested-by tag.
- Change PWM period to 50000 since 20 kHz is recommended (Ondrej Jirman).
- Remove useless comments for the panel regulators (Ondrej Jirman).
- Drop unneeded pinctrl pull down conf for pins that either already have
a pull-down resistor or are already driven by the SoC (Ondrej Jirman).
- Remove "pwm-delay-us" property not supported in mainline (Ondrej Jirman).
- Use the correct "goodix,gt1158" compatible string (Ondrej Jirman).
- Remove "poweroff-in-suspend" not supported in mainline (Ondrej Jirman).
Changes in v2:
- Drop touchscreen node because used the wrong compatible (Ondrej Jirman).
- Fix assigned-clock-parents in vopb node (Ondrej Jirman).
- Add vopl and vopl nodes.
Martijn Braam (2):
arm64: dts: rk3399-pinephone-pro: Add internal display support
arm64: dts: rk3399-pinephone-pro: Add touchscreen support
.../dts/rockchip/rk3399-pinephone-pro.dts | 114 ++++++++++++++++++
1 file changed, 114 insertions(+)
base-commit: 3a93e40326c8f470e71d20b4c42d36767450f38f
--
2.40.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v3 1/2] arm64: dts: rk3399-pinephone-pro: Add internal display support
2023-03-28 7:33 ` Javier Martinez Canillas
(?)
@ 2023-03-28 7:33 ` Javier Martinez Canillas
-1 siblings, 0 replies; 12+ messages in thread
From: Javier Martinez Canillas @ 2023-03-28 7:33 UTC (permalink / raw)
To: linux-kernel
Cc: Peter Robinson, Tom, Robert Mader, Laurent Pinchart,
Martijn Braam, Ondrej Jirman, Jacopo Mondi, Kamil Trzciński,
Javier Martinez Canillas, Heiko Stuebner, Jarrah Gosbell,
Krzysztof Kozlowski, Rob Herring, devicetree, linux-arm-kernel,
linux-rockchip
From: Martijn Braam <martijn@brixit.nl>
The phone's display is using a Hannstar LCD panel. Support it by adding a
panel DT node and all needed nodes (backlight, MIPI DSI, regulators, etc).
Signed-off-by: Martijn Braam <martijn@brixit.nl>
Co-developed-by: Kamil Trzciński <ayufan@ayufan.eu>
Signed-off-by: Kamil Trzciński <ayufan@ayufan.eu>
Co-developed-by: Ondrej Jirman <megi@xff.cz>
Signed-off-by: Ondrej Jirman <megi@xff.cz>
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
Tested-by: Ondrej Jirman <megi@xff.cz>
---
Changes in v3:
- Fix some ./scripts/checkpatch.pl --strict warnings.
- Add Ondrej Jirman Tested-by tag.
- Change PWM period to 50000 since 20 kHz is recommended (Ondrej Jirman).
- Remove useless comments for the panel regulators (Ondrej Jirman).
- Drop unneeded pinctrl pull down conf for pins that either already have
a pull-down resistor or are already driven by the SoC (Ondrej Jirman).
- Remove "pwm-delay-us" property not supported in mainline (Ondrej Jirman).
Changes in v2:
- Drop touchscreen node because used the wrong compatible (Ondrej Jirman).
- Fix assigned-clock-parents in vopb node (Ondrej Jirman).
- Add vopl and vopl nodes.
.../dts/rockchip/rk3399-pinephone-pro.dts | 95 +++++++++++++++++++
1 file changed, 95 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
index a0795a2b1cb1..539b36e8bff5 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
@@ -29,6 +29,11 @@ chosen {
stdout-path = "serial2:115200n8";
};
+ backlight: backlight {
+ compatible = "pwm-backlight";
+ pwms = <&pwm0 0 50000 0>;
+ };
+
gpio-keys {
compatible = "gpio-keys";
pinctrl-names = "default";
@@ -102,6 +107,30 @@ wifi_pwrseq: sdio-wifi-pwrseq {
/* WL_REG_ON on module */
reset-gpios = <&gpio0 RK_PB2 GPIO_ACTIVE_LOW>;
};
+
+ /* MIPI DSI panel 1.8v supply */
+ vcc1v8_lcd: vcc1v8-lcd {
+ compatible = "regulator-fixed";
+ enable-active-high;
+ regulator-name = "vcc1v8_lcd";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ vin-supply = <&vcc3v3_sys>;
+ gpio = <&gpio3 RK_PA5 GPIO_ACTIVE_HIGH>;
+ pinctrl-names = "default";
+ };
+
+ /* MIPI DSI panel 2.8v supply */
+ vcc2v8_lcd: vcc2v8-lcd {
+ compatible = "regulator-fixed";
+ enable-active-high;
+ regulator-name = "vcc2v8_lcd";
+ regulator-min-microvolt = <2800000>;
+ regulator-max-microvolt = <2800000>;
+ vin-supply = <&vcc3v3_sys>;
+ gpio = <&gpio3 RK_PA1 GPIO_ACTIVE_HIGH>;
+ pinctrl-names = "default";
+ };
};
&cpu_alert0 {
@@ -139,6 +168,11 @@ &emmc_phy {
status = "okay";
};
+&gpu {
+ mali-supply = <&vdd_gpu>;
+ status = "okay";
+};
+
&i2c0 {
clock-frequency = <400000>;
i2c-scl-rising-time-ns = <168>;
@@ -362,6 +396,39 @@ &io_domains {
status = "okay";
};
+&mipi_dsi {
+ status = "okay";
+ clock-master;
+
+ ports {
+ mipi_out: port@1 {
+ #address-cells = <0>;
+ #size-cells = <0>;
+ reg = <1>;
+
+ mipi_out_panel: endpoint {
+ remote-endpoint = <&mipi_in_panel>;
+ };
+ };
+ };
+
+ panel@0 {
+ compatible = "hannstar,hsd060bhw4";
+ reg = <0>;
+ backlight = <&backlight>;
+ reset-gpios = <&gpio4 RK_PD1 GPIO_ACTIVE_LOW>;
+ vcc-supply = <&vcc2v8_lcd>;
+ iovcc-supply = <&vcc1v8_lcd>;
+ pinctrl-names = "default";
+
+ port {
+ mipi_in_panel: endpoint {
+ remote-endpoint = <&mipi_out_panel>;
+ };
+ };
+ };
+};
+
&pmu_io_domains {
pmu1830-supply = <&vcc_1v8>;
status = "okay";
@@ -429,6 +496,10 @@ &sdio0 {
status = "okay";
};
+&pwm0 {
+ status = "okay";
+};
+
&sdmmc {
bus-width = <4>;
cap-sd-highspeed;
@@ -479,3 +550,27 @@ bluetooth {
&uart2 {
status = "okay";
};
+
+&vopb {
+ status = "okay";
+ assigned-clocks = <&cru DCLK_VOP0_DIV>, <&cru DCLK_VOP0>,
+ <&cru ACLK_VOP0>, <&cru HCLK_VOP0>;
+ assigned-clock-rates = <0>, <0>, <400000000>, <100000000>;
+ assigned-clock-parents = <&cru PLL_GPLL>, <&cru DCLK_VOP0_DIV>;
+};
+
+&vopb_mmu {
+ status = "okay";
+};
+
+&vopl {
+ status = "okay";
+ assigned-clocks = <&cru DCLK_VOP1_DIV>, <&cru DCLK_VOP1>,
+ <&cru ACLK_VOP1>, <&cru HCLK_VOP1>;
+ assigned-clock-rates = <0>, <0>, <400000000>, <100000000>;
+ assigned-clock-parents = <&cru PLL_GPLL>, <&cru DCLK_VOP1_DIV>;
+};
+
+&vopl_mmu {
+ status = "okay";
+};
--
2.40.0
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH v3 1/2] arm64: dts: rk3399-pinephone-pro: Add internal display support
@ 2023-03-28 7:33 ` Javier Martinez Canillas
0 siblings, 0 replies; 12+ messages in thread
From: Javier Martinez Canillas @ 2023-03-28 7:33 UTC (permalink / raw)
To: linux-kernel
Cc: Peter Robinson, Tom, Robert Mader, Laurent Pinchart,
Martijn Braam, Ondrej Jirman, Jacopo Mondi, Kamil Trzciński,
Javier Martinez Canillas, Heiko Stuebner, Jarrah Gosbell,
Krzysztof Kozlowski, Rob Herring, devicetree, linux-arm-kernel,
linux-rockchip
From: Martijn Braam <martijn@brixit.nl>
The phone's display is using a Hannstar LCD panel. Support it by adding a
panel DT node and all needed nodes (backlight, MIPI DSI, regulators, etc).
Signed-off-by: Martijn Braam <martijn@brixit.nl>
Co-developed-by: Kamil Trzciński <ayufan@ayufan.eu>
Signed-off-by: Kamil Trzciński <ayufan@ayufan.eu>
Co-developed-by: Ondrej Jirman <megi@xff.cz>
Signed-off-by: Ondrej Jirman <megi@xff.cz>
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
Tested-by: Ondrej Jirman <megi@xff.cz>
---
Changes in v3:
- Fix some ./scripts/checkpatch.pl --strict warnings.
- Add Ondrej Jirman Tested-by tag.
- Change PWM period to 50000 since 20 kHz is recommended (Ondrej Jirman).
- Remove useless comments for the panel regulators (Ondrej Jirman).
- Drop unneeded pinctrl pull down conf for pins that either already have
a pull-down resistor or are already driven by the SoC (Ondrej Jirman).
- Remove "pwm-delay-us" property not supported in mainline (Ondrej Jirman).
Changes in v2:
- Drop touchscreen node because used the wrong compatible (Ondrej Jirman).
- Fix assigned-clock-parents in vopb node (Ondrej Jirman).
- Add vopl and vopl nodes.
.../dts/rockchip/rk3399-pinephone-pro.dts | 95 +++++++++++++++++++
1 file changed, 95 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
index a0795a2b1cb1..539b36e8bff5 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
@@ -29,6 +29,11 @@ chosen {
stdout-path = "serial2:115200n8";
};
+ backlight: backlight {
+ compatible = "pwm-backlight";
+ pwms = <&pwm0 0 50000 0>;
+ };
+
gpio-keys {
compatible = "gpio-keys";
pinctrl-names = "default";
@@ -102,6 +107,30 @@ wifi_pwrseq: sdio-wifi-pwrseq {
/* WL_REG_ON on module */
reset-gpios = <&gpio0 RK_PB2 GPIO_ACTIVE_LOW>;
};
+
+ /* MIPI DSI panel 1.8v supply */
+ vcc1v8_lcd: vcc1v8-lcd {
+ compatible = "regulator-fixed";
+ enable-active-high;
+ regulator-name = "vcc1v8_lcd";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ vin-supply = <&vcc3v3_sys>;
+ gpio = <&gpio3 RK_PA5 GPIO_ACTIVE_HIGH>;
+ pinctrl-names = "default";
+ };
+
+ /* MIPI DSI panel 2.8v supply */
+ vcc2v8_lcd: vcc2v8-lcd {
+ compatible = "regulator-fixed";
+ enable-active-high;
+ regulator-name = "vcc2v8_lcd";
+ regulator-min-microvolt = <2800000>;
+ regulator-max-microvolt = <2800000>;
+ vin-supply = <&vcc3v3_sys>;
+ gpio = <&gpio3 RK_PA1 GPIO_ACTIVE_HIGH>;
+ pinctrl-names = "default";
+ };
};
&cpu_alert0 {
@@ -139,6 +168,11 @@ &emmc_phy {
status = "okay";
};
+&gpu {
+ mali-supply = <&vdd_gpu>;
+ status = "okay";
+};
+
&i2c0 {
clock-frequency = <400000>;
i2c-scl-rising-time-ns = <168>;
@@ -362,6 +396,39 @@ &io_domains {
status = "okay";
};
+&mipi_dsi {
+ status = "okay";
+ clock-master;
+
+ ports {
+ mipi_out: port@1 {
+ #address-cells = <0>;
+ #size-cells = <0>;
+ reg = <1>;
+
+ mipi_out_panel: endpoint {
+ remote-endpoint = <&mipi_in_panel>;
+ };
+ };
+ };
+
+ panel@0 {
+ compatible = "hannstar,hsd060bhw4";
+ reg = <0>;
+ backlight = <&backlight>;
+ reset-gpios = <&gpio4 RK_PD1 GPIO_ACTIVE_LOW>;
+ vcc-supply = <&vcc2v8_lcd>;
+ iovcc-supply = <&vcc1v8_lcd>;
+ pinctrl-names = "default";
+
+ port {
+ mipi_in_panel: endpoint {
+ remote-endpoint = <&mipi_out_panel>;
+ };
+ };
+ };
+};
+
&pmu_io_domains {
pmu1830-supply = <&vcc_1v8>;
status = "okay";
@@ -429,6 +496,10 @@ &sdio0 {
status = "okay";
};
+&pwm0 {
+ status = "okay";
+};
+
&sdmmc {
bus-width = <4>;
cap-sd-highspeed;
@@ -479,3 +550,27 @@ bluetooth {
&uart2 {
status = "okay";
};
+
+&vopb {
+ status = "okay";
+ assigned-clocks = <&cru DCLK_VOP0_DIV>, <&cru DCLK_VOP0>,
+ <&cru ACLK_VOP0>, <&cru HCLK_VOP0>;
+ assigned-clock-rates = <0>, <0>, <400000000>, <100000000>;
+ assigned-clock-parents = <&cru PLL_GPLL>, <&cru DCLK_VOP0_DIV>;
+};
+
+&vopb_mmu {
+ status = "okay";
+};
+
+&vopl {
+ status = "okay";
+ assigned-clocks = <&cru DCLK_VOP1_DIV>, <&cru DCLK_VOP1>,
+ <&cru ACLK_VOP1>, <&cru HCLK_VOP1>;
+ assigned-clock-rates = <0>, <0>, <400000000>, <100000000>;
+ assigned-clock-parents = <&cru PLL_GPLL>, <&cru DCLK_VOP1_DIV>;
+};
+
+&vopl_mmu {
+ status = "okay";
+};
--
2.40.0
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH v3 1/2] arm64: dts: rk3399-pinephone-pro: Add internal display support
@ 2023-03-28 7:33 ` Javier Martinez Canillas
0 siblings, 0 replies; 12+ messages in thread
From: Javier Martinez Canillas @ 2023-03-28 7:33 UTC (permalink / raw)
To: linux-kernel
Cc: Peter Robinson, Tom, Robert Mader, Laurent Pinchart,
Martijn Braam, Ondrej Jirman, Jacopo Mondi, Kamil Trzciński,
Javier Martinez Canillas, Heiko Stuebner, Jarrah Gosbell,
Krzysztof Kozlowski, Rob Herring, devicetree, linux-arm-kernel,
linux-rockchip
From: Martijn Braam <martijn@brixit.nl>
The phone's display is using a Hannstar LCD panel. Support it by adding a
panel DT node and all needed nodes (backlight, MIPI DSI, regulators, etc).
Signed-off-by: Martijn Braam <martijn@brixit.nl>
Co-developed-by: Kamil Trzciński <ayufan@ayufan.eu>
Signed-off-by: Kamil Trzciński <ayufan@ayufan.eu>
Co-developed-by: Ondrej Jirman <megi@xff.cz>
Signed-off-by: Ondrej Jirman <megi@xff.cz>
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
Tested-by: Ondrej Jirman <megi@xff.cz>
---
Changes in v3:
- Fix some ./scripts/checkpatch.pl --strict warnings.
- Add Ondrej Jirman Tested-by tag.
- Change PWM period to 50000 since 20 kHz is recommended (Ondrej Jirman).
- Remove useless comments for the panel regulators (Ondrej Jirman).
- Drop unneeded pinctrl pull down conf for pins that either already have
a pull-down resistor or are already driven by the SoC (Ondrej Jirman).
- Remove "pwm-delay-us" property not supported in mainline (Ondrej Jirman).
Changes in v2:
- Drop touchscreen node because used the wrong compatible (Ondrej Jirman).
- Fix assigned-clock-parents in vopb node (Ondrej Jirman).
- Add vopl and vopl nodes.
.../dts/rockchip/rk3399-pinephone-pro.dts | 95 +++++++++++++++++++
1 file changed, 95 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
index a0795a2b1cb1..539b36e8bff5 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
@@ -29,6 +29,11 @@ chosen {
stdout-path = "serial2:115200n8";
};
+ backlight: backlight {
+ compatible = "pwm-backlight";
+ pwms = <&pwm0 0 50000 0>;
+ };
+
gpio-keys {
compatible = "gpio-keys";
pinctrl-names = "default";
@@ -102,6 +107,30 @@ wifi_pwrseq: sdio-wifi-pwrseq {
/* WL_REG_ON on module */
reset-gpios = <&gpio0 RK_PB2 GPIO_ACTIVE_LOW>;
};
+
+ /* MIPI DSI panel 1.8v supply */
+ vcc1v8_lcd: vcc1v8-lcd {
+ compatible = "regulator-fixed";
+ enable-active-high;
+ regulator-name = "vcc1v8_lcd";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ vin-supply = <&vcc3v3_sys>;
+ gpio = <&gpio3 RK_PA5 GPIO_ACTIVE_HIGH>;
+ pinctrl-names = "default";
+ };
+
+ /* MIPI DSI panel 2.8v supply */
+ vcc2v8_lcd: vcc2v8-lcd {
+ compatible = "regulator-fixed";
+ enable-active-high;
+ regulator-name = "vcc2v8_lcd";
+ regulator-min-microvolt = <2800000>;
+ regulator-max-microvolt = <2800000>;
+ vin-supply = <&vcc3v3_sys>;
+ gpio = <&gpio3 RK_PA1 GPIO_ACTIVE_HIGH>;
+ pinctrl-names = "default";
+ };
};
&cpu_alert0 {
@@ -139,6 +168,11 @@ &emmc_phy {
status = "okay";
};
+&gpu {
+ mali-supply = <&vdd_gpu>;
+ status = "okay";
+};
+
&i2c0 {
clock-frequency = <400000>;
i2c-scl-rising-time-ns = <168>;
@@ -362,6 +396,39 @@ &io_domains {
status = "okay";
};
+&mipi_dsi {
+ status = "okay";
+ clock-master;
+
+ ports {
+ mipi_out: port@1 {
+ #address-cells = <0>;
+ #size-cells = <0>;
+ reg = <1>;
+
+ mipi_out_panel: endpoint {
+ remote-endpoint = <&mipi_in_panel>;
+ };
+ };
+ };
+
+ panel@0 {
+ compatible = "hannstar,hsd060bhw4";
+ reg = <0>;
+ backlight = <&backlight>;
+ reset-gpios = <&gpio4 RK_PD1 GPIO_ACTIVE_LOW>;
+ vcc-supply = <&vcc2v8_lcd>;
+ iovcc-supply = <&vcc1v8_lcd>;
+ pinctrl-names = "default";
+
+ port {
+ mipi_in_panel: endpoint {
+ remote-endpoint = <&mipi_out_panel>;
+ };
+ };
+ };
+};
+
&pmu_io_domains {
pmu1830-supply = <&vcc_1v8>;
status = "okay";
@@ -429,6 +496,10 @@ &sdio0 {
status = "okay";
};
+&pwm0 {
+ status = "okay";
+};
+
&sdmmc {
bus-width = <4>;
cap-sd-highspeed;
@@ -479,3 +550,27 @@ bluetooth {
&uart2 {
status = "okay";
};
+
+&vopb {
+ status = "okay";
+ assigned-clocks = <&cru DCLK_VOP0_DIV>, <&cru DCLK_VOP0>,
+ <&cru ACLK_VOP0>, <&cru HCLK_VOP0>;
+ assigned-clock-rates = <0>, <0>, <400000000>, <100000000>;
+ assigned-clock-parents = <&cru PLL_GPLL>, <&cru DCLK_VOP0_DIV>;
+};
+
+&vopb_mmu {
+ status = "okay";
+};
+
+&vopl {
+ status = "okay";
+ assigned-clocks = <&cru DCLK_VOP1_DIV>, <&cru DCLK_VOP1>,
+ <&cru ACLK_VOP1>, <&cru HCLK_VOP1>;
+ assigned-clock-rates = <0>, <0>, <400000000>, <100000000>;
+ assigned-clock-parents = <&cru PLL_GPLL>, <&cru DCLK_VOP1_DIV>;
+};
+
+&vopl_mmu {
+ status = "okay";
+};
--
2.40.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH v3 2/2] arm64: dts: rk3399-pinephone-pro: Add touchscreen support
2023-03-28 7:33 ` Javier Martinez Canillas
(?)
@ 2023-03-28 7:33 ` Javier Martinez Canillas
-1 siblings, 0 replies; 12+ messages in thread
From: Javier Martinez Canillas @ 2023-03-28 7:33 UTC (permalink / raw)
To: linux-kernel
Cc: Peter Robinson, Tom, Robert Mader, Laurent Pinchart,
Martijn Braam, Ondrej Jirman, Jacopo Mondi, Kamil Trzciński,
Javier Martinez Canillas, Caleb Connolly, Heiko Stuebner,
Jarrah Gosbell, Krzysztof Kozlowski, Rob Herring, devicetree,
linux-arm-kernel, linux-rockchip
From: Martijn Braam <martijn@brixit.nl>
The phone has a Goodix GT1158 touchscreen, add a DT node for it.
Signed-off-by: Martijn Braam <martijn@brixit.nl>
Co-developed-by: Kamil Trzciński <ayufan@ayufan.eu>
Signed-off-by: Kamil Trzciński <ayufan@ayufan.eu>
Co-developed-by: Ondrej Jirman <megi@xff.cz>
Signed-off-by: Ondrej Jirman <megi@xff.cz>
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
---
Changes in v3:
- Use the correct "goodix,gt1158" compatible string (Ondrej Jirman).
- Remove "poweroff-in-suspend" not supported in mainline (Ondrej Jirman).
.../dts/rockchip/rk3399-pinephone-pro.dts | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
index 539b36e8bff5..475ba78acc09 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
@@ -367,6 +367,25 @@ regulator-state-mem {
};
};
+&i2c3 {
+ i2c-scl-rising-time-ns = <450>;
+ i2c-scl-falling-time-ns = <15>;
+ status = "okay";
+
+ touchscreen@14 {
+ compatible = "goodix,gt1158";
+ reg = <0x14>;
+ interrupt-parent = <&gpio3>;
+ interrupts = <RK_PB5 IRQ_TYPE_EDGE_RISING>;
+ irq-gpios = <&gpio3 RK_PB5 GPIO_ACTIVE_HIGH>;
+ reset-gpios = <&gpio3 RK_PB4 GPIO_ACTIVE_HIGH>;
+ AVDD28-supply = <&vcc3v0_touch>;
+ VDDIO-supply = <&vcc3v0_touch>;
+ touchscreen-size-x = <720>;
+ touchscreen-size-y = <1440>;
+ };
+};
+
&cluster0_opp {
opp04 {
status = "disabled";
--
2.40.0
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH v3 2/2] arm64: dts: rk3399-pinephone-pro: Add touchscreen support
@ 2023-03-28 7:33 ` Javier Martinez Canillas
0 siblings, 0 replies; 12+ messages in thread
From: Javier Martinez Canillas @ 2023-03-28 7:33 UTC (permalink / raw)
To: linux-kernel
Cc: Peter Robinson, Tom, Robert Mader, Laurent Pinchart,
Martijn Braam, Ondrej Jirman, Jacopo Mondi, Kamil Trzciński,
Javier Martinez Canillas, Caleb Connolly, Heiko Stuebner,
Jarrah Gosbell, Krzysztof Kozlowski, Rob Herring, devicetree,
linux-arm-kernel, linux-rockchip
From: Martijn Braam <martijn@brixit.nl>
The phone has a Goodix GT1158 touchscreen, add a DT node for it.
Signed-off-by: Martijn Braam <martijn@brixit.nl>
Co-developed-by: Kamil Trzciński <ayufan@ayufan.eu>
Signed-off-by: Kamil Trzciński <ayufan@ayufan.eu>
Co-developed-by: Ondrej Jirman <megi@xff.cz>
Signed-off-by: Ondrej Jirman <megi@xff.cz>
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
---
Changes in v3:
- Use the correct "goodix,gt1158" compatible string (Ondrej Jirman).
- Remove "poweroff-in-suspend" not supported in mainline (Ondrej Jirman).
.../dts/rockchip/rk3399-pinephone-pro.dts | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
index 539b36e8bff5..475ba78acc09 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
@@ -367,6 +367,25 @@ regulator-state-mem {
};
};
+&i2c3 {
+ i2c-scl-rising-time-ns = <450>;
+ i2c-scl-falling-time-ns = <15>;
+ status = "okay";
+
+ touchscreen@14 {
+ compatible = "goodix,gt1158";
+ reg = <0x14>;
+ interrupt-parent = <&gpio3>;
+ interrupts = <RK_PB5 IRQ_TYPE_EDGE_RISING>;
+ irq-gpios = <&gpio3 RK_PB5 GPIO_ACTIVE_HIGH>;
+ reset-gpios = <&gpio3 RK_PB4 GPIO_ACTIVE_HIGH>;
+ AVDD28-supply = <&vcc3v0_touch>;
+ VDDIO-supply = <&vcc3v0_touch>;
+ touchscreen-size-x = <720>;
+ touchscreen-size-y = <1440>;
+ };
+};
+
&cluster0_opp {
opp04 {
status = "disabled";
--
2.40.0
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH v3 2/2] arm64: dts: rk3399-pinephone-pro: Add touchscreen support
@ 2023-03-28 7:33 ` Javier Martinez Canillas
0 siblings, 0 replies; 12+ messages in thread
From: Javier Martinez Canillas @ 2023-03-28 7:33 UTC (permalink / raw)
To: linux-kernel
Cc: Peter Robinson, Tom, Robert Mader, Laurent Pinchart,
Martijn Braam, Ondrej Jirman, Jacopo Mondi, Kamil Trzciński,
Javier Martinez Canillas, Caleb Connolly, Heiko Stuebner,
Jarrah Gosbell, Krzysztof Kozlowski, Rob Herring, devicetree,
linux-arm-kernel, linux-rockchip
From: Martijn Braam <martijn@brixit.nl>
The phone has a Goodix GT1158 touchscreen, add a DT node for it.
Signed-off-by: Martijn Braam <martijn@brixit.nl>
Co-developed-by: Kamil Trzciński <ayufan@ayufan.eu>
Signed-off-by: Kamil Trzciński <ayufan@ayufan.eu>
Co-developed-by: Ondrej Jirman <megi@xff.cz>
Signed-off-by: Ondrej Jirman <megi@xff.cz>
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
---
Changes in v3:
- Use the correct "goodix,gt1158" compatible string (Ondrej Jirman).
- Remove "poweroff-in-suspend" not supported in mainline (Ondrej Jirman).
.../dts/rockchip/rk3399-pinephone-pro.dts | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
index 539b36e8bff5..475ba78acc09 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
@@ -367,6 +367,25 @@ regulator-state-mem {
};
};
+&i2c3 {
+ i2c-scl-rising-time-ns = <450>;
+ i2c-scl-falling-time-ns = <15>;
+ status = "okay";
+
+ touchscreen@14 {
+ compatible = "goodix,gt1158";
+ reg = <0x14>;
+ interrupt-parent = <&gpio3>;
+ interrupts = <RK_PB5 IRQ_TYPE_EDGE_RISING>;
+ irq-gpios = <&gpio3 RK_PB5 GPIO_ACTIVE_HIGH>;
+ reset-gpios = <&gpio3 RK_PB4 GPIO_ACTIVE_HIGH>;
+ AVDD28-supply = <&vcc3v0_touch>;
+ VDDIO-supply = <&vcc3v0_touch>;
+ touchscreen-size-x = <720>;
+ touchscreen-size-y = <1440>;
+ };
+};
+
&cluster0_opp {
opp04 {
status = "disabled";
--
2.40.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH v3 0/2] arm64: dts: rk3399-pinephone-pro: Add display and touchscreen support
2023-03-28 7:33 ` Javier Martinez Canillas
(?)
@ 2023-03-30 11:44 ` Heiko Stuebner
-1 siblings, 0 replies; 12+ messages in thread
From: Heiko Stuebner @ 2023-03-30 11:44 UTC (permalink / raw)
To: Javier Martinez Canillas, linux-kernel
Cc: Heiko Stuebner, Robert Mader, Jarrah Gosbell, linux-rockchip,
Tom, Rob Herring, Martijn Braam, Jacopo Mondi, linux-arm-kernel,
devicetree, Laurent Pinchart, Peter Robinson, Ondrej Jirman,
Krzysztof Kozlowski, Kamil Trzciński, Caleb Connolly
On Tue, 28 Mar 2023 09:33:07 +0200, Javier Martinez Canillas wrote:
> This series adds support for the display and touchscreen found in the
> PinePhone Pro. It's a third version that addresses issues pointed out
> by Ondrej Jirman in v2:
>
> http://lists.infradead.org/pipermail/linux-rockchip/2023-March/037889.html
>
> Best regards,
> Javier
>
> [...]
Applied, thanks!
[1/2] arm64: dts: rk3399-pinephone-pro: Add internal display support
commit: 3e987e1f22b9b9fdb652a5f3f4aff24265c9af05
[2/2] arm64: dts: rk3399-pinephone-pro: Add touchscreen support
commit: 17a23ce930e35d5a84889441efd9208d0445bf18
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v3 0/2] arm64: dts: rk3399-pinephone-pro: Add display and touchscreen support
@ 2023-03-30 11:44 ` Heiko Stuebner
0 siblings, 0 replies; 12+ messages in thread
From: Heiko Stuebner @ 2023-03-30 11:44 UTC (permalink / raw)
To: Javier Martinez Canillas, linux-kernel
Cc: Heiko Stuebner, Robert Mader, Jarrah Gosbell, linux-rockchip,
Tom, Rob Herring, Martijn Braam, Jacopo Mondi, linux-arm-kernel,
devicetree, Laurent Pinchart, Peter Robinson, Ondrej Jirman,
Krzysztof Kozlowski, Kamil Trzciński, Caleb Connolly
On Tue, 28 Mar 2023 09:33:07 +0200, Javier Martinez Canillas wrote:
> This series adds support for the display and touchscreen found in the
> PinePhone Pro. It's a third version that addresses issues pointed out
> by Ondrej Jirman in v2:
>
> http://lists.infradead.org/pipermail/linux-rockchip/2023-March/037889.html
>
> Best regards,
> Javier
>
> [...]
Applied, thanks!
[1/2] arm64: dts: rk3399-pinephone-pro: Add internal display support
commit: 3e987e1f22b9b9fdb652a5f3f4aff24265c9af05
[2/2] arm64: dts: rk3399-pinephone-pro: Add touchscreen support
commit: 17a23ce930e35d5a84889441efd9208d0445bf18
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v3 0/2] arm64: dts: rk3399-pinephone-pro: Add display and touchscreen support
@ 2023-03-30 11:44 ` Heiko Stuebner
0 siblings, 0 replies; 12+ messages in thread
From: Heiko Stuebner @ 2023-03-30 11:44 UTC (permalink / raw)
To: Javier Martinez Canillas, linux-kernel
Cc: Heiko Stuebner, Robert Mader, Jarrah Gosbell, linux-rockchip,
Tom, Rob Herring, Martijn Braam, Jacopo Mondi, linux-arm-kernel,
devicetree, Laurent Pinchart, Peter Robinson, Ondrej Jirman,
Krzysztof Kozlowski, Kamil Trzciński, Caleb Connolly
On Tue, 28 Mar 2023 09:33:07 +0200, Javier Martinez Canillas wrote:
> This series adds support for the display and touchscreen found in the
> PinePhone Pro. It's a third version that addresses issues pointed out
> by Ondrej Jirman in v2:
>
> http://lists.infradead.org/pipermail/linux-rockchip/2023-March/037889.html
>
> Best regards,
> Javier
>
> [...]
Applied, thanks!
[1/2] arm64: dts: rk3399-pinephone-pro: Add internal display support
commit: 3e987e1f22b9b9fdb652a5f3f4aff24265c9af05
[2/2] arm64: dts: rk3399-pinephone-pro: Add touchscreen support
commit: 17a23ce930e35d5a84889441efd9208d0445bf18
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2023-03-30 11:46 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-28 7:33 [PATCH v3 0/2] arm64: dts: rk3399-pinephone-pro: Add display and touchscreen support Javier Martinez Canillas
2023-03-28 7:33 ` Javier Martinez Canillas
2023-03-28 7:33 ` Javier Martinez Canillas
2023-03-28 7:33 ` [PATCH v3 1/2] arm64: dts: rk3399-pinephone-pro: Add internal display support Javier Martinez Canillas
2023-03-28 7:33 ` Javier Martinez Canillas
2023-03-28 7:33 ` Javier Martinez Canillas
2023-03-28 7:33 ` [PATCH v3 2/2] arm64: dts: rk3399-pinephone-pro: Add touchscreen support Javier Martinez Canillas
2023-03-28 7:33 ` Javier Martinez Canillas
2023-03-28 7:33 ` Javier Martinez Canillas
2023-03-30 11:44 ` [PATCH v3 0/2] arm64: dts: rk3399-pinephone-pro: Add display and " Heiko Stuebner
2023-03-30 11:44 ` Heiko Stuebner
2023-03-30 11:44 ` Heiko Stuebner
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.