[PATCH] phy: broadcom: don't duplicate genphy_startup

[PATCH] phy: broadcom: don't duplicate genphy_startup

[Rasmus Villemoes]

Functionally, bcm_cygnus_startup() is an exact copy of
genphy_startup().

Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
---
 drivers/net/phy/broadcom.c | 14 +-------------
 1 file changed, 1 insertion(+), 13 deletions(-)

diff --git a/drivers/net/phy/broadcom.c b/drivers/net/phy/broadcom.c
index 566fcb8de7..5499ff12df 100644
--- a/drivers/net/phy/broadcom.c
+++ b/drivers/net/phy/broadcom.c
@@ -162,18 +162,6 @@ static int bcm5482_config(struct phy_device *phydev)
 	return 0;
 }
 
-static int bcm_cygnus_startup(struct phy_device *phydev)
-{
-	int ret;
-
-	/* Read the Status (2x to make sure link is right) */
-	ret = genphy_update_link(phydev);
-	if (ret)
-		return ret;
-
-	return genphy_parse_link(phydev);
-}
-
 static void bcm_cygnus_afe(struct phy_device *phydev)
 {
 	/* ensures smdspclk is enabled */
@@ -359,7 +347,7 @@ static struct phy_driver BCM_CYGNUS_driver = {
 	.mask = 0xfffff0,
 	.features = PHY_GBIT_FEATURES,
 	.config = &bcm_cygnus_config,
-	.startup = &bcm_cygnus_startup,
+	.startup = &genphy_startup,
 	.shutdown = &genphy_shutdown,
 };
 
-- 
2.37.2

Re: [PATCH] phy: broadcom: don't duplicate genphy_startup

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 265 bytes --]

On Tue, Mar 28, 2023 at 11:12:47PM +0200, Rasmus Villemoes wrote:

> Functionally, bcm_cygnus_startup() is an exact copy of
> genphy_startup().
> 
> Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>

Applied to u-boot/master, thanks!

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]