* [PATCH v3] xen/netback: use same error messages for same errors
@ 2023-03-29 8:02 Juergen Gross
2023-03-29 8:53 ` Jan Beulich
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Juergen Gross @ 2023-03-29 8:02 UTC (permalink / raw)
To: linux-kernel, netdev
Cc: Juergen Gross, Wei Liu, Paul Durrant, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, xen-devel,
Jan Beulich
Issue the same error message in case an illegal page boundary crossing
has been detected in both cases where this is tested.
Suggested-by: Jan Beulich <jbeulich@suse.com>
Signed-off-by: Juergen Gross <jgross@suse.com>
---
V2:
- new patch
V3:
- modify message text (Jan Beulich)
---
drivers/net/xen-netback/netback.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c
index 9ca4b69d3b39..dbaead243737 100644
--- a/drivers/net/xen-netback/netback.c
+++ b/drivers/net/xen-netback/netback.c
@@ -996,10 +996,8 @@ static void xenvif_tx_build_gops(struct xenvif_queue *queue,
/* No crossing a page as the payload mustn't fragment. */
if (unlikely((txreq.offset + txreq.size) > XEN_PAGE_SIZE)) {
- netdev_err(queue->vif->dev,
- "txreq.offset: %u, size: %u, end: %lu\n",
- txreq.offset, txreq.size,
- (unsigned long)(txreq.offset&~XEN_PAGE_MASK) + txreq.size);
+ netdev_err(queue->vif->dev, "Cross page boundary, txreq.offset: %u, size: %u\n",
+ txreq.offset, txreq.size);
xenvif_fatal_tx_err(queue->vif);
break;
}
--
2.35.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v3] xen/netback: use same error messages for same errors
2023-03-29 8:02 [PATCH v3] xen/netback: use same error messages for same errors Juergen Gross
@ 2023-03-29 8:53 ` Jan Beulich
2023-03-30 12:00 ` Paolo Abeni
2023-03-30 13:50 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Jan Beulich @ 2023-03-29 8:53 UTC (permalink / raw)
To: Juergen Gross
Cc: Wei Liu, Paul Durrant, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, xen-devel, linux-kernel, netdev
On 29.03.2023 10:02, Juergen Gross wrote:
> Issue the same error message in case an illegal page boundary crossing
> has been detected in both cases where this is tested.
>
> Suggested-by: Jan Beulich <jbeulich@suse.com>
> Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v3] xen/netback: use same error messages for same errors
2023-03-29 8:02 [PATCH v3] xen/netback: use same error messages for same errors Juergen Gross
2023-03-29 8:53 ` Jan Beulich
@ 2023-03-30 12:00 ` Paolo Abeni
2023-03-30 13:50 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Paolo Abeni @ 2023-03-30 12:00 UTC (permalink / raw)
To: Juergen Gross, linux-kernel, netdev
Cc: Wei Liu, Paul Durrant, David S. Miller, Eric Dumazet,
Jakub Kicinski, xen-devel, Jan Beulich
Hello,
On Wed, 2023-03-29 at 10:02 +0200, Juergen Gross wrote:
> Issue the same error message in case an illegal page boundary crossing
> has been detected in both cases where this is tested.
>
> Suggested-by: Jan Beulich <jbeulich@suse.com>
> Signed-off-by: Juergen Gross <jgross@suse.com>
As this was intended to be part of:
xen/netback: fix issue introduced recently
I'm going to apply this one on net, unless someone screams very loudly,
very soon :)
thanks!
Paolo
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v3] xen/netback: use same error messages for same errors
2023-03-29 8:02 [PATCH v3] xen/netback: use same error messages for same errors Juergen Gross
2023-03-29 8:53 ` Jan Beulich
2023-03-30 12:00 ` Paolo Abeni
@ 2023-03-30 13:50 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-03-30 13:50 UTC (permalink / raw)
To: Juergen Gross
Cc: linux-kernel, netdev, wei.liu, paul, davem, edumazet, kuba,
pabeni, xen-devel, jbeulich
Hello:
This patch was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@redhat.com>:
On Wed, 29 Mar 2023 10:02:59 +0200 you wrote:
> Issue the same error message in case an illegal page boundary crossing
> has been detected in both cases where this is tested.
>
> Suggested-by: Jan Beulich <jbeulich@suse.com>
> Signed-off-by: Juergen Gross <jgross@suse.com>
> ---
> V2:
> - new patch
> V3:
> - modify message text (Jan Beulich)
>
> [...]
Here is the summary with links:
- [v3] xen/netback: use same error messages for same errors
https://git.kernel.org/netdev/net/c/2eca98e5b24d
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-03-30 13:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-29 8:02 [PATCH v3] xen/netback: use same error messages for same errors Juergen Gross
2023-03-29 8:53 ` Jan Beulich
2023-03-30 12:00 ` Paolo Abeni
2023-03-30 13:50 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.