All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alex Deucher <alexander.deucher@amd.com>
To: <amd-gfx@lists.freedesktop.org>
Cc: "Alex Deucher" <alexander.deucher@amd.com>,
	"Christian König" <christian.koenig@amd.com>
Subject: [PATCH 13/13] drm/amdgpu: add debugfs interface for reading MQDs
Date: Thu, 30 Mar 2023 15:17:50 -0400	[thread overview]
Message-ID: <20230330191750.1134210-14-alexander.deucher@amd.com> (raw)
In-Reply-To: <20230330191750.1134210-1-alexander.deucher@amd.com>

Provide a debugfs interface to access the MQD.  Useful for
debugging issues with the CP and MES hardware scheduler.

v2: fix missing unreserve/unmap when pos >= size (Alex)

Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c | 60 +++++++++++++++++++++++-
 1 file changed, 59 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c
index dc474b809604..c3b7654678c4 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c
@@ -478,6 +478,59 @@ static const struct file_operations amdgpu_debugfs_ring_fops = {
 	.llseek = default_llseek
 };
 
+static ssize_t amdgpu_debugfs_mqd_read(struct file *f, char __user *buf,
+				       size_t size, loff_t *pos)
+{
+	struct amdgpu_ring *ring = file_inode(f)->i_private;
+	volatile u32 *mqd;
+	int r;
+	uint32_t value, result;
+
+	if (*pos & 3 || size & 3)
+		return -EINVAL;
+
+	result = 0;
+
+	r = amdgpu_bo_reserve(ring->mqd_obj, false);
+	if (unlikely(r != 0))
+		return r;
+
+	r = amdgpu_bo_kmap(ring->mqd_obj, (void **)&mqd);
+	if (r) {
+		amdgpu_bo_unreserve(ring->mqd_obj);
+		return r;
+	}
+
+	while (size) {
+		if (*pos >= ring->mqd_size)
+			goto done;
+
+		value = mqd[*pos/4];
+		r = put_user(value, (uint32_t *)buf);
+		if (r)
+			goto done;
+		buf += 4;
+		result += 4;
+		size -= 4;
+		*pos += 4;
+	}
+
+done:
+	amdgpu_bo_kunmap(ring->mqd_obj);
+	mqd = NULL;
+	amdgpu_bo_unreserve(ring->mqd_obj);
+	if (r)
+		return r;
+
+	return result;
+}
+
+static const struct file_operations amdgpu_debugfs_mqd_fops = {
+	.owner = THIS_MODULE,
+	.read = amdgpu_debugfs_mqd_read,
+	.llseek = default_llseek
+};
+
 #endif
 
 void amdgpu_debugfs_ring_init(struct amdgpu_device *adev,
@@ -492,7 +545,12 @@ void amdgpu_debugfs_ring_init(struct amdgpu_device *adev,
 	debugfs_create_file_size(name, S_IFREG | S_IRUGO, root, ring,
 				 &amdgpu_debugfs_ring_fops,
 				 ring->ring_size + 12);
-
+	if (ring->mqd_obj) {
+		sprintf(name, "amdgpu_mqd_%s", ring->name);
+		debugfs_create_file_size(name, S_IFREG | S_IRUGO, root, ring,
+					 &amdgpu_debugfs_mqd_fops,
+					 ring->mqd_size);
+	}
 #endif
 }
 
-- 
2.39.2


  parent reply	other threads:[~2023-03-30 19:18 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-30 19:17 [PATCH V4 00/13] Enable FW assisted shadowing for GFX11 Alex Deucher
2023-03-30 19:17 ` [PATCH 01/13] drm/amdgpu/gfx11: add FW version check for new CP GFX shadow feature Alex Deucher
2023-03-30 19:17 ` [PATCH 02/13] drm/amdgpu/gfx11: check the CP FW version CP GFX shadow support Alex Deucher
2023-03-31  6:34   ` Christian König
2023-03-31 19:18     ` Alex Deucher
2023-03-30 19:17 ` [PATCH 03/13] drm/amdgpu/UAPI: add new CS chunk for GFX shadow buffers Alex Deucher
2023-04-06  7:36   ` Marek Olšák
2023-04-06  9:09     ` Christian König
2023-04-06  9:43       ` Marek Olšák
2023-04-06 10:31         ` Christian König
2023-04-06 15:01           ` Marek Olšák
2023-04-09 15:21             ` Christian König
2023-04-13  9:21               ` Marek Olšák
2023-04-13 11:32                 ` Christian König
2023-04-13 12:26                   ` Alex Deucher
2023-04-13 15:54                     ` Christian König
2023-04-13 16:56                       ` Alex Deucher
2023-04-13 18:23                         ` Marek Olšák
2023-04-13 18:58                           ` Christian König
2023-03-30 19:17 ` [PATCH 04/13] drm/amdgpu: add gfx shadow CS IOCTL support Alex Deucher
2023-03-31  6:33   ` Christian König
2023-03-30 19:17 ` [PATCH 05/13] drm/amdgpu: add gfx11 emit shadow callback Alex Deucher
2023-03-30 19:17 ` [PATCH 06/13] drm/amdgpu: don't require a job for cond_exec and shadow Alex Deucher
2023-03-30 19:17 ` [PATCH 07/13] drm/amdgpu: add UAPI to query GFX shadow sizes Alex Deucher
2023-03-30 19:17 ` [PATCH 08/13] drm/amdgpu: add gfx shadow callback Alex Deucher
2023-03-30 19:17 ` [PATCH 09/13] drm/amdgpu: add get_gfx_shadow_info callback for gfx11 Alex Deucher
2023-04-19 22:11   ` Alex Deucher
2023-03-30 19:17 ` [PATCH 10/13] drm/amdgpu: add support for new GFX shadow size query Alex Deucher
2023-04-19 22:12   ` Alex Deucher
2023-03-30 19:17 ` [PATCH 11/13] drm/amdgpu: bump driver version number for CP GFX shadow Alex Deucher
2023-04-19 22:12   ` Alex Deucher
2023-03-30 19:17 ` [PATCH 12/13] drm/amdgpu: track MQD size for gfx and compute Alex Deucher
2023-03-30 19:17 ` Alex Deucher [this message]
  -- strict thread matches above, loose matches on Subject: below --
2023-03-29 15:25 [PATCH V3 00/13] Enable FW assisted shadowing for GFX11 Alex Deucher
2023-03-29 15:25 ` [PATCH 13/13] drm/amdgpu: add debugfs interface for reading MQDs Alex Deucher
2023-03-23 21:40 [PATCH V3 00/13] Enable FW assisted shadowing for GFX11 Alex Deucher
2023-03-23 21:40 ` [PATCH 13/13] drm/amdgpu: add debugfs interface for reading MQDs Alex Deucher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230330191750.1134210-14-alexander.deucher@amd.com \
    --to=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=christian.koenig@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.