All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Christian König" <christian.koenig@amd.com>
To: Alex Deucher <alexander.deucher@amd.com>, amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH 02/13] drm/amdgpu/gfx11: check the CP FW version CP GFX shadow support
Date: Fri, 31 Mar 2023 08:34:46 +0200	[thread overview]
Message-ID: <ecf2a379-4b8d-a168-f555-26f66d5d5e9b@amd.com> (raw)
In-Reply-To: <20230330191750.1134210-3-alexander.deucher@amd.com>

Am 30.03.23 um 21:17 schrieb Alex Deucher:
> Only set the supported flag if we have new enough CP FW.
>
> XXX: don't commit this until the CP FW versions are finalized!

Maybe commit the rest of this series and just hold back this one?

It should still keep everything working.

Regards,
Christian.

>
> Acked-by: Christian König <christian.koenig@amd.com>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 9 +++++++++
>   1 file changed, 9 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c
> index a0d830dc0d01..4a50d0fbcdcf 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c
> @@ -469,6 +469,15 @@ static void gfx_v11_0_check_fw_cp_gfx_shadow(struct amdgpu_device *adev)
>   	case IP_VERSION(11, 0, 0):
>   	case IP_VERSION(11, 0, 2):
>   	case IP_VERSION(11, 0, 3):
> +		/* XXX fix me! */
> +		if ((adev->gfx.me_fw_version >= 1498) &&
> +		    (adev->gfx.me_feature_version >= 29) &&
> +		    (adev->gfx.pfp_fw_version >= 1541) &&
> +		    (adev->gfx.pfp_feature_version >= 29) &&
> +		    (adev->gfx.mec_fw_version >= 507) &&
> +		    (adev->gfx.mec_feature_version >= 29))
> +			adev->gfx.cp_gfx_shadow = true;
> +		break;
>   	default:
>   		adev->gfx.cp_gfx_shadow = false;
>   		break;


  reply	other threads:[~2023-03-31  6:34 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-30 19:17 [PATCH V4 00/13] Enable FW assisted shadowing for GFX11 Alex Deucher
2023-03-30 19:17 ` [PATCH 01/13] drm/amdgpu/gfx11: add FW version check for new CP GFX shadow feature Alex Deucher
2023-03-30 19:17 ` [PATCH 02/13] drm/amdgpu/gfx11: check the CP FW version CP GFX shadow support Alex Deucher
2023-03-31  6:34   ` Christian König [this message]
2023-03-31 19:18     ` Alex Deucher
2023-03-30 19:17 ` [PATCH 03/13] drm/amdgpu/UAPI: add new CS chunk for GFX shadow buffers Alex Deucher
2023-04-06  7:36   ` Marek Olšák
2023-04-06  9:09     ` Christian König
2023-04-06  9:43       ` Marek Olšák
2023-04-06 10:31         ` Christian König
2023-04-06 15:01           ` Marek Olšák
2023-04-09 15:21             ` Christian König
2023-04-13  9:21               ` Marek Olšák
2023-04-13 11:32                 ` Christian König
2023-04-13 12:26                   ` Alex Deucher
2023-04-13 15:54                     ` Christian König
2023-04-13 16:56                       ` Alex Deucher
2023-04-13 18:23                         ` Marek Olšák
2023-04-13 18:58                           ` Christian König
2023-03-30 19:17 ` [PATCH 04/13] drm/amdgpu: add gfx shadow CS IOCTL support Alex Deucher
2023-03-31  6:33   ` Christian König
2023-03-30 19:17 ` [PATCH 05/13] drm/amdgpu: add gfx11 emit shadow callback Alex Deucher
2023-03-30 19:17 ` [PATCH 06/13] drm/amdgpu: don't require a job for cond_exec and shadow Alex Deucher
2023-03-30 19:17 ` [PATCH 07/13] drm/amdgpu: add UAPI to query GFX shadow sizes Alex Deucher
2023-03-30 19:17 ` [PATCH 08/13] drm/amdgpu: add gfx shadow callback Alex Deucher
2023-03-30 19:17 ` [PATCH 09/13] drm/amdgpu: add get_gfx_shadow_info callback for gfx11 Alex Deucher
2023-04-19 22:11   ` Alex Deucher
2023-03-30 19:17 ` [PATCH 10/13] drm/amdgpu: add support for new GFX shadow size query Alex Deucher
2023-04-19 22:12   ` Alex Deucher
2023-03-30 19:17 ` [PATCH 11/13] drm/amdgpu: bump driver version number for CP GFX shadow Alex Deucher
2023-04-19 22:12   ` Alex Deucher
2023-03-30 19:17 ` [PATCH 12/13] drm/amdgpu: track MQD size for gfx and compute Alex Deucher
2023-03-30 19:17 ` [PATCH 13/13] drm/amdgpu: add debugfs interface for reading MQDs Alex Deucher
  -- strict thread matches above, loose matches on Subject: below --
2023-03-29 15:25 [PATCH V3 00/13] Enable FW assisted shadowing for GFX11 Alex Deucher
2023-03-29 15:25 ` [PATCH 02/13] drm/amdgpu/gfx11: check the CP FW version CP GFX shadow support Alex Deucher
2023-03-23 21:40 [PATCH V3 00/13] Enable FW assisted shadowing for GFX11 Alex Deucher
2023-03-23 21:40 ` [PATCH 02/13] drm/amdgpu/gfx11: check the CP FW version CP GFX shadow support Alex Deucher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ecf2a379-4b8d-a168-f555-26f66d5d5e9b@amd.com \
    --to=christian.koenig@amd.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.