All of lore.kernel.org
 help / color / mirror / Atom feed
* [android-common:android-4.19-stable 2/2] fs/verity/enable.c:26:16: error: implicit declaration of function 'find_get_page_flags'
@ 2023-04-04  4:05 kernel test robot
  0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2023-04-04  4:05 UTC (permalink / raw)
  To: cros-kernel-buildreports; +Cc: oe-kbuild-all

tree:   https://android.googlesource.com/kernel/common android-4.19-stable
head:   e8676808abe2a4dd79bd76700719c360d84b343d
commit: e8676808abe2a4dd79bd76700719c360d84b343d [2/2] UPSTREAM: fsverity: don't drop pagecache at end of FS_IOC_ENABLE_VERITY
config: x86_64-randconfig-a016-20230403 (https://download.01.org/0day-ci/archive/20230404/202304041149.OVu2XwxA-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
reproduce (this is a W=1 build):
        git remote add android-common https://android.googlesource.com/kernel/common
        git fetch --no-tags android-common android-4.19-stable
        git checkout e8676808abe2a4dd79bd76700719c360d84b343d
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=x86_64 olddefconfig
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash fs/verity/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202304041149.OVu2XwxA-lkp@intel.com/

All error/warnings (new ones prefixed by >>):

   fs/verity/enable.c: In function 'read_file_data_page':
>> fs/verity/enable.c:26:16: error: implicit declaration of function 'find_get_page_flags' [-Werror=implicit-function-declaration]
      26 |         page = find_get_page_flags(filp->f_mapping, index, FGP_ACCESSED);
         |                ^~~~~~~~~~~~~~~~~~~
>> fs/verity/enable.c:26:60: error: 'FGP_ACCESSED' undeclared (first use in this function); did you mean 'FL_ACCESS'?
      26 |         page = find_get_page_flags(filp->f_mapping, index, FGP_ACCESSED);
         |                                                            ^~~~~~~~~~~~
         |                                                            FL_ACCESS
   fs/verity/enable.c:26:60: note: each undeclared identifier is reported only once for each function it appears in
>> fs/verity/enable.c:27:23: error: implicit declaration of function 'PageUptodate' [-Werror=implicit-function-declaration]
      27 |         if (!page || !PageUptodate(page)) {
         |                       ^~~~~~~~~~~~
>> fs/verity/enable.c:29:25: error: implicit declaration of function 'put_page'; did you mean 'pgd_page'? [-Werror=implicit-function-declaration]
      29 |                         put_page(page);
         |                         ^~~~~~~~
         |                         pgd_page
>> fs/verity/enable.c:31:25: error: implicit declaration of function 'page_cache_sync_readahead' [-Werror=implicit-function-declaration]
      31 |                         page_cache_sync_readahead(filp->f_mapping, ra, filp,
         |                         ^~~~~~~~~~~~~~~~~~~~~~~~~
>> fs/verity/enable.c:33:24: error: implicit declaration of function 'read_mapping_page' [-Werror=implicit-function-declaration]
      33 |                 page = read_mapping_page(filp->f_mapping, index, NULL);
         |                        ^~~~~~~~~~~~~~~~~
>> fs/verity/enable.c:33:22: warning: assignment to 'struct page *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
      33 |                 page = read_mapping_page(filp->f_mapping, index, NULL);
         |                      ^
>> fs/verity/enable.c:37:13: error: implicit declaration of function 'PageReadahead' [-Werror=implicit-function-declaration]
      37 |         if (PageReadahead(page))
         |             ^~~~~~~~~~~~~
>> fs/verity/enable.c:38:17: error: implicit declaration of function 'page_cache_async_readahead' [-Werror=implicit-function-declaration]
      38 |                 page_cache_async_readahead(filp->f_mapping, ra, filp, page,
         |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors


vim +/find_get_page_flags +26 fs/verity/enable.c

43005f9bdbe63b Eric Biggers 2019-07-22  15  
9630eacb1ee572 Eric Biggers 2020-01-06  16  /*
9630eacb1ee572 Eric Biggers 2020-01-06  17   * Read a file data page for Merkle tree construction.  Do aggressive readahead,
9630eacb1ee572 Eric Biggers 2020-01-06  18   * since we're sequentially reading the entire file.
9630eacb1ee572 Eric Biggers 2020-01-06  19   */
9630eacb1ee572 Eric Biggers 2020-01-06  20  static struct page *read_file_data_page(struct file *filp, pgoff_t index,
9630eacb1ee572 Eric Biggers 2020-01-06  21  					struct file_ra_state *ra,
9630eacb1ee572 Eric Biggers 2020-01-06  22  					unsigned long remaining_pages)
9630eacb1ee572 Eric Biggers 2020-01-06  23  {
9630eacb1ee572 Eric Biggers 2020-01-06  24  	struct page *page;
9630eacb1ee572 Eric Biggers 2020-01-06  25  
9630eacb1ee572 Eric Biggers 2020-01-06 @26  	page = find_get_page_flags(filp->f_mapping, index, FGP_ACCESSED);
9630eacb1ee572 Eric Biggers 2020-01-06 @27  	if (!page || !PageUptodate(page)) {
9630eacb1ee572 Eric Biggers 2020-01-06  28  		if (page)
9630eacb1ee572 Eric Biggers 2020-01-06 @29  			put_page(page);
9630eacb1ee572 Eric Biggers 2020-01-06  30  		else
9630eacb1ee572 Eric Biggers 2020-01-06 @31  			page_cache_sync_readahead(filp->f_mapping, ra, filp,
9630eacb1ee572 Eric Biggers 2020-01-06  32  						  index, remaining_pages);
9630eacb1ee572 Eric Biggers 2020-01-06 @33  		page = read_mapping_page(filp->f_mapping, index, NULL);
9630eacb1ee572 Eric Biggers 2020-01-06  34  		if (IS_ERR(page))
9630eacb1ee572 Eric Biggers 2020-01-06  35  			return page;
9630eacb1ee572 Eric Biggers 2020-01-06  36  	}
9630eacb1ee572 Eric Biggers 2020-01-06 @37  	if (PageReadahead(page))
9630eacb1ee572 Eric Biggers 2020-01-06 @38  		page_cache_async_readahead(filp->f_mapping, ra, filp, page,
9630eacb1ee572 Eric Biggers 2020-01-06  39  					   index, remaining_pages);
9630eacb1ee572 Eric Biggers 2020-01-06  40  	return page;
9630eacb1ee572 Eric Biggers 2020-01-06  41  }
9630eacb1ee572 Eric Biggers 2020-01-06  42  

:::::: The code at line 26 was first introduced by commit
:::::: 9630eacb1ee572392628c4b96daa8031e84af56e fs-verity: implement readahead for FS_IOC_ENABLE_VERITY

:::::: TO: Eric Biggers <ebiggers@google.com>
:::::: CC: Jaegeuk Kim <jaegeuk@google.com>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests

^ permalink raw reply	[flat|nested] only message in thread
only message in thread, other threads:[~2023-04-04  4:06 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-04  4:05 [android-common:android-4.19-stable 2/2] fs/verity/enable.c:26:16: error: implicit declaration of function 'find_get_page_flags' kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.