From: Leonardo Bras <leobras@redhat.com> To: Paul Walmsley <paul.walmsley@sifive.com>, Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>, Leonardo Bras <leobras@redhat.com>, Guo Ren <guoren@kernel.org>, Andrea Parri <parri.andrea@gmail.com>, Conor Dooley <conor.dooley@microchip.com> Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [RFC PATCH v3 0/6] Deduplicating RISCV cmpxchg.h macros Date: Tue, 4 Apr 2023 13:37:35 -0300 [thread overview] Message-ID: <20230404163741.2762165-1-leobras@redhat.com> (raw) While studying riscv's cmpxchg.h file, I got really interested in understanding how RISCV asm implemented the different versions of {cmp,}xchg. When I understood the pattern, it made sense for me to remove the duplications and create macros to make it easier to understand what exactly changes between the versions: Instruction sufixes & barriers. I split those changes in 3 levels for each cmpxchg and xchg, resulting a total of 6 patches. I did this so it becomes easier to review and remove the last levels if desired, but I have no issue squashing them if it's better. Please provide comments. Thanks! Leo Changes since v2: - Fixed macros that depend on having a local variable with a magic name - Previous cast to (long) is now only applied on 4-bytes cmpxchg Changes since v1: - Fixed patch 4/6 suffix from 'w.aqrl' to '.w.aqrl', to avoid build error Leonardo Bras (6): riscv/cmpxchg: Deduplicate cmpxchg() asm functions riscv/cmpxchg: Deduplicate cmpxchg() macros riscv/cmpxchg: Deduplicate arch_cmpxchg() macros riscv/cmpxchg: Deduplicate xchg() asm functions riscv/cmpxchg: Deduplicate xchg() macros riscv/cmpxchg: Deduplicate arch_xchg() macros arch/riscv/include/asm/cmpxchg.h | 319 +++++++------------------------ 1 file changed, 67 insertions(+), 252 deletions(-) -- 2.40.0
WARNING: multiple messages have this Message-ID (diff)
From: Leonardo Bras <leobras@redhat.com> To: Paul Walmsley <paul.walmsley@sifive.com>, Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>, Leonardo Bras <leobras@redhat.com>, Guo Ren <guoren@kernel.org>, Andrea Parri <parri.andrea@gmail.com>, Conor Dooley <conor.dooley@microchip.com> Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [RFC PATCH v3 0/6] Deduplicating RISCV cmpxchg.h macros Date: Tue, 4 Apr 2023 13:37:35 -0300 [thread overview] Message-ID: <20230404163741.2762165-1-leobras@redhat.com> (raw) While studying riscv's cmpxchg.h file, I got really interested in understanding how RISCV asm implemented the different versions of {cmp,}xchg. When I understood the pattern, it made sense for me to remove the duplications and create macros to make it easier to understand what exactly changes between the versions: Instruction sufixes & barriers. I split those changes in 3 levels for each cmpxchg and xchg, resulting a total of 6 patches. I did this so it becomes easier to review and remove the last levels if desired, but I have no issue squashing them if it's better. Please provide comments. Thanks! Leo Changes since v2: - Fixed macros that depend on having a local variable with a magic name - Previous cast to (long) is now only applied on 4-bytes cmpxchg Changes since v1: - Fixed patch 4/6 suffix from 'w.aqrl' to '.w.aqrl', to avoid build error Leonardo Bras (6): riscv/cmpxchg: Deduplicate cmpxchg() asm functions riscv/cmpxchg: Deduplicate cmpxchg() macros riscv/cmpxchg: Deduplicate arch_cmpxchg() macros riscv/cmpxchg: Deduplicate xchg() asm functions riscv/cmpxchg: Deduplicate xchg() macros riscv/cmpxchg: Deduplicate arch_xchg() macros arch/riscv/include/asm/cmpxchg.h | 319 +++++++------------------------ 1 file changed, 67 insertions(+), 252 deletions(-) -- 2.40.0 _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
next reply other threads:[~2023-04-04 16:38 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-04-04 16:37 Leonardo Bras [this message] 2023-04-04 16:37 ` [RFC PATCH v3 0/6] Deduplicating RISCV cmpxchg.h macros Leonardo Bras 2023-04-04 16:37 ` [RFC PATCH v3 1/6] riscv/cmpxchg: Deduplicate cmpxchg() asm functions Leonardo Bras 2023-04-04 16:37 ` Leonardo Bras 2023-04-04 16:37 ` [RFC PATCH v3 2/6] riscv/cmpxchg: Deduplicate cmpxchg() macros Leonardo Bras 2023-04-04 16:37 ` Leonardo Bras 2023-04-04 16:37 ` [RFC PATCH v3 3/6] riscv/cmpxchg: Deduplicate arch_cmpxchg() macros Leonardo Bras 2023-04-04 16:37 ` Leonardo Bras 2023-04-04 16:37 ` [RFC PATCH v3 4/6] riscv/cmpxchg: Deduplicate xchg() asm functions Leonardo Bras 2023-04-04 16:37 ` Leonardo Bras 2023-04-04 16:37 ` [RFC PATCH v3 5/6] riscv/cmpxchg: Deduplicate xchg() macros Leonardo Bras 2023-04-04 16:37 ` Leonardo Bras 2023-04-04 16:37 ` [RFC PATCH v3 6/6] riscv/cmpxchg: Deduplicate arch_xchg() macros Leonardo Bras 2023-04-04 16:37 ` Leonardo Bras 2023-04-06 2:39 ` [RFC PATCH v3 0/6] Deduplicating RISCV cmpxchg.h macros Guo Ren 2023-04-06 2:39 ` Guo Ren 2023-04-06 8:04 ` Leonardo Bras Soares Passos 2023-04-06 8:04 ` Leonardo Bras Soares Passos
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230404163741.2762165-1-leobras@redhat.com \ --to=leobras@redhat.com \ --cc=aou@eecs.berkeley.edu \ --cc=conor.dooley@microchip.com \ --cc=guoren@kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-riscv@lists.infradead.org \ --cc=palmer@dabbelt.com \ --cc=parri.andrea@gmail.com \ --cc=paul.walmsley@sifive.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.