All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2 0/2] Add PWM fan support to Rock 5B board
@ 2023-04-04 17:38 ` Cristian Ciocaltea
  0 siblings, 0 replies; 30+ messages in thread
From: Cristian Ciocaltea @ 2023-04-04 17:38 UTC (permalink / raw)
  To: Jean Delvare, Guenter Roeck, Rob Herring, Krzysztof Kozlowski,
	Heiko Stuebner
  Cc: linux-hwmon, devicetree, linux-kernel, linux-arm-kernel,
	linux-rockchip, kernel

This patch series enables support for the PWM controlled heat sink fan 
on the Rock 5B SBC and, additionally, converts the hwmon PWM fan bindings 
to DT schema format.

Changes in v2:
 - Updated PATCH 1/2 according to Rob's review
 - Added Reviewed-by from Christopher to PATCH 2/2
 - v1: https://lore.kernel.org/lkml/20230403105052.426135-1-cristian.ciocaltea@collabora.com/

Cristian Ciocaltea (2):
  dt-bindings: hwmon: pwm-fan: Convert to DT schema
  arm64: dts: rockchip: rk3588-rock-5b: Add pwm-fan

 .../devicetree/bindings/hwmon/pwm-fan.txt     |  68 +---------
 .../devicetree/bindings/hwmon/pwm-fan.yaml    | 119 ++++++++++++++++++
 .../boot/dts/rockchip/rk3588-rock-5b.dts      |  12 ++
 3 files changed, 132 insertions(+), 67 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/hwmon/pwm-fan.yaml

-- 
2.40.0


^ permalink raw reply	[flat|nested] 30+ messages in thread
* [PATCH v2 0/2] Add PWM fan support to Rock 5B board
@ 2023-04-04 17:38 ` Cristian Ciocaltea
  0 siblings, 0 replies; 30+ messages in thread
From: Cristian Ciocaltea @ 2023-04-04 17:38 UTC (permalink / raw)
  To: Jean Delvare, Guenter Roeck, Rob Herring, Krzysztof Kozlowski,
	Heiko Stuebner
  Cc: linux-hwmon, devicetree, linux-kernel, linux-arm-kernel,
	linux-rockchip, kernel

This patch series enables support for the PWM controlled heat sink fan 
on the Rock 5B SBC and, additionally, converts the hwmon PWM fan bindings 
to DT schema format.

Changes in v2:
 - Updated PATCH 1/2 according to Rob's review
 - Added Reviewed-by from Christopher to PATCH 2/2
 - v1: https://lore.kernel.org/lkml/20230403105052.426135-1-cristian.ciocaltea@collabora.com/

Cristian Ciocaltea (2):
  dt-bindings: hwmon: pwm-fan: Convert to DT schema
  arm64: dts: rockchip: rk3588-rock-5b: Add pwm-fan

 .../devicetree/bindings/hwmon/pwm-fan.txt     |  68 +---------
 .../devicetree/bindings/hwmon/pwm-fan.yaml    | 119 ++++++++++++++++++
 .../boot/dts/rockchip/rk3588-rock-5b.dts      |  12 ++
 3 files changed, 132 insertions(+), 67 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/hwmon/pwm-fan.yaml

-- 
2.40.0


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

^ permalink raw reply	[flat|nested] 30+ messages in thread
* [PATCH v2 0/2] Add PWM fan support to Rock 5B board
@ 2023-04-04 17:38 ` Cristian Ciocaltea
  0 siblings, 0 replies; 30+ messages in thread
From: Cristian Ciocaltea @ 2023-04-04 17:38 UTC (permalink / raw)
  To: Jean Delvare, Guenter Roeck, Rob Herring, Krzysztof Kozlowski,
	Heiko Stuebner
  Cc: linux-hwmon, devicetree, linux-kernel, linux-arm-kernel,
	linux-rockchip, kernel

This patch series enables support for the PWM controlled heat sink fan 
on the Rock 5B SBC and, additionally, converts the hwmon PWM fan bindings 
to DT schema format.

Changes in v2:
 - Updated PATCH 1/2 according to Rob's review
 - Added Reviewed-by from Christopher to PATCH 2/2
 - v1: https://lore.kernel.org/lkml/20230403105052.426135-1-cristian.ciocaltea@collabora.com/

Cristian Ciocaltea (2):
  dt-bindings: hwmon: pwm-fan: Convert to DT schema
  arm64: dts: rockchip: rk3588-rock-5b: Add pwm-fan

 .../devicetree/bindings/hwmon/pwm-fan.txt     |  68 +---------
 .../devicetree/bindings/hwmon/pwm-fan.yaml    | 119 ++++++++++++++++++
 .../boot/dts/rockchip/rk3588-rock-5b.dts      |  12 ++
 3 files changed, 132 insertions(+), 67 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/hwmon/pwm-fan.yaml

-- 
2.40.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 30+ messages in thread
* [PATCH v2 1/2] dt-bindings: hwmon: pwm-fan: Convert to DT schema
  2023-04-04 17:38 ` Cristian Ciocaltea
  (?)
@ 2023-04-04 17:38   ` Cristian Ciocaltea
  -1 siblings, 0 replies; 30+ messages in thread
From: Cristian Ciocaltea @ 2023-04-04 17:38 UTC (permalink / raw)
  To: Jean Delvare, Guenter Roeck, Rob Herring, Krzysztof Kozlowski,
	Heiko Stuebner
  Cc: linux-hwmon, devicetree, linux-kernel, linux-arm-kernel,
	linux-rockchip, kernel

Convert the PWM fan bindings to DT schema format.

Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
---
 .../devicetree/bindings/hwmon/pwm-fan.txt     |  68 +---------
 .../devicetree/bindings/hwmon/pwm-fan.yaml    | 119 ++++++++++++++++++
 2 files changed, 120 insertions(+), 67 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/hwmon/pwm-fan.yaml

diff --git a/Documentation/devicetree/bindings/hwmon/pwm-fan.txt b/Documentation/devicetree/bindings/hwmon/pwm-fan.txt
index 4509e688623a..48886f0ce415 100644
--- a/Documentation/devicetree/bindings/hwmon/pwm-fan.txt
+++ b/Documentation/devicetree/bindings/hwmon/pwm-fan.txt
@@ -1,67 +1 @@
-Bindings for a fan connected to the PWM lines
-
-Required properties:
-- compatible	: "pwm-fan"
-- pwms		: the PWM that is used to control the PWM fan
-- cooling-levels      : PWM duty cycle values in a range from 0 to 255
-			which correspond to thermal cooling states
-
-Optional properties:
-- fan-supply		: phandle to the regulator that provides power to the fan
-- interrupts		: This contains an interrupt specifier for each fan
-			  tachometer output connected to an interrupt source.
-			  The output signal must generate a defined number of
-			  interrupts per fan revolution, which require that
-			  it must be self resetting edge interrupts. See
-			  interrupt-controller/interrupts.txt for the format.
-- pulses-per-revolution : define the number of pulses per fan revolution for
-			  each tachometer input as an integer (default is 2
-			  interrupts per revolution). The value must be
-			  greater than zero.
-
-Example:
-	fan0: pwm-fan {
-		compatible = "pwm-fan";
-		#cooling-cells = <2>;
-		pwms = <&pwm 0 10000 0>;
-		cooling-levels = <0 102 170 230>;
-	};
-
-	thermal-zones {
-		cpu_thermal: cpu-thermal {
-			     thermal-sensors = <&tmu 0>;
-			     polling-delay-passive = <0>;
-			     polling-delay = <0>;
-			     trips {
-					cpu_alert1: cpu-alert1 {
-						    temperature = <100000>; /* millicelsius */
-						    hysteresis = <2000>; /* millicelsius */
-						    type = "passive";
-					};
-			     };
-			     cooling-maps {
-					map0 {
-						    trip = <&cpu_alert1>;
-						    cooling-device = <&fan0 0 1>;
-					};
-			     };
-		};
-
-Example 2:
-	fan0: pwm-fan {
-		compatible = "pwm-fan";
-		pwms = <&pwm 0 40000 0>;
-		fan-supply = <&reg_fan>;
-		interrupt-parent = <&gpio5>;
-		interrupts = <1 IRQ_TYPE_EDGE_FALLING>;
-		pulses-per-revolution = <2>;
-	};
-
-Example 3:
-	fan0: pwm-fan {
-		compatible = "pwm-fan";
-		pwms = <&pwm1 0 25000 0>;
-		interrupts-extended = <&gpio1 1 IRQ_TYPE_EDGE_FALLING>,
-			<&gpio2 5 IRQ_TYPE_EDGE_FALLING>;
-		pulses-per-revolution = <2>, <1>;
-	};
+This file has moved to pwm-fan.yaml.
diff --git a/Documentation/devicetree/bindings/hwmon/pwm-fan.yaml b/Documentation/devicetree/bindings/hwmon/pwm-fan.yaml
new file mode 100644
index 000000000000..048b6ea794c7
--- /dev/null
+++ b/Documentation/devicetree/bindings/hwmon/pwm-fan.yaml
@@ -0,0 +1,119 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/hwmon/pwm-fan.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Fan connected to PWM lines
+
+maintainers:
+  - Jean Delvare <jdelvare@suse.com>
+  - Guenter Roeck <linux@roeck-us.net>
+
+properties:
+  compatible:
+    const: pwm-fan
+
+  cooling-levels:
+    description: PWM duty cycle values corresponding to thermal cooling states.
+    items:
+      maximum: 255
+    $ref: /schemas/types.yaml#/definitions/uint32-array
+
+  fan-supply:
+    description: Phandle to the regulator that provides power to the fan.
+
+  interrupts:
+    description:
+      This contains an interrupt specifier for each fan tachometer output
+      connected to an interrupt source. The output signal must generate a
+      defined number of interrupts per fan revolution, which require that
+      it must be self resetting edge interrupts.
+    minItems: 1
+    maxItems: 5
+
+  pulses-per-revolution:
+    description:
+      Define the number of pulses per fan revolution for each tachometer
+      input as an integer.
+    items:
+      minimum: 1
+      maximum: 4
+      default: 2
+    minItems: 1
+    maxItems: 5
+    $ref: /schemas/types.yaml#/definitions/uint32-array
+
+  pwms:
+    description: The PWM that is used to control the fan.
+    maxItems: 1
+
+  pwm-names: true
+
+  "#cooling-cells":
+    description:
+      Must be 2, in order to specify minimum and maximum cooling state used in
+      the cooling-maps reference. The first cell is the minimum cooling state
+      and the second cell is the maximum cooling state requested.
+    const: 2
+
+required:
+  - compatible
+  - pwms
+
+additionalProperties: false
+
+examples:
+  - |
+    pwm-fan {
+      compatible = "pwm-fan";
+      cooling-levels = <0 102 170 230>;
+      pwms = <&pwm 0 10000 0>;
+      #cooling-cells = <2>;
+    };
+
+    thermal-zones {
+      cpu_thermal: cpu-thermal {
+        thermal-sensors = <&tmu 0>;
+        polling-delay-passive = <0>;
+        polling-delay = <0>;
+
+        trips {
+          cpu_alert1: cpu-alert1 {
+            temperature = <100000>; /* millicelsius */
+            hysteresis = <2000>; /* millicelsius */
+            type = "passive";
+          };
+        };
+
+        cooling-maps {
+          map0 {
+            trip = <&cpu_alert1>;
+            cooling-device = <&fan0 0 1>;
+          };
+        };
+      };
+    };
+
+  - |
+    #include <dt-bindings/interrupt-controller/irq.h>
+
+    pwm-fan {
+      compatible = "pwm-fan";
+      pwms = <&pwm 0 40000 0>;
+      fan-supply = <&reg_fan>;
+      interrupt-parent = <&gpio5>;
+      interrupts = <1 IRQ_TYPE_EDGE_FALLING>;
+      pulses-per-revolution = <2>;
+    };
+
+  - |
+    #include <dt-bindings/interrupt-controller/irq.h>
+
+    pwm-fan {
+      compatible = "pwm-fan";
+      pwms = <&pwm1 0 25000 0>;
+      interrupts-extended = <&gpio1 1 IRQ_TYPE_EDGE_FALLING>,
+                            <&gpio2 5 IRQ_TYPE_EDGE_FALLING>;
+      pulses-per-revolution = <2>, <1>;
+    };
-- 
2.40.0


^ permalink raw reply related	[flat|nested] 30+ messages in thread
* [PATCH v2 1/2] dt-bindings: hwmon: pwm-fan: Convert to DT schema
@ 2023-04-04 17:38   ` Cristian Ciocaltea
  0 siblings, 0 replies; 30+ messages in thread
From: Cristian Ciocaltea @ 2023-04-04 17:38 UTC (permalink / raw)
  To: Jean Delvare, Guenter Roeck, Rob Herring, Krzysztof Kozlowski,
	Heiko Stuebner
  Cc: linux-hwmon, devicetree, linux-kernel, linux-arm-kernel,
	linux-rockchip, kernel

Convert the PWM fan bindings to DT schema format.

Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
---
 .../devicetree/bindings/hwmon/pwm-fan.txt     |  68 +---------
 .../devicetree/bindings/hwmon/pwm-fan.yaml    | 119 ++++++++++++++++++
 2 files changed, 120 insertions(+), 67 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/hwmon/pwm-fan.yaml

diff --git a/Documentation/devicetree/bindings/hwmon/pwm-fan.txt b/Documentation/devicetree/bindings/hwmon/pwm-fan.txt
index 4509e688623a..48886f0ce415 100644
--- a/Documentation/devicetree/bindings/hwmon/pwm-fan.txt
+++ b/Documentation/devicetree/bindings/hwmon/pwm-fan.txt
@@ -1,67 +1 @@
-Bindings for a fan connected to the PWM lines
-
-Required properties:
-- compatible	: "pwm-fan"
-- pwms		: the PWM that is used to control the PWM fan
-- cooling-levels      : PWM duty cycle values in a range from 0 to 255
-			which correspond to thermal cooling states
-
-Optional properties:
-- fan-supply		: phandle to the regulator that provides power to the fan
-- interrupts		: This contains an interrupt specifier for each fan
-			  tachometer output connected to an interrupt source.
-			  The output signal must generate a defined number of
-			  interrupts per fan revolution, which require that
-			  it must be self resetting edge interrupts. See
-			  interrupt-controller/interrupts.txt for the format.
-- pulses-per-revolution : define the number of pulses per fan revolution for
-			  each tachometer input as an integer (default is 2
-			  interrupts per revolution). The value must be
-			  greater than zero.
-
-Example:
-	fan0: pwm-fan {
-		compatible = "pwm-fan";
-		#cooling-cells = <2>;
-		pwms = <&pwm 0 10000 0>;
-		cooling-levels = <0 102 170 230>;
-	};
-
-	thermal-zones {
-		cpu_thermal: cpu-thermal {
-			     thermal-sensors = <&tmu 0>;
-			     polling-delay-passive = <0>;
-			     polling-delay = <0>;
-			     trips {
-					cpu_alert1: cpu-alert1 {
-						    temperature = <100000>; /* millicelsius */
-						    hysteresis = <2000>; /* millicelsius */
-						    type = "passive";
-					};
-			     };
-			     cooling-maps {
-					map0 {
-						    trip = <&cpu_alert1>;
-						    cooling-device = <&fan0 0 1>;
-					};
-			     };
-		};
-
-Example 2:
-	fan0: pwm-fan {
-		compatible = "pwm-fan";
-		pwms = <&pwm 0 40000 0>;
-		fan-supply = <&reg_fan>;
-		interrupt-parent = <&gpio5>;
-		interrupts = <1 IRQ_TYPE_EDGE_FALLING>;
-		pulses-per-revolution = <2>;
-	};
-
-Example 3:
-	fan0: pwm-fan {
-		compatible = "pwm-fan";
-		pwms = <&pwm1 0 25000 0>;
-		interrupts-extended = <&gpio1 1 IRQ_TYPE_EDGE_FALLING>,
-			<&gpio2 5 IRQ_TYPE_EDGE_FALLING>;
-		pulses-per-revolution = <2>, <1>;
-	};
+This file has moved to pwm-fan.yaml.
diff --git a/Documentation/devicetree/bindings/hwmon/pwm-fan.yaml b/Documentation/devicetree/bindings/hwmon/pwm-fan.yaml
new file mode 100644
index 000000000000..048b6ea794c7
--- /dev/null
+++ b/Documentation/devicetree/bindings/hwmon/pwm-fan.yaml
@@ -0,0 +1,119 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/hwmon/pwm-fan.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Fan connected to PWM lines
+
+maintainers:
+  - Jean Delvare <jdelvare@suse.com>
+  - Guenter Roeck <linux@roeck-us.net>
+
+properties:
+  compatible:
+    const: pwm-fan
+
+  cooling-levels:
+    description: PWM duty cycle values corresponding to thermal cooling states.
+    items:
+      maximum: 255
+    $ref: /schemas/types.yaml#/definitions/uint32-array
+
+  fan-supply:
+    description: Phandle to the regulator that provides power to the fan.
+
+  interrupts:
+    description:
+      This contains an interrupt specifier for each fan tachometer output
+      connected to an interrupt source. The output signal must generate a
+      defined number of interrupts per fan revolution, which require that
+      it must be self resetting edge interrupts.
+    minItems: 1
+    maxItems: 5
+
+  pulses-per-revolution:
+    description:
+      Define the number of pulses per fan revolution for each tachometer
+      input as an integer.
+    items:
+      minimum: 1
+      maximum: 4
+      default: 2
+    minItems: 1
+    maxItems: 5
+    $ref: /schemas/types.yaml#/definitions/uint32-array
+
+  pwms:
+    description: The PWM that is used to control the fan.
+    maxItems: 1
+
+  pwm-names: true
+
+  "#cooling-cells":
+    description:
+      Must be 2, in order to specify minimum and maximum cooling state used in
+      the cooling-maps reference. The first cell is the minimum cooling state
+      and the second cell is the maximum cooling state requested.
+    const: 2
+
+required:
+  - compatible
+  - pwms
+
+additionalProperties: false
+
+examples:
+  - |
+    pwm-fan {
+      compatible = "pwm-fan";
+      cooling-levels = <0 102 170 230>;
+      pwms = <&pwm 0 10000 0>;
+      #cooling-cells = <2>;
+    };
+
+    thermal-zones {
+      cpu_thermal: cpu-thermal {
+        thermal-sensors = <&tmu 0>;
+        polling-delay-passive = <0>;
+        polling-delay = <0>;
+
+        trips {
+          cpu_alert1: cpu-alert1 {
+            temperature = <100000>; /* millicelsius */
+            hysteresis = <2000>; /* millicelsius */
+            type = "passive";
+          };
+        };
+
+        cooling-maps {
+          map0 {
+            trip = <&cpu_alert1>;
+            cooling-device = <&fan0 0 1>;
+          };
+        };
+      };
+    };
+
+  - |
+    #include <dt-bindings/interrupt-controller/irq.h>
+
+    pwm-fan {
+      compatible = "pwm-fan";
+      pwms = <&pwm 0 40000 0>;
+      fan-supply = <&reg_fan>;
+      interrupt-parent = <&gpio5>;
+      interrupts = <1 IRQ_TYPE_EDGE_FALLING>;
+      pulses-per-revolution = <2>;
+    };
+
+  - |
+    #include <dt-bindings/interrupt-controller/irq.h>
+
+    pwm-fan {
+      compatible = "pwm-fan";
+      pwms = <&pwm1 0 25000 0>;
+      interrupts-extended = <&gpio1 1 IRQ_TYPE_EDGE_FALLING>,
+                            <&gpio2 5 IRQ_TYPE_EDGE_FALLING>;
+      pulses-per-revolution = <2>, <1>;
+    };
-- 
2.40.0


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

^ permalink raw reply related	[flat|nested] 30+ messages in thread
* [PATCH v2 1/2] dt-bindings: hwmon: pwm-fan: Convert to DT schema
@ 2023-04-04 17:38   ` Cristian Ciocaltea
  0 siblings, 0 replies; 30+ messages in thread
From: Cristian Ciocaltea @ 2023-04-04 17:38 UTC (permalink / raw)
  To: Jean Delvare, Guenter Roeck, Rob Herring, Krzysztof Kozlowski,
	Heiko Stuebner
  Cc: linux-hwmon, devicetree, linux-kernel, linux-arm-kernel,
	linux-rockchip, kernel

Convert the PWM fan bindings to DT schema format.

Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
---
 .../devicetree/bindings/hwmon/pwm-fan.txt     |  68 +---------
 .../devicetree/bindings/hwmon/pwm-fan.yaml    | 119 ++++++++++++++++++
 2 files changed, 120 insertions(+), 67 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/hwmon/pwm-fan.yaml

diff --git a/Documentation/devicetree/bindings/hwmon/pwm-fan.txt b/Documentation/devicetree/bindings/hwmon/pwm-fan.txt
index 4509e688623a..48886f0ce415 100644
--- a/Documentation/devicetree/bindings/hwmon/pwm-fan.txt
+++ b/Documentation/devicetree/bindings/hwmon/pwm-fan.txt
@@ -1,67 +1 @@
-Bindings for a fan connected to the PWM lines
-
-Required properties:
-- compatible	: "pwm-fan"
-- pwms		: the PWM that is used to control the PWM fan
-- cooling-levels      : PWM duty cycle values in a range from 0 to 255
-			which correspond to thermal cooling states
-
-Optional properties:
-- fan-supply		: phandle to the regulator that provides power to the fan
-- interrupts		: This contains an interrupt specifier for each fan
-			  tachometer output connected to an interrupt source.
-			  The output signal must generate a defined number of
-			  interrupts per fan revolution, which require that
-			  it must be self resetting edge interrupts. See
-			  interrupt-controller/interrupts.txt for the format.
-- pulses-per-revolution : define the number of pulses per fan revolution for
-			  each tachometer input as an integer (default is 2
-			  interrupts per revolution). The value must be
-			  greater than zero.
-
-Example:
-	fan0: pwm-fan {
-		compatible = "pwm-fan";
-		#cooling-cells = <2>;
-		pwms = <&pwm 0 10000 0>;
-		cooling-levels = <0 102 170 230>;
-	};
-
-	thermal-zones {
-		cpu_thermal: cpu-thermal {
-			     thermal-sensors = <&tmu 0>;
-			     polling-delay-passive = <0>;
-			     polling-delay = <0>;
-			     trips {
-					cpu_alert1: cpu-alert1 {
-						    temperature = <100000>; /* millicelsius */
-						    hysteresis = <2000>; /* millicelsius */
-						    type = "passive";
-					};
-			     };
-			     cooling-maps {
-					map0 {
-						    trip = <&cpu_alert1>;
-						    cooling-device = <&fan0 0 1>;
-					};
-			     };
-		};
-
-Example 2:
-	fan0: pwm-fan {
-		compatible = "pwm-fan";
-		pwms = <&pwm 0 40000 0>;
-		fan-supply = <&reg_fan>;
-		interrupt-parent = <&gpio5>;
-		interrupts = <1 IRQ_TYPE_EDGE_FALLING>;
-		pulses-per-revolution = <2>;
-	};
-
-Example 3:
-	fan0: pwm-fan {
-		compatible = "pwm-fan";
-		pwms = <&pwm1 0 25000 0>;
-		interrupts-extended = <&gpio1 1 IRQ_TYPE_EDGE_FALLING>,
-			<&gpio2 5 IRQ_TYPE_EDGE_FALLING>;
-		pulses-per-revolution = <2>, <1>;
-	};
+This file has moved to pwm-fan.yaml.
diff --git a/Documentation/devicetree/bindings/hwmon/pwm-fan.yaml b/Documentation/devicetree/bindings/hwmon/pwm-fan.yaml
new file mode 100644
index 000000000000..048b6ea794c7
--- /dev/null
+++ b/Documentation/devicetree/bindings/hwmon/pwm-fan.yaml
@@ -0,0 +1,119 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/hwmon/pwm-fan.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Fan connected to PWM lines
+
+maintainers:
+  - Jean Delvare <jdelvare@suse.com>
+  - Guenter Roeck <linux@roeck-us.net>
+
+properties:
+  compatible:
+    const: pwm-fan
+
+  cooling-levels:
+    description: PWM duty cycle values corresponding to thermal cooling states.
+    items:
+      maximum: 255
+    $ref: /schemas/types.yaml#/definitions/uint32-array
+
+  fan-supply:
+    description: Phandle to the regulator that provides power to the fan.
+
+  interrupts:
+    description:
+      This contains an interrupt specifier for each fan tachometer output
+      connected to an interrupt source. The output signal must generate a
+      defined number of interrupts per fan revolution, which require that
+      it must be self resetting edge interrupts.
+    minItems: 1
+    maxItems: 5
+
+  pulses-per-revolution:
+    description:
+      Define the number of pulses per fan revolution for each tachometer
+      input as an integer.
+    items:
+      minimum: 1
+      maximum: 4
+      default: 2
+    minItems: 1
+    maxItems: 5
+    $ref: /schemas/types.yaml#/definitions/uint32-array
+
+  pwms:
+    description: The PWM that is used to control the fan.
+    maxItems: 1
+
+  pwm-names: true
+
+  "#cooling-cells":
+    description:
+      Must be 2, in order to specify minimum and maximum cooling state used in
+      the cooling-maps reference. The first cell is the minimum cooling state
+      and the second cell is the maximum cooling state requested.
+    const: 2
+
+required:
+  - compatible
+  - pwms
+
+additionalProperties: false
+
+examples:
+  - |
+    pwm-fan {
+      compatible = "pwm-fan";
+      cooling-levels = <0 102 170 230>;
+      pwms = <&pwm 0 10000 0>;
+      #cooling-cells = <2>;
+    };
+
+    thermal-zones {
+      cpu_thermal: cpu-thermal {
+        thermal-sensors = <&tmu 0>;
+        polling-delay-passive = <0>;
+        polling-delay = <0>;
+
+        trips {
+          cpu_alert1: cpu-alert1 {
+            temperature = <100000>; /* millicelsius */
+            hysteresis = <2000>; /* millicelsius */
+            type = "passive";
+          };
+        };
+
+        cooling-maps {
+          map0 {
+            trip = <&cpu_alert1>;
+            cooling-device = <&fan0 0 1>;
+          };
+        };
+      };
+    };
+
+  - |
+    #include <dt-bindings/interrupt-controller/irq.h>
+
+    pwm-fan {
+      compatible = "pwm-fan";
+      pwms = <&pwm 0 40000 0>;
+      fan-supply = <&reg_fan>;
+      interrupt-parent = <&gpio5>;
+      interrupts = <1 IRQ_TYPE_EDGE_FALLING>;
+      pulses-per-revolution = <2>;
+    };
+
+  - |
+    #include <dt-bindings/interrupt-controller/irq.h>
+
+    pwm-fan {
+      compatible = "pwm-fan";
+      pwms = <&pwm1 0 25000 0>;
+      interrupts-extended = <&gpio1 1 IRQ_TYPE_EDGE_FALLING>,
+                            <&gpio2 5 IRQ_TYPE_EDGE_FALLING>;
+      pulses-per-revolution = <2>, <1>;
+    };
-- 
2.40.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 30+ messages in thread
* [PATCH v2 2/2] arm64: dts: rockchip: rk3588-rock-5b: Add pwm-fan
  2023-04-04 17:38 ` Cristian Ciocaltea
  (?)
@ 2023-04-04 17:38   ` Cristian Ciocaltea
  -1 siblings, 0 replies; 30+ messages in thread
From: Cristian Ciocaltea @ 2023-04-04 17:38 UTC (permalink / raw)
  To: Jean Delvare, Guenter Roeck, Rob Herring, Krzysztof Kozlowski,
	Heiko Stuebner
  Cc: linux-hwmon, devicetree, linux-kernel, linux-arm-kernel,
	linux-rockchip, kernel, Christopher Obbard

Add the necessary DT changes for the Rock 5B board to enable support for
the PWM controlled heat sink fan.

Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
Reviewed-by: Christopher Obbard <chris.obbard@collabora.com>
---
 arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
index 95805cb0adfa..bd74d9da2c17 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
@@ -17,6 +17,14 @@ chosen {
 		stdout-path = "serial2:1500000n8";
 	};
 
+	fan: pwm-fan {
+		compatible = "pwm-fan";
+		cooling-levels = <0 95 145 195 255>;
+		fan-supply = <&vcc5v0_sys>;
+		pwms = <&pwm1 0 50000 0>;
+		#cooling-cells = <2>;
+	};
+
 	vcc5v0_sys: vcc5v0-sys-regulator {
 		compatible = "regulator-fixed";
 		regulator-name = "vcc5v0_sys";
@@ -27,6 +35,10 @@ vcc5v0_sys: vcc5v0-sys-regulator {
 	};
 };
 
+&pwm1 {
+	status = "okay";
+};
+
 &sdhci {
 	bus-width = <8>;
 	no-sdio;
-- 
2.40.0


^ permalink raw reply related	[flat|nested] 30+ messages in thread
* [PATCH v2 2/2] arm64: dts: rockchip: rk3588-rock-5b: Add pwm-fan
@ 2023-04-04 17:38   ` Cristian Ciocaltea
  0 siblings, 0 replies; 30+ messages in thread
From: Cristian Ciocaltea @ 2023-04-04 17:38 UTC (permalink / raw)
  To: Jean Delvare, Guenter Roeck, Rob Herring, Krzysztof Kozlowski,
	Heiko Stuebner
  Cc: linux-hwmon, devicetree, linux-kernel, linux-arm-kernel,
	linux-rockchip, kernel, Christopher Obbard

Add the necessary DT changes for the Rock 5B board to enable support for
the PWM controlled heat sink fan.

Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
Reviewed-by: Christopher Obbard <chris.obbard@collabora.com>
---
 arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
index 95805cb0adfa..bd74d9da2c17 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
@@ -17,6 +17,14 @@ chosen {
 		stdout-path = "serial2:1500000n8";
 	};
 
+	fan: pwm-fan {
+		compatible = "pwm-fan";
+		cooling-levels = <0 95 145 195 255>;
+		fan-supply = <&vcc5v0_sys>;
+		pwms = <&pwm1 0 50000 0>;
+		#cooling-cells = <2>;
+	};
+
 	vcc5v0_sys: vcc5v0-sys-regulator {
 		compatible = "regulator-fixed";
 		regulator-name = "vcc5v0_sys";
@@ -27,6 +35,10 @@ vcc5v0_sys: vcc5v0-sys-regulator {
 	};
 };
 
+&pwm1 {
+	status = "okay";
+};
+
 &sdhci {
 	bus-width = <8>;
 	no-sdio;
-- 
2.40.0


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

^ permalink raw reply related	[flat|nested] 30+ messages in thread
* [PATCH v2 2/2] arm64: dts: rockchip: rk3588-rock-5b: Add pwm-fan
@ 2023-04-04 17:38   ` Cristian Ciocaltea
  0 siblings, 0 replies; 30+ messages in thread
From: Cristian Ciocaltea @ 2023-04-04 17:38 UTC (permalink / raw)
  To: Jean Delvare, Guenter Roeck, Rob Herring, Krzysztof Kozlowski,
	Heiko Stuebner
  Cc: linux-hwmon, devicetree, linux-kernel, linux-arm-kernel,
	linux-rockchip, kernel, Christopher Obbard

Add the necessary DT changes for the Rock 5B board to enable support for
the PWM controlled heat sink fan.

Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
Reviewed-by: Christopher Obbard <chris.obbard@collabora.com>
---
 arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
index 95805cb0adfa..bd74d9da2c17 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
@@ -17,6 +17,14 @@ chosen {
 		stdout-path = "serial2:1500000n8";
 	};
 
+	fan: pwm-fan {
+		compatible = "pwm-fan";
+		cooling-levels = <0 95 145 195 255>;
+		fan-supply = <&vcc5v0_sys>;
+		pwms = <&pwm1 0 50000 0>;
+		#cooling-cells = <2>;
+	};
+
 	vcc5v0_sys: vcc5v0-sys-regulator {
 		compatible = "regulator-fixed";
 		regulator-name = "vcc5v0_sys";
@@ -27,6 +35,10 @@ vcc5v0_sys: vcc5v0-sys-regulator {
 	};
 };
 
+&pwm1 {
+	status = "okay";
+};
+
 &sdhci {
 	bus-width = <8>;
 	no-sdio;
-- 
2.40.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 30+ messages in thread
* Re: (subset) [PATCH v2 0/2] Add PWM fan support to Rock 5B board
  2023-04-04 17:38 ` Cristian Ciocaltea
  (?)
@ 2023-04-05 17:45   ` Heiko Stuebner
  -1 siblings, 0 replies; 30+ messages in thread
From: Heiko Stuebner @ 2023-04-05 17:45 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Cristian Ciocaltea,
	Jean Delvare, Guenter Roeck
  Cc: Heiko Stuebner, linux-hwmon, devicetree, kernel, linux-kernel,
	linux-arm-kernel, linux-rockchip

On Tue, 4 Apr 2023 20:38:05 +0300, Cristian Ciocaltea wrote:
> This patch series enables support for the PWM controlled heat sink fan
> on the Rock 5B SBC and, additionally, converts the hwmon PWM fan bindings
> to DT schema format.
> 
> Changes in v2:
>  - Updated PATCH 1/2 according to Rob's review
>  - Added Reviewed-by from Christopher to PATCH 2/2
>  - v1: https://lore.kernel.org/lkml/20230403105052.426135-1-cristian.ciocaltea@collabora.com/
> 
> [...]

Applied, thanks!

[2/2] arm64: dts: rockchip: rk3588-rock-5b: Add pwm-fan
      commit: f36bb17653e4b9e26bbdb1224027d20614e77636

Best regards,
-- 
Heiko Stuebner <heiko@sntech.de>

^ permalink raw reply	[flat|nested] 30+ messages in thread
* Re: (subset) [PATCH v2 0/2] Add PWM fan support to Rock 5B board
@ 2023-04-05 17:45   ` Heiko Stuebner
  0 siblings, 0 replies; 30+ messages in thread
From: Heiko Stuebner @ 2023-04-05 17:45 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Cristian Ciocaltea,
	Jean Delvare, Guenter Roeck
  Cc: Heiko Stuebner, linux-hwmon, devicetree, kernel, linux-kernel,
	linux-arm-kernel, linux-rockchip

On Tue, 4 Apr 2023 20:38:05 +0300, Cristian Ciocaltea wrote:
> This patch series enables support for the PWM controlled heat sink fan
> on the Rock 5B SBC and, additionally, converts the hwmon PWM fan bindings
> to DT schema format.
> 
> Changes in v2:
>  - Updated PATCH 1/2 according to Rob's review
>  - Added Reviewed-by from Christopher to PATCH 2/2
>  - v1: https://lore.kernel.org/lkml/20230403105052.426135-1-cristian.ciocaltea@collabora.com/
> 
> [...]

Applied, thanks!

[2/2] arm64: dts: rockchip: rk3588-rock-5b: Add pwm-fan
      commit: f36bb17653e4b9e26bbdb1224027d20614e77636

Best regards,
-- 
Heiko Stuebner <heiko@sntech.de>

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

^ permalink raw reply	[flat|nested] 30+ messages in thread
* Re: (subset) [PATCH v2 0/2] Add PWM fan support to Rock 5B board
@ 2023-04-05 17:45   ` Heiko Stuebner
  0 siblings, 0 replies; 30+ messages in thread
From: Heiko Stuebner @ 2023-04-05 17:45 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Cristian Ciocaltea,
	Jean Delvare, Guenter Roeck
  Cc: Heiko Stuebner, linux-hwmon, devicetree, kernel, linux-kernel,
	linux-arm-kernel, linux-rockchip

On Tue, 4 Apr 2023 20:38:05 +0300, Cristian Ciocaltea wrote:
> This patch series enables support for the PWM controlled heat sink fan
> on the Rock 5B SBC and, additionally, converts the hwmon PWM fan bindings
> to DT schema format.
> 
> Changes in v2:
>  - Updated PATCH 1/2 according to Rob's review
>  - Added Reviewed-by from Christopher to PATCH 2/2
>  - v1: https://lore.kernel.org/lkml/20230403105052.426135-1-cristian.ciocaltea@collabora.com/
> 
> [...]

Applied, thanks!

[2/2] arm64: dts: rockchip: rk3588-rock-5b: Add pwm-fan
      commit: f36bb17653e4b9e26bbdb1224027d20614e77636

Best regards,
-- 
Heiko Stuebner <heiko@sntech.de>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 30+ messages in thread
* Re: (subset) [PATCH v2 0/2] Add PWM fan support to Rock 5B board
  2023-04-05 17:45   ` Heiko Stuebner
  (?)
@ 2023-04-05 19:04     ` Guenter Roeck
  -1 siblings, 0 replies; 30+ messages in thread
From: Guenter Roeck @ 2023-04-05 19:04 UTC (permalink / raw)
  To: Heiko Stuebner, Rob Herring, Krzysztof Kozlowski,
	Cristian Ciocaltea, Jean Delvare
  Cc: linux-hwmon, devicetree, kernel, linux-kernel, linux-arm-kernel,
	linux-rockchip

On 4/5/23 10:45, Heiko Stuebner wrote:
> On Tue, 4 Apr 2023 20:38:05 +0300, Cristian Ciocaltea wrote:
>> This patch series enables support for the PWM controlled heat sink fan
>> on the Rock 5B SBC and, additionally, converts the hwmon PWM fan bindings
>> to DT schema format.
>>
>> Changes in v2:
>>   - Updated PATCH 1/2 according to Rob's review
>>   - Added Reviewed-by from Christopher to PATCH 2/2
>>   - v1: https://lore.kernel.org/lkml/20230403105052.426135-1-cristian.ciocaltea@collabora.com/
>>
>> [...]
> 
> Applied, thanks!
> 

Both patches or only the second one ?

Thanks,
Guenter


^ permalink raw reply	[flat|nested] 30+ messages in thread
* Re: (subset) [PATCH v2 0/2] Add PWM fan support to Rock 5B board
@ 2023-04-05 19:04     ` Guenter Roeck
  0 siblings, 0 replies; 30+ messages in thread
From: Guenter Roeck @ 2023-04-05 19:04 UTC (permalink / raw)
  To: Heiko Stuebner, Rob Herring, Krzysztof Kozlowski,
	Cristian Ciocaltea, Jean Delvare
  Cc: linux-hwmon, devicetree, kernel, linux-kernel, linux-arm-kernel,
	linux-rockchip

On 4/5/23 10:45, Heiko Stuebner wrote:
> On Tue, 4 Apr 2023 20:38:05 +0300, Cristian Ciocaltea wrote:
>> This patch series enables support for the PWM controlled heat sink fan
>> on the Rock 5B SBC and, additionally, converts the hwmon PWM fan bindings
>> to DT schema format.
>>
>> Changes in v2:
>>   - Updated PATCH 1/2 according to Rob's review
>>   - Added Reviewed-by from Christopher to PATCH 2/2
>>   - v1: https://lore.kernel.org/lkml/20230403105052.426135-1-cristian.ciocaltea@collabora.com/
>>
>> [...]
> 
> Applied, thanks!
> 

Both patches or only the second one ?

Thanks,
Guenter


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

^ permalink raw reply	[flat|nested] 30+ messages in thread
* Re: (subset) [PATCH v2 0/2] Add PWM fan support to Rock 5B board
@ 2023-04-05 19:04     ` Guenter Roeck
  0 siblings, 0 replies; 30+ messages in thread
From: Guenter Roeck @ 2023-04-05 19:04 UTC (permalink / raw)
  To: Heiko Stuebner, Rob Herring, Krzysztof Kozlowski,
	Cristian Ciocaltea, Jean Delvare
  Cc: linux-hwmon, devicetree, kernel, linux-kernel, linux-arm-kernel,
	linux-rockchip

On 4/5/23 10:45, Heiko Stuebner wrote:
> On Tue, 4 Apr 2023 20:38:05 +0300, Cristian Ciocaltea wrote:
>> This patch series enables support for the PWM controlled heat sink fan
>> on the Rock 5B SBC and, additionally, converts the hwmon PWM fan bindings
>> to DT schema format.
>>
>> Changes in v2:
>>   - Updated PATCH 1/2 according to Rob's review
>>   - Added Reviewed-by from Christopher to PATCH 2/2
>>   - v1: https://lore.kernel.org/lkml/20230403105052.426135-1-cristian.ciocaltea@collabora.com/
>>
>> [...]
> 
> Applied, thanks!
> 

Both patches or only the second one ?

Thanks,
Guenter


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 30+ messages in thread
* Re: (subset) [PATCH v2 0/2] Add PWM fan support to Rock 5B board
  2023-04-05 19:04     ` Guenter Roeck
  (?)
@ 2023-04-05 21:35       ` Heiko Stübner
  -1 siblings, 0 replies; 30+ messages in thread
From: Heiko Stübner @ 2023-04-05 21:35 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Cristian Ciocaltea,
	Jean Delvare, Guenter Roeck
  Cc: linux-hwmon, devicetree, kernel, linux-kernel, linux-arm-kernel,
	linux-rockchip

Am Mittwoch, 5. April 2023, 21:04:04 CEST schrieb Guenter Roeck:
> On 4/5/23 10:45, Heiko Stuebner wrote:
> > On Tue, 4 Apr 2023 20:38:05 +0300, Cristian Ciocaltea wrote:
> >> This patch series enables support for the PWM controlled heat sink fan
> >> on the Rock 5B SBC and, additionally, converts the hwmon PWM fan bindings
> >> to DT schema format.
> >>
> >> Changes in v2:
> >>   - Updated PATCH 1/2 according to Rob's review
> >>   - Added Reviewed-by from Christopher to PATCH 2/2
> >>   - v1: https://lore.kernel.org/lkml/20230403105052.426135-1-cristian.ciocaltea@collabora.com/
> >>
> >> [...]
> > 
> > Applied, thanks!
> > 
> 
> Both patches or only the second one ?

only the second one of course. According to earlier talks the dts patch
does already follow the text binding, so the yaml conversion is actually
not a requirement for it.

So I picked the dts patch let the binding sort itself when people have
time for it :-) .


Looking at the mail b4 created, I guessed this would also be visible
with the subject saying (subset) and the listed commits only showing

[2/2] arm64: dts: rockchip: rk3588-rock-5b: Add pwm-fan
      commit: f36bb17653e4b9e26bbdb1224027d20614e77636


Heiko



^ permalink raw reply	[flat|nested] 30+ messages in thread
* Re: (subset) [PATCH v2 0/2] Add PWM fan support to Rock 5B board
@ 2023-04-05 21:35       ` Heiko Stübner
  0 siblings, 0 replies; 30+ messages in thread
From: Heiko Stübner @ 2023-04-05 21:35 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Cristian Ciocaltea,
	Jean Delvare, Guenter Roeck
  Cc: linux-hwmon, devicetree, kernel, linux-kernel, linux-arm-kernel,
	linux-rockchip

Am Mittwoch, 5. April 2023, 21:04:04 CEST schrieb Guenter Roeck:
> On 4/5/23 10:45, Heiko Stuebner wrote:
> > On Tue, 4 Apr 2023 20:38:05 +0300, Cristian Ciocaltea wrote:
> >> This patch series enables support for the PWM controlled heat sink fan
> >> on the Rock 5B SBC and, additionally, converts the hwmon PWM fan bindings
> >> to DT schema format.
> >>
> >> Changes in v2:
> >>   - Updated PATCH 1/2 according to Rob's review
> >>   - Added Reviewed-by from Christopher to PATCH 2/2
> >>   - v1: https://lore.kernel.org/lkml/20230403105052.426135-1-cristian.ciocaltea@collabora.com/
> >>
> >> [...]
> > 
> > Applied, thanks!
> > 
> 
> Both patches or only the second one ?

only the second one of course. According to earlier talks the dts patch
does already follow the text binding, so the yaml conversion is actually
not a requirement for it.

So I picked the dts patch let the binding sort itself when people have
time for it :-) .


Looking at the mail b4 created, I guessed this would also be visible
with the subject saying (subset) and the listed commits only showing

[2/2] arm64: dts: rockchip: rk3588-rock-5b: Add pwm-fan
      commit: f36bb17653e4b9e26bbdb1224027d20614e77636


Heiko



_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

^ permalink raw reply	[flat|nested] 30+ messages in thread
* Re: (subset) [PATCH v2 0/2] Add PWM fan support to Rock 5B board
@ 2023-04-05 21:35       ` Heiko Stübner
  0 siblings, 0 replies; 30+ messages in thread
From: Heiko Stübner @ 2023-04-05 21:35 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Cristian Ciocaltea,
	Jean Delvare, Guenter Roeck
  Cc: linux-hwmon, devicetree, kernel, linux-kernel, linux-arm-kernel,
	linux-rockchip

Am Mittwoch, 5. April 2023, 21:04:04 CEST schrieb Guenter Roeck:
> On 4/5/23 10:45, Heiko Stuebner wrote:
> > On Tue, 4 Apr 2023 20:38:05 +0300, Cristian Ciocaltea wrote:
> >> This patch series enables support for the PWM controlled heat sink fan
> >> on the Rock 5B SBC and, additionally, converts the hwmon PWM fan bindings
> >> to DT schema format.
> >>
> >> Changes in v2:
> >>   - Updated PATCH 1/2 according to Rob's review
> >>   - Added Reviewed-by from Christopher to PATCH 2/2
> >>   - v1: https://lore.kernel.org/lkml/20230403105052.426135-1-cristian.ciocaltea@collabora.com/
> >>
> >> [...]
> > 
> > Applied, thanks!
> > 
> 
> Both patches or only the second one ?

only the second one of course. According to earlier talks the dts patch
does already follow the text binding, so the yaml conversion is actually
not a requirement for it.

So I picked the dts patch let the binding sort itself when people have
time for it :-) .


Looking at the mail b4 created, I guessed this would also be visible
with the subject saying (subset) and the listed commits only showing

[2/2] arm64: dts: rockchip: rk3588-rock-5b: Add pwm-fan
      commit: f36bb17653e4b9e26bbdb1224027d20614e77636


Heiko



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 30+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: hwmon: pwm-fan: Convert to DT schema
  2023-04-04 17:38   ` Cristian Ciocaltea
  (?)
@ 2023-04-06 16:45     ` Rob Herring
  -1 siblings, 0 replies; 30+ messages in thread
From: Rob Herring @ 2023-04-06 16:45 UTC (permalink / raw)
  To: Cristian Ciocaltea
  Cc: Jean Delvare, Guenter Roeck, Krzysztof Kozlowski, Heiko Stuebner,
	linux-hwmon, devicetree, linux-kernel, linux-arm-kernel,
	linux-rockchip, kernel

On Tue, Apr 04, 2023 at 08:38:06PM +0300, Cristian Ciocaltea wrote:
> Convert the PWM fan bindings to DT schema format.
> 
> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
> ---
>  .../devicetree/bindings/hwmon/pwm-fan.txt     |  68 +---------
>  .../devicetree/bindings/hwmon/pwm-fan.yaml    | 119 ++++++++++++++++++
>  2 files changed, 120 insertions(+), 67 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/hwmon/pwm-fan.yaml
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/pwm-fan.txt b/Documentation/devicetree/bindings/hwmon/pwm-fan.txt
> index 4509e688623a..48886f0ce415 100644
> --- a/Documentation/devicetree/bindings/hwmon/pwm-fan.txt
> +++ b/Documentation/devicetree/bindings/hwmon/pwm-fan.txt
> @@ -1,67 +1 @@
> -Bindings for a fan connected to the PWM lines
> -
> -Required properties:
> -- compatible	: "pwm-fan"
> -- pwms		: the PWM that is used to control the PWM fan
> -- cooling-levels      : PWM duty cycle values in a range from 0 to 255
> -			which correspond to thermal cooling states
> -
> -Optional properties:
> -- fan-supply		: phandle to the regulator that provides power to the fan
> -- interrupts		: This contains an interrupt specifier for each fan
> -			  tachometer output connected to an interrupt source.
> -			  The output signal must generate a defined number of
> -			  interrupts per fan revolution, which require that
> -			  it must be self resetting edge interrupts. See
> -			  interrupt-controller/interrupts.txt for the format.
> -- pulses-per-revolution : define the number of pulses per fan revolution for
> -			  each tachometer input as an integer (default is 2
> -			  interrupts per revolution). The value must be
> -			  greater than zero.
> -
> -Example:
> -	fan0: pwm-fan {
> -		compatible = "pwm-fan";
> -		#cooling-cells = <2>;
> -		pwms = <&pwm 0 10000 0>;
> -		cooling-levels = <0 102 170 230>;
> -	};
> -
> -	thermal-zones {
> -		cpu_thermal: cpu-thermal {
> -			     thermal-sensors = <&tmu 0>;
> -			     polling-delay-passive = <0>;
> -			     polling-delay = <0>;
> -			     trips {
> -					cpu_alert1: cpu-alert1 {
> -						    temperature = <100000>; /* millicelsius */
> -						    hysteresis = <2000>; /* millicelsius */
> -						    type = "passive";
> -					};
> -			     };
> -			     cooling-maps {
> -					map0 {
> -						    trip = <&cpu_alert1>;
> -						    cooling-device = <&fan0 0 1>;
> -					};
> -			     };
> -		};
> -
> -Example 2:
> -	fan0: pwm-fan {
> -		compatible = "pwm-fan";
> -		pwms = <&pwm 0 40000 0>;
> -		fan-supply = <&reg_fan>;
> -		interrupt-parent = <&gpio5>;
> -		interrupts = <1 IRQ_TYPE_EDGE_FALLING>;
> -		pulses-per-revolution = <2>;
> -	};
> -
> -Example 3:
> -	fan0: pwm-fan {
> -		compatible = "pwm-fan";
> -		pwms = <&pwm1 0 25000 0>;
> -		interrupts-extended = <&gpio1 1 IRQ_TYPE_EDGE_FALLING>,
> -			<&gpio2 5 IRQ_TYPE_EDGE_FALLING>;
> -		pulses-per-revolution = <2>, <1>;
> -	};
> +This file has moved to pwm-fan.yaml.
> diff --git a/Documentation/devicetree/bindings/hwmon/pwm-fan.yaml b/Documentation/devicetree/bindings/hwmon/pwm-fan.yaml
> new file mode 100644
> index 000000000000..048b6ea794c7
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/pwm-fan.yaml
> @@ -0,0 +1,119 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/hwmon/pwm-fan.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Fan connected to PWM lines
> +
> +maintainers:
> +  - Jean Delvare <jdelvare@suse.com>
> +  - Guenter Roeck <linux@roeck-us.net>
> +
> +properties:
> +  compatible:
> +    const: pwm-fan
> +
> +  cooling-levels:
> +    description: PWM duty cycle values corresponding to thermal cooling states.
> +    items:
> +      maximum: 255
> +    $ref: /schemas/types.yaml#/definitions/uint32-array
> +
> +  fan-supply:
> +    description: Phandle to the regulator that provides power to the fan.
> +
> +  interrupts:
> +    description:
> +      This contains an interrupt specifier for each fan tachometer output
> +      connected to an interrupt source. The output signal must generate a
> +      defined number of interrupts per fan revolution, which require that
> +      it must be self resetting edge interrupts.
> +    minItems: 1
> +    maxItems: 5

I'm not so sure I'd allow for more than 1 if the example is the only 
case we can find. More than 1 implies you have multiple fans controlled 
by 1 PWM. What do you do with the tach data other than display it or 
detect a stuck fan. You can't really implement any control loop unless 
you average the rpm's? I suppose there could be h/w, so okay.

> +
> +  pulses-per-revolution:
> +    description:
> +      Define the number of pulses per fan revolution for each tachometer
> +      input as an integer.
> +    items:
> +      minimum: 1
> +      maximum: 4
> +      default: 2
> +    minItems: 1
> +    maxItems: 5
> +    $ref: /schemas/types.yaml#/definitions/uint32-array
> +
> +  pwms:
> +    description: The PWM that is used to control the fan.
> +    maxItems: 1
> +
> +  pwm-names: true

Not part of the original binding. It's not that useful in general if 
there's only 1 entry. It's completely useless if the name is not defined 
for the OS to use. So drop it.

> +
> +  "#cooling-cells":
> +    description:
> +      Must be 2, in order to specify minimum and maximum cooling state used in
> +      the cooling-maps reference. The first cell is the minimum cooling state
> +      and the second cell is the maximum cooling state requested.

Just duplicating the same text from thermal-cooling-devices.yaml is 
pointless.

> +    const: 2

As this is globally the only allowed value, you don't need to duplicate 
this either.

'"#cooling-cells": true"' is sufficient.

Rob


^ permalink raw reply	[flat|nested] 30+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: hwmon: pwm-fan: Convert to DT schema
@ 2023-04-06 16:45     ` Rob Herring
  0 siblings, 0 replies; 30+ messages in thread
From: Rob Herring @ 2023-04-06 16:45 UTC (permalink / raw)
  To: Cristian Ciocaltea
  Cc: Jean Delvare, Guenter Roeck, Krzysztof Kozlowski, Heiko Stuebner,
	linux-hwmon, devicetree, linux-kernel, linux-arm-kernel,
	linux-rockchip, kernel

On Tue, Apr 04, 2023 at 08:38:06PM +0300, Cristian Ciocaltea wrote:
> Convert the PWM fan bindings to DT schema format.
> 
> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
> ---
>  .../devicetree/bindings/hwmon/pwm-fan.txt     |  68 +---------
>  .../devicetree/bindings/hwmon/pwm-fan.yaml    | 119 ++++++++++++++++++
>  2 files changed, 120 insertions(+), 67 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/hwmon/pwm-fan.yaml
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/pwm-fan.txt b/Documentation/devicetree/bindings/hwmon/pwm-fan.txt
> index 4509e688623a..48886f0ce415 100644
> --- a/Documentation/devicetree/bindings/hwmon/pwm-fan.txt
> +++ b/Documentation/devicetree/bindings/hwmon/pwm-fan.txt
> @@ -1,67 +1 @@
> -Bindings for a fan connected to the PWM lines
> -
> -Required properties:
> -- compatible	: "pwm-fan"
> -- pwms		: the PWM that is used to control the PWM fan
> -- cooling-levels      : PWM duty cycle values in a range from 0 to 255
> -			which correspond to thermal cooling states
> -
> -Optional properties:
> -- fan-supply		: phandle to the regulator that provides power to the fan
> -- interrupts		: This contains an interrupt specifier for each fan
> -			  tachometer output connected to an interrupt source.
> -			  The output signal must generate a defined number of
> -			  interrupts per fan revolution, which require that
> -			  it must be self resetting edge interrupts. See
> -			  interrupt-controller/interrupts.txt for the format.
> -- pulses-per-revolution : define the number of pulses per fan revolution for
> -			  each tachometer input as an integer (default is 2
> -			  interrupts per revolution). The value must be
> -			  greater than zero.
> -
> -Example:
> -	fan0: pwm-fan {
> -		compatible = "pwm-fan";
> -		#cooling-cells = <2>;
> -		pwms = <&pwm 0 10000 0>;
> -		cooling-levels = <0 102 170 230>;
> -	};
> -
> -	thermal-zones {
> -		cpu_thermal: cpu-thermal {
> -			     thermal-sensors = <&tmu 0>;
> -			     polling-delay-passive = <0>;
> -			     polling-delay = <0>;
> -			     trips {
> -					cpu_alert1: cpu-alert1 {
> -						    temperature = <100000>; /* millicelsius */
> -						    hysteresis = <2000>; /* millicelsius */
> -						    type = "passive";
> -					};
> -			     };
> -			     cooling-maps {
> -					map0 {
> -						    trip = <&cpu_alert1>;
> -						    cooling-device = <&fan0 0 1>;
> -					};
> -			     };
> -		};
> -
> -Example 2:
> -	fan0: pwm-fan {
> -		compatible = "pwm-fan";
> -		pwms = <&pwm 0 40000 0>;
> -		fan-supply = <&reg_fan>;
> -		interrupt-parent = <&gpio5>;
> -		interrupts = <1 IRQ_TYPE_EDGE_FALLING>;
> -		pulses-per-revolution = <2>;
> -	};
> -
> -Example 3:
> -	fan0: pwm-fan {
> -		compatible = "pwm-fan";
> -		pwms = <&pwm1 0 25000 0>;
> -		interrupts-extended = <&gpio1 1 IRQ_TYPE_EDGE_FALLING>,
> -			<&gpio2 5 IRQ_TYPE_EDGE_FALLING>;
> -		pulses-per-revolution = <2>, <1>;
> -	};
> +This file has moved to pwm-fan.yaml.
> diff --git a/Documentation/devicetree/bindings/hwmon/pwm-fan.yaml b/Documentation/devicetree/bindings/hwmon/pwm-fan.yaml
> new file mode 100644
> index 000000000000..048b6ea794c7
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/pwm-fan.yaml
> @@ -0,0 +1,119 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/hwmon/pwm-fan.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Fan connected to PWM lines
> +
> +maintainers:
> +  - Jean Delvare <jdelvare@suse.com>
> +  - Guenter Roeck <linux@roeck-us.net>
> +
> +properties:
> +  compatible:
> +    const: pwm-fan
> +
> +  cooling-levels:
> +    description: PWM duty cycle values corresponding to thermal cooling states.
> +    items:
> +      maximum: 255
> +    $ref: /schemas/types.yaml#/definitions/uint32-array
> +
> +  fan-supply:
> +    description: Phandle to the regulator that provides power to the fan.
> +
> +  interrupts:
> +    description:
> +      This contains an interrupt specifier for each fan tachometer output
> +      connected to an interrupt source. The output signal must generate a
> +      defined number of interrupts per fan revolution, which require that
> +      it must be self resetting edge interrupts.
> +    minItems: 1
> +    maxItems: 5

I'm not so sure I'd allow for more than 1 if the example is the only 
case we can find. More than 1 implies you have multiple fans controlled 
by 1 PWM. What do you do with the tach data other than display it or 
detect a stuck fan. You can't really implement any control loop unless 
you average the rpm's? I suppose there could be h/w, so okay.

> +
> +  pulses-per-revolution:
> +    description:
> +      Define the number of pulses per fan revolution for each tachometer
> +      input as an integer.
> +    items:
> +      minimum: 1
> +      maximum: 4
> +      default: 2
> +    minItems: 1
> +    maxItems: 5
> +    $ref: /schemas/types.yaml#/definitions/uint32-array
> +
> +  pwms:
> +    description: The PWM that is used to control the fan.
> +    maxItems: 1
> +
> +  pwm-names: true

Not part of the original binding. It's not that useful in general if 
there's only 1 entry. It's completely useless if the name is not defined 
for the OS to use. So drop it.

> +
> +  "#cooling-cells":
> +    description:
> +      Must be 2, in order to specify minimum and maximum cooling state used in
> +      the cooling-maps reference. The first cell is the minimum cooling state
> +      and the second cell is the maximum cooling state requested.

Just duplicating the same text from thermal-cooling-devices.yaml is 
pointless.

> +    const: 2

As this is globally the only allowed value, you don't need to duplicate 
this either.

'"#cooling-cells": true"' is sufficient.

Rob


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

^ permalink raw reply	[flat|nested] 30+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: hwmon: pwm-fan: Convert to DT schema
@ 2023-04-06 16:45     ` Rob Herring
  0 siblings, 0 replies; 30+ messages in thread
From: Rob Herring @ 2023-04-06 16:45 UTC (permalink / raw)
  To: Cristian Ciocaltea
  Cc: Jean Delvare, Guenter Roeck, Krzysztof Kozlowski, Heiko Stuebner,
	linux-hwmon, devicetree, linux-kernel, linux-arm-kernel,
	linux-rockchip, kernel

On Tue, Apr 04, 2023 at 08:38:06PM +0300, Cristian Ciocaltea wrote:
> Convert the PWM fan bindings to DT schema format.
> 
> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
> ---
>  .../devicetree/bindings/hwmon/pwm-fan.txt     |  68 +---------
>  .../devicetree/bindings/hwmon/pwm-fan.yaml    | 119 ++++++++++++++++++
>  2 files changed, 120 insertions(+), 67 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/hwmon/pwm-fan.yaml
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/pwm-fan.txt b/Documentation/devicetree/bindings/hwmon/pwm-fan.txt
> index 4509e688623a..48886f0ce415 100644
> --- a/Documentation/devicetree/bindings/hwmon/pwm-fan.txt
> +++ b/Documentation/devicetree/bindings/hwmon/pwm-fan.txt
> @@ -1,67 +1 @@
> -Bindings for a fan connected to the PWM lines
> -
> -Required properties:
> -- compatible	: "pwm-fan"
> -- pwms		: the PWM that is used to control the PWM fan
> -- cooling-levels      : PWM duty cycle values in a range from 0 to 255
> -			which correspond to thermal cooling states
> -
> -Optional properties:
> -- fan-supply		: phandle to the regulator that provides power to the fan
> -- interrupts		: This contains an interrupt specifier for each fan
> -			  tachometer output connected to an interrupt source.
> -			  The output signal must generate a defined number of
> -			  interrupts per fan revolution, which require that
> -			  it must be self resetting edge interrupts. See
> -			  interrupt-controller/interrupts.txt for the format.
> -- pulses-per-revolution : define the number of pulses per fan revolution for
> -			  each tachometer input as an integer (default is 2
> -			  interrupts per revolution). The value must be
> -			  greater than zero.
> -
> -Example:
> -	fan0: pwm-fan {
> -		compatible = "pwm-fan";
> -		#cooling-cells = <2>;
> -		pwms = <&pwm 0 10000 0>;
> -		cooling-levels = <0 102 170 230>;
> -	};
> -
> -	thermal-zones {
> -		cpu_thermal: cpu-thermal {
> -			     thermal-sensors = <&tmu 0>;
> -			     polling-delay-passive = <0>;
> -			     polling-delay = <0>;
> -			     trips {
> -					cpu_alert1: cpu-alert1 {
> -						    temperature = <100000>; /* millicelsius */
> -						    hysteresis = <2000>; /* millicelsius */
> -						    type = "passive";
> -					};
> -			     };
> -			     cooling-maps {
> -					map0 {
> -						    trip = <&cpu_alert1>;
> -						    cooling-device = <&fan0 0 1>;
> -					};
> -			     };
> -		};
> -
> -Example 2:
> -	fan0: pwm-fan {
> -		compatible = "pwm-fan";
> -		pwms = <&pwm 0 40000 0>;
> -		fan-supply = <&reg_fan>;
> -		interrupt-parent = <&gpio5>;
> -		interrupts = <1 IRQ_TYPE_EDGE_FALLING>;
> -		pulses-per-revolution = <2>;
> -	};
> -
> -Example 3:
> -	fan0: pwm-fan {
> -		compatible = "pwm-fan";
> -		pwms = <&pwm1 0 25000 0>;
> -		interrupts-extended = <&gpio1 1 IRQ_TYPE_EDGE_FALLING>,
> -			<&gpio2 5 IRQ_TYPE_EDGE_FALLING>;
> -		pulses-per-revolution = <2>, <1>;
> -	};
> +This file has moved to pwm-fan.yaml.
> diff --git a/Documentation/devicetree/bindings/hwmon/pwm-fan.yaml b/Documentation/devicetree/bindings/hwmon/pwm-fan.yaml
> new file mode 100644
> index 000000000000..048b6ea794c7
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/pwm-fan.yaml
> @@ -0,0 +1,119 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/hwmon/pwm-fan.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Fan connected to PWM lines
> +
> +maintainers:
> +  - Jean Delvare <jdelvare@suse.com>
> +  - Guenter Roeck <linux@roeck-us.net>
> +
> +properties:
> +  compatible:
> +    const: pwm-fan
> +
> +  cooling-levels:
> +    description: PWM duty cycle values corresponding to thermal cooling states.
> +    items:
> +      maximum: 255
> +    $ref: /schemas/types.yaml#/definitions/uint32-array
> +
> +  fan-supply:
> +    description: Phandle to the regulator that provides power to the fan.
> +
> +  interrupts:
> +    description:
> +      This contains an interrupt specifier for each fan tachometer output
> +      connected to an interrupt source. The output signal must generate a
> +      defined number of interrupts per fan revolution, which require that
> +      it must be self resetting edge interrupts.
> +    minItems: 1
> +    maxItems: 5

I'm not so sure I'd allow for more than 1 if the example is the only 
case we can find. More than 1 implies you have multiple fans controlled 
by 1 PWM. What do you do with the tach data other than display it or 
detect a stuck fan. You can't really implement any control loop unless 
you average the rpm's? I suppose there could be h/w, so okay.

> +
> +  pulses-per-revolution:
> +    description:
> +      Define the number of pulses per fan revolution for each tachometer
> +      input as an integer.
> +    items:
> +      minimum: 1
> +      maximum: 4
> +      default: 2
> +    minItems: 1
> +    maxItems: 5
> +    $ref: /schemas/types.yaml#/definitions/uint32-array
> +
> +  pwms:
> +    description: The PWM that is used to control the fan.
> +    maxItems: 1
> +
> +  pwm-names: true

Not part of the original binding. It's not that useful in general if 
there's only 1 entry. It's completely useless if the name is not defined 
for the OS to use. So drop it.

> +
> +  "#cooling-cells":
> +    description:
> +      Must be 2, in order to specify minimum and maximum cooling state used in
> +      the cooling-maps reference. The first cell is the minimum cooling state
> +      and the second cell is the maximum cooling state requested.

Just duplicating the same text from thermal-cooling-devices.yaml is 
pointless.

> +    const: 2

As this is globally the only allowed value, you don't need to duplicate 
this either.

'"#cooling-cells": true"' is sufficient.

Rob


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 30+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: hwmon: pwm-fan: Convert to DT schema
  2023-04-06 16:45     ` Rob Herring
  (?)
@ 2023-04-06 16:55       ` Cristian Ciocaltea
  -1 siblings, 0 replies; 30+ messages in thread
From: Cristian Ciocaltea @ 2023-04-06 16:55 UTC (permalink / raw)
  To: Rob Herring
  Cc: Jean Delvare, Guenter Roeck, Krzysztof Kozlowski, Heiko Stuebner,
	linux-hwmon, devicetree, linux-kernel, linux-arm-kernel,
	linux-rockchip, kernel

On 4/6/23 19:45, Rob Herring wrote:
> On Tue, Apr 04, 2023 at 08:38:06PM +0300, Cristian Ciocaltea wrote:
>> Convert the PWM fan bindings to DT schema format.
>>
>> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
>> ---
>>  .../devicetree/bindings/hwmon/pwm-fan.txt     |  68 +---------
>>  .../devicetree/bindings/hwmon/pwm-fan.yaml    | 119 ++++++++++++++++++
>>  2 files changed, 120 insertions(+), 67 deletions(-)
>>  create mode 100644 Documentation/devicetree/bindings/hwmon/pwm-fan.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/hwmon/pwm-fan.txt b/Documentation/devicetree/bindings/hwmon/pwm-fan.txt
>> index 4509e688623a..48886f0ce415 100644
>> --- a/Documentation/devicetree/bindings/hwmon/pwm-fan.txt
>> +++ b/Documentation/devicetree/bindings/hwmon/pwm-fan.txt
>> @@ -1,67 +1 @@
>> -Bindings for a fan connected to the PWM lines
>> -
>> -Required properties:
>> -- compatible	: "pwm-fan"
>> -- pwms		: the PWM that is used to control the PWM fan
>> -- cooling-levels      : PWM duty cycle values in a range from 0 to 255
>> -			which correspond to thermal cooling states
>> -
>> -Optional properties:
>> -- fan-supply		: phandle to the regulator that provides power to the fan
>> -- interrupts		: This contains an interrupt specifier for each fan
>> -			  tachometer output connected to an interrupt source.
>> -			  The output signal must generate a defined number of
>> -			  interrupts per fan revolution, which require that
>> -			  it must be self resetting edge interrupts. See
>> -			  interrupt-controller/interrupts.txt for the format.
>> -- pulses-per-revolution : define the number of pulses per fan revolution for
>> -			  each tachometer input as an integer (default is 2
>> -			  interrupts per revolution). The value must be
>> -			  greater than zero.
>> -
>> -Example:
>> -	fan0: pwm-fan {
>> -		compatible = "pwm-fan";
>> -		#cooling-cells = <2>;
>> -		pwms = <&pwm 0 10000 0>;
>> -		cooling-levels = <0 102 170 230>;
>> -	};
>> -
>> -	thermal-zones {
>> -		cpu_thermal: cpu-thermal {
>> -			     thermal-sensors = <&tmu 0>;
>> -			     polling-delay-passive = <0>;
>> -			     polling-delay = <0>;
>> -			     trips {
>> -					cpu_alert1: cpu-alert1 {
>> -						    temperature = <100000>; /* millicelsius */
>> -						    hysteresis = <2000>; /* millicelsius */
>> -						    type = "passive";
>> -					};
>> -			     };
>> -			     cooling-maps {
>> -					map0 {
>> -						    trip = <&cpu_alert1>;
>> -						    cooling-device = <&fan0 0 1>;
>> -					};
>> -			     };
>> -		};
>> -
>> -Example 2:
>> -	fan0: pwm-fan {
>> -		compatible = "pwm-fan";
>> -		pwms = <&pwm 0 40000 0>;
>> -		fan-supply = <&reg_fan>;
>> -		interrupt-parent = <&gpio5>;
>> -		interrupts = <1 IRQ_TYPE_EDGE_FALLING>;
>> -		pulses-per-revolution = <2>;
>> -	};
>> -
>> -Example 3:
>> -	fan0: pwm-fan {
>> -		compatible = "pwm-fan";
>> -		pwms = <&pwm1 0 25000 0>;
>> -		interrupts-extended = <&gpio1 1 IRQ_TYPE_EDGE_FALLING>,
>> -			<&gpio2 5 IRQ_TYPE_EDGE_FALLING>;
>> -		pulses-per-revolution = <2>, <1>;
>> -	};
>> +This file has moved to pwm-fan.yaml.
>> diff --git a/Documentation/devicetree/bindings/hwmon/pwm-fan.yaml b/Documentation/devicetree/bindings/hwmon/pwm-fan.yaml
>> new file mode 100644
>> index 000000000000..048b6ea794c7
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/hwmon/pwm-fan.yaml
>> @@ -0,0 +1,119 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/hwmon/pwm-fan.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Fan connected to PWM lines
>> +
>> +maintainers:
>> +  - Jean Delvare <jdelvare@suse.com>
>> +  - Guenter Roeck <linux@roeck-us.net>
>> +
>> +properties:
>> +  compatible:
>> +    const: pwm-fan
>> +
>> +  cooling-levels:
>> +    description: PWM duty cycle values corresponding to thermal cooling states.
>> +    items:
>> +      maximum: 255
>> +    $ref: /schemas/types.yaml#/definitions/uint32-array
>> +
>> +  fan-supply:
>> +    description: Phandle to the regulator that provides power to the fan.
>> +
>> +  interrupts:
>> +    description:
>> +      This contains an interrupt specifier for each fan tachometer output
>> +      connected to an interrupt source. The output signal must generate a
>> +      defined number of interrupts per fan revolution, which require that
>> +      it must be self resetting edge interrupts.
>> +    minItems: 1
>> +    maxItems: 5
> 
> I'm not so sure I'd allow for more than 1 if the example is the only 
> case we can find. More than 1 implies you have multiple fans controlled 
> by 1 PWM. What do you do with the tach data other than display it or 
> detect a stuck fan. You can't really implement any control loop unless 
> you average the rpm's? I suppose there could be h/w, so okay.

I will drop the 3rd example and use 'maxItems: 1' here. Same for
pulses-per-revolution below.

>> +
>> +  pulses-per-revolution:
>> +    description:
>> +      Define the number of pulses per fan revolution for each tachometer
>> +      input as an integer.
>> +    items:
>> +      minimum: 1
>> +      maximum: 4
>> +      default: 2
>> +    minItems: 1
>> +    maxItems: 5
>> +    $ref: /schemas/types.yaml#/definitions/uint32-array
>> +
>> +  pwms:
>> +    description: The PWM that is used to control the fan.
>> +    maxItems: 1
>> +
>> +  pwm-names: true
> 
> Not part of the original binding. It's not that useful in general if 
> there's only 1 entry. It's completely useless if the name is not defined 
> for the OS to use. So drop it.

Ack.

>> +
>> +  "#cooling-cells":
>> +    description:
>> +      Must be 2, in order to specify minimum and maximum cooling state used in
>> +      the cooling-maps reference. The first cell is the minimum cooling state
>> +      and the second cell is the maximum cooling state requested.
> 
> Just duplicating the same text from thermal-cooling-devices.yaml is 
> pointless.
> 
>> +    const: 2
> 
> As this is globally the only allowed value, you don't need to duplicate 
> this either.
> 
> '"#cooling-cells": true"' is sufficient.

Sure, will do.

Thanks,
Cristian

^ permalink raw reply	[flat|nested] 30+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: hwmon: pwm-fan: Convert to DT schema
@ 2023-04-06 16:55       ` Cristian Ciocaltea
  0 siblings, 0 replies; 30+ messages in thread
From: Cristian Ciocaltea @ 2023-04-06 16:55 UTC (permalink / raw)
  To: Rob Herring
  Cc: Jean Delvare, Guenter Roeck, Krzysztof Kozlowski, Heiko Stuebner,
	linux-hwmon, devicetree, linux-kernel, linux-arm-kernel,
	linux-rockchip, kernel

On 4/6/23 19:45, Rob Herring wrote:
> On Tue, Apr 04, 2023 at 08:38:06PM +0300, Cristian Ciocaltea wrote:
>> Convert the PWM fan bindings to DT schema format.
>>
>> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
>> ---
>>  .../devicetree/bindings/hwmon/pwm-fan.txt     |  68 +---------
>>  .../devicetree/bindings/hwmon/pwm-fan.yaml    | 119 ++++++++++++++++++
>>  2 files changed, 120 insertions(+), 67 deletions(-)
>>  create mode 100644 Documentation/devicetree/bindings/hwmon/pwm-fan.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/hwmon/pwm-fan.txt b/Documentation/devicetree/bindings/hwmon/pwm-fan.txt
>> index 4509e688623a..48886f0ce415 100644
>> --- a/Documentation/devicetree/bindings/hwmon/pwm-fan.txt
>> +++ b/Documentation/devicetree/bindings/hwmon/pwm-fan.txt
>> @@ -1,67 +1 @@
>> -Bindings for a fan connected to the PWM lines
>> -
>> -Required properties:
>> -- compatible	: "pwm-fan"
>> -- pwms		: the PWM that is used to control the PWM fan
>> -- cooling-levels      : PWM duty cycle values in a range from 0 to 255
>> -			which correspond to thermal cooling states
>> -
>> -Optional properties:
>> -- fan-supply		: phandle to the regulator that provides power to the fan
>> -- interrupts		: This contains an interrupt specifier for each fan
>> -			  tachometer output connected to an interrupt source.
>> -			  The output signal must generate a defined number of
>> -			  interrupts per fan revolution, which require that
>> -			  it must be self resetting edge interrupts. See
>> -			  interrupt-controller/interrupts.txt for the format.
>> -- pulses-per-revolution : define the number of pulses per fan revolution for
>> -			  each tachometer input as an integer (default is 2
>> -			  interrupts per revolution). The value must be
>> -			  greater than zero.
>> -
>> -Example:
>> -	fan0: pwm-fan {
>> -		compatible = "pwm-fan";
>> -		#cooling-cells = <2>;
>> -		pwms = <&pwm 0 10000 0>;
>> -		cooling-levels = <0 102 170 230>;
>> -	};
>> -
>> -	thermal-zones {
>> -		cpu_thermal: cpu-thermal {
>> -			     thermal-sensors = <&tmu 0>;
>> -			     polling-delay-passive = <0>;
>> -			     polling-delay = <0>;
>> -			     trips {
>> -					cpu_alert1: cpu-alert1 {
>> -						    temperature = <100000>; /* millicelsius */
>> -						    hysteresis = <2000>; /* millicelsius */
>> -						    type = "passive";
>> -					};
>> -			     };
>> -			     cooling-maps {
>> -					map0 {
>> -						    trip = <&cpu_alert1>;
>> -						    cooling-device = <&fan0 0 1>;
>> -					};
>> -			     };
>> -		};
>> -
>> -Example 2:
>> -	fan0: pwm-fan {
>> -		compatible = "pwm-fan";
>> -		pwms = <&pwm 0 40000 0>;
>> -		fan-supply = <&reg_fan>;
>> -		interrupt-parent = <&gpio5>;
>> -		interrupts = <1 IRQ_TYPE_EDGE_FALLING>;
>> -		pulses-per-revolution = <2>;
>> -	};
>> -
>> -Example 3:
>> -	fan0: pwm-fan {
>> -		compatible = "pwm-fan";
>> -		pwms = <&pwm1 0 25000 0>;
>> -		interrupts-extended = <&gpio1 1 IRQ_TYPE_EDGE_FALLING>,
>> -			<&gpio2 5 IRQ_TYPE_EDGE_FALLING>;
>> -		pulses-per-revolution = <2>, <1>;
>> -	};
>> +This file has moved to pwm-fan.yaml.
>> diff --git a/Documentation/devicetree/bindings/hwmon/pwm-fan.yaml b/Documentation/devicetree/bindings/hwmon/pwm-fan.yaml
>> new file mode 100644
>> index 000000000000..048b6ea794c7
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/hwmon/pwm-fan.yaml
>> @@ -0,0 +1,119 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/hwmon/pwm-fan.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Fan connected to PWM lines
>> +
>> +maintainers:
>> +  - Jean Delvare <jdelvare@suse.com>
>> +  - Guenter Roeck <linux@roeck-us.net>
>> +
>> +properties:
>> +  compatible:
>> +    const: pwm-fan
>> +
>> +  cooling-levels:
>> +    description: PWM duty cycle values corresponding to thermal cooling states.
>> +    items:
>> +      maximum: 255
>> +    $ref: /schemas/types.yaml#/definitions/uint32-array
>> +
>> +  fan-supply:
>> +    description: Phandle to the regulator that provides power to the fan.
>> +
>> +  interrupts:
>> +    description:
>> +      This contains an interrupt specifier for each fan tachometer output
>> +      connected to an interrupt source. The output signal must generate a
>> +      defined number of interrupts per fan revolution, which require that
>> +      it must be self resetting edge interrupts.
>> +    minItems: 1
>> +    maxItems: 5
> 
> I'm not so sure I'd allow for more than 1 if the example is the only 
> case we can find. More than 1 implies you have multiple fans controlled 
> by 1 PWM. What do you do with the tach data other than display it or 
> detect a stuck fan. You can't really implement any control loop unless 
> you average the rpm's? I suppose there could be h/w, so okay.

I will drop the 3rd example and use 'maxItems: 1' here. Same for
pulses-per-revolution below.

>> +
>> +  pulses-per-revolution:
>> +    description:
>> +      Define the number of pulses per fan revolution for each tachometer
>> +      input as an integer.
>> +    items:
>> +      minimum: 1
>> +      maximum: 4
>> +      default: 2
>> +    minItems: 1
>> +    maxItems: 5
>> +    $ref: /schemas/types.yaml#/definitions/uint32-array
>> +
>> +  pwms:
>> +    description: The PWM that is used to control the fan.
>> +    maxItems: 1
>> +
>> +  pwm-names: true
> 
> Not part of the original binding. It's not that useful in general if 
> there's only 1 entry. It's completely useless if the name is not defined 
> for the OS to use. So drop it.

Ack.

>> +
>> +  "#cooling-cells":
>> +    description:
>> +      Must be 2, in order to specify minimum and maximum cooling state used in
>> +      the cooling-maps reference. The first cell is the minimum cooling state
>> +      and the second cell is the maximum cooling state requested.
> 
> Just duplicating the same text from thermal-cooling-devices.yaml is 
> pointless.
> 
>> +    const: 2
> 
> As this is globally the only allowed value, you don't need to duplicate 
> this either.
> 
> '"#cooling-cells": true"' is sufficient.

Sure, will do.

Thanks,
Cristian

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

^ permalink raw reply	[flat|nested] 30+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: hwmon: pwm-fan: Convert to DT schema
@ 2023-04-06 16:55       ` Cristian Ciocaltea
  0 siblings, 0 replies; 30+ messages in thread
From: Cristian Ciocaltea @ 2023-04-06 16:55 UTC (permalink / raw)
  To: Rob Herring
  Cc: Jean Delvare, Guenter Roeck, Krzysztof Kozlowski, Heiko Stuebner,
	linux-hwmon, devicetree, linux-kernel, linux-arm-kernel,
	linux-rockchip, kernel

On 4/6/23 19:45, Rob Herring wrote:
> On Tue, Apr 04, 2023 at 08:38:06PM +0300, Cristian Ciocaltea wrote:
>> Convert the PWM fan bindings to DT schema format.
>>
>> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
>> ---
>>  .../devicetree/bindings/hwmon/pwm-fan.txt     |  68 +---------
>>  .../devicetree/bindings/hwmon/pwm-fan.yaml    | 119 ++++++++++++++++++
>>  2 files changed, 120 insertions(+), 67 deletions(-)
>>  create mode 100644 Documentation/devicetree/bindings/hwmon/pwm-fan.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/hwmon/pwm-fan.txt b/Documentation/devicetree/bindings/hwmon/pwm-fan.txt
>> index 4509e688623a..48886f0ce415 100644
>> --- a/Documentation/devicetree/bindings/hwmon/pwm-fan.txt
>> +++ b/Documentation/devicetree/bindings/hwmon/pwm-fan.txt
>> @@ -1,67 +1 @@
>> -Bindings for a fan connected to the PWM lines
>> -
>> -Required properties:
>> -- compatible	: "pwm-fan"
>> -- pwms		: the PWM that is used to control the PWM fan
>> -- cooling-levels      : PWM duty cycle values in a range from 0 to 255
>> -			which correspond to thermal cooling states
>> -
>> -Optional properties:
>> -- fan-supply		: phandle to the regulator that provides power to the fan
>> -- interrupts		: This contains an interrupt specifier for each fan
>> -			  tachometer output connected to an interrupt source.
>> -			  The output signal must generate a defined number of
>> -			  interrupts per fan revolution, which require that
>> -			  it must be self resetting edge interrupts. See
>> -			  interrupt-controller/interrupts.txt for the format.
>> -- pulses-per-revolution : define the number of pulses per fan revolution for
>> -			  each tachometer input as an integer (default is 2
>> -			  interrupts per revolution). The value must be
>> -			  greater than zero.
>> -
>> -Example:
>> -	fan0: pwm-fan {
>> -		compatible = "pwm-fan";
>> -		#cooling-cells = <2>;
>> -		pwms = <&pwm 0 10000 0>;
>> -		cooling-levels = <0 102 170 230>;
>> -	};
>> -
>> -	thermal-zones {
>> -		cpu_thermal: cpu-thermal {
>> -			     thermal-sensors = <&tmu 0>;
>> -			     polling-delay-passive = <0>;
>> -			     polling-delay = <0>;
>> -			     trips {
>> -					cpu_alert1: cpu-alert1 {
>> -						    temperature = <100000>; /* millicelsius */
>> -						    hysteresis = <2000>; /* millicelsius */
>> -						    type = "passive";
>> -					};
>> -			     };
>> -			     cooling-maps {
>> -					map0 {
>> -						    trip = <&cpu_alert1>;
>> -						    cooling-device = <&fan0 0 1>;
>> -					};
>> -			     };
>> -		};
>> -
>> -Example 2:
>> -	fan0: pwm-fan {
>> -		compatible = "pwm-fan";
>> -		pwms = <&pwm 0 40000 0>;
>> -		fan-supply = <&reg_fan>;
>> -		interrupt-parent = <&gpio5>;
>> -		interrupts = <1 IRQ_TYPE_EDGE_FALLING>;
>> -		pulses-per-revolution = <2>;
>> -	};
>> -
>> -Example 3:
>> -	fan0: pwm-fan {
>> -		compatible = "pwm-fan";
>> -		pwms = <&pwm1 0 25000 0>;
>> -		interrupts-extended = <&gpio1 1 IRQ_TYPE_EDGE_FALLING>,
>> -			<&gpio2 5 IRQ_TYPE_EDGE_FALLING>;
>> -		pulses-per-revolution = <2>, <1>;
>> -	};
>> +This file has moved to pwm-fan.yaml.
>> diff --git a/Documentation/devicetree/bindings/hwmon/pwm-fan.yaml b/Documentation/devicetree/bindings/hwmon/pwm-fan.yaml
>> new file mode 100644
>> index 000000000000..048b6ea794c7
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/hwmon/pwm-fan.yaml
>> @@ -0,0 +1,119 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/hwmon/pwm-fan.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Fan connected to PWM lines
>> +
>> +maintainers:
>> +  - Jean Delvare <jdelvare@suse.com>
>> +  - Guenter Roeck <linux@roeck-us.net>
>> +
>> +properties:
>> +  compatible:
>> +    const: pwm-fan
>> +
>> +  cooling-levels:
>> +    description: PWM duty cycle values corresponding to thermal cooling states.
>> +    items:
>> +      maximum: 255
>> +    $ref: /schemas/types.yaml#/definitions/uint32-array
>> +
>> +  fan-supply:
>> +    description: Phandle to the regulator that provides power to the fan.
>> +
>> +  interrupts:
>> +    description:
>> +      This contains an interrupt specifier for each fan tachometer output
>> +      connected to an interrupt source. The output signal must generate a
>> +      defined number of interrupts per fan revolution, which require that
>> +      it must be self resetting edge interrupts.
>> +    minItems: 1
>> +    maxItems: 5
> 
> I'm not so sure I'd allow for more than 1 if the example is the only 
> case we can find. More than 1 implies you have multiple fans controlled 
> by 1 PWM. What do you do with the tach data other than display it or 
> detect a stuck fan. You can't really implement any control loop unless 
> you average the rpm's? I suppose there could be h/w, so okay.

I will drop the 3rd example and use 'maxItems: 1' here. Same for
pulses-per-revolution below.

>> +
>> +  pulses-per-revolution:
>> +    description:
>> +      Define the number of pulses per fan revolution for each tachometer
>> +      input as an integer.
>> +    items:
>> +      minimum: 1
>> +      maximum: 4
>> +      default: 2
>> +    minItems: 1
>> +    maxItems: 5
>> +    $ref: /schemas/types.yaml#/definitions/uint32-array
>> +
>> +  pwms:
>> +    description: The PWM that is used to control the fan.
>> +    maxItems: 1
>> +
>> +  pwm-names: true
> 
> Not part of the original binding. It's not that useful in general if 
> there's only 1 entry. It's completely useless if the name is not defined 
> for the OS to use. So drop it.

Ack.

>> +
>> +  "#cooling-cells":
>> +    description:
>> +      Must be 2, in order to specify minimum and maximum cooling state used in
>> +      the cooling-maps reference. The first cell is the minimum cooling state
>> +      and the second cell is the maximum cooling state requested.
> 
> Just duplicating the same text from thermal-cooling-devices.yaml is 
> pointless.
> 
>> +    const: 2
> 
> As this is globally the only allowed value, you don't need to duplicate 
> this either.
> 
> '"#cooling-cells": true"' is sufficient.

Sure, will do.

Thanks,
Cristian

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 30+ messages in thread
* Re: (subset) [PATCH v2 0/2] Add PWM fan support to Rock 5B board
  2023-04-05 21:35       ` Heiko Stübner
  (?)
@ 2023-04-06 18:27         ` Guenter Roeck
  -1 siblings, 0 replies; 30+ messages in thread
From: Guenter Roeck @ 2023-04-06 18:27 UTC (permalink / raw)
  To: Heiko Stübner, Rob Herring, Krzysztof Kozlowski,
	Cristian Ciocaltea, Jean Delvare
  Cc: linux-hwmon, devicetree, kernel, linux-kernel, linux-arm-kernel,
	linux-rockchip

On 4/5/23 14:35, Heiko Stübner wrote:
> Am Mittwoch, 5. April 2023, 21:04:04 CEST schrieb Guenter Roeck:
>> On 4/5/23 10:45, Heiko Stuebner wrote:
>>> On Tue, 4 Apr 2023 20:38:05 +0300, Cristian Ciocaltea wrote:
>>>> This patch series enables support for the PWM controlled heat sink fan
>>>> on the Rock 5B SBC and, additionally, converts the hwmon PWM fan bindings
>>>> to DT schema format.
>>>>
>>>> Changes in v2:
>>>>    - Updated PATCH 1/2 according to Rob's review
>>>>    - Added Reviewed-by from Christopher to PATCH 2/2
>>>>    - v1: https://lore.kernel.org/lkml/20230403105052.426135-1-cristian.ciocaltea@collabora.com/
>>>>
>>>> [...]
>>>
>>> Applied, thanks!
>>>
>>
>> Both patches or only the second one ?
> 
> only the second one of course. According to earlier talks the dts patch
> does already follow the text binding, so the yaml conversion is actually
> not a requirement for it.
> 
> So I picked the dts patch let the binding sort itself when people have
> time for it :-) .
> 
> 
> Looking at the mail b4 created, I guessed this would also be visible
> with the subject saying (subset) and the listed commits only showing
> 
> [2/2] arm64: dts: rockchip: rk3588-rock-5b: Add pwm-fan
>        commit: f36bb17653e4b9e26bbdb1224027d20614e77636
> 

Kind of, sure, but I figured it doesn't hurt asking to avoid the situation
(again) where I apply a patch and then get a nice e-mail telling me that
some other branch also applied the same patch.

Guenter


^ permalink raw reply	[flat|nested] 30+ messages in thread
* Re: (subset) [PATCH v2 0/2] Add PWM fan support to Rock 5B board
@ 2023-04-06 18:27         ` Guenter Roeck
  0 siblings, 0 replies; 30+ messages in thread
From: Guenter Roeck @ 2023-04-06 18:27 UTC (permalink / raw)
  To: Heiko Stübner, Rob Herring, Krzysztof Kozlowski,
	Cristian Ciocaltea, Jean Delvare
  Cc: linux-hwmon, devicetree, kernel, linux-kernel, linux-arm-kernel,
	linux-rockchip

On 4/5/23 14:35, Heiko Stübner wrote:
> Am Mittwoch, 5. April 2023, 21:04:04 CEST schrieb Guenter Roeck:
>> On 4/5/23 10:45, Heiko Stuebner wrote:
>>> On Tue, 4 Apr 2023 20:38:05 +0300, Cristian Ciocaltea wrote:
>>>> This patch series enables support for the PWM controlled heat sink fan
>>>> on the Rock 5B SBC and, additionally, converts the hwmon PWM fan bindings
>>>> to DT schema format.
>>>>
>>>> Changes in v2:
>>>>    - Updated PATCH 1/2 according to Rob's review
>>>>    - Added Reviewed-by from Christopher to PATCH 2/2
>>>>    - v1: https://lore.kernel.org/lkml/20230403105052.426135-1-cristian.ciocaltea@collabora.com/
>>>>
>>>> [...]
>>>
>>> Applied, thanks!
>>>
>>
>> Both patches or only the second one ?
> 
> only the second one of course. According to earlier talks the dts patch
> does already follow the text binding, so the yaml conversion is actually
> not a requirement for it.
> 
> So I picked the dts patch let the binding sort itself when people have
> time for it :-) .
> 
> 
> Looking at the mail b4 created, I guessed this would also be visible
> with the subject saying (subset) and the listed commits only showing
> 
> [2/2] arm64: dts: rockchip: rk3588-rock-5b: Add pwm-fan
>        commit: f36bb17653e4b9e26bbdb1224027d20614e77636
> 

Kind of, sure, but I figured it doesn't hurt asking to avoid the situation
(again) where I apply a patch and then get a nice e-mail telling me that
some other branch also applied the same patch.

Guenter


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

^ permalink raw reply	[flat|nested] 30+ messages in thread
* Re: (subset) [PATCH v2 0/2] Add PWM fan support to Rock 5B board
@ 2023-04-06 18:27         ` Guenter Roeck
  0 siblings, 0 replies; 30+ messages in thread
From: Guenter Roeck @ 2023-04-06 18:27 UTC (permalink / raw)
  To: Heiko Stübner, Rob Herring, Krzysztof Kozlowski,
	Cristian Ciocaltea, Jean Delvare
  Cc: linux-hwmon, devicetree, kernel, linux-kernel, linux-arm-kernel,
	linux-rockchip

On 4/5/23 14:35, Heiko Stübner wrote:
> Am Mittwoch, 5. April 2023, 21:04:04 CEST schrieb Guenter Roeck:
>> On 4/5/23 10:45, Heiko Stuebner wrote:
>>> On Tue, 4 Apr 2023 20:38:05 +0300, Cristian Ciocaltea wrote:
>>>> This patch series enables support for the PWM controlled heat sink fan
>>>> on the Rock 5B SBC and, additionally, converts the hwmon PWM fan bindings
>>>> to DT schema format.
>>>>
>>>> Changes in v2:
>>>>    - Updated PATCH 1/2 according to Rob's review
>>>>    - Added Reviewed-by from Christopher to PATCH 2/2
>>>>    - v1: https://lore.kernel.org/lkml/20230403105052.426135-1-cristian.ciocaltea@collabora.com/
>>>>
>>>> [...]
>>>
>>> Applied, thanks!
>>>
>>
>> Both patches or only the second one ?
> 
> only the second one of course. According to earlier talks the dts patch
> does already follow the text binding, so the yaml conversion is actually
> not a requirement for it.
> 
> So I picked the dts patch let the binding sort itself when people have
> time for it :-) .
> 
> 
> Looking at the mail b4 created, I guessed this would also be visible
> with the subject saying (subset) and the listed commits only showing
> 
> [2/2] arm64: dts: rockchip: rk3588-rock-5b: Add pwm-fan
>        commit: f36bb17653e4b9e26bbdb1224027d20614e77636
> 

Kind of, sure, but I figured it doesn't hurt asking to avoid the situation
(again) where I apply a patch and then get a nice e-mail telling me that
some other branch also applied the same patch.

Guenter


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 30+ messages in thread
* Re: (subset) [PATCH v2 0/2] Add PWM fan support to Rock 5B board
  2023-04-06 18:27         ` Guenter Roeck
  (?)
@ 2023-04-06 18:40           ` Heiko Stübner
  -1 siblings, 0 replies; 30+ messages in thread
From: Heiko Stübner @ 2023-04-06 18:40 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Cristian Ciocaltea,
	Jean Delvare, Guenter Roeck
  Cc: linux-hwmon, devicetree, kernel, linux-kernel, linux-arm-kernel,
	linux-rockchip

Am Donnerstag, 6. April 2023, 20:27:33 CEST schrieb Guenter Roeck:
> On 4/5/23 14:35, Heiko Stübner wrote:
> > Am Mittwoch, 5. April 2023, 21:04:04 CEST schrieb Guenter Roeck:
> >> On 4/5/23 10:45, Heiko Stuebner wrote:
> >>> On Tue, 4 Apr 2023 20:38:05 +0300, Cristian Ciocaltea wrote:
> >>>> This patch series enables support for the PWM controlled heat sink fan
> >>>> on the Rock 5B SBC and, additionally, converts the hwmon PWM fan bindings
> >>>> to DT schema format.
> >>>>
> >>>> Changes in v2:
> >>>>    - Updated PATCH 1/2 according to Rob's review
> >>>>    - Added Reviewed-by from Christopher to PATCH 2/2
> >>>>    - v1: https://lore.kernel.org/lkml/20230403105052.426135-1-cristian.ciocaltea@collabora.com/
> >>>>
> >>>> [...]
> >>>
> >>> Applied, thanks!
> >>>
> >>
> >> Both patches or only the second one ?
> > 
> > only the second one of course. According to earlier talks the dts patch
> > does already follow the text binding, so the yaml conversion is actually
> > not a requirement for it.
> > 
> > So I picked the dts patch let the binding sort itself when people have
> > time for it :-) .
> > 
> > 
> > Looking at the mail b4 created, I guessed this would also be visible
> > with the subject saying (subset) and the listed commits only showing
> > 
> > [2/2] arm64: dts: rockchip: rk3588-rock-5b: Add pwm-fan
> >        commit: f36bb17653e4b9e26bbdb1224027d20614e77636
> > 
> 
> Kind of, sure, but I figured it doesn't hurt asking to avoid the situation
> (again) where I apply a patch and then get a nice e-mail telling me that
> some other branch also applied the same patch.

no worries and yes better save than sorry.
Though you had me worried for a bit that somehow the mail b4 generated
for me was faulty ;-)

Heiko



^ permalink raw reply	[flat|nested] 30+ messages in thread
* Re: (subset) [PATCH v2 0/2] Add PWM fan support to Rock 5B board
@ 2023-04-06 18:40           ` Heiko Stübner
  0 siblings, 0 replies; 30+ messages in thread
From: Heiko Stübner @ 2023-04-06 18:40 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Cristian Ciocaltea,
	Jean Delvare, Guenter Roeck
  Cc: linux-hwmon, devicetree, kernel, linux-kernel, linux-arm-kernel,
	linux-rockchip

Am Donnerstag, 6. April 2023, 20:27:33 CEST schrieb Guenter Roeck:
> On 4/5/23 14:35, Heiko Stübner wrote:
> > Am Mittwoch, 5. April 2023, 21:04:04 CEST schrieb Guenter Roeck:
> >> On 4/5/23 10:45, Heiko Stuebner wrote:
> >>> On Tue, 4 Apr 2023 20:38:05 +0300, Cristian Ciocaltea wrote:
> >>>> This patch series enables support for the PWM controlled heat sink fan
> >>>> on the Rock 5B SBC and, additionally, converts the hwmon PWM fan bindings
> >>>> to DT schema format.
> >>>>
> >>>> Changes in v2:
> >>>>    - Updated PATCH 1/2 according to Rob's review
> >>>>    - Added Reviewed-by from Christopher to PATCH 2/2
> >>>>    - v1: https://lore.kernel.org/lkml/20230403105052.426135-1-cristian.ciocaltea@collabora.com/
> >>>>
> >>>> [...]
> >>>
> >>> Applied, thanks!
> >>>
> >>
> >> Both patches or only the second one ?
> > 
> > only the second one of course. According to earlier talks the dts patch
> > does already follow the text binding, so the yaml conversion is actually
> > not a requirement for it.
> > 
> > So I picked the dts patch let the binding sort itself when people have
> > time for it :-) .
> > 
> > 
> > Looking at the mail b4 created, I guessed this would also be visible
> > with the subject saying (subset) and the listed commits only showing
> > 
> > [2/2] arm64: dts: rockchip: rk3588-rock-5b: Add pwm-fan
> >        commit: f36bb17653e4b9e26bbdb1224027d20614e77636
> > 
> 
> Kind of, sure, but I figured it doesn't hurt asking to avoid the situation
> (again) where I apply a patch and then get a nice e-mail telling me that
> some other branch also applied the same patch.

no worries and yes better save than sorry.
Though you had me worried for a bit that somehow the mail b4 generated
for me was faulty ;-)

Heiko



_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

^ permalink raw reply	[flat|nested] 30+ messages in thread
* Re: (subset) [PATCH v2 0/2] Add PWM fan support to Rock 5B board
@ 2023-04-06 18:40           ` Heiko Stübner
  0 siblings, 0 replies; 30+ messages in thread
From: Heiko Stübner @ 2023-04-06 18:40 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Cristian Ciocaltea,
	Jean Delvare, Guenter Roeck
  Cc: linux-hwmon, devicetree, kernel, linux-kernel, linux-arm-kernel,
	linux-rockchip

Am Donnerstag, 6. April 2023, 20:27:33 CEST schrieb Guenter Roeck:
> On 4/5/23 14:35, Heiko Stübner wrote:
> > Am Mittwoch, 5. April 2023, 21:04:04 CEST schrieb Guenter Roeck:
> >> On 4/5/23 10:45, Heiko Stuebner wrote:
> >>> On Tue, 4 Apr 2023 20:38:05 +0300, Cristian Ciocaltea wrote:
> >>>> This patch series enables support for the PWM controlled heat sink fan
> >>>> on the Rock 5B SBC and, additionally, converts the hwmon PWM fan bindings
> >>>> to DT schema format.
> >>>>
> >>>> Changes in v2:
> >>>>    - Updated PATCH 1/2 according to Rob's review
> >>>>    - Added Reviewed-by from Christopher to PATCH 2/2
> >>>>    - v1: https://lore.kernel.org/lkml/20230403105052.426135-1-cristian.ciocaltea@collabora.com/
> >>>>
> >>>> [...]
> >>>
> >>> Applied, thanks!
> >>>
> >>
> >> Both patches or only the second one ?
> > 
> > only the second one of course. According to earlier talks the dts patch
> > does already follow the text binding, so the yaml conversion is actually
> > not a requirement for it.
> > 
> > So I picked the dts patch let the binding sort itself when people have
> > time for it :-) .
> > 
> > 
> > Looking at the mail b4 created, I guessed this would also be visible
> > with the subject saying (subset) and the listed commits only showing
> > 
> > [2/2] arm64: dts: rockchip: rk3588-rock-5b: Add pwm-fan
> >        commit: f36bb17653e4b9e26bbdb1224027d20614e77636
> > 
> 
> Kind of, sure, but I figured it doesn't hurt asking to avoid the situation
> (again) where I apply a patch and then get a nice e-mail telling me that
> some other branch also applied the same patch.

no worries and yes better save than sorry.
Though you had me worried for a bit that somehow the mail b4 generated
for me was faulty ;-)

Heiko



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 30+ messages in thread
end of thread, other threads:[~2023-04-06 18:42 UTC | newest]

Thread overview: 30+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-04 17:38 [PATCH v2 0/2] Add PWM fan support to Rock 5B board Cristian Ciocaltea
2023-04-04 17:38 ` Cristian Ciocaltea
2023-04-04 17:38 ` Cristian Ciocaltea
2023-04-04 17:38 ` [PATCH v2 1/2] dt-bindings: hwmon: pwm-fan: Convert to DT schema Cristian Ciocaltea
2023-04-04 17:38   ` Cristian Ciocaltea
2023-04-04 17:38   ` Cristian Ciocaltea
2023-04-06 16:45   ` Rob Herring
2023-04-06 16:45     ` Rob Herring
2023-04-06 16:45     ` Rob Herring
2023-04-06 16:55     ` Cristian Ciocaltea
2023-04-06 16:55       ` Cristian Ciocaltea
2023-04-06 16:55       ` Cristian Ciocaltea
2023-04-04 17:38 ` [PATCH v2 2/2] arm64: dts: rockchip: rk3588-rock-5b: Add pwm-fan Cristian Ciocaltea
2023-04-04 17:38   ` Cristian Ciocaltea
2023-04-04 17:38   ` Cristian Ciocaltea
2023-04-05 17:45 ` (subset) [PATCH v2 0/2] Add PWM fan support to Rock 5B board Heiko Stuebner
2023-04-05 17:45   ` Heiko Stuebner
2023-04-05 17:45   ` Heiko Stuebner
2023-04-05 19:04   ` Guenter Roeck
2023-04-05 19:04     ` Guenter Roeck
2023-04-05 19:04     ` Guenter Roeck
2023-04-05 21:35     ` Heiko Stübner
2023-04-05 21:35       ` Heiko Stübner
2023-04-05 21:35       ` Heiko Stübner
2023-04-06 18:27       ` Guenter Roeck
2023-04-06 18:27         ` Guenter Roeck
2023-04-06 18:27         ` Guenter Roeck
2023-04-06 18:40         ` Heiko Stübner
2023-04-06 18:40           ` Heiko Stübner
2023-04-06 18:40           ` Heiko Stübner

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.