All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH net-next] net: stmmac: remove set but unused mask in stmmac_ethtool_set_link_ksettings()
@ 2023-04-06 12:54 ` Vladimir Oltean
  0 siblings, 0 replies; 6+ messages in thread
From: Vladimir Oltean @ 2023-04-06 12:54 UTC (permalink / raw)
  To: netdev, Jakub Kicinski
  Cc: David S. Miller, Eric Dumazet, Paolo Abeni, Andrew Lunn,
	Florian Fainelli, Giuseppe Cavallaro, Alexandre Torgue,
	Jose Abreu, Maxime Coquelin, Heiner Kallweit, Russell King,
	linux-stm32, linux-arm-kernel

This was never used since the commit that added it - e58bb43f5e43
("stmmac: initial support to manage pcs modes").

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
 drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c
index 35c8dd92d369..2ae73ab842d4 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c
@@ -393,19 +393,10 @@ stmmac_ethtool_set_link_ksettings(struct net_device *dev,
 
 	if (priv->hw->pcs & STMMAC_PCS_RGMII ||
 	    priv->hw->pcs & STMMAC_PCS_SGMII) {
-		u32 mask = ADVERTISED_Autoneg | ADVERTISED_Pause;
-
 		/* Only support ANE */
 		if (cmd->base.autoneg != AUTONEG_ENABLE)
 			return -EINVAL;
 
-		mask &= (ADVERTISED_1000baseT_Half |
-			ADVERTISED_1000baseT_Full |
-			ADVERTISED_100baseT_Half |
-			ADVERTISED_100baseT_Full |
-			ADVERTISED_10baseT_Half |
-			ADVERTISED_10baseT_Full);
-
 		mutex_lock(&priv->lock);
 		stmmac_pcs_ctrl_ane(priv, priv->ioaddr, 1, priv->hw->ps, 0);
 		mutex_unlock(&priv->lock);
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH net-next] net: stmmac: remove set but unused mask in stmmac_ethtool_set_link_ksettings()
@ 2023-04-06 12:54 ` Vladimir Oltean
  0 siblings, 0 replies; 6+ messages in thread
From: Vladimir Oltean @ 2023-04-06 12:54 UTC (permalink / raw)
  To: netdev, Jakub Kicinski
  Cc: David S. Miller, Eric Dumazet, Paolo Abeni, Andrew Lunn,
	Florian Fainelli, Giuseppe Cavallaro, Alexandre Torgue,
	Jose Abreu, Maxime Coquelin, Heiner Kallweit, Russell King,
	linux-stm32, linux-arm-kernel

This was never used since the commit that added it - e58bb43f5e43
("stmmac: initial support to manage pcs modes").

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
 drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c
index 35c8dd92d369..2ae73ab842d4 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c
@@ -393,19 +393,10 @@ stmmac_ethtool_set_link_ksettings(struct net_device *dev,
 
 	if (priv->hw->pcs & STMMAC_PCS_RGMII ||
 	    priv->hw->pcs & STMMAC_PCS_SGMII) {
-		u32 mask = ADVERTISED_Autoneg | ADVERTISED_Pause;
-
 		/* Only support ANE */
 		if (cmd->base.autoneg != AUTONEG_ENABLE)
 			return -EINVAL;
 
-		mask &= (ADVERTISED_1000baseT_Half |
-			ADVERTISED_1000baseT_Full |
-			ADVERTISED_100baseT_Half |
-			ADVERTISED_100baseT_Full |
-			ADVERTISED_10baseT_Half |
-			ADVERTISED_10baseT_Full);
-
 		mutex_lock(&priv->lock);
 		stmmac_pcs_ctrl_ane(priv, priv->ioaddr, 1, priv->hw->ps, 0);
 		mutex_unlock(&priv->lock);
-- 
2.34.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH net-next] net: stmmac: remove set but unused mask in stmmac_ethtool_set_link_ksettings()
  2023-04-06 12:54 ` Vladimir Oltean
@ 2023-04-06 15:07   ` Simon Horman
  -1 siblings, 0 replies; 6+ messages in thread
From: Simon Horman @ 2023-04-06 15:07 UTC (permalink / raw)
  To: Vladimir Oltean
  Cc: netdev, Jakub Kicinski, David S. Miller, Eric Dumazet,
	Paolo Abeni, Andrew Lunn, Florian Fainelli, Giuseppe Cavallaro,
	Alexandre Torgue, Jose Abreu, Maxime Coquelin, Heiner Kallweit,
	Russell King, linux-stm32, linux-arm-kernel

On Thu, Apr 06, 2023 at 03:54:12PM +0300, Vladimir Oltean wrote:
> This was never used since the commit that added it - e58bb43f5e43
> ("stmmac: initial support to manage pcs modes").
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>


^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH net-next] net: stmmac: remove set but unused mask in stmmac_ethtool_set_link_ksettings()
@ 2023-04-06 15:07   ` Simon Horman
  0 siblings, 0 replies; 6+ messages in thread
From: Simon Horman @ 2023-04-06 15:07 UTC (permalink / raw)
  To: Vladimir Oltean
  Cc: netdev, Jakub Kicinski, David S. Miller, Eric Dumazet,
	Paolo Abeni, Andrew Lunn, Florian Fainelli, Giuseppe Cavallaro,
	Alexandre Torgue, Jose Abreu, Maxime Coquelin, Heiner Kallweit,
	Russell King, linux-stm32, linux-arm-kernel

On Thu, Apr 06, 2023 at 03:54:12PM +0300, Vladimir Oltean wrote:
> This was never used since the commit that added it - e58bb43f5e43
> ("stmmac: initial support to manage pcs modes").
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH net-next] net: stmmac: remove set but unused mask in stmmac_ethtool_set_link_ksettings()
  2023-04-06 12:54 ` Vladimir Oltean
@ 2023-04-08  3:10   ` patchwork-bot+netdevbpf
  -1 siblings, 0 replies; 6+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-04-08  3:10 UTC (permalink / raw)
  To: Vladimir Oltean
  Cc: netdev, kuba, davem, edumazet, pabeni, andrew, f.fainelli,
	peppe.cavallaro, alexandre.torgue, joabreu, mcoquelin.stm32,
	hkallweit1, linux, linux-stm32, linux-arm-kernel

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Thu,  6 Apr 2023 15:54:12 +0300 you wrote:
> This was never used since the commit that added it - e58bb43f5e43
> ("stmmac: initial support to manage pcs modes").
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> ---
>  drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c | 9 ---------
>  1 file changed, 9 deletions(-)

Here is the summary with links:
  - [net-next] net: stmmac: remove set but unused mask in stmmac_ethtool_set_link_ksettings()
    https://git.kernel.org/netdev/net-next/c/07e75db6b1b2

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH net-next] net: stmmac: remove set but unused mask in stmmac_ethtool_set_link_ksettings()
@ 2023-04-08  3:10   ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 6+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-04-08  3:10 UTC (permalink / raw)
  To: Vladimir Oltean
  Cc: netdev, kuba, davem, edumazet, pabeni, andrew, f.fainelli,
	peppe.cavallaro, alexandre.torgue, joabreu, mcoquelin.stm32,
	hkallweit1, linux, linux-stm32, linux-arm-kernel

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Thu,  6 Apr 2023 15:54:12 +0300 you wrote:
> This was never used since the commit that added it - e58bb43f5e43
> ("stmmac: initial support to manage pcs modes").
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> ---
>  drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c | 9 ---------
>  1 file changed, 9 deletions(-)

Here is the summary with links:
  - [net-next] net: stmmac: remove set but unused mask in stmmac_ethtool_set_link_ksettings()
    https://git.kernel.org/netdev/net-next/c/07e75db6b1b2

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-04-08  3:11 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-06 12:54 [PATCH net-next] net: stmmac: remove set but unused mask in stmmac_ethtool_set_link_ksettings() Vladimir Oltean
2023-04-06 12:54 ` Vladimir Oltean
2023-04-06 15:07 ` Simon Horman
2023-04-06 15:07   ` Simon Horman
2023-04-08  3:10 ` patchwork-bot+netdevbpf
2023-04-08  3:10   ` patchwork-bot+netdevbpf

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.