All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] hw/core: Move numa.c into the target independent source set
@ 2023-04-13 18:26 Thomas Huth
  2023-04-14 13:52 ` Philippe Mathieu-Daudé
  0 siblings, 1 reply; 2+ messages in thread
From: Thomas Huth @ 2023-04-13 18:26 UTC (permalink / raw)
  To: qemu-devel
  Cc: Philippe Mathieu-Daudé, Markus Armbruster, Stefan Hajnoczi

There is nothing that depends on target specific macros in this
file, so we can move it to the common source set to avoid that
we have to compile this file multiple times (one time for each
target).

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 hw/core/meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/core/meson.build b/hw/core/meson.build
index 7a4d02b6c0..ae977c9396 100644
--- a/hw/core/meson.build
+++ b/hw/core/meson.build
@@ -44,6 +44,7 @@ softmmu_ss.add(files(
   'machine.c',
   'nmi.c',
   'null-machine.c',
+  'numa.c',
   'qdev-fw.c',
   'qdev-properties-system.c',
   'sysbus.c',
@@ -53,5 +54,4 @@ softmmu_ss.add(files(
 
 specific_ss.add(when: 'CONFIG_SOFTMMU', if_true: files(
   'machine-qmp-cmds.c',
-  'numa.c',
 ))
-- 
2.31.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] hw/core: Move numa.c into the target independent source set
  2023-04-13 18:26 [PATCH] hw/core: Move numa.c into the target independent source set Thomas Huth
@ 2023-04-14 13:52 ` Philippe Mathieu-Daudé
  0 siblings, 0 replies; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2023-04-14 13:52 UTC (permalink / raw)
  To: Thomas Huth, qemu-devel; +Cc: Markus Armbruster, Stefan Hajnoczi

On 13/4/23 20:26, Thomas Huth wrote:
> There is nothing that depends on target specific macros in this
> file, so we can move it to the common source set to avoid that
> we have to compile this file multiple times (one time for each
> target).
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>   hw/core/meson.build | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-04-14 13:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-13 18:26 [PATCH] hw/core: Move numa.c into the target independent source set Thomas Huth
2023-04-14 13:52 ` Philippe Mathieu-Daudé

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.