* [PATCH v2] docs: kvm: vfio: Require call KVM_DEV_VFIO_GROUP_ADD before VFIO_GROUP_GET_DEVICE_FD
@ 2023-02-22 2:22 Yi Liu
2023-02-22 2:29 ` Tian, Kevin
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Yi Liu @ 2023-02-22 2:22 UTC (permalink / raw)
To: alex.williamson, jgg, kevin.tian
Cc: cohuck, eric.auger, kvm, mjrosato, chao.p.peng, yi.l.liu,
yi.y.sun, pbonzini
as some vfio_device drivers require a kvm pointer to be set in their
open_device and kvm pointer is set to VFIO in GROUP_ADD path.
Signed-off-by: Yi Liu <yi.l.liu@intel.com>
---
v2:
- Adopt Alex's suggestion
v1: https://lore.kernel.org/kvm/20230221034114.135386-1-yi.l.liu@intel.com/
---
Documentation/virt/kvm/devices/vfio.rst | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/Documentation/virt/kvm/devices/vfio.rst b/Documentation/virt/kvm/devices/vfio.rst
index 2d20dc561069..79b6811bb4f3 100644
--- a/Documentation/virt/kvm/devices/vfio.rst
+++ b/Documentation/virt/kvm/devices/vfio.rst
@@ -39,3 +39,10 @@ KVM_DEV_VFIO_GROUP attributes:
- @groupfd is a file descriptor for a VFIO group;
- @tablefd is a file descriptor for a TCE table allocated via
KVM_CREATE_SPAPR_TCE.
+
+::
+
+The GROUP_ADD operation above should be invoked prior to accessing the
+device file descriptor via VFIO_GROUP_GET_DEVICE_FD in order to support
+drivers which require a kvm pointer to be set in their .open_device()
+callback.
--
2.34.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* RE: [PATCH v2] docs: kvm: vfio: Require call KVM_DEV_VFIO_GROUP_ADD before VFIO_GROUP_GET_DEVICE_FD
2023-02-22 2:22 [PATCH v2] docs: kvm: vfio: Require call KVM_DEV_VFIO_GROUP_ADD before VFIO_GROUP_GET_DEVICE_FD Yi Liu
@ 2023-02-22 2:29 ` Tian, Kevin
2023-02-22 2:32 ` Tian, Kevin
2023-04-11 19:28 ` Alex Williamson
2 siblings, 0 replies; 9+ messages in thread
From: Tian, Kevin @ 2023-02-22 2:29 UTC (permalink / raw)
To: Liu, Yi L, alex.williamson, jgg
Cc: cohuck, eric.auger, kvm, mjrosato, chao.p.peng, yi.y.sun, pbonzini
> From: Liu, Yi L <yi.l.liu@intel.com>
> Sent: Wednesday, February 22, 2023 10:23 AM
>
> as some vfio_device drivers require a kvm pointer to be set in their
> open_device and kvm pointer is set to VFIO in GROUP_ADD path.
>
> Signed-off-by: Yi Liu <yi.l.liu@intel.com>
Reviewed-by: Kevin Tian <kevin.tian@intel.com>
^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [PATCH v2] docs: kvm: vfio: Require call KVM_DEV_VFIO_GROUP_ADD before VFIO_GROUP_GET_DEVICE_FD
2023-02-22 2:22 [PATCH v2] docs: kvm: vfio: Require call KVM_DEV_VFIO_GROUP_ADD before VFIO_GROUP_GET_DEVICE_FD Yi Liu
2023-02-22 2:29 ` Tian, Kevin
@ 2023-02-22 2:32 ` Tian, Kevin
2023-03-25 12:37 ` Liu, Yi L
2023-04-11 19:28 ` Alex Williamson
2 siblings, 1 reply; 9+ messages in thread
From: Tian, Kevin @ 2023-02-22 2:32 UTC (permalink / raw)
To: Liu, Yi L, alex.williamson, jgg
Cc: cohuck, eric.auger, kvm, mjrosato, chao.p.peng, yi.y.sun, Paolo Bonzini
Paolo's mail address is wrong. Added the right one.
> From: Liu, Yi L <yi.l.liu@intel.com>
> Sent: Wednesday, February 22, 2023 10:23 AM
>
> as some vfio_device drivers require a kvm pointer to be set in their
> open_device and kvm pointer is set to VFIO in GROUP_ADD path.
>
> Signed-off-by: Yi Liu <yi.l.liu@intel.com>
> ---
> v2:
> - Adopt Alex's suggestion
> v1: https://lore.kernel.org/kvm/20230221034114.135386-1-
> yi.l.liu@intel.com/
> ---
> Documentation/virt/kvm/devices/vfio.rst | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/virt/kvm/devices/vfio.rst
> b/Documentation/virt/kvm/devices/vfio.rst
> index 2d20dc561069..79b6811bb4f3 100644
> --- a/Documentation/virt/kvm/devices/vfio.rst
> +++ b/Documentation/virt/kvm/devices/vfio.rst
> @@ -39,3 +39,10 @@ KVM_DEV_VFIO_GROUP attributes:
> - @groupfd is a file descriptor for a VFIO group;
> - @tablefd is a file descriptor for a TCE table allocated via
> KVM_CREATE_SPAPR_TCE.
> +
> +::
> +
> +The GROUP_ADD operation above should be invoked prior to accessing the
> +device file descriptor via VFIO_GROUP_GET_DEVICE_FD in order to support
> +drivers which require a kvm pointer to be set in their .open_device()
> +callback.
> --
> 2.34.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [PATCH v2] docs: kvm: vfio: Require call KVM_DEV_VFIO_GROUP_ADD before VFIO_GROUP_GET_DEVICE_FD
2023-02-22 2:32 ` Tian, Kevin
@ 2023-03-25 12:37 ` Liu, Yi L
2023-03-27 16:20 ` Alex Williamson
0 siblings, 1 reply; 9+ messages in thread
From: Liu, Yi L @ 2023-03-25 12:37 UTC (permalink / raw)
To: Tian, Kevin, alex.williamson, jgg
Cc: cohuck, eric.auger, kvm, mjrosato, chao.p.peng, yi.y.sun, Paolo Bonzini
> From: Tian, Kevin <kevin.tian@intel.com>
> Sent: Wednesday, February 22, 2023 10:33 AM
>
> Paolo's mail address is wrong. Added the right one.
Thanks. @Alex, do you want a new version or this one is ok?
Regards,
Yi Liu
> > From: Liu, Yi L <yi.l.liu@intel.com>
> > Sent: Wednesday, February 22, 2023 10:23 AM
> >
> > as some vfio_device drivers require a kvm pointer to be set in their
> > open_device and kvm pointer is set to VFIO in GROUP_ADD path.
> >
> > Signed-off-by: Yi Liu <yi.l.liu@intel.com>
> > ---
> > v2:
> > - Adopt Alex's suggestion
> > v1: https://lore.kernel.org/kvm/20230221034114.135386-1-
> > yi.l.liu@intel.com/
> > ---
> > Documentation/virt/kvm/devices/vfio.rst | 7 +++++++
> > 1 file changed, 7 insertions(+)
> >
> > diff --git a/Documentation/virt/kvm/devices/vfio.rst
> > b/Documentation/virt/kvm/devices/vfio.rst
> > index 2d20dc561069..79b6811bb4f3 100644
> > --- a/Documentation/virt/kvm/devices/vfio.rst
> > +++ b/Documentation/virt/kvm/devices/vfio.rst
> > @@ -39,3 +39,10 @@ KVM_DEV_VFIO_GROUP attributes:
> > - @groupfd is a file descriptor for a VFIO group;
> > - @tablefd is a file descriptor for a TCE table allocated via
> > KVM_CREATE_SPAPR_TCE.
> > +
> > +::
> > +
> > +The GROUP_ADD operation above should be invoked prior to accessing
> the
> > +device file descriptor via VFIO_GROUP_GET_DEVICE_FD in order to
> support
> > +drivers which require a kvm pointer to be set in their .open_device()
> > +callback.
> > --
> > 2.34.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2] docs: kvm: vfio: Require call KVM_DEV_VFIO_GROUP_ADD before VFIO_GROUP_GET_DEVICE_FD
2023-03-25 12:37 ` Liu, Yi L
@ 2023-03-27 16:20 ` Alex Williamson
0 siblings, 0 replies; 9+ messages in thread
From: Alex Williamson @ 2023-03-27 16:20 UTC (permalink / raw)
To: Liu, Yi L
Cc: Tian, Kevin, jgg, cohuck, eric.auger, kvm, mjrosato, chao.p.peng,
yi.y.sun, Paolo Bonzini
On Sat, 25 Mar 2023 12:37:02 +0000
"Liu, Yi L" <yi.l.liu@intel.com> wrote:
> > From: Tian, Kevin <kevin.tian@intel.com>
> > Sent: Wednesday, February 22, 2023 10:33 AM
> >
> > Paolo's mail address is wrong. Added the right one.
>
> Thanks. @Alex, do you want a new version or this one is ok?
This one is fine. Thanks,
Alex
> > > From: Liu, Yi L <yi.l.liu@intel.com>
> > > Sent: Wednesday, February 22, 2023 10:23 AM
> > >
> > > as some vfio_device drivers require a kvm pointer to be set in their
> > > open_device and kvm pointer is set to VFIO in GROUP_ADD path.
> > >
> > > Signed-off-by: Yi Liu <yi.l.liu@intel.com>
> > > ---
> > > v2:
> > > - Adopt Alex's suggestion
> > > v1: https://lore.kernel.org/kvm/20230221034114.135386-1-
> > > yi.l.liu@intel.com/
> > > ---
> > > Documentation/virt/kvm/devices/vfio.rst | 7 +++++++
> > > 1 file changed, 7 insertions(+)
> > >
> > > diff --git a/Documentation/virt/kvm/devices/vfio.rst
> > > b/Documentation/virt/kvm/devices/vfio.rst
> > > index 2d20dc561069..79b6811bb4f3 100644
> > > --- a/Documentation/virt/kvm/devices/vfio.rst
> > > +++ b/Documentation/virt/kvm/devices/vfio.rst
> > > @@ -39,3 +39,10 @@ KVM_DEV_VFIO_GROUP attributes:
> > > - @groupfd is a file descriptor for a VFIO group;
> > > - @tablefd is a file descriptor for a TCE table allocated via
> > > KVM_CREATE_SPAPR_TCE.
> > > +
> > > +::
> > > +
> > > +The GROUP_ADD operation above should be invoked prior to accessing
> > the
> > > +device file descriptor via VFIO_GROUP_GET_DEVICE_FD in order to
> > support
> > > +drivers which require a kvm pointer to be set in their .open_device()
> > > +callback.
> > > --
> > > 2.34.1
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2] docs: kvm: vfio: Require call KVM_DEV_VFIO_GROUP_ADD before VFIO_GROUP_GET_DEVICE_FD
2023-02-22 2:22 [PATCH v2] docs: kvm: vfio: Require call KVM_DEV_VFIO_GROUP_ADD before VFIO_GROUP_GET_DEVICE_FD Yi Liu
2023-02-22 2:29 ` Tian, Kevin
2023-02-22 2:32 ` Tian, Kevin
@ 2023-04-11 19:28 ` Alex Williamson
2023-04-14 20:08 ` Alex Williamson
2 siblings, 1 reply; 9+ messages in thread
From: Alex Williamson @ 2023-04-11 19:28 UTC (permalink / raw)
To: Yi Liu
Cc: jgg, kevin.tian, cohuck, eric.auger, kvm, mjrosato, chao.p.peng,
yi.y.sun, pbonzini
On Tue, 21 Feb 2023 18:22:31 -0800
Yi Liu <yi.l.liu@intel.com> wrote:
> as some vfio_device drivers require a kvm pointer to be set in their
> open_device and kvm pointer is set to VFIO in GROUP_ADD path.
>
> Signed-off-by: Yi Liu <yi.l.liu@intel.com>
> ---
> v2:
> - Adopt Alex's suggestion
> v1: https://lore.kernel.org/kvm/20230221034114.135386-1-yi.l.liu@intel.com/
> ---
> Documentation/virt/kvm/devices/vfio.rst | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/virt/kvm/devices/vfio.rst b/Documentation/virt/kvm/devices/vfio.rst
> index 2d20dc561069..79b6811bb4f3 100644
> --- a/Documentation/virt/kvm/devices/vfio.rst
> +++ b/Documentation/virt/kvm/devices/vfio.rst
> @@ -39,3 +39,10 @@ KVM_DEV_VFIO_GROUP attributes:
> - @groupfd is a file descriptor for a VFIO group;
> - @tablefd is a file descriptor for a TCE table allocated via
> KVM_CREATE_SPAPR_TCE.
> +
> +::
> +
> +The GROUP_ADD operation above should be invoked prior to accessing the
> +device file descriptor via VFIO_GROUP_GET_DEVICE_FD in order to support
> +drivers which require a kvm pointer to be set in their .open_device()
> +callback.
I updated the title and commit log so as not to further construe that
documentation can impose a requirement, otherwise applied to vfio next
branch for v6.4. Thanks,
Alex
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2] docs: kvm: vfio: Require call KVM_DEV_VFIO_GROUP_ADD before VFIO_GROUP_GET_DEVICE_FD
2023-04-11 19:28 ` Alex Williamson
@ 2023-04-14 20:08 ` Alex Williamson
2023-04-17 13:04 ` Liu, Yi L
0 siblings, 1 reply; 9+ messages in thread
From: Alex Williamson @ 2023-04-14 20:08 UTC (permalink / raw)
To: Yi Liu
Cc: jgg, kevin.tian, cohuck, eric.auger, kvm, mjrosato, chao.p.peng,
yi.y.sun, pbonzini
On Tue, 11 Apr 2023 13:28:03 -0600
Alex Williamson <alex.williamson@redhat.com> wrote:
> On Tue, 21 Feb 2023 18:22:31 -0800
> Yi Liu <yi.l.liu@intel.com> wrote:
>
> > as some vfio_device drivers require a kvm pointer to be set in their
> > open_device and kvm pointer is set to VFIO in GROUP_ADD path.
> >
> > Signed-off-by: Yi Liu <yi.l.liu@intel.com>
> > ---
> > v2:
> > - Adopt Alex's suggestion
> > v1: https://lore.kernel.org/kvm/20230221034114.135386-1-yi.l.liu@intel.com/
> > ---
> > Documentation/virt/kvm/devices/vfio.rst | 7 +++++++
> > 1 file changed, 7 insertions(+)
> >
> > diff --git a/Documentation/virt/kvm/devices/vfio.rst b/Documentation/virt/kvm/devices/vfio.rst
> > index 2d20dc561069..79b6811bb4f3 100644
> > --- a/Documentation/virt/kvm/devices/vfio.rst
> > +++ b/Documentation/virt/kvm/devices/vfio.rst
> > @@ -39,3 +39,10 @@ KVM_DEV_VFIO_GROUP attributes:
> > - @groupfd is a file descriptor for a VFIO group;
> > - @tablefd is a file descriptor for a TCE table allocated via
> > KVM_CREATE_SPAPR_TCE.
> > +
> > +::
> > +
> > +The GROUP_ADD operation above should be invoked prior to accessing the
> > +device file descriptor via VFIO_GROUP_GET_DEVICE_FD in order to support
> > +drivers which require a kvm pointer to be set in their .open_device()
> > +callback.
>
> I updated the title and commit log so as not to further construe that
> documentation can impose a requirement, otherwise applied to vfio next
> branch for v6.4. Thanks,
Dropped
https://lore.kernel.org/all/20230413163336.7ce6ecec.alex.williamson@redhat.com/
Please resubmit, resolving the warning and change the title since a
requirement of some drivers does not equate to a requirement of the
API. Thanks,
Alex
^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [PATCH v2] docs: kvm: vfio: Require call KVM_DEV_VFIO_GROUP_ADD before VFIO_GROUP_GET_DEVICE_FD
2023-04-14 20:08 ` Alex Williamson
@ 2023-04-17 13:04 ` Liu, Yi L
2023-04-17 19:34 ` Alex Williamson
0 siblings, 1 reply; 9+ messages in thread
From: Liu, Yi L @ 2023-04-17 13:04 UTC (permalink / raw)
To: Alex Williamson
Cc: jgg, Tian, Kevin, cohuck, eric.auger, kvm, mjrosato, chao.p.peng,
yi.y.sun
> From: Alex Williamson <alex.williamson@redhat.com>
> Sent: Saturday, April 15, 2023 4:08 AM
> On Tue, 11 Apr 2023 13:28:03 -0600
> Alex Williamson <alex.williamson@redhat.com> wrote:
>
> > On Tue, 21 Feb 2023 18:22:31 -0800
> > Yi Liu <yi.l.liu@intel.com> wrote:
> >
> > > as some vfio_device drivers require a kvm pointer to be set in their
> > > open_device and kvm pointer is set to VFIO in GROUP_ADD path.
> > >
> > > Signed-off-by: Yi Liu <yi.l.liu@intel.com>
> > > ---
> > > v2:
> > > - Adopt Alex's suggestion
> > > v1: https://lore.kernel.org/kvm/20230221034114.135386-1-yi.l.liu@intel.com/
> > > ---
> > > Documentation/virt/kvm/devices/vfio.rst | 7 +++++++
> > > 1 file changed, 7 insertions(+)
> > >
> > > diff --git a/Documentation/virt/kvm/devices/vfio.rst
> b/Documentation/virt/kvm/devices/vfio.rst
> > > index 2d20dc561069..79b6811bb4f3 100644
> > > --- a/Documentation/virt/kvm/devices/vfio.rst
> > > +++ b/Documentation/virt/kvm/devices/vfio.rst
> > > @@ -39,3 +39,10 @@ KVM_DEV_VFIO_GROUP attributes:
> > > - @groupfd is a file descriptor for a VFIO group;
> > > - @tablefd is a file descriptor for a TCE table allocated via
> > > KVM_CREATE_SPAPR_TCE.
> > > +
> > > +::
> > > +
> > > +The GROUP_ADD operation above should be invoked prior to accessing the
> > > +device file descriptor via VFIO_GROUP_GET_DEVICE_FD in order to support
> > > +drivers which require a kvm pointer to be set in their .open_device()
> > > +callback.
> >
> > I updated the title and commit log so as not to further construe that
> > documentation can impose a requirement, otherwise applied to vfio next
> > branch for v6.4. Thanks,
>
> Dropped
>
> https://lore.kernel.org/all/20230413163336.7ce6ecec.alex.williamson@redhat.com/
>
> Please resubmit, resolving the warning and change the title since a
> requirement of some drivers does not equate to a requirement of the
> API. Thanks,
Sorry for it. May just remove the "::". So a version as below. Please let me
know it is ok, then I'll submit it.
From abfc87425aa2977c08511b648a194bcfb072dcb8 Mon Sep 17 00:00:00 2001
From: Yi Liu <yi.l.liu@intel.com>
Date: Thu, 16 Feb 2023 02:37:28 -0800
Subject: [PATCH] docs: kvm: vfio: Suggest KVM_DEV_VFIO_GROUP_ADD vs VFIO_GROUP_GET_DEVICE_FD ordering
as some vfio_device's open_device op requires kvm pointer and kvm pointer
set is part of GROUP_ADD.
Signed-off-by: Yi Liu <yi.l.liu@intel.com>
---
Documentation/virt/kvm/devices/vfio.rst | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/Documentation/virt/kvm/devices/vfio.rst b/Documentation/virt/kvm/devices/vfio.rst
index 2d20dc561069..79b6811bb4f3 100644
--- a/Documentation/virt/kvm/devices/vfio.rst
+++ b/Documentation/virt/kvm/devices/vfio.rst
@@ -39,3 +39,8 @@ KVM_DEV_VFIO_GROUP attributes:
- @groupfd is a file descriptor for a VFIO group;
- @tablefd is a file descriptor for a TCE table allocated via
KVM_CREATE_SPAPR_TCE.
+
+The GROUP_ADD operation above should be invoked prior to accessing the
+device file descriptor via VFIO_GROUP_GET_DEVICE_FD in order to support
+drivers which require a kvm pointer to be set in their .open_device()
+callback.
--
2.34.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v2] docs: kvm: vfio: Require call KVM_DEV_VFIO_GROUP_ADD before VFIO_GROUP_GET_DEVICE_FD
2023-04-17 13:04 ` Liu, Yi L
@ 2023-04-17 19:34 ` Alex Williamson
0 siblings, 0 replies; 9+ messages in thread
From: Alex Williamson @ 2023-04-17 19:34 UTC (permalink / raw)
To: Liu, Yi L
Cc: jgg, Tian, Kevin, cohuck, eric.auger, kvm, mjrosato, chao.p.peng,
yi.y.sun
On Mon, 17 Apr 2023 13:04:50 +0000
"Liu, Yi L" <yi.l.liu@intel.com> wrote:
> > From: Alex Williamson <alex.williamson@redhat.com>
> > Sent: Saturday, April 15, 2023 4:08 AM
> > On Tue, 11 Apr 2023 13:28:03 -0600
> > Alex Williamson <alex.williamson@redhat.com> wrote:
> >
> > > On Tue, 21 Feb 2023 18:22:31 -0800
> > > Yi Liu <yi.l.liu@intel.com> wrote:
> > >
> > > > as some vfio_device drivers require a kvm pointer to be set in their
> > > > open_device and kvm pointer is set to VFIO in GROUP_ADD path.
> > > >
> > > > Signed-off-by: Yi Liu <yi.l.liu@intel.com>
> > > > ---
> > > > v2:
> > > > - Adopt Alex's suggestion
> > > > v1: https://lore.kernel.org/kvm/20230221034114.135386-1-yi.l.liu@intel.com/
> > > > ---
> > > > Documentation/virt/kvm/devices/vfio.rst | 7 +++++++
> > > > 1 file changed, 7 insertions(+)
> > > >
> > > > diff --git a/Documentation/virt/kvm/devices/vfio.rst
> > b/Documentation/virt/kvm/devices/vfio.rst
> > > > index 2d20dc561069..79b6811bb4f3 100644
> > > > --- a/Documentation/virt/kvm/devices/vfio.rst
> > > > +++ b/Documentation/virt/kvm/devices/vfio.rst
> > > > @@ -39,3 +39,10 @@ KVM_DEV_VFIO_GROUP attributes:
> > > > - @groupfd is a file descriptor for a VFIO group;
> > > > - @tablefd is a file descriptor for a TCE table allocated via
> > > > KVM_CREATE_SPAPR_TCE.
> > > > +
> > > > +::
> > > > +
> > > > +The GROUP_ADD operation above should be invoked prior to accessing the
> > > > +device file descriptor via VFIO_GROUP_GET_DEVICE_FD in order to support
> > > > +drivers which require a kvm pointer to be set in their .open_device()
> > > > +callback.
> > >
> > > I updated the title and commit log so as not to further construe that
> > > documentation can impose a requirement, otherwise applied to vfio next
> > > branch for v6.4. Thanks,
> >
> > Dropped
> >
> > https://lore.kernel.org/all/20230413163336.7ce6ecec.alex.williamson@redhat.com/
> >
> > Please resubmit, resolving the warning and change the title since a
> > requirement of some drivers does not equate to a requirement of the
> > API. Thanks,
>
> Sorry for it. May just remove the "::". So a version as below. Please let me
> know it is ok, then I'll submit it.
Sure, so long as the docs build warning is gone. I'll wait for a
separate v3 posting. Thanks,
Alex
> From abfc87425aa2977c08511b648a194bcfb072dcb8 Mon Sep 17 00:00:00 2001
> From: Yi Liu <yi.l.liu@intel.com>
> Date: Thu, 16 Feb 2023 02:37:28 -0800
> Subject: [PATCH] docs: kvm: vfio: Suggest KVM_DEV_VFIO_GROUP_ADD vs VFIO_GROUP_GET_DEVICE_FD ordering
>
> as some vfio_device's open_device op requires kvm pointer and kvm pointer
> set is part of GROUP_ADD.
>
> Signed-off-by: Yi Liu <yi.l.liu@intel.com>
> ---
> Documentation/virt/kvm/devices/vfio.rst | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/virt/kvm/devices/vfio.rst b/Documentation/virt/kvm/devices/vfio.rst
> index 2d20dc561069..79b6811bb4f3 100644
> --- a/Documentation/virt/kvm/devices/vfio.rst
> +++ b/Documentation/virt/kvm/devices/vfio.rst
> @@ -39,3 +39,8 @@ KVM_DEV_VFIO_GROUP attributes:
> - @groupfd is a file descriptor for a VFIO group;
> - @tablefd is a file descriptor for a TCE table allocated via
> KVM_CREATE_SPAPR_TCE.
> +
> +The GROUP_ADD operation above should be invoked prior to accessing the
> +device file descriptor via VFIO_GROUP_GET_DEVICE_FD in order to support
> +drivers which require a kvm pointer to be set in their .open_device()
> +callback.
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2023-04-17 19:35 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-22 2:22 [PATCH v2] docs: kvm: vfio: Require call KVM_DEV_VFIO_GROUP_ADD before VFIO_GROUP_GET_DEVICE_FD Yi Liu
2023-02-22 2:29 ` Tian, Kevin
2023-02-22 2:32 ` Tian, Kevin
2023-03-25 12:37 ` Liu, Yi L
2023-03-27 16:20 ` Alex Williamson
2023-04-11 19:28 ` Alex Williamson
2023-04-14 20:08 ` Alex Williamson
2023-04-17 13:04 ` Liu, Yi L
2023-04-17 19:34 ` Alex Williamson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.