From: Andrew Halaney <ahalaney@redhat.com>
To: Krishna Kurapati <quic_kriskura@quicinc.com>
Cc: Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
quic_pkondeti@quicinc.com, quic_ppratap@quicinc.com,
quic_wcheng@quicinc.com, quic_jackp@quicinc.com,
quic_harshq@quicinc.com, quic_shazhuss@quicinc.com
Subject: Re: [PATCH v6 8/8] arm64: dts: qcom: sa8540-ride: Enable first port of tertiary usb controller
Date: Fri, 14 Apr 2023 10:51:59 -0500 [thread overview]
Message-ID: <20230414155159.zmhkeoxwhxe5czm5@halaney-x13s> (raw)
In-Reply-To: <20230405125759.4201-9-quic_kriskura@quicinc.com>
On Wed, Apr 05, 2023 at 06:27:59PM +0530, Krishna Kurapati wrote:
> Enable first port of Quad port Tertiary USB controller for SA8540 Ride.
>
> Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com>
This is nitpicky, but I liked some of the description in the first[0]
version of this patch that I authored for you:
From dcb27d07f079194ebd7efe1c9bec64da78beb290 Mon Sep 17 00:00:00 2001
From: Andrew Halaney <ahalaney@redhat.com>
Date: Thu, 19 Jan 2023 14:53:38 -0600
Subject: [PATCH] arm64: dts: qcom: sa8540p-ride: Enable usb_2
Content-type: text/plain
There is now support for the multiport USB controller this uses
so enable it.
The board only has a single port hooked up (despite it being wired up to
the multiport IP on the SoC). There's also a USB 2.0 mux hooked up,
which by default on boot is selected to mux properly. Grab the gpio
controlling that and ensure it stays in the right position so USB 2.0
continues to be routed from the external port to the SoC.
Signed-off-by: Andrew Halaney <ahalaney@redhat.com>
Specifically the bit helping explain what the mux, its default state,
etc are things I find explain some of the hardware/patch better. Personal
opinion of course but I'll highlight it since you dropped it out :)
[0] https://lore.kernel.org/linux-arm-msm/20230119220942.ja5gbo3t3fl63gpy@halaney-x13s/
Either way, thanks for taking the patch along and working on this.
Thanks,
Andrew
next prev parent reply other threads:[~2023-04-14 15:53 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-05 12:57 [PATCH v6 0/8] Add multiport support for DWC3 controllers Krishna Kurapati
2023-04-05 12:57 ` [PATCH v6 1/8] dt-bindings: usb: Add bindings for multiport properties on DWC3 controller Krishna Kurapati
2023-04-05 14:01 ` Krzysztof Kozlowski
2023-04-05 14:15 ` Krishna Kurapati PSSNV
2023-04-05 14:18 ` Krzysztof Kozlowski
2023-04-05 20:17 ` Rob Herring
2023-04-06 14:07 ` Krishna Kurapati PSSNV
2023-04-05 16:48 ` Rob Herring
2023-04-05 12:57 ` [PATCH v6 2/8] usb: dwc3: core: Access XHCI address space temporarily to read port info Krishna Kurapati
2023-04-05 23:14 ` kernel test robot
2023-04-08 1:38 ` Thinh Nguyen
2023-04-05 12:57 ` [PATCH v6 3/8] usb: dwc3: core: Skip setting event buffers for host only controllers Krishna Kurapati
2023-04-05 12:57 ` [PATCH v6 4/8] usb: dwc3: core: Refactor PHY logic to support Multiport Controller Krishna Kurapati
2023-04-05 12:57 ` [PATCH v6 5/8] usb: dwc3: qcom: Add multiport controller support for qcom wrapper Krishna Kurapati
2023-04-05 12:57 ` [PATCH v6 6/8] arm64: dts: qcom: sc8280xp: Add multiport controller node for SC8280 Krishna Kurapati
2023-04-14 15:45 ` Andrew Halaney
2023-04-15 19:04 ` Krishna Kurapati PSSNV
2023-04-22 16:08 ` Krishna Kurapati PSSNV
2023-04-25 20:33 ` Andrew Halaney
2023-05-05 7:55 ` Johan Hovold
2023-04-05 12:57 ` [PATCH v6 7/8] arm64: dts: qcom: sa8295p: Enable tertiary controller and its 4 USB ports Krishna Kurapati
2023-04-05 12:57 ` [PATCH v6 8/8] arm64: dts: qcom: sa8540-ride: Enable first port of tertiary usb controller Krishna Kurapati
2023-04-14 15:51 ` Andrew Halaney [this message]
2023-04-15 19:09 ` Krishna Kurapati PSSNV
2023-04-08 1:42 ` [PATCH v6 0/8] Add multiport support for DWC3 controllers Thinh Nguyen
2023-04-08 11:36 ` Krzysztof Kozlowski
2023-04-08 23:09 ` Thinh Nguyen
2023-04-10 15:24 ` Krzysztof Kozlowski
2023-04-13 18:54 ` Adrien Thierry
2023-04-14 4:41 ` Krishna Kurapati PSSNV
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230414155159.zmhkeoxwhxe5czm5@halaney-x13s \
--to=ahalaney@redhat.com \
--cc=Thinh.Nguyen@synopsys.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=quic_harshq@quicinc.com \
--cc=quic_jackp@quicinc.com \
--cc=quic_kriskura@quicinc.com \
--cc=quic_pkondeti@quicinc.com \
--cc=quic_ppratap@quicinc.com \
--cc=quic_shazhuss@quicinc.com \
--cc=quic_wcheng@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.