Re: [PATCH v6 8/8] arm64: dts: qcom: sa8540-ride: Enable first port of tertiary usb controller

From: Krishna Kurapati PSSNV <quic_kriskura@quicinc.com>
To: Andrew Halaney <ahalaney@redhat.com>
Cc: Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	"Andy Gross" <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	"Konrad Dybcio" <konrad.dybcio@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	<linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<quic_pkondeti@quicinc.com>, <quic_ppratap@quicinc.com>,
	<quic_wcheng@quicinc.com>, <quic_jackp@quicinc.com>,
	<quic_harshq@quicinc.com>, <quic_shazhuss@quicinc.com>
Subject: Re: [PATCH v6 8/8] arm64: dts: qcom: sa8540-ride: Enable first port of tertiary usb controller
Date: Sun, 16 Apr 2023 00:39:29 +0530	[thread overview]
Message-ID: <f979b4c2-c0e8-6b43-796b-10c21ae4df75@quicinc.com> (raw)
In-Reply-To: <20230414155159.zmhkeoxwhxe5czm5@halaney-x13s>

On 4/14/2023 9:21 PM, Andrew Halaney wrote:
> On Wed, Apr 05, 2023 at 06:27:59PM +0530, Krishna Kurapati wrote:
>> Enable first port of Quad port Tertiary USB controller for SA8540 Ride.
>>
>> Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com>
> 
> This is nitpicky, but I liked some of the description in the first[0]
> version of this patch that I authored for you:
> 
>      From dcb27d07f079194ebd7efe1c9bec64da78beb290 Mon Sep 17 00:00:00 2001
>      From: Andrew Halaney <ahalaney@redhat.com>
>      Date: Thu, 19 Jan 2023 14:53:38 -0600
>      Subject: [PATCH] arm64: dts: qcom: sa8540p-ride: Enable usb_2
>      Content-type: text/plain
> 
>      There is now support for the multiport USB controller this uses
>      so enable it.
> 
>      The board only has a single port hooked up (despite it being wired up to
>      the multiport IP on the SoC). There's also a USB 2.0 mux hooked up,
>      which by default on boot is selected to mux properly. Grab the gpio
>      controlling that and ensure it stays in the right position so USB 2.0
>      continues to be routed from the external port to the SoC.
> 
>      Signed-off-by: Andrew Halaney <ahalaney@redhat.com>
> 
> Specifically the bit helping explain what the mux, its default state,
> etc are things I find explain some of the hardware/patch better. Personal
> opinion of course but I'll highlight it since you dropped it out :)
> 
> [0] https://lore.kernel.org/linux-arm-msm/20230119220942.ja5gbo3t3fl63gpy@halaney-x13s/
> 
> Either way, thanks for taking the patch along and working on this.
> 
> Thanks,
> Andrew
> 

Hi Andrew, Sorry for that. Will make sure to update the commit text with 
this info in the next version.

Regards,
Krishna,