From: Jakub Kicinski <kuba@kernel.org>
To: Sasha Levin <sashal@kernel.org>
Cc: "Samudrala, Sridhar" <sridhar.samudrala@intel.com>,
Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
Pavan Kumar Linga <pavan.kumar.linga@intel.com>,
willemb@google.com, decot@google.com, netdev@vger.kernel.org,
jesse.brandeburg@intel.com, edumazet@google.com,
intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,
pabeni@redhat.com, davem@davemloft.net
Subject: Re: [Intel-wired-lan] [PATCH net-next v2 00/15] Introduce Intel IDPF driver
Date: Mon, 17 Apr 2023 09:38:32 -0700 [thread overview]
Message-ID: <20230417093832.686d0799@kernel.org> (raw)
In-Reply-To: <ZDrb58HEqLvG6ZoQ@sashalap>
On Sat, 15 Apr 2023 13:16:23 -0400 Sasha Levin wrote:
> Sorry, I may not have explained myself well. My concern is not around
> what's standard and what's not, nor around where in the kernel tree
> these drivers live.
My bad, I thought you were looking at this from the stable tree's angle.
> I'm concerned that down the road we may end up with two drivers that
> have the same name, and are working with hardware so similar that it
> might be confusing to understand which driver a user should be using.
>
> Yes, it's not something too big, but we have an opportunity to think
> about this before committing to anything that might be a pain down the
> road.
Indeed, the "update" Willem mentioned should be at most a quirk or
capability exchange with the device within this driver. Two drivers
would be unacceptable.
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Sasha Levin <sashal@kernel.org>
Cc: Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
pabeni@redhat.com, willemb@google.com,
jesse.brandeburg@intel.com, edumazet@google.com,
intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
anthony.l.nguyen@intel.com, decot@google.com,
davem@davemloft.net
Subject: Re: [Intel-wired-lan] [PATCH net-next v2 00/15] Introduce Intel IDPF driver
Date: Mon, 17 Apr 2023 09:38:32 -0700 [thread overview]
Message-ID: <20230417093832.686d0799@kernel.org> (raw)
In-Reply-To: <ZDrb58HEqLvG6ZoQ@sashalap>
On Sat, 15 Apr 2023 13:16:23 -0400 Sasha Levin wrote:
> Sorry, I may not have explained myself well. My concern is not around
> what's standard and what's not, nor around where in the kernel tree
> these drivers live.
My bad, I thought you were looking at this from the stable tree's angle.
> I'm concerned that down the road we may end up with two drivers that
> have the same name, and are working with hardware so similar that it
> might be confusing to understand which driver a user should be using.
>
> Yes, it's not something too big, but we have an opportunity to think
> about this before committing to anything that might be a pain down the
> road.
Indeed, the "update" Willem mentioned should be at most a quirk or
capability exchange with the device within this driver. Two drivers
would be unacceptable.
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
next prev parent reply other threads:[~2023-04-17 16:38 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-11 1:13 [PATCH net-next v2 00/15] Introduce Intel IDPF driver Pavan Kumar Linga
2023-04-11 1:13 ` [Intel-wired-lan] " Pavan Kumar Linga
2023-04-11 1:13 ` [PATCH net-next v2 01/15] virtchnl: add virtchnl version 2 ops Pavan Kumar Linga
2023-04-11 1:13 ` [Intel-wired-lan] " Pavan Kumar Linga
2023-04-11 8:51 ` Simon Horman
2023-04-11 8:51 ` [Intel-wired-lan] " Simon Horman
2023-04-12 21:38 ` Tantilov, Emil S
2023-04-12 21:38 ` [Intel-wired-lan] " Tantilov, Emil S
2023-04-11 1:13 ` [PATCH net-next v2 02/15] idpf: add module register and probe functionality Pavan Kumar Linga
2023-04-11 1:13 ` [Intel-wired-lan] " Pavan Kumar Linga
2023-04-11 12:36 ` Leon Romanovsky
2023-04-11 12:36 ` [Intel-wired-lan] " Leon Romanovsky
2023-04-12 23:10 ` Tantilov, Emil S
2023-04-12 23:10 ` [Intel-wired-lan] " Tantilov, Emil S
2023-04-13 6:03 ` Leon Romanovsky
2023-04-13 6:03 ` [Intel-wired-lan] " Leon Romanovsky
2023-04-13 18:58 ` Tantilov, Emil S
2023-04-13 18:58 ` [Intel-wired-lan] " Tantilov, Emil S
2023-04-20 18:13 ` Tantilov, Emil S
2023-04-20 18:13 ` Tantilov, Emil S
2023-04-20 18:20 ` Leon Romanovsky
2023-04-20 18:20 ` Leon Romanovsky
2023-04-11 1:13 ` [PATCH net-next v2 03/15] idpf: add controlq init and reset checks Pavan Kumar Linga
2023-04-11 1:13 ` [Intel-wired-lan] " Pavan Kumar Linga
2023-04-11 9:19 ` Simon Horman
2023-04-11 9:19 ` [Intel-wired-lan] " Simon Horman
2023-04-11 1:13 ` [PATCH net-next v2 04/15] idpf: add core init and interrupt request Pavan Kumar Linga
2023-04-11 1:13 ` [Intel-wired-lan] " Pavan Kumar Linga
2023-04-11 9:52 ` Simon Horman
2023-04-11 9:52 ` [Intel-wired-lan] " Simon Horman
2023-04-13 19:10 ` Tantilov, Emil S
2023-04-13 19:10 ` [Intel-wired-lan] " Tantilov, Emil S
2023-04-11 1:13 ` [PATCH net-next v2 05/15] idpf: add create vport and netdev configuration Pavan Kumar Linga
2023-04-11 1:13 ` [Intel-wired-lan] " Pavan Kumar Linga
2023-04-11 1:13 ` [Intel-wired-lan] [PATCH net-next v2 06/15] idpf: continue expanding init task Pavan Kumar Linga
2023-04-11 1:13 ` Pavan Kumar Linga
2023-04-11 9:04 ` [Intel-wired-lan] " Simon Horman
2023-04-11 9:04 ` Simon Horman
2023-04-13 19:04 ` Tantilov, Emil S
2023-04-13 19:04 ` [Intel-wired-lan] " Tantilov, Emil S
2023-04-11 1:13 ` [PATCH net-next v2 07/15] idpf: configure resources for TX queues Pavan Kumar Linga
2023-04-11 1:13 ` [Intel-wired-lan] " Pavan Kumar Linga
2023-04-11 1:13 ` [Intel-wired-lan] [PATCH net-next v2 08/15] idpf: configure resources for RX queues Pavan Kumar Linga
2023-04-11 1:13 ` Pavan Kumar Linga
2023-04-11 1:13 ` [Intel-wired-lan] [PATCH net-next v2 09/15] idpf: initialize interrupts and enable vport Pavan Kumar Linga
2023-04-11 1:13 ` Pavan Kumar Linga
2023-04-11 1:13 ` [Intel-wired-lan] [PATCH net-next v2 10/15] idpf: add splitq start_xmit Pavan Kumar Linga
2023-04-11 1:13 ` Pavan Kumar Linga
2023-04-11 1:13 ` [PATCH net-next v2 11/15] idpf: add TX splitq napi poll support Pavan Kumar Linga
2023-04-11 1:13 ` [Intel-wired-lan] " Pavan Kumar Linga
2023-04-11 1:13 ` [Intel-wired-lan] [PATCH net-next v2 12/15] idpf: add RX " Pavan Kumar Linga
2023-04-11 1:13 ` Pavan Kumar Linga
2023-04-11 1:13 ` [Intel-wired-lan] [PATCH net-next v2 13/15] idpf: add singleq start_xmit and napi poll Pavan Kumar Linga
2023-04-11 1:13 ` Pavan Kumar Linga
2023-04-11 1:13 ` [Intel-wired-lan] [PATCH net-next v2 14/15] idpf: add ethtool callbacks Pavan Kumar Linga
2023-04-11 1:13 ` Pavan Kumar Linga
2023-04-11 9:55 ` Simon Horman
2023-04-11 9:55 ` [Intel-wired-lan] " Simon Horman
2023-04-13 19:11 ` Tantilov, Emil S
2023-04-13 19:11 ` [Intel-wired-lan] " Tantilov, Emil S
2023-04-22 5:26 ` Tantilov, Emil S
2023-04-22 5:26 ` Tantilov, Emil S
2023-04-22 7:55 ` Simon Horman
2023-04-22 7:55 ` Simon Horman
2023-04-11 1:13 ` [Intel-wired-lan] [PATCH net-next v2 15/15] idpf: configure SRIOV and add other ndo_ops Pavan Kumar Linga
2023-04-11 1:13 ` Pavan Kumar Linga
2023-04-12 18:25 ` [Intel-wired-lan] [PATCH net-next v2 00/15] Introduce Intel IDPF driver Sasha Levin
2023-04-12 18:25 ` Sasha Levin
2023-04-12 19:16 ` Willem de Bruijn
2023-04-12 19:16 ` Willem de Bruijn
2023-04-13 0:03 ` Samudrala, Sridhar
2023-04-13 0:03 ` Samudrala, Sridhar
2023-04-13 2:24 ` Jakub Kicinski
2023-04-13 2:24 ` Jakub Kicinski
2023-04-13 7:15 ` Leon Romanovsky
2023-04-13 7:15 ` Leon Romanovsky
2023-04-14 22:01 ` Sasha Levin
2023-04-14 22:01 ` Sasha Levin
2023-04-14 22:27 ` Jakub Kicinski
2023-04-14 22:27 ` Jakub Kicinski
2023-04-15 17:16 ` Sasha Levin
2023-04-15 17:16 ` Sasha Levin
2023-04-17 16:38 ` Jakub Kicinski [this message]
2023-04-17 16:38 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230417093832.686d0799@kernel.org \
--to=kuba@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=decot@google.com \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pavan.kumar.linga@intel.com \
--cc=sashal@kernel.org \
--cc=sridhar.samudrala@intel.com \
--cc=willemb@google.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.