* [bvanassche:retain-zoned-write-order 15/15] block/mq-deadline.c:189:24: error: 'struct gendisk' has no member named 'max_active_zones'
@ 2023-04-18 10:56 kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2023-04-18 10:56 UTC (permalink / raw)
To: Bart Van Assche; +Cc: oe-kbuild-all
tree: https://github.com/bvanassche/linux retain-zoned-write-order
head: 2bdceaa60eb460189b66d717bce55dc354512fe8
commit: 2bdceaa60eb460189b66d717bce55dc354512fe8 [15/15] block: mq-deadline: Respect the active zone limit
config: csky-defconfig (https://download.01.org/0day-ci/archive/20230418/202304181837.VCTT4sYB-lkp@intel.com/config)
compiler: csky-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/bvanassche/linux/commit/2bdceaa60eb460189b66d717bce55dc354512fe8
git remote add bvanassche https://github.com/bvanassche/linux
git fetch --no-tags bvanassche retain-zoned-write-order
git checkout 2bdceaa60eb460189b66d717bce55dc354512fe8
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=csky olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=csky SHELL=/bin/bash
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202304181837.VCTT4sYB-lkp@intel.com/
All errors (new ones prefixed by >>):
block/mq-deadline.c: In function 'dd_check_zone':
>> block/mq-deadline.c:189:24: error: 'struct gendisk' has no member named 'max_active_zones'
189 | if (rq->q->disk->max_active_zones == 0)
| ^~
block/mq-deadline.c:206:49: error: 'struct gendisk' has no member named 'max_active_zones'
206 | return dd_active_zones(dd) < rq->q->disk->max_active_zones;
| ^~
In file included from include/linux/printk.h:10,
from include/linux/kernel.h:29,
from block/mq-deadline.c:8:
block/mq-deadline.c: In function 'dd_update_wp':
block/mq-deadline.c:216:37: error: 'struct gendisk' has no member named 'max_active_zones'
216 | if (WARN_ON_ONCE(rq->q->disk->max_active_zones == 0))
| ^~
include/linux/once_lite.h:28:41: note: in definition of macro 'DO_ONCE_LITE_IF'
28 | bool __ret_do_once = !!(condition); \
| ^~~~~~~~~
block/mq-deadline.c:216:13: note: in expansion of macro 'WARN_ON_ONCE'
216 | if (WARN_ON_ONCE(rq->q->disk->max_active_zones == 0))
| ^~~~~~~~~~~~
block/mq-deadline.c: In function 'dd_dispatch_request':
block/mq-deadline.c:762:30: error: 'struct gendisk' has no member named 'max_active_zones'
762 | if (rq && rq->q->disk->max_active_zones)
| ^~
block/mq-deadline.c: In function 'dd_finish_request':
block/mq-deadline.c:1080:24: error: 'struct gendisk' has no member named 'max_active_zones'
1080 | if (rq->q->disk->max_active_zones) {
| ^~
block/mq-deadline.c: In function 'dd_check_zone':
block/mq-deadline.c:207:1: error: control reaches end of non-void function [-Werror=return-type]
207 | }
| ^
block/mq-deadline.c: At top level:
block/mq-deadline.c:461:24: warning: 'deadline_skip_seq_writes' defined but not used [-Wunused-function]
461 | static struct request *deadline_skip_seq_writes(struct deadline_data *dd,
| ^~~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +189 block/mq-deadline.c
177
178 /*
179 * Returns true if and only if dispatching request @rq won't cause the active
180 * zones limit to be exceeded.
181 */
182 static bool dd_check_zone(struct deadline_data *dd, struct request *rq)
183 {
184 unsigned int zno = blk_rq_zone_no(rq);
185 struct dd_zone *zone;
186
187 lockdep_assert_held(&dd->lock);
188
> 189 if (rq->q->disk->max_active_zones == 0)
190 return true;
191
192 switch (req_op(rq)) {
193 case REQ_OP_WRITE:
194 case REQ_OP_WRITE_ZEROES:
195 case REQ_OP_ZONE_APPEND:
196 break;
197 default:
198 return true;
199 }
200
201 hash_for_each_possible(dd->active_zones, zone, entry, zno)
202 if (zone->zno == zno)
203 return true; /* zone already open */
204
205 /* zone is empty or closed */
206 return dd_active_zones(dd) < rq->q->disk->max_active_zones;
207 }
208
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-04-18 10:57 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-18 10:56 [bvanassche:retain-zoned-write-order 15/15] block/mq-deadline.c:189:24: error: 'struct gendisk' has no member named 'max_active_zones' kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.