From: Rob Herring <robh@kernel.org> To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Cc: Neil Armstrong <neil.armstrong@linaro.org>, Sam Ravnborg <sam@ravnborg.org>, David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Thierry Reding <thierry.reding@gmail.com>, Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio <konrad.dybcio@linaro.org> Subject: Re: [PATCH] dt-bindings: display: panel: add common definition of ports Date: Tue, 18 Apr 2023 17:26:13 -0500 [thread overview] Message-ID: <20230418222613.GA2408838-robh@kernel.org> (raw) In-Reply-To: <20230416153929.356330-1-krzysztof.kozlowski@linaro.org> On Sun, Apr 16, 2023 at 05:39:29PM +0200, Krzysztof Kozlowski wrote: > Few panel bindings for dual-link connections just type "ports: true", > which does not enforce any type. Add common definition of ports, so the > type will be fixed. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- > > Cc: Konrad Dybcio <konrad.dybcio@linaro.org> > --- > .../bindings/display/panel/panel-common.yaml | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/panel/panel-common.yaml b/Documentation/devicetree/bindings/display/panel/panel-common.yaml > index 5b38dc89cb21..ad62d34e6fa3 100644 > --- a/Documentation/devicetree/bindings/display/panel/panel-common.yaml > +++ b/Documentation/devicetree/bindings/display/panel/panel-common.yaml > @@ -70,6 +70,16 @@ properties: > port: > $ref: /schemas/graph.yaml#/properties/port > > + # For dual-link connections > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + patternProperties: > + "^port@[0-9a-f]+$": > + $ref: /schemas/graph.yaml#/$defs/port-base This allows any undocumented property. > + > + required: > + - port@0 > + I don't think this should be added here because users must define what each port is. With it here, we're going to validate the nodes twice as well. Same can be said for 'port' though. It can't be extended though. I originally wanted to a do a meta-schema to enforce some of this, but there's just too many exceptions. Rob
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org> To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Cc: Neil Armstrong <neil.armstrong@linaro.org>, Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>, devicetree@vger.kernel.org, Sam Ravnborg <sam@ravnborg.org>, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Konrad Dybcio <konrad.dybcio@linaro.org>, Thierry Reding <thierry.reding@gmail.com>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> Subject: Re: [PATCH] dt-bindings: display: panel: add common definition of ports Date: Tue, 18 Apr 2023 17:26:13 -0500 [thread overview] Message-ID: <20230418222613.GA2408838-robh@kernel.org> (raw) In-Reply-To: <20230416153929.356330-1-krzysztof.kozlowski@linaro.org> On Sun, Apr 16, 2023 at 05:39:29PM +0200, Krzysztof Kozlowski wrote: > Few panel bindings for dual-link connections just type "ports: true", > which does not enforce any type. Add common definition of ports, so the > type will be fixed. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- > > Cc: Konrad Dybcio <konrad.dybcio@linaro.org> > --- > .../bindings/display/panel/panel-common.yaml | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/panel/panel-common.yaml b/Documentation/devicetree/bindings/display/panel/panel-common.yaml > index 5b38dc89cb21..ad62d34e6fa3 100644 > --- a/Documentation/devicetree/bindings/display/panel/panel-common.yaml > +++ b/Documentation/devicetree/bindings/display/panel/panel-common.yaml > @@ -70,6 +70,16 @@ properties: > port: > $ref: /schemas/graph.yaml#/properties/port > > + # For dual-link connections > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + patternProperties: > + "^port@[0-9a-f]+$": > + $ref: /schemas/graph.yaml#/$defs/port-base This allows any undocumented property. > + > + required: > + - port@0 > + I don't think this should be added here because users must define what each port is. With it here, we're going to validate the nodes twice as well. Same can be said for 'port' though. It can't be extended though. I originally wanted to a do a meta-schema to enforce some of this, but there's just too many exceptions. Rob
next prev parent reply other threads:[~2023-04-18 22:26 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-04-16 15:39 [PATCH] dt-bindings: display: panel: add common definition of ports Krzysztof Kozlowski 2023-04-16 15:39 ` Krzysztof Kozlowski 2023-04-17 7:20 ` Konrad Dybcio 2023-04-17 7:24 ` Neil Armstrong 2023-04-18 22:26 ` Rob Herring [this message] 2023-04-18 22:26 ` Rob Herring 2023-04-19 8:56 ` Krzysztof Kozlowski 2023-04-19 8:56 ` Krzysztof Kozlowski 2023-04-20 16:09 ` Rob Herring 2023-04-20 16:09 ` Rob Herring
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230418222613.GA2408838-robh@kernel.org \ --to=robh@kernel.org \ --cc=airlied@gmail.com \ --cc=daniel@ffwll.ch \ --cc=devicetree@vger.kernel.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=konrad.dybcio@linaro.org \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=krzysztof.kozlowski@linaro.org \ --cc=laurent.pinchart+renesas@ideasonboard.com \ --cc=linux-kernel@vger.kernel.org \ --cc=neil.armstrong@linaro.org \ --cc=sam@ravnborg.org \ --cc=thierry.reding@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.