From: Xuan Zhuo <xuanzhuo@linux.alibaba.com> To: virtualization@lists.linux-foundation.org Cc: Xuan Zhuo <xuanzhuo@linux.alibaba.com>, Jesper Dangaard Brouer <hawk@kernel.org>, Daniel Borkmann <daniel@iogearbox.net>, "Michael S. Tsirkin" <mst@redhat.com>, netdev@vger.kernel.org, John Fastabend <john.fastabend@gmail.com>, Alexei Starovoitov <ast@kernel.org>, Christoph Hellwig <hch@infradead.org>, Alexander Lobakin <aleksander.lobakin@intel.com>, Jakub Kicinski <kuba@kernel.org>, bpf@vger.kernel.org, "David S. Miller" <davem@davemloft.net> Subject: [PATCH vhost v7 00/11] virtio core prepares for AF_XDP Date: Tue, 25 Apr 2023 15:36:02 +0800 [thread overview] Message-ID: <20230425073613.8839-1-xuanzhuo@linux.alibaba.com> (raw) ## About DMA APIs Now, virtio may can not work with DMA APIs when virtio features do not have VIRTIO_F_ACCESS_PLATFORM. 1. I tried to let DMA APIs return phy address by virtio-device. But DMA APIs just work with the "real" devices. 2. I tried to let xsk support callballs to get phy address from virtio-net driver as the dma address. But the maintainers of xsk may want to use dma-buf to replace the DMA APIs. I think that may be a larger effort. We will wait too long. So rethinking this, firstly, we can support premapped-dma only for devices with VIRTIO_F_ACCESS_PLATFORM. In the case of af-xdp, if the users want to use it, they have to update the device to support VIRTIO_F_RING_RESET, and they can also enable the device's VIRTIO_F_ACCESS_PLATFORM feature by the way. Thanks for the help from Christoph. ================= XDP socket(AF_XDP) is an excellent bypass kernel network framework. The zero copy feature of xsk (XDP socket) needs to be supported by the driver. The performance of zero copy is very good. ENV: Qemu with vhost. vhost cpu | Guest APP CPU |Guest Softirq CPU | PPS -----------------------------|---------------|------------------|------------ xmit by sockperf: 90% | 100% | | 318967 xmit by xsk: 100% | 30% | 33% | 1192064 recv by sockperf: 100% | 68% | 100% | 692288 recv by xsk: 100% | 33% | 43% | 771670 Before achieving the function of Virtio-Net, we also have to let virtio core support these features: 1. virtio core support premapped 2. virtio core support reset per-queue 3. introduce DMA APIs to virtio core Please review. Thanks. v7: 1. virtqueue_dma_dev() return NULL when virtio is without DMA API. v6: 1. change the size of the flags to u32. v5: 1. fix for error handler 2. add flags to record internal dma mapping v4: 1. rename map_inter to dma_map_internal 2. fix: Excess function parameter 'vq' description in 'virtqueue_dma_dev' v3: 1. add map_inter to struct desc state to reocrd whether virtio core do dma map v2: 1. based on sgs[0]->dma_address to judgment is premapped 2. based on extra.addr to judgment to do unmap for no-indirect desc 3. based on indir_desc to judgment to do unmap for indirect desc 4. rename virtqueue_get_dma_dev to virtqueue_dma_dev v1: 1. expose dma device. NO introduce the api for dma and sync 2. split some commit for review. Xuan Zhuo (11): virtio_ring: split: separate dma codes virtio_ring: packed: separate dma codes virtio_ring: packed-indirect: separate dma codes virtio_ring: split: support premapped virtio_ring: packed: support premapped virtio_ring: packed-indirect: support premapped virtio_ring: update document for virtqueue_add_* virtio_ring: introduce virtqueue_dma_dev() virtio_ring: correct the expression of the description of virtqueue_resize() virtio_ring: separate the logic of reset/enable from virtqueue_resize virtio_ring: introduce virtqueue_reset() drivers/virtio/virtio_ring.c | 352 +++++++++++++++++++++++++---------- include/linux/virtio.h | 4 + 2 files changed, 259 insertions(+), 97 deletions(-) -- 2.32.0.3.g01195cf9f _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
WARNING: multiple messages have this Message-ID (diff)
From: Xuan Zhuo <xuanzhuo@linux.alibaba.com> To: virtualization@lists.linux-foundation.org Cc: "Michael S. Tsirkin" <mst@redhat.com>, Jason Wang <jasowang@redhat.com>, Xuan Zhuo <xuanzhuo@linux.alibaba.com>, Alexei Starovoitov <ast@kernel.org>, Daniel Borkmann <daniel@iogearbox.net>, "David S. Miller" <davem@davemloft.net>, Jesper Dangaard Brouer <hawk@kernel.org>, John Fastabend <john.fastabend@gmail.com>, netdev@vger.kernel.org, bpf@vger.kernel.org, Christoph Hellwig <hch@infradead.org>, Jakub Kicinski <kuba@kernel.org>, Alexander Lobakin <aleksander.lobakin@intel.com> Subject: [PATCH vhost v7 00/11] virtio core prepares for AF_XDP Date: Tue, 25 Apr 2023 15:36:02 +0800 [thread overview] Message-ID: <20230425073613.8839-1-xuanzhuo@linux.alibaba.com> (raw) ## About DMA APIs Now, virtio may can not work with DMA APIs when virtio features do not have VIRTIO_F_ACCESS_PLATFORM. 1. I tried to let DMA APIs return phy address by virtio-device. But DMA APIs just work with the "real" devices. 2. I tried to let xsk support callballs to get phy address from virtio-net driver as the dma address. But the maintainers of xsk may want to use dma-buf to replace the DMA APIs. I think that may be a larger effort. We will wait too long. So rethinking this, firstly, we can support premapped-dma only for devices with VIRTIO_F_ACCESS_PLATFORM. In the case of af-xdp, if the users want to use it, they have to update the device to support VIRTIO_F_RING_RESET, and they can also enable the device's VIRTIO_F_ACCESS_PLATFORM feature by the way. Thanks for the help from Christoph. ================= XDP socket(AF_XDP) is an excellent bypass kernel network framework. The zero copy feature of xsk (XDP socket) needs to be supported by the driver. The performance of zero copy is very good. ENV: Qemu with vhost. vhost cpu | Guest APP CPU |Guest Softirq CPU | PPS -----------------------------|---------------|------------------|------------ xmit by sockperf: 90% | 100% | | 318967 xmit by xsk: 100% | 30% | 33% | 1192064 recv by sockperf: 100% | 68% | 100% | 692288 recv by xsk: 100% | 33% | 43% | 771670 Before achieving the function of Virtio-Net, we also have to let virtio core support these features: 1. virtio core support premapped 2. virtio core support reset per-queue 3. introduce DMA APIs to virtio core Please review. Thanks. v7: 1. virtqueue_dma_dev() return NULL when virtio is without DMA API. v6: 1. change the size of the flags to u32. v5: 1. fix for error handler 2. add flags to record internal dma mapping v4: 1. rename map_inter to dma_map_internal 2. fix: Excess function parameter 'vq' description in 'virtqueue_dma_dev' v3: 1. add map_inter to struct desc state to reocrd whether virtio core do dma map v2: 1. based on sgs[0]->dma_address to judgment is premapped 2. based on extra.addr to judgment to do unmap for no-indirect desc 3. based on indir_desc to judgment to do unmap for indirect desc 4. rename virtqueue_get_dma_dev to virtqueue_dma_dev v1: 1. expose dma device. NO introduce the api for dma and sync 2. split some commit for review. Xuan Zhuo (11): virtio_ring: split: separate dma codes virtio_ring: packed: separate dma codes virtio_ring: packed-indirect: separate dma codes virtio_ring: split: support premapped virtio_ring: packed: support premapped virtio_ring: packed-indirect: support premapped virtio_ring: update document for virtqueue_add_* virtio_ring: introduce virtqueue_dma_dev() virtio_ring: correct the expression of the description of virtqueue_resize() virtio_ring: separate the logic of reset/enable from virtqueue_resize virtio_ring: introduce virtqueue_reset() drivers/virtio/virtio_ring.c | 352 +++++++++++++++++++++++++---------- include/linux/virtio.h | 4 + 2 files changed, 259 insertions(+), 97 deletions(-) -- 2.32.0.3.g01195cf9f
next reply other threads:[~2023-04-25 7:36 UTC|newest] Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-04-25 7:36 Xuan Zhuo [this message] 2023-04-25 7:36 ` [PATCH vhost v7 00/11] virtio core prepares for AF_XDP Xuan Zhuo 2023-04-25 7:36 ` [PATCH vhost v7 01/11] virtio_ring: split: separate dma codes Xuan Zhuo 2023-04-25 7:36 ` Xuan Zhuo 2023-05-01 4:24 ` Christoph Hellwig 2023-05-01 4:24 ` Christoph Hellwig 2023-05-06 3:08 ` Xuan Zhuo 2023-05-06 3:08 ` Xuan Zhuo 2023-04-25 7:36 ` [PATCH vhost v7 02/11] virtio_ring: packed: " Xuan Zhuo 2023-04-25 7:36 ` Xuan Zhuo 2023-04-25 7:36 ` [PATCH vhost v7 03/11] virtio_ring: packed-indirect: " Xuan Zhuo 2023-04-25 7:36 ` Xuan Zhuo 2023-04-25 7:36 ` [PATCH vhost v7 04/11] virtio_ring: split: support premapped Xuan Zhuo 2023-04-25 7:36 ` Xuan Zhuo 2023-04-25 7:36 ` [PATCH vhost v7 05/11] virtio_ring: packed: " Xuan Zhuo 2023-04-25 7:36 ` Xuan Zhuo 2023-04-25 7:36 ` [PATCH vhost v7 06/11] virtio_ring: packed-indirect: " Xuan Zhuo 2023-04-25 7:36 ` Xuan Zhuo 2023-04-25 7:36 ` [PATCH vhost v7 07/11] virtio_ring: update document for virtqueue_add_* Xuan Zhuo 2023-04-25 7:36 ` Xuan Zhuo 2023-04-25 7:36 ` [PATCH vhost v7 08/11] virtio_ring: introduce virtqueue_dma_dev() Xuan Zhuo 2023-04-25 7:36 ` Xuan Zhuo 2023-04-25 7:36 ` [PATCH vhost v7 09/11] virtio_ring: correct the expression of the description of virtqueue_resize() Xuan Zhuo 2023-04-25 7:36 ` Xuan Zhuo 2023-04-25 7:36 ` [PATCH vhost v7 10/11] virtio_ring: separate the logic of reset/enable from virtqueue_resize Xuan Zhuo 2023-04-25 7:36 ` Xuan Zhuo 2023-04-25 7:36 ` [PATCH vhost v7 11/11] virtio_ring: introduce virtqueue_reset() Xuan Zhuo 2023-04-25 7:36 ` Xuan Zhuo 2023-04-25 7:51 ` [PATCH vhost v7 00/11] virtio core prepares for AF_XDP Michael S. Tsirkin 2023-04-25 7:51 ` Michael S. Tsirkin 2023-04-25 8:05 ` Xuan Zhuo 2023-04-25 8:05 ` Xuan Zhuo 2023-04-25 8:13 ` Michael S. Tsirkin 2023-04-25 8:13 ` Michael S. Tsirkin 2023-04-25 8:21 ` Xuan Zhuo 2023-04-25 8:21 ` Xuan Zhuo 2023-04-25 12:40 ` Michael S. Tsirkin 2023-04-25 12:40 ` Michael S. Tsirkin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230425073613.8839-1-xuanzhuo@linux.alibaba.com \ --to=xuanzhuo@linux.alibaba.com \ --cc=aleksander.lobakin@intel.com \ --cc=ast@kernel.org \ --cc=bpf@vger.kernel.org \ --cc=daniel@iogearbox.net \ --cc=davem@davemloft.net \ --cc=hawk@kernel.org \ --cc=hch@infradead.org \ --cc=john.fastabend@gmail.com \ --cc=kuba@kernel.org \ --cc=mst@redhat.com \ --cc=netdev@vger.kernel.org \ --cc=virtualization@lists.linux-foundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.