All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH v7 1/5] package/at-spi2-core: bump to version 2.48.0
@ 2023-04-28  7:59 Thomas Devoogdt
  2023-04-28  7:59 ` [Buildroot] [PATCH v7 2/5] package/at-spi2-atk: remove package Thomas Devoogdt
                   ` (6 more replies)
  0 siblings, 7 replies; 14+ messages in thread
From: Thomas Devoogdt @ 2023-04-28  7:59 UTC (permalink / raw)
  To: buildroot
  Cc: Joseph Kogut, Daniel Lang, Thomas Devoogdt, James Knight,
	Adrian Perez de Castro, Fabrice Fontaine

From: Daniel Lang <d.lang@abatec.at>

https://gitlab.gnome.org/GNOME/at-spi2-core/-/blob/AT_SPI2_CORE_2_48_0/NEWS

- X11 is now optional.
- libxml2 is no longer optional.
- atk and at-spi2-atk have been merged into at-spi2-core.
- atk introspection option added.
- Added patch to which avoids requiring libsystemd when configured to use dbus-daemon.
- Added check on dlopen.

Signed-off-by: Daniel Lang <d.lang@abatec.at>
Signed-off-by: Thomas Devoogdt <thomas.devoogdt@barco.com>
---
v3:
 - rebased on https://patchwork.ozlabs.org/project/buildroot/list/?series=336254
 - needed to fix the webkitgtk 2.38.5 compilation
   (https://patchwork.ozlabs.org/project/buildroot/patch/20230220090923.2155635-2-thomas.devoogdt@barco.com/)
v5: rebased + grouped patches
v6: rebased + added Adrians patch
 - note: 2.48.0 is out, but will first merge this one
v7: bumped to 2.48.0 + added dlopen check
---
 ...iring-libsystemd-when-configured-to-.patch | 92 +++++++++++++++++++
 package/at-spi2-core/Config.in                | 13 +--
 package/at-spi2-core/at-spi2-core.hash        |  4 +-
 package/at-spi2-core/at-spi2-core.mk          | 18 +++-
 4 files changed, 115 insertions(+), 12 deletions(-)
 create mode 100644 package/at-spi2-core/0001-meson-Avoid-requiring-libsystemd-when-configured-to-.patch

diff --git a/package/at-spi2-core/0001-meson-Avoid-requiring-libsystemd-when-configured-to-.patch b/package/at-spi2-core/0001-meson-Avoid-requiring-libsystemd-when-configured-to-.patch
new file mode 100644
index 0000000000..29c3de8d2d
--- /dev/null
+++ b/package/at-spi2-core/0001-meson-Avoid-requiring-libsystemd-when-configured-to-.patch
@@ -0,0 +1,92 @@
+From aeb14ffccaabe65a64e976576d71f30eb2165f43 Mon Sep 17 00:00:00 2001
+From: Adrian Perez de Castro <aperez@igalia.com>
+Date: Mon, 24 Apr 2023 12:09:50 +0300
+Subject: [PATCH] meson: Avoid requiring libsystemd when configured to use
+ dbus-daemon
+
+Checks for dbus-daemon and dbus-broker only when they are chosen
+with default_bus. This avoids requiring the systemd libraries if
+one wants the built at-spi2-core to use dbus-daemon, but dbus-worker
+is somehow available in the $PATH. A typical scenario is cross
+compilation, where the build host may have a dbus-broker program
+available, but the target system may not have it (or may not have
+nor want to use the systemd libraries).
+
+upstream: https://gitlab.gnome.org/GNOME/at-spi2-core/-/merge_requests/134
+---
+ bus/meson.build | 53 ++++++++++++++++++++++++-------------------------
+ 1 file changed, 26 insertions(+), 27 deletions(-)
+
+diff --git a/bus/meson.build b/bus/meson.build
+index 22a1bce6..2f3c5621 100644
+--- a/bus/meson.build
++++ b/bus/meson.build
+@@ -46,39 +46,38 @@ launcher_args = [
+              '-DDATADIR="@0@"'.format(atspi_datadir),
+            ]
+ 
+-if get_option('dbus_daemon') != 'default'
+-  launcher_args += '-DDBUS_DAEMON="@0@"'.format(get_option('dbus_daemon'))
+-else
+-  dbus_daemon = find_program('dbus-daemon',
+-                             '/sbin/dbus-daemon',
+-                             '/usr/sbin/dbus-daemon',
+-                             '/libexec/dbus-daemon',
+-                             '/usr/libexec/dbus-daemon',
+-                             '/usr/lib/dbus-daemon',
+-                             '/usr/pkg/bin/dbus-daemon',
+-                             required: false)
+-  if dbus_daemon.found()
+-    launcher_args += '-DDBUS_DAEMON="@0@"'.format(dbus_daemon.full_path())
+-  endif
+-endif
+-
+ needs_systemd = false
+-if get_option('dbus_broker') != 'default'
+-  launcher_args += '-DDBUS_BROKER="@0@"'.format(get_option('dbus_broker'))
+-  needs_systemd = true
++if get_option('default_bus') == 'dbus-daemon'
++  if get_option('dbus_daemon') != 'default'
++    launcher_args += '-DDBUS_DAEMON="@0@"'.format(get_option('dbus_daemon'))
++  else
++    dbus_daemon = find_program('dbus-daemon',
++                               '/sbin/dbus-daemon',
++                               '/usr/sbin/dbus-daemon',
++                               '/libexec/dbus-daemon',
++                               '/usr/libexec/dbus-daemon',
++                               '/usr/lib/dbus-daemon',
++                               '/usr/pkg/bin/dbus-daemon',
++                               required: false)
++    if dbus_daemon.found()
++      launcher_args += '-DDBUS_DAEMON="@0@"'.format(dbus_daemon.full_path())
++    endif
++  endif
+ else
+-  dbus_broker = find_program('dbus-broker-launch',
+-                             required: false)
+-  if dbus_broker.found()
+-    launcher_args += '-DDBUS_BROKER="@0@"'.format(dbus_broker.full_path())
++  launcher_args += '-DWANT_DBUS_BROKER'
++  if get_option('dbus_broker') != 'default'
++    launcher_args += '-DDBUS_BROKER="@0@"'.format(get_option('dbus_broker'))
+     needs_systemd = true
++  else
++    dbus_broker = find_program('dbus-broker-launch',
++                               required: false)
++    if dbus_broker.found()
++      launcher_args += '-DDBUS_BROKER="@0@"'.format(dbus_broker.full_path())
++      needs_systemd = true
++    endif
+   endif
+ endif
+ 
+-if get_option('default_bus') == 'dbus-broker'
+-  launcher_args += '-DWANT_DBUS_BROKER'
+-endif
+-
+ if needs_systemd
+   systemd_dep = dependency('libsystemd')
+ else
+-- 
+2.34.1
+
diff --git a/package/at-spi2-core/Config.in b/package/at-spi2-core/Config.in
index f56c5b93c4..2a1b21d375 100644
--- a/package/at-spi2-core/Config.in
+++ b/package/at-spi2-core/Config.in
@@ -1,12 +1,13 @@
 config BR2_PACKAGE_AT_SPI2_CORE
 	bool "at-spi2-core"
-	depends on BR2_PACKAGE_XORG7 # xlib-libxtst
 	depends on BR2_TOOLCHAIN_HAS_THREADS # dbus, glib2
 	depends on BR2_USE_MMU # glib2
 	depends on BR2_USE_WCHAR # glib2
+	depends on !BR2_STATIC_LIBS # dlopen()
 	select BR2_PACKAGE_DBUS
 	select BR2_PACKAGE_LIBGLIB2
-	select BR2_PACKAGE_XLIB_LIBXTST
+	select BR2_PACKAGE_LIBXML2
+	select BR2_PACKAGE_XLIB_LIBXTST if BR2_PACKAGE_XORG7 # optionally for X11
 	help
 	  The At-Spi2 Core package is a part of the GNOME
 	  Accessibility Project. It provides a Service Provider
@@ -16,10 +17,6 @@ config BR2_PACKAGE_AT_SPI2_CORE
 
 	  https://wiki.gnome.org/Accessibility
 
-comment "at-spi2-core needs a toolchain w/ wchar, threads"
+comment "at-spi2-core needs a toolchain w/ dynamic library, wchar, threads"
 	depends on BR2_USE_MMU
-	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
-
-comment "at-spi2-core depends on X.org"
-	depends on BR2_USE_MMU
-	depends on !BR2_PACKAGE_XORG7
+	depends on BR2_STATIC_LIBS || !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
diff --git a/package/at-spi2-core/at-spi2-core.hash b/package/at-spi2-core/at-spi2-core.hash
index 764e4c3661..9cf80d1cc0 100644
--- a/package/at-spi2-core/at-spi2-core.hash
+++ b/package/at-spi2-core/at-spi2-core.hash
@@ -1,5 +1,5 @@
-# From https://download.gnome.org/sources/at-spi2-core/2.36/at-spi2-core-2.36.0.sha256sum
-sha256  88da57de0a7e3c60bc341a974a80fdba091612db3547c410d6deab039ca5c05a  at-spi2-core-2.36.0.tar.xz
+# From https://download.gnome.org/sources/at-spi2-core/2.48/at-spi2-core-2.48.0.sha256sum
+sha256  905a5b6f1790b68ee803bffa9f5fab4ceb591fb4fae0b2f8c612c54f1d4e8a30  at-spi2-core-2.48.0.tar.xz
 
 # locally calculated
 sha256  dc626520dcd53a22f727af3ee42c770e56c97a64fe3adb063799d8ab032fe551  COPYING
diff --git a/package/at-spi2-core/at-spi2-core.mk b/package/at-spi2-core/at-spi2-core.mk
index f0b019c0ed..e4489f6f88 100644
--- a/package/at-spi2-core/at-spi2-core.mk
+++ b/package/at-spi2-core/at-spi2-core.mk
@@ -4,17 +4,31 @@
 #
 ################################################################################
 
-AT_SPI2_CORE_VERSION_MAJOR = 2.36
+AT_SPI2_CORE_VERSION_MAJOR = 2.48
 AT_SPI2_CORE_VERSION = $(AT_SPI2_CORE_VERSION_MAJOR).0
 AT_SPI2_CORE_SOURCE = at-spi2-core-$(AT_SPI2_CORE_VERSION).tar.xz
 AT_SPI2_CORE_SITE = https://download.gnome.org/sources/at-spi2-core/$(AT_SPI2_CORE_VERSION_MAJOR)
 AT_SPI2_CORE_LICENSE = LGPL-2.1+
 AT_SPI2_CORE_LICENSE_FILES = COPYING
 AT_SPI2_CORE_INSTALL_STAGING = YES
-AT_SPI2_CORE_DEPENDENCIES = host-pkgconf dbus libglib2 xlib_libXtst \
+AT_SPI2_CORE_DEPENDENCIES = host-pkgconf dbus libglib2 libxml2 \
 	$(TARGET_NLS_DEPENDENCIES)
 AT_SPI2_CORE_CONF_OPTS = -Ddbus_daemon=/usr/bin/dbus-daemon
 
+ifeq ($(BR2_PACKAGE_XORG7),y)
+AT_SPI2_CORE_CONF_OPTS += -Dx11=enabled
+AT_SPI2_CORE_DEPENDENCIES += xlib_libXtst
+else
+AT_SPI2_CORE_CONF_OPTS += -Dx11=disabled
+endif
+
+ifeq ($(BR2_PACKAGE_GOBJECT_INTROSPECTION),y)
+AT_SPI2_CORE_CONF_OPTS += -Dintrospection=enabled
+AT_SPI2_CORE_DEPENDENCIES += gobject-introspection
+else
+AT_SPI2_CORE_CONF_OPTS += -Dintrospection=disabled
+endif
+
 AT_SPI2_CORE_LDFLAGS = $(TARGET_LDFLAGS) $(TARGET_NLS_LIBS)
 
 $(eval $(meson-package))
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [Buildroot] [PATCH v7 2/5] package/at-spi2-atk: remove package
  2023-04-28  7:59 [Buildroot] [PATCH v7 1/5] package/at-spi2-core: bump to version 2.48.0 Thomas Devoogdt
@ 2023-04-28  7:59 ` Thomas Devoogdt
  2023-05-05 11:56   ` Adrian Perez de Castro
  2023-04-28  7:59 ` [Buildroot] [PATCH v7 3/5] package/atk: " Thomas Devoogdt
                   ` (5 subsequent siblings)
  6 siblings, 1 reply; 14+ messages in thread
From: Thomas Devoogdt @ 2023-04-28  7:59 UTC (permalink / raw)
  To: buildroot
  Cc: Joseph Kogut, Daniel Lang, Thomas Devoogdt, James Knight,
	Adrian Perez de Castro, Fabrice Fontaine

From: Daniel Lang <d.lang@abatec.at>

at-spi2-atk has been merged into at-spi2-core with version 2.45.1.

https://gitlab.gnome.org/GNOME/at-spi2-core/-/blob/AT_SPI2_CORE_2_45_1/NEWS
https://gitlab.gnome.org/GNOME/at-spi2-core/-/merge_requests/78

Signed-off-by: Daniel Lang <d.lang@abatec.at>
Signed-off-by: Thomas Devoogdt <thomas.devoogdt@barco.com>
Tested-by: Adrian Perez de Castro <aperez@igalia.com>
---
v3:
 - rebased on https://patchwork.ozlabs.org/project/buildroot/list/?series=336254
 - needed to fix the webkitgtk 2.38.5 compilation
   (https://patchwork.ozlabs.org/project/buildroot/patch/20230220090923.2155635-2-thomas.devoogdt@barco.com/)
v5: rebased + grouped patches
v6: no change
v7: no change
---
 Config.in.legacy                              |  7 +++
 DEVELOPERS                                    |  1 -
 package/Config.in                             |  1 -
 .../0001-meson-add-tests-option.patch         | 43 -------------------
 package/at-spi2-atk/Config.in                 | 22 ----------
 package/at-spi2-atk/at-spi2-atk.hash          |  5 ---
 package/at-spi2-atk/at-spi2-atk.mk            | 19 --------
 7 files changed, 7 insertions(+), 91 deletions(-)
 delete mode 100644 package/at-spi2-atk/0001-meson-add-tests-option.patch
 delete mode 100644 package/at-spi2-atk/Config.in
 delete mode 100644 package/at-spi2-atk/at-spi2-atk.hash
 delete mode 100644 package/at-spi2-atk/at-spi2-atk.mk

diff --git a/Config.in.legacy b/Config.in.legacy
index 366b9d6949..db75899a9b 100644
--- a/Config.in.legacy
+++ b/Config.in.legacy
@@ -146,6 +146,13 @@ endif
 
 comment "Legacy options removed in 2023.05"
 
+config BR2_PACKAGE_AT_SPI2_ATK
+	bool "at-spi2-atk removed"
+	select BR2_LEGACY
+	select BR2_PACKAGE_AT_SPI2_CORE
+	help
+	  at-spi2-atk is now part of at-spi2-core.
+
 config BR2_PACAKGE_OPENFPGALOADER_CMSIS
 	bool "openfpgaloader cmsis option name fixed"
 	select BR2_LEGACY
diff --git a/DEVELOPERS b/DEVELOPERS
index d9e95a3d05..9206659428 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -1632,7 +1632,6 @@ F:	support/testing/tests/package/test_avocado.py
 F:	support/testing/tests/package/test_python_aexpect.py
 
 N:	Joseph Kogut <joseph.kogut@gmail.com>
-F:	package/at-spi2-atk/
 F:	package/at-spi2-core/
 F:	package/clang/
 F:	package/earlyoom/
diff --git a/package/Config.in b/package/Config.in
index eaac32a01a..70c5c2eea8 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1554,7 +1554,6 @@ endmenu
 
 menu "Graphics"
 	source "package/assimp/Config.in"
-	source "package/at-spi2-atk/Config.in"
 	source "package/at-spi2-core/Config.in"
 	source "package/atk/Config.in"
 	source "package/atkmm/Config.in"
diff --git a/package/at-spi2-atk/0001-meson-add-tests-option.patch b/package/at-spi2-atk/0001-meson-add-tests-option.patch
deleted file mode 100644
index 3a2aefa090..0000000000
--- a/package/at-spi2-atk/0001-meson-add-tests-option.patch
+++ /dev/null
@@ -1,43 +0,0 @@
-From 466d04a57b32417dbf2d5e818af1b7593af5f802 Mon Sep 17 00:00:00 2001
-From: Fabrice Fontaine <fontaine.fabrice@gmail.com>
-Date: Sun, 3 May 2020 10:29:36 +0200
-Subject: [PATCH] meson: add tests option
-
-Add tests option to allow the user to build at-spi2-atk without tests,
-it is especially useful as one of the test requires libxml-2.0
-
-Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
-[Upstream status:
-https://gitlab.gnome.org/GNOME/at-spi2-atk/-/merge_requests/22]
----
- meson.build       | 4 +++-
- meson_options.txt | 4 ++++
- 2 files changed, 7 insertions(+), 1 deletion(-)
-
-diff --git a/meson.build b/meson.build
-index 9fce5d6..61bc93d 100644
---- a/meson.build
-+++ b/meson.build
-@@ -61,4 +61,6 @@ install_data('at-spi2-atk.desktop',
- 
- subdir('droute')
- subdir('atk-adaptor')
--subdir('tests')
-+if get_option('tests')
-+  subdir('tests')
-+endif
-diff --git a/meson_options.txt b/meson_options.txt
-index 24c9228..a4abdc2 100644
---- a/meson_options.txt
-+++ b/meson_options.txt
-@@ -2,3 +2,7 @@ option('disable_p2p',
-        description: 'Disable peer-to-peer DBus connections',
-        type: 'boolean',
-        value: false)
-+option('tests',
-+       description: 'Whether to build tests',
-+       type: 'boolean',
-+       value: true)
--- 
-2.26.2
-
diff --git a/package/at-spi2-atk/Config.in b/package/at-spi2-atk/Config.in
deleted file mode 100644
index 9a7cfde0af..0000000000
--- a/package/at-spi2-atk/Config.in
+++ /dev/null
@@ -1,22 +0,0 @@
-config BR2_PACKAGE_AT_SPI2_ATK
-	bool "at-spi2-atk"
-	depends on BR2_PACKAGE_XORG7 # at-spi2-core
-	depends on BR2_TOOLCHAIN_HAS_THREADS # glib2
-	depends on BR2_USE_MMU # glib2
-	depends on BR2_USE_WCHAR # glib2
-	select BR2_PACKAGE_ATK
-	select BR2_PACKAGE_AT_SPI2_CORE
-	select BR2_PACKAGE_LIBGLIB2
-	help
-	  The At-Spi2 Atk package contains a library that bridges
-	  ATK to At-Spi2 D-Bus service.
-
-	  https://www.freedesktop.org/wiki/Accessibility/AT-SPI2/
-
-comment "at-spi2-atk needs a toolchain w/ wchar, threads"
-	depends on BR2_USE_MMU
-	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
-
-comment "at-spi2-atk depends on X.org"
-	depends on BR2_USE_MMU
-	depends on !BR2_PACKAGE_XORG7
diff --git a/package/at-spi2-atk/at-spi2-atk.hash b/package/at-spi2-atk/at-spi2-atk.hash
deleted file mode 100644
index 9c564c32af..0000000000
--- a/package/at-spi2-atk/at-spi2-atk.hash
+++ /dev/null
@@ -1,5 +0,0 @@
-# From http://ftp.acc.umu.se/pub/gnome/sources/at-spi2-atk/2.34/at-spi2-atk-2.34.2.sha256sum
-sha256  901323cee0eef05c01ec4dee06c701aeeca81a314a7d60216fa363005e27f4f0  at-spi2-atk-2.34.2.tar.xz
-
-# locally calculated
-sha256  dc626520dcd53a22f727af3ee42c770e56c97a64fe3adb063799d8ab032fe551  COPYING
diff --git a/package/at-spi2-atk/at-spi2-atk.mk b/package/at-spi2-atk/at-spi2-atk.mk
deleted file mode 100644
index 232b577230..0000000000
--- a/package/at-spi2-atk/at-spi2-atk.mk
+++ /dev/null
@@ -1,19 +0,0 @@
-################################################################################
-#
-# at-spi2-atk
-#
-################################################################################
-
-AT_SPI2_ATK_VERSION_MAJOR = 2.34
-AT_SPI2_ATK_VERSION = $(AT_SPI2_ATK_VERSION_MAJOR).2
-AT_SPI2_ATK_SOURCE = at-spi2-atk-$(AT_SPI2_ATK_VERSION).tar.xz
-AT_SPI2_ATK_SITE = \
-	http://ftp.gnome.org/pub/gnome/sources/at-spi2-atk/$(AT_SPI2_ATK_VERSION_MAJOR)
-AT_SPI2_ATK_LICENSE = LGPL-2.1+
-AT_SPI2_ATK_LICENSE_FILES = COPYING
-AT_SPI2_ATK_CPE_ID_VENDOR = gnome
-AT_SPI2_ATK_INSTALL_STAGING = YES
-AT_SPI2_ATK_DEPENDENCIES = atk at-spi2-core libglib2 host-pkgconf
-AT_SPI2_ATK_CONF_OPTS = -Dtests=false
-
-$(eval $(meson-package))
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [Buildroot] [PATCH v7 3/5] package/atk: remove package
  2023-04-28  7:59 [Buildroot] [PATCH v7 1/5] package/at-spi2-core: bump to version 2.48.0 Thomas Devoogdt
  2023-04-28  7:59 ` [Buildroot] [PATCH v7 2/5] package/at-spi2-atk: remove package Thomas Devoogdt
@ 2023-04-28  7:59 ` Thomas Devoogdt
  2023-05-05 11:56   ` Adrian Perez de Castro
  2023-04-28  7:59 ` [Buildroot] [PATCH v7 4/5] package/libgtk3: re-enable atk-bridge Thomas Devoogdt
                   ` (4 subsequent siblings)
  6 siblings, 1 reply; 14+ messages in thread
From: Thomas Devoogdt @ 2023-04-28  7:59 UTC (permalink / raw)
  To: buildroot
  Cc: Joseph Kogut, Daniel Lang, Thomas Devoogdt, James Knight,
	Adrian Perez de Castro, Fabrice Fontaine

From: Daniel Lang <d.lang@abatec.at>

atk has been merged into at-spi2-core with version 2.45.1.

https://gitlab.gnome.org/GNOME/at-spi2-core/-/blob/AT_SPI2_CORE_2_45_1/NEWS
https://gitlab.gnome.org/GNOME/at-spi2-core/-/merge_requests/78

Signed-off-by: Daniel Lang <d.lang@abatec.at>
Signed-off-by: Thomas Devoogdt <thomas.devoogdt@barco.com>
Tested-by: Adrian Perez de Castro <aperez@igalia.com>
---
v3:
 - rebased on https://patchwork.ozlabs.org/project/buildroot/list/?series=336254
 - needed to fix the webkitgtk 2.38.5 compilation
   (https://patchwork.ozlabs.org/project/buildroot/patch/20230220090923.2155635-2-thomas.devoogdt@barco.com/)
v5: rebased + grouped patches
v6: added change to atkmm2_28
v7: no change
---
 Config.in.legacy               |  7 +++++++
 package/Config.in              |  1 -
 package/atk/Config.in          | 14 --------------
 package/atk/atk.hash           |  5 -----
 package/atk/atk.mk             | 25 -------------------------
 package/atkmm/Config.in        |  8 ++++----
 package/atkmm/atkmm.mk         |  2 +-
 package/atkmm2_28/Config.in    |  8 ++++----
 package/atkmm2_28/atkmm2_28.mk |  2 +-
 package/libglade/Config.in     |  2 +-
 package/libglade/libglade.mk   |  2 +-
 package/libgtk2/Config.in      |  2 +-
 package/libgtk2/libgtk2.mk     |  2 +-
 package/libgtk3/Config.in      |  2 +-
 package/libgtk3/libgtk3.mk     |  2 +-
 15 files changed, 23 insertions(+), 61 deletions(-)
 delete mode 100644 package/atk/Config.in
 delete mode 100644 package/atk/atk.hash
 delete mode 100644 package/atk/atk.mk

diff --git a/Config.in.legacy b/Config.in.legacy
index db75899a9b..d86a7e6363 100644
--- a/Config.in.legacy
+++ b/Config.in.legacy
@@ -146,6 +146,13 @@ endif
 
 comment "Legacy options removed in 2023.05"
 
+config BR2_PACKAGE_ATK
+	bool "atk removed"
+	select BR2_LEGACY
+	select BR2_PACKAGE_AT_SPI2_CORE
+	help
+	  atk is now part of at-spi2-core.
+
 config BR2_PACKAGE_AT_SPI2_ATK
 	bool "at-spi2-atk removed"
 	select BR2_LEGACY
diff --git a/package/Config.in b/package/Config.in
index 70c5c2eea8..6a92573d39 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1555,7 +1555,6 @@ endmenu
 menu "Graphics"
 	source "package/assimp/Config.in"
 	source "package/at-spi2-core/Config.in"
-	source "package/atk/Config.in"
 	source "package/atkmm/Config.in"
 	source "package/atkmm2_28/Config.in"
 	source "package/bayer2rgb-neon/Config.in"
diff --git a/package/atk/Config.in b/package/atk/Config.in
deleted file mode 100644
index d9371b879b..0000000000
--- a/package/atk/Config.in
+++ /dev/null
@@ -1,14 +0,0 @@
-config BR2_PACKAGE_ATK
-	bool "atk"
-	depends on BR2_USE_WCHAR # glib2
-	depends on BR2_TOOLCHAIN_HAS_THREADS # glib2
-	depends on BR2_USE_MMU # glib2
-	select BR2_PACKAGE_LIBGLIB2
-	help
-	  The ATK accessibility toolkit, needed to build GTK+-2.x.
-
-	  https://gitlab.gnome.org/GNOME/atk
-
-comment "atk needs a toolchain w/ wchar, threads"
-	depends on BR2_USE_MMU
-	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
diff --git a/package/atk/atk.hash b/package/atk/atk.hash
deleted file mode 100644
index d8cd69ff1f..0000000000
--- a/package/atk/atk.hash
+++ /dev/null
@@ -1,5 +0,0 @@
-# From http://ftp.gnome.org/pub/gnome/sources/atk/2.38/atk-2.38.0.sha256sum
-sha256  ac4de2a4ef4bd5665052952fe169657e65e895c5057dffb3c2a810f6191a0c36  atk-2.38.0.tar.xz
-
-# Hash for license file
-sha256  d245807f90032872d1438d741ed21e2490e1175dc8aa3afa5ddb6c8e529b58e5  COPYING
diff --git a/package/atk/atk.mk b/package/atk/atk.mk
deleted file mode 100644
index 2820fb486d..0000000000
--- a/package/atk/atk.mk
+++ /dev/null
@@ -1,25 +0,0 @@
-################################################################################
-#
-# atk
-#
-################################################################################
-
-ATK_VERSION_MAJOR = 2.38
-ATK_VERSION = $(ATK_VERSION_MAJOR).0
-ATK_SOURCE = atk-$(ATK_VERSION).tar.xz
-ATK_SITE = http://ftp.gnome.org/pub/gnome/sources/atk/$(ATK_VERSION_MAJOR)
-ATK_LICENSE = LGPL-2.0+
-ATK_LICENSE_FILES = COPYING
-ATK_INSTALL_STAGING = YES
-ATK_DEPENDENCIES = libglib2 $(TARGET_NLS_DEPENDENCIES)
-
-ifeq ($(BR2_PACKAGE_GOBJECT_INTROSPECTION),y)
-ATK_CONF_OPTS += -Dintrospection=true
-ATK_DEPENDENCIES += gobject-introspection
-else
-ATK_CONF_OPTS += -Dintrospection=false
-endif
-
-ATK_LDFLAGS = $(TARGET_LDFLAGS) $(TARGET_NLS_LIBS)
-
-$(eval $(meson-package))
diff --git a/package/atkmm/Config.in b/package/atkmm/Config.in
index 1f370356ea..571d7e69ad 100644
--- a/package/atkmm/Config.in
+++ b/package/atkmm/Config.in
@@ -2,10 +2,10 @@ config BR2_PACKAGE_ATKMM
 	bool "atkmm (latest)"
 	depends on BR2_INSTALL_LIBSTDCPP # glibmm
 	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_7 # libsigc
-	depends on BR2_TOOLCHAIN_HAS_THREADS # atk/glibmm -> libglib2
-	depends on BR2_USE_MMU # atk/glibmm -> libglib2
-	depends on BR2_USE_WCHAR # atk/glibmm -> libglib2
-	select BR2_PACKAGE_ATK
+	depends on BR2_TOOLCHAIN_HAS_THREADS # at-spi2-core/glibmm -> libglib2
+	depends on BR2_USE_MMU # at-spi2-core/glibmm -> libglib2
+	depends on BR2_USE_WCHAR # at-spi2-core/glibmm -> libglib2
+	select BR2_PACKAGE_AT_SPI2_CORE
 	select BR2_PACKAGE_GLIBMM
 	select BR2_PACKAGE_LIBSIGC
 
diff --git a/package/atkmm/atkmm.mk b/package/atkmm/atkmm.mk
index 7ceb87b047..da763c8386 100644
--- a/package/atkmm/atkmm.mk
+++ b/package/atkmm/atkmm.mk
@@ -11,6 +11,6 @@ ATKMM_SITE = https://download.gnome.org/sources/atkmm/$(ATKMM_VERSION_MAJOR)
 ATKMM_LICENSE = LGPL-2.1+ (library), GPL-2.0+ (tools)
 ATKMM_LICENSE_FILES = COPYING COPYING.tools
 ATKMM_INSTALL_STAGING = YES
-ATKMM_DEPENDENCIES = atk glibmm libsigc host-pkgconf
+ATKMM_DEPENDENCIES = at-spi2-core glibmm libsigc host-pkgconf
 
 $(eval $(meson-package))
diff --git a/package/atkmm2_28/Config.in b/package/atkmm2_28/Config.in
index 2340465b20..e88073b87a 100644
--- a/package/atkmm2_28/Config.in
+++ b/package/atkmm2_28/Config.in
@@ -2,10 +2,10 @@ config BR2_PACKAGE_ATKMM2_28
 	bool "atkmm (2.28.x)"
 	depends on BR2_INSTALL_LIBSTDCPP # glibmm
 	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # C++11
-	depends on BR2_TOOLCHAIN_HAS_THREADS # atk/glibmm -> libglib2
-	depends on BR2_USE_MMU # atk/glibmm -> libglib2
-	depends on BR2_USE_WCHAR # atk/glibmm -> libglib2
-	select BR2_PACKAGE_ATK
+	depends on BR2_TOOLCHAIN_HAS_THREADS # at-spi2-core/glibmm -> libglib2
+	depends on BR2_USE_MMU # at-spi2-core/glibmm -> libglib2
+	depends on BR2_USE_WCHAR # at-spi2-core/glibmm -> libglib2
+	select BR2_PACKAGE_AT_SPI2_CORE
 	select BR2_PACKAGE_GLIBMM2_66
 	select BR2_PACKAGE_LIBSIGC2
 
diff --git a/package/atkmm2_28/atkmm2_28.mk b/package/atkmm2_28/atkmm2_28.mk
index dc57363cf5..b56da61ec0 100644
--- a/package/atkmm2_28/atkmm2_28.mk
+++ b/package/atkmm2_28/atkmm2_28.mk
@@ -11,6 +11,6 @@ ATKMM2_28_SITE = https://download.gnome.org/sources/atkmm/$(ATKMM2_28_VERSION_MA
 ATKMM2_28_LICENSE = LGPL-2.1+ (library), GPL-2.0+ (tools)
 ATKMM2_28_LICENSE_FILES = COPYING COPYING.tools
 ATKMM2_28_INSTALL_STAGING = YES
-ATKMM2_28_DEPENDENCIES = atk glibmm2_66 libsigc2 host-pkgconf
+ATKMM2_28_DEPENDENCIES = at-spi2-core glibmm2_66 libsigc2 host-pkgconf
 
 $(eval $(meson-package))
diff --git a/package/libglade/Config.in b/package/libglade/Config.in
index c97c9becd2..8d0d26f159 100644
--- a/package/libglade/Config.in
+++ b/package/libglade/Config.in
@@ -5,7 +5,7 @@ config BR2_PACKAGE_LIBGLADE
 	depends on BR2_TOOLCHAIN_HAS_THREADS # glib2
 	depends on BR2_USE_MMU # glib2
 	select BR2_PACKAGE_LIBGLIB2
-	select BR2_PACKAGE_ATK
+	select BR2_PACKAGE_AT_SPI2_CORE
 	select BR2_PACKAGE_LIBXML2
 	help
 	  Libglade allows you to load glade interface files in a program
diff --git a/package/libglade/libglade.mk b/package/libglade/libglade.mk
index 21aed60605..af73d8bd00 100644
--- a/package/libglade/libglade.mk
+++ b/package/libglade/libglade.mk
@@ -9,7 +9,7 @@ LIBGLADE_VERSION = $(LIBGLADE_VERSION_MAJOR).4
 LIBGLADE_SOURCE = libglade-$(LIBGLADE_VERSION).tar.bz2
 LIBGLADE_SITE = https://download.gnome.org/sources/libglade/$(LIBGLADE_VERSION_MAJOR)
 LIBGLADE_INSTALL_STAGING = YES
-LIBGLADE_DEPENDENCIES = host-pkgconf libglib2 libgtk2 atk libxml2
+LIBGLADE_DEPENDENCIES = host-pkgconf libglib2 libgtk2 at-spi2-core libxml2
 LIBGLADE_LICENSE = LGPL-2.0+
 LIBGLADE_LICENSE_FILES = COPYING
 
diff --git a/package/libgtk2/Config.in b/package/libgtk2/Config.in
index c75c37fb63..f2888b2f51 100644
--- a/package/libgtk2/Config.in
+++ b/package/libgtk2/Config.in
@@ -7,7 +7,7 @@ config BR2_PACKAGE_LIBGTK2
 	depends on BR2_INSTALL_LIBSTDCPP # pango
 	depends on BR2_TOOLCHAIN_HAS_SYNC_4 # pango -> harfbuzz
 	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # pango -> harfbuzz
-	select BR2_PACKAGE_ATK
+	select BR2_PACKAGE_AT_SPI2_CORE
 	select BR2_PACKAGE_CAIRO
 	select BR2_PACKAGE_CAIRO_PS
 	select BR2_PACKAGE_CAIRO_PDF
diff --git a/package/libgtk2/libgtk2.mk b/package/libgtk2/libgtk2.mk
index 859925e8d3..608c263e4d 100644
--- a/package/libgtk2/libgtk2.mk
+++ b/package/libgtk2/libgtk2.mk
@@ -23,7 +23,7 @@ LIBGTK2_CONF_ENV = \
 
 LIBGTK2_CONF_OPTS = --disable-glibtest --enable-explicit-deps=no
 
-LIBGTK2_DEPENDENCIES = host-pkgconf host-libgtk2 libglib2 cairo pango atk \
+LIBGTK2_DEPENDENCIES = host-pkgconf host-libgtk2 libglib2 cairo pango at-spi2-core \
 	gdk-pixbuf $(TARGET_NLS_DEPENDENCIES)
 
 LIBGTK2_MAKE_OPTS = LIBS=$(TARGET_NLS_LIBS)
diff --git a/package/libgtk3/Config.in b/package/libgtk3/Config.in
index 82ca68d2da..34b8d49eb3 100644
--- a/package/libgtk3/Config.in
+++ b/package/libgtk3/Config.in
@@ -23,7 +23,7 @@ config BR2_PACKAGE_LIBGTK3
 	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # pango -> harfbuzz
 	depends on BR2_PACKAGE_HAS_LIBEGL_WAYLAND || \
 		BR2_PACKAGE_HAS_LIBGL
-	select BR2_PACKAGE_ATK
+	select BR2_PACKAGE_AT_SPI2_CORE
 	select BR2_PACKAGE_CAIRO
 	select BR2_PACKAGE_CAIRO_PS
 	select BR2_PACKAGE_CAIRO_PDF
diff --git a/package/libgtk3/libgtk3.mk b/package/libgtk3/libgtk3.mk
index 18a8a9fa42..bdd54dcdc8 100644
--- a/package/libgtk3/libgtk3.mk
+++ b/package/libgtk3/libgtk3.mk
@@ -14,7 +14,7 @@ LIBGTK3_CPE_ID_VENDOR = gnome
 LIBGTK3_CPE_ID_PRODUCT = gtk
 LIBGTK3_INSTALL_STAGING = YES
 
-LIBGTK3_DEPENDENCIES = host-pkgconf host-libgtk3 atk libglib2 cairo pango \
+LIBGTK3_DEPENDENCIES = host-pkgconf host-libgtk3 at-spi2-core libglib2 cairo pango \
 	gdk-pixbuf libepoxy $(TARGET_NLS_DEPENDENCIES)
 
 ifeq ($(BR2_PACKAGE_LIBGTK3_X11),y)
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [Buildroot] [PATCH v7 4/5] package/libgtk3: re-enable atk-bridge
  2023-04-28  7:59 [Buildroot] [PATCH v7 1/5] package/at-spi2-core: bump to version 2.48.0 Thomas Devoogdt
  2023-04-28  7:59 ` [Buildroot] [PATCH v7 2/5] package/at-spi2-atk: remove package Thomas Devoogdt
  2023-04-28  7:59 ` [Buildroot] [PATCH v7 3/5] package/atk: " Thomas Devoogdt
@ 2023-04-28  7:59 ` Thomas Devoogdt
  2023-05-05 11:57   ` Adrian Perez de Castro
  2023-04-28  7:59 ` [Buildroot] [PATCH v7 5/5] package/libgtk3: fix update-icon-cache on empty directory Thomas Devoogdt
                   ` (3 subsequent siblings)
  6 siblings, 1 reply; 14+ messages in thread
From: Thomas Devoogdt @ 2023-04-28  7:59 UTC (permalink / raw)
  To: buildroot
  Cc: Joseph Kogut, Thomas Devoogdt, Daniel Lang, Thomas Devoogdt,
	James Knight, Adrian Perez de Castro, Fabrice Fontaine

The at-spi2-core and at-spi2-atk were merged, and are now built by default,
so this patch is no longer required.

Signed-off-by: Thomas Devoogdt <thomas.devoogdt@barco.com>
Tested-by: Adrian Perez de Castro <aperez@igalia.com>
---
v5: added re-enable atk-bridge patch to the package/at-spi2-core: bump to version 2.47.1 group
v6: no change
v7: no change
---
 package/libgtk3/0001-disable-atk-bridge.patch | 41 -------------------
 1 file changed, 41 deletions(-)
 delete mode 100644 package/libgtk3/0001-disable-atk-bridge.patch

diff --git a/package/libgtk3/0001-disable-atk-bridge.patch b/package/libgtk3/0001-disable-atk-bridge.patch
deleted file mode 100644
index f3e9bff2ba..0000000000
--- a/package/libgtk3/0001-disable-atk-bridge.patch
+++ /dev/null
@@ -1,41 +0,0 @@
-Remove atk-bridge support.
-
-atk-bridge doesn't seem useful for now in Buildroot and requires to
-add two new packages just for it: at-spi2-core and at-spi2-atk.
-
-Signed-off-by: Hadrien Boutteville <hadrien.boutteville@gmail.com>
-
---- a/gtk/a11y/gtkaccessibility.c
-+++ b/gtk/a11y/gtkaccessibility.c
-@@ -37,10 +37,6 @@
- #include <gtk/gtktogglebutton.h>
- #include <gtk/gtkaccessible.h>
-
--#ifdef GDK_WINDOWING_X11
--#include <atk-bridge.h>
--#endif
--
- static gboolean gail_focus_watcher      (GSignalInvocationHint *ihint,
-                                          guint                  n_param_values,
-                                          const GValue          *param_values,
-@@ -988,9 +984,5 @@ _gtk_accessibility_init (void)
-   _gtk_accessibility_override_atk_util ();
-   do_window_event_initialization ();
-
--#ifdef GDK_WINDOWING_X11
--  atk_bridge_adaptor_init (NULL, NULL);
--#endif
--
-   atk_misc_instance = g_object_new (GTK_TYPE_MISC_IMPL, NULL);
- }
---- a/meson.build
-+++ b/meson.build
-@@ -564,7 +564,7 @@ if x11_enabled
-   xfixes_dep     = dependency('xfixes', required: false)
-   xcomposite_dep = dependency('xcomposite', required: false)
-   fontconfig_dep = dependency('fontconfig', fallback: ['fontconfig', 'fontconfig_dep'])
--  atkbridge_dep  = dependency('atk-bridge-2.0', version: at_spi2_atk_req)
-+  atkbridge_dep  = dependency('atk-bridge-2.0', version: at_spi2_atk_req, required: false)
- 
-   backend_immodules += ['xim']
- 
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [Buildroot] [PATCH v7 5/5] package/libgtk3: fix update-icon-cache on empty directory
  2023-04-28  7:59 [Buildroot] [PATCH v7 1/5] package/at-spi2-core: bump to version 2.48.0 Thomas Devoogdt
                   ` (2 preceding siblings ...)
  2023-04-28  7:59 ` [Buildroot] [PATCH v7 4/5] package/libgtk3: re-enable atk-bridge Thomas Devoogdt
@ 2023-04-28  7:59 ` Thomas Devoogdt
  2023-05-05 11:57   ` Adrian Perez de Castro
  2023-05-05 11:56 ` [Buildroot] [PATCH v7 1/5] package/at-spi2-core: bump to version 2.48.0 Adrian Perez de Castro
                   ` (2 subsequent siblings)
  6 siblings, 1 reply; 14+ messages in thread
From: Thomas Devoogdt @ 2023-04-28  7:59 UTC (permalink / raw)
  To: buildroot
  Cc: Joseph Kogut, Thomas Devoogdt, Daniel Lang, Thomas Devoogdt,
	James Knight, Adrian Perez de Castro, Fabrice Fontaine

If both, hicolor-icon-theme (selected by libgtk3-demo) and
adwaita-icon-theme is not selected, then the /usr/share/icons
folder is empty, causing find to fail.

Signed-off-by: Thomas Devoogdt <thomas.devoogdt@barco.com>
Tested-by: Adrian Perez de Castro <aperez@igalia.com>
---
v5: 
 - Fixed indentation.
 - Grouped patches.
v6: no change
v7: no change
---
 package/libgtk3/libgtk3.mk | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/package/libgtk3/libgtk3.mk b/package/libgtk3/libgtk3.mk
index bdd54dcdc8..eac569fd41 100644
--- a/package/libgtk3/libgtk3.mk
+++ b/package/libgtk3/libgtk3.mk
@@ -146,8 +146,9 @@ endef
 # Create icon-theme.cache for each of the icon directories/themes
 # It's not strictly necessary but speeds up lookups
 define LIBGTK3_UPDATE_ICON_CACHE
-	find $(TARGET_DIR)/usr/share/icons -maxdepth 1 -mindepth 1 -type d \
-		-exec $(HOST_DIR)/bin/gtk-update-icon-cache {} \;
+	[ ! -d $(TARGET_DIR)/usr/share/icons ] || \
+		find $(TARGET_DIR)/usr/share/icons -maxdepth 1 -mindepth 1 -type d \
+			-exec $(HOST_DIR)/bin/gtk-update-icon-cache {} \;
 endef
 LIBGTK3_TARGET_FINALIZE_HOOKS += LIBGTK3_UPDATE_ICON_CACHE
 
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 14+ messages in thread

* Re: [Buildroot] [PATCH v7 1/5] package/at-spi2-core: bump to version 2.48.0
  2023-04-28  7:59 [Buildroot] [PATCH v7 1/5] package/at-spi2-core: bump to version 2.48.0 Thomas Devoogdt
                   ` (3 preceding siblings ...)
  2023-04-28  7:59 ` [Buildroot] [PATCH v7 5/5] package/libgtk3: fix update-icon-cache on empty directory Thomas Devoogdt
@ 2023-05-05 11:56 ` Adrian Perez de Castro
  2023-05-05 11:58   ` Adrian Perez de Castro
  2023-05-08 11:35 ` Yann E. MORIN
  2023-05-08 16:05 ` Yann E. MORIN
  6 siblings, 1 reply; 14+ messages in thread
From: Adrian Perez de Castro @ 2023-05-05 11:56 UTC (permalink / raw)
  To: Thomas Devoogdt
  Cc: Joseph Kogut, Daniel Lang, Thomas Devoogdt, James Knight,
	buildroot, Fabrice Fontaine


[-- Attachment #1.1: Type: text/plain, Size: 9515 bytes --]

On Fri, 28 Apr 2023 09:59:16 +0200 Thomas Devoogdt <thomas@devoogdt.com> wrote:
> From: Daniel Lang <d.lang@abatec.at>
> 
> https://gitlab.gnome.org/GNOME/at-spi2-core/-/blob/AT_SPI2_CORE_2_48_0/NEWS
> 
> - X11 is now optional.
> - libxml2 is no longer optional.
> - atk and at-spi2-atk have been merged into at-spi2-core.
> - atk introspection option added.
> - Added patch to which avoids requiring libsystemd when configured to use dbus-daemon.
> - Added check on dlopen.
> 
> Signed-off-by: Daniel Lang <d.lang@abatec.at>
> Signed-off-by: Thomas Devoogdt <thomas.devoogdt@barco.com>

Tested-by: Adrian Perez de Castro <aperez@igalia.com>
Reviewed-by: Adrian Perez de Castro <aperez@igalia.com>

> ---
> v3:
>  - rebased on https://patchwork.ozlabs.org/project/buildroot/list/?series=336254
>  - needed to fix the webkitgtk 2.38.5 compilation
>    (https://patchwork.ozlabs.org/project/buildroot/patch/20230220090923.2155635-2-thomas.devoogdt@barco.com/)
> v5: rebased + grouped patches
> v6: rebased + added Adrians patch
>  - note: 2.48.0 is out, but will first merge this one
> v7: bumped to 2.48.0 + added dlopen check
> ---
>  ...iring-libsystemd-when-configured-to-.patch | 92 +++++++++++++++++++
>  package/at-spi2-core/Config.in                | 13 +--
>  package/at-spi2-core/at-spi2-core.hash        |  4 +-
>  package/at-spi2-core/at-spi2-core.mk          | 18 +++-
>  4 files changed, 115 insertions(+), 12 deletions(-)
>  create mode 100644 package/at-spi2-core/0001-meson-Avoid-requiring-libsystemd-when-configured-to-.patch
> 
> diff --git a/package/at-spi2-core/0001-meson-Avoid-requiring-libsystemd-when-configured-to-.patch b/package/at-spi2-core/0001-meson-Avoid-requiring-libsystemd-when-configured-to-.patch
> new file mode 100644
> index 0000000000..29c3de8d2d
> --- /dev/null
> +++ b/package/at-spi2-core/0001-meson-Avoid-requiring-libsystemd-when-configured-to-.patch
> @@ -0,0 +1,92 @@
> +From aeb14ffccaabe65a64e976576d71f30eb2165f43 Mon Sep 17 00:00:00 2001
> +From: Adrian Perez de Castro <aperez@igalia.com>
> +Date: Mon, 24 Apr 2023 12:09:50 +0300
> +Subject: [PATCH] meson: Avoid requiring libsystemd when configured to use
> + dbus-daemon
> +
> +Checks for dbus-daemon and dbus-broker only when they are chosen
> +with default_bus. This avoids requiring the systemd libraries if
> +one wants the built at-spi2-core to use dbus-daemon, but dbus-worker
> +is somehow available in the $PATH. A typical scenario is cross
> +compilation, where the build host may have a dbus-broker program
> +available, but the target system may not have it (or may not have
> +nor want to use the systemd libraries).
> +
> +upstream: https://gitlab.gnome.org/GNOME/at-spi2-core/-/merge_requests/134
> +---
> + bus/meson.build | 53 ++++++++++++++++++++++++-------------------------
> + 1 file changed, 26 insertions(+), 27 deletions(-)
> +
> +diff --git a/bus/meson.build b/bus/meson.build
> +index 22a1bce6..2f3c5621 100644
> +--- a/bus/meson.build
> ++++ b/bus/meson.build
> +@@ -46,39 +46,38 @@ launcher_args = [
> +              '-DDATADIR="@0@"'.format(atspi_datadir),
> +            ]
> + 
> +-if get_option('dbus_daemon') != 'default'
> +-  launcher_args += '-DDBUS_DAEMON="@0@"'.format(get_option('dbus_daemon'))
> +-else
> +-  dbus_daemon = find_program('dbus-daemon',
> +-                             '/sbin/dbus-daemon',
> +-                             '/usr/sbin/dbus-daemon',
> +-                             '/libexec/dbus-daemon',
> +-                             '/usr/libexec/dbus-daemon',
> +-                             '/usr/lib/dbus-daemon',
> +-                             '/usr/pkg/bin/dbus-daemon',
> +-                             required: false)
> +-  if dbus_daemon.found()
> +-    launcher_args += '-DDBUS_DAEMON="@0@"'.format(dbus_daemon.full_path())
> +-  endif
> +-endif
> +-
> + needs_systemd = false
> +-if get_option('dbus_broker') != 'default'
> +-  launcher_args += '-DDBUS_BROKER="@0@"'.format(get_option('dbus_broker'))
> +-  needs_systemd = true
> ++if get_option('default_bus') == 'dbus-daemon'
> ++  if get_option('dbus_daemon') != 'default'
> ++    launcher_args += '-DDBUS_DAEMON="@0@"'.format(get_option('dbus_daemon'))
> ++  else
> ++    dbus_daemon = find_program('dbus-daemon',
> ++                               '/sbin/dbus-daemon',
> ++                               '/usr/sbin/dbus-daemon',
> ++                               '/libexec/dbus-daemon',
> ++                               '/usr/libexec/dbus-daemon',
> ++                               '/usr/lib/dbus-daemon',
> ++                               '/usr/pkg/bin/dbus-daemon',
> ++                               required: false)
> ++    if dbus_daemon.found()
> ++      launcher_args += '-DDBUS_DAEMON="@0@"'.format(dbus_daemon.full_path())
> ++    endif
> ++  endif
> + else
> +-  dbus_broker = find_program('dbus-broker-launch',
> +-                             required: false)
> +-  if dbus_broker.found()
> +-    launcher_args += '-DDBUS_BROKER="@0@"'.format(dbus_broker.full_path())
> ++  launcher_args += '-DWANT_DBUS_BROKER'
> ++  if get_option('dbus_broker') != 'default'
> ++    launcher_args += '-DDBUS_BROKER="@0@"'.format(get_option('dbus_broker'))
> +     needs_systemd = true
> ++  else
> ++    dbus_broker = find_program('dbus-broker-launch',
> ++                               required: false)
> ++    if dbus_broker.found()
> ++      launcher_args += '-DDBUS_BROKER="@0@"'.format(dbus_broker.full_path())
> ++      needs_systemd = true
> ++    endif
> +   endif
> + endif
> + 
> +-if get_option('default_bus') == 'dbus-broker'
> +-  launcher_args += '-DWANT_DBUS_BROKER'
> +-endif
> +-
> + if needs_systemd
> +   systemd_dep = dependency('libsystemd')
> + else
> +-- 
> +2.34.1
> +
> diff --git a/package/at-spi2-core/Config.in b/package/at-spi2-core/Config.in
> index f56c5b93c4..2a1b21d375 100644
> --- a/package/at-spi2-core/Config.in
> +++ b/package/at-spi2-core/Config.in
> @@ -1,12 +1,13 @@
>  config BR2_PACKAGE_AT_SPI2_CORE
>  	bool "at-spi2-core"
> -	depends on BR2_PACKAGE_XORG7 # xlib-libxtst
>  	depends on BR2_TOOLCHAIN_HAS_THREADS # dbus, glib2
>  	depends on BR2_USE_MMU # glib2
>  	depends on BR2_USE_WCHAR # glib2
> +	depends on !BR2_STATIC_LIBS # dlopen()
>  	select BR2_PACKAGE_DBUS
>  	select BR2_PACKAGE_LIBGLIB2
> -	select BR2_PACKAGE_XLIB_LIBXTST
> +	select BR2_PACKAGE_LIBXML2
> +	select BR2_PACKAGE_XLIB_LIBXTST if BR2_PACKAGE_XORG7 # optionally for X11
>  	help
>  	  The At-Spi2 Core package is a part of the GNOME
>  	  Accessibility Project. It provides a Service Provider
> @@ -16,10 +17,6 @@ config BR2_PACKAGE_AT_SPI2_CORE
>  
>  	  https://wiki.gnome.org/Accessibility
>  
> -comment "at-spi2-core needs a toolchain w/ wchar, threads"
> +comment "at-spi2-core needs a toolchain w/ dynamic library, wchar, threads"
>  	depends on BR2_USE_MMU
> -	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
> -
> -comment "at-spi2-core depends on X.org"
> -	depends on BR2_USE_MMU
> -	depends on !BR2_PACKAGE_XORG7
> +	depends on BR2_STATIC_LIBS || !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
> diff --git a/package/at-spi2-core/at-spi2-core.hash b/package/at-spi2-core/at-spi2-core.hash
> index 764e4c3661..9cf80d1cc0 100644
> --- a/package/at-spi2-core/at-spi2-core.hash
> +++ b/package/at-spi2-core/at-spi2-core.hash
> @@ -1,5 +1,5 @@
> -# From https://download.gnome.org/sources/at-spi2-core/2.36/at-spi2-core-2.36.0.sha256sum
> -sha256  88da57de0a7e3c60bc341a974a80fdba091612db3547c410d6deab039ca5c05a  at-spi2-core-2.36.0.tar.xz
> +# From https://download.gnome.org/sources/at-spi2-core/2.48/at-spi2-core-2.48.0.sha256sum
> +sha256  905a5b6f1790b68ee803bffa9f5fab4ceb591fb4fae0b2f8c612c54f1d4e8a30  at-spi2-core-2.48.0.tar.xz
>  
>  # locally calculated
>  sha256  dc626520dcd53a22f727af3ee42c770e56c97a64fe3adb063799d8ab032fe551  COPYING
> diff --git a/package/at-spi2-core/at-spi2-core.mk b/package/at-spi2-core/at-spi2-core.mk
> index f0b019c0ed..e4489f6f88 100644
> --- a/package/at-spi2-core/at-spi2-core.mk
> +++ b/package/at-spi2-core/at-spi2-core.mk
> @@ -4,17 +4,31 @@
>  #
>  ################################################################################
>  
> -AT_SPI2_CORE_VERSION_MAJOR = 2.36
> +AT_SPI2_CORE_VERSION_MAJOR = 2.48
>  AT_SPI2_CORE_VERSION = $(AT_SPI2_CORE_VERSION_MAJOR).0
>  AT_SPI2_CORE_SOURCE = at-spi2-core-$(AT_SPI2_CORE_VERSION).tar.xz
>  AT_SPI2_CORE_SITE = https://download.gnome.org/sources/at-spi2-core/$(AT_SPI2_CORE_VERSION_MAJOR)
>  AT_SPI2_CORE_LICENSE = LGPL-2.1+
>  AT_SPI2_CORE_LICENSE_FILES = COPYING
>  AT_SPI2_CORE_INSTALL_STAGING = YES
> -AT_SPI2_CORE_DEPENDENCIES = host-pkgconf dbus libglib2 xlib_libXtst \
> +AT_SPI2_CORE_DEPENDENCIES = host-pkgconf dbus libglib2 libxml2 \
>  	$(TARGET_NLS_DEPENDENCIES)
>  AT_SPI2_CORE_CONF_OPTS = -Ddbus_daemon=/usr/bin/dbus-daemon
>  
> +ifeq ($(BR2_PACKAGE_XORG7),y)
> +AT_SPI2_CORE_CONF_OPTS += -Dx11=enabled
> +AT_SPI2_CORE_DEPENDENCIES += xlib_libXtst
> +else
> +AT_SPI2_CORE_CONF_OPTS += -Dx11=disabled
> +endif
> +
> +ifeq ($(BR2_PACKAGE_GOBJECT_INTROSPECTION),y)
> +AT_SPI2_CORE_CONF_OPTS += -Dintrospection=enabled
> +AT_SPI2_CORE_DEPENDENCIES += gobject-introspection
> +else
> +AT_SPI2_CORE_CONF_OPTS += -Dintrospection=disabled
> +endif
> +
>  AT_SPI2_CORE_LDFLAGS = $(TARGET_LDFLAGS) $(TARGET_NLS_LIBS)
>  
>  $(eval $(meson-package))
> -- 
> 2.34.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
> 

Cheers,
—Adrián

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [Buildroot] [PATCH v7 2/5] package/at-spi2-atk: remove package
  2023-04-28  7:59 ` [Buildroot] [PATCH v7 2/5] package/at-spi2-atk: remove package Thomas Devoogdt
@ 2023-05-05 11:56   ` Adrian Perez de Castro
  0 siblings, 0 replies; 14+ messages in thread
From: Adrian Perez de Castro @ 2023-05-05 11:56 UTC (permalink / raw)
  To: Thomas Devoogdt
  Cc: Joseph Kogut, Daniel Lang, Thomas Devoogdt, James Knight,
	buildroot, Fabrice Fontaine


[-- Attachment #1.1: Type: text/plain, Size: 7278 bytes --]

On Fri, 28 Apr 2023 09:59:17 +0200 Thomas Devoogdt <thomas@devoogdt.com> wrote:
> From: Daniel Lang <d.lang@abatec.at>
> 
> at-spi2-atk has been merged into at-spi2-core with version 2.45.1.
> 
> https://gitlab.gnome.org/GNOME/at-spi2-core/-/blob/AT_SPI2_CORE_2_45_1/NEWS
> https://gitlab.gnome.org/GNOME/at-spi2-core/-/merge_requests/78
> 
> Signed-off-by: Daniel Lang <d.lang@abatec.at>
> Signed-off-by: Thomas Devoogdt <thomas.devoogdt@barco.com>
> Tested-by: Adrian Perez de Castro <aperez@igalia.com>

Reviewed-by: Adrian Perez de Castro <aperez@igalia.com>

> ---
> v3:
>  - rebased on https://patchwork.ozlabs.org/project/buildroot/list/?series=336254
>  - needed to fix the webkitgtk 2.38.5 compilation
>    (https://patchwork.ozlabs.org/project/buildroot/patch/20230220090923.2155635-2-thomas.devoogdt@barco.com/)
> v5: rebased + grouped patches
> v6: no change
> v7: no change
> ---
>  Config.in.legacy                              |  7 +++
>  DEVELOPERS                                    |  1 -
>  package/Config.in                             |  1 -
>  .../0001-meson-add-tests-option.patch         | 43 -------------------
>  package/at-spi2-atk/Config.in                 | 22 ----------
>  package/at-spi2-atk/at-spi2-atk.hash          |  5 ---
>  package/at-spi2-atk/at-spi2-atk.mk            | 19 --------
>  7 files changed, 7 insertions(+), 91 deletions(-)
>  delete mode 100644 package/at-spi2-atk/0001-meson-add-tests-option.patch
>  delete mode 100644 package/at-spi2-atk/Config.in
>  delete mode 100644 package/at-spi2-atk/at-spi2-atk.hash
>  delete mode 100644 package/at-spi2-atk/at-spi2-atk.mk
> 
> diff --git a/Config.in.legacy b/Config.in.legacy
> index 366b9d6949..db75899a9b 100644
> --- a/Config.in.legacy
> +++ b/Config.in.legacy
> @@ -146,6 +146,13 @@ endif
>  
>  comment "Legacy options removed in 2023.05"
>  
> +config BR2_PACKAGE_AT_SPI2_ATK
> +	bool "at-spi2-atk removed"
> +	select BR2_LEGACY
> +	select BR2_PACKAGE_AT_SPI2_CORE
> +	help
> +	  at-spi2-atk is now part of at-spi2-core.
> +
>  config BR2_PACAKGE_OPENFPGALOADER_CMSIS
>  	bool "openfpgaloader cmsis option name fixed"
>  	select BR2_LEGACY
> diff --git a/DEVELOPERS b/DEVELOPERS
> index d9e95a3d05..9206659428 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -1632,7 +1632,6 @@ F:	support/testing/tests/package/test_avocado.py
>  F:	support/testing/tests/package/test_python_aexpect.py
>  
>  N:	Joseph Kogut <joseph.kogut@gmail.com>
> -F:	package/at-spi2-atk/
>  F:	package/at-spi2-core/
>  F:	package/clang/
>  F:	package/earlyoom/
> diff --git a/package/Config.in b/package/Config.in
> index eaac32a01a..70c5c2eea8 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -1554,7 +1554,6 @@ endmenu
>  
>  menu "Graphics"
>  	source "package/assimp/Config.in"
> -	source "package/at-spi2-atk/Config.in"
>  	source "package/at-spi2-core/Config.in"
>  	source "package/atk/Config.in"
>  	source "package/atkmm/Config.in"
> diff --git a/package/at-spi2-atk/0001-meson-add-tests-option.patch b/package/at-spi2-atk/0001-meson-add-tests-option.patch
> deleted file mode 100644
> index 3a2aefa090..0000000000
> --- a/package/at-spi2-atk/0001-meson-add-tests-option.patch
> +++ /dev/null
> @@ -1,43 +0,0 @@
> -From 466d04a57b32417dbf2d5e818af1b7593af5f802 Mon Sep 17 00:00:00 2001
> -From: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> -Date: Sun, 3 May 2020 10:29:36 +0200
> -Subject: [PATCH] meson: add tests option
> -
> -Add tests option to allow the user to build at-spi2-atk without tests,
> -it is especially useful as one of the test requires libxml-2.0
> -
> -Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> -[Upstream status:
> -https://gitlab.gnome.org/GNOME/at-spi2-atk/-/merge_requests/22]
> ----
> - meson.build       | 4 +++-
> - meson_options.txt | 4 ++++
> - 2 files changed, 7 insertions(+), 1 deletion(-)
> -
> -diff --git a/meson.build b/meson.build
> -index 9fce5d6..61bc93d 100644
> ---- a/meson.build
> -+++ b/meson.build
> -@@ -61,4 +61,6 @@ install_data('at-spi2-atk.desktop',
> - 
> - subdir('droute')
> - subdir('atk-adaptor')
> --subdir('tests')
> -+if get_option('tests')
> -+  subdir('tests')
> -+endif
> -diff --git a/meson_options.txt b/meson_options.txt
> -index 24c9228..a4abdc2 100644
> ---- a/meson_options.txt
> -+++ b/meson_options.txt
> -@@ -2,3 +2,7 @@ option('disable_p2p',
> -        description: 'Disable peer-to-peer DBus connections',
> -        type: 'boolean',
> -        value: false)
> -+option('tests',
> -+       description: 'Whether to build tests',
> -+       type: 'boolean',
> -+       value: true)
> --- 
> -2.26.2
> -
> diff --git a/package/at-spi2-atk/Config.in b/package/at-spi2-atk/Config.in
> deleted file mode 100644
> index 9a7cfde0af..0000000000
> --- a/package/at-spi2-atk/Config.in
> +++ /dev/null
> @@ -1,22 +0,0 @@
> -config BR2_PACKAGE_AT_SPI2_ATK
> -	bool "at-spi2-atk"
> -	depends on BR2_PACKAGE_XORG7 # at-spi2-core
> -	depends on BR2_TOOLCHAIN_HAS_THREADS # glib2
> -	depends on BR2_USE_MMU # glib2
> -	depends on BR2_USE_WCHAR # glib2
> -	select BR2_PACKAGE_ATK
> -	select BR2_PACKAGE_AT_SPI2_CORE
> -	select BR2_PACKAGE_LIBGLIB2
> -	help
> -	  The At-Spi2 Atk package contains a library that bridges
> -	  ATK to At-Spi2 D-Bus service.
> -
> -	  https://www.freedesktop.org/wiki/Accessibility/AT-SPI2/
> -
> -comment "at-spi2-atk needs a toolchain w/ wchar, threads"
> -	depends on BR2_USE_MMU
> -	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
> -
> -comment "at-spi2-atk depends on X.org"
> -	depends on BR2_USE_MMU
> -	depends on !BR2_PACKAGE_XORG7
> diff --git a/package/at-spi2-atk/at-spi2-atk.hash b/package/at-spi2-atk/at-spi2-atk.hash
> deleted file mode 100644
> index 9c564c32af..0000000000
> --- a/package/at-spi2-atk/at-spi2-atk.hash
> +++ /dev/null
> @@ -1,5 +0,0 @@
> -# From http://ftp.acc.umu.se/pub/gnome/sources/at-spi2-atk/2.34/at-spi2-atk-2.34.2.sha256sum
> -sha256  901323cee0eef05c01ec4dee06c701aeeca81a314a7d60216fa363005e27f4f0  at-spi2-atk-2.34.2.tar.xz
> -
> -# locally calculated
> -sha256  dc626520dcd53a22f727af3ee42c770e56c97a64fe3adb063799d8ab032fe551  COPYING
> diff --git a/package/at-spi2-atk/at-spi2-atk.mk b/package/at-spi2-atk/at-spi2-atk.mk
> deleted file mode 100644
> index 232b577230..0000000000
> --- a/package/at-spi2-atk/at-spi2-atk.mk
> +++ /dev/null
> @@ -1,19 +0,0 @@
> -################################################################################
> -#
> -# at-spi2-atk
> -#
> -################################################################################
> -
> -AT_SPI2_ATK_VERSION_MAJOR = 2.34
> -AT_SPI2_ATK_VERSION = $(AT_SPI2_ATK_VERSION_MAJOR).2
> -AT_SPI2_ATK_SOURCE = at-spi2-atk-$(AT_SPI2_ATK_VERSION).tar.xz
> -AT_SPI2_ATK_SITE = \
> -	http://ftp.gnome.org/pub/gnome/sources/at-spi2-atk/$(AT_SPI2_ATK_VERSION_MAJOR)
> -AT_SPI2_ATK_LICENSE = LGPL-2.1+
> -AT_SPI2_ATK_LICENSE_FILES = COPYING
> -AT_SPI2_ATK_CPE_ID_VENDOR = gnome
> -AT_SPI2_ATK_INSTALL_STAGING = YES
> -AT_SPI2_ATK_DEPENDENCIES = atk at-spi2-core libglib2 host-pkgconf
> -AT_SPI2_ATK_CONF_OPTS = -Dtests=false
> -
> -$(eval $(meson-package))
> -- 
> 2.34.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
> 

Cheers,
—Adrián

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [Buildroot] [PATCH v7 3/5] package/atk: remove package
  2023-04-28  7:59 ` [Buildroot] [PATCH v7 3/5] package/atk: " Thomas Devoogdt
@ 2023-05-05 11:56   ` Adrian Perez de Castro
  0 siblings, 0 replies; 14+ messages in thread
From: Adrian Perez de Castro @ 2023-05-05 11:56 UTC (permalink / raw)
  To: Thomas Devoogdt
  Cc: Joseph Kogut, Daniel Lang, Thomas Devoogdt, James Knight,
	buildroot, Fabrice Fontaine


[-- Attachment #1.1: Type: text/plain, Size: 11182 bytes --]

On Fri, 28 Apr 2023 09:59:18 +0200 Thomas Devoogdt <thomas@devoogdt.com> wrote:
> From: Daniel Lang <d.lang@abatec.at>
> 
> atk has been merged into at-spi2-core with version 2.45.1.
> 
> https://gitlab.gnome.org/GNOME/at-spi2-core/-/blob/AT_SPI2_CORE_2_45_1/NEWS
> https://gitlab.gnome.org/GNOME/at-spi2-core/-/merge_requests/78
> 
> Signed-off-by: Daniel Lang <d.lang@abatec.at>
> Signed-off-by: Thomas Devoogdt <thomas.devoogdt@barco.com>
> Tested-by: Adrian Perez de Castro <aperez@igalia.com>

Reviewed-by: Adrian Perez de Castro <aperez@igalia.com>

> ---
> v3:
>  - rebased on https://patchwork.ozlabs.org/project/buildroot/list/?series=336254
>  - needed to fix the webkitgtk 2.38.5 compilation
>    (https://patchwork.ozlabs.org/project/buildroot/patch/20230220090923.2155635-2-thomas.devoogdt@barco.com/)
> v5: rebased + grouped patches
> v6: added change to atkmm2_28
> v7: no change
> ---
>  Config.in.legacy               |  7 +++++++
>  package/Config.in              |  1 -
>  package/atk/Config.in          | 14 --------------
>  package/atk/atk.hash           |  5 -----
>  package/atk/atk.mk             | 25 -------------------------
>  package/atkmm/Config.in        |  8 ++++----
>  package/atkmm/atkmm.mk         |  2 +-
>  package/atkmm2_28/Config.in    |  8 ++++----
>  package/atkmm2_28/atkmm2_28.mk |  2 +-
>  package/libglade/Config.in     |  2 +-
>  package/libglade/libglade.mk   |  2 +-
>  package/libgtk2/Config.in      |  2 +-
>  package/libgtk2/libgtk2.mk     |  2 +-
>  package/libgtk3/Config.in      |  2 +-
>  package/libgtk3/libgtk3.mk     |  2 +-
>  15 files changed, 23 insertions(+), 61 deletions(-)
>  delete mode 100644 package/atk/Config.in
>  delete mode 100644 package/atk/atk.hash
>  delete mode 100644 package/atk/atk.mk
> 
> diff --git a/Config.in.legacy b/Config.in.legacy
> index db75899a9b..d86a7e6363 100644
> --- a/Config.in.legacy
> +++ b/Config.in.legacy
> @@ -146,6 +146,13 @@ endif
>  
>  comment "Legacy options removed in 2023.05"
>  
> +config BR2_PACKAGE_ATK
> +	bool "atk removed"
> +	select BR2_LEGACY
> +	select BR2_PACKAGE_AT_SPI2_CORE
> +	help
> +	  atk is now part of at-spi2-core.
> +
>  config BR2_PACKAGE_AT_SPI2_ATK
>  	bool "at-spi2-atk removed"
>  	select BR2_LEGACY
> diff --git a/package/Config.in b/package/Config.in
> index 70c5c2eea8..6a92573d39 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -1555,7 +1555,6 @@ endmenu
>  menu "Graphics"
>  	source "package/assimp/Config.in"
>  	source "package/at-spi2-core/Config.in"
> -	source "package/atk/Config.in"
>  	source "package/atkmm/Config.in"
>  	source "package/atkmm2_28/Config.in"
>  	source "package/bayer2rgb-neon/Config.in"
> diff --git a/package/atk/Config.in b/package/atk/Config.in
> deleted file mode 100644
> index d9371b879b..0000000000
> --- a/package/atk/Config.in
> +++ /dev/null
> @@ -1,14 +0,0 @@
> -config BR2_PACKAGE_ATK
> -	bool "atk"
> -	depends on BR2_USE_WCHAR # glib2
> -	depends on BR2_TOOLCHAIN_HAS_THREADS # glib2
> -	depends on BR2_USE_MMU # glib2
> -	select BR2_PACKAGE_LIBGLIB2
> -	help
> -	  The ATK accessibility toolkit, needed to build GTK+-2.x.
> -
> -	  https://gitlab.gnome.org/GNOME/atk
> -
> -comment "atk needs a toolchain w/ wchar, threads"
> -	depends on BR2_USE_MMU
> -	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
> diff --git a/package/atk/atk.hash b/package/atk/atk.hash
> deleted file mode 100644
> index d8cd69ff1f..0000000000
> --- a/package/atk/atk.hash
> +++ /dev/null
> @@ -1,5 +0,0 @@
> -# From http://ftp.gnome.org/pub/gnome/sources/atk/2.38/atk-2.38.0.sha256sum
> -sha256  ac4de2a4ef4bd5665052952fe169657e65e895c5057dffb3c2a810f6191a0c36  atk-2.38.0.tar.xz
> -
> -# Hash for license file
> -sha256  d245807f90032872d1438d741ed21e2490e1175dc8aa3afa5ddb6c8e529b58e5  COPYING
> diff --git a/package/atk/atk.mk b/package/atk/atk.mk
> deleted file mode 100644
> index 2820fb486d..0000000000
> --- a/package/atk/atk.mk
> +++ /dev/null
> @@ -1,25 +0,0 @@
> -################################################################################
> -#
> -# atk
> -#
> -################################################################################
> -
> -ATK_VERSION_MAJOR = 2.38
> -ATK_VERSION = $(ATK_VERSION_MAJOR).0
> -ATK_SOURCE = atk-$(ATK_VERSION).tar.xz
> -ATK_SITE = http://ftp.gnome.org/pub/gnome/sources/atk/$(ATK_VERSION_MAJOR)
> -ATK_LICENSE = LGPL-2.0+
> -ATK_LICENSE_FILES = COPYING
> -ATK_INSTALL_STAGING = YES
> -ATK_DEPENDENCIES = libglib2 $(TARGET_NLS_DEPENDENCIES)
> -
> -ifeq ($(BR2_PACKAGE_GOBJECT_INTROSPECTION),y)
> -ATK_CONF_OPTS += -Dintrospection=true
> -ATK_DEPENDENCIES += gobject-introspection
> -else
> -ATK_CONF_OPTS += -Dintrospection=false
> -endif
> -
> -ATK_LDFLAGS = $(TARGET_LDFLAGS) $(TARGET_NLS_LIBS)
> -
> -$(eval $(meson-package))
> diff --git a/package/atkmm/Config.in b/package/atkmm/Config.in
> index 1f370356ea..571d7e69ad 100644
> --- a/package/atkmm/Config.in
> +++ b/package/atkmm/Config.in
> @@ -2,10 +2,10 @@ config BR2_PACKAGE_ATKMM
>  	bool "atkmm (latest)"
>  	depends on BR2_INSTALL_LIBSTDCPP # glibmm
>  	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_7 # libsigc
> -	depends on BR2_TOOLCHAIN_HAS_THREADS # atk/glibmm -> libglib2
> -	depends on BR2_USE_MMU # atk/glibmm -> libglib2
> -	depends on BR2_USE_WCHAR # atk/glibmm -> libglib2
> -	select BR2_PACKAGE_ATK
> +	depends on BR2_TOOLCHAIN_HAS_THREADS # at-spi2-core/glibmm -> libglib2
> +	depends on BR2_USE_MMU # at-spi2-core/glibmm -> libglib2
> +	depends on BR2_USE_WCHAR # at-spi2-core/glibmm -> libglib2
> +	select BR2_PACKAGE_AT_SPI2_CORE
>  	select BR2_PACKAGE_GLIBMM
>  	select BR2_PACKAGE_LIBSIGC
>  
> diff --git a/package/atkmm/atkmm.mk b/package/atkmm/atkmm.mk
> index 7ceb87b047..da763c8386 100644
> --- a/package/atkmm/atkmm.mk
> +++ b/package/atkmm/atkmm.mk
> @@ -11,6 +11,6 @@ ATKMM_SITE = https://download.gnome.org/sources/atkmm/$(ATKMM_VERSION_MAJOR)
>  ATKMM_LICENSE = LGPL-2.1+ (library), GPL-2.0+ (tools)
>  ATKMM_LICENSE_FILES = COPYING COPYING.tools
>  ATKMM_INSTALL_STAGING = YES
> -ATKMM_DEPENDENCIES = atk glibmm libsigc host-pkgconf
> +ATKMM_DEPENDENCIES = at-spi2-core glibmm libsigc host-pkgconf
>  
>  $(eval $(meson-package))
> diff --git a/package/atkmm2_28/Config.in b/package/atkmm2_28/Config.in
> index 2340465b20..e88073b87a 100644
> --- a/package/atkmm2_28/Config.in
> +++ b/package/atkmm2_28/Config.in
> @@ -2,10 +2,10 @@ config BR2_PACKAGE_ATKMM2_28
>  	bool "atkmm (2.28.x)"
>  	depends on BR2_INSTALL_LIBSTDCPP # glibmm
>  	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # C++11
> -	depends on BR2_TOOLCHAIN_HAS_THREADS # atk/glibmm -> libglib2
> -	depends on BR2_USE_MMU # atk/glibmm -> libglib2
> -	depends on BR2_USE_WCHAR # atk/glibmm -> libglib2
> -	select BR2_PACKAGE_ATK
> +	depends on BR2_TOOLCHAIN_HAS_THREADS # at-spi2-core/glibmm -> libglib2
> +	depends on BR2_USE_MMU # at-spi2-core/glibmm -> libglib2
> +	depends on BR2_USE_WCHAR # at-spi2-core/glibmm -> libglib2
> +	select BR2_PACKAGE_AT_SPI2_CORE
>  	select BR2_PACKAGE_GLIBMM2_66
>  	select BR2_PACKAGE_LIBSIGC2
>  
> diff --git a/package/atkmm2_28/atkmm2_28.mk b/package/atkmm2_28/atkmm2_28.mk
> index dc57363cf5..b56da61ec0 100644
> --- a/package/atkmm2_28/atkmm2_28.mk
> +++ b/package/atkmm2_28/atkmm2_28.mk
> @@ -11,6 +11,6 @@ ATKMM2_28_SITE = https://download.gnome.org/sources/atkmm/$(ATKMM2_28_VERSION_MA
>  ATKMM2_28_LICENSE = LGPL-2.1+ (library), GPL-2.0+ (tools)
>  ATKMM2_28_LICENSE_FILES = COPYING COPYING.tools
>  ATKMM2_28_INSTALL_STAGING = YES
> -ATKMM2_28_DEPENDENCIES = atk glibmm2_66 libsigc2 host-pkgconf
> +ATKMM2_28_DEPENDENCIES = at-spi2-core glibmm2_66 libsigc2 host-pkgconf
>  
>  $(eval $(meson-package))
> diff --git a/package/libglade/Config.in b/package/libglade/Config.in
> index c97c9becd2..8d0d26f159 100644
> --- a/package/libglade/Config.in
> +++ b/package/libglade/Config.in
> @@ -5,7 +5,7 @@ config BR2_PACKAGE_LIBGLADE
>  	depends on BR2_TOOLCHAIN_HAS_THREADS # glib2
>  	depends on BR2_USE_MMU # glib2
>  	select BR2_PACKAGE_LIBGLIB2
> -	select BR2_PACKAGE_ATK
> +	select BR2_PACKAGE_AT_SPI2_CORE
>  	select BR2_PACKAGE_LIBXML2
>  	help
>  	  Libglade allows you to load glade interface files in a program
> diff --git a/package/libglade/libglade.mk b/package/libglade/libglade.mk
> index 21aed60605..af73d8bd00 100644
> --- a/package/libglade/libglade.mk
> +++ b/package/libglade/libglade.mk
> @@ -9,7 +9,7 @@ LIBGLADE_VERSION = $(LIBGLADE_VERSION_MAJOR).4
>  LIBGLADE_SOURCE = libglade-$(LIBGLADE_VERSION).tar.bz2
>  LIBGLADE_SITE = https://download.gnome.org/sources/libglade/$(LIBGLADE_VERSION_MAJOR)
>  LIBGLADE_INSTALL_STAGING = YES
> -LIBGLADE_DEPENDENCIES = host-pkgconf libglib2 libgtk2 atk libxml2
> +LIBGLADE_DEPENDENCIES = host-pkgconf libglib2 libgtk2 at-spi2-core libxml2
>  LIBGLADE_LICENSE = LGPL-2.0+
>  LIBGLADE_LICENSE_FILES = COPYING
>  
> diff --git a/package/libgtk2/Config.in b/package/libgtk2/Config.in
> index c75c37fb63..f2888b2f51 100644
> --- a/package/libgtk2/Config.in
> +++ b/package/libgtk2/Config.in
> @@ -7,7 +7,7 @@ config BR2_PACKAGE_LIBGTK2
>  	depends on BR2_INSTALL_LIBSTDCPP # pango
>  	depends on BR2_TOOLCHAIN_HAS_SYNC_4 # pango -> harfbuzz
>  	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # pango -> harfbuzz
> -	select BR2_PACKAGE_ATK
> +	select BR2_PACKAGE_AT_SPI2_CORE
>  	select BR2_PACKAGE_CAIRO
>  	select BR2_PACKAGE_CAIRO_PS
>  	select BR2_PACKAGE_CAIRO_PDF
> diff --git a/package/libgtk2/libgtk2.mk b/package/libgtk2/libgtk2.mk
> index 859925e8d3..608c263e4d 100644
> --- a/package/libgtk2/libgtk2.mk
> +++ b/package/libgtk2/libgtk2.mk
> @@ -23,7 +23,7 @@ LIBGTK2_CONF_ENV = \
>  
>  LIBGTK2_CONF_OPTS = --disable-glibtest --enable-explicit-deps=no
>  
> -LIBGTK2_DEPENDENCIES = host-pkgconf host-libgtk2 libglib2 cairo pango atk \
> +LIBGTK2_DEPENDENCIES = host-pkgconf host-libgtk2 libglib2 cairo pango at-spi2-core \
>  	gdk-pixbuf $(TARGET_NLS_DEPENDENCIES)
>  
>  LIBGTK2_MAKE_OPTS = LIBS=$(TARGET_NLS_LIBS)
> diff --git a/package/libgtk3/Config.in b/package/libgtk3/Config.in
> index 82ca68d2da..34b8d49eb3 100644
> --- a/package/libgtk3/Config.in
> +++ b/package/libgtk3/Config.in
> @@ -23,7 +23,7 @@ config BR2_PACKAGE_LIBGTK3
>  	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # pango -> harfbuzz
>  	depends on BR2_PACKAGE_HAS_LIBEGL_WAYLAND || \
>  		BR2_PACKAGE_HAS_LIBGL
> -	select BR2_PACKAGE_ATK
> +	select BR2_PACKAGE_AT_SPI2_CORE
>  	select BR2_PACKAGE_CAIRO
>  	select BR2_PACKAGE_CAIRO_PS
>  	select BR2_PACKAGE_CAIRO_PDF
> diff --git a/package/libgtk3/libgtk3.mk b/package/libgtk3/libgtk3.mk
> index 18a8a9fa42..bdd54dcdc8 100644
> --- a/package/libgtk3/libgtk3.mk
> +++ b/package/libgtk3/libgtk3.mk
> @@ -14,7 +14,7 @@ LIBGTK3_CPE_ID_VENDOR = gnome
>  LIBGTK3_CPE_ID_PRODUCT = gtk
>  LIBGTK3_INSTALL_STAGING = YES
>  
> -LIBGTK3_DEPENDENCIES = host-pkgconf host-libgtk3 atk libglib2 cairo pango \
> +LIBGTK3_DEPENDENCIES = host-pkgconf host-libgtk3 at-spi2-core libglib2 cairo pango \
>  	gdk-pixbuf libepoxy $(TARGET_NLS_DEPENDENCIES)
>  
>  ifeq ($(BR2_PACKAGE_LIBGTK3_X11),y)
> -- 
> 2.34.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
> 

Cheers,
—Adrián

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [Buildroot] [PATCH v7 4/5] package/libgtk3: re-enable atk-bridge
  2023-04-28  7:59 ` [Buildroot] [PATCH v7 4/5] package/libgtk3: re-enable atk-bridge Thomas Devoogdt
@ 2023-05-05 11:57   ` Adrian Perez de Castro
  0 siblings, 0 replies; 14+ messages in thread
From: Adrian Perez de Castro @ 2023-05-05 11:57 UTC (permalink / raw)
  To: Thomas Devoogdt
  Cc: Joseph Kogut, Thomas Devoogdt, Daniel Lang, Thomas Devoogdt,
	James Knight, buildroot, Fabrice Fontaine


[-- Attachment #1.1: Type: text/plain, Size: 2711 bytes --]

On Fri, 28 Apr 2023 09:59:19 +0200 Thomas Devoogdt <thomas@devoogdt.com> wrote:
> The at-spi2-core and at-spi2-atk were merged, and are now built by default,
> so this patch is no longer required.
> 
> Signed-off-by: Thomas Devoogdt <thomas.devoogdt@barco.com>
> Tested-by: Adrian Perez de Castro <aperez@igalia.com>

Reviewed-by: Adrian Perez de Castro <aperez@igalia.com>

> ---
> v5: added re-enable atk-bridge patch to the package/at-spi2-core: bump to version 2.47.1 group
> v6: no change
> v7: no change
> ---
>  package/libgtk3/0001-disable-atk-bridge.patch | 41 -------------------
>  1 file changed, 41 deletions(-)
>  delete mode 100644 package/libgtk3/0001-disable-atk-bridge.patch
> 
> diff --git a/package/libgtk3/0001-disable-atk-bridge.patch b/package/libgtk3/0001-disable-atk-bridge.patch
> deleted file mode 100644
> index f3e9bff2ba..0000000000
> --- a/package/libgtk3/0001-disable-atk-bridge.patch
> +++ /dev/null
> @@ -1,41 +0,0 @@
> -Remove atk-bridge support.
> -
> -atk-bridge doesn't seem useful for now in Buildroot and requires to
> -add two new packages just for it: at-spi2-core and at-spi2-atk.
> -
> -Signed-off-by: Hadrien Boutteville <hadrien.boutteville@gmail.com>
> -
> ---- a/gtk/a11y/gtkaccessibility.c
> -+++ b/gtk/a11y/gtkaccessibility.c
> -@@ -37,10 +37,6 @@
> - #include <gtk/gtktogglebutton.h>
> - #include <gtk/gtkaccessible.h>
> -
> --#ifdef GDK_WINDOWING_X11
> --#include <atk-bridge.h>
> --#endif
> --
> - static gboolean gail_focus_watcher      (GSignalInvocationHint *ihint,
> -                                          guint                  n_param_values,
> -                                          const GValue          *param_values,
> -@@ -988,9 +984,5 @@ _gtk_accessibility_init (void)
> -   _gtk_accessibility_override_atk_util ();
> -   do_window_event_initialization ();
> -
> --#ifdef GDK_WINDOWING_X11
> --  atk_bridge_adaptor_init (NULL, NULL);
> --#endif
> --
> -   atk_misc_instance = g_object_new (GTK_TYPE_MISC_IMPL, NULL);
> - }
> ---- a/meson.build
> -+++ b/meson.build
> -@@ -564,7 +564,7 @@ if x11_enabled
> -   xfixes_dep     = dependency('xfixes', required: false)
> -   xcomposite_dep = dependency('xcomposite', required: false)
> -   fontconfig_dep = dependency('fontconfig', fallback: ['fontconfig', 'fontconfig_dep'])
> --  atkbridge_dep  = dependency('atk-bridge-2.0', version: at_spi2_atk_req)
> -+  atkbridge_dep  = dependency('atk-bridge-2.0', version: at_spi2_atk_req, required: false)
> - 
> -   backend_immodules += ['xim']
> - 
> -- 
> 2.34.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
> 

Cheers,
—Adrián

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [Buildroot] [PATCH v7 5/5] package/libgtk3: fix update-icon-cache on empty directory
  2023-04-28  7:59 ` [Buildroot] [PATCH v7 5/5] package/libgtk3: fix update-icon-cache on empty directory Thomas Devoogdt
@ 2023-05-05 11:57   ` Adrian Perez de Castro
  0 siblings, 0 replies; 14+ messages in thread
From: Adrian Perez de Castro @ 2023-05-05 11:57 UTC (permalink / raw)
  To: Thomas Devoogdt
  Cc: Joseph Kogut, Thomas Devoogdt, Daniel Lang, Thomas Devoogdt,
	James Knight, buildroot, Fabrice Fontaine


[-- Attachment #1.1: Type: text/plain, Size: 1562 bytes --]

On Fri, 28 Apr 2023 09:59:20 +0200 Thomas Devoogdt <thomas@devoogdt.com> wrote:
> If both, hicolor-icon-theme (selected by libgtk3-demo) and
> adwaita-icon-theme is not selected, then the /usr/share/icons
> folder is empty, causing find to fail.
> 
> Signed-off-by: Thomas Devoogdt <thomas.devoogdt@barco.com>
> Tested-by: Adrian Perez de Castro <aperez@igalia.com>

Reviewed-by: Adrian Perez de Castro <aperez@igalia.com>

> ---
> v5: 
>  - Fixed indentation.
>  - Grouped patches.
> v6: no change
> v7: no change
> ---
>  package/libgtk3/libgtk3.mk | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/package/libgtk3/libgtk3.mk b/package/libgtk3/libgtk3.mk
> index bdd54dcdc8..eac569fd41 100644
> --- a/package/libgtk3/libgtk3.mk
> +++ b/package/libgtk3/libgtk3.mk
> @@ -146,8 +146,9 @@ endef
>  # Create icon-theme.cache for each of the icon directories/themes
>  # It's not strictly necessary but speeds up lookups
>  define LIBGTK3_UPDATE_ICON_CACHE
> -	find $(TARGET_DIR)/usr/share/icons -maxdepth 1 -mindepth 1 -type d \
> -		-exec $(HOST_DIR)/bin/gtk-update-icon-cache {} \;
> +	[ ! -d $(TARGET_DIR)/usr/share/icons ] || \
> +		find $(TARGET_DIR)/usr/share/icons -maxdepth 1 -mindepth 1 -type d \
> +			-exec $(HOST_DIR)/bin/gtk-update-icon-cache {} \;
>  endef
>  LIBGTK3_TARGET_FINALIZE_HOOKS += LIBGTK3_UPDATE_ICON_CACHE
>  
> -- 
> 2.34.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
> 

Cheers,
—Adrián

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [Buildroot] [PATCH v7 1/5] package/at-spi2-core: bump to version 2.48.0
  2023-05-05 11:56 ` [Buildroot] [PATCH v7 1/5] package/at-spi2-core: bump to version 2.48.0 Adrian Perez de Castro
@ 2023-05-05 11:58   ` Adrian Perez de Castro
  0 siblings, 0 replies; 14+ messages in thread
From: Adrian Perez de Castro @ 2023-05-05 11:58 UTC (permalink / raw)
  To: Thomas Devoogdt
  Cc: Joseph Kogut, Daniel Lang, Thomas Devoogdt, James Knight,
	buildroot, Fabrice Fontaine


[-- Attachment #1.1: Type: text/plain, Size: 10201 bytes --]

On Fri, 05 May 2023 14:56:15 +0300 Adrian Perez de Castro <aperez@igalia.com> wrote:
> On Fri, 28 Apr 2023 09:59:16 +0200 Thomas Devoogdt <thomas@devoogdt.com> wrote:
> > From: Daniel Lang <d.lang@abatec.at>
> > 
> > https://gitlab.gnome.org/GNOME/at-spi2-core/-/blob/AT_SPI2_CORE_2_48_0/NEWS
> > 
> > - X11 is now optional.
> > - libxml2 is no longer optional.
> > - atk and at-spi2-atk have been merged into at-spi2-core.
> > - atk introspection option added.
> > - Added patch to which avoids requiring libsystemd when configured to use dbus-daemon.
> > - Added check on dlopen.
> > 
> > Signed-off-by: Daniel Lang <d.lang@abatec.at>
> > Signed-off-by: Thomas Devoogdt <thomas.devoogdt@barco.com>
> 
> Tested-by: Adrian Perez de Castro <aperez@igalia.com>
> Reviewed-by: Adrian Perez de Castro <aperez@igalia.com>

Thanks for the updated patch series, I hope this gets merged as it has solved
my build issues for WebKitGTK with X11 enabled =)

> > ---
> > v3:
> >  - rebased on https://patchwork.ozlabs.org/project/buildroot/list/?series=336254
> >  - needed to fix the webkitgtk 2.38.5 compilation
> >    (https://patchwork.ozlabs.org/project/buildroot/patch/20230220090923.2155635-2-thomas.devoogdt@barco.com/)
> > v5: rebased + grouped patches
> > v6: rebased + added Adrians patch
> >  - note: 2.48.0 is out, but will first merge this one
> > v7: bumped to 2.48.0 + added dlopen check
> > ---
> >  ...iring-libsystemd-when-configured-to-.patch | 92 +++++++++++++++++++
> >  package/at-spi2-core/Config.in                | 13 +--
> >  package/at-spi2-core/at-spi2-core.hash        |  4 +-
> >  package/at-spi2-core/at-spi2-core.mk          | 18 +++-
> >  4 files changed, 115 insertions(+), 12 deletions(-)
> >  create mode 100644 package/at-spi2-core/0001-meson-Avoid-requiring-libsystemd-when-configured-to-.patch
> > 
> > diff --git a/package/at-spi2-core/0001-meson-Avoid-requiring-libsystemd-when-configured-to-.patch b/package/at-spi2-core/0001-meson-Avoid-requiring-libsystemd-when-configured-to-.patch
> > new file mode 100644
> > index 0000000000..29c3de8d2d
> > --- /dev/null
> > +++ b/package/at-spi2-core/0001-meson-Avoid-requiring-libsystemd-when-configured-to-.patch
> > @@ -0,0 +1,92 @@
> > +From aeb14ffccaabe65a64e976576d71f30eb2165f43 Mon Sep 17 00:00:00 2001
> > +From: Adrian Perez de Castro <aperez@igalia.com>
> > +Date: Mon, 24 Apr 2023 12:09:50 +0300
> > +Subject: [PATCH] meson: Avoid requiring libsystemd when configured to use
> > + dbus-daemon
> > +
> > +Checks for dbus-daemon and dbus-broker only when they are chosen
> > +with default_bus. This avoids requiring the systemd libraries if
> > +one wants the built at-spi2-core to use dbus-daemon, but dbus-worker
> > +is somehow available in the $PATH. A typical scenario is cross
> > +compilation, where the build host may have a dbus-broker program
> > +available, but the target system may not have it (or may not have
> > +nor want to use the systemd libraries).
> > +
> > +upstream: https://gitlab.gnome.org/GNOME/at-spi2-core/-/merge_requests/134
> > +---
> > + bus/meson.build | 53 ++++++++++++++++++++++++-------------------------
> > + 1 file changed, 26 insertions(+), 27 deletions(-)
> > +
> > +diff --git a/bus/meson.build b/bus/meson.build
> > +index 22a1bce6..2f3c5621 100644
> > +--- a/bus/meson.build
> > ++++ b/bus/meson.build
> > +@@ -46,39 +46,38 @@ launcher_args = [
> > +              '-DDATADIR="@0@"'.format(atspi_datadir),
> > +            ]
> > + 
> > +-if get_option('dbus_daemon') != 'default'
> > +-  launcher_args += '-DDBUS_DAEMON="@0@"'.format(get_option('dbus_daemon'))
> > +-else
> > +-  dbus_daemon = find_program('dbus-daemon',
> > +-                             '/sbin/dbus-daemon',
> > +-                             '/usr/sbin/dbus-daemon',
> > +-                             '/libexec/dbus-daemon',
> > +-                             '/usr/libexec/dbus-daemon',
> > +-                             '/usr/lib/dbus-daemon',
> > +-                             '/usr/pkg/bin/dbus-daemon',
> > +-                             required: false)
> > +-  if dbus_daemon.found()
> > +-    launcher_args += '-DDBUS_DAEMON="@0@"'.format(dbus_daemon.full_path())
> > +-  endif
> > +-endif
> > +-
> > + needs_systemd = false
> > +-if get_option('dbus_broker') != 'default'
> > +-  launcher_args += '-DDBUS_BROKER="@0@"'.format(get_option('dbus_broker'))
> > +-  needs_systemd = true
> > ++if get_option('default_bus') == 'dbus-daemon'
> > ++  if get_option('dbus_daemon') != 'default'
> > ++    launcher_args += '-DDBUS_DAEMON="@0@"'.format(get_option('dbus_daemon'))
> > ++  else
> > ++    dbus_daemon = find_program('dbus-daemon',
> > ++                               '/sbin/dbus-daemon',
> > ++                               '/usr/sbin/dbus-daemon',
> > ++                               '/libexec/dbus-daemon',
> > ++                               '/usr/libexec/dbus-daemon',
> > ++                               '/usr/lib/dbus-daemon',
> > ++                               '/usr/pkg/bin/dbus-daemon',
> > ++                               required: false)
> > ++    if dbus_daemon.found()
> > ++      launcher_args += '-DDBUS_DAEMON="@0@"'.format(dbus_daemon.full_path())
> > ++    endif
> > ++  endif
> > + else
> > +-  dbus_broker = find_program('dbus-broker-launch',
> > +-                             required: false)
> > +-  if dbus_broker.found()
> > +-    launcher_args += '-DDBUS_BROKER="@0@"'.format(dbus_broker.full_path())
> > ++  launcher_args += '-DWANT_DBUS_BROKER'
> > ++  if get_option('dbus_broker') != 'default'
> > ++    launcher_args += '-DDBUS_BROKER="@0@"'.format(get_option('dbus_broker'))
> > +     needs_systemd = true
> > ++  else
> > ++    dbus_broker = find_program('dbus-broker-launch',
> > ++                               required: false)
> > ++    if dbus_broker.found()
> > ++      launcher_args += '-DDBUS_BROKER="@0@"'.format(dbus_broker.full_path())
> > ++      needs_systemd = true
> > ++    endif
> > +   endif
> > + endif
> > + 
> > +-if get_option('default_bus') == 'dbus-broker'
> > +-  launcher_args += '-DWANT_DBUS_BROKER'
> > +-endif
> > +-
> > + if needs_systemd
> > +   systemd_dep = dependency('libsystemd')
> > + else
> > +-- 
> > +2.34.1
> > +
> > diff --git a/package/at-spi2-core/Config.in b/package/at-spi2-core/Config.in
> > index f56c5b93c4..2a1b21d375 100644
> > --- a/package/at-spi2-core/Config.in
> > +++ b/package/at-spi2-core/Config.in
> > @@ -1,12 +1,13 @@
> >  config BR2_PACKAGE_AT_SPI2_CORE
> >  	bool "at-spi2-core"
> > -	depends on BR2_PACKAGE_XORG7 # xlib-libxtst
> >  	depends on BR2_TOOLCHAIN_HAS_THREADS # dbus, glib2
> >  	depends on BR2_USE_MMU # glib2
> >  	depends on BR2_USE_WCHAR # glib2
> > +	depends on !BR2_STATIC_LIBS # dlopen()
> >  	select BR2_PACKAGE_DBUS
> >  	select BR2_PACKAGE_LIBGLIB2
> > -	select BR2_PACKAGE_XLIB_LIBXTST
> > +	select BR2_PACKAGE_LIBXML2
> > +	select BR2_PACKAGE_XLIB_LIBXTST if BR2_PACKAGE_XORG7 # optionally for X11
> >  	help
> >  	  The At-Spi2 Core package is a part of the GNOME
> >  	  Accessibility Project. It provides a Service Provider
> > @@ -16,10 +17,6 @@ config BR2_PACKAGE_AT_SPI2_CORE
> >  
> >  	  https://wiki.gnome.org/Accessibility
> >  
> > -comment "at-spi2-core needs a toolchain w/ wchar, threads"
> > +comment "at-spi2-core needs a toolchain w/ dynamic library, wchar, threads"
> >  	depends on BR2_USE_MMU
> > -	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
> > -
> > -comment "at-spi2-core depends on X.org"
> > -	depends on BR2_USE_MMU
> > -	depends on !BR2_PACKAGE_XORG7
> > +	depends on BR2_STATIC_LIBS || !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
> > diff --git a/package/at-spi2-core/at-spi2-core.hash b/package/at-spi2-core/at-spi2-core.hash
> > index 764e4c3661..9cf80d1cc0 100644
> > --- a/package/at-spi2-core/at-spi2-core.hash
> > +++ b/package/at-spi2-core/at-spi2-core.hash
> > @@ -1,5 +1,5 @@
> > -# From https://download.gnome.org/sources/at-spi2-core/2.36/at-spi2-core-2.36.0.sha256sum
> > -sha256  88da57de0a7e3c60bc341a974a80fdba091612db3547c410d6deab039ca5c05a  at-spi2-core-2.36.0.tar.xz
> > +# From https://download.gnome.org/sources/at-spi2-core/2.48/at-spi2-core-2.48.0.sha256sum
> > +sha256  905a5b6f1790b68ee803bffa9f5fab4ceb591fb4fae0b2f8c612c54f1d4e8a30  at-spi2-core-2.48.0.tar.xz
> >  
> >  # locally calculated
> >  sha256  dc626520dcd53a22f727af3ee42c770e56c97a64fe3adb063799d8ab032fe551  COPYING
> > diff --git a/package/at-spi2-core/at-spi2-core.mk b/package/at-spi2-core/at-spi2-core.mk
> > index f0b019c0ed..e4489f6f88 100644
> > --- a/package/at-spi2-core/at-spi2-core.mk
> > +++ b/package/at-spi2-core/at-spi2-core.mk
> > @@ -4,17 +4,31 @@
> >  #
> >  ################################################################################
> >  
> > -AT_SPI2_CORE_VERSION_MAJOR = 2.36
> > +AT_SPI2_CORE_VERSION_MAJOR = 2.48
> >  AT_SPI2_CORE_VERSION = $(AT_SPI2_CORE_VERSION_MAJOR).0
> >  AT_SPI2_CORE_SOURCE = at-spi2-core-$(AT_SPI2_CORE_VERSION).tar.xz
> >  AT_SPI2_CORE_SITE = https://download.gnome.org/sources/at-spi2-core/$(AT_SPI2_CORE_VERSION_MAJOR)
> >  AT_SPI2_CORE_LICENSE = LGPL-2.1+
> >  AT_SPI2_CORE_LICENSE_FILES = COPYING
> >  AT_SPI2_CORE_INSTALL_STAGING = YES
> > -AT_SPI2_CORE_DEPENDENCIES = host-pkgconf dbus libglib2 xlib_libXtst \
> > +AT_SPI2_CORE_DEPENDENCIES = host-pkgconf dbus libglib2 libxml2 \
> >  	$(TARGET_NLS_DEPENDENCIES)
> >  AT_SPI2_CORE_CONF_OPTS = -Ddbus_daemon=/usr/bin/dbus-daemon
> >  
> > +ifeq ($(BR2_PACKAGE_XORG7),y)
> > +AT_SPI2_CORE_CONF_OPTS += -Dx11=enabled
> > +AT_SPI2_CORE_DEPENDENCIES += xlib_libXtst
> > +else
> > +AT_SPI2_CORE_CONF_OPTS += -Dx11=disabled
> > +endif
> > +
> > +ifeq ($(BR2_PACKAGE_GOBJECT_INTROSPECTION),y)
> > +AT_SPI2_CORE_CONF_OPTS += -Dintrospection=enabled
> > +AT_SPI2_CORE_DEPENDENCIES += gobject-introspection
> > +else
> > +AT_SPI2_CORE_CONF_OPTS += -Dintrospection=disabled
> > +endif
> > +
> >  AT_SPI2_CORE_LDFLAGS = $(TARGET_LDFLAGS) $(TARGET_NLS_LIBS)
> >  
> >  $(eval $(meson-package))
> > -- 
> > 2.34.1
> > 
> > _______________________________________________
> > buildroot mailing list
> > buildroot@buildroot.org
> > https://lists.buildroot.org/mailman/listinfo/buildroot
> > 
> 
> Cheers,
> —Adrián

Cheers,
—Adrián

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [Buildroot] [PATCH v7 1/5] package/at-spi2-core: bump to version 2.48.0
  2023-04-28  7:59 [Buildroot] [PATCH v7 1/5] package/at-spi2-core: bump to version 2.48.0 Thomas Devoogdt
                   ` (4 preceding siblings ...)
  2023-05-05 11:56 ` [Buildroot] [PATCH v7 1/5] package/at-spi2-core: bump to version 2.48.0 Adrian Perez de Castro
@ 2023-05-08 11:35 ` Yann E. MORIN
  2023-05-08 14:52   ` Thomas Devoogdt
  2023-05-08 16:05 ` Yann E. MORIN
  6 siblings, 1 reply; 14+ messages in thread
From: Yann E. MORIN @ 2023-05-08 11:35 UTC (permalink / raw)
  To: Thomas Devoogdt
  Cc: Joseph Kogut, Daniel Lang, Thomas Devoogdt, James Knight,
	buildroot, Adrian Perez de Castro, Fabrice Fontaine

Thomas, Daniel, All,

On 2023-04-28 09:59 +0200, Thomas Devoogdt spake thusly:
> From: Daniel Lang <d.lang@abatec.at>
> 
> https://gitlab.gnome.org/GNOME/at-spi2-core/-/blob/AT_SPI2_CORE_2_48_0/NEWS
> 
> - X11 is now optional.
> - libxml2 is no longer optional.
> - atk and at-spi2-atk have been merged into at-spi2-core.
> - atk introspection option added.
> - Added patch to which avoids requiring libsystemd when configured to use dbus-daemon.
> - Added check on dlopen.
> 
> Signed-off-by: Daniel Lang <d.lang@abatec.at>
> Signed-off-by: Thomas Devoogdt <thomas.devoogdt@barco.com>

I wanted to apply this patch series, but unfiortuantely, there is
missing piece, see below...

[--SNIP--]
> diff --git a/package/at-spi2-core/0001-meson-Avoid-requiring-libsystemd-when-configured-to-.patch b/package/at-spi2-core/0001-meson-Avoid-requiring-libsystemd-when-configured-to-.patch
> new file mode 100644
> index 0000000000..29c3de8d2d
> --- /dev/null
> +++ b/package/at-spi2-core/0001-meson-Avoid-requiring-libsystemd-when-configured-to-.patch
> @@ -0,0 +1,92 @@
> +From aeb14ffccaabe65a64e976576d71f30eb2165f43 Mon Sep 17 00:00:00 2001
> +From: Adrian Perez de Castro <aperez@igalia.com>
> +Date: Mon, 24 Apr 2023 12:09:50 +0300
> +Subject: [PATCH] meson: Avoid requiring libsystemd when configured to use
> + dbus-daemon
> +
> +Checks for dbus-daemon and dbus-broker only when they are chosen
> +with default_bus. This avoids requiring the systemd libraries if
> +one wants the built at-spi2-core to use dbus-daemon, but dbus-worker
> +is somehow available in the $PATH. A typical scenario is cross
> +compilation, where the build host may have a dbus-broker program
> +available, but the target system may not have it (or may not have
> +nor want to use the systemd libraries).
> +
> +upstream: https://gitlab.gnome.org/GNOME/at-spi2-core/-/merge_requests/134

This patch is missing a SoB of you guys that grabbed it from upstream,
i.e. Daniel and Thomas, even if the upstream commit has no SoB itself.

And nit: the upstream tag takes a uppercase 'U'.

    $ ./utils/docker-run make check-package
    package/at-spi2-core/0001-meson-Avoid-requiring-libsystemd-when-configured-to-.patch:0: missing Signed-off-by in the header (http://nightly.buildroot.org/#_format_and_licensing_of_the_package_patches)
    package/at-spi2-core/0001-meson-Avoid-requiring-libsystemd-when-configured-to-.patch:0: missing Upstream in the header (http://nightly.buildroot.org/#_additional_patch_documentation)

I could fix the Upstream issue, but I can't add a SoB for others. But if
you reply here with your SoB lines, Daniel and/or Thomas, I can add them
when applying.

Regards,
Yann E. MORIN.

> +---
> + bus/meson.build | 53 ++++++++++++++++++++++++-------------------------
> + 1 file changed, 26 insertions(+), 27 deletions(-)
> +
> +diff --git a/bus/meson.build b/bus/meson.build
> +index 22a1bce6..2f3c5621 100644
> +--- a/bus/meson.build
> ++++ b/bus/meson.build
> +@@ -46,39 +46,38 @@ launcher_args = [
> +              '-DDATADIR="@0@"'.format(atspi_datadir),
> +            ]
> + 
> +-if get_option('dbus_daemon') != 'default'
> +-  launcher_args += '-DDBUS_DAEMON="@0@"'.format(get_option('dbus_daemon'))
> +-else
> +-  dbus_daemon = find_program('dbus-daemon',
> +-                             '/sbin/dbus-daemon',
> +-                             '/usr/sbin/dbus-daemon',
> +-                             '/libexec/dbus-daemon',
> +-                             '/usr/libexec/dbus-daemon',
> +-                             '/usr/lib/dbus-daemon',
> +-                             '/usr/pkg/bin/dbus-daemon',
> +-                             required: false)
> +-  if dbus_daemon.found()
> +-    launcher_args += '-DDBUS_DAEMON="@0@"'.format(dbus_daemon.full_path())
> +-  endif
> +-endif
> +-
> + needs_systemd = false
> +-if get_option('dbus_broker') != 'default'
> +-  launcher_args += '-DDBUS_BROKER="@0@"'.format(get_option('dbus_broker'))
> +-  needs_systemd = true
> ++if get_option('default_bus') == 'dbus-daemon'
> ++  if get_option('dbus_daemon') != 'default'
> ++    launcher_args += '-DDBUS_DAEMON="@0@"'.format(get_option('dbus_daemon'))
> ++  else
> ++    dbus_daemon = find_program('dbus-daemon',
> ++                               '/sbin/dbus-daemon',
> ++                               '/usr/sbin/dbus-daemon',
> ++                               '/libexec/dbus-daemon',
> ++                               '/usr/libexec/dbus-daemon',
> ++                               '/usr/lib/dbus-daemon',
> ++                               '/usr/pkg/bin/dbus-daemon',
> ++                               required: false)
> ++    if dbus_daemon.found()
> ++      launcher_args += '-DDBUS_DAEMON="@0@"'.format(dbus_daemon.full_path())
> ++    endif
> ++  endif
> + else
> +-  dbus_broker = find_program('dbus-broker-launch',
> +-                             required: false)
> +-  if dbus_broker.found()
> +-    launcher_args += '-DDBUS_BROKER="@0@"'.format(dbus_broker.full_path())
> ++  launcher_args += '-DWANT_DBUS_BROKER'
> ++  if get_option('dbus_broker') != 'default'
> ++    launcher_args += '-DDBUS_BROKER="@0@"'.format(get_option('dbus_broker'))
> +     needs_systemd = true
> ++  else
> ++    dbus_broker = find_program('dbus-broker-launch',
> ++                               required: false)
> ++    if dbus_broker.found()
> ++      launcher_args += '-DDBUS_BROKER="@0@"'.format(dbus_broker.full_path())
> ++      needs_systemd = true
> ++    endif
> +   endif
> + endif
> + 
> +-if get_option('default_bus') == 'dbus-broker'
> +-  launcher_args += '-DWANT_DBUS_BROKER'
> +-endif
> +-
> + if needs_systemd
> +   systemd_dep = dependency('libsystemd')
> + else
> +-- 
> +2.34.1
> +
> diff --git a/package/at-spi2-core/Config.in b/package/at-spi2-core/Config.in
> index f56c5b93c4..2a1b21d375 100644
> --- a/package/at-spi2-core/Config.in
> +++ b/package/at-spi2-core/Config.in
> @@ -1,12 +1,13 @@
>  config BR2_PACKAGE_AT_SPI2_CORE
>  	bool "at-spi2-core"
> -	depends on BR2_PACKAGE_XORG7 # xlib-libxtst
>  	depends on BR2_TOOLCHAIN_HAS_THREADS # dbus, glib2
>  	depends on BR2_USE_MMU # glib2
>  	depends on BR2_USE_WCHAR # glib2
> +	depends on !BR2_STATIC_LIBS # dlopen()
>  	select BR2_PACKAGE_DBUS
>  	select BR2_PACKAGE_LIBGLIB2
> -	select BR2_PACKAGE_XLIB_LIBXTST
> +	select BR2_PACKAGE_LIBXML2
> +	select BR2_PACKAGE_XLIB_LIBXTST if BR2_PACKAGE_XORG7 # optionally for X11
>  	help
>  	  The At-Spi2 Core package is a part of the GNOME
>  	  Accessibility Project. It provides a Service Provider
> @@ -16,10 +17,6 @@ config BR2_PACKAGE_AT_SPI2_CORE
>  
>  	  https://wiki.gnome.org/Accessibility
>  
> -comment "at-spi2-core needs a toolchain w/ wchar, threads"
> +comment "at-spi2-core needs a toolchain w/ dynamic library, wchar, threads"
>  	depends on BR2_USE_MMU
> -	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
> -
> -comment "at-spi2-core depends on X.org"
> -	depends on BR2_USE_MMU
> -	depends on !BR2_PACKAGE_XORG7
> +	depends on BR2_STATIC_LIBS || !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
> diff --git a/package/at-spi2-core/at-spi2-core.hash b/package/at-spi2-core/at-spi2-core.hash
> index 764e4c3661..9cf80d1cc0 100644
> --- a/package/at-spi2-core/at-spi2-core.hash
> +++ b/package/at-spi2-core/at-spi2-core.hash
> @@ -1,5 +1,5 @@
> -# From https://download.gnome.org/sources/at-spi2-core/2.36/at-spi2-core-2.36.0.sha256sum
> -sha256  88da57de0a7e3c60bc341a974a80fdba091612db3547c410d6deab039ca5c05a  at-spi2-core-2.36.0.tar.xz
> +# From https://download.gnome.org/sources/at-spi2-core/2.48/at-spi2-core-2.48.0.sha256sum
> +sha256  905a5b6f1790b68ee803bffa9f5fab4ceb591fb4fae0b2f8c612c54f1d4e8a30  at-spi2-core-2.48.0.tar.xz
>  
>  # locally calculated
>  sha256  dc626520dcd53a22f727af3ee42c770e56c97a64fe3adb063799d8ab032fe551  COPYING
> diff --git a/package/at-spi2-core/at-spi2-core.mk b/package/at-spi2-core/at-spi2-core.mk
> index f0b019c0ed..e4489f6f88 100644
> --- a/package/at-spi2-core/at-spi2-core.mk
> +++ b/package/at-spi2-core/at-spi2-core.mk
> @@ -4,17 +4,31 @@
>  #
>  ################################################################################
>  
> -AT_SPI2_CORE_VERSION_MAJOR = 2.36
> +AT_SPI2_CORE_VERSION_MAJOR = 2.48
>  AT_SPI2_CORE_VERSION = $(AT_SPI2_CORE_VERSION_MAJOR).0
>  AT_SPI2_CORE_SOURCE = at-spi2-core-$(AT_SPI2_CORE_VERSION).tar.xz
>  AT_SPI2_CORE_SITE = https://download.gnome.org/sources/at-spi2-core/$(AT_SPI2_CORE_VERSION_MAJOR)
>  AT_SPI2_CORE_LICENSE = LGPL-2.1+
>  AT_SPI2_CORE_LICENSE_FILES = COPYING
>  AT_SPI2_CORE_INSTALL_STAGING = YES
> -AT_SPI2_CORE_DEPENDENCIES = host-pkgconf dbus libglib2 xlib_libXtst \
> +AT_SPI2_CORE_DEPENDENCIES = host-pkgconf dbus libglib2 libxml2 \
>  	$(TARGET_NLS_DEPENDENCIES)
>  AT_SPI2_CORE_CONF_OPTS = -Ddbus_daemon=/usr/bin/dbus-daemon
>  
> +ifeq ($(BR2_PACKAGE_XORG7),y)
> +AT_SPI2_CORE_CONF_OPTS += -Dx11=enabled
> +AT_SPI2_CORE_DEPENDENCIES += xlib_libXtst
> +else
> +AT_SPI2_CORE_CONF_OPTS += -Dx11=disabled
> +endif
> +
> +ifeq ($(BR2_PACKAGE_GOBJECT_INTROSPECTION),y)
> +AT_SPI2_CORE_CONF_OPTS += -Dintrospection=enabled
> +AT_SPI2_CORE_DEPENDENCIES += gobject-introspection
> +else
> +AT_SPI2_CORE_CONF_OPTS += -Dintrospection=disabled
> +endif
> +
>  AT_SPI2_CORE_LDFLAGS = $(TARGET_LDFLAGS) $(TARGET_NLS_LIBS)
>  
>  $(eval $(meson-package))
> -- 
> 2.34.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [Buildroot] [PATCH v7 1/5] package/at-spi2-core: bump to version 2.48.0
  2023-05-08 11:35 ` Yann E. MORIN
@ 2023-05-08 14:52   ` Thomas Devoogdt
  0 siblings, 0 replies; 14+ messages in thread
From: Thomas Devoogdt @ 2023-05-08 14:52 UTC (permalink / raw)
  To: Yann E. MORIN
  Cc: Joseph Kogut, Thomas Devoogdt, Daniel Lang, Thomas Devoogdt,
	James Knight, buildroot, Adrian Perez de Castro,
	Fabrice Fontaine

Hi,

This patch series is already updated sometimes, I took the series from
@Daniel Lang, and added, for example, this patch.
The patch itself was submitted upstream by @Adrian Perez de Castro,
but no SoB was added there.
Since it's accepted upstream, and checked by me and Adrian, I guess
that adding my SoB is fine.

 "Signed-off-by: Thomas Devoogdt <thomas.devoogdt@barco.com>"

Btw, about "package/libgtk3: re-enable atk-bridge", don't forget to
remove "0001-disable-atk-bridge.patch" from the .checkpackageignore
list.
I only recently learned about that list, so next time, I will do it
myself. But I guess you will do it now.
Next time, I will also make sure to write Upstream and add the
mandatory signed-off.

Kr,

Thomas Devoogdt

Op ma 8 mei 2023 om 13:35 schreef Yann E. MORIN <yann.morin.1998@free.fr>:
>
> Thomas, Daniel, All,
>
> On 2023-04-28 09:59 +0200, Thomas Devoogdt spake thusly:
> > From: Daniel Lang <d.lang@abatec.at>
> >
> > https://gitlab.gnome.org/GNOME/at-spi2-core/-/blob/AT_SPI2_CORE_2_48_0/NEWS
> >
> > - X11 is now optional.
> > - libxml2 is no longer optional.
> > - atk and at-spi2-atk have been merged into at-spi2-core.
> > - atk introspection option added.
> > - Added patch to which avoids requiring libsystemd when configured to use dbus-daemon.
> > - Added check on dlopen.
> >
> > Signed-off-by: Daniel Lang <d.lang@abatec.at>
> > Signed-off-by: Thomas Devoogdt <thomas.devoogdt@barco.com>
>
> I wanted to apply this patch series, but unfiortuantely, there is
> missing piece, see below...
>
> [--SNIP--]
> > diff --git a/package/at-spi2-core/0001-meson-Avoid-requiring-libsystemd-when-configured-to-.patch b/package/at-spi2-core/0001-meson-Avoid-requiring-libsystemd-when-configured-to-.patch
> > new file mode 100644
> > index 0000000000..29c3de8d2d
> > --- /dev/null
> > +++ b/package/at-spi2-core/0001-meson-Avoid-requiring-libsystemd-when-configured-to-.patch
> > @@ -0,0 +1,92 @@
> > +From aeb14ffccaabe65a64e976576d71f30eb2165f43 Mon Sep 17 00:00:00 2001
> > +From: Adrian Perez de Castro <aperez@igalia.com>
> > +Date: Mon, 24 Apr 2023 12:09:50 +0300
> > +Subject: [PATCH] meson: Avoid requiring libsystemd when configured to use
> > + dbus-daemon
> > +
> > +Checks for dbus-daemon and dbus-broker only when they are chosen
> > +with default_bus. This avoids requiring the systemd libraries if
> > +one wants the built at-spi2-core to use dbus-daemon, but dbus-worker
> > +is somehow available in the $PATH. A typical scenario is cross
> > +compilation, where the build host may have a dbus-broker program
> > +available, but the target system may not have it (or may not have
> > +nor want to use the systemd libraries).
> > +
> > +upstream: https://gitlab.gnome.org/GNOME/at-spi2-core/-/merge_requests/134
>
> This patch is missing a SoB of you guys that grabbed it from upstream,
> i.e. Daniel and Thomas, even if the upstream commit has no SoB itself.
>
> And nit: the upstream tag takes a uppercase 'U'.
>
>     $ ./utils/docker-run make check-package
>     package/at-spi2-core/0001-meson-Avoid-requiring-libsystemd-when-configured-to-.patch:0: missing Signed-off-by in the header (http://nightly.buildroot.org/#_format_and_licensing_of_the_package_patches)
>     package/at-spi2-core/0001-meson-Avoid-requiring-libsystemd-when-configured-to-.patch:0: missing Upstream in the header (http://nightly.buildroot.org/#_additional_patch_documentation)
>
> I could fix the Upstream issue, but I can't add a SoB for others. But if
> you reply here with your SoB lines, Daniel and/or Thomas, I can add them
> when applying.
>
> Regards,
> Yann E. MORIN.
>
> > +---
> > + bus/meson.build | 53 ++++++++++++++++++++++++-------------------------
> > + 1 file changed, 26 insertions(+), 27 deletions(-)
> > +
> > +diff --git a/bus/meson.build b/bus/meson.build
> > +index 22a1bce6..2f3c5621 100644
> > +--- a/bus/meson.build
> > ++++ b/bus/meson.build
> > +@@ -46,39 +46,38 @@ launcher_args = [
> > +              '-DDATADIR="@0@"'.format(atspi_datadir),
> > +            ]
> > +
> > +-if get_option('dbus_daemon') != 'default'
> > +-  launcher_args += '-DDBUS_DAEMON="@0@"'.format(get_option('dbus_daemon'))
> > +-else
> > +-  dbus_daemon = find_program('dbus-daemon',
> > +-                             '/sbin/dbus-daemon',
> > +-                             '/usr/sbin/dbus-daemon',
> > +-                             '/libexec/dbus-daemon',
> > +-                             '/usr/libexec/dbus-daemon',
> > +-                             '/usr/lib/dbus-daemon',
> > +-                             '/usr/pkg/bin/dbus-daemon',
> > +-                             required: false)
> > +-  if dbus_daemon.found()
> > +-    launcher_args += '-DDBUS_DAEMON="@0@"'.format(dbus_daemon.full_path())
> > +-  endif
> > +-endif
> > +-
> > + needs_systemd = false
> > +-if get_option('dbus_broker') != 'default'
> > +-  launcher_args += '-DDBUS_BROKER="@0@"'.format(get_option('dbus_broker'))
> > +-  needs_systemd = true
> > ++if get_option('default_bus') == 'dbus-daemon'
> > ++  if get_option('dbus_daemon') != 'default'
> > ++    launcher_args += '-DDBUS_DAEMON="@0@"'.format(get_option('dbus_daemon'))
> > ++  else
> > ++    dbus_daemon = find_program('dbus-daemon',
> > ++                               '/sbin/dbus-daemon',
> > ++                               '/usr/sbin/dbus-daemon',
> > ++                               '/libexec/dbus-daemon',
> > ++                               '/usr/libexec/dbus-daemon',
> > ++                               '/usr/lib/dbus-daemon',
> > ++                               '/usr/pkg/bin/dbus-daemon',
> > ++                               required: false)
> > ++    if dbus_daemon.found()
> > ++      launcher_args += '-DDBUS_DAEMON="@0@"'.format(dbus_daemon.full_path())
> > ++    endif
> > ++  endif
> > + else
> > +-  dbus_broker = find_program('dbus-broker-launch',
> > +-                             required: false)
> > +-  if dbus_broker.found()
> > +-    launcher_args += '-DDBUS_BROKER="@0@"'.format(dbus_broker.full_path())
> > ++  launcher_args += '-DWANT_DBUS_BROKER'
> > ++  if get_option('dbus_broker') != 'default'
> > ++    launcher_args += '-DDBUS_BROKER="@0@"'.format(get_option('dbus_broker'))
> > +     needs_systemd = true
> > ++  else
> > ++    dbus_broker = find_program('dbus-broker-launch',
> > ++                               required: false)
> > ++    if dbus_broker.found()
> > ++      launcher_args += '-DDBUS_BROKER="@0@"'.format(dbus_broker.full_path())
> > ++      needs_systemd = true
> > ++    endif
> > +   endif
> > + endif
> > +
> > +-if get_option('default_bus') == 'dbus-broker'
> > +-  launcher_args += '-DWANT_DBUS_BROKER'
> > +-endif
> > +-
> > + if needs_systemd
> > +   systemd_dep = dependency('libsystemd')
> > + else
> > +--
> > +2.34.1
> > +
> > diff --git a/package/at-spi2-core/Config.in b/package/at-spi2-core/Config.in
> > index f56c5b93c4..2a1b21d375 100644
> > --- a/package/at-spi2-core/Config.in
> > +++ b/package/at-spi2-core/Config.in
> > @@ -1,12 +1,13 @@
> >  config BR2_PACKAGE_AT_SPI2_CORE
> >       bool "at-spi2-core"
> > -     depends on BR2_PACKAGE_XORG7 # xlib-libxtst
> >       depends on BR2_TOOLCHAIN_HAS_THREADS # dbus, glib2
> >       depends on BR2_USE_MMU # glib2
> >       depends on BR2_USE_WCHAR # glib2
> > +     depends on !BR2_STATIC_LIBS # dlopen()
> >       select BR2_PACKAGE_DBUS
> >       select BR2_PACKAGE_LIBGLIB2
> > -     select BR2_PACKAGE_XLIB_LIBXTST
> > +     select BR2_PACKAGE_LIBXML2
> > +     select BR2_PACKAGE_XLIB_LIBXTST if BR2_PACKAGE_XORG7 # optionally for X11
> >       help
> >         The At-Spi2 Core package is a part of the GNOME
> >         Accessibility Project. It provides a Service Provider
> > @@ -16,10 +17,6 @@ config BR2_PACKAGE_AT_SPI2_CORE
> >
> >         https://wiki.gnome.org/Accessibility
> >
> > -comment "at-spi2-core needs a toolchain w/ wchar, threads"
> > +comment "at-spi2-core needs a toolchain w/ dynamic library, wchar, threads"
> >       depends on BR2_USE_MMU
> > -     depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
> > -
> > -comment "at-spi2-core depends on X.org"
> > -     depends on BR2_USE_MMU
> > -     depends on !BR2_PACKAGE_XORG7
> > +     depends on BR2_STATIC_LIBS || !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
> > diff --git a/package/at-spi2-core/at-spi2-core.hash b/package/at-spi2-core/at-spi2-core.hash
> > index 764e4c3661..9cf80d1cc0 100644
> > --- a/package/at-spi2-core/at-spi2-core.hash
> > +++ b/package/at-spi2-core/at-spi2-core.hash
> > @@ -1,5 +1,5 @@
> > -# From https://download.gnome.org/sources/at-spi2-core/2.36/at-spi2-core-2.36.0.sha256sum
> > -sha256  88da57de0a7e3c60bc341a974a80fdba091612db3547c410d6deab039ca5c05a  at-spi2-core-2.36.0.tar.xz
> > +# From https://download.gnome.org/sources/at-spi2-core/2.48/at-spi2-core-2.48.0.sha256sum
> > +sha256  905a5b6f1790b68ee803bffa9f5fab4ceb591fb4fae0b2f8c612c54f1d4e8a30  at-spi2-core-2.48.0.tar.xz
> >
> >  # locally calculated
> >  sha256  dc626520dcd53a22f727af3ee42c770e56c97a64fe3adb063799d8ab032fe551  COPYING
> > diff --git a/package/at-spi2-core/at-spi2-core.mk b/package/at-spi2-core/at-spi2-core.mk
> > index f0b019c0ed..e4489f6f88 100644
> > --- a/package/at-spi2-core/at-spi2-core.mk
> > +++ b/package/at-spi2-core/at-spi2-core.mk
> > @@ -4,17 +4,31 @@
> >  #
> >  ################################################################################
> >
> > -AT_SPI2_CORE_VERSION_MAJOR = 2.36
> > +AT_SPI2_CORE_VERSION_MAJOR = 2.48
> >  AT_SPI2_CORE_VERSION = $(AT_SPI2_CORE_VERSION_MAJOR).0
> >  AT_SPI2_CORE_SOURCE = at-spi2-core-$(AT_SPI2_CORE_VERSION).tar.xz
> >  AT_SPI2_CORE_SITE = https://download.gnome.org/sources/at-spi2-core/$(AT_SPI2_CORE_VERSION_MAJOR)
> >  AT_SPI2_CORE_LICENSE = LGPL-2.1+
> >  AT_SPI2_CORE_LICENSE_FILES = COPYING
> >  AT_SPI2_CORE_INSTALL_STAGING = YES
> > -AT_SPI2_CORE_DEPENDENCIES = host-pkgconf dbus libglib2 xlib_libXtst \
> > +AT_SPI2_CORE_DEPENDENCIES = host-pkgconf dbus libglib2 libxml2 \
> >       $(TARGET_NLS_DEPENDENCIES)
> >  AT_SPI2_CORE_CONF_OPTS = -Ddbus_daemon=/usr/bin/dbus-daemon
> >
> > +ifeq ($(BR2_PACKAGE_XORG7),y)
> > +AT_SPI2_CORE_CONF_OPTS += -Dx11=enabled
> > +AT_SPI2_CORE_DEPENDENCIES += xlib_libXtst
> > +else
> > +AT_SPI2_CORE_CONF_OPTS += -Dx11=disabled
> > +endif
> > +
> > +ifeq ($(BR2_PACKAGE_GOBJECT_INTROSPECTION),y)
> > +AT_SPI2_CORE_CONF_OPTS += -Dintrospection=enabled
> > +AT_SPI2_CORE_DEPENDENCIES += gobject-introspection
> > +else
> > +AT_SPI2_CORE_CONF_OPTS += -Dintrospection=disabled
> > +endif
> > +
> >  AT_SPI2_CORE_LDFLAGS = $(TARGET_LDFLAGS) $(TARGET_NLS_LIBS)
> >
> >  $(eval $(meson-package))
> > --
> > 2.34.1
> >
> > _______________________________________________
> > buildroot mailing list
> > buildroot@buildroot.org
> > https://lists.buildroot.org/mailman/listinfo/buildroot
>
> --
> .-----------------.--------------------.------------------.--------------------.
> |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
> | +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
> '------------------------------^-------^------------------^--------------------'
>
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [Buildroot] [PATCH v7 1/5] package/at-spi2-core: bump to version 2.48.0
  2023-04-28  7:59 [Buildroot] [PATCH v7 1/5] package/at-spi2-core: bump to version 2.48.0 Thomas Devoogdt
                   ` (5 preceding siblings ...)
  2023-05-08 11:35 ` Yann E. MORIN
@ 2023-05-08 16:05 ` Yann E. MORIN
  6 siblings, 0 replies; 14+ messages in thread
From: Yann E. MORIN @ 2023-05-08 16:05 UTC (permalink / raw)
  To: Thomas Devoogdt
  Cc: Joseph Kogut, Daniel Lang, Thomas Devoogdt, James Knight,
	buildroot, Adrian Perez de Castro, Fabrice Fontaine

Thomas, All,

On 2023-04-28 09:59 +0200, Thomas Devoogdt spake thusly:
> From: Daniel Lang <d.lang@abatec.at>
> 
> https://gitlab.gnome.org/GNOME/at-spi2-core/-/blob/AT_SPI2_CORE_2_48_0/NEWS
> 
> - X11 is now optional.
> - libxml2 is no longer optional.
> - atk and at-spi2-atk have been merged into at-spi2-core.
> - atk introspection option added.
> - Added patch to which avoids requiring libsystemd when configured to use dbus-daemon.
> - Added check on dlopen.
> 
> Signed-off-by: Daniel Lang <d.lang@abatec.at>
> Signed-off-by: Thomas Devoogdt <thomas.devoogdt@barco.com>

Series applied to master, thanks!

Regards,
Yann E. MORIN.

> ---
> v3:
>  - rebased on https://patchwork.ozlabs.org/project/buildroot/list/?series=336254
>  - needed to fix the webkitgtk 2.38.5 compilation
>    (https://patchwork.ozlabs.org/project/buildroot/patch/20230220090923.2155635-2-thomas.devoogdt@barco.com/)
> v5: rebased + grouped patches
> v6: rebased + added Adrians patch
>  - note: 2.48.0 is out, but will first merge this one
> v7: bumped to 2.48.0 + added dlopen check
> ---
>  ...iring-libsystemd-when-configured-to-.patch | 92 +++++++++++++++++++
>  package/at-spi2-core/Config.in                | 13 +--
>  package/at-spi2-core/at-spi2-core.hash        |  4 +-
>  package/at-spi2-core/at-spi2-core.mk          | 18 +++-
>  4 files changed, 115 insertions(+), 12 deletions(-)
>  create mode 100644 package/at-spi2-core/0001-meson-Avoid-requiring-libsystemd-when-configured-to-.patch
> 
> diff --git a/package/at-spi2-core/0001-meson-Avoid-requiring-libsystemd-when-configured-to-.patch b/package/at-spi2-core/0001-meson-Avoid-requiring-libsystemd-when-configured-to-.patch
> new file mode 100644
> index 0000000000..29c3de8d2d
> --- /dev/null
> +++ b/package/at-spi2-core/0001-meson-Avoid-requiring-libsystemd-when-configured-to-.patch
> @@ -0,0 +1,92 @@
> +From aeb14ffccaabe65a64e976576d71f30eb2165f43 Mon Sep 17 00:00:00 2001
> +From: Adrian Perez de Castro <aperez@igalia.com>
> +Date: Mon, 24 Apr 2023 12:09:50 +0300
> +Subject: [PATCH] meson: Avoid requiring libsystemd when configured to use
> + dbus-daemon
> +
> +Checks for dbus-daemon and dbus-broker only when they are chosen
> +with default_bus. This avoids requiring the systemd libraries if
> +one wants the built at-spi2-core to use dbus-daemon, but dbus-worker
> +is somehow available in the $PATH. A typical scenario is cross
> +compilation, where the build host may have a dbus-broker program
> +available, but the target system may not have it (or may not have
> +nor want to use the systemd libraries).
> +
> +upstream: https://gitlab.gnome.org/GNOME/at-spi2-core/-/merge_requests/134
> +---
> + bus/meson.build | 53 ++++++++++++++++++++++++-------------------------
> + 1 file changed, 26 insertions(+), 27 deletions(-)
> +
> +diff --git a/bus/meson.build b/bus/meson.build
> +index 22a1bce6..2f3c5621 100644
> +--- a/bus/meson.build
> ++++ b/bus/meson.build
> +@@ -46,39 +46,38 @@ launcher_args = [
> +              '-DDATADIR="@0@"'.format(atspi_datadir),
> +            ]
> + 
> +-if get_option('dbus_daemon') != 'default'
> +-  launcher_args += '-DDBUS_DAEMON="@0@"'.format(get_option('dbus_daemon'))
> +-else
> +-  dbus_daemon = find_program('dbus-daemon',
> +-                             '/sbin/dbus-daemon',
> +-                             '/usr/sbin/dbus-daemon',
> +-                             '/libexec/dbus-daemon',
> +-                             '/usr/libexec/dbus-daemon',
> +-                             '/usr/lib/dbus-daemon',
> +-                             '/usr/pkg/bin/dbus-daemon',
> +-                             required: false)
> +-  if dbus_daemon.found()
> +-    launcher_args += '-DDBUS_DAEMON="@0@"'.format(dbus_daemon.full_path())
> +-  endif
> +-endif
> +-
> + needs_systemd = false
> +-if get_option('dbus_broker') != 'default'
> +-  launcher_args += '-DDBUS_BROKER="@0@"'.format(get_option('dbus_broker'))
> +-  needs_systemd = true
> ++if get_option('default_bus') == 'dbus-daemon'
> ++  if get_option('dbus_daemon') != 'default'
> ++    launcher_args += '-DDBUS_DAEMON="@0@"'.format(get_option('dbus_daemon'))
> ++  else
> ++    dbus_daemon = find_program('dbus-daemon',
> ++                               '/sbin/dbus-daemon',
> ++                               '/usr/sbin/dbus-daemon',
> ++                               '/libexec/dbus-daemon',
> ++                               '/usr/libexec/dbus-daemon',
> ++                               '/usr/lib/dbus-daemon',
> ++                               '/usr/pkg/bin/dbus-daemon',
> ++                               required: false)
> ++    if dbus_daemon.found()
> ++      launcher_args += '-DDBUS_DAEMON="@0@"'.format(dbus_daemon.full_path())
> ++    endif
> ++  endif
> + else
> +-  dbus_broker = find_program('dbus-broker-launch',
> +-                             required: false)
> +-  if dbus_broker.found()
> +-    launcher_args += '-DDBUS_BROKER="@0@"'.format(dbus_broker.full_path())
> ++  launcher_args += '-DWANT_DBUS_BROKER'
> ++  if get_option('dbus_broker') != 'default'
> ++    launcher_args += '-DDBUS_BROKER="@0@"'.format(get_option('dbus_broker'))
> +     needs_systemd = true
> ++  else
> ++    dbus_broker = find_program('dbus-broker-launch',
> ++                               required: false)
> ++    if dbus_broker.found()
> ++      launcher_args += '-DDBUS_BROKER="@0@"'.format(dbus_broker.full_path())
> ++      needs_systemd = true
> ++    endif
> +   endif
> + endif
> + 
> +-if get_option('default_bus') == 'dbus-broker'
> +-  launcher_args += '-DWANT_DBUS_BROKER'
> +-endif
> +-
> + if needs_systemd
> +   systemd_dep = dependency('libsystemd')
> + else
> +-- 
> +2.34.1
> +
> diff --git a/package/at-spi2-core/Config.in b/package/at-spi2-core/Config.in
> index f56c5b93c4..2a1b21d375 100644
> --- a/package/at-spi2-core/Config.in
> +++ b/package/at-spi2-core/Config.in
> @@ -1,12 +1,13 @@
>  config BR2_PACKAGE_AT_SPI2_CORE
>  	bool "at-spi2-core"
> -	depends on BR2_PACKAGE_XORG7 # xlib-libxtst
>  	depends on BR2_TOOLCHAIN_HAS_THREADS # dbus, glib2
>  	depends on BR2_USE_MMU # glib2
>  	depends on BR2_USE_WCHAR # glib2
> +	depends on !BR2_STATIC_LIBS # dlopen()
>  	select BR2_PACKAGE_DBUS
>  	select BR2_PACKAGE_LIBGLIB2
> -	select BR2_PACKAGE_XLIB_LIBXTST
> +	select BR2_PACKAGE_LIBXML2
> +	select BR2_PACKAGE_XLIB_LIBXTST if BR2_PACKAGE_XORG7 # optionally for X11
>  	help
>  	  The At-Spi2 Core package is a part of the GNOME
>  	  Accessibility Project. It provides a Service Provider
> @@ -16,10 +17,6 @@ config BR2_PACKAGE_AT_SPI2_CORE
>  
>  	  https://wiki.gnome.org/Accessibility
>  
> -comment "at-spi2-core needs a toolchain w/ wchar, threads"
> +comment "at-spi2-core needs a toolchain w/ dynamic library, wchar, threads"
>  	depends on BR2_USE_MMU
> -	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
> -
> -comment "at-spi2-core depends on X.org"
> -	depends on BR2_USE_MMU
> -	depends on !BR2_PACKAGE_XORG7
> +	depends on BR2_STATIC_LIBS || !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
> diff --git a/package/at-spi2-core/at-spi2-core.hash b/package/at-spi2-core/at-spi2-core.hash
> index 764e4c3661..9cf80d1cc0 100644
> --- a/package/at-spi2-core/at-spi2-core.hash
> +++ b/package/at-spi2-core/at-spi2-core.hash
> @@ -1,5 +1,5 @@
> -# From https://download.gnome.org/sources/at-spi2-core/2.36/at-spi2-core-2.36.0.sha256sum
> -sha256  88da57de0a7e3c60bc341a974a80fdba091612db3547c410d6deab039ca5c05a  at-spi2-core-2.36.0.tar.xz
> +# From https://download.gnome.org/sources/at-spi2-core/2.48/at-spi2-core-2.48.0.sha256sum
> +sha256  905a5b6f1790b68ee803bffa9f5fab4ceb591fb4fae0b2f8c612c54f1d4e8a30  at-spi2-core-2.48.0.tar.xz
>  
>  # locally calculated
>  sha256  dc626520dcd53a22f727af3ee42c770e56c97a64fe3adb063799d8ab032fe551  COPYING
> diff --git a/package/at-spi2-core/at-spi2-core.mk b/package/at-spi2-core/at-spi2-core.mk
> index f0b019c0ed..e4489f6f88 100644
> --- a/package/at-spi2-core/at-spi2-core.mk
> +++ b/package/at-spi2-core/at-spi2-core.mk
> @@ -4,17 +4,31 @@
>  #
>  ################################################################################
>  
> -AT_SPI2_CORE_VERSION_MAJOR = 2.36
> +AT_SPI2_CORE_VERSION_MAJOR = 2.48
>  AT_SPI2_CORE_VERSION = $(AT_SPI2_CORE_VERSION_MAJOR).0
>  AT_SPI2_CORE_SOURCE = at-spi2-core-$(AT_SPI2_CORE_VERSION).tar.xz
>  AT_SPI2_CORE_SITE = https://download.gnome.org/sources/at-spi2-core/$(AT_SPI2_CORE_VERSION_MAJOR)
>  AT_SPI2_CORE_LICENSE = LGPL-2.1+
>  AT_SPI2_CORE_LICENSE_FILES = COPYING
>  AT_SPI2_CORE_INSTALL_STAGING = YES
> -AT_SPI2_CORE_DEPENDENCIES = host-pkgconf dbus libglib2 xlib_libXtst \
> +AT_SPI2_CORE_DEPENDENCIES = host-pkgconf dbus libglib2 libxml2 \
>  	$(TARGET_NLS_DEPENDENCIES)
>  AT_SPI2_CORE_CONF_OPTS = -Ddbus_daemon=/usr/bin/dbus-daemon
>  
> +ifeq ($(BR2_PACKAGE_XORG7),y)
> +AT_SPI2_CORE_CONF_OPTS += -Dx11=enabled
> +AT_SPI2_CORE_DEPENDENCIES += xlib_libXtst
> +else
> +AT_SPI2_CORE_CONF_OPTS += -Dx11=disabled
> +endif
> +
> +ifeq ($(BR2_PACKAGE_GOBJECT_INTROSPECTION),y)
> +AT_SPI2_CORE_CONF_OPTS += -Dintrospection=enabled
> +AT_SPI2_CORE_DEPENDENCIES += gobject-introspection
> +else
> +AT_SPI2_CORE_CONF_OPTS += -Dintrospection=disabled
> +endif
> +
>  AT_SPI2_CORE_LDFLAGS = $(TARGET_LDFLAGS) $(TARGET_NLS_LIBS)
>  
>  $(eval $(meson-package))
> -- 
> 2.34.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2023-05-08 16:06 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-28  7:59 [Buildroot] [PATCH v7 1/5] package/at-spi2-core: bump to version 2.48.0 Thomas Devoogdt
2023-04-28  7:59 ` [Buildroot] [PATCH v7 2/5] package/at-spi2-atk: remove package Thomas Devoogdt
2023-05-05 11:56   ` Adrian Perez de Castro
2023-04-28  7:59 ` [Buildroot] [PATCH v7 3/5] package/atk: " Thomas Devoogdt
2023-05-05 11:56   ` Adrian Perez de Castro
2023-04-28  7:59 ` [Buildroot] [PATCH v7 4/5] package/libgtk3: re-enable atk-bridge Thomas Devoogdt
2023-05-05 11:57   ` Adrian Perez de Castro
2023-04-28  7:59 ` [Buildroot] [PATCH v7 5/5] package/libgtk3: fix update-icon-cache on empty directory Thomas Devoogdt
2023-05-05 11:57   ` Adrian Perez de Castro
2023-05-05 11:56 ` [Buildroot] [PATCH v7 1/5] package/at-spi2-core: bump to version 2.48.0 Adrian Perez de Castro
2023-05-05 11:58   ` Adrian Perez de Castro
2023-05-08 11:35 ` Yann E. MORIN
2023-05-08 14:52   ` Thomas Devoogdt
2023-05-08 16:05 ` Yann E. MORIN

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.