All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] ref-manual: classes: kernel: remove incorrect sentence opening
@ 2023-05-05  9:10 Luca Ceresoli
  2023-05-05  9:10 ` [PATCH 2/2] ref-manual: classes: kernel: document automatic defconfig usage Luca Ceresoli
  0 siblings, 1 reply; 5+ messages in thread
From: Luca Ceresoli @ 2023-05-05  9:10 UTC (permalink / raw)
  To: docs; +Cc: Luca Ceresoli

"This means that" implies that this sentence is a consequence of the
previous, but this is not the case, the two sentences being quite unrelated
to each other.

Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
---
 documentation/ref-manual/classes.rst | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/documentation/ref-manual/classes.rst b/documentation/ref-manual/classes.rst
index a78368b380f6..de2d97de3038 100644
--- a/documentation/ref-manual/classes.rst
+++ b/documentation/ref-manual/classes.rst
@@ -1532,11 +1532,11 @@ code to build all kernel trees. All needed headers are staged into the
 :term:`STAGING_KERNEL_DIR` directory to allow out-of-tree module builds
 using the :ref:`ref-classes-module` class.
 
-This means that each built kernel module is packaged separately and
-inter-module dependencies are created by parsing the ``modinfo`` output.
-If all modules are required, then installing the ``kernel-modules``
-package installs all packages with modules and various other kernel
-packages such as ``kernel-vmlinux``.
+Each built kernel module is packaged separately and inter-module
+dependencies are created by parsing the ``modinfo`` output.  If all modules
+are required, then installing the ``kernel-modules`` package installs all
+packages with modules and various other kernel packages such as
+``kernel-vmlinux``.
 
 The :ref:`ref-classes-kernel` class contains logic that allows you to embed an initial
 RAM filesystem (:term:`Initramfs`) image when you build the kernel image. For
-- 
2.34.1



^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 2/2] ref-manual: classes: kernel: document automatic defconfig usage
  2023-05-05  9:10 [PATCH 1/2] ref-manual: classes: kernel: remove incorrect sentence opening Luca Ceresoli
@ 2023-05-05  9:10 ` Luca Ceresoli
  2023-05-05 15:10   ` [docs] " Michael Opdenacker
       [not found]   ` <175C47EAC5CB336C.898@lists.yoctoproject.org>
  0 siblings, 2 replies; 5+ messages in thread
From: Luca Ceresoli @ 2023-05-05  9:10 UTC (permalink / raw)
  To: docs; +Cc: Luca Ceresoli

Since a very long time the kernel bbclass uses a defconfig file from
SRC_URI automatically. Document this feature.

Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
---
 documentation/ref-manual/classes.rst | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/documentation/ref-manual/classes.rst b/documentation/ref-manual/classes.rst
index de2d97de3038..8f7cbf2b456e 100644
--- a/documentation/ref-manual/classes.rst
+++ b/documentation/ref-manual/classes.rst
@@ -1532,6 +1532,13 @@ code to build all kernel trees. All needed headers are staged into the
 :term:`STAGING_KERNEL_DIR` directory to allow out-of-tree module builds
 using the :ref:`ref-classes-module` class.
 
+If a file named ``defconfig`` is listed in :term:`SRC_URI`, then by default
+:ref:`ref-tasks-configure` copies it as ``.config`` in the build directory,
+so it is automatically used as the kernel configuration for the build. This
+copy is not performed in case ``.config`` already exists there: this allows
+recipes to produce a configuration by other means in
+``do_configure:prepend``.
+
 Each built kernel module is packaged separately and inter-module
 dependencies are created by parsing the ``modinfo`` output.  If all modules
 are required, then installing the ``kernel-modules`` package installs all
-- 
2.34.1



^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [docs] [PATCH 2/2] ref-manual: classes: kernel: document automatic defconfig usage
  2023-05-05  9:10 ` [PATCH 2/2] ref-manual: classes: kernel: document automatic defconfig usage Luca Ceresoli
@ 2023-05-05 15:10   ` Michael Opdenacker
       [not found]   ` <175C47EAC5CB336C.898@lists.yoctoproject.org>
  1 sibling, 0 replies; 5+ messages in thread
From: Michael Opdenacker @ 2023-05-05 15:10 UTC (permalink / raw)
  To: luca.ceresoli; +Cc: docs


On 05.05.23 at 11:10, Luca Ceresoli via lists.yoctoproject.org wrote:
> Since a very long time the kernel bbclass uses a defconfig file from
> SRC_URI automatically. Document this feature.
>
> Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>


Hi Luca,

That's great to document this behavior. Good catch!
For both patches: Reviewed-by: Michael Opdenacker 
<michael.opdenacker@bootlin.com>
... and merged into "master-next".

Cheers
Michael.

-- 
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [docs] [PATCH 2/2] ref-manual: classes: kernel: document automatic defconfig usage
       [not found]   ` <175C47EAC5CB336C.898@lists.yoctoproject.org>
@ 2023-05-05 16:40     ` Michael Opdenacker
  2023-05-05 16:49       ` Luca Ceresoli
  0 siblings, 1 reply; 5+ messages in thread
From: Michael Opdenacker @ 2023-05-05 16:40 UTC (permalink / raw)
  To: luca.ceresoli; +Cc: docs

Hi Luca,

On 05.05.23 at 17:10, Michael Opdenacker via lists.yoctoproject.org wrote:
>
> On 05.05.23 at 11:10, Luca Ceresoli via lists.yoctoproject.org wrote:
>> Since a very long time the kernel bbclass uses a defconfig file from
>> SRC_URI automatically. Document this feature.
>>
>> Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
>
>
> Hi Luca,
>
> That's great to document this behavior. Good catch!
> For both patches: Reviewed-by: Michael Opdenacker 
> <michael.opdenacker@bootlin.com>
> ... and merged into "master-next".


Oops, I realize you should run a few git commands to have a proper 
identity in your git commits.

See 
https://www.openembedded.org/wiki/How_to_submit_a_patch_to_OpenEmbedded#Fixing_your_From_identity

Don't need to send your patches again, I will fix your last two commits 
by myself.

Thanks in advance for next time.
Cheers
Michael.

-- 
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [docs] [PATCH 2/2] ref-manual: classes: kernel: document automatic defconfig usage
  2023-05-05 16:40     ` Michael Opdenacker
@ 2023-05-05 16:49       ` Luca Ceresoli
  0 siblings, 0 replies; 5+ messages in thread
From: Luca Ceresoli @ 2023-05-05 16:49 UTC (permalink / raw)
  To: Michael Opdenacker; +Cc: docs

Hi Mike,

On Fri, 5 May 2023 18:40:21 +0200
Michael Opdenacker <michael.opdenacker@bootlin.com> wrote:

> Hi Luca,
> 
> On 05.05.23 at 17:10, Michael Opdenacker via lists.yoctoproject.org wrote:
> >
> > On 05.05.23 at 11:10, Luca Ceresoli via lists.yoctoproject.org wrote:  
> >> Since a very long time the kernel bbclass uses a defconfig file from
> >> SRC_URI automatically. Document this feature.
> >>
> >> Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>  
> >
> >
> > Hi Luca,
> >
> > That's great to document this behavior. Good catch!
> > For both patches: Reviewed-by: Michael Opdenacker 
> > <michael.opdenacker@bootlin.com>
> > ... and merged into "master-next".  
> 
> 
> Oops, I realize you should run a few git commands to have a proper 
> identity in your git commits.
> 
> See 
> https://www.openembedded.org/wiki/How_to_submit_a_patch_to_OpenEmbedded#Fixing_your_From_identity
> 
> Don't need to send your patches again, I will fix your last two commits 
> by myself.

My bad, I forgot to add --identity=yocto when running git send-email! I
now added it to the local git config for the various yocto
repositories, so it hopefully won't happen again.

> Thanks in advance for next time.

Thank you very much!

Cheers,
Luca

-- 
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2023-05-05 16:49 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-05  9:10 [PATCH 1/2] ref-manual: classes: kernel: remove incorrect sentence opening Luca Ceresoli
2023-05-05  9:10 ` [PATCH 2/2] ref-manual: classes: kernel: document automatic defconfig usage Luca Ceresoli
2023-05-05 15:10   ` [docs] " Michael Opdenacker
     [not found]   ` <175C47EAC5CB336C.898@lists.yoctoproject.org>
2023-05-05 16:40     ` Michael Opdenacker
2023-05-05 16:49       ` Luca Ceresoli

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.