All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] arm64: mm: use bitmap_zero() API
@ 2023-05-06  8:36 ` ye.xingchen
  0 siblings, 0 replies; 4+ messages in thread
From: ye.xingchen @ 2023-05-06  8:36 UTC (permalink / raw)
  To: broonie
  Cc: catalin.marinas, will, kristina.martsenko, linux-arm-kernel,
	linux-kernel

From: Ye Xingchen <ye.xingchen@zte.com.cn>

bitmap_zero() is faster than bitmap_clear(), so use bitmap_zero()
instead of bitmap_clear().

Signed-off-by: Ye Xingchen <ye.xingchen@zte.com.cn>
---
 arch/arm64/mm/context.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/mm/context.c b/arch/arm64/mm/context.c
index e1e0dca01839..ed0bf7f8e8ce 100644
--- a/arch/arm64/mm/context.c
+++ b/arch/arm64/mm/context.c
@@ -95,7 +95,7 @@ static void set_reserved_asid_bits(void)
 	else if (arm64_kernel_unmapped_at_el0())
 		set_kpti_asid_bits(asid_map);
 	else
-		bitmap_clear(asid_map, 0, NUM_USER_ASIDS);
+		bitmap_zero(asid_map, NUM_USER_ASIDS);
 }

 #define asid_gen_match(asid) \
-- 
2.25.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH] arm64: mm: use bitmap_zero() API
@ 2023-05-06  8:36 ` ye.xingchen
  0 siblings, 0 replies; 4+ messages in thread
From: ye.xingchen @ 2023-05-06  8:36 UTC (permalink / raw)
  To: broonie
  Cc: catalin.marinas, will, kristina.martsenko, linux-arm-kernel,
	linux-kernel

From: Ye Xingchen <ye.xingchen@zte.com.cn>

bitmap_zero() is faster than bitmap_clear(), so use bitmap_zero()
instead of bitmap_clear().

Signed-off-by: Ye Xingchen <ye.xingchen@zte.com.cn>
---
 arch/arm64/mm/context.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/mm/context.c b/arch/arm64/mm/context.c
index e1e0dca01839..ed0bf7f8e8ce 100644
--- a/arch/arm64/mm/context.c
+++ b/arch/arm64/mm/context.c
@@ -95,7 +95,7 @@ static void set_reserved_asid_bits(void)
 	else if (arm64_kernel_unmapped_at_el0())
 		set_kpti_asid_bits(asid_map);
 	else
-		bitmap_clear(asid_map, 0, NUM_USER_ASIDS);
+		bitmap_zero(asid_map, NUM_USER_ASIDS);
 }

 #define asid_gen_match(asid) \
-- 
2.25.1

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: mm: use bitmap_zero() API
  2023-05-06  8:36 ` ye.xingchen
@ 2023-05-16 13:24   ` Will Deacon
  -1 siblings, 0 replies; 4+ messages in thread
From: Will Deacon @ 2023-05-16 13:24 UTC (permalink / raw)
  To: ye.xingchen
  Cc: broonie, catalin.marinas, kristina.martsenko, linux-arm-kernel,
	linux-kernel

On Sat, May 06, 2023 at 04:36:31PM +0800, ye.xingchen@zte.com.cn wrote:
> From: Ye Xingchen <ye.xingchen@zte.com.cn>
> 
> bitmap_zero() is faster than bitmap_clear(), so use bitmap_zero()
> instead of bitmap_clear().

Is it? Don't these both boil down to:

	memset(asid_map, 0, NUM_USER_ASIDS / 8)

?

Will

> ---
>  arch/arm64/mm/context.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/mm/context.c b/arch/arm64/mm/context.c
> index e1e0dca01839..ed0bf7f8e8ce 100644
> --- a/arch/arm64/mm/context.c
> +++ b/arch/arm64/mm/context.c
> @@ -95,7 +95,7 @@ static void set_reserved_asid_bits(void)
>  	else if (arm64_kernel_unmapped_at_el0())
>  		set_kpti_asid_bits(asid_map);
>  	else
> -		bitmap_clear(asid_map, 0, NUM_USER_ASIDS);
> +		bitmap_zero(asid_map, NUM_USER_ASIDS);
>  }
> 
>  #define asid_gen_match(asid) \
> -- 
> 2.25.1

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: mm: use bitmap_zero() API
@ 2023-05-16 13:24   ` Will Deacon
  0 siblings, 0 replies; 4+ messages in thread
From: Will Deacon @ 2023-05-16 13:24 UTC (permalink / raw)
  To: ye.xingchen
  Cc: broonie, catalin.marinas, kristina.martsenko, linux-arm-kernel,
	linux-kernel

On Sat, May 06, 2023 at 04:36:31PM +0800, ye.xingchen@zte.com.cn wrote:
> From: Ye Xingchen <ye.xingchen@zte.com.cn>
> 
> bitmap_zero() is faster than bitmap_clear(), so use bitmap_zero()
> instead of bitmap_clear().

Is it? Don't these both boil down to:

	memset(asid_map, 0, NUM_USER_ASIDS / 8)

?

Will

> ---
>  arch/arm64/mm/context.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/mm/context.c b/arch/arm64/mm/context.c
> index e1e0dca01839..ed0bf7f8e8ce 100644
> --- a/arch/arm64/mm/context.c
> +++ b/arch/arm64/mm/context.c
> @@ -95,7 +95,7 @@ static void set_reserved_asid_bits(void)
>  	else if (arm64_kernel_unmapped_at_el0())
>  		set_kpti_asid_bits(asid_map);
>  	else
> -		bitmap_clear(asid_map, 0, NUM_USER_ASIDS);
> +		bitmap_zero(asid_map, NUM_USER_ASIDS);
>  }
> 
>  #define asid_gen_match(asid) \
> -- 
> 2.25.1

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-05-16 13:25 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-06  8:36 [PATCH] arm64: mm: use bitmap_zero() API ye.xingchen
2023-05-06  8:36 ` ye.xingchen
2023-05-16 13:24 ` Will Deacon
2023-05-16 13:24   ` Will Deacon

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.