* [PATCH 0/2] Add minor updates in device trees
@ 2023-05-10 12:32 Nitin Yadav
2023-05-10 12:32 ` [PATCH 1/2] arm64: dts: ti: k3-am62x-sk-common: Add main_uart1 and wkup_uart nodes Nitin Yadav
2023-05-10 12:32 ` [PATCH 2/2] arm64: dts: ti: k3-am62-main: add sa3_secproxy in cbass_main Nitin Yadav
0 siblings, 2 replies; 7+ messages in thread
From: Nitin Yadav @ 2023-05-10 12:32 UTC (permalink / raw)
To: nm, vigneshr, kristo, robh+dt, krzysztof.kozlowski+dt, conor+dt
Cc: linux-arm-kernel, devicetree, linux-kernel
Minor Device Tree updates to be able to use common Device
trees with u-boot. These updates include adding main_uart1
and wkup_uart1 into k3-am62x-sk-common.dtsi and sa3_secproxy
node in k3-am62-main.dtsi
Nitin Yadav (2):
arm64: dts: ti: k3-am62x-sk-common: Add main_uart1 and wkup_uart nodes
arm64: dts: ti: k3-am62-main: add sa3_secproxy in cbass_main
arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 9 +++++++
.../arm64/boot/dts/ti/k3-am62x-sk-common.dtsi | 26 +++++++++++++++++++
2 files changed, 35 insertions(+)
--
2.25.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/2] arm64: dts: ti: k3-am62x-sk-common: Add main_uart1 and wkup_uart nodes
2023-05-10 12:32 [PATCH 0/2] Add minor updates in device trees Nitin Yadav
@ 2023-05-10 12:32 ` Nitin Yadav
2023-05-30 17:50 ` Nishanth Menon
2023-05-10 12:32 ` [PATCH 2/2] arm64: dts: ti: k3-am62-main: add sa3_secproxy in cbass_main Nitin Yadav
1 sibling, 1 reply; 7+ messages in thread
From: Nitin Yadav @ 2023-05-10 12:32 UTC (permalink / raw)
To: nm, vigneshr, kristo, robh+dt, krzysztof.kozlowski+dt, conor+dt
Cc: linux-arm-kernel, devicetree, linux-kernel
wkup_uart and main_uart1 on this platform is used by TIFS and DM
firmwares. Describe pinmux and add aliases for completeness.
Signed-off-by: Nitin Yadav <n-yadav@ti.com>
---
.../arm64/boot/dts/ti/k3-am62x-sk-common.dtsi | 26 +++++++++++++++++++
1 file changed, 26 insertions(+)
diff --git a/arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi b/arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi
index 976f8303c84f..e29ea8ae2177 100644
--- a/arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi
@@ -12,7 +12,9 @@
/ {
aliases {
+ serial0 = &wkup_uart0;
serial2 = &main_uart0;
+ serial3 = &main_uart1;
mmc0 = &sdhci0;
mmc1 = &sdhci1;
mmc2 = &sdhci2;
@@ -127,6 +129,15 @@ AM62X_IOPAD(0x1cc, PIN_OUTPUT, 0) /* (E14/E11) UART0_TXD */
>;
};
+ main_uart1_pins_default: main-uart1-pins-default {
+ pinctrl-single,pins = <
+ AM62X_IOPAD(0x194, PIN_INPUT, 2) /* (B19) MCASP0_AXR3.UART1_CTSn */
+ AM62X_IOPAD(0x198, PIN_OUTPUT, 2) /* (A19) MCASP0_AXR2.UART1_RTSn */
+ AM62X_IOPAD(0x1ac, PIN_INPUT, 2) /* (E19) MCASP0_AFSR.UART1_RXD */
+ AM62X_IOPAD(0x1b0, PIN_OUTPUT, 2) /* (A20) MCAS/mP0_ACLKR.UART1_TXD */
+ >;
+ };
+
main_i2c0_pins_default: main-i2c0-pins-default {
pinctrl-single,pins = <
AM62X_IOPAD(0x1e0, PIN_INPUT_PULLUP, 0) /* (B16/E12) I2C0_SCL */
@@ -221,8 +232,21 @@ AM62X_IOPAD(0x084, PIN_INPUT, 2) /* (L23) GPMC0_ADVN_ALE.MCASP1_AXR2 */
};
};
+&mcu_pmx0 {
+ wkup_uart0_pins_default: wkup-uart0-pins-default {
+ pinctrl-single,pins = <
+ AM62X_MCU_IOPAD(0x02c, PIN_INPUT, 0) /* (C6) WKUP_UART0_CTSn */
+ AM62X_MCU_IOPAD(0x030, PIN_OUTPUT, 0) /* (A4) WKUP_UART0_RTSn */
+ AM62X_MCU_IOPAD(0x024, PIN_INPUT, 0) /* (B4) WKUP_UART0_RXD */
+ AM62X_MCU_IOPAD(0x028, PIN_OUTPUT, 0) /* (C5) WKUP_UART0_TXD */
+ >;
+ };
+};
+
&wkup_uart0 {
/* WKUP UART0 is used by DM firmware */
+ pinctrl-names = "default";
+ pinctrl-0 = <&wkup_uart0_pins_default>;
status = "reserved";
};
@@ -234,6 +258,8 @@ &main_uart0 {
&main_uart1 {
/* Main UART1 is used by TIFS firmware */
+ pinctrl-names = "default";
+ pinctrl-0 = <&main_uart1_pins_default>;
status = "reserved";
};
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 2/2] arm64: dts: ti: k3-am62-main: add sa3_secproxy in cbass_main
2023-05-10 12:32 [PATCH 0/2] Add minor updates in device trees Nitin Yadav
2023-05-10 12:32 ` [PATCH 1/2] arm64: dts: ti: k3-am62x-sk-common: Add main_uart1 and wkup_uart nodes Nitin Yadav
@ 2023-05-10 12:32 ` Nitin Yadav
2023-05-15 14:32 ` Nishanth Menon
1 sibling, 1 reply; 7+ messages in thread
From: Nitin Yadav @ 2023-05-10 12:32 UTC (permalink / raw)
To: nm, vigneshr, kristo, robh+dt, krzysztof.kozlowski+dt, conor+dt
Cc: linux-arm-kernel, devicetree, linux-kernel
Add sa3_secproxy node in k3-am62-main.dtsi to keep device tree
nodes in sync with u-boot nodes.
Signed-off-by: Nitin Yadav <n-yadav@ti.com>
---
arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
index b3e4857bbbe4..7c2af5b0e022 100644
--- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
@@ -42,6 +42,15 @@ gic_its: msi-controller@1820000 {
};
};
+ sa3_secproxy: secproxy@44880000 {
+ compatible = "ti,am654-secure-proxy";
+ #mbox-cells = <1>;
+ reg-names = "rt", "scfg", "target_data";
+ reg = <0x00 0x44880000 0x00 0x20000>,
+ <0x0 0x44860000 0x0 0x20000>,
+ <0x0 0x43600000 0x0 0x10000>;
+ };
+
main_conf: syscon@100000 {
compatible = "syscon", "simple-mfd";
reg = <0x00 0x00100000 0x00 0x20000>;
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] arm64: dts: ti: k3-am62-main: add sa3_secproxy in cbass_main
2023-05-10 12:32 ` [PATCH 2/2] arm64: dts: ti: k3-am62-main: add sa3_secproxy in cbass_main Nitin Yadav
@ 2023-05-15 14:32 ` Nishanth Menon
0 siblings, 0 replies; 7+ messages in thread
From: Nishanth Menon @ 2023-05-15 14:32 UTC (permalink / raw)
To: Nitin Yadav
Cc: vigneshr, kristo, robh+dt, krzysztof.kozlowski+dt, conor+dt,
linux-arm-kernel, devicetree, linux-kernel
On 18:02-20230510, Nitin Yadav wrote:
> Add sa3_secproxy node in k3-am62-main.dtsi to keep device tree
> nodes in sync with u-boot nodes.
>
> Signed-off-by: Nitin Yadav <n-yadav@ti.com>
> ---
> arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> index b3e4857bbbe4..7c2af5b0e022 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> @@ -42,6 +42,15 @@ gic_its: msi-controller@1820000 {
> };
> };
>
> + sa3_secproxy: secproxy@44880000 {
> + compatible = "ti,am654-secure-proxy";
> + #mbox-cells = <1>;
> + reg-names = "rt", "scfg", "target_data";
> + reg = <0x00 0x44880000 0x00 0x20000>,
> + <0x0 0x44860000 0x0 0x20000>,
> + <0x0 0x43600000 0x0 0x10000>;
be consistent with 0x00 instead of 0x0
You want this marked reserved and documented since it is to be used only by HSM
processors and NOT general processors.
> + };
> +
> main_conf: syscon@100000 {
> compatible = "syscon", "simple-mfd";
> reg = <0x00 0x00100000 0x00 0x20000>;
> --
> 2.25.1
>
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] arm64: dts: ti: k3-am62-main: add sa3_secproxy in cbass_main
@ 2023-05-15 14:32 ` Nishanth Menon
0 siblings, 0 replies; 7+ messages in thread
From: Nishanth Menon @ 2023-05-15 14:32 UTC (permalink / raw)
To: Nitin Yadav
Cc: vigneshr, kristo, robh+dt, krzysztof.kozlowski+dt, conor+dt,
linux-arm-kernel, devicetree, linux-kernel
On 18:02-20230510, Nitin Yadav wrote:
> Add sa3_secproxy node in k3-am62-main.dtsi to keep device tree
> nodes in sync with u-boot nodes.
>
> Signed-off-by: Nitin Yadav <n-yadav@ti.com>
> ---
> arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> index b3e4857bbbe4..7c2af5b0e022 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> @@ -42,6 +42,15 @@ gic_its: msi-controller@1820000 {
> };
> };
>
> + sa3_secproxy: secproxy@44880000 {
> + compatible = "ti,am654-secure-proxy";
> + #mbox-cells = <1>;
> + reg-names = "rt", "scfg", "target_data";
> + reg = <0x00 0x44880000 0x00 0x20000>,
> + <0x0 0x44860000 0x0 0x20000>,
> + <0x0 0x43600000 0x0 0x10000>;
be consistent with 0x00 instead of 0x0
You want this marked reserved and documented since it is to be used only by HSM
processors and NOT general processors.
> + };
> +
> main_conf: syscon@100000 {
> compatible = "syscon", "simple-mfd";
> reg = <0x00 0x00100000 0x00 0x20000>;
> --
> 2.25.1
>
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] arm64: dts: ti: k3-am62x-sk-common: Add main_uart1 and wkup_uart nodes
2023-05-10 12:32 ` [PATCH 1/2] arm64: dts: ti: k3-am62x-sk-common: Add main_uart1 and wkup_uart nodes Nitin Yadav
@ 2023-05-30 17:50 ` Nishanth Menon
0 siblings, 0 replies; 7+ messages in thread
From: Nishanth Menon @ 2023-05-30 17:50 UTC (permalink / raw)
To: Nitin Yadav
Cc: vigneshr, kristo, robh+dt, krzysztof.kozlowski+dt, conor+dt,
linux-arm-kernel, devicetree, linux-kernel
On 18:02-20230510, Nitin Yadav wrote:
> wkup_uart and main_uart1 on this platform is used by TIFS and DM
> firmwares. Describe pinmux and add aliases for completeness.
>
> Signed-off-by: Nitin Yadav <n-yadav@ti.com>
> ---
> .../arm64/boot/dts/ti/k3-am62x-sk-common.dtsi | 26 +++++++++++++++++++
> 1 file changed, 26 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi b/arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi
> index 976f8303c84f..e29ea8ae2177 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi
> @@ -12,7 +12,9 @@
>
> / {
> aliases {
> + serial0 = &wkup_uart0;
> serial2 = &main_uart0;
> + serial3 = &main_uart1;
> mmc0 = &sdhci0;
> mmc1 = &sdhci1;
> mmc2 = &sdhci2;
> @@ -127,6 +129,15 @@ AM62X_IOPAD(0x1cc, PIN_OUTPUT, 0) /* (E14/E11) UART0_TXD */
> >;
> };
>
> + main_uart1_pins_default: main-uart1-pins-default {
> + pinctrl-single,pins = <
> + AM62X_IOPAD(0x194, PIN_INPUT, 2) /* (B19) MCASP0_AXR3.UART1_CTSn */
> + AM62X_IOPAD(0x198, PIN_OUTPUT, 2) /* (A19) MCASP0_AXR2.UART1_RTSn */
> + AM62X_IOPAD(0x1ac, PIN_INPUT, 2) /* (E19) MCASP0_AFSR.UART1_RXD */
> + AM62X_IOPAD(0x1b0, PIN_OUTPUT, 2) /* (A20) MCAS/mP0_ACLKR.UART1_TXD */
In all places for sk-common.dtsi,
Could you fix the documentation in line with rest of the code?
/* First pad number is ALW package and second is AMC package */
[..]
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] arm64: dts: ti: k3-am62x-sk-common: Add main_uart1 and wkup_uart nodes
@ 2023-05-30 17:50 ` Nishanth Menon
0 siblings, 0 replies; 7+ messages in thread
From: Nishanth Menon @ 2023-05-30 17:50 UTC (permalink / raw)
To: Nitin Yadav
Cc: vigneshr, kristo, robh+dt, krzysztof.kozlowski+dt, conor+dt,
linux-arm-kernel, devicetree, linux-kernel
On 18:02-20230510, Nitin Yadav wrote:
> wkup_uart and main_uart1 on this platform is used by TIFS and DM
> firmwares. Describe pinmux and add aliases for completeness.
>
> Signed-off-by: Nitin Yadav <n-yadav@ti.com>
> ---
> .../arm64/boot/dts/ti/k3-am62x-sk-common.dtsi | 26 +++++++++++++++++++
> 1 file changed, 26 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi b/arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi
> index 976f8303c84f..e29ea8ae2177 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi
> @@ -12,7 +12,9 @@
>
> / {
> aliases {
> + serial0 = &wkup_uart0;
> serial2 = &main_uart0;
> + serial3 = &main_uart1;
> mmc0 = &sdhci0;
> mmc1 = &sdhci1;
> mmc2 = &sdhci2;
> @@ -127,6 +129,15 @@ AM62X_IOPAD(0x1cc, PIN_OUTPUT, 0) /* (E14/E11) UART0_TXD */
> >;
> };
>
> + main_uart1_pins_default: main-uart1-pins-default {
> + pinctrl-single,pins = <
> + AM62X_IOPAD(0x194, PIN_INPUT, 2) /* (B19) MCASP0_AXR3.UART1_CTSn */
> + AM62X_IOPAD(0x198, PIN_OUTPUT, 2) /* (A19) MCASP0_AXR2.UART1_RTSn */
> + AM62X_IOPAD(0x1ac, PIN_INPUT, 2) /* (E19) MCASP0_AFSR.UART1_RXD */
> + AM62X_IOPAD(0x1b0, PIN_OUTPUT, 2) /* (A20) MCAS/mP0_ACLKR.UART1_TXD */
In all places for sk-common.dtsi,
Could you fix the documentation in line with rest of the code?
/* First pad number is ALW package and second is AMC package */
[..]
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-05-30 17:51 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-10 12:32 [PATCH 0/2] Add minor updates in device trees Nitin Yadav
2023-05-10 12:32 ` [PATCH 1/2] arm64: dts: ti: k3-am62x-sk-common: Add main_uart1 and wkup_uart nodes Nitin Yadav
2023-05-30 17:50 ` Nishanth Menon
2023-05-30 17:50 ` Nishanth Menon
2023-05-10 12:32 ` [PATCH 2/2] arm64: dts: ti: k3-am62-main: add sa3_secproxy in cbass_main Nitin Yadav
2023-05-15 14:32 ` Nishanth Menon
2023-05-15 14:32 ` Nishanth Menon
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.