* [PATCH] firmware: ti_sci: Add missing LF in error message
@ 2023-05-09 21:38 Andreas Dannenberg
2023-05-10 15:46 ` Andrew Davis
2023-06-01 19:47 ` Tom Rini
0 siblings, 2 replies; 5+ messages in thread
From: Andreas Dannenberg @ 2023-05-09 21:38 UTC (permalink / raw)
To: trini, u-boot; +Cc: Andreas Dannenberg, Andrew Davis, Vignesh Raghavendra
The "Message not acknowledged" error message is missing a line feed,
leading to the console log getting garbled and joined together with
whatever the next output is in case this error happens:
"ti_sci system-controller@44043000: Message not acknowledgedAuthentication failed!"
Fix ths by adding the missing linefeed character.
Signed-off-by: Andreas Dannenberg <dannenberg@ti.com>
---
drivers/firmware/ti_sci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/firmware/ti_sci.c b/drivers/firmware/ti_sci.c
index bd7379ae55..72f572d824 100644
--- a/drivers/firmware/ti_sci.c
+++ b/drivers/firmware/ti_sci.c
@@ -265,7 +265,7 @@ static int ti_sci_do_xfer(struct ti_sci_info *info,
if (xfer->rx_len) {
ret = ti_sci_get_response(info, xfer, &info->chan_rx);
if (!ti_sci_is_response_ack(xfer->tx_message.buf)) {
- dev_err(info->dev, "Message not acknowledged");
+ dev_err(info->dev, "Message not acknowledged\n");
ret = -ENODEV;
}
}
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] firmware: ti_sci: Add missing LF in error message
2023-05-09 21:38 [PATCH] firmware: ti_sci: Add missing LF in error message Andreas Dannenberg
@ 2023-05-10 15:46 ` Andrew Davis
2023-05-10 16:09 ` Tom Rini
2023-06-01 19:47 ` Tom Rini
1 sibling, 1 reply; 5+ messages in thread
From: Andrew Davis @ 2023-05-10 15:46 UTC (permalink / raw)
To: Andreas Dannenberg, trini, u-boot; +Cc: Vignesh Raghavendra
On 5/9/23 4:38 PM, Andreas Dannenberg wrote:
> The "Message not acknowledged" error message is missing a line feed,
> leading to the console log getting garbled and joined together with
> whatever the next output is in case this error happens:
>
> "ti_sci system-controller@44043000: Message not acknowledgedAuthentication failed!"
>
> Fix ths by adding the missing linefeed character.
s/ths/this
>
> Signed-off-by: Andreas Dannenberg <dannenberg@ti.com>
> ---
Good find,
Acked-by: Andrew Davis <afd@ti.com>
> drivers/firmware/ti_sci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/ti_sci.c b/drivers/firmware/ti_sci.c
> index bd7379ae55..72f572d824 100644
> --- a/drivers/firmware/ti_sci.c
> +++ b/drivers/firmware/ti_sci.c
> @@ -265,7 +265,7 @@ static int ti_sci_do_xfer(struct ti_sci_info *info,
> if (xfer->rx_len) {
> ret = ti_sci_get_response(info, xfer, &info->chan_rx);
> if (!ti_sci_is_response_ack(xfer->tx_message.buf)) {
> - dev_err(info->dev, "Message not acknowledged");
> + dev_err(info->dev, "Message not acknowledged\n");
> ret = -ENODEV;
> }
> }
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] firmware: ti_sci: Add missing LF in error message
2023-05-10 15:46 ` Andrew Davis
@ 2023-05-10 16:09 ` Tom Rini
2023-05-10 18:22 ` [EXTERNAL] " Andreas Dannenberg
0 siblings, 1 reply; 5+ messages in thread
From: Tom Rini @ 2023-05-10 16:09 UTC (permalink / raw)
To: Andrew Davis; +Cc: Andreas Dannenberg, u-boot, Vignesh Raghavendra
[-- Attachment #1: Type: text/plain, Size: 713 bytes --]
On Wed, May 10, 2023 at 08:46:37AM -0700, Andrew Davis wrote:
> On 5/9/23 4:38 PM, Andreas Dannenberg wrote:
> > The "Message not acknowledged" error message is missing a line feed,
> > leading to the console log getting garbled and joined together with
> > whatever the next output is in case this error happens:
> >
> > "ti_sci system-controller@44043000: Message not acknowledgedAuthentication failed!"
> >
> > Fix ths by adding the missing linefeed character.
>
> s/ths/this
>
> >
> > Signed-off-by: Andreas Dannenberg <dannenberg@ti.com>
> > ---
>
> Good find,
I'll do my best to remember to fix this before pushing (checkpatch will
remind me, I think), no need to v2.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [EXTERNAL] Re: [PATCH] firmware: ti_sci: Add missing LF in error message
2023-05-10 16:09 ` Tom Rini
@ 2023-05-10 18:22 ` Andreas Dannenberg
0 siblings, 0 replies; 5+ messages in thread
From: Andreas Dannenberg @ 2023-05-10 18:22 UTC (permalink / raw)
To: Tom Rini; +Cc: Andrew Davis, u-boot, Vignesh Raghavendra
On Wed, May 10, 2023 at 12:09:47PM -0400, Tom Rini wrote:
> On Wed, May 10, 2023 at 08:46:37AM -0700, Andrew Davis wrote:
> > On 5/9/23 4:38 PM, Andreas Dannenberg wrote:
> > > The "Message not acknowledged" error message is missing a line feed,
> > > leading to the console log getting garbled and joined together with
> > > whatever the next output is in case this error happens:
> > >
> > > "ti_sci system-controller@44043000: Message not acknowledgedAuthentication failed!"
> > >
> > > Fix ths by adding the missing linefeed character.
> >
> > s/ths/this
This slipped through the cracks on my end...
> >
> > >
> > > Signed-off-by: Andreas Dannenberg <dannenberg@ti.com>
> > > ---
> >
> > Good find,
>
> I'll do my best to remember to fix this before pushing (checkpatch will
> remind me, I think), no need to v2.
Thanks Tom, I appreciate it.
--
Andreas Dannenberg
Texas Instruments Inc
>
> --
> Tom
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] firmware: ti_sci: Add missing LF in error message
2023-05-09 21:38 [PATCH] firmware: ti_sci: Add missing LF in error message Andreas Dannenberg
2023-05-10 15:46 ` Andrew Davis
@ 2023-06-01 19:47 ` Tom Rini
1 sibling, 0 replies; 5+ messages in thread
From: Tom Rini @ 2023-06-01 19:47 UTC (permalink / raw)
To: Andreas Dannenberg; +Cc: u-boot, Andrew Davis, Vignesh Raghavendra
[-- Attachment #1: Type: text/plain, Size: 568 bytes --]
On Tue, May 09, 2023 at 04:38:13PM -0500, Andreas Dannenberg wrote:
> The "Message not acknowledged" error message is missing a line feed,
> leading to the console log getting garbled and joined together with
> whatever the next output is in case this error happens:
>
> "ti_sci system-controller@44043000: Message not acknowledgedAuthentication failed!"
>
> Fix ths by adding the missing linefeed character.
>
> Signed-off-by: Andreas Dannenberg <dannenberg@ti.com>
> Acked-by: Andrew Davis <afd@ti.com>
Applied to u-boot/next, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-06-01 19:48 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-09 21:38 [PATCH] firmware: ti_sci: Add missing LF in error message Andreas Dannenberg
2023-05-10 15:46 ` Andrew Davis
2023-05-10 16:09 ` Tom Rini
2023-05-10 18:22 ` [EXTERNAL] " Andreas Dannenberg
2023-06-01 19:47 ` Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.