All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Rokosov <ddrokosov@sberdevices.ru>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: <neil.armstrong@linaro.org>, <jbrunet@baylibre.com>,
	<mturquette@baylibre.com>, <sboyd@kernel.org>,
	<robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
	<khilman@baylibre.com>, <jian.hu@amlogic.com>,
	<kernel@sberdevices.ru>, <rockosov@gmail.com>,
	<linux-amlogic@lists.infradead.org>, <linux-clk@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	Rob Herring <robh@kernel.org>
Subject: Re: [PATCH v14 5/6] dt-bindings: clock: meson: add A1 Peripherals clock controller bindings
Date: Thu, 11 May 2023 16:44:16 +0300	[thread overview]
Message-ID: <20230511134416.pw4led274g72z7e6@CAB-WSD-L081021> (raw)
In-Reply-To: <CAFBinCCdoaNuQymcjp5j9MHn2jpPWMqXe-+EgBo=5Ot8Bwaofw@mail.gmail.com>

Hello Martin,

Sorry for the delayed response as I was on vacation without laptop.

On Mon, May 01, 2023 at 08:51:30PM +0200, Martin Blumenstingl wrote:
> Hi Dmitry,
> 
> On Wed, Apr 26, 2023 at 11:58 AM Dmitry Rokosov
> <ddrokosov@sberdevices.ru> wrote:
> >
> > Add the documentation for Amlogic A1 Peripherals clock driver,
> > and A1 Peripherals clock controller bindings.
> Maybe a native English speaker can comment on whether it's
> "peripheral" or "peripherals".
> 

Ok

> [...]
> > Signed-off-by: Jian Hu <jian.hu@amlogic.com>
> > Signed-off-by: Dmitry Rokosov <ddrokosov@sberdevices.ru>
> > Reviewed-by: Rob Herring <robh@kernel.org>
> > ---
> >  .../bindings/clock/amlogic,a1-clkc.yaml       |  73 +++++++++++
> >  .../bindings/clock/amlogic,a1-pll-clkc.yaml   |   5 +-
> >  include/dt-bindings/clock/amlogic,a1-clkc.h   | 114 ++++++++++++++++++
> I have seen that Yu Tu named the S4 peripheral clock controller
> binding and driver "s4-peripherals-clkc" [0].
> Does it make sense to apply the same naming here as well?

Yes, it makes sense. I will prepare a new version with the necessary
renaming.

> 
> 
> Best regards,
> Martin
> 
> 
> [0] https://lore.kernel.org/linux-amlogic/20230417065005.24967-3-yu.tu@amlogic.com/

-- 
Thank you,
Dmitry

WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Rokosov <ddrokosov@sberdevices.ru>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: <neil.armstrong@linaro.org>, <jbrunet@baylibre.com>,
	<mturquette@baylibre.com>, <sboyd@kernel.org>,
	<robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
	<khilman@baylibre.com>, <jian.hu@amlogic.com>,
	<kernel@sberdevices.ru>, <rockosov@gmail.com>,
	<linux-amlogic@lists.infradead.org>, <linux-clk@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	Rob Herring <robh@kernel.org>
Subject: Re: [PATCH v14 5/6] dt-bindings: clock: meson: add A1 Peripherals clock controller bindings
Date: Thu, 11 May 2023 16:44:16 +0300	[thread overview]
Message-ID: <20230511134416.pw4led274g72z7e6@CAB-WSD-L081021> (raw)
In-Reply-To: <CAFBinCCdoaNuQymcjp5j9MHn2jpPWMqXe-+EgBo=5Ot8Bwaofw@mail.gmail.com>

Hello Martin,

Sorry for the delayed response as I was on vacation without laptop.

On Mon, May 01, 2023 at 08:51:30PM +0200, Martin Blumenstingl wrote:
> Hi Dmitry,
> 
> On Wed, Apr 26, 2023 at 11:58 AM Dmitry Rokosov
> <ddrokosov@sberdevices.ru> wrote:
> >
> > Add the documentation for Amlogic A1 Peripherals clock driver,
> > and A1 Peripherals clock controller bindings.
> Maybe a native English speaker can comment on whether it's
> "peripheral" or "peripherals".
> 

Ok

> [...]
> > Signed-off-by: Jian Hu <jian.hu@amlogic.com>
> > Signed-off-by: Dmitry Rokosov <ddrokosov@sberdevices.ru>
> > Reviewed-by: Rob Herring <robh@kernel.org>
> > ---
> >  .../bindings/clock/amlogic,a1-clkc.yaml       |  73 +++++++++++
> >  .../bindings/clock/amlogic,a1-pll-clkc.yaml   |   5 +-
> >  include/dt-bindings/clock/amlogic,a1-clkc.h   | 114 ++++++++++++++++++
> I have seen that Yu Tu named the S4 peripheral clock controller
> binding and driver "s4-peripherals-clkc" [0].
> Does it make sense to apply the same naming here as well?

Yes, it makes sense. I will prepare a new version with the necessary
renaming.

> 
> 
> Best regards,
> Martin
> 
> 
> [0] https://lore.kernel.org/linux-amlogic/20230417065005.24967-3-yu.tu@amlogic.com/

-- 
Thank you,
Dmitry

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

  parent reply	other threads:[~2023-05-11 13:44 UTC|newest]

Thread overview: 83+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-26  9:57 [PATCH v14 0/6] add Amlogic A1 clock controller drivers Dmitry Rokosov
2023-04-26  9:57 ` Dmitry Rokosov
2023-04-26  9:57 ` Dmitry Rokosov
2023-04-26  9:58 ` [PATCH v14 1/6] clk: meson: make pll rst bit as optional Dmitry Rokosov
2023-04-26  9:58   ` Dmitry Rokosov
2023-04-26  9:58   ` Dmitry Rokosov
2023-04-26  9:58 ` [PATCH v14 2/6] clk: meson: introduce new pll power-on sequence for A1 SoC family Dmitry Rokosov
2023-04-26  9:58   ` Dmitry Rokosov
2023-04-26  9:58   ` Dmitry Rokosov
2023-04-26  9:58 ` [PATCH v14 3/6] dt-bindings: clock: meson: add A1 PLL clock controller bindings Dmitry Rokosov
2023-04-26  9:58   ` Dmitry Rokosov
2023-04-26  9:58   ` Dmitry Rokosov
2023-05-01 18:52   ` Martin Blumenstingl
2023-05-01 18:52     ` Martin Blumenstingl
2023-05-01 18:52     ` Martin Blumenstingl
2023-04-26  9:58 ` [PATCH v14 4/6] clk: meson: a1: add Amlogic A1 PLL clock controller driver Dmitry Rokosov
2023-04-26  9:58   ` Dmitry Rokosov
2023-04-26  9:58   ` Dmitry Rokosov
2023-05-01 18:53   ` Martin Blumenstingl
2023-05-01 18:53     ` Martin Blumenstingl
2023-05-01 18:53     ` Martin Blumenstingl
2023-04-26  9:58 ` [PATCH v14 5/6] dt-bindings: clock: meson: add A1 Peripherals clock controller bindings Dmitry Rokosov
2023-04-26  9:58   ` Dmitry Rokosov
2023-04-26  9:58   ` Dmitry Rokosov
2023-05-01 18:51   ` Martin Blumenstingl
2023-05-01 18:51     ` Martin Blumenstingl
2023-05-01 18:51     ` Martin Blumenstingl
2023-05-02  1:38     ` Christian Hewitt
2023-05-02  1:38       ` Christian Hewitt
2023-05-02  1:38       ` Christian Hewitt
2023-05-02  7:39       ` Krzysztof Kozlowski
2023-05-02  7:39         ` Krzysztof Kozlowski
2023-05-02  7:39         ` Krzysztof Kozlowski
2023-05-11 13:50         ` Dmitry Rokosov
2023-05-11 13:50           ` Dmitry Rokosov
2023-05-11 13:46       ` Dmitry Rokosov
2023-05-11 13:46         ` Dmitry Rokosov
2023-05-11 13:44     ` Dmitry Rokosov [this message]
2023-05-11 13:44       ` Dmitry Rokosov
2023-04-26  9:58 ` [PATCH v14 6/6] clk: meson: a1: add Amlogic A1 Peripherals clock controller driver Dmitry Rokosov
2023-04-26  9:58   ` Dmitry Rokosov
2023-04-26  9:58   ` Dmitry Rokosov
2023-05-01 19:06   ` Martin Blumenstingl
2023-05-01 19:06     ` Martin Blumenstingl
2023-05-01 19:06     ` Martin Blumenstingl
2023-05-12 14:06     ` Dmitry Rokosov
2023-05-12 14:06       ` Dmitry Rokosov
2023-05-16 21:10       ` Martin Blumenstingl
2023-05-16 21:10         ` Martin Blumenstingl
2023-05-16 21:10         ` Martin Blumenstingl
2023-05-17 10:34         ` Dmitry Rokosov
2023-05-17 10:34           ` Dmitry Rokosov
2023-05-17 10:34           ` Dmitry Rokosov
2023-05-18 20:04           ` Martin Blumenstingl
2023-05-18 20:04             ` Martin Blumenstingl
2023-05-18 20:04             ` Martin Blumenstingl
2023-05-19 15:07             ` Dmitry Rokosov
2023-05-19 15:07               ` Dmitry Rokosov
2023-05-19 15:07               ` Dmitry Rokosov
2023-05-19 16:10             ` Heiner Kallweit
2023-05-19 16:10               ` Heiner Kallweit
2023-05-19 16:10               ` Heiner Kallweit
2023-05-22 13:44               ` Dmitry Rokosov
2023-05-22 13:44                 ` Dmitry Rokosov
2023-05-22 13:44                 ` Dmitry Rokosov
2023-05-22 20:35                 ` Heiner Kallweit
2023-05-22 20:35                   ` Heiner Kallweit
2023-05-22 20:35                   ` Heiner Kallweit
2023-05-23  9:42                   ` Старк Георгий Николаевич
2023-05-23  9:42                     ` Старк Георгий Николаевич
2023-05-23  9:42                     ` Старк Георгий Николаевич
2023-05-23 10:23                   ` Dmitry Rokosov
2023-05-23 10:23                     ` Dmitry Rokosov
2023-05-23 10:23                     ` Dmitry Rokosov
2023-05-23 19:13                     ` Heiner Kallweit
2023-05-23 19:13                       ` Heiner Kallweit
2023-05-23 19:13                       ` Heiner Kallweit
2023-05-24  9:27                       ` Dmitry Rokosov
2023-05-24  9:27                         ` Dmitry Rokosov
2023-05-24  9:27                         ` Dmitry Rokosov
2023-05-24  0:52                   ` George Stark
2023-05-24  0:52                     ` George Stark
2023-05-24  0:52                     ` George Stark

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230511134416.pw4led274g72z7e6@CAB-WSD-L081021 \
    --to=ddrokosov@sberdevices.ru \
    --cc=devicetree@vger.kernel.org \
    --cc=jbrunet@baylibre.com \
    --cc=jian.hu@amlogic.com \
    --cc=kernel@sberdevices.ru \
    --cc=khilman@baylibre.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=mturquette@baylibre.com \
    --cc=neil.armstrong@linaro.org \
    --cc=robh+dt@kernel.org \
    --cc=robh@kernel.org \
    --cc=rockosov@gmail.com \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.