* [PATCH v2 net-next] net: ethernet: mtk_eth_soc: log clock enable errors
@ 2023-05-10 18:13 Lorenz Brun
2023-05-12 1:06 ` Jakub Kicinski
0 siblings, 1 reply; 2+ messages in thread
From: Lorenz Brun @ 2023-05-10 18:13 UTC (permalink / raw)
To: Felix Fietkau, John Crispin, Sean Wang, Mark Lee,
Lorenzo Bianconi, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Matthias Brugger, AngeloGioacchino Del Regno
Cc: netdev, linux-kernel, linux-arm-kernel, linux-mediatek
Currently errors in clk_prepare_enable are silently swallowed.
Add a log stating which clock failed to be enabled and what the error
code was.
Signed-off-by: Lorenz Brun <lorenz@brun.one>
---
v2: reflowed long line
---
drivers/net/ethernet/mediatek/mtk_eth_soc.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
index e14050e17862..ced12e5b7b32 100644
--- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
+++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
@@ -3445,8 +3445,11 @@ static int mtk_clk_enable(struct mtk_eth *eth)
for (clk = 0; clk < MTK_CLK_MAX ; clk++) {
ret = clk_prepare_enable(eth->clks[clk]);
- if (ret)
+ if (ret) {
+ dev_err(eth->dev, "enabling clock %s failed with error %d\n",
+ mtk_clks_source_name[clk], ret);
goto err_disable_clks;
+ }
}
return 0;
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2 net-next] net: ethernet: mtk_eth_soc: log clock enable errors
2023-05-10 18:13 [PATCH v2 net-next] net: ethernet: mtk_eth_soc: log clock enable errors Lorenz Brun
@ 2023-05-12 1:06 ` Jakub Kicinski
0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2023-05-12 1:06 UTC (permalink / raw)
To: Lorenz Brun
Cc: Felix Fietkau, John Crispin, Sean Wang, Mark Lee,
Lorenzo Bianconi, David S. Miller, Eric Dumazet, Paolo Abeni,
Matthias Brugger, AngeloGioacchino Del Regno, netdev,
linux-kernel, linux-arm-kernel, linux-mediatek
On Wed, 10 May 2023 20:13:50 +0200 Lorenz Brun wrote:
> for (clk = 0; clk < MTK_CLK_MAX ; clk++) {
> ret = clk_prepare_enable(eth->clks[clk]);
> - if (ret)
> + if (ret) {
> + dev_err(eth->dev, "enabling clock %s failed with error %d\n",
> + mtk_clks_source_name[clk], ret);
> goto err_disable_clks;
> + }
dev_err_probe() would be even better, I think?
--
pw-bot: cr
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-05-12 1:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-10 18:13 [PATCH v2 net-next] net: ethernet: mtk_eth_soc: log clock enable errors Lorenz Brun
2023-05-12 1:06 ` Jakub Kicinski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.