* [PATCH] drm/i915/selftest/gsc: Ensure GSC Proxy init completes before selftests
@ 2023-05-12 23:58 ` Alan Previn
0 siblings, 0 replies; 6+ messages in thread
From: Alan Previn @ 2023-05-12 23:58 UTC (permalink / raw)
To: intel-gfx; +Cc: Daniele Ceraolo Spurio, dri-devel, Alan Previn
On MTL, if the GSC Proxy init flows haven't completed, submissions to the
GSC engine will fail. Those init flows are dependent on the mei's
gsc_proxy component that is loaded in parallel with i915 and a
worker that could potentially start after i915 driver init is done.
That said, all subsytems that access the GSC engine today does check
for such init flow completion before using the GSC engine. However,
selftests currently don't wait on anything before starting.
To fix this, add a waiter function at the start of __run_selftests
that waits for gsc-proxy init flows to complete. While implementing this,
use an table of function pointers so its scalable to add additional
waiter functions for future such "wait on dependency" cases that.
Signed-off-by: Alan Previn <alan.previn.teres.alexis@intel.com>
---
.../gpu/drm/i915/selftests/i915_selftest.c | 53 +++++++++++++++++++
1 file changed, 53 insertions(+)
diff --git a/drivers/gpu/drm/i915/selftests/i915_selftest.c b/drivers/gpu/drm/i915/selftests/i915_selftest.c
index 39da0fb0d6d2..a05effdbce94 100644
--- a/drivers/gpu/drm/i915/selftests/i915_selftest.c
+++ b/drivers/gpu/drm/i915/selftests/i915_selftest.c
@@ -24,6 +24,8 @@
#include <linux/random.h>
#include "gt/intel_gt_pm.h"
+#include "gt/uc/intel_gsc_fw.h"
+
#include "i915_driver.h"
#include "i915_drv.h"
#include "i915_selftest.h"
@@ -127,6 +129,55 @@ static void set_default_test_all(struct selftest *st, unsigned int count)
st[i].enabled = true;
}
+static int
+__wait_gsc_proxy_completed(struct drm_i915_private *i915,
+ unsigned long timeout_ms)
+{
+ bool need_to_wait = (IS_ENABLED(CONFIG_INTEL_MEI_GSC_PROXY) &&
+ i915->media_gt &&
+ HAS_ENGINE(i915->media_gt, GSC0) &&
+ intel_uc_fw_is_loadable(&i915->media_gt->uc.gsc.fw));
+
+ if (need_to_wait &&
+ (wait_for(intel_gsc_uc_fw_proxy_init_done(&i915->media_gt->uc.gsc),
+ timeout_ms)))
+ return -ETIME;
+
+ return 0;
+}
+
+struct __startup_waiter {
+ const char *name;
+ int (*wait_to_completed)(struct drm_i915_private *i915, unsigned long timeout_ms);
+};
+
+static struct __startup_waiter all_startup_waiters[] = { \
+ {"gsc_proxy", __wait_gsc_proxy_completed} \
+ };
+
+static int __wait_on_all_system_dependencies(struct drm_i915_private *i915)
+{
+ struct __startup_waiter *waiter = all_startup_waiters;
+ int count = ARRAY_SIZE(all_startup_waiters);
+ int ret;
+
+ if (!waiter || !count || !i915)
+ return 0;
+
+ for (; count--; waiter++) {
+ if (!waiter->wait_to_completed)
+ continue;
+ ret = waiter->wait_to_completed(i915, i915_selftest.timeout_ms);
+ if (ret) {
+ pr_info(DRIVER_NAME ": Pre-selftest waiter %s failed with %d\n",
+ waiter->name, ret);
+ return ret;
+ }
+ }
+
+ return 0;
+}
+
static int __run_selftests(const char *name,
struct selftest *st,
unsigned int count,
@@ -134,6 +185,8 @@ static int __run_selftests(const char *name,
{
int err = 0;
+ __wait_on_all_system_dependencies(data);
+
while (!i915_selftest.random_seed)
i915_selftest.random_seed = get_random_u32();
base-commit: 222ff19f23b0bd6aca0b52001d69699f78f5a206
--
2.39.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Intel-gfx] [PATCH] drm/i915/selftest/gsc: Ensure GSC Proxy init completes before selftests
@ 2023-05-12 23:58 ` Alan Previn
0 siblings, 0 replies; 6+ messages in thread
From: Alan Previn @ 2023-05-12 23:58 UTC (permalink / raw)
To: intel-gfx; +Cc: dri-devel, Alan Previn
On MTL, if the GSC Proxy init flows haven't completed, submissions to the
GSC engine will fail. Those init flows are dependent on the mei's
gsc_proxy component that is loaded in parallel with i915 and a
worker that could potentially start after i915 driver init is done.
That said, all subsytems that access the GSC engine today does check
for such init flow completion before using the GSC engine. However,
selftests currently don't wait on anything before starting.
To fix this, add a waiter function at the start of __run_selftests
that waits for gsc-proxy init flows to complete. While implementing this,
use an table of function pointers so its scalable to add additional
waiter functions for future such "wait on dependency" cases that.
Signed-off-by: Alan Previn <alan.previn.teres.alexis@intel.com>
---
.../gpu/drm/i915/selftests/i915_selftest.c | 53 +++++++++++++++++++
1 file changed, 53 insertions(+)
diff --git a/drivers/gpu/drm/i915/selftests/i915_selftest.c b/drivers/gpu/drm/i915/selftests/i915_selftest.c
index 39da0fb0d6d2..a05effdbce94 100644
--- a/drivers/gpu/drm/i915/selftests/i915_selftest.c
+++ b/drivers/gpu/drm/i915/selftests/i915_selftest.c
@@ -24,6 +24,8 @@
#include <linux/random.h>
#include "gt/intel_gt_pm.h"
+#include "gt/uc/intel_gsc_fw.h"
+
#include "i915_driver.h"
#include "i915_drv.h"
#include "i915_selftest.h"
@@ -127,6 +129,55 @@ static void set_default_test_all(struct selftest *st, unsigned int count)
st[i].enabled = true;
}
+static int
+__wait_gsc_proxy_completed(struct drm_i915_private *i915,
+ unsigned long timeout_ms)
+{
+ bool need_to_wait = (IS_ENABLED(CONFIG_INTEL_MEI_GSC_PROXY) &&
+ i915->media_gt &&
+ HAS_ENGINE(i915->media_gt, GSC0) &&
+ intel_uc_fw_is_loadable(&i915->media_gt->uc.gsc.fw));
+
+ if (need_to_wait &&
+ (wait_for(intel_gsc_uc_fw_proxy_init_done(&i915->media_gt->uc.gsc),
+ timeout_ms)))
+ return -ETIME;
+
+ return 0;
+}
+
+struct __startup_waiter {
+ const char *name;
+ int (*wait_to_completed)(struct drm_i915_private *i915, unsigned long timeout_ms);
+};
+
+static struct __startup_waiter all_startup_waiters[] = { \
+ {"gsc_proxy", __wait_gsc_proxy_completed} \
+ };
+
+static int __wait_on_all_system_dependencies(struct drm_i915_private *i915)
+{
+ struct __startup_waiter *waiter = all_startup_waiters;
+ int count = ARRAY_SIZE(all_startup_waiters);
+ int ret;
+
+ if (!waiter || !count || !i915)
+ return 0;
+
+ for (; count--; waiter++) {
+ if (!waiter->wait_to_completed)
+ continue;
+ ret = waiter->wait_to_completed(i915, i915_selftest.timeout_ms);
+ if (ret) {
+ pr_info(DRIVER_NAME ": Pre-selftest waiter %s failed with %d\n",
+ waiter->name, ret);
+ return ret;
+ }
+ }
+
+ return 0;
+}
+
static int __run_selftests(const char *name,
struct selftest *st,
unsigned int count,
@@ -134,6 +185,8 @@ static int __run_selftests(const char *name,
{
int err = 0;
+ __wait_on_all_system_dependencies(data);
+
while (!i915_selftest.random_seed)
i915_selftest.random_seed = get_random_u32();
base-commit: 222ff19f23b0bd6aca0b52001d69699f78f5a206
--
2.39.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/selftest/gsc: Ensure GSC Proxy init completes before selftests
2023-05-12 23:58 ` [Intel-gfx] " Alan Previn
(?)
@ 2023-05-13 1:14 ` Patchwork
-1 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2023-05-13 1:14 UTC (permalink / raw)
To: Teres Alexis, Alan Previn; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/selftest/gsc: Ensure GSC Proxy init completes before selftests
URL : https://patchwork.freedesktop.org/series/117713/
State : warning
== Summary ==
Error: dim checkpatch failed
b97349ae2b23 drm/i915/selftest/gsc: Ensure GSC Proxy init completes before selftests
-:62: WARNING:LINE_CONTINUATIONS: Avoid unnecessary line continuations
#62: FILE: drivers/gpu/drm/i915/selftests/i915_selftest.c:154:
+static struct __startup_waiter all_startup_waiters[] = { \
total: 0 errors, 1 warnings, 0 checks, 71 lines checked
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftest/gsc: Ensure GSC Proxy init completes before selftests
2023-05-12 23:58 ` [Intel-gfx] " Alan Previn
(?)
(?)
@ 2023-05-13 1:29 ` Patchwork
-1 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2023-05-13 1:29 UTC (permalink / raw)
To: Teres Alexis, Alan Previn; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 6255 bytes --]
== Series Details ==
Series: drm/i915/selftest/gsc: Ensure GSC Proxy init completes before selftests
URL : https://patchwork.freedesktop.org/series/117713/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13143 -> Patchwork_117713v1
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117713v1/index.html
Participating hosts (38 -> 37)
------------------------------
Missing (1): fi-snb-2520m
Known issues
------------
Here are the changes found in Patchwork_117713v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_pm_backlight@basic-brightness@edp-1:
- bat-rplp-1: NOTRUN -> [ABORT][1] ([i915#7077])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117713v1/bat-rplp-1/igt@i915_pm_backlight@basic-brightness@edp-1.html
* igt@i915_selftest@live@slpc:
- bat-rpls-2: NOTRUN -> [DMESG-WARN][2] ([i915#6367])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117713v1/bat-rpls-2/igt@i915_selftest@live@slpc.html
- bat-rpls-1: NOTRUN -> [DMESG-WARN][3] ([i915#6367] / [i915#7953])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117713v1/bat-rpls-1/igt@i915_selftest@live@slpc.html
* igt@i915_selftest@live@workarounds:
- bat-adlm-1: [PASS][4] -> [DMESG-FAIL][5] ([i915#7904])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13143/bat-adlm-1/igt@i915_selftest@live@workarounds.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117713v1/bat-adlm-1/igt@i915_selftest@live@workarounds.html
* igt@i915_suspend@basic-s2idle-without-i915:
- bat-rpls-2: NOTRUN -> [ABORT][6] ([i915#6687])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117713v1/bat-rpls-2/igt@i915_suspend@basic-s2idle-without-i915.html
* igt@i915_suspend@basic-s3-without-i915:
- bat-rpls-1: NOTRUN -> [ABORT][7] ([i915#6687] / [i915#7953] / [i915#7978])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117713v1/bat-rpls-1/igt@i915_suspend@basic-s3-without-i915.html
* igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence:
- bat-dg2-11: NOTRUN -> [SKIP][8] ([i915#1845] / [i915#5354]) +2 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117713v1/bat-dg2-11/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence.html
#### Possible fixes ####
* igt@i915_selftest@live@gt_heartbeat:
- fi-apl-guc: [DMESG-FAIL][9] ([i915#5334]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13143/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117713v1/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
* igt@i915_selftest@live@reset:
- bat-rpls-2: [ABORT][11] ([i915#4983] / [i915#7461] / [i915#7913] / [i915#8347]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13143/bat-rpls-2/igt@i915_selftest@live@reset.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117713v1/bat-rpls-2/igt@i915_selftest@live@reset.html
- bat-rpls-1: [ABORT][13] ([i915#4983] / [i915#7461] / [i915#7953] / [i915#8347] / [i915#8384]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13143/bat-rpls-1/igt@i915_selftest@live@reset.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117713v1/bat-rpls-1/igt@i915_selftest@live@reset.html
* igt@i915_selftest@live@slpc:
- {bat-mtlp-6}: [DMESG-WARN][15] ([i915#6367] / [i915#7953]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13143/bat-mtlp-6/igt@i915_selftest@live@slpc.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117713v1/bat-mtlp-6/igt@i915_selftest@live@slpc.html
#### Warnings ####
* igt@kms_setmode@basic-clone-single-crtc:
- bat-rplp-1: [ABORT][17] ([i915#4579] / [i915#8260]) -> [SKIP][18] ([i915#3555] / [i915#4579])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13143/bat-rplp-1/igt@kms_setmode@basic-clone-single-crtc.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117713v1/bat-rplp-1/igt@kms_setmode@basic-clone-single-crtc.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6687]: https://gitlab.freedesktop.org/drm/intel/issues/6687
[i915#7077]: https://gitlab.freedesktop.org/drm/intel/issues/7077
[i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461
[i915#7904]: https://gitlab.freedesktop.org/drm/intel/issues/7904
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#7953]: https://gitlab.freedesktop.org/drm/intel/issues/7953
[i915#7978]: https://gitlab.freedesktop.org/drm/intel/issues/7978
[i915#8260]: https://gitlab.freedesktop.org/drm/intel/issues/8260
[i915#8347]: https://gitlab.freedesktop.org/drm/intel/issues/8347
[i915#8384]: https://gitlab.freedesktop.org/drm/intel/issues/8384
Build changes
-------------
* Linux: CI_DRM_13143 -> Patchwork_117713v1
CI-20190529: 20190529
CI_DRM_13143: 222ff19f23b0bd6aca0b52001d69699f78f5a206 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7286: a482779488f11c432d7ddcb1980691ab1603f356 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_117713v1: 222ff19f23b0bd6aca0b52001d69699f78f5a206 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
ceff2c212ae7 drm/i915/selftest/gsc: Ensure GSC Proxy init completes before selftests
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117713v1/index.html
[-- Attachment #2: Type: text/html, Size: 7790 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/selftest/gsc: Ensure GSC Proxy init completes before selftests
2023-05-12 23:58 ` [Intel-gfx] " Alan Previn
` (2 preceding siblings ...)
(?)
@ 2023-05-13 4:55 ` Patchwork
2023-05-24 17:15 ` Teres Alexis, Alan Previn
-1 siblings, 1 reply; 6+ messages in thread
From: Patchwork @ 2023-05-13 4:55 UTC (permalink / raw)
To: Teres Alexis, Alan Previn; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 11642 bytes --]
== Series Details ==
Series: drm/i915/selftest/gsc: Ensure GSC Proxy init completes before selftests
URL : https://patchwork.freedesktop.org/series/117713/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_13143_full -> Patchwork_117713v1_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_117713v1_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_117713v1_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Participating hosts (7 -> 7)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_117713v1_full:
### IGT changes ###
#### Possible regressions ####
* igt@kms_plane@plane-panning-bottom-right-suspend@pipe-b-planes:
- shard-apl: [PASS][1] -> [ABORT][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13143/shard-apl7/igt@kms_plane@plane-panning-bottom-right-suspend@pipe-b-planes.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117713v1/shard-apl2/igt@kms_plane@plane-panning-bottom-right-suspend@pipe-b-planes.html
Known issues
------------
Here are the changes found in Patchwork_117713v1_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [PASS][3] -> [FAIL][4] ([i915#2842])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13143/shard-glk2/igt@gem_exec_fair@basic-pace-share@rcs0.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117713v1/shard-glk1/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_lmem_swapping@massive-random:
- shard-glk: NOTRUN -> [SKIP][5] ([fdo#109271] / [i915#4613])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117713v1/shard-glk2/igt@gem_lmem_swapping@massive-random.html
* igt@gem_ppgtt@blt-vs-render-ctx0:
- shard-snb: [PASS][6] -> [DMESG-FAIL][7] ([i915#8295])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13143/shard-snb4/igt@gem_ppgtt@blt-vs-render-ctx0.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117713v1/shard-snb6/igt@gem_ppgtt@blt-vs-render-ctx0.html
* igt@gen9_exec_parse@allowed-single:
- shard-apl: [PASS][8] -> [ABORT][9] ([i915#5566])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13143/shard-apl2/igt@gen9_exec_parse@allowed-single.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117713v1/shard-apl3/igt@gen9_exec_parse@allowed-single.html
* igt@kms_chamelium_color@ctm-max:
- shard-glk: NOTRUN -> [SKIP][10] ([fdo#109271]) +24 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117713v1/shard-glk2/igt@kms_chamelium_color@ctm-max.html
* igt@kms_content_protection@atomic:
- shard-glk: NOTRUN -> [SKIP][11] ([fdo#109271] / [i915#4579])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117713v1/shard-glk2/igt@kms_content_protection@atomic.html
#### Possible fixes ####
* igt@drm_fdinfo@most-busy-idle-check-all@rcs0:
- {shard-rkl}: [FAIL][12] ([i915#7742]) -> [PASS][13] +1 similar issue
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13143/shard-rkl-2/igt@drm_fdinfo@most-busy-idle-check-all@rcs0.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117713v1/shard-rkl-3/igt@drm_fdinfo@most-busy-idle-check-all@rcs0.html
* igt@gem_ctx_freq@sysfs:
- {shard-dg1}: [FAIL][14] ([i915#6786]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13143/shard-dg1-15/igt@gem_ctx_freq@sysfs.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117713v1/shard-dg1-14/igt@gem_ctx_freq@sysfs.html
* igt@gem_eio@hibernate:
- {shard-dg1}: [ABORT][16] ([i915#7975] / [i915#8213]) -> [PASS][17] +1 similar issue
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13143/shard-dg1-14/igt@gem_eio@hibernate.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117713v1/shard-dg1-17/igt@gem_eio@hibernate.html
* igt@gem_eio@in-flight-contexts-10ms:
- {shard-tglu}: [TIMEOUT][18] ([i915#3063] / [i915#7941]) -> [PASS][19]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13143/shard-tglu-3/igt@gem_eio@in-flight-contexts-10ms.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117713v1/shard-tglu-2/igt@gem_eio@in-flight-contexts-10ms.html
* igt@gem_lmem_swapping@smem-oom@lmem0:
- {shard-dg1}: [TIMEOUT][20] ([i915#5493]) -> [PASS][21]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13143/shard-dg1-17/igt@gem_lmem_swapping@smem-oom@lmem0.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117713v1/shard-dg1-14/igt@gem_lmem_swapping@smem-oom@lmem0.html
* igt@gen9_exec_parse@allowed-single:
- shard-glk: [ABORT][22] ([i915#5566]) -> [PASS][23]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13143/shard-glk1/igt@gen9_exec_parse@allowed-single.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117713v1/shard-glk2/igt@gen9_exec_parse@allowed-single.html
* igt@i915_pm_rpm@dpms-lpsp:
- {shard-rkl}: [SKIP][24] ([i915#1397]) -> [PASS][25]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13143/shard-rkl-4/igt@i915_pm_rpm@dpms-lpsp.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117713v1/shard-rkl-7/igt@i915_pm_rpm@dpms-lpsp.html
* igt@kms_cursor_legacy@single-bo@pipe-b:
- {shard-rkl}: [INCOMPLETE][26] ([i915#8011]) -> [PASS][27]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13143/shard-rkl-7/igt@kms_cursor_legacy@single-bo@pipe-b.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117713v1/shard-rkl-4/igt@kms_cursor_legacy@single-bo@pipe-b.html
* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ac-hdmi-a1-hdmi-a2:
- shard-glk: [FAIL][28] ([i915#79]) -> [PASS][29]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13143/shard-glk2/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ac-hdmi-a1-hdmi-a2.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117713v1/shard-glk6/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ac-hdmi-a1-hdmi-a2.html
#### Warnings ####
* igt@kms_content_protection@mei_interface:
- shard-snb: [SKIP][30] ([fdo#109271] / [i915#4579]) -> [SKIP][31] ([fdo#109271])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13143/shard-snb4/igt@kms_content_protection@mei_interface.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117713v1/shard-snb2/igt@kms_content_protection@mei_interface.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#3063]: https://gitlab.freedesktop.org/drm/intel/issues/3063
[i915#315]: https://gitlab.freedesktop.org/drm/intel/issues/315
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3952]: https://gitlab.freedesktop.org/drm/intel/issues/3952
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4771]: https://gitlab.freedesktop.org/drm/intel/issues/4771
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4816]: https://gitlab.freedesktop.org/drm/intel/issues/4816
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#4873]: https://gitlab.freedesktop.org/drm/intel/issues/4873
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#5493]: https://gitlab.freedesktop.org/drm/intel/issues/5493
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6786]: https://gitlab.freedesktop.org/drm/intel/issues/6786
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#7941]: https://gitlab.freedesktop.org/drm/intel/issues/7941
[i915#7975]: https://gitlab.freedesktop.org/drm/intel/issues/7975
[i915#8011]: https://gitlab.freedesktop.org/drm/intel/issues/8011
[i915#8213]: https://gitlab.freedesktop.org/drm/intel/issues/8213
[i915#8295]: https://gitlab.freedesktop.org/drm/intel/issues/8295
[i915#8414]: https://gitlab.freedesktop.org/drm/intel/issues/8414
Build changes
-------------
* Linux: CI_DRM_13143 -> Patchwork_117713v1
CI-20190529: 20190529
CI_DRM_13143: 222ff19f23b0bd6aca0b52001d69699f78f5a206 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7286: a482779488f11c432d7ddcb1980691ab1603f356 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_117713v1: 222ff19f23b0bd6aca0b52001d69699f78f5a206 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117713v1/index.html
[-- Attachment #2: Type: text/html, Size: 10212 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/selftest/gsc: Ensure GSC Proxy init completes before selftests
2023-05-13 4:55 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
@ 2023-05-24 17:15 ` Teres Alexis, Alan Previn
0 siblings, 0 replies; 6+ messages in thread
From: Teres Alexis, Alan Previn @ 2023-05-24 17:15 UTC (permalink / raw)
To: intel-gfx
The error below seems unrelated to the change in this patch. In fact test below fails on APL which wont excersize the patch code change.
However, from internal testing we did see cases where CI's selftest timeout is lower than the GSC Proxy requires to complete
(i.e. the selftest would bail with timeout because it was waiting for the GSC proxy to complete but the completion came in after the timeout).
So might need to re-rev this anyway with a longer timeout. (which typically takes longer for first time boot, not at driver-reload or suspend-resume)
...alan
On Sat, 2023-05-13 at 04:55 +0000, Patchwork wrote:
> Patch Details
> Series: drm/i915/selftest/gsc: Ensure GSC Proxy init completes before selftests
> URL: https://patchwork.freedesktop.org/series/117713/
> State: failure
> Details: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117713v1/index.html
> CI Bug Log - changes from CI_DRM_13143_full -> Patchwork_117713v1_full
> Summary
>
> FAILURE
>
> Serious unknown changes coming with Patchwork_117713v1_full absolutely need to be
> verified manually.
>
> If you think the reported changes have nothing to do with the changes
> introduced in Patchwork_117713v1_full, please notify your bug team to allow them
> to document this new failure mode, which will reduce false positives in CI.
>
> Participating hosts (7 -> 7)
>
> No changes in participating hosts
>
> Possible new issues
>
> Here are the unknown changes that may have been introduced in Patchwork_117713v1_full:
>
> IGT changes
> Possible regressions
>
> * igt@kms_plane@plane-panning-bottom-right-suspend@pipe-b-planes:
> * shard-apl: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13143/shard-apl7/igt@kms_plane@plane-panning-bottom-right-suspend@pipe-b-planes.html> -> ABORT<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117713v1/shard-apl2/igt@kms_plane@plane-panning-bottom-right-suspend@pipe-b-planes.html>
>
alan:snip
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-05-24 17:15 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-12 23:58 [PATCH] drm/i915/selftest/gsc: Ensure GSC Proxy init completes before selftests Alan Previn
2023-05-12 23:58 ` [Intel-gfx] " Alan Previn
2023-05-13 1:14 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2023-05-13 1:29 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-05-13 4:55 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2023-05-24 17:15 ` Teres Alexis, Alan Previn
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.