All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v3 00/34] Remove .notify callback in acpi_device_ops
@ 2023-05-17  7:56 Michal Wilczynski
  2023-05-17  7:56 ` [PATCH v3 01/34] acpi: Adjust functions installing bus event handlers Michal Wilczynski
                   ` (34 more replies)
  0 siblings, 35 replies; 39+ messages in thread
From: Michal Wilczynski @ 2023-05-17  7:56 UTC (permalink / raw)
  To: linux-acpi; +Cc: rafael, srinivas.pandruvada, Michal Wilczynski

Currently drivers support ACPI event handlers by defining .notify
callback in acpi_device_ops. This solution is suboptimal as event
handler installer installs intermediary function acpi_notify_device as a
handler in every driver. Also this approach requires extra variable
'flags' for specifying event types that the driver want to subscribe to.
Additionally this is a pre-work required to align acpi_driver with
platform_driver and eventually replace acpi_driver with platform_driver.

Remove .notify callback from the acpi_device_ops. Replace it with each
driver installing and removing it's event handlers.

v3:
 - lkp still reported some failures for eeepc, fujitsu and
   toshiba_bluetooth, fix those
v2:
 - fix compilation errors for drivers

Michal Wilczynski (34):
  acpi: Adjust functions installing bus event handlers
  acpi/ac: Move handler installing logic to driver
  acpi/video: Move handler installing logic to driver
  acpi/battery: Move handler installing logic to driver
  acpi/button: Move handler installing logic to driver
  acpi/hed: Move handler installing logic to driver
  acpi/nfit: Move handler installing logic to driver
  acpi/thermal: Move handler installing logic to driver
  acpi/tiny-power-button: Move handler installing logic to driver
  hwmon: Move handler installing logic to driver
  iio/acpi-als: Move handler installing logic to driver
  platform/chromeos_tbmc: Move handler installing logic to driver
  platform/wilco_ec: Move handler installing logic to driver
  platform/surface/button: Move handler installing logic to driver
  platform/x86/acer-wireless: Move handler installing logic to driver
  platform/x86/asus-laptop: Move handler installing logic to driver
  platform/x86/asus-wireless: Move handler installing logic to driver
  platform/x86/classmate-laptop: Move handler installing logic to driver
  platform/x86/dell/dell-rbtn: Move handler installing logic to driver
  platform/x86/eeepc-laptop: Move handler installing logic to driver
  platform/x86/fujitsu-laptop: Move handler installing logic to driver
  platform/x86/lg-laptop: Move handler installing logic to driver
  platform/x86/panasonic-laptop: Move handler installing logic to driver
  platform/x86/system76_acpi: Move handler installing logic to driver
  platform/x86/topstar-laptop: Move handler installing logic to driver
  platform/x86/toshiba_acpi: Move handler installing logic to driver
  platform/x86/toshiba_bluetooth: Move handler installing logic to
    driver
  platform/x86/toshiba_haps: Move handler installing logic to driver
  platform/x86/wireless-hotkey: Move handler installing logic to driver
  platform/x86/xo15-ebook: Move handler installing logic to driver
  virt/vmgenid: Move handler installing logic to driver
  acpi/bus: Remove installing/removing notify handlers from probe/remove
  acpi/bus: Remove redundant functions
  acpi/bus: Remove notify callback and flags

 drivers/acpi/ac.c                             |  14 +-
 drivers/acpi/acpi_video.c                     |  18 ++-
 drivers/acpi/battery.c                        |  14 +-
 drivers/acpi/bus.c                            |  53 ++-----
 drivers/acpi/button.c                         |  18 ++-
 drivers/acpi/hed.c                            |   6 +-
 drivers/acpi/nfit/core.c                      |  25 ++--
 drivers/acpi/thermal.c                        |  20 ++-
 drivers/acpi/tiny-power-button.c              |  18 +--
 drivers/hwmon/acpi_power_meter.c              |  15 +-
 drivers/iio/light/acpi-als.c                  |  23 ++-
 drivers/platform/chrome/chromeos_tbmc.c       |  14 +-
 drivers/platform/chrome/wilco_ec/event.c      |  19 ++-
 drivers/platform/surface/surfacepro3_button.c |  19 ++-
 drivers/platform/x86/acer-wireless.c          |  22 ++-
 drivers/platform/x86/asus-laptop.c            |  16 ++-
 drivers/platform/x86/asus-wireless.c          |  24 ++--
 drivers/platform/x86/classmate-laptop.c       |  12 +-
 drivers/platform/x86/dell/dell-rbtn.c         |  15 +-
 drivers/platform/x86/eeepc-laptop.c           |  18 ++-
 drivers/platform/x86/fujitsu-laptop.c         |  19 ++-
 drivers/platform/x86/lg-laptop.c              |  12 +-
 drivers/platform/x86/panasonic-laptop.c       |  17 ++-
 drivers/platform/x86/system76_acpi.c          |  28 ++--
 drivers/platform/x86/topstar-laptop.c         |  16 ++-
 drivers/platform/x86/toshiba_acpi.c           | 131 +++++++++---------
 drivers/platform/x86/toshiba_bluetooth.c      |  30 ++--
 drivers/platform/x86/toshiba_haps.c           |   9 +-
 drivers/platform/x86/wireless-hotkey.c        |  23 ++-
 drivers/platform/x86/xo15-ebook.c             |  11 +-
 drivers/virt/vmgenid.c                        |  30 ++--
 include/acpi/acpi_bus.h                       |  10 +-
 32 files changed, 457 insertions(+), 262 deletions(-)

-- 
2.40.1


^ permalink raw reply	[flat|nested] 39+ messages in thread

end of thread, other threads:[~2023-05-17 18:00 UTC | newest]

Thread overview: 39+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-17  7:56 [PATCH v3 00/34] Remove .notify callback in acpi_device_ops Michal Wilczynski
2023-05-17  7:56 ` [PATCH v3 01/34] acpi: Adjust functions installing bus event handlers Michal Wilczynski
2023-05-17  7:56 ` [PATCH v3 02/34] acpi/ac: Move handler installing logic to driver Michal Wilczynski
2023-05-17  7:56 ` [PATCH v3 03/34] acpi/video: " Michal Wilczynski
2023-05-17  7:56 ` [PATCH v3 04/34] acpi/battery: " Michal Wilczynski
2023-05-17  7:56 ` [PATCH v3 05/34] acpi/button: " Michal Wilczynski
2023-05-17  7:56 ` [PATCH v3 06/34] acpi/hed: " Michal Wilczynski
2023-05-17  7:56 ` [PATCH v3 07/34] acpi/nfit: " Michal Wilczynski
2023-05-17  7:56 ` [PATCH v3 08/34] acpi/thermal: " Michal Wilczynski
2023-05-17  7:56 ` [PATCH v3 09/34] acpi/tiny-power-button: " Michal Wilczynski
2023-05-17  7:57 ` [PATCH v3 10/34] hwmon: " Michal Wilczynski
2023-05-17  7:57 ` [PATCH v3 11/34] iio/acpi-als: " Michal Wilczynski
2023-05-17  7:57 ` [PATCH v3 12/34] platform/chromeos_tbmc: " Michal Wilczynski
2023-05-17  7:57 ` [PATCH v3 13/34] platform/wilco_ec: " Michal Wilczynski
2023-05-17  7:57 ` [PATCH v3 14/34] platform/surface/button: " Michal Wilczynski
2023-05-17  7:57 ` [PATCH v3 15/34] platform/x86/acer-wireless: " Michal Wilczynski
2023-05-17  7:57 ` [PATCH v3 16/34] platform/x86/asus-laptop: " Michal Wilczynski
2023-05-17  7:57 ` [PATCH v3 17/34] platform/x86/asus-wireless: " Michal Wilczynski
2023-05-17  7:57 ` [PATCH v3 18/34] platform/x86/classmate-laptop: " Michal Wilczynski
2023-05-17  7:57 ` [PATCH v3 19/34] platform/x86/dell/dell-rbtn: " Michal Wilczynski
2023-05-17  7:57 ` [PATCH v3 20/34] platform/x86/eeepc-laptop: " Michal Wilczynski
2023-05-17  7:57 ` [PATCH v3 21/34] platform/x86/fujitsu-laptop: " Michal Wilczynski
2023-05-17  7:57 ` [PATCH v3 22/34] platform/x86/lg-laptop: " Michal Wilczynski
2023-05-17  7:57 ` [PATCH v3 23/34] platform/x86/panasonic-laptop: " Michal Wilczynski
2023-05-17 15:30   ` kernel test robot
2023-05-17  7:57 ` [PATCH v3 24/34] platform/x86/system76_acpi: " Michal Wilczynski
2023-05-17  7:57 ` [PATCH v3 25/34] platform/x86/topstar-laptop: " Michal Wilczynski
2023-05-17  7:57 ` [PATCH v3 26/34] platform/x86/toshiba_acpi: " Michal Wilczynski
2023-05-17  7:57 ` [PATCH v3 27/34] platform/x86/toshiba_bluetooth: " Michal Wilczynski
2023-05-17  7:57 ` [PATCH v3 28/34] platform/x86/toshiba_haps: " Michal Wilczynski
2023-05-17  7:57 ` [PATCH v3 29/34] platform/x86/wireless-hotkey: " Michal Wilczynski
2023-05-17  7:57 ` [PATCH v3 30/34] platform/x86/xo15-ebook: " Michal Wilczynski
2023-05-17  7:57 ` [PATCH v3 31/34] virt/vmgenid: " Michal Wilczynski
2023-05-17  7:57 ` [PATCH v3 32/34] acpi/bus: Remove installing/removing notify handlers from probe/remove Michal Wilczynski
2023-05-17  7:57 ` [PATCH v3 33/34] acpi/bus: Remove redundant functions Michal Wilczynski
2023-05-17  7:57 ` [PATCH v3 34/34] acpi/bus: Remove notify callback and flags Michal Wilczynski
2023-05-17 17:59   ` kernel test robot
2023-05-17  9:35 ` [PATCH v3 00/34] Remove .notify callback in acpi_device_ops Hans de Goede
2023-05-17 10:58   ` Wilczynski, Michal

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.