[igt-dev] [PATCH i-g-t 0/4] kms_rotation_crc improvements and generalization

[igt-dev] [PATCH i-g-t 0/4] kms_rotation_crc improvements and generalization

[Maíra Canal]

This patchset introduces some improvements and generalizes the kms_rotation_crc
test. Currently, I'm working on the rotation property of the vkms driver [1]
and while working on it, I noticed that some subtests could be added and some
subtests could be more generic.

The first and second patches make the tests more generic. Currently, some
subtests use i915 modifiers, which make the subtest fail for other vendors
that are not Intel. Therefore, check if the device is i915 before using the
i915-specific modifiers.

The third patch expands the subtest "sprite-rotation-90-pos-100-0" by testing
all 90, 180 and 270 degrees rotation with x and y offsets. This can helps us
to assure that 90, 180 and 270 degrees rotation happens correctly even with
offsets.

Finally, add generic tests for reflect-x and reflect-y. Currently, there are
no tests for reflection values. So, add some generic reflection tests to
ensure that these properties are working correctly. Note that these subtests
must skip on i915 devices, as i915 uses reflect-x together with specific
modifiers.

[1] https://gitlab.freedesktop.org/mairacanal/linux/-/commits/vkms/rotation

Best Regards,
- Maíra Canal

Maíra Canal (4):
  tests/kms_rotation_crc: make the subtest "bad-pixel-format" i915-specific
  tests/kms_rotation_crc: use DRM_FORMAT_MOD_LINEAR as default modifier
  tests/kms_rotation_crc: add tests for a rotated plane in a given position
  tests/kms_rotation_crc: create generic reflection tests

 tests/kms_rotation_crc.c | 69 ++++++++++++++++++++++++++++++++++++----
 1 file changed, 62 insertions(+), 7 deletions(-)

-- 
2.39.2

[igt-dev] [PATCH i-g-t 1/4] tests/kms_rotation_crc: make the subtest "bad-pixel-format" i915-specific

[Maíra Canal]

The subtest "bad-pixel-format" expects that RGB565 rotation is not
supported for 90 degrees, which is not necessarily true for non-i915
devices. Therefore, require the device to be i915 before running the
subtest "bad-pixel-format", as we can only guarantee bad pixel formats
for i915 devices.

Signed-off-by: Maíra Canal <mcanal@igalia.com>
---
 tests/kms_rotation_crc.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c
index 295aed76..0d7b3962 100644
--- a/tests/kms_rotation_crc.c
+++ b/tests/kms_rotation_crc.c
@@ -1181,6 +1181,8 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
 
 	igt_describe("Checking unsupported pixel format for gen9+ with 90 degree of rotation");
 	igt_subtest_f("bad-pixel-format") {
+		igt_require(is_i915_device(data.gfx_fd));
+
 		 /* gen11 enables RGB565 rotation for 90/270 degrees.
 		  * so apart from this, any other gen11+ pixel format
 		  * can be used which doesn't support 90/270 degree
-- 
2.39.2

[igt-dev] [PATCH i-g-t 2/4] tests/kms_rotation_crc: use DRM_FORMAT_MOD_LINEAR as default modifier

[Maíra Canal]

If the rotation is 90 or 270 degrees, the function prepare_fbs() uses a
i915-specific modifier, I915_FORMAT_MOD_Y_TILED. In order to make the
function more generic, use a i915-specific modifier only if the device
is i915. Otherwise, use the DRM_FORMAT_MOD_LINEAR modifier.

Signed-off-by: Maíra Canal <mcanal@igalia.com>
---
 tests/kms_rotation_crc.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c
index 0d7b3962..cf02306f 100644
--- a/tests/kms_rotation_crc.c
+++ b/tests/kms_rotation_crc.c
@@ -296,7 +296,8 @@ static void prepare_fbs(data_t *data, igt_output_t *output,
 	 * frame can fit in
 	 */
 	if (igt_rotation_90_or_270(data->rotation)) {
-		modifier = data->override_modifier ?: I915_FORMAT_MOD_Y_TILED;
+		if (is_i915_device(data->gfx_fd))
+			modifier = data->override_modifier ?: I915_FORMAT_MOD_Y_TILED;
 
 		igt_swap(w, h);
 	}
-- 
2.39.2

[igt-dev] [PATCH i-g-t 3/4] tests/kms_rotation_crc: add tests for a rotated plane in a given position

[Maíra Canal]

Currently, kms_rotation_crc only has one subtest testing a rotated plane
in a given position: a subtest that rotates 90 degrees the overlay plane
with a offset in the x axis. So, expand the subtest "sprite-rotation-90-pos-100-0"
by creating subtests for 90, 180 and 270 degrees rotation with different
x and y offsets. This can help us to assure that the rotation happens
correctly even with offsets in the x and y axis.

Signed-off-by: Maíra Canal <mcanal@igalia.com>
---
 tests/kms_rotation_crc.c | 33 +++++++++++++++++++++++++++------
 1 file changed, 27 insertions(+), 6 deletions(-)

diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c
index cf02306f..441a298b 100644
--- a/tests/kms_rotation_crc.c
+++ b/tests/kms_rotation_crc.c
@@ -1134,6 +1134,23 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
 		{ 0, 0 }
 	};
 
+	struct rot_pos_subtest {
+		igt_rotation_t rot;
+		int pos_x;
+		int pos_y;
+	} *rot_pos, rot_pos_subtests[] = {
+		{ IGT_ROTATION_90, 0, 100 },
+		{ IGT_ROTATION_90, 100, 0 },
+		{ IGT_ROTATION_90, 100, 100 },
+		{ IGT_ROTATION_180, 0, 100 },
+		{ IGT_ROTATION_180, 100, 0 },
+		{ IGT_ROTATION_180, 100, 100 },
+		{ IGT_ROTATION_270, 0, 100 },
+		{ IGT_ROTATION_270, 100, 0 },
+		{ IGT_ROTATION_270, 100, 100 },
+		{ 0, 0 }
+	};
+
 	int gen = 0;
 
 	igt_fixture {
@@ -1170,12 +1187,16 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
 		}
 	}
 
-	igt_describe("Rotation test with 90 degree for a plane of gen9+ with given position");
-	igt_subtest_f("sprite-rotation-90-pos-100-0") {
-		data.rotation = IGT_ROTATION_90;
-		data.pos_x = 100,
-		data.pos_y = 0;
-		test_plane_rotation(&data, DRM_PLANE_TYPE_OVERLAY, false);
+	igt_describe("Rotation test with 90/180/270 degree for a plane of gen9+ with given position");
+	for (rot_pos = rot_pos_subtests; rot_pos->rot; rot_pos++) {
+		igt_subtest_f("sprite-rotation-%s-pos-%d-%d", rot_test_str(rot_pos->rot),
+			      rot_pos->pos_x,
+			      rot_pos->pos_y) {
+			data.rotation = rot_pos->rot;
+			data.pos_x = rot_pos->pos_x;
+			data.pos_y = rot_pos->pos_y;
+			test_plane_rotation(&data, DRM_PLANE_TYPE_OVERLAY, false);
+		}
 	}
 	data.pos_x = 0,
 	data.pos_y = 0;
-- 
2.39.2

[igt-dev] [PATCH i-g-t 4/4] tests/kms_rotation_crc: create generic reflection tests

[Maíra Canal]

Currently, kms_rotation_crc doesn't have any tests for the reflect-x and
reflect-y properties. Therefore, add generic reflection tests for the
primary and overlay planes. Note that this tests should skip on i915
devices, as i915 devices use reflect-x together with specific modifiers.

Signed-off-by: Maíra Canal <mcanal@igalia.com>
---
 tests/kms_rotation_crc.c | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c
index 441a298b..47a3973b 100644
--- a/tests/kms_rotation_crc.c
+++ b/tests/kms_rotation_crc.c
@@ -131,6 +131,9 @@ static void rotate_colors(rgb_color_t *tl, rgb_color_t *tr, rgb_color_t *br,
 	if (rotation & IGT_REFLECT_X) {
 		igt_swap(*tl, *tr);
 		igt_swap(*bl, *br);
+	} else if (rotation & IGT_REFLECT_Y) {
+		igt_swap(*tl, *bl);
+		igt_swap(*tr, *br);
 	}
 
 	if (rotation & IGT_ROTATION_90) {
@@ -1055,6 +1058,10 @@ static const char *rot_test_str(igt_rotation_t rot)
 		return "180";
 	case IGT_ROTATION_270:
 		return "270";
+	case IGT_REFLECT_X:
+		return "x";
+	case IGT_REFLECT_Y:
+		return "y";
 	default:
 		igt_assert(0);
 	}
@@ -1151,6 +1158,17 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
 		{ 0, 0 }
 	};
 
+	struct generic_reflect {
+		unsigned int plane;
+		igt_rotation_t rot;
+	} *generic_reflect, generic_reflect_subtests[] = {
+		{ DRM_PLANE_TYPE_PRIMARY, IGT_REFLECT_X },
+		{ DRM_PLANE_TYPE_PRIMARY, IGT_REFLECT_Y },
+		{ DRM_PLANE_TYPE_OVERLAY, IGT_REFLECT_X },
+		{ DRM_PLANE_TYPE_OVERLAY, IGT_REFLECT_Y },
+		{ 0, 0 }
+	};
+
 	int gen = 0;
 
 	igt_fixture {
@@ -1187,6 +1205,19 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
 		}
 	}
 
+	igt_describe("Generic reflection tests for primary and sprite planes");
+	for (generic_reflect = generic_reflect_subtests; generic_reflect->rot; generic_reflect++) {
+		igt_subtest_f("%s-reflect-%s",
+			      plane_test_str(generic_reflect->plane),
+			      rot_test_str(generic_reflect->rot)) {
+			/* i915 devices have specific modifiers for reflection */
+			igt_require(!is_i915_device(data.gfx_fd));
+
+			data.rotation = IGT_ROTATION_0 | generic_reflect->rot;
+			test_plane_rotation(&data, generic_reflect->plane, false);
+		}
+	}
+
 	igt_describe("Rotation test with 90/180/270 degree for a plane of gen9+ with given position");
 	for (rot_pos = rot_pos_subtests; rot_pos->rot; rot_pos++) {
 		igt_subtest_f("sprite-rotation-%s-pos-%d-%d", rot_test_str(rot_pos->rot),
-- 
2.39.2

[igt-dev] ✓ Fi.CI.BAT: success for kms_rotation_crc improvements and generalization

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 3870 bytes --]

== Series Details ==

Series: kms_rotation_crc improvements and generalization
URL   : https://patchwork.freedesktop.org/series/116025/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_12958 -> IGTPW_8738
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8738/index.html

Participating hosts (37 -> 36)
------------------------------

  Missing    (1): fi-snb-2520m 

Known issues
------------

  Here are the changes found in IGTPW_8738 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_selftest@live@reset:
    - bat-rpls-1:         [PASS][1] -> [ABORT][2] ([i915#4983])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12958/bat-rpls-1/igt@i915_selftest@live@reset.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8738/bat-rpls-1/igt@i915_selftest@live@reset.html

  * igt@kms_chamelium_hpd@common-hpd-after-suspend:
    - fi-bsw-nick:        NOTRUN -> [SKIP][3] ([fdo#109271]) +1 similar issue
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8738/fi-bsw-nick/igt@kms_chamelium_hpd@common-hpd-after-suspend.html

  * igt@kms_pipe_crc_basic@nonblocking-crc@pipe-c-dp-1:
    - bat-dg2-8:          [PASS][4] -> [FAIL][5] ([i915#7932])
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12958/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc@pipe-c-dp-1.html
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8738/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc@pipe-c-dp-1.html

  
#### Possible fixes ####

  * igt@i915_selftest@live@hangcheck:
    - fi-bsw-nick:        [ABORT][6] ([i915#7913]) -> [PASS][7]
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12958/fi-bsw-nick/igt@i915_selftest@live@hangcheck.html
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8738/fi-bsw-nick/igt@i915_selftest@live@hangcheck.html

  
#### Warnings ####

  * igt@i915_selftest@live@slpc:
    - bat-rpls-2:         [DMESG-FAIL][8] ([i915#6367] / [i915#7913] / [i915#7996]) -> [DMESG-FAIL][9] ([i915#6367] / [i915#7913])
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12958/bat-rpls-2/igt@i915_selftest@live@slpc.html
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8738/bat-rpls-2/igt@i915_selftest@live@slpc.html

  
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
  [i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
  [i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
  [i915#7932]: https://gitlab.freedesktop.org/drm/intel/issues/7932
  [i915#7996]: https://gitlab.freedesktop.org/drm/intel/issues/7996


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_7233 -> IGTPW_8738

  CI-20190529: 20190529
  CI_DRM_12958: f09f557ecb751519378d6d153a5b77afb14f7b43 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_8738: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8738/index.html
  IGT_7233: 716520b469a2745e1882780f2aabbc88eb19332c @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git


Testlist changes
----------------

+igt@kms_rotation_crc@primary-reflect-x
+igt@kms_rotation_crc@primary-reflect-y
+igt@kms_rotation_crc@sprite-reflect-x
+igt@kms_rotation_crc@sprite-reflect-y
+igt@kms_rotation_crc@sprite-rotation-90-pos-0-100
+igt@kms_rotation_crc@sprite-rotation-90-pos-100-100
+igt@kms_rotation_crc@sprite-rotation-180-pos-0-100
+igt@kms_rotation_crc@sprite-rotation-180-pos-100-0
+igt@kms_rotation_crc@sprite-rotation-180-pos-100-100
+igt@kms_rotation_crc@sprite-rotation-270-pos-0-100
+igt@kms_rotation_crc@sprite-rotation-270-pos-100-0
+igt@kms_rotation_crc@sprite-rotation-270-pos-100-100

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8738/index.html

[-- Attachment #2: Type: text/html, Size: 4827 bytes --]

[igt-dev] ✗ Fi.CI.IGT: failure for kms_rotation_crc improvements and generalization

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 22597 bytes --]

== Series Details ==

Series: kms_rotation_crc improvements and generalization
URL   : https://patchwork.freedesktop.org/series/116025/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_12958_full -> IGTPW_8738_full
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with IGTPW_8738_full absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_8738_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8738/index.html

Participating hosts (8 -> 8)
------------------------------

  Additional (1): shard-tglu0 
  Missing    (1): shard-rkl0 

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_8738_full:

### IGT changes ###

#### Possible regressions ####

  * {igt@kms_rotation_crc@primary-reflect-x} (NEW):
    - {shard-rkl}:        NOTRUN -> [SKIP][1] +3 similar issues
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8738/shard-rkl-6/igt@kms_rotation_crc@primary-reflect-x.html

  * {igt@kms_rotation_crc@sprite-reflect-x} (NEW):
    - {shard-tglu}:       NOTRUN -> [SKIP][2] +2 similar issues
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8738/shard-tglu-8/igt@kms_rotation_crc@sprite-reflect-x.html

  * {igt@kms_rotation_crc@sprite-reflect-y} (NEW):
    - {shard-dg1}:        NOTRUN -> [SKIP][3]
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8738/shard-dg1-17/igt@kms_rotation_crc@sprite-reflect-y.html

  * igt@runner@aborted:
    - shard-apl:          NOTRUN -> [FAIL][4]
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8738/shard-apl6/igt@runner@aborted.html

  
New tests
---------

  New tests have been introduced between CI_DRM_12958_full and IGTPW_8738_full:

### New IGT tests (15) ###

  * igt@kms_cursor_edge_walk@128x128-right-edge@pipe-b-hdmi-a-2:
    - Statuses : 1 pass(s)
    - Exec time: [0.0] s

  * igt@kms_cursor_edge_walk@64x64-right-edge@pipe-b-hdmi-a-2:
    - Statuses : 1 pass(s)
    - Exec time: [0.0] s

  * igt@kms_cursor_edge_walk@64x64-top-edge@pipe-b-hdmi-a-2:
    - Statuses : 1 pass(s)
    - Exec time: [0.0] s

  * igt@kms_rotation_crc@primary-reflect-x:
    - Statuses : 5 skip(s)
    - Exec time: [0.0] s

  * igt@kms_rotation_crc@primary-reflect-y:
    - Statuses : 2 skip(s)
    - Exec time: [0.0] s

  * igt@kms_rotation_crc@sprite-reflect-x:
    - Statuses : 5 skip(s)
    - Exec time: [0.0] s

  * igt@kms_rotation_crc@sprite-reflect-y:
    - Statuses : 6 skip(s)
    - Exec time: [0.0] s

  * igt@kms_rotation_crc@sprite-rotation-180-pos-0-100:
    - Statuses : 6 pass(s)
    - Exec time: [0.0] s

  * igt@kms_rotation_crc@sprite-rotation-180-pos-100-0:
    - Statuses : 6 pass(s)
    - Exec time: [0.0] s

  * igt@kms_rotation_crc@sprite-rotation-180-pos-100-100:
    - Statuses : 6 pass(s)
    - Exec time: [0.0] s

  * igt@kms_rotation_crc@sprite-rotation-270-pos-0-100:
    - Statuses : 3 pass(s) 1 skip(s)
    - Exec time: [0.0] s

  * igt@kms_rotation_crc@sprite-rotation-270-pos-100-0:
    - Statuses : 4 pass(s) 1 skip(s)
    - Exec time: [0.0] s

  * igt@kms_rotation_crc@sprite-rotation-270-pos-100-100:
    - Statuses : 5 pass(s) 1 skip(s)
    - Exec time: [0.0] s

  * igt@kms_rotation_crc@sprite-rotation-90-pos-0-100:
    - Statuses : 4 pass(s) 1 skip(s)
    - Exec time: [0.0] s

  * igt@kms_rotation_crc@sprite-rotation-90-pos-100-100:
    - Statuses : 4 pass(s) 1 skip(s)
    - Exec time: [0.0] s

  

Known issues
------------

  Here are the changes found in IGTPW_8738_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_exec_fair@basic-pace-solo@rcs0:
    - shard-glk:          [PASS][5] -> [FAIL][6] ([i915#2842])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12958/shard-glk6/igt@gem_exec_fair@basic-pace-solo@rcs0.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8738/shard-glk3/igt@gem_exec_fair@basic-pace-solo@rcs0.html

  * igt@gem_lmem_swapping@heavy-verify-random:
    - shard-apl:          NOTRUN -> [SKIP][7] ([fdo#109271] / [i915#4613])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8738/shard-apl1/igt@gem_lmem_swapping@heavy-verify-random.html

  * igt@gem_lmem_swapping@massive-random:
    - shard-glk:          NOTRUN -> [SKIP][8] ([fdo#109271] / [i915#4613])
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8738/shard-glk2/igt@gem_lmem_swapping@massive-random.html

  * igt@gen9_exec_parse@allowed-all:
    - shard-apl:          [PASS][9] -> [ABORT][10] ([i915#5566])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12958/shard-apl4/igt@gen9_exec_parse@allowed-all.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8738/shard-apl3/igt@gen9_exec_parse@allowed-all.html

  * igt@i915_pm_rpm@gem-execbuf-stress-pc8:
    - shard-glk:          NOTRUN -> [SKIP][11] ([fdo#109271]) +49 similar issues
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8738/shard-glk4/igt@i915_pm_rpm@gem-execbuf-stress-pc8.html

  * igt@i915_suspend@basic-s3-without-i915:
    - shard-snb:          [PASS][12] -> [INCOMPLETE][13] ([i915#4528] / [i915#4817])
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12958/shard-snb2/igt@i915_suspend@basic-s3-without-i915.html
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8738/shard-snb4/igt@i915_suspend@basic-s3-without-i915.html

  * igt@kms_async_flips@alternate-sync-async-flip@pipe-c-hdmi-a-1:
    - shard-glk:          [PASS][14] -> [FAIL][15] ([i915#2521])
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12958/shard-glk3/igt@kms_async_flips@alternate-sync-async-flip@pipe-c-hdmi-a-1.html
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8738/shard-glk1/igt@kms_async_flips@alternate-sync-async-flip@pipe-c-hdmi-a-1.html

  * igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_mc_ccs:
    - shard-apl:          NOTRUN -> [SKIP][16] ([fdo#109271] / [i915#3886]) +4 similar issues
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8738/shard-apl1/igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_mc_ccs.html

  * igt@kms_ccs@pipe-c-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc:
    - shard-glk:          NOTRUN -> [SKIP][17] ([fdo#109271] / [i915#3886]) +1 similar issue
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8738/shard-glk8/igt@kms_ccs@pipe-c-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc.html

  * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
    - shard-glk:          [PASS][18] -> [FAIL][19] ([i915#2346])
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12958/shard-glk6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8738/shard-glk7/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
    - shard-apl:          [PASS][20] -> [FAIL][21] ([i915#2346])
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12958/shard-apl1/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8738/shard-apl7/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html

  * igt@kms_fbcon_fbt@fbc-suspend:
    - shard-apl:          [PASS][22] -> [FAIL][23] ([i915#4767])
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12958/shard-apl1/igt@kms_fbcon_fbt@fbc-suspend.html
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8738/shard-apl6/igt@kms_fbcon_fbt@fbc-suspend.html

  * igt@kms_plane_scaling@planes-downscale-factor-0-5-upscale-0-25@pipe-c-dp-1:
    - shard-apl:          NOTRUN -> [SKIP][24] ([fdo#109271]) +73 similar issues
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8738/shard-apl6/igt@kms_plane_scaling@planes-downscale-factor-0-5-upscale-0-25@pipe-c-dp-1.html

  * igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-sf:
    - shard-apl:          NOTRUN -> [SKIP][25] ([fdo#109271] / [i915#658])
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8738/shard-apl4/igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-sf.html

  * igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-big-fb:
    - shard-glk:          NOTRUN -> [SKIP][26] ([fdo#109271] / [i915#658])
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8738/shard-glk4/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-big-fb.html

  * {igt@kms_rotation_crc@sprite-reflect-x} (NEW):
    - shard-snb:          NOTRUN -> [SKIP][27] ([fdo#109271]) +7 similar issues
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8738/shard-snb5/igt@kms_rotation_crc@sprite-reflect-x.html

  * igt@kms_writeback@writeback-pixel-formats:
    - shard-apl:          NOTRUN -> [SKIP][28] ([fdo#109271] / [i915#2437])
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8738/shard-apl6/igt@kms_writeback@writeback-pixel-formats.html

  
#### Possible fixes ####

  * igt@drm_fdinfo@most-busy-idle-check-all@rcs0:
    - {shard-rkl}:        [FAIL][29] ([i915#7742]) -> [PASS][30] +1 similar issue
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12958/shard-rkl-2/igt@drm_fdinfo@most-busy-idle-check-all@rcs0.html
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8738/shard-rkl-7/igt@drm_fdinfo@most-busy-idle-check-all@rcs0.html

  * igt@gem_barrier_race@remote-request@rcs0:
    - {shard-tglu}:       [ABORT][31] ([i915#8211]) -> [PASS][32]
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12958/shard-tglu-8/igt@gem_barrier_race@remote-request@rcs0.html
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8738/shard-tglu-5/igt@gem_barrier_race@remote-request@rcs0.html

  * igt@gem_ctx_exec@basic-nohangcheck:
    - {shard-rkl}:        [FAIL][33] ([i915#6268]) -> [PASS][34]
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12958/shard-rkl-3/igt@gem_ctx_exec@basic-nohangcheck.html
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8738/shard-rkl-4/igt@gem_ctx_exec@basic-nohangcheck.html

  * igt@gem_exec_fair@basic-pace-share@rcs0:
    - shard-apl:          [FAIL][35] ([i915#2842]) -> [PASS][36]
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12958/shard-apl2/igt@gem_exec_fair@basic-pace-share@rcs0.html
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8738/shard-apl2/igt@gem_exec_fair@basic-pace-share@rcs0.html

  * igt@gem_exec_suspend@basic-s4-devices@smem:
    - {shard-tglu}:       [ABORT][37] ([i915#7975]) -> [PASS][38]
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12958/shard-tglu-10/igt@gem_exec_suspend@basic-s4-devices@smem.html
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8738/shard-tglu-3/igt@gem_exec_suspend@basic-s4-devices@smem.html

  * igt@gem_lmem_swapping@smem-oom@lmem0:
    - {shard-dg1}:        [DMESG-WARN][39] ([i915#4936]) -> [PASS][40]
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12958/shard-dg1-16/igt@gem_lmem_swapping@smem-oom@lmem0.html
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8738/shard-dg1-16/igt@gem_lmem_swapping@smem-oom@lmem0.html

  * igt@gem_mmap_offset@clear@smem0:
    - {shard-dg1}:        [DMESG-WARN][41] ([i915#8304]) -> [PASS][42]
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12958/shard-dg1-14/igt@gem_mmap_offset@clear@smem0.html
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8738/shard-dg1-18/igt@gem_mmap_offset@clear@smem0.html

  * igt@gen9_exec_parse@allowed-single:
    - shard-apl:          [ABORT][43] ([i915#5566]) -> [PASS][44]
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12958/shard-apl2/igt@gen9_exec_parse@allowed-single.html
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8738/shard-apl3/igt@gen9_exec_parse@allowed-single.html

  * igt@i915_pm_dc@dc9-dpms:
    - shard-apl:          [SKIP][45] ([fdo#109271]) -> [PASS][46]
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12958/shard-apl3/igt@i915_pm_dc@dc9-dpms.html
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8738/shard-apl1/igt@i915_pm_dc@dc9-dpms.html

  * igt@i915_pm_rpm@dpms-non-lpsp:
    - {shard-rkl}:        [SKIP][47] ([i915#1397]) -> [PASS][48]
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12958/shard-rkl-7/igt@i915_pm_rpm@dpms-non-lpsp.html
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8738/shard-rkl-2/igt@i915_pm_rpm@dpms-non-lpsp.html

  * igt@i915_pm_rpm@modeset-non-lpsp-stress:
    - {shard-dg1}:        [SKIP][49] ([i915#1397]) -> [PASS][50]
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12958/shard-dg1-14/igt@i915_pm_rpm@modeset-non-lpsp-stress.html
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8738/shard-dg1-16/igt@i915_pm_rpm@modeset-non-lpsp-stress.html

  * igt@kms_flip@flip-vs-suspend-interruptible@b-dp1:
    - shard-apl:          [ABORT][51] ([i915#180]) -> [PASS][52]
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12958/shard-apl6/igt@kms_flip@flip-vs-suspend-interruptible@b-dp1.html
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8738/shard-apl6/igt@kms_flip@flip-vs-suspend-interruptible@b-dp1.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [IGT#2]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/2
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
  [fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
  [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
  [fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
  [fdo#109302]: https://bugs.freedesktop.org/show_bug.cgi?id=109302
  [fdo#109313]: https://bugs.freedesktop.org/show_bug.cgi?id=109313
  [fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
  [fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
  [fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
  [fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
  [fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
  [fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
  [fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
  [fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644
  [fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
  [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
  [fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054
  [fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
  [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
  [i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
  [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
  [i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
  [i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
  [i915#1902]: https://gitlab.freedesktop.org/drm/intel/issues/1902
  [i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
  [i915#2434]: https://gitlab.freedesktop.org/drm/intel/issues/2434
  [i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
  [i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
  [i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
  [i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
  [i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
  [i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
  [i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
  [i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
  [i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
  [i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
  [i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
  [i915#3023]: https://gitlab.freedesktop.org/drm/intel/issues/3023
  [i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
  [i915#315]: https://gitlab.freedesktop.org/drm/intel/issues/315
  [i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
  [i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
  [i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
  [i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318
  [i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
  [i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
  [i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469
  [i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
  [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
  [i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
  [i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
  [i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
  [i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
  [i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
  [i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
  [i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
  [i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
  [i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
  [i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
  [i915#3938]: https://gitlab.freedesktop.org/drm/intel/issues/3938
  [i915#3952]: https://gitlab.freedesktop.org/drm/intel/issues/3952
  [i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
  [i915#3989]: https://gitlab.freedesktop.org/drm/intel/issues/3989
  [i915#4036]: https://gitlab.freedesktop.org/drm/intel/issues/4036
  [i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
  [i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
  [i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
  [i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
  [i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
  [i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
  [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
  [i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
  [i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
  [i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215
  [i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
  [i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
  [i915#433]: https://gitlab.freedesktop.org/drm/intel/issues/433
  [i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349
  [i915#4387]: https://gitlab.freedesktop.org/drm/intel/issues/4387
  [i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528
  [i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
  [i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
  [i915#4565]: https://gitlab.freedesktop.org/drm/intel/issues/4565
  [i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
  [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
  [i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767
  [i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
  [i915#4817]: https://gitlab.freedesktop.org/drm/intel/issues/4817
  [i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
  [i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
  [i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
  [i915#4873]: https://gitlab.freedesktop.org/drm/intel/issues/4873
  [i915#4936]: https://gitlab.freedesktop.org/drm/intel/issues/4936
  [i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
  [i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
  [i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
  [i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288
  [i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
  [i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
  [i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
  [i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
  [i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
  [i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563
  [i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
  [i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
  [i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
  [i915#6230]: https://gitlab.freedesktop.org/drm/intel/issues/6230
  [i915#6245]: https://gitlab.freedesktop.org/drm/intel/issues/6245
  [i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
  [i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
  [i915#6493]: https://gitlab.freedesktop.org/drm/intel/issues/6493
  [i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
  [i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
  [i915#6590]: https://gitlab.freedesktop.org/drm/intel/issues/6590
  [i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
  [i915#6946]: https://gitlab.freedesktop.org/drm/intel/issues/6946
  [i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
  [i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
  [i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697
  [i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
  [i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
  [i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
  [i915#7975]: https://gitlab.freedesktop.org/drm/intel/issues/7975
  [i915#8011]: https://gitlab.freedesktop.org/drm/intel/issues/8011
  [i915#8211]: https://gitlab.freedesktop.org/drm/intel/issues/8211
  [i915#8304]: https://gitlab.freedesktop.org/drm/intel/issues/8304


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_7233 -> IGTPW_8738
  * Piglit: piglit_4509 -> None

  CI-20190529: 20190529
  CI_DRM_12958: f09f557ecb751519378d6d153a5b77afb14f7b43 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_8738: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8738/index.html
  IGT_7233: 716520b469a2745e1882780f2aabbc88eb19332c @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8738/index.html

[-- Attachment #2: Type: text/html, Size: 18326 bytes --]

Re: [igt-dev] [PATCH i-g-t 0/4] kms_rotation_crc improvements and generalization

[Maíra Canal]

Gentle ping. Thanks!

Best Regards,
- Maíra Canal

On 4/3/23 10:01, Maíra Canal wrote:
> This patchset introduces some improvements and generalizes the kms_rotation_crc
> test. Currently, I'm working on the rotation property of the vkms driver [1]
> and while working on it, I noticed that some subtests could be added and some
> subtests could be more generic.
> 
> The first and second patches make the tests more generic. Currently, some
> subtests use i915 modifiers, which make the subtest fail for other vendors
> that are not Intel. Therefore, check if the device is i915 before using the
> i915-specific modifiers.
> 
> The third patch expands the subtest "sprite-rotation-90-pos-100-0" by testing
> all 90, 180 and 270 degrees rotation with x and y offsets. This can helps us
> to assure that 90, 180 and 270 degrees rotation happens correctly even with
> offsets.
> 
> Finally, add generic tests for reflect-x and reflect-y. Currently, there are
> no tests for reflection values. So, add some generic reflection tests to
> ensure that these properties are working correctly. Note that these subtests
> must skip on i915 devices, as i915 uses reflect-x together with specific
> modifiers.
> 
> [1] https://gitlab.freedesktop.org/mairacanal/linux/-/commits/vkms/rotation
> 
> Best Regards,
> - Maíra Canal
> 
> Maíra Canal (4):
>    tests/kms_rotation_crc: make the subtest "bad-pixel-format" i915-specific
>    tests/kms_rotation_crc: use DRM_FORMAT_MOD_LINEAR as default modifier
>    tests/kms_rotation_crc: add tests for a rotated plane in a given position
>    tests/kms_rotation_crc: create generic reflection tests
> 
>   tests/kms_rotation_crc.c | 69 ++++++++++++++++++++++++++++++++++++----
>   1 file changed, 62 insertions(+), 7 deletions(-)
> 

[igt-dev] ✓ Fi.CI.BAT: success for kms_rotation_crc improvements and generalization (rev2)

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 4560 bytes --]

== Series Details ==

Series: kms_rotation_crc improvements and generalization (rev2)
URL   : https://patchwork.freedesktop.org/series/116025/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_13071 -> IGTPW_8877
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8877/index.html

Participating hosts (38 -> 36)
------------------------------

  Missing    (2): bat-mtlp-8 fi-snb-2520m 

Known issues
------------

  Here are the changes found in IGTPW_8877 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_selftest@live@execlists:
    - fi-bsw-n3050:       [PASS][1] -> [ABORT][2] ([i915#7913])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13071/fi-bsw-n3050/igt@i915_selftest@live@execlists.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8877/fi-bsw-n3050/igt@i915_selftest@live@execlists.html

  * igt@i915_selftest@live@gt_heartbeat:
    - fi-apl-guc:         [PASS][3] -> [FAIL][4] ([i915#7916])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13071/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8877/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html

  * igt@i915_selftest@live@reset:
    - bat-rpls-1:         [PASS][5] -> [ABORT][6] ([i915#8384])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13071/bat-rpls-1/igt@i915_selftest@live@reset.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8877/bat-rpls-1/igt@i915_selftest@live@reset.html

  
#### Possible fixes ####

  * igt@i915_selftest@live@gt_heartbeat:
    - fi-glk-j4005:       [FAIL][7] ([i915#7916]) -> [PASS][8]
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13071/fi-glk-j4005/igt@i915_selftest@live@gt_heartbeat.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8877/fi-glk-j4005/igt@i915_selftest@live@gt_heartbeat.html

  * igt@i915_selftest@live@requests:
    - {bat-mtlp-6}:       [ABORT][9] ([i915#7920]) -> [PASS][10]
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13071/bat-mtlp-6/igt@i915_selftest@live@requests.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8877/bat-mtlp-6/igt@i915_selftest@live@requests.html

  
#### Warnings ####

  * igt@core_hotunplug@unbind-rebind:
    - fi-kbl-8809g:       [ABORT][11] -> [ABORT][12] ([i915#8397])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13071/fi-kbl-8809g/igt@core_hotunplug@unbind-rebind.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8877/fi-kbl-8809g/igt@core_hotunplug@unbind-rebind.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
  [i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
  [i915#6645]: https://gitlab.freedesktop.org/drm/intel/issues/6645
  [i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
  [i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
  [i915#7916]: https://gitlab.freedesktop.org/drm/intel/issues/7916
  [i915#7920]: https://gitlab.freedesktop.org/drm/intel/issues/7920
  [i915#8384]: https://gitlab.freedesktop.org/drm/intel/issues/8384
  [i915#8397]: https://gitlab.freedesktop.org/drm/intel/issues/8397


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_7273 -> IGTPW_8877

  CI-20190529: 20190529
  CI_DRM_13071: b9458e7075652669ec0e04abe039a5ed001701fe @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_8877: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8877/index.html
  IGT_7273: f40ef4b058466219968b7792d22ff0648b82396b @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git


Testlist changes
----------------

+igt@kms_rotation_crc@primary-reflect-x
+igt@kms_rotation_crc@primary-reflect-y
+igt@kms_rotation_crc@sprite-reflect-x
+igt@kms_rotation_crc@sprite-reflect-y
+igt@kms_rotation_crc@sprite-rotation-90-pos-0-100
+igt@kms_rotation_crc@sprite-rotation-90-pos-100-100
+igt@kms_rotation_crc@sprite-rotation-180-pos-0-100
+igt@kms_rotation_crc@sprite-rotation-180-pos-100-0
+igt@kms_rotation_crc@sprite-rotation-180-pos-100-100
+igt@kms_rotation_crc@sprite-rotation-270-pos-0-100
+igt@kms_rotation_crc@sprite-rotation-270-pos-100-0
+igt@kms_rotation_crc@sprite-rotation-270-pos-100-100

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8877/index.html

[-- Attachment #2: Type: text/html, Size: 5165 bytes --]

[igt-dev] ✗ Fi.CI.IGT: failure for kms_rotation_crc improvements and generalization (rev2)

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 17457 bytes --]

== Series Details ==

Series: kms_rotation_crc improvements and generalization (rev2)
URL   : https://patchwork.freedesktop.org/series/116025/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_13071_full -> IGTPW_8877_full
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with IGTPW_8877_full absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_8877_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8877/index.html

Participating hosts (7 -> 7)
------------------------------

  No changes in participating hosts

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_8877_full:

### IGT changes ###

#### Possible regressions ####

  * {igt@kms_rotation_crc@primary-reflect-x} (NEW):
    - {shard-rkl}:        NOTRUN -> [SKIP][1] +3 similar issues
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8877/shard-rkl-1/igt@kms_rotation_crc@primary-reflect-x.html
    - {shard-dg1}:        NOTRUN -> [SKIP][2] +3 similar issues
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8877/shard-dg1-17/igt@kms_rotation_crc@primary-reflect-x.html

  * {igt@kms_rotation_crc@sprite-reflect-x} (NEW):
    - {shard-tglu}:       NOTRUN -> [SKIP][3] +3 similar issues
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8877/shard-tglu-4/igt@kms_rotation_crc@sprite-reflect-x.html

  * igt@kms_vblank@pipe-a-ts-continuation-suspend:
    - shard-snb:          [PASS][4] -> [ABORT][5]
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13071/shard-snb7/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8877/shard-snb1/igt@kms_vblank@pipe-a-ts-continuation-suspend.html

  
#### Suppressed ####

  The following results come from untrusted machines, tests, or statuses.
  They do not affect the overall result.

  * igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend:
    - {shard-tglu}:       [PASS][6] -> [ABORT][7]
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13071/shard-tglu-2/igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend.html
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8877/shard-tglu-7/igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend.html

  
New tests
---------

  New tests have been introduced between CI_DRM_13071_full and IGTPW_8877_full:

### New IGT tests (12) ###

  * igt@kms_rotation_crc@primary-reflect-x:
    - Statuses : 6 skip(s)
    - Exec time: [0.0] s

  * igt@kms_rotation_crc@primary-reflect-y:
    - Statuses : 6 skip(s)
    - Exec time: [0.0] s

  * igt@kms_rotation_crc@sprite-reflect-x:
    - Statuses : 6 skip(s)
    - Exec time: [0.0] s

  * igt@kms_rotation_crc@sprite-reflect-y:
    - Statuses : 6 skip(s)
    - Exec time: [0.0] s

  * igt@kms_rotation_crc@sprite-rotation-180-pos-0-100:
    - Statuses : 6 pass(s)
    - Exec time: [0.0] s

  * igt@kms_rotation_crc@sprite-rotation-180-pos-100-0:
    - Statuses : 6 pass(s)
    - Exec time: [0.0] s

  * igt@kms_rotation_crc@sprite-rotation-180-pos-100-100:
    - Statuses : 6 pass(s)
    - Exec time: [0.0] s

  * igt@kms_rotation_crc@sprite-rotation-270-pos-0-100:
    - Statuses : 5 pass(s)
    - Exec time: [0.0] s

  * igt@kms_rotation_crc@sprite-rotation-270-pos-100-0:
    - Statuses : 5 pass(s) 1 skip(s)
    - Exec time: [0.0] s

  * igt@kms_rotation_crc@sprite-rotation-270-pos-100-100:
    - Statuses : 5 pass(s) 1 skip(s)
    - Exec time: [0.0] s

  * igt@kms_rotation_crc@sprite-rotation-90-pos-0-100:
    - Statuses : 5 pass(s) 1 skip(s)
    - Exec time: [0.0] s

  * igt@kms_rotation_crc@sprite-rotation-90-pos-100-100:
    - Statuses : 5 pass(s) 1 skip(s)
    - Exec time: [0.0] s

  

Known issues
------------

  Here are the changes found in IGTPW_8877_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_exec_fair@basic-deadline:
    - shard-glk:          [PASS][8] -> [FAIL][9] ([i915#2846])
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13071/shard-glk9/igt@gem_exec_fair@basic-deadline.html
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8877/shard-glk1/igt@gem_exec_fair@basic-deadline.html

  * igt@gem_huc_copy@huc-copy:
    - shard-apl:          NOTRUN -> [SKIP][10] ([fdo#109271] / [i915#2190])
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8877/shard-apl1/igt@gem_huc_copy@huc-copy.html

  * igt@i915_pm_dc@dc9-dpms:
    - shard-apl:          [PASS][11] -> [SKIP][12] ([fdo#109271])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13071/shard-apl2/igt@i915_pm_dc@dc9-dpms.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8877/shard-apl7/igt@i915_pm_dc@dc9-dpms.html

  * igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip:
    - shard-apl:          NOTRUN -> [SKIP][13] ([fdo#109271]) +29 similar issues
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8877/shard-apl7/igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip.html

  * igt@kms_cdclk@mode-transition:
    - shard-glk:          NOTRUN -> [SKIP][14] ([fdo#109271]) +9 similar issues
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8877/shard-glk8/igt@kms_cdclk@mode-transition.html

  * igt@kms_content_protection@atomic@pipe-a-dp-1:
    - shard-apl:          NOTRUN -> [TIMEOUT][15] ([i915#7173])
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8877/shard-apl7/igt@kms_content_protection@atomic@pipe-a-dp-1.html

  * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
    - shard-apl:          [PASS][16] -> [FAIL][17] ([i915#2346])
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13071/shard-apl7/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8877/shard-apl4/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html

  * igt@kms_plane_scaling@plane-upscale-with-modifiers-factor-0-25@pipe-a-vga-1:
    - shard-snb:          NOTRUN -> [SKIP][18] ([fdo#109271]) +31 similar issues
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8877/shard-snb6/igt@kms_plane_scaling@plane-upscale-with-modifiers-factor-0-25@pipe-a-vga-1.html

  * igt@kms_psr2_sf@overlay-plane-move-continuous-sf:
    - shard-glk:          NOTRUN -> [SKIP][19] ([fdo#109271] / [i915#658])
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8877/shard-glk1/igt@kms_psr2_sf@overlay-plane-move-continuous-sf.html

  * igt@kms_setmode@basic@pipe-a-hdmi-a-1:
    - shard-snb:          NOTRUN -> [FAIL][20] ([i915#5465]) +1 similar issue
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8877/shard-snb1/igt@kms_setmode@basic@pipe-a-hdmi-a-1.html

  
#### Possible fixes ####

  * igt@drm_fdinfo@most-busy-check-all@rcs0:
    - {shard-rkl}:        [FAIL][21] ([i915#7742]) -> [PASS][22]
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13071/shard-rkl-3/igt@drm_fdinfo@most-busy-check-all@rcs0.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8877/shard-rkl-4/igt@drm_fdinfo@most-busy-check-all@rcs0.html

  * igt@gem_barrier_race@remote-request@rcs0:
    - {shard-dg1}:        [ABORT][23] ([i915#7461] / [i915#8234]) -> [PASS][24]
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13071/shard-dg1-16/igt@gem_barrier_race@remote-request@rcs0.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8877/shard-dg1-14/igt@gem_barrier_race@remote-request@rcs0.html

  * igt@gem_ctx_exec@basic-nohangcheck:
    - {shard-tglu}:       [FAIL][25] ([i915#6268]) -> [PASS][26]
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13071/shard-tglu-5/igt@gem_ctx_exec@basic-nohangcheck.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8877/shard-tglu-7/igt@gem_ctx_exec@basic-nohangcheck.html

  * igt@gem_eio@hibernate:
    - shard-apl:          [ABORT][27] -> [PASS][28]
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13071/shard-apl3/igt@gem_eio@hibernate.html
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8877/shard-apl1/igt@gem_eio@hibernate.html

  * igt@gem_eio@unwedge-stress:
    - {shard-dg1}:        [FAIL][29] ([i915#5784]) -> [PASS][30] +1 similar issue
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13071/shard-dg1-14/igt@gem_eio@unwedge-stress.html
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8877/shard-dg1-18/igt@gem_eio@unwedge-stress.html

  * igt@gem_exec_fair@basic-pace@rcs0:
    - {shard-rkl}:        [FAIL][31] ([i915#2842]) -> [PASS][32]
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13071/shard-rkl-7/igt@gem_exec_fair@basic-pace@rcs0.html
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8877/shard-rkl-2/igt@gem_exec_fair@basic-pace@rcs0.html

  * igt@i915_pm_dc@dc9-dpms:
    - {shard-tglu}:       [SKIP][33] ([i915#4281]) -> [PASS][34]
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13071/shard-tglu-9/igt@i915_pm_dc@dc9-dpms.html
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8877/shard-tglu-9/igt@i915_pm_dc@dc9-dpms.html

  * igt@i915_pm_rc6_residency@rc6-idle@vcs0:
    - {shard-dg1}:        [FAIL][35] ([i915#3591]) -> [PASS][36]
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13071/shard-dg1-14/igt@i915_pm_rc6_residency@rc6-idle@vcs0.html
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8877/shard-dg1-18/igt@i915_pm_rc6_residency@rc6-idle@vcs0.html

  * igt@i915_pm_rpm@modeset-lpsp-stress-no-wait:
    - {shard-rkl}:        [SKIP][37] ([i915#1397]) -> [PASS][38]
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13071/shard-rkl-1/igt@i915_pm_rpm@modeset-lpsp-stress-no-wait.html
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8877/shard-rkl-7/igt@i915_pm_rpm@modeset-lpsp-stress-no-wait.html

  * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
    - shard-apl:          [FAIL][39] ([i915#2346]) -> [PASS][40]
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13071/shard-apl2/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8877/shard-apl3/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html

  * igt@kms_vblank@pipe-a-ts-continuation-suspend:
    - {shard-tglu}:       [ABORT][41] ([i915#5122]) -> [PASS][42]
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13071/shard-tglu-5/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8877/shard-tglu-5/igt@kms_vblank@pipe-a-ts-continuation-suspend.html

  * igt@perf_pmu@idle@rcs0:
    - {shard-rkl}:        [FAIL][43] ([i915#4349]) -> [PASS][44]
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13071/shard-rkl-6/igt@perf_pmu@idle@rcs0.html
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8877/shard-rkl-1/igt@perf_pmu@idle@rcs0.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
  [fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
  [fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
  [fdo#109309]: https://bugs.freedesktop.org/show_bug.cgi?id=109309
  [fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
  [fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
  [fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
  [fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
  [fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
  [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
  [i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
  [i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
  [i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
  [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
  [i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
  [i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
  [i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
  [i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
  [i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
  [i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
  [i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
  [i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
  [i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
  [i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
  [i915#3023]: https://gitlab.freedesktop.org/drm/intel/issues/3023
  [i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
  [i915#315]: https://gitlab.freedesktop.org/drm/intel/issues/315
  [i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
  [i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
  [i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
  [i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
  [i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
  [i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
  [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
  [i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
  [i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
  [i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
  [i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
  [i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
  [i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
  [i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
  [i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
  [i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
  [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
  [i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
  [i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349
  [i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
  [i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
  [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
  [i915#4816]: https://gitlab.freedesktop.org/drm/intel/issues/4816
  [i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
  [i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
  [i915#5122]: https://gitlab.freedesktop.org/drm/intel/issues/5122
  [i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
  [i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
  [i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
  [i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
  [i915#5465]: https://gitlab.freedesktop.org/drm/intel/issues/5465
  [i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
  [i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
  [i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
  [i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
  [i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
  [i915#6755]: https://gitlab.freedesktop.org/drm/intel/issues/6755
  [i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
  [i915#6944]: https://gitlab.freedesktop.org/drm/intel/issues/6944
  [i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
  [i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
  [i915#7173]: https://gitlab.freedesktop.org/drm/intel/issues/7173
  [i915#7392]: https://gitlab.freedesktop.org/drm/intel/issues/7392
  [i915#7443]: https://gitlab.freedesktop.org/drm/intel/issues/7443
  [i915#7456]: https://gitlab.freedesktop.org/drm/intel/issues/7456
  [i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461
  [i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
  [i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
  [i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
  [i915#8011]: https://gitlab.freedesktop.org/drm/intel/issues/8011
  [i915#8102]: https://gitlab.freedesktop.org/drm/intel/issues/8102
  [i915#8234]: https://gitlab.freedesktop.org/drm/intel/issues/8234
  [i915#8292]: https://gitlab.freedesktop.org/drm/intel/issues/8292
  [i915#8381]: https://gitlab.freedesktop.org/drm/intel/issues/8381
  [i915#8399]: https://gitlab.freedesktop.org/drm/intel/issues/8399


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_7273 -> IGTPW_8877
  * Piglit: piglit_4509 -> None

  CI-20190529: 20190529
  CI_DRM_13071: b9458e7075652669ec0e04abe039a5ed001701fe @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_8877: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8877/index.html
  IGT_7273: f40ef4b058466219968b7792d22ff0648b82396b @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8877/index.html

[-- Attachment #2: Type: text/html, Size: 15140 bytes --]

Re: [igt-dev] [PATCH i-g-t 1/4] tests/kms_rotation_crc: make the subtest "bad-pixel-format" i915-specific

[Kamil Konieczny]

Hi Maira,

On 2023-04-03 at 10:01:21 -0300, Maíra Canal wrote:
> The subtest "bad-pixel-format" expects that RGB565 rotation is not
> supported for 90 degrees, which is not necessarily true for non-i915
> devices. Therefore, require the device to be i915 before running the
> subtest "bad-pixel-format", as we can only guarantee bad pixel formats
> for i915 devices.
> 
> Signed-off-by: Maíra Canal <mcanal@igalia.com>
> ---
>  tests/kms_rotation_crc.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c
> index 295aed76..0d7b3962 100644
> --- a/tests/kms_rotation_crc.c
> +++ b/tests/kms_rotation_crc.c
> @@ -1181,6 +1181,8 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
>  
>  	igt_describe("Checking unsupported pixel format for gen9+ with 90 degree of rotation");
>  	igt_subtest_f("bad-pixel-format") {
> +		igt_require(is_i915_device(data.gfx_fd));
------------------------------ ^
Please change this into is_intel_device

Regards,
Kamil

> +
>  		 /* gen11 enables RGB565 rotation for 90/270 degrees.
>  		  * so apart from this, any other gen11+ pixel format
>  		  * can be used which doesn't support 90/270 degree
> -- 
> 2.39.2
> 

Re: [igt-dev] [PATCH i-g-t 2/4] tests/kms_rotation_crc: use DRM_FORMAT_MOD_LINEAR as default modifier

[Kamil Konieczny]

Hi Maíra,

On 2023-04-03 at 10:01:22 -0300, Maíra Canal wrote:
> If the rotation is 90 or 270 degrees, the function prepare_fbs() uses a
> i915-specific modifier, I915_FORMAT_MOD_Y_TILED. In order to make the
> function more generic, use a i915-specific modifier only if the device
> is i915. Otherwise, use the DRM_FORMAT_MOD_LINEAR modifier.
> 
> Signed-off-by: Maíra Canal <mcanal@igalia.com>
> ---
>  tests/kms_rotation_crc.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c
> index 0d7b3962..cf02306f 100644
> --- a/tests/kms_rotation_crc.c
> +++ b/tests/kms_rotation_crc.c
> @@ -296,7 +296,8 @@ static void prepare_fbs(data_t *data, igt_output_t *output,
>  	 * frame can fit in
>  	 */
>  	if (igt_rotation_90_or_270(data->rotation)) {
> -		modifier = data->override_modifier ?: I915_FORMAT_MOD_Y_TILED;
> +		if (is_i915_device(data->gfx_fd))
---------------------- ^
is_intel_device

Regards,
Kamil

> +			modifier = data->override_modifier ?: I915_FORMAT_MOD_Y_TILED;
>  
>  		igt_swap(w, h);
>  	}
> -- 
> 2.39.2
> 

Re: [igt-dev] [PATCH i-g-t 3/4] tests/kms_rotation_crc: add tests for a rotated plane in a given position

[Kamil Konieczny]

Hi Maíra,

On 2023-04-03 at 10:01:23 -0300, Maíra Canal wrote:
> Currently, kms_rotation_crc only has one subtest testing a rotated plane
> in a given position: a subtest that rotates 90 degrees the overlay plane
> with a offset in the x axis. So, expand the subtest "sprite-rotation-90-pos-100-0"
> by creating subtests for 90, 180 and 270 degrees rotation with different
> x and y offsets. This can help us to assure that the rotation happens
> correctly even with offsets in the x and y axis.
> 
> Signed-off-by: Maíra Canal <mcanal@igalia.com>
> ---
>  tests/kms_rotation_crc.c | 33 +++++++++++++++++++++++++++------
>  1 file changed, 27 insertions(+), 6 deletions(-)
> 
> diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c
> index cf02306f..441a298b 100644
> --- a/tests/kms_rotation_crc.c
> +++ b/tests/kms_rotation_crc.c
> @@ -1134,6 +1134,23 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
>  		{ 0, 0 }
>  	};
>  
> +	struct rot_pos_subtest {
> +		igt_rotation_t rot;
> +		int pos_x;
> +		int pos_y;
> +	} *rot_pos, rot_pos_subtests[] = {
> +		{ IGT_ROTATION_90, 0, 100 },
> +		{ IGT_ROTATION_90, 100, 0 },
> +		{ IGT_ROTATION_90, 100, 100 },
> +		{ IGT_ROTATION_180, 0, 100 },
> +		{ IGT_ROTATION_180, 100, 0 },
> +		{ IGT_ROTATION_180, 100, 100 },
> +		{ IGT_ROTATION_270, 0, 100 },
> +		{ IGT_ROTATION_270, 100, 0 },
> +		{ IGT_ROTATION_270, 100, 100 },
> +		{ 0, 0 }
> +	};
> +
>  	int gen = 0;
>  
>  	igt_fixture {
> @@ -1170,12 +1187,16 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
>  		}
>  	}
>  
> -	igt_describe("Rotation test with 90 degree for a plane of gen9+ with given position");
> -	igt_subtest_f("sprite-rotation-90-pos-100-0") {
> -		data.rotation = IGT_ROTATION_90;
> -		data.pos_x = 100,
> -		data.pos_y = 0;
> -		test_plane_rotation(&data, DRM_PLANE_TYPE_OVERLAY, false);
> +	igt_describe("Rotation test with 90/180/270 degree for a plane of gen9+ with given position");
------------------------------------------------------------------------- ^
This is for intel platforms, maybe you should remove this from
description ind write a comment like:
/* for intel gen9+ platforms or other arch */

Or create function like bool has_rotation(...) so you could
skip on non-supported archs ?

Regards,
Kamil

> +	for (rot_pos = rot_pos_subtests; rot_pos->rot; rot_pos++) {
> +		igt_subtest_f("sprite-rotation-%s-pos-%d-%d", rot_test_str(rot_pos->rot),
> +			      rot_pos->pos_x,
> +			      rot_pos->pos_y) {
> +			data.rotation = rot_pos->rot;
> +			data.pos_x = rot_pos->pos_x;
> +			data.pos_y = rot_pos->pos_y;
> +			test_plane_rotation(&data, DRM_PLANE_TYPE_OVERLAY, false);
> +		}
>  	}
>  	data.pos_x = 0,
>  	data.pos_y = 0;
> -- 
> 2.39.2
> 

Re: [igt-dev] [PATCH i-g-t 4/4] tests/kms_rotation_crc: create generic reflection tests

[Kamil Konieczny]

Hi Maíra,

On 2023-04-03 at 10:01:24 -0300, Maíra Canal wrote:
> Currently, kms_rotation_crc doesn't have any tests for the reflect-x and
> reflect-y properties. Therefore, add generic reflection tests for the
> primary and overlay planes. Note that this tests should skip on i915
----------------------------------------------------------------- ^
intel

+cc Ville, Juha-Pekka and Bhanuprakash

> devices, as i915 devices use reflect-x together with specific modifiers.
> 
> Signed-off-by: Maíra Canal <mcanal@igalia.com>
> ---
>  tests/kms_rotation_crc.c | 31 +++++++++++++++++++++++++++++++
>  1 file changed, 31 insertions(+)
> 
> diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c
> index 441a298b..47a3973b 100644
> --- a/tests/kms_rotation_crc.c
> +++ b/tests/kms_rotation_crc.c
> @@ -131,6 +131,9 @@ static void rotate_colors(rgb_color_t *tl, rgb_color_t *tr, rgb_color_t *br,
>  	if (rotation & IGT_REFLECT_X) {
>  		igt_swap(*tl, *tr);
>  		igt_swap(*bl, *br);
> +	} else if (rotation & IGT_REFLECT_Y) {
> +		igt_swap(*tl, *bl);
> +		igt_swap(*tr, *br);
>  	}
>  
>  	if (rotation & IGT_ROTATION_90) {
> @@ -1055,6 +1058,10 @@ static const char *rot_test_str(igt_rotation_t rot)
>  		return "180";
>  	case IGT_ROTATION_270:
>  		return "270";
> +	case IGT_REFLECT_X:
> +		return "x";
> +	case IGT_REFLECT_Y:
> +		return "y";
>  	default:
>  		igt_assert(0);
>  	}
> @@ -1151,6 +1158,17 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
>  		{ 0, 0 }
>  	};
>  
> +	struct generic_reflect {
> +		unsigned int plane;
> +		igt_rotation_t rot;
> +	} *generic_reflect, generic_reflect_subtests[] = {
> +		{ DRM_PLANE_TYPE_PRIMARY, IGT_REFLECT_X },
> +		{ DRM_PLANE_TYPE_PRIMARY, IGT_REFLECT_Y },
> +		{ DRM_PLANE_TYPE_OVERLAY, IGT_REFLECT_X },
> +		{ DRM_PLANE_TYPE_OVERLAY, IGT_REFLECT_Y },
> +		{ 0, 0 }
> +	};
> +
>  	int gen = 0;
>  
>  	igt_fixture {
> @@ -1187,6 +1205,19 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
>  		}
>  	}
>  
> +	igt_describe("Generic reflection tests for primary and sprite planes");
> +	for (generic_reflect = generic_reflect_subtests; generic_reflect->rot; generic_reflect++) {
> +		igt_subtest_f("%s-reflect-%s",
> +			      plane_test_str(generic_reflect->plane),
> +			      rot_test_str(generic_reflect->rot)) {
> +			/* i915 devices have specific modifiers for reflection */
-------------------------- ^
intel
> +			igt_require(!is_i915_device(data.gfx_fd));
--------------------------------------- ^
is_intel_device

Regards,
Kamil

> +
> +			data.rotation = IGT_ROTATION_0 | generic_reflect->rot;
> +			test_plane_rotation(&data, generic_reflect->plane, false);
> +		}
> +	}
> +
>  	igt_describe("Rotation test with 90/180/270 degree for a plane of gen9+ with given position");
>  	for (rot_pos = rot_pos_subtests; rot_pos->rot; rot_pos++) {
>  		igt_subtest_f("sprite-rotation-%s-pos-%d-%d", rot_test_str(rot_pos->rot),
> -- 
> 2.39.2
>