* [Buildroot] [PATCH v2] package/qemu: install keyboard maps only if necessary
@ 2023-05-23 23:16 unixmania
2023-05-24 4:26 ` Yann E. MORIN
0 siblings, 1 reply; 2+ messages in thread
From: unixmania @ 2023-05-23 23:16 UTC (permalink / raw)
To: buildroot; +Cc: Carlos Santos, Romain Naour
From: Carlos Santos <unixmania@gmail.com>
They are required only for system emulation, so pull a patch already
reviewd upstream that makes the installation conditional:
https://patchwork.kernel.org/project/qemu-devel/patch/20230327172147.196607-1-casantos@redhat.com/
Signed-off-by: Carlos Santos <unixmania@gmail.com>
---
Changes v1->v2
- Fixed reference to uptream patch, using the QEMU patchwork
Note about the "Signed-off-by: Carlos Santos <casantos@redhat.com>" in
the patch:
Thousands of Red Hat employees contribute to free software projects
using their work email addresses. There is no contradiction between
personal and employee activity regarding this. Check this document for
additional information:
Red Hat’s open source participation guidelines
https://www.redhat.com/en/resources/open-source-participation-guidelines-overview
---
...tall-keyboard-maps-only-if-necessary.patch | 36 +++++++++++++++++++
1 file changed, 36 insertions(+)
create mode 100644 package/qemu/0003-meson-install-keyboard-maps-only-if-necessary.patch
diff --git a/package/qemu/0003-meson-install-keyboard-maps-only-if-necessary.patch b/package/qemu/0003-meson-install-keyboard-maps-only-if-necessary.patch
new file mode 100644
index 0000000000..91ea1e86c9
--- /dev/null
+++ b/package/qemu/0003-meson-install-keyboard-maps-only-if-necessary.patch
@@ -0,0 +1,36 @@
+From 9d9b74f806f5dbca53df6630c1a0591eaedd4500 Mon Sep 17 00:00:00 2001
+From: Carlos Santos <casantos@redhat.com>
+Date: Sun, 1 Jan 2023 21:00:57 -0300
+Subject: [PATCH] meson: install keyboard maps only if necessary
+
+They are required only for system emulation (i.e. have_system is true).
+
+Signed-off-by: Carlos Santos <casantos@redhat.com>
+---
+ pc-bios/keymaps/meson.build | 6 ++++--
+ 1 file changed, 4 insertions(+), 2 deletions(-)
+
+diff --git a/pc-bios/keymaps/meson.build b/pc-bios/keymaps/meson.build
+index 158a3b410c..bff3083313 100644
+--- a/pc-bios/keymaps/meson.build
++++ b/pc-bios/keymaps/meson.build
+@@ -47,7 +47,7 @@ if native_qemu_keymap.found()
+ build_by_default: true,
+ output: km,
+ command: [native_qemu_keymap, '-f', '@OUTPUT@', args.split()],
+- install: true,
++ install: have_system,
+ install_dir: qemu_datadir / 'keymaps')
+ endforeach
+
+@@ -56,4 +56,6 @@ else
+ install_data(keymaps.keys(), install_dir: qemu_datadir / 'keymaps')
+ endif
+
+-install_data(['sl', 'sv'], install_dir: qemu_datadir / 'keymaps')
++if have_system
++ install_data(['sl', 'sv'], install_dir: qemu_datadir / 'keymaps')
++endif
+--
+2.31.1
+
--
2.31.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Buildroot] [PATCH v2] package/qemu: install keyboard maps only if necessary
2023-05-23 23:16 [Buildroot] [PATCH v2] package/qemu: install keyboard maps only if necessary unixmania
@ 2023-05-24 4:26 ` Yann E. MORIN
0 siblings, 0 replies; 2+ messages in thread
From: Yann E. MORIN @ 2023-05-24 4:26 UTC (permalink / raw)
To: unixmania; +Cc: Romain Naour, buildroot
Carlos, All,
On 2023-05-23 20:16 -0300, unixmania@gmail.com spake thusly:
> From: Carlos Santos <unixmania@gmail.com>
>
> They are required only for system emulation, so pull a patch already
> reviewd upstream that makes the installation conditional:
>
> https://patchwork.kernel.org/project/qemu-devel/patch/20230327172147.196607-1-casantos@redhat.com/
>
> Signed-off-by: Carlos Santos <unixmania@gmail.com>
> ---
> Changes v1->v2
> - Fixed reference to uptream patch, using the QEMU patchwork
>
> Note about the "Signed-off-by: Carlos Santos <casantos@redhat.com>" in
> the patch:
>
> Thousands of Red Hat employees contribute to free software projects
> using their work email addresses. There is no contradiction between
> personal and employee activity regarding this. Check this document for
> additional information:
>
> Red Hat’s open source participation guidelines
> https://www.redhat.com/en/resources/open-source-participation-guidelines-overview
Still, it is our policy in Buildroot that the submitter adds its own SoB
when they carry a patch. In this case, the author casantos@redhat.com is
not the same (legally) as the submitter unixmania@gmail.com: the former
is a Red Hat employee, the latter is an individual acting in their own
name.
Please, add your unixmania@gmail.com SoB to the patch you add, as Arnout
requested.
Regards,
Yann E. MORIN.
> ---
> ...tall-keyboard-maps-only-if-necessary.patch | 36 +++++++++++++++++++
> 1 file changed, 36 insertions(+)
> create mode 100644 package/qemu/0003-meson-install-keyboard-maps-only-if-necessary.patch
>
> diff --git a/package/qemu/0003-meson-install-keyboard-maps-only-if-necessary.patch b/package/qemu/0003-meson-install-keyboard-maps-only-if-necessary.patch
> new file mode 100644
> index 0000000000..91ea1e86c9
> --- /dev/null
> +++ b/package/qemu/0003-meson-install-keyboard-maps-only-if-necessary.patch
> @@ -0,0 +1,36 @@
> +From 9d9b74f806f5dbca53df6630c1a0591eaedd4500 Mon Sep 17 00:00:00 2001
> +From: Carlos Santos <casantos@redhat.com>
> +Date: Sun, 1 Jan 2023 21:00:57 -0300
> +Subject: [PATCH] meson: install keyboard maps only if necessary
> +
> +They are required only for system emulation (i.e. have_system is true).
> +
> +Signed-off-by: Carlos Santos <casantos@redhat.com>
> +---
> + pc-bios/keymaps/meson.build | 6 ++++--
> + 1 file changed, 4 insertions(+), 2 deletions(-)
> +
> +diff --git a/pc-bios/keymaps/meson.build b/pc-bios/keymaps/meson.build
> +index 158a3b410c..bff3083313 100644
> +--- a/pc-bios/keymaps/meson.build
> ++++ b/pc-bios/keymaps/meson.build
> +@@ -47,7 +47,7 @@ if native_qemu_keymap.found()
> + build_by_default: true,
> + output: km,
> + command: [native_qemu_keymap, '-f', '@OUTPUT@', args.split()],
> +- install: true,
> ++ install: have_system,
> + install_dir: qemu_datadir / 'keymaps')
> + endforeach
> +
> +@@ -56,4 +56,6 @@ else
> + install_data(keymaps.keys(), install_dir: qemu_datadir / 'keymaps')
> + endif
> +
> +-install_data(['sl', 'sv'], install_dir: qemu_datadir / 'keymaps')
> ++if have_system
> ++ install_data(['sl', 'sv'], install_dir: qemu_datadir / 'keymaps')
> ++endif
> +--
> +2.31.1
> +
> --
> 2.31.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-05-24 4:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-23 23:16 [Buildroot] [PATCH v2] package/qemu: install keyboard maps only if necessary unixmania
2023-05-24 4:26 ` Yann E. MORIN
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.