* [PATCH] drm/i915/gt: Use the correct error value when kernel_context() fails
@ 2023-05-26 12:41 ` Andi Shyti
0 siblings, 0 replies; 14+ messages in thread
From: Andi Shyti @ 2023-05-26 12:41 UTC (permalink / raw)
To: Intel GFX, DRI Devel
Cc: Andi Shyti, Andi Shyti, Dan Carpenter, Chris Wilson, stable
kernel_context() returns an error pointer. Use pointer-error
conversion functions to evaluate its return value, rather than
checking for a '0' return.
Fixes: eb5c10cbbc2f ("drm/i915: Remove I915_USER_PRIORITY_SHIFT")
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com>
Cc: Chris Wilson < chris@chris-wilson.co.uk>
Cc: <stable@vger.kernel.org> # v5.13+
---
drivers/gpu/drm/i915/gt/selftest_execlists.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/selftest_execlists.c b/drivers/gpu/drm/i915/gt/selftest_execlists.c
index 736b89a8ecf54..4202df5b8c122 100644
--- a/drivers/gpu/drm/i915/gt/selftest_execlists.c
+++ b/drivers/gpu/drm/i915/gt/selftest_execlists.c
@@ -1530,8 +1530,8 @@ static int live_busywait_preempt(void *arg)
struct drm_i915_gem_object *obj;
struct i915_vma *vma;
enum intel_engine_id id;
- int err = -ENOMEM;
u32 *map;
+ int err;
/*
* Verify that even without HAS_LOGICAL_RING_PREEMPTION, we can
@@ -1539,13 +1539,17 @@ static int live_busywait_preempt(void *arg)
*/
ctx_hi = kernel_context(gt->i915, NULL);
- if (!ctx_hi)
- return -ENOMEM;
+ if (IS_ERR(ctx_hi))
+ return PTR_ERR(ctx_hi);
+
ctx_hi->sched.priority = I915_CONTEXT_MAX_USER_PRIORITY;
ctx_lo = kernel_context(gt->i915, NULL);
- if (!ctx_lo)
+ if (IS_ERR(ctx_lo)) {
+ err = PTR_ERR(ctx_lo);
goto err_ctx_hi;
+ }
+
ctx_lo->sched.priority = I915_CONTEXT_MIN_USER_PRIORITY;
obj = i915_gem_object_create_internal(gt->i915, PAGE_SIZE);
--
2.40.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH] drm/i915/gt: Use the correct error value when kernel_context() fails
@ 2023-05-26 12:41 ` Andi Shyti
0 siblings, 0 replies; 14+ messages in thread
From: Andi Shyti @ 2023-05-26 12:41 UTC (permalink / raw)
To: Intel GFX, DRI Devel
Cc: Dan Carpenter, stable, Andi Shyti, Andi Shyti, Chris Wilson
kernel_context() returns an error pointer. Use pointer-error
conversion functions to evaluate its return value, rather than
checking for a '0' return.
Fixes: eb5c10cbbc2f ("drm/i915: Remove I915_USER_PRIORITY_SHIFT")
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com>
Cc: Chris Wilson < chris@chris-wilson.co.uk>
Cc: <stable@vger.kernel.org> # v5.13+
---
drivers/gpu/drm/i915/gt/selftest_execlists.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/selftest_execlists.c b/drivers/gpu/drm/i915/gt/selftest_execlists.c
index 736b89a8ecf54..4202df5b8c122 100644
--- a/drivers/gpu/drm/i915/gt/selftest_execlists.c
+++ b/drivers/gpu/drm/i915/gt/selftest_execlists.c
@@ -1530,8 +1530,8 @@ static int live_busywait_preempt(void *arg)
struct drm_i915_gem_object *obj;
struct i915_vma *vma;
enum intel_engine_id id;
- int err = -ENOMEM;
u32 *map;
+ int err;
/*
* Verify that even without HAS_LOGICAL_RING_PREEMPTION, we can
@@ -1539,13 +1539,17 @@ static int live_busywait_preempt(void *arg)
*/
ctx_hi = kernel_context(gt->i915, NULL);
- if (!ctx_hi)
- return -ENOMEM;
+ if (IS_ERR(ctx_hi))
+ return PTR_ERR(ctx_hi);
+
ctx_hi->sched.priority = I915_CONTEXT_MAX_USER_PRIORITY;
ctx_lo = kernel_context(gt->i915, NULL);
- if (!ctx_lo)
+ if (IS_ERR(ctx_lo)) {
+ err = PTR_ERR(ctx_lo);
goto err_ctx_hi;
+ }
+
ctx_lo->sched.priority = I915_CONTEXT_MIN_USER_PRIORITY;
obj = i915_gem_object_create_internal(gt->i915, PAGE_SIZE);
--
2.40.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [Intel-gfx] [PATCH] drm/i915/gt: Use the correct error value when kernel_context() fails
@ 2023-05-26 12:41 ` Andi Shyti
0 siblings, 0 replies; 14+ messages in thread
From: Andi Shyti @ 2023-05-26 12:41 UTC (permalink / raw)
To: Intel GFX, DRI Devel; +Cc: Dan Carpenter, stable, Andi Shyti, Chris Wilson
kernel_context() returns an error pointer. Use pointer-error
conversion functions to evaluate its return value, rather than
checking for a '0' return.
Fixes: eb5c10cbbc2f ("drm/i915: Remove I915_USER_PRIORITY_SHIFT")
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com>
Cc: Chris Wilson < chris@chris-wilson.co.uk>
Cc: <stable@vger.kernel.org> # v5.13+
---
drivers/gpu/drm/i915/gt/selftest_execlists.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/selftest_execlists.c b/drivers/gpu/drm/i915/gt/selftest_execlists.c
index 736b89a8ecf54..4202df5b8c122 100644
--- a/drivers/gpu/drm/i915/gt/selftest_execlists.c
+++ b/drivers/gpu/drm/i915/gt/selftest_execlists.c
@@ -1530,8 +1530,8 @@ static int live_busywait_preempt(void *arg)
struct drm_i915_gem_object *obj;
struct i915_vma *vma;
enum intel_engine_id id;
- int err = -ENOMEM;
u32 *map;
+ int err;
/*
* Verify that even without HAS_LOGICAL_RING_PREEMPTION, we can
@@ -1539,13 +1539,17 @@ static int live_busywait_preempt(void *arg)
*/
ctx_hi = kernel_context(gt->i915, NULL);
- if (!ctx_hi)
- return -ENOMEM;
+ if (IS_ERR(ctx_hi))
+ return PTR_ERR(ctx_hi);
+
ctx_hi->sched.priority = I915_CONTEXT_MAX_USER_PRIORITY;
ctx_lo = kernel_context(gt->i915, NULL);
- if (!ctx_lo)
+ if (IS_ERR(ctx_lo)) {
+ err = PTR_ERR(ctx_lo);
goto err_ctx_hi;
+ }
+
ctx_lo->sched.priority = I915_CONTEXT_MIN_USER_PRIORITY;
obj = i915_gem_object_create_internal(gt->i915, PAGE_SIZE);
--
2.40.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gt: Use the correct error value when kernel_context() fails
2023-05-26 12:41 ` Andi Shyti
(?)
(?)
@ 2023-05-26 16:00 ` Patchwork
-1 siblings, 0 replies; 14+ messages in thread
From: Patchwork @ 2023-05-26 16:00 UTC (permalink / raw)
To: Andi Shyti; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/gt: Use the correct error value when kernel_context() fails
URL : https://patchwork.freedesktop.org/series/118429/
State : warning
== Summary ==
Error: dim checkpatch failed
73a5046dfd9e drm/i915/gt: Use the correct error value when kernel_context() fails
-:12: WARNING:BAD_REPORTED_BY_LINK: Reported-by: should be immediately followed by Closes: with a URL to the report
#12:
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com>
-:14: ERROR:BAD_SIGN_OFF: Unrecognized email address: 'Chris Wilson < chris@chris-wilson.co.uk>'
#14:
Cc: Chris Wilson < chris@chris-wilson.co.uk>
total: 1 errors, 1 warnings, 0 checks, 29 lines checked
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Use the correct error value when kernel_context() fails
2023-05-26 12:41 ` Andi Shyti
` (2 preceding siblings ...)
(?)
@ 2023-05-26 16:14 ` Patchwork
-1 siblings, 0 replies; 14+ messages in thread
From: Patchwork @ 2023-05-26 16:14 UTC (permalink / raw)
To: Andi Shyti; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 8435 bytes --]
== Series Details ==
Series: drm/i915/gt: Use the correct error value when kernel_context() fails
URL : https://patchwork.freedesktop.org/series/118429/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13195 -> Patchwork_118429v1
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118429v1/index.html
Participating hosts (38 -> 39)
------------------------------
Additional (2): fi-kbl-soraka bat-mtlp-6
Missing (1): fi-snb-2520m
Known issues
------------
Here are the changes found in Patchwork_118429v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_huc_copy@huc-copy:
- fi-kbl-soraka: NOTRUN -> [SKIP][1] ([fdo#109271] / [i915#2190])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118429v1/fi-kbl-soraka/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@basic:
- fi-kbl-soraka: NOTRUN -> [SKIP][2] ([fdo#109271] / [i915#4613]) +3 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118429v1/fi-kbl-soraka/igt@gem_lmem_swapping@basic.html
* igt@i915_selftest@live@execlists:
- fi-kbl-soraka: NOTRUN -> [INCOMPLETE][3] ([i915#7156] / [i915#7913])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118429v1/fi-kbl-soraka/igt@i915_selftest@live@execlists.html
* igt@i915_selftest@live@gt_heartbeat:
- fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][4] ([i915#5334] / [i915#7872])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118429v1/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html
- fi-apl-guc: [PASS][5] -> [DMESG-FAIL][6] ([i915#5334])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13195/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118429v1/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
* igt@i915_selftest@live@gt_pm:
- fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][7] ([i915#1886] / [i915#7913])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118429v1/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html
* igt@i915_selftest@live@reset:
- bat-rpls-2: NOTRUN -> [ABORT][8] ([i915#4983] / [i915#7461] / [i915#7913] / [i915#8347])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118429v1/bat-rpls-2/igt@i915_selftest@live@reset.html
* igt@i915_selftest@live@slpc:
- bat-rpls-1: NOTRUN -> [DMESG-WARN][9] ([i915#6367])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118429v1/bat-rpls-1/igt@i915_selftest@live@slpc.html
* igt@i915_suspend@basic-s3-without-i915:
- bat-rpls-1: NOTRUN -> [ABORT][10] ([i915#6687] / [i915#7978])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118429v1/bat-rpls-1/igt@i915_suspend@basic-s3-without-i915.html
* igt@kms_chamelium_frames@hdmi-crc-fast:
- fi-kbl-soraka: NOTRUN -> [SKIP][11] ([fdo#109271]) +14 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118429v1/fi-kbl-soraka/igt@kms_chamelium_frames@hdmi-crc-fast.html
* igt@kms_setmode@basic-clone-single-crtc:
- fi-kbl-soraka: NOTRUN -> [SKIP][12] ([fdo#109271] / [i915#4579])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118429v1/fi-kbl-soraka/igt@kms_setmode@basic-clone-single-crtc.html
#### Possible fixes ####
* igt@i915_selftest@live@gt_mocs:
- {bat-mtlp-8}: [DMESG-FAIL][13] ([i915#7059]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13195/bat-mtlp-8/igt@i915_selftest@live@gt_mocs.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118429v1/bat-mtlp-8/igt@i915_selftest@live@gt_mocs.html
* igt@i915_selftest@live@requests:
- bat-rpls-2: [ABORT][15] ([i915#7913] / [i915#7982]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13195/bat-rpls-2/igt@i915_selftest@live@requests.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118429v1/bat-rpls-2/igt@i915_selftest@live@requests.html
* igt@i915_selftest@live@reset:
- bat-rpls-1: [ABORT][17] ([i915#4983] / [i915#7461] / [i915#8347] / [i915#8384]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13195/bat-rpls-1/igt@i915_selftest@live@reset.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118429v1/bat-rpls-1/igt@i915_selftest@live@reset.html
#### Warnings ####
* igt@kms_psr@primary_mmap_gtt:
- bat-rplp-1: [SKIP][19] ([i915#1072]) -> [ABORT][20] ([i915#8442])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13195/bat-rplp-1/igt@kms_psr@primary_mmap_gtt.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118429v1/bat-rplp-1/igt@kms_psr@primary_mmap_gtt.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[IGT#6]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/6
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3595]: https://gitlab.freedesktop.org/drm/intel/issues/3595
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4342]: https://gitlab.freedesktop.org/drm/intel/issues/4342
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190
[i915#5274]: https://gitlab.freedesktop.org/drm/intel/issues/5274
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6645]: https://gitlab.freedesktop.org/drm/intel/issues/6645
[i915#6687]: https://gitlab.freedesktop.org/drm/intel/issues/6687
[i915#7059]: https://gitlab.freedesktop.org/drm/intel/issues/7059
[i915#7156]: https://gitlab.freedesktop.org/drm/intel/issues/7156
[i915#7456]: https://gitlab.freedesktop.org/drm/intel/issues/7456
[i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7872]: https://gitlab.freedesktop.org/drm/intel/issues/7872
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#7978]: https://gitlab.freedesktop.org/drm/intel/issues/7978
[i915#7982]: https://gitlab.freedesktop.org/drm/intel/issues/7982
[i915#8347]: https://gitlab.freedesktop.org/drm/intel/issues/8347
[i915#8384]: https://gitlab.freedesktop.org/drm/intel/issues/8384
[i915#8442]: https://gitlab.freedesktop.org/drm/intel/issues/8442
[i915#8497]: https://gitlab.freedesktop.org/drm/intel/issues/8497
Build changes
-------------
* Linux: CI_DRM_13195 -> Patchwork_118429v1
CI-20190529: 20190529
CI_DRM_13195: 8de6f7d7e58a51740d5bcaf203d2eb4a94762f5d @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7305: 09aa9628059a93510b658dcc731ae4c8bd223790 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_118429v1: 8de6f7d7e58a51740d5bcaf203d2eb4a94762f5d @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
2139f2bce763 drm/i915/gt: Use the correct error value when kernel_context() fails
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118429v1/index.html
[-- Attachment #2: Type: text/html, Size: 8628 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gt: Use the correct error value when kernel_context() fails
2023-05-26 12:41 ` Andi Shyti
` (3 preceding siblings ...)
(?)
@ 2023-05-27 13:07 ` Patchwork
-1 siblings, 0 replies; 14+ messages in thread
From: Patchwork @ 2023-05-27 13:07 UTC (permalink / raw)
To: Andi Shyti; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 14194 bytes --]
== Series Details ==
Series: drm/i915/gt: Use the correct error value when kernel_context() fails
URL : https://patchwork.freedesktop.org/series/118429/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13195_full -> Patchwork_118429v1_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (8 -> 7)
------------------------------
Missing (1): shard-rkl0
Known issues
------------
Here are the changes found in Patchwork_118429v1_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_eio@reset-stress:
- shard-snb: NOTRUN -> [TIMEOUT][1] ([i915#3063])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118429v1/shard-snb5/igt@gem_eio@reset-stress.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-apl: [PASS][2] -> [FAIL][3] ([i915#2842])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13195/shard-apl6/igt@gem_exec_fair@basic-pace-share@rcs0.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118429v1/shard-apl1/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-vga:
- shard-snb: NOTRUN -> [SKIP][4] ([fdo#109271] / [i915#4579]) +20 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118429v1/shard-snb5/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-vga.html
* igt@i915_pm_rps@reset:
- shard-snb: [PASS][5] -> [INCOMPLETE][6] ([i915#7790])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13195/shard-snb5/igt@i915_pm_rps@reset.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118429v1/shard-snb2/igt@i915_pm_rps@reset.html
* igt@kms_big_fb@x-tiled-32bpp-rotate-90:
- shard-apl: NOTRUN -> [SKIP][7] ([IGT#6] / [fdo#109271]) +9 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118429v1/shard-apl6/igt@kms_big_fb@x-tiled-32bpp-rotate-90.html
* igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc:
- shard-apl: NOTRUN -> [SKIP][8] ([fdo#109271] / [i915#3886])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118429v1/shard-apl6/igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_color@ctm-green-to-red@pipe-a-hdmi-a-1:
- shard-snb: NOTRUN -> [SKIP][9] ([fdo#109271]) +80 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118429v1/shard-snb1/igt@kms_color@ctm-green-to-red@pipe-a-hdmi-a-1.html
* igt@kms_content_protection@lic@pipe-a-dp-1:
- shard-apl: NOTRUN -> [TIMEOUT][10] ([i915#7173])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118429v1/shard-apl6/igt@kms_content_protection@lic@pipe-a-dp-1.html
* igt@kms_cursor_crc@cursor-sliding-32x32:
- shard-apl: NOTRUN -> [SKIP][11] ([fdo#109271] / [i915#4579]) +2 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118429v1/shard-apl6/igt@kms_cursor_crc@cursor-sliding-32x32.html
* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy:
- shard-glk: [PASS][12] -> [FAIL][13] ([IGT#6] / [i915#72])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13195/shard-glk2/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118429v1/shard-glk7/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy.html
* igt@kms_dp_tiled_display@basic-test-pattern-with-chamelium:
- shard-apl: NOTRUN -> [SKIP][14] ([fdo#109271]) +10 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118429v1/shard-apl6/igt@kms_dp_tiled_display@basic-test-pattern-with-chamelium.html
* igt@kms_flip@flip-vs-expired-vblank@c-hdmi-a2:
- shard-glk: [PASS][15] -> [FAIL][16] ([i915#79])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13195/shard-glk9/igt@kms_flip@flip-vs-expired-vblank@c-hdmi-a2.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118429v1/shard-glk9/igt@kms_flip@flip-vs-expired-vblank@c-hdmi-a2.html
* igt@kms_hdr@static-toggle:
- shard-apl: NOTRUN -> [SKIP][17] ([IGT#6] / [fdo#109271] / [i915#4579])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118429v1/shard-apl6/igt@kms_hdr@static-toggle.html
* igt@kms_plane@plane-panning-bottom-right-suspend@pipe-a-planes:
- shard-apl: [PASS][18] -> [ABORT][19] ([i915#180])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13195/shard-apl4/igt@kms_plane@plane-panning-bottom-right-suspend@pipe-a-planes.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118429v1/shard-apl3/igt@kms_plane@plane-panning-bottom-right-suspend@pipe-a-planes.html
#### Possible fixes ####
* igt@drm_fdinfo@most-busy-idle-check-all@rcs0:
- {shard-rkl}: [FAIL][20] ([i915#7742]) -> [PASS][21]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13195/shard-rkl-1/igt@drm_fdinfo@most-busy-idle-check-all@rcs0.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118429v1/shard-rkl-7/igt@drm_fdinfo@most-busy-idle-check-all@rcs0.html
* igt@gem_busy@close-race:
- shard-snb: [ABORT][22] -> [PASS][23]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13195/shard-snb2/igt@gem_busy@close-race.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118429v1/shard-snb5/igt@gem_busy@close-race.html
* igt@gem_ctx_exec@basic-nohangcheck:
- {shard-rkl}: [FAIL][24] ([i915#6268]) -> [PASS][25]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13195/shard-rkl-7/igt@gem_ctx_exec@basic-nohangcheck.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118429v1/shard-rkl-1/igt@gem_ctx_exec@basic-nohangcheck.html
* igt@gem_exec_fair@basic-throttle@rcs0:
- {shard-rkl}: [FAIL][26] ([i915#2842]) -> [PASS][27] +1 similar issue
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13195/shard-rkl-1/igt@gem_exec_fair@basic-throttle@rcs0.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118429v1/shard-rkl-4/igt@gem_exec_fair@basic-throttle@rcs0.html
* igt@gen9_exec_parse@allowed-single:
- shard-apl: [ABORT][28] ([i915#5566]) -> [PASS][29]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13195/shard-apl7/igt@gen9_exec_parse@allowed-single.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118429v1/shard-apl6/igt@gen9_exec_parse@allowed-single.html
* igt@i915_pm_rpm@dpms-mode-unset-lpsp:
- {shard-rkl}: [SKIP][30] ([i915#1397]) -> [PASS][31] +2 similar issues
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13195/shard-rkl-4/igt@i915_pm_rpm@dpms-mode-unset-lpsp.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118429v1/shard-rkl-7/igt@i915_pm_rpm@dpms-mode-unset-lpsp.html
* igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip:
- {shard-rkl}: [FAIL][32] ([i915#3743]) -> [PASS][33]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13195/shard-rkl-7/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118429v1/shard-rkl-1/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip.html
* igt@kms_color@ctm-blue-to-red@pipe-b-hdmi-a-4:
- {shard-dg1}: [INCOMPLETE][34] -> [PASS][35]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13195/shard-dg1-14/igt@kms_color@ctm-blue-to-red@pipe-b-hdmi-a-4.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118429v1/shard-dg1-16/igt@kms_color@ctm-blue-to-red@pipe-b-hdmi-a-4.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-glk: [FAIL][36] ([IGT#6] / [i915#2346]) -> [PASS][37]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13195/shard-glk1/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118429v1/shard-glk9/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-apl: [FAIL][38] ([IGT#6] / [i915#4767]) -> [PASS][39]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13195/shard-apl1/igt@kms_fbcon_fbt@fbc-suspend.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118429v1/shard-apl7/igt@kms_fbcon_fbt@fbc-suspend.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a2:
- shard-glk: [FAIL][40] ([i915#79]) -> [PASS][41] +1 similar issue
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13195/shard-glk8/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a2.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118429v1/shard-glk1/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a2.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[IGT#6]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/6
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109307]: https://bugs.freedesktop.org/show_bug.cgi?id=109307
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1937]: https://gitlab.freedesktop.org/drm/intel/issues/1937
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#3023]: https://gitlab.freedesktop.org/drm/intel/issues/3023
[i915#3063]: https://gitlab.freedesktop.org/drm/intel/issues/3063
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
[i915#3804]: https://gitlab.freedesktop.org/drm/intel/issues/3804
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#3989]: https://gitlab.freedesktop.org/drm/intel/issues/3989
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767
[i915#4816]: https://gitlab.freedesktop.org/drm/intel/issues/4816
[i915#4936]: https://gitlab.freedesktop.org/drm/intel/issues/4936
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#5493]: https://gitlab.freedesktop.org/drm/intel/issues/5493
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
[i915#6786]: https://gitlab.freedesktop.org/drm/intel/issues/6786
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#7173]: https://gitlab.freedesktop.org/drm/intel/issues/7173
[i915#72]: https://gitlab.freedesktop.org/drm/intel/issues/72
[i915#7276]: https://gitlab.freedesktop.org/drm/intel/issues/7276
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697
[i915#7701]: https://gitlab.freedesktop.org/drm/intel/issues/7701
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#7790]: https://gitlab.freedesktop.org/drm/intel/issues/7790
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#7941]: https://gitlab.freedesktop.org/drm/intel/issues/7941
[i915#7975]: https://gitlab.freedesktop.org/drm/intel/issues/7975
[i915#8011]: https://gitlab.freedesktop.org/drm/intel/issues/8011
[i915#8213]: https://gitlab.freedesktop.org/drm/intel/issues/8213
[i915#8502]: https://gitlab.freedesktop.org/drm/intel/issues/8502
Build changes
-------------
* Linux: CI_DRM_13195 -> Patchwork_118429v1
CI-20190529: 20190529
CI_DRM_13195: 8de6f7d7e58a51740d5bcaf203d2eb4a94762f5d @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7305: 09aa9628059a93510b658dcc731ae4c8bd223790 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_118429v1: 8de6f7d7e58a51740d5bcaf203d2eb4a94762f5d @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118429v1/index.html
[-- Attachment #2: Type: text/html, Size: 13049 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/gt: Use the correct error value when kernel_context() fails
2023-05-26 12:41 ` Andi Shyti
@ 2023-06-01 12:44 ` Andrzej Hajda
-1 siblings, 0 replies; 14+ messages in thread
From: Andrzej Hajda @ 2023-06-01 12:44 UTC (permalink / raw)
To: Andi Shyti, Intel GFX, DRI Devel
Cc: Dan Carpenter, stable, Andi Shyti, Chris Wilson
On 26.05.2023 14:41, Andi Shyti wrote:
> kernel_context() returns an error pointer. Use pointer-error
> conversion functions to evaluate its return value, rather than
> checking for a '0' return.
>
> Fixes: eb5c10cbbc2f ("drm/i915: Remove I915_USER_PRIORITY_SHIFT")
> Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com>
> Cc: Chris Wilson < chris@chris-wilson.co.uk>
> Cc: <stable@vger.kernel.org> # v5.13+
Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
Regards
Andrzej
> ---
> drivers/gpu/drm/i915/gt/selftest_execlists.c | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/selftest_execlists.c b/drivers/gpu/drm/i915/gt/selftest_execlists.c
> index 736b89a8ecf54..4202df5b8c122 100644
> --- a/drivers/gpu/drm/i915/gt/selftest_execlists.c
> +++ b/drivers/gpu/drm/i915/gt/selftest_execlists.c
> @@ -1530,8 +1530,8 @@ static int live_busywait_preempt(void *arg)
> struct drm_i915_gem_object *obj;
> struct i915_vma *vma;
> enum intel_engine_id id;
> - int err = -ENOMEM;
> u32 *map;
> + int err;
>
> /*
> * Verify that even without HAS_LOGICAL_RING_PREEMPTION, we can
> @@ -1539,13 +1539,17 @@ static int live_busywait_preempt(void *arg)
> */
>
> ctx_hi = kernel_context(gt->i915, NULL);
> - if (!ctx_hi)
> - return -ENOMEM;
> + if (IS_ERR(ctx_hi))
> + return PTR_ERR(ctx_hi);
> +
> ctx_hi->sched.priority = I915_CONTEXT_MAX_USER_PRIORITY;
>
> ctx_lo = kernel_context(gt->i915, NULL);
> - if (!ctx_lo)
> + if (IS_ERR(ctx_lo)) {
> + err = PTR_ERR(ctx_lo);
> goto err_ctx_hi;
> + }
> +
> ctx_lo->sched.priority = I915_CONTEXT_MIN_USER_PRIORITY;
>
> obj = i915_gem_object_create_internal(gt->i915, PAGE_SIZE);
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/gt: Use the correct error value when kernel_context() fails
@ 2023-06-01 12:44 ` Andrzej Hajda
0 siblings, 0 replies; 14+ messages in thread
From: Andrzej Hajda @ 2023-06-01 12:44 UTC (permalink / raw)
To: Andi Shyti, Intel GFX, DRI Devel
Cc: Chris Wilson, stable, Dan Carpenter, Andi Shyti
On 26.05.2023 14:41, Andi Shyti wrote:
> kernel_context() returns an error pointer. Use pointer-error
> conversion functions to evaluate its return value, rather than
> checking for a '0' return.
>
> Fixes: eb5c10cbbc2f ("drm/i915: Remove I915_USER_PRIORITY_SHIFT")
> Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com>
> Cc: Chris Wilson < chris@chris-wilson.co.uk>
> Cc: <stable@vger.kernel.org> # v5.13+
Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
Regards
Andrzej
> ---
> drivers/gpu/drm/i915/gt/selftest_execlists.c | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/selftest_execlists.c b/drivers/gpu/drm/i915/gt/selftest_execlists.c
> index 736b89a8ecf54..4202df5b8c122 100644
> --- a/drivers/gpu/drm/i915/gt/selftest_execlists.c
> +++ b/drivers/gpu/drm/i915/gt/selftest_execlists.c
> @@ -1530,8 +1530,8 @@ static int live_busywait_preempt(void *arg)
> struct drm_i915_gem_object *obj;
> struct i915_vma *vma;
> enum intel_engine_id id;
> - int err = -ENOMEM;
> u32 *map;
> + int err;
>
> /*
> * Verify that even without HAS_LOGICAL_RING_PREEMPTION, we can
> @@ -1539,13 +1539,17 @@ static int live_busywait_preempt(void *arg)
> */
>
> ctx_hi = kernel_context(gt->i915, NULL);
> - if (!ctx_hi)
> - return -ENOMEM;
> + if (IS_ERR(ctx_hi))
> + return PTR_ERR(ctx_hi);
> +
> ctx_hi->sched.priority = I915_CONTEXT_MAX_USER_PRIORITY;
>
> ctx_lo = kernel_context(gt->i915, NULL);
> - if (!ctx_lo)
> + if (IS_ERR(ctx_lo)) {
> + err = PTR_ERR(ctx_lo);
> goto err_ctx_hi;
> + }
> +
> ctx_lo->sched.priority = I915_CONTEXT_MIN_USER_PRIORITY;
>
> obj = i915_gem_object_create_internal(gt->i915, PAGE_SIZE);
^ permalink raw reply [flat|nested] 14+ messages in thread
* RE: [Intel-gfx] [PATCH] drm/i915/gt: Use the correct error value when kernel_context() fails
2023-06-01 12:44 ` Andrzej Hajda
(?)
@ 2023-06-01 14:30 ` Upadhyay, Tejas
-1 siblings, 0 replies; 14+ messages in thread
From: Upadhyay, Tejas @ 2023-06-01 14:30 UTC (permalink / raw)
To: Hajda, Andrzej, Andi Shyti, Intel GFX, DRI Devel
Cc: Andi Shyti, Dan Carpenter, stable, Chris Wilson
> -----Original Message-----
> From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of
> Andrzej Hajda
> Sent: Thursday, June 1, 2023 6:14 PM
> To: Andi Shyti <andi.shyti@linux.intel.com>; Intel GFX <intel-
> gfx@lists.freedesktop.org>; DRI Devel <dri-devel@lists.freedesktop.org>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>; stable@vger.kernel.org; Dan
> Carpenter <dan.carpenter@linaro.org>; Andi Shyti <andi.shyti@kernel.org>
> Subject: Re: [Intel-gfx] [PATCH] drm/i915/gt: Use the correct error value
> when kernel_context() fails
>
> On 26.05.2023 14:41, Andi Shyti wrote:
> > kernel_context() returns an error pointer. Use pointer-error
> > conversion functions to evaluate its return value, rather than
> > checking for a '0' return.
> >
> > Fixes: eb5c10cbbc2f ("drm/i915: Remove I915_USER_PRIORITY_SHIFT")
> > Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> > Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com>
> > Cc: Chris Wilson < chris@chris-wilson.co.uk>
> > Cc: <stable@vger.kernel.org> # v5.13+
>
> Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
>
> Regards
> Andrzej
>
> > ---
> > drivers/gpu/drm/i915/gt/selftest_execlists.c | 12 ++++++++----
> > 1 file changed, 8 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/gt/selftest_execlists.c
> > b/drivers/gpu/drm/i915/gt/selftest_execlists.c
> > index 736b89a8ecf54..4202df5b8c122 100644
> > --- a/drivers/gpu/drm/i915/gt/selftest_execlists.c
> > +++ b/drivers/gpu/drm/i915/gt/selftest_execlists.c
> > @@ -1530,8 +1530,8 @@ static int live_busywait_preempt(void *arg)
> > struct drm_i915_gem_object *obj;
> > struct i915_vma *vma;
> > enum intel_engine_id id;
> > - int err = -ENOMEM;
> > u32 *map;
> > + int err;
We could initialize err with 0 and remove err = 0 assignment below but leaving up to you.
> >
> > /*
> > * Verify that even without HAS_LOGICAL_RING_PREEMPTION, we
> can @@
> > -1539,13 +1539,17 @@ static int live_busywait_preempt(void *arg)
> > */
> >
> > ctx_hi = kernel_context(gt->i915, NULL);
> > - if (!ctx_hi)
> > - return -ENOMEM;
> > + if (IS_ERR(ctx_hi))
> > + return PTR_ERR(ctx_hi);
> > +
> > ctx_hi->sched.priority = I915_CONTEXT_MAX_USER_PRIORITY;
> >
> > ctx_lo = kernel_context(gt->i915, NULL);
> > - if (!ctx_lo)
> > + if (IS_ERR(ctx_lo)) {
> > + err = PTR_ERR(ctx_lo);
> > goto err_ctx_hi;
> > + }
> > +
Looks fine,
Acked-by: Tejas Upadhyay <tejas.upadhyay@intel.com>
> > ctx_lo->sched.priority = I915_CONTEXT_MIN_USER_PRIORITY;
> >
> > obj = i915_gem_object_create_internal(gt->i915, PAGE_SIZE);
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/gt: Use the correct error value when kernel_context() fails
@ 2023-06-01 14:30 ` Upadhyay, Tejas
0 siblings, 0 replies; 14+ messages in thread
From: Upadhyay, Tejas @ 2023-06-01 14:30 UTC (permalink / raw)
To: Hajda, Andrzej, Andi Shyti, Intel GFX, DRI Devel
Cc: Andi Shyti, Dan Carpenter, stable, Chris Wilson
> -----Original Message-----
> From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of
> Andrzej Hajda
> Sent: Thursday, June 1, 2023 6:14 PM
> To: Andi Shyti <andi.shyti@linux.intel.com>; Intel GFX <intel-
> gfx@lists.freedesktop.org>; DRI Devel <dri-devel@lists.freedesktop.org>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>; stable@vger.kernel.org; Dan
> Carpenter <dan.carpenter@linaro.org>; Andi Shyti <andi.shyti@kernel.org>
> Subject: Re: [Intel-gfx] [PATCH] drm/i915/gt: Use the correct error value
> when kernel_context() fails
>
> On 26.05.2023 14:41, Andi Shyti wrote:
> > kernel_context() returns an error pointer. Use pointer-error
> > conversion functions to evaluate its return value, rather than
> > checking for a '0' return.
> >
> > Fixes: eb5c10cbbc2f ("drm/i915: Remove I915_USER_PRIORITY_SHIFT")
> > Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> > Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com>
> > Cc: Chris Wilson < chris@chris-wilson.co.uk>
> > Cc: <stable@vger.kernel.org> # v5.13+
>
> Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
>
> Regards
> Andrzej
>
> > ---
> > drivers/gpu/drm/i915/gt/selftest_execlists.c | 12 ++++++++----
> > 1 file changed, 8 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/gt/selftest_execlists.c
> > b/drivers/gpu/drm/i915/gt/selftest_execlists.c
> > index 736b89a8ecf54..4202df5b8c122 100644
> > --- a/drivers/gpu/drm/i915/gt/selftest_execlists.c
> > +++ b/drivers/gpu/drm/i915/gt/selftest_execlists.c
> > @@ -1530,8 +1530,8 @@ static int live_busywait_preempt(void *arg)
> > struct drm_i915_gem_object *obj;
> > struct i915_vma *vma;
> > enum intel_engine_id id;
> > - int err = -ENOMEM;
> > u32 *map;
> > + int err;
We could initialize err with 0 and remove err = 0 assignment below but leaving up to you.
> >
> > /*
> > * Verify that even without HAS_LOGICAL_RING_PREEMPTION, we
> can @@
> > -1539,13 +1539,17 @@ static int live_busywait_preempt(void *arg)
> > */
> >
> > ctx_hi = kernel_context(gt->i915, NULL);
> > - if (!ctx_hi)
> > - return -ENOMEM;
> > + if (IS_ERR(ctx_hi))
> > + return PTR_ERR(ctx_hi);
> > +
> > ctx_hi->sched.priority = I915_CONTEXT_MAX_USER_PRIORITY;
> >
> > ctx_lo = kernel_context(gt->i915, NULL);
> > - if (!ctx_lo)
> > + if (IS_ERR(ctx_lo)) {
> > + err = PTR_ERR(ctx_lo);
> > goto err_ctx_hi;
> > + }
> > +
Looks fine,
Acked-by: Tejas Upadhyay <tejas.upadhyay@intel.com>
> > ctx_lo->sched.priority = I915_CONTEXT_MIN_USER_PRIORITY;
> >
> > obj = i915_gem_object_create_internal(gt->i915, PAGE_SIZE);
^ permalink raw reply [flat|nested] 14+ messages in thread
* RE: [Intel-gfx] [PATCH] drm/i915/gt: Use the correct error value when kernel_context() fails
@ 2023-06-01 14:30 ` Upadhyay, Tejas
0 siblings, 0 replies; 14+ messages in thread
From: Upadhyay, Tejas @ 2023-06-01 14:30 UTC (permalink / raw)
To: Hajda, Andrzej, Andi Shyti, Intel GFX, DRI Devel
Cc: Chris Wilson, stable, Dan Carpenter, Andi Shyti
> -----Original Message-----
> From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of
> Andrzej Hajda
> Sent: Thursday, June 1, 2023 6:14 PM
> To: Andi Shyti <andi.shyti@linux.intel.com>; Intel GFX <intel-
> gfx@lists.freedesktop.org>; DRI Devel <dri-devel@lists.freedesktop.org>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>; stable@vger.kernel.org; Dan
> Carpenter <dan.carpenter@linaro.org>; Andi Shyti <andi.shyti@kernel.org>
> Subject: Re: [Intel-gfx] [PATCH] drm/i915/gt: Use the correct error value
> when kernel_context() fails
>
> On 26.05.2023 14:41, Andi Shyti wrote:
> > kernel_context() returns an error pointer. Use pointer-error
> > conversion functions to evaluate its return value, rather than
> > checking for a '0' return.
> >
> > Fixes: eb5c10cbbc2f ("drm/i915: Remove I915_USER_PRIORITY_SHIFT")
> > Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> > Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com>
> > Cc: Chris Wilson < chris@chris-wilson.co.uk>
> > Cc: <stable@vger.kernel.org> # v5.13+
>
> Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
>
> Regards
> Andrzej
>
> > ---
> > drivers/gpu/drm/i915/gt/selftest_execlists.c | 12 ++++++++----
> > 1 file changed, 8 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/gt/selftest_execlists.c
> > b/drivers/gpu/drm/i915/gt/selftest_execlists.c
> > index 736b89a8ecf54..4202df5b8c122 100644
> > --- a/drivers/gpu/drm/i915/gt/selftest_execlists.c
> > +++ b/drivers/gpu/drm/i915/gt/selftest_execlists.c
> > @@ -1530,8 +1530,8 @@ static int live_busywait_preempt(void *arg)
> > struct drm_i915_gem_object *obj;
> > struct i915_vma *vma;
> > enum intel_engine_id id;
> > - int err = -ENOMEM;
> > u32 *map;
> > + int err;
We could initialize err with 0 and remove err = 0 assignment below but leaving up to you.
> >
> > /*
> > * Verify that even without HAS_LOGICAL_RING_PREEMPTION, we
> can @@
> > -1539,13 +1539,17 @@ static int live_busywait_preempt(void *arg)
> > */
> >
> > ctx_hi = kernel_context(gt->i915, NULL);
> > - if (!ctx_hi)
> > - return -ENOMEM;
> > + if (IS_ERR(ctx_hi))
> > + return PTR_ERR(ctx_hi);
> > +
> > ctx_hi->sched.priority = I915_CONTEXT_MAX_USER_PRIORITY;
> >
> > ctx_lo = kernel_context(gt->i915, NULL);
> > - if (!ctx_lo)
> > + if (IS_ERR(ctx_lo)) {
> > + err = PTR_ERR(ctx_lo);
> > goto err_ctx_hi;
> > + }
> > +
Looks fine,
Acked-by: Tejas Upadhyay <tejas.upadhyay@intel.com>
> > ctx_lo->sched.priority = I915_CONTEXT_MIN_USER_PRIORITY;
> >
> > obj = i915_gem_object_create_internal(gt->i915, PAGE_SIZE);
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/gt: Use the correct error value when kernel_context() fails
2023-06-01 14:30 ` Upadhyay, Tejas
(?)
@ 2023-06-01 14:38 ` Andi Shyti
-1 siblings, 0 replies; 14+ messages in thread
From: Andi Shyti @ 2023-06-01 14:38 UTC (permalink / raw)
To: Upadhyay, Tejas
Cc: Hajda, Andrzej, Intel GFX, DRI Devel, Chris Wilson, stable,
Andi Shyti, Dan Carpenter, Andi Shyti
Hi Tejas,
> > > @@ -1530,8 +1530,8 @@ static int live_busywait_preempt(void *arg)
> > > struct drm_i915_gem_object *obj;
> > > struct i915_vma *vma;
> > > enum intel_engine_id id;
> > > - int err = -ENOMEM;
> > > u32 *map;
> > > + int err;
>
> We could initialize err with 0 and remove err = 0 assignment below but leaving up to you.
that assignement must be a leftover from previous patches because
err is already initialized here:
err = i915_vma_pin(vma, 0, 0, PIN_GLOBAL);
will remove it. Thanks!
> > >
> > > /*
> > > * Verify that even without HAS_LOGICAL_RING_PREEMPTION, we
> > can @@
> > > -1539,13 +1539,17 @@ static int live_busywait_preempt(void *arg)
> > > */
> > >
> > > ctx_hi = kernel_context(gt->i915, NULL);
> > > - if (!ctx_hi)
> > > - return -ENOMEM;
> > > + if (IS_ERR(ctx_hi))
> > > + return PTR_ERR(ctx_hi);
> > > +
> > > ctx_hi->sched.priority = I915_CONTEXT_MAX_USER_PRIORITY;
> > >
> > > ctx_lo = kernel_context(gt->i915, NULL);
> > > - if (!ctx_lo)
> > > + if (IS_ERR(ctx_lo)) {
> > > + err = PTR_ERR(ctx_lo);
> > > goto err_ctx_hi;
> > > + }
> > > +
>
> Looks fine,
> Acked-by: Tejas Upadhyay <tejas.upadhyay@intel.com>
Thank you!
Andi
>
> > > ctx_lo->sched.priority = I915_CONTEXT_MIN_USER_PRIORITY;
> > >
> > > obj = i915_gem_object_create_internal(gt->i915, PAGE_SIZE);
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/gt: Use the correct error value when kernel_context() fails
@ 2023-06-01 14:38 ` Andi Shyti
0 siblings, 0 replies; 14+ messages in thread
From: Andi Shyti @ 2023-06-01 14:38 UTC (permalink / raw)
To: Upadhyay, Tejas
Cc: Hajda, Andrzej, Intel GFX, DRI Devel, Chris Wilson, stable,
Dan Carpenter, Andi Shyti
Hi Tejas,
> > > @@ -1530,8 +1530,8 @@ static int live_busywait_preempt(void *arg)
> > > struct drm_i915_gem_object *obj;
> > > struct i915_vma *vma;
> > > enum intel_engine_id id;
> > > - int err = -ENOMEM;
> > > u32 *map;
> > > + int err;
>
> We could initialize err with 0 and remove err = 0 assignment below but leaving up to you.
that assignement must be a leftover from previous patches because
err is already initialized here:
err = i915_vma_pin(vma, 0, 0, PIN_GLOBAL);
will remove it. Thanks!
> > >
> > > /*
> > > * Verify that even without HAS_LOGICAL_RING_PREEMPTION, we
> > can @@
> > > -1539,13 +1539,17 @@ static int live_busywait_preempt(void *arg)
> > > */
> > >
> > > ctx_hi = kernel_context(gt->i915, NULL);
> > > - if (!ctx_hi)
> > > - return -ENOMEM;
> > > + if (IS_ERR(ctx_hi))
> > > + return PTR_ERR(ctx_hi);
> > > +
> > > ctx_hi->sched.priority = I915_CONTEXT_MAX_USER_PRIORITY;
> > >
> > > ctx_lo = kernel_context(gt->i915, NULL);
> > > - if (!ctx_lo)
> > > + if (IS_ERR(ctx_lo)) {
> > > + err = PTR_ERR(ctx_lo);
> > > goto err_ctx_hi;
> > > + }
> > > +
>
> Looks fine,
> Acked-by: Tejas Upadhyay <tejas.upadhyay@intel.com>
Thank you!
Andi
>
> > > ctx_lo->sched.priority = I915_CONTEXT_MIN_USER_PRIORITY;
> > >
> > > obj = i915_gem_object_create_internal(gt->i915, PAGE_SIZE);
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/gt: Use the correct error value when kernel_context() fails
@ 2023-06-01 14:38 ` Andi Shyti
0 siblings, 0 replies; 14+ messages in thread
From: Andi Shyti @ 2023-06-01 14:38 UTC (permalink / raw)
To: Upadhyay, Tejas
Cc: Hajda, Andrzej, Andi Shyti, Intel GFX, DRI Devel, Chris Wilson,
stable, Dan Carpenter, Andi Shyti
Hi Tejas,
> > > @@ -1530,8 +1530,8 @@ static int live_busywait_preempt(void *arg)
> > > struct drm_i915_gem_object *obj;
> > > struct i915_vma *vma;
> > > enum intel_engine_id id;
> > > - int err = -ENOMEM;
> > > u32 *map;
> > > + int err;
>
> We could initialize err with 0 and remove err = 0 assignment below but leaving up to you.
that assignement must be a leftover from previous patches because
err is already initialized here:
err = i915_vma_pin(vma, 0, 0, PIN_GLOBAL);
will remove it. Thanks!
> > >
> > > /*
> > > * Verify that even without HAS_LOGICAL_RING_PREEMPTION, we
> > can @@
> > > -1539,13 +1539,17 @@ static int live_busywait_preempt(void *arg)
> > > */
> > >
> > > ctx_hi = kernel_context(gt->i915, NULL);
> > > - if (!ctx_hi)
> > > - return -ENOMEM;
> > > + if (IS_ERR(ctx_hi))
> > > + return PTR_ERR(ctx_hi);
> > > +
> > > ctx_hi->sched.priority = I915_CONTEXT_MAX_USER_PRIORITY;
> > >
> > > ctx_lo = kernel_context(gt->i915, NULL);
> > > - if (!ctx_lo)
> > > + if (IS_ERR(ctx_lo)) {
> > > + err = PTR_ERR(ctx_lo);
> > > goto err_ctx_hi;
> > > + }
> > > +
>
> Looks fine,
> Acked-by: Tejas Upadhyay <tejas.upadhyay@intel.com>
Thank you!
Andi
>
> > > ctx_lo->sched.priority = I915_CONTEXT_MIN_USER_PRIORITY;
> > >
> > > obj = i915_gem_object_create_internal(gt->i915, PAGE_SIZE);
>
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2023-06-01 14:45 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-26 12:41 [PATCH] drm/i915/gt: Use the correct error value when kernel_context() fails Andi Shyti
2023-05-26 12:41 ` [Intel-gfx] " Andi Shyti
2023-05-26 12:41 ` Andi Shyti
2023-05-26 16:00 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2023-05-26 16:14 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-05-27 13:07 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2023-06-01 12:44 ` [Intel-gfx] [PATCH] " Andrzej Hajda
2023-06-01 12:44 ` Andrzej Hajda
2023-06-01 14:30 ` Upadhyay, Tejas
2023-06-01 14:30 ` Upadhyay, Tejas
2023-06-01 14:30 ` Upadhyay, Tejas
2023-06-01 14:38 ` Andi Shyti
2023-06-01 14:38 ` Andi Shyti
2023-06-01 14:38 ` Andi Shyti
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.