From: Leo Yan <leo.yan@linaro.org>
To: Tiezhu Yang <yangtiezhu@loongson.cn>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Hans-Peter Nilsson <hp@axis.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
loongarch@lists.linux.dev, loongson-kernel@lists.loongnix.cn
Subject: Re: [PATCH 2/2] perf LoongArch: Simplify mksyscalltbl
Date: Sat, 27 May 2023 09:55:20 +0800 [thread overview]
Message-ID: <20230527015520.GB188137@leoy-huanghe> (raw)
In-Reply-To: <1684837327-18203-3-git-send-email-yangtiezhu@loongson.cn>
On Tue, May 23, 2023 at 06:22:07PM +0800, Tiezhu Yang wrote:
> In order to print the numerical entries of the syscall table,
> there is no need to call the host compiler to build and then
> run a program, this can be done directly by the shell script.
>
> This is similar with commit 9854e7ad35fe ("perf arm64: Simplify
> mksyscalltbl").
>
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> ---
> .../arch/loongarch/entry/syscalls/mksyscalltbl | 32 ++++++----------------
> 1 file changed, 8 insertions(+), 24 deletions(-)
>
> diff --git a/tools/perf/arch/loongarch/entry/syscalls/mksyscalltbl b/tools/perf/arch/loongarch/entry/syscalls/mksyscalltbl
> index c52156f..d7d97d5 100755
> --- a/tools/perf/arch/loongarch/entry/syscalls/mksyscalltbl
> +++ b/tools/perf/arch/loongarch/entry/syscalls/mksyscalltbl
> @@ -22,40 +22,24 @@ create_table_from_c()
Nitpick: since this patch tries to remove the temporary C program and
simply use shell to generate syscall table, to avoid confusion, it's
good to update the function name from create_table_from_c() to
create_sc_table().
I know Arm64's mksyscalltbl has the same issue, we can use a separate
patch to address it.
Otherwise, this patch LGTM:
Reviewed-by: Leo Yan <leo.yan@linaro.org>
prev parent reply other threads:[~2023-05-27 1:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-23 10:22 [PATCH 0/2] perf tools: Modify mksyscalltbl Tiezhu Yang
2023-05-23 10:22 ` [PATCH 1/2] perf arm64: Handle __NR3264_ prefixed syscall number Tiezhu Yang
2023-05-23 12:31 ` Alexander Kapshuk
2023-05-24 3:19 ` Tiezhu Yang
2023-05-24 6:43 ` Alexander Kapshuk
2023-05-24 7:18 ` Tiezhu Yang
2023-05-27 1:43 ` Leo Yan
2023-05-23 10:22 ` [PATCH 2/2] perf LoongArch: Simplify mksyscalltbl Tiezhu Yang
2023-05-27 1:55 ` Leo Yan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230527015520.GB188137@leoy-huanghe \
--to=leo.yan@linaro.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=hp@axis.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=loongson-kernel@lists.loongnix.cn \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.