From: Leo Yan <leo.yan@linaro.org>
To: Tiezhu Yang <yangtiezhu@loongson.cn>
Cc: Alexander Kapshuk <alexander.kapshuk@gmail.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Hans-Peter Nilsson <hp@axis.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
loongarch@lists.linux.dev, loongson-kernel@lists.loongnix.cn
Subject: Re: [PATCH 1/2] perf arm64: Handle __NR3264_ prefixed syscall number
Date: Sat, 27 May 2023 09:43:55 +0800 [thread overview]
Message-ID: <CALZQ+UN0y29mJUypfSUHCLkMHzBVQTVU0i95MtHG3U+VzS+5Og@mail.gmail.com> (raw)
In-Reply-To: <2932e212-ba17-090b-761b-b18e8f9c33e8@loongson.cn>
On Wed, May 24, 2023 at 03:18:28PM +0800, Tiezhu Yang wrote:
> On 05/24/2023 02:43 PM, Alexander Kapshuk wrote:
[...]
> Yes, there are only 2 patterns such as "__NR_" and "__NR3264_",
> I confirmed that in include/uapi/asm-generic/unistd.h.
>
> > routines, they may be combined into a single sub routine like so:
> > awk '$2 ~ "__NR" && $3 !~ "__NR3264_" {
> > sub("^#define __NR(3264)?_", "")
> > print | "sort -k2 -n"
> > }'
Thanks for improving this, Tiezhu and Alexander.
The format between '[46]' and '[__NR3264_ftruncate]' has changed back
and forth for several times due to various reasons ;)
Above change is a good improvement for me and I tested at my side
with below commands:
$ aarch64-linux-gnu-gcc -E -dM -x c -I tools/include/uapi/ \
tools/include/uapi/asm-generic/unistd.h \
| awk '$2 ~ "__NR" && $3 !~ "__NR3264_" { sub("^#define
__NR(3264)?_", ""); print | "sort -k2 -n"}'
The result looks good to me. You are welcome to add my review tag:
Reviewed-by: Leo Yan <leo.yan@linaro.org>
next prev parent reply other threads:[~2023-05-27 1:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-23 10:22 [PATCH 0/2] perf tools: Modify mksyscalltbl Tiezhu Yang
2023-05-23 10:22 ` [PATCH 1/2] perf arm64: Handle __NR3264_ prefixed syscall number Tiezhu Yang
2023-05-23 12:31 ` Alexander Kapshuk
2023-05-24 3:19 ` Tiezhu Yang
2023-05-24 6:43 ` Alexander Kapshuk
2023-05-24 7:18 ` Tiezhu Yang
2023-05-27 1:43 ` Leo Yan [this message]
2023-05-23 10:22 ` [PATCH 2/2] perf LoongArch: Simplify mksyscalltbl Tiezhu Yang
2023-05-27 1:55 ` Leo Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALZQ+UN0y29mJUypfSUHCLkMHzBVQTVU0i95MtHG3U+VzS+5Og@mail.gmail.com \
--to=leo.yan@linaro.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.kapshuk@gmail.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=hp@axis.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=loongson-kernel@lists.loongnix.cn \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.