* [PATCH v2 1/1] ARM: dts: imx6qdl-mba6: add mac address for USB ethernet controller
@ 2023-05-15 5:44 Alexander Stein
2023-05-27 8:15 ` Shawn Guo
2023-06-04 12:03 ` Shawn Guo
0 siblings, 2 replies; 7+ messages in thread
From: Alexander Stein @ 2023-05-15 5:44 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Shawn Guo, Sascha Hauer,
Fabio Estevam, Markus Niebel, Matthias Schiffer
Cc: Alexander Stein, Pengutronix Kernel Team, NXP Linux Team,
devicetree, linux-arm-kernel
The mac address is stored in mainboard eeprom.
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
Changes in v2:
* Fix indentation
arch/arm/boot/dts/imx6qdl-mba6.dtsi | 16 ++++++++++++++++
arch/arm/boot/dts/imx6qdl-mba6a.dtsi | 6 ++++++
arch/arm/boot/dts/imx6qdl-mba6b.dtsi | 6 ++++++
3 files changed, 28 insertions(+)
diff --git a/arch/arm/boot/dts/imx6qdl-mba6.dtsi b/arch/arm/boot/dts/imx6qdl-mba6.dtsi
index 7b7e6c2ad190..9d90d7647024 100644
--- a/arch/arm/boot/dts/imx6qdl-mba6.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-mba6.dtsi
@@ -272,6 +272,22 @@ &uart5 {
&usbh1 {
disable-over-current;
status = "okay";
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ hub@1 {
+ compatible = "usb424,2517";
+ reg = <1>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ ethernet@1 {
+ compatible = "usb424,9e00";
+ reg = <1>;
+ nvmem-cells = <&mba_mac_address>;
+ nvmem-cell-names = "mac-address";
+ };
+ };
};
&usbotg {
diff --git a/arch/arm/boot/dts/imx6qdl-mba6a.dtsi b/arch/arm/boot/dts/imx6qdl-mba6a.dtsi
index df8fa169e9f6..27fec340c380 100644
--- a/arch/arm/boot/dts/imx6qdl-mba6a.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-mba6a.dtsi
@@ -21,6 +21,12 @@ m24c64_57: eeprom@57 {
compatible = "atmel,24c64";
reg = <0x57>;
pagesize = <32>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+
+ mba_mac_address: mac-address@20 {
+ reg = <0x20 0x6>;
+ };
};
rtc0: rtc@68 {
diff --git a/arch/arm/boot/dts/imx6qdl-mba6b.dtsi b/arch/arm/boot/dts/imx6qdl-mba6b.dtsi
index 7d1cd7454c7f..0a9f076eeb36 100644
--- a/arch/arm/boot/dts/imx6qdl-mba6b.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-mba6b.dtsi
@@ -31,6 +31,12 @@ m24c64_57: eeprom@57 {
compatible = "atmel,24c64";
reg = <0x57>;
pagesize = <32>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+
+ mba_mac_address: mac-address@20 {
+ reg = <0x20 0x6>;
+ };
};
rtc0: rtc@68 {
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v2 1/1] ARM: dts: imx6qdl-mba6: add mac address for USB ethernet controller
2023-05-15 5:44 [PATCH v2 1/1] ARM: dts: imx6qdl-mba6: add mac address for USB ethernet controller Alexander Stein
@ 2023-05-27 8:15 ` Shawn Guo
2023-06-04 12:03 ` Shawn Guo
1 sibling, 0 replies; 7+ messages in thread
From: Shawn Guo @ 2023-05-27 8:15 UTC (permalink / raw)
To: Alexander Stein
Cc: Rob Herring, Krzysztof Kozlowski, Sascha Hauer, Fabio Estevam,
Markus Niebel, Matthias Schiffer, Pengutronix Kernel Team,
NXP Linux Team, devicetree, linux-arm-kernel
On Mon, May 15, 2023 at 07:44:29AM +0200, Alexander Stein wrote:
> The mac address is stored in mainboard eeprom.
>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> Changes in v2:
> * Fix indentation
>
> arch/arm/boot/dts/imx6qdl-mba6.dtsi | 16 ++++++++++++++++
> arch/arm/boot/dts/imx6qdl-mba6a.dtsi | 6 ++++++
> arch/arm/boot/dts/imx6qdl-mba6b.dtsi | 6 ++++++
> 3 files changed, 28 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx6qdl-mba6.dtsi b/arch/arm/boot/dts/imx6qdl-mba6.dtsi
> index 7b7e6c2ad190..9d90d7647024 100644
> --- a/arch/arm/boot/dts/imx6qdl-mba6.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-mba6.dtsi
> @@ -272,6 +272,22 @@ &uart5 {
> &usbh1 {
> disable-over-current;
> status = "okay";
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + hub@1 {
> + compatible = "usb424,2517";
> + reg = <1>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + ethernet@1 {
> + compatible = "usb424,9e00";
These two usb424 compatible strings are undocumented?
Shawn
> + reg = <1>;
> + nvmem-cells = <&mba_mac_address>;
> + nvmem-cell-names = "mac-address";
> + };
> + };
> };
>
> &usbotg {
> diff --git a/arch/arm/boot/dts/imx6qdl-mba6a.dtsi b/arch/arm/boot/dts/imx6qdl-mba6a.dtsi
> index df8fa169e9f6..27fec340c380 100644
> --- a/arch/arm/boot/dts/imx6qdl-mba6a.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-mba6a.dtsi
> @@ -21,6 +21,12 @@ m24c64_57: eeprom@57 {
> compatible = "atmel,24c64";
> reg = <0x57>;
> pagesize = <32>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> +
> + mba_mac_address: mac-address@20 {
> + reg = <0x20 0x6>;
> + };
> };
>
> rtc0: rtc@68 {
> diff --git a/arch/arm/boot/dts/imx6qdl-mba6b.dtsi b/arch/arm/boot/dts/imx6qdl-mba6b.dtsi
> index 7d1cd7454c7f..0a9f076eeb36 100644
> --- a/arch/arm/boot/dts/imx6qdl-mba6b.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-mba6b.dtsi
> @@ -31,6 +31,12 @@ m24c64_57: eeprom@57 {
> compatible = "atmel,24c64";
> reg = <0x57>;
> pagesize = <32>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> +
> + mba_mac_address: mac-address@20 {
> + reg = <0x20 0x6>;
> + };
> };
>
> rtc0: rtc@68 {
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 1/1] ARM: dts: imx6qdl-mba6: add mac address for USB ethernet controller
@ 2023-05-27 8:15 ` Shawn Guo
0 siblings, 0 replies; 7+ messages in thread
From: Shawn Guo @ 2023-05-27 8:15 UTC (permalink / raw)
To: Alexander Stein
Cc: Rob Herring, Krzysztof Kozlowski, Sascha Hauer, Fabio Estevam,
Markus Niebel, Matthias Schiffer, Pengutronix Kernel Team,
NXP Linux Team, devicetree, linux-arm-kernel
On Mon, May 15, 2023 at 07:44:29AM +0200, Alexander Stein wrote:
> The mac address is stored in mainboard eeprom.
>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> Changes in v2:
> * Fix indentation
>
> arch/arm/boot/dts/imx6qdl-mba6.dtsi | 16 ++++++++++++++++
> arch/arm/boot/dts/imx6qdl-mba6a.dtsi | 6 ++++++
> arch/arm/boot/dts/imx6qdl-mba6b.dtsi | 6 ++++++
> 3 files changed, 28 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx6qdl-mba6.dtsi b/arch/arm/boot/dts/imx6qdl-mba6.dtsi
> index 7b7e6c2ad190..9d90d7647024 100644
> --- a/arch/arm/boot/dts/imx6qdl-mba6.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-mba6.dtsi
> @@ -272,6 +272,22 @@ &uart5 {
> &usbh1 {
> disable-over-current;
> status = "okay";
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + hub@1 {
> + compatible = "usb424,2517";
> + reg = <1>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + ethernet@1 {
> + compatible = "usb424,9e00";
These two usb424 compatible strings are undocumented?
Shawn
> + reg = <1>;
> + nvmem-cells = <&mba_mac_address>;
> + nvmem-cell-names = "mac-address";
> + };
> + };
> };
>
> &usbotg {
> diff --git a/arch/arm/boot/dts/imx6qdl-mba6a.dtsi b/arch/arm/boot/dts/imx6qdl-mba6a.dtsi
> index df8fa169e9f6..27fec340c380 100644
> --- a/arch/arm/boot/dts/imx6qdl-mba6a.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-mba6a.dtsi
> @@ -21,6 +21,12 @@ m24c64_57: eeprom@57 {
> compatible = "atmel,24c64";
> reg = <0x57>;
> pagesize = <32>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> +
> + mba_mac_address: mac-address@20 {
> + reg = <0x20 0x6>;
> + };
> };
>
> rtc0: rtc@68 {
> diff --git a/arch/arm/boot/dts/imx6qdl-mba6b.dtsi b/arch/arm/boot/dts/imx6qdl-mba6b.dtsi
> index 7d1cd7454c7f..0a9f076eeb36 100644
> --- a/arch/arm/boot/dts/imx6qdl-mba6b.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-mba6b.dtsi
> @@ -31,6 +31,12 @@ m24c64_57: eeprom@57 {
> compatible = "atmel,24c64";
> reg = <0x57>;
> pagesize = <32>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> +
> + mba_mac_address: mac-address@20 {
> + reg = <0x20 0x6>;
> + };
> };
>
> rtc0: rtc@68 {
> --
> 2.34.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 1/1] ARM: dts: imx6qdl-mba6: add mac address for USB ethernet controller
2023-05-27 8:15 ` Shawn Guo
@ 2023-05-30 6:02 ` Alexander Stein
-1 siblings, 0 replies; 7+ messages in thread
From: Alexander Stein @ 2023-05-30 6:02 UTC (permalink / raw)
To: Shawn Guo
Cc: Rob Herring, Krzysztof Kozlowski, Sascha Hauer, Fabio Estevam,
Markus Niebel, Matthias Schiffer, Pengutronix Kernel Team,
NXP Linux Team, devicetree, linux-arm-kernel
Hi Shawn,
Am Samstag, 27. Mai 2023, 10:15:59 CEST schrieb Shawn Guo:
> On Mon, May 15, 2023 at 07:44:29AM +0200, Alexander Stein wrote:
> > The mac address is stored in mainboard eeprom.
> >
> > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> > ---
> > Changes in v2:
> > * Fix indentation
> >
> > arch/arm/boot/dts/imx6qdl-mba6.dtsi | 16 ++++++++++++++++
> > arch/arm/boot/dts/imx6qdl-mba6a.dtsi | 6 ++++++
> > arch/arm/boot/dts/imx6qdl-mba6b.dtsi | 6 ++++++
> > 3 files changed, 28 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/imx6qdl-mba6.dtsi
> > b/arch/arm/boot/dts/imx6qdl-mba6.dtsi index 7b7e6c2ad190..9d90d7647024
> > 100644
> > --- a/arch/arm/boot/dts/imx6qdl-mba6.dtsi
> > +++ b/arch/arm/boot/dts/imx6qdl-mba6.dtsi
> > @@ -272,6 +272,22 @@ &uart5 {
> >
> > &usbh1 {
> >
> > disable-over-current;
> > status = "okay";
> >
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + hub@1 {
> > + compatible = "usb424,2517";
> > + reg = <1>;
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + ethernet@1 {
> > + compatible = "usb424,9e00";
>
> These two usb424 compatible strings are undocumented?
Well, there are bindings in Documentation/devicetree/bindings/usb/usb-
device.yaml. But (all) the VID/PID are not listed explicitly.
Best regards,
Alexander
> Shawn
>
> > + reg = <1>;
> > + nvmem-cells = <&mba_mac_address>;
> > + nvmem-cell-names = "mac-address";
> > + };
> > + };
> >
> > };
> >
> > &usbotg {
> >
> > diff --git a/arch/arm/boot/dts/imx6qdl-mba6a.dtsi
> > b/arch/arm/boot/dts/imx6qdl-mba6a.dtsi index df8fa169e9f6..27fec340c380
> > 100644
> > --- a/arch/arm/boot/dts/imx6qdl-mba6a.dtsi
> > +++ b/arch/arm/boot/dts/imx6qdl-mba6a.dtsi
> > @@ -21,6 +21,12 @@ m24c64_57: eeprom@57 {
> >
> > compatible = "atmel,24c64";
> > reg = <0x57>;
> > pagesize = <32>;
> >
> > + #address-cells = <1>;
> > + #size-cells = <1>;
> > +
> > + mba_mac_address: mac-address@20 {
> > + reg = <0x20 0x6>;
> > + };
> >
> > };
> >
> > rtc0: rtc@68 {
> >
> > diff --git a/arch/arm/boot/dts/imx6qdl-mba6b.dtsi
> > b/arch/arm/boot/dts/imx6qdl-mba6b.dtsi index 7d1cd7454c7f..0a9f076eeb36
> > 100644
> > --- a/arch/arm/boot/dts/imx6qdl-mba6b.dtsi
> > +++ b/arch/arm/boot/dts/imx6qdl-mba6b.dtsi
> > @@ -31,6 +31,12 @@ m24c64_57: eeprom@57 {
> >
> > compatible = "atmel,24c64";
> > reg = <0x57>;
> > pagesize = <32>;
> >
> > + #address-cells = <1>;
> > + #size-cells = <1>;
> > +
> > + mba_mac_address: mac-address@20 {
> > + reg = <0x20 0x6>;
> > + };
> >
> > };
> >
> > rtc0: rtc@68 {
--
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 1/1] ARM: dts: imx6qdl-mba6: add mac address for USB ethernet controller
@ 2023-05-30 6:02 ` Alexander Stein
0 siblings, 0 replies; 7+ messages in thread
From: Alexander Stein @ 2023-05-30 6:02 UTC (permalink / raw)
To: Shawn Guo
Cc: Rob Herring, Krzysztof Kozlowski, Sascha Hauer, Fabio Estevam,
Markus Niebel, Matthias Schiffer, Pengutronix Kernel Team,
NXP Linux Team, devicetree, linux-arm-kernel
Hi Shawn,
Am Samstag, 27. Mai 2023, 10:15:59 CEST schrieb Shawn Guo:
> On Mon, May 15, 2023 at 07:44:29AM +0200, Alexander Stein wrote:
> > The mac address is stored in mainboard eeprom.
> >
> > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> > ---
> > Changes in v2:
> > * Fix indentation
> >
> > arch/arm/boot/dts/imx6qdl-mba6.dtsi | 16 ++++++++++++++++
> > arch/arm/boot/dts/imx6qdl-mba6a.dtsi | 6 ++++++
> > arch/arm/boot/dts/imx6qdl-mba6b.dtsi | 6 ++++++
> > 3 files changed, 28 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/imx6qdl-mba6.dtsi
> > b/arch/arm/boot/dts/imx6qdl-mba6.dtsi index 7b7e6c2ad190..9d90d7647024
> > 100644
> > --- a/arch/arm/boot/dts/imx6qdl-mba6.dtsi
> > +++ b/arch/arm/boot/dts/imx6qdl-mba6.dtsi
> > @@ -272,6 +272,22 @@ &uart5 {
> >
> > &usbh1 {
> >
> > disable-over-current;
> > status = "okay";
> >
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + hub@1 {
> > + compatible = "usb424,2517";
> > + reg = <1>;
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + ethernet@1 {
> > + compatible = "usb424,9e00";
>
> These two usb424 compatible strings are undocumented?
Well, there are bindings in Documentation/devicetree/bindings/usb/usb-
device.yaml. But (all) the VID/PID are not listed explicitly.
Best regards,
Alexander
> Shawn
>
> > + reg = <1>;
> > + nvmem-cells = <&mba_mac_address>;
> > + nvmem-cell-names = "mac-address";
> > + };
> > + };
> >
> > };
> >
> > &usbotg {
> >
> > diff --git a/arch/arm/boot/dts/imx6qdl-mba6a.dtsi
> > b/arch/arm/boot/dts/imx6qdl-mba6a.dtsi index df8fa169e9f6..27fec340c380
> > 100644
> > --- a/arch/arm/boot/dts/imx6qdl-mba6a.dtsi
> > +++ b/arch/arm/boot/dts/imx6qdl-mba6a.dtsi
> > @@ -21,6 +21,12 @@ m24c64_57: eeprom@57 {
> >
> > compatible = "atmel,24c64";
> > reg = <0x57>;
> > pagesize = <32>;
> >
> > + #address-cells = <1>;
> > + #size-cells = <1>;
> > +
> > + mba_mac_address: mac-address@20 {
> > + reg = <0x20 0x6>;
> > + };
> >
> > };
> >
> > rtc0: rtc@68 {
> >
> > diff --git a/arch/arm/boot/dts/imx6qdl-mba6b.dtsi
> > b/arch/arm/boot/dts/imx6qdl-mba6b.dtsi index 7d1cd7454c7f..0a9f076eeb36
> > 100644
> > --- a/arch/arm/boot/dts/imx6qdl-mba6b.dtsi
> > +++ b/arch/arm/boot/dts/imx6qdl-mba6b.dtsi
> > @@ -31,6 +31,12 @@ m24c64_57: eeprom@57 {
> >
> > compatible = "atmel,24c64";
> > reg = <0x57>;
> > pagesize = <32>;
> >
> > + #address-cells = <1>;
> > + #size-cells = <1>;
> > +
> > + mba_mac_address: mac-address@20 {
> > + reg = <0x20 0x6>;
> > + };
> >
> > };
> >
> > rtc0: rtc@68 {
--
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 1/1] ARM: dts: imx6qdl-mba6: add mac address for USB ethernet controller
2023-05-15 5:44 [PATCH v2 1/1] ARM: dts: imx6qdl-mba6: add mac address for USB ethernet controller Alexander Stein
@ 2023-06-04 12:03 ` Shawn Guo
2023-06-04 12:03 ` Shawn Guo
1 sibling, 0 replies; 7+ messages in thread
From: Shawn Guo @ 2023-06-04 12:03 UTC (permalink / raw)
To: Alexander Stein
Cc: Rob Herring, Krzysztof Kozlowski, Sascha Hauer, Fabio Estevam,
Markus Niebel, Matthias Schiffer, Pengutronix Kernel Team,
NXP Linux Team, devicetree, linux-arm-kernel
On Mon, May 15, 2023 at 07:44:29AM +0200, Alexander Stein wrote:
> The mac address is stored in mainboard eeprom.
>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
Applied, thanks!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 1/1] ARM: dts: imx6qdl-mba6: add mac address for USB ethernet controller
@ 2023-06-04 12:03 ` Shawn Guo
0 siblings, 0 replies; 7+ messages in thread
From: Shawn Guo @ 2023-06-04 12:03 UTC (permalink / raw)
To: Alexander Stein
Cc: Rob Herring, Krzysztof Kozlowski, Sascha Hauer, Fabio Estevam,
Markus Niebel, Matthias Schiffer, Pengutronix Kernel Team,
NXP Linux Team, devicetree, linux-arm-kernel
On Mon, May 15, 2023 at 07:44:29AM +0200, Alexander Stein wrote:
> The mac address is stored in mainboard eeprom.
>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
Applied, thanks!
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-06-04 12:03 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-15 5:44 [PATCH v2 1/1] ARM: dts: imx6qdl-mba6: add mac address for USB ethernet controller Alexander Stein
2023-05-27 8:15 ` Shawn Guo
2023-05-27 8:15 ` Shawn Guo
2023-05-30 6:02 ` Alexander Stein
2023-05-30 6:02 ` Alexander Stein
2023-06-04 12:03 ` Shawn Guo
2023-06-04 12:03 ` Shawn Guo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.