* [igt-dev] [PATCH i-g-t v2] tests/kms_rotation_crc: enable and optimize test for sim
@ 2023-05-29 12:11 Swati Sharma
2023-05-30 13:33 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_rotation_crc: enable and optimize test for sim (rev2) Patchwork
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Swati Sharma @ 2023-05-29 12:11 UTC (permalink / raw)
To: igt-dev
To reduce execution time in simulation dropping RGB565 and PO10
formats (coverage is not compromised, we do have NV12 and RGB888
formats being validated).
Also, skipping buffered CRC reusecrcfromlastround() in simulation.
v2: -Add checks inside multiplaneskiproundcheck() and
reusecrcfromlastround() (JP)
Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
---
tests/kms_rotation_crc.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c
index 28b4fd27..0a22cc22 100644
--- a/tests/kms_rotation_crc.c
+++ b/tests/kms_rotation_crc.c
@@ -719,6 +719,16 @@ static bool multiplaneskiproundcheck(data_t *data, planeinfos p[2])
if (!igt_plane_has_rotation(p[1].plane, p[1].fbinfo->rotation))
return false;
+ if (igt_run_in_simulation() &&
+ (multiplaneformatlist[p[0].formatindex] == DRM_FORMAT_P010 ||
+ multiplaneformatlist[p[0].formatindex] == DRM_FORMAT_RGB565))
+ return false;
+
+ if (igt_run_in_simulation() &&
+ (multiplaneformatlist[p[1].formatindex] == DRM_FORMAT_P010 ||
+ multiplaneformatlist[p[1].formatindex] == DRM_FORMAT_RGB565))
+ return false;
+
return true;
}
@@ -765,6 +775,9 @@ static bool reusecrcfromlastround(planeinfos p[2], int lastroundp1format,
int lastroundp0rotation,
int lastroundp1rotation)
{
+ if (igt_run_in_simulation())
+ return false;
+
if (planarcheck != 1)
return false;
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_rotation_crc: enable and optimize test for sim (rev2)
2023-05-29 12:11 [igt-dev] [PATCH i-g-t v2] tests/kms_rotation_crc: enable and optimize test for sim Swati Sharma
@ 2023-05-30 13:33 ` Patchwork
2023-05-31 3:47 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2023-05-31 8:10 ` [igt-dev] [PATCH i-g-t v2] tests/kms_rotation_crc: enable and optimize test for sim Juha-Pekka Heikkila
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2023-05-30 13:33 UTC (permalink / raw)
To: Swati Sharma; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 5455 bytes --]
== Series Details ==
Series: tests/kms_rotation_crc: enable and optimize test for sim (rev2)
URL : https://patchwork.freedesktop.org/series/118363/
State : success
== Summary ==
CI Bug Log - changes from IGT_7310 -> IGTPW_9060
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9060/index.html
Participating hosts (38 -> 37)
------------------------------
Missing (1): fi-kbl-8809g
New tests
---------
New tests have been introduced between IGT_7310 and IGTPW_9060:
### New IGT tests (6) ###
* igt@gem_exec_basic@basic@bcs0-smem:
- Statuses : 34 pass(s)
- Exec time: [0.0] s
* igt@gem_exec_basic@basic@rcs0-smem:
- Statuses : 36 pass(s)
- Exec time: [0.0] s
* igt@gem_exec_basic@basic@vcs0-smem:
- Statuses : 35 pass(s)
- Exec time: [0.0] s
* igt@gem_exec_basic@basic@vcs1-smem:
- Statuses : 16 pass(s)
- Exec time: [0.0] s
* igt@gem_exec_basic@basic@vecs0-smem:
- Statuses : 34 pass(s)
- Exec time: [0.0] s
* igt@i915_pciid:
- Statuses : 36 pass(s)
- Exec time: [0.0] s
Known issues
------------
Here are the changes found in IGTPW_9060 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live@gt_heartbeat:
- fi-kbl-soraka: [PASS][1] -> [DMESG-FAIL][2] ([i915#5334] / [i915#7872])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7310/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9060/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html
* igt@i915_selftest@live@migrate:
- bat-dg2-11: [PASS][3] -> [DMESG-WARN][4] ([i915#7699])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7310/bat-dg2-11/igt@i915_selftest@live@migrate.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9060/bat-dg2-11/igt@i915_selftest@live@migrate.html
* igt@i915_selftest@live@slpc:
- bat-rpls-2: NOTRUN -> [DMESG-WARN][5] ([i915#6367])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9060/bat-rpls-2/igt@i915_selftest@live@slpc.html
- bat-rpls-1: [PASS][6] -> [DMESG-WARN][7] ([i915#6367])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7310/bat-rpls-1/igt@i915_selftest@live@slpc.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9060/bat-rpls-1/igt@i915_selftest@live@slpc.html
* igt@kms_pipe_crc_basic@read-crc:
- bat-adlp-9: NOTRUN -> [SKIP][8] ([i915#3546]) +1 similar issue
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9060/bat-adlp-9/igt@kms_pipe_crc_basic@read-crc.html
#### Possible fixes ####
* igt@core_hotunplug@unbind-rebind:
- {bat-mtlp-6}: [ABORT][9] -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7310/bat-mtlp-6/igt@core_hotunplug@unbind-rebind.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9060/bat-mtlp-6/igt@core_hotunplug@unbind-rebind.html
* igt@i915_selftest@live@mman:
- bat-rpls-2: [TIMEOUT][11] ([i915#6794] / [i915#7392]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7310/bat-rpls-2/igt@i915_selftest@live@mman.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9060/bat-rpls-2/igt@i915_selftest@live@mman.html
#### Warnings ####
* igt@kms_psr@sprite_plane_onoff:
- bat-rplp-1: [SKIP][13] ([i915#1072]) -> [ABORT][14] ([i915#8442])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7310/bat-rplp-1/igt@kms_psr@sprite_plane_onoff.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9060/bat-rplp-1/igt@kms_psr@sprite_plane_onoff.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6645]: https://gitlab.freedesktop.org/drm/intel/issues/6645
[i915#6794]: https://gitlab.freedesktop.org/drm/intel/issues/6794
[i915#7059]: https://gitlab.freedesktop.org/drm/intel/issues/7059
[i915#7392]: https://gitlab.freedesktop.org/drm/intel/issues/7392
[i915#7699]: https://gitlab.freedesktop.org/drm/intel/issues/7699
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7872]: https://gitlab.freedesktop.org/drm/intel/issues/7872
[i915#8442]: https://gitlab.freedesktop.org/drm/intel/issues/8442
[i915#8497]: https://gitlab.freedesktop.org/drm/intel/issues/8497
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7310 -> IGTPW_9060
CI-20190529: 20190529
CI_DRM_13200: 0ae4ee2c735979030a0219218081eee661606921 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_9060: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9060/index.html
IGT_7310: 2f9acfea5e3a93303f71cbda6e80ba64b8d75a4d @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9060/index.html
[-- Attachment #2: Type: text/html, Size: 6023 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for tests/kms_rotation_crc: enable and optimize test for sim (rev2)
2023-05-29 12:11 [igt-dev] [PATCH i-g-t v2] tests/kms_rotation_crc: enable and optimize test for sim Swati Sharma
2023-05-30 13:33 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_rotation_crc: enable and optimize test for sim (rev2) Patchwork
@ 2023-05-31 3:47 ` Patchwork
2023-05-31 8:10 ` [igt-dev] [PATCH i-g-t v2] tests/kms_rotation_crc: enable and optimize test for sim Juha-Pekka Heikkila
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2023-05-31 3:47 UTC (permalink / raw)
To: Sharma, Swati2; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 15662 bytes --]
== Series Details ==
Series: tests/kms_rotation_crc: enable and optimize test for sim (rev2)
URL : https://patchwork.freedesktop.org/series/118363/
State : success
== Summary ==
CI Bug Log - changes from IGT_7310_full -> IGTPW_9060_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9060/index.html
Participating hosts (7 -> 7)
------------------------------
No changes in participating hosts
New tests
---------
New tests have been introduced between IGT_7310_full and IGTPW_9060_full:
### New IGT tests (3) ###
* igt@kms_plane_scaling@plane-scaler-with-rotation-unity-scaling@pipe-a-hdmi-a-2:
- Statuses : 1 skip(s)
- Exec time: [0.0] s
* igt@kms_plane_scaling@plane-upscale-with-modifiers-20x20@pipe-a-hdmi-a-2:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@kms_plane_scaling@plane-upscale-with-rotation-factor-0-25@pipe-a-hdmi-a-2:
- Statuses : 1 skip(s)
- Exec time: [0.0] s
Known issues
------------
Here are the changes found in IGTPW_9060_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_fair@basic-deadline:
- shard-glk: [PASS][1] -> [FAIL][2] ([i915#2846])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7310/shard-glk8/igt@gem_exec_fair@basic-deadline.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9060/shard-glk3/igt@gem_exec_fair@basic-deadline.html
* igt@gen9_exec_parse@allowed-single:
- shard-glk: [PASS][3] -> [ABORT][4] ([i915#5566])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7310/shard-glk9/igt@gen9_exec_parse@allowed-single.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9060/shard-glk4/igt@gen9_exec_parse@allowed-single.html
* igt@i915_pm_rpm@system-suspend-modeset:
- shard-apl: [PASS][5] -> [ABORT][6] ([i915#8424])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7310/shard-apl1/igt@i915_pm_rpm@system-suspend-modeset.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9060/shard-apl7/igt@i915_pm_rpm@system-suspend-modeset.html
* igt@kms_cursor_crc@cursor-suspend@pipe-c-dp-1:
- shard-apl: [PASS][7] -> [ABORT][8] ([i915#180]) +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7310/shard-apl7/igt@kms_cursor_crc@cursor-suspend@pipe-c-dp-1.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9060/shard-apl3/igt@kms_cursor_crc@cursor-suspend@pipe-c-dp-1.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-apl: [PASS][9] -> [FAIL][10] ([IGT#6] / [i915#2346])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7310/shard-apl6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9060/shard-apl4/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-rotation@pipe-a-vga-1:
- shard-snb: NOTRUN -> [SKIP][11] ([fdo#109271]) +16 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9060/shard-snb6/igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-rotation@pipe-a-vga-1.html
* igt@kms_plane_scaling@plane-upscale-with-rotation-factor-0-25@pipe-a-hdmi-a-2 (NEW):
- {shard-rkl}: NOTRUN -> [SKIP][12] ([i915#5176]) +1 similar issue
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9060/shard-rkl-6/igt@kms_plane_scaling@plane-upscale-with-rotation-factor-0-25@pipe-a-hdmi-a-2.html
* igt@kms_plane_scaling@planes-downscale-factor-0-25@pipe-b-vga-1:
- shard-snb: NOTRUN -> [SKIP][13] ([fdo#109271] / [i915#4579]) +12 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9060/shard-snb5/igt@kms_plane_scaling@planes-downscale-factor-0-25@pipe-b-vga-1.html
#### Possible fixes ####
* igt@gem_barrier_race@remote-request@rcs0:
- {shard-tglu}: [ABORT][14] ([i915#8211] / [i915#8234]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7310/shard-tglu-10/igt@gem_barrier_race@remote-request@rcs0.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9060/shard-tglu-4/igt@gem_barrier_race@remote-request@rcs0.html
* igt@gem_ctx_exec@basic-nohangcheck:
- {shard-tglu}: [FAIL][16] ([i915#6268]) -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7310/shard-tglu-9/igt@gem_ctx_exec@basic-nohangcheck.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9060/shard-tglu-4/igt@gem_ctx_exec@basic-nohangcheck.html
* igt@gem_eio@kms:
- {shard-dg1}: [FAIL][18] ([i915#5784]) -> [PASS][19]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7310/shard-dg1-15/igt@gem_eio@kms.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9060/shard-dg1-14/igt@gem_eio@kms.html
* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-apl: [FAIL][20] ([i915#2842]) -> [PASS][21]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7310/shard-apl7/igt@gem_exec_fair@basic-none-solo@rcs0.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9060/shard-apl6/igt@gem_exec_fair@basic-none-solo@rcs0.html
* igt@gem_exec_fair@basic-none@bcs0:
- {shard-rkl}: [FAIL][22] ([i915#2842]) -> [PASS][23] +1 similar issue
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7310/shard-rkl-6/igt@gem_exec_fair@basic-none@bcs0.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9060/shard-rkl-4/igt@gem_exec_fair@basic-none@bcs0.html
* igt@i915_pm_dc@dc9-dpms:
- shard-apl: [SKIP][24] ([fdo#109271]) -> [PASS][25]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7310/shard-apl6/igt@i915_pm_dc@dc9-dpms.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9060/shard-apl6/igt@i915_pm_dc@dc9-dpms.html
* igt@i915_pm_rc6_residency@rc6-fence:
- {shard-tglu}: [WARN][26] ([i915#2681]) -> [PASS][27]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7310/shard-tglu-7/igt@i915_pm_rc6_residency@rc6-fence.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9060/shard-tglu-4/igt@i915_pm_rc6_residency@rc6-fence.html
* igt@i915_pm_rc6_residency@rc6-idle@vcs0:
- {shard-dg1}: [FAIL][28] ([i915#3591]) -> [PASS][29] +1 similar issue
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7310/shard-dg1-14/igt@i915_pm_rc6_residency@rc6-idle@vcs0.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9060/shard-dg1-14/igt@i915_pm_rc6_residency@rc6-idle@vcs0.html
* igt@i915_pm_rpm@modeset-lpsp-stress-no-wait:
- {shard-rkl}: [SKIP][30] ([i915#1397]) -> [PASS][31]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7310/shard-rkl-2/igt@i915_pm_rpm@modeset-lpsp-stress-no-wait.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9060/shard-rkl-7/igt@i915_pm_rpm@modeset-lpsp-stress-no-wait.html
* igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip:
- {shard-rkl}: [FAIL][32] ([i915#3743]) -> [PASS][33] +1 similar issue
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7310/shard-rkl-7/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9060/shard-rkl-6/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip.html
* igt@perf_pmu@busy-double-start@vecs0:
- {shard-dg1}: [FAIL][34] ([i915#4349]) -> [PASS][35] +2 similar issues
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7310/shard-dg1-14/igt@perf_pmu@busy-double-start@vecs0.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9060/shard-dg1-17/igt@perf_pmu@busy-double-start@vecs0.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[IGT#6]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/6
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109302]: https://bugs.freedesktop.org/show_bug.cgi?id=109302
[fdo#109303]: https://bugs.freedesktop.org/show_bug.cgi?id=109303
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1257]: https://gitlab.freedesktop.org/drm/intel/issues/1257
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#3023]: https://gitlab.freedesktop.org/drm/intel/issues/3023
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3528]: https://gitlab.freedesktop.org/drm/intel/issues/3528
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
[i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#426]: https://gitlab.freedesktop.org/drm/intel/issues/426
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
[i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#4565]: https://gitlab.freedesktop.org/drm/intel/issues/4565
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4771]: https://gitlab.freedesktop.org/drm/intel/issues/4771
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#4880]: https://gitlab.freedesktop.org/drm/intel/issues/4880
[i915#4885]: https://gitlab.freedesktop.org/drm/intel/issues/4885
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6230]: https://gitlab.freedesktop.org/drm/intel/issues/6230
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6590]: https://gitlab.freedesktop.org/drm/intel/issues/6590
[i915#6755]: https://gitlab.freedesktop.org/drm/intel/issues/6755
[i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
[i915#7392]: https://gitlab.freedesktop.org/drm/intel/issues/7392
[i915#7701]: https://gitlab.freedesktop.org/drm/intel/issues/7701
[i915#7707]: https://gitlab.freedesktop.org/drm/intel/issues/7707
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#8011]: https://gitlab.freedesktop.org/drm/intel/issues/8011
[i915#8211]: https://gitlab.freedesktop.org/drm/intel/issues/8211
[i915#8234]: https://gitlab.freedesktop.org/drm/intel/issues/8234
[i915#8414]: https://gitlab.freedesktop.org/drm/intel/issues/8414
[i915#8424]: https://gitlab.freedesktop.org/drm/intel/issues/8424
[i915#8502]: https://gitlab.freedesktop.org/drm/intel/issues/8502
[i915#8516]: https://gitlab.freedesktop.org/drm/intel/issues/8516
[i915#8555]: https://gitlab.freedesktop.org/drm/intel/issues/8555
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7310 -> IGTPW_9060
CI-20190529: 20190529
CI_DRM_13200: 0ae4ee2c735979030a0219218081eee661606921 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_9060: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9060/index.html
IGT_7310: 2f9acfea5e3a93303f71cbda6e80ba64b8d75a4d @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9060/index.html
[-- Attachment #2: Type: text/html, Size: 11126 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [igt-dev] [PATCH i-g-t v2] tests/kms_rotation_crc: enable and optimize test for sim
2023-05-29 12:11 [igt-dev] [PATCH i-g-t v2] tests/kms_rotation_crc: enable and optimize test for sim Swati Sharma
2023-05-30 13:33 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_rotation_crc: enable and optimize test for sim (rev2) Patchwork
2023-05-31 3:47 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
@ 2023-05-31 8:10 ` Juha-Pekka Heikkila
2023-05-31 8:12 ` Sharma, Swati2
2 siblings, 1 reply; 5+ messages in thread
From: Juha-Pekka Heikkila @ 2023-05-31 8:10 UTC (permalink / raw)
To: Swati Sharma, igt-dev
look ok to me. While pushing you could fix typo from commit message,
"PO10" -> "P010".
Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
On 29.5.2023 15.11, Swati Sharma wrote:
> To reduce execution time in simulation dropping RGB565 and PO10
> formats (coverage is not compromised, we do have NV12 and RGB888
> formats being validated).
> Also, skipping buffered CRC reusecrcfromlastround() in simulation.
>
> v2: -Add checks inside multiplaneskiproundcheck() and
> reusecrcfromlastround() (JP)
>
> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
> ---
> tests/kms_rotation_crc.c | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c
> index 28b4fd27..0a22cc22 100644
> --- a/tests/kms_rotation_crc.c
> +++ b/tests/kms_rotation_crc.c
> @@ -719,6 +719,16 @@ static bool multiplaneskiproundcheck(data_t *data, planeinfos p[2])
> if (!igt_plane_has_rotation(p[1].plane, p[1].fbinfo->rotation))
> return false;
>
> + if (igt_run_in_simulation() &&
> + (multiplaneformatlist[p[0].formatindex] == DRM_FORMAT_P010 ||
> + multiplaneformatlist[p[0].formatindex] == DRM_FORMAT_RGB565))
> + return false;
> +
> + if (igt_run_in_simulation() &&
> + (multiplaneformatlist[p[1].formatindex] == DRM_FORMAT_P010 ||
> + multiplaneformatlist[p[1].formatindex] == DRM_FORMAT_RGB565))
> + return false;
> +
> return true;
> }
>
> @@ -765,6 +775,9 @@ static bool reusecrcfromlastround(planeinfos p[2], int lastroundp1format,
> int lastroundp0rotation,
> int lastroundp1rotation)
> {
> + if (igt_run_in_simulation())
> + return false;
> +
> if (planarcheck != 1)
> return false;
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [igt-dev] [PATCH i-g-t v2] tests/kms_rotation_crc: enable and optimize test for sim
2023-05-31 8:10 ` [igt-dev] [PATCH i-g-t v2] tests/kms_rotation_crc: enable and optimize test for sim Juha-Pekka Heikkila
@ 2023-05-31 8:12 ` Sharma, Swati2
0 siblings, 0 replies; 5+ messages in thread
From: Sharma, Swati2 @ 2023-05-31 8:12 UTC (permalink / raw)
To: juhapekka.heikkila, igt-dev
Sure JP. Thanks for the review. Will fix typo before merging.
On 31-May-23 1:40 PM, Juha-Pekka Heikkila wrote:
> look ok to me. While pushing you could fix typo from commit message,
> "PO10" -> "P010".
>
> Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
>
> On 29.5.2023 15.11, Swati Sharma wrote:
>> To reduce execution time in simulation dropping RGB565 and PO10
>> formats (coverage is not compromised, we do have NV12 and RGB888
>> formats being validated).
>> Also, skipping buffered CRC reusecrcfromlastround() in simulation.
>>
>> v2: -Add checks inside multiplaneskiproundcheck() and
>> reusecrcfromlastround() (JP)
>>
>> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
>> ---
>> tests/kms_rotation_crc.c | 13 +++++++++++++
>> 1 file changed, 13 insertions(+)
>>
>> diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c
>> index 28b4fd27..0a22cc22 100644
>> --- a/tests/kms_rotation_crc.c
>> +++ b/tests/kms_rotation_crc.c
>> @@ -719,6 +719,16 @@ static bool multiplaneskiproundcheck(data_t
>> *data, planeinfos p[2])
>> if (!igt_plane_has_rotation(p[1].plane, p[1].fbinfo->rotation))
>> return false;
>> + if (igt_run_in_simulation() &&
>> + (multiplaneformatlist[p[0].formatindex] == DRM_FORMAT_P010 ||
>> + multiplaneformatlist[p[0].formatindex] == DRM_FORMAT_RGB565))
>> + return false;
>> +
>> + if (igt_run_in_simulation() &&
>> + (multiplaneformatlist[p[1].formatindex] == DRM_FORMAT_P010 ||
>> + multiplaneformatlist[p[1].formatindex] == DRM_FORMAT_RGB565))
>> + return false;
>> +
>> return true;
>> }
>> @@ -765,6 +775,9 @@ static bool reusecrcfromlastround(planeinfos p[2],
>> int lastroundp1format,
>> int lastroundp0rotation,
>> int lastroundp1rotation)
>> {
>> + if (igt_run_in_simulation())
>> + return false;
>> +
>> if (planarcheck != 1)
>> return false;
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-05-31 8:12 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-29 12:11 [igt-dev] [PATCH i-g-t v2] tests/kms_rotation_crc: enable and optimize test for sim Swati Sharma
2023-05-30 13:33 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_rotation_crc: enable and optimize test for sim (rev2) Patchwork
2023-05-31 3:47 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2023-05-31 8:10 ` [igt-dev] [PATCH i-g-t v2] tests/kms_rotation_crc: enable and optimize test for sim Juha-Pekka Heikkila
2023-05-31 8:12 ` Sharma, Swati2
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.