All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kees Cook <keescook@chromium.org>
To: Azeem Shaikh <azeemshaikh38@gmail.com>
Cc: Maxim Krasnyansky <maxk@qti.qualcomm.com>,
	linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org,
	Richard Weinberger <richard@nod.at>,
	Anton Ivanov <anton.ivanov@cambridgegreys.com>,
	Johannes Berg <johannes@sipsolutions.net>,
	linux-um@lists.infradead.org
Subject: Re: [PATCH] uml: Replace all non-returning strlcpy with strscpy
Date: Tue, 30 May 2023 16:21:15 -0700	[thread overview]
Message-ID: <202305301621.239F666@keescook> (raw)
In-Reply-To: <20230530164004.986750-1-azeemshaikh38@gmail.com>

On Tue, May 30, 2023 at 04:40:04PM +0000, Azeem Shaikh wrote:
> strlcpy() reads the entire source buffer first.
> This read may exceed the destination size limit.
> This is both inefficient and can lead to linear read
> overflows if a source string is not NUL-terminated [1].
> In an effort to remove strlcpy() completely [2], replace
> strlcpy() here with strscpy().
> No return values were used, so direct replacement is safe.
> 
> [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
> [2] https://github.com/KSPP/linux/issues/89
> 
> Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>

Reviewed-by: Kees Cook <keescook@chromium.org>

-- 
Kees Cook

  reply	other threads:[~2023-05-30 23:21 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-30 16:40 [PATCH] uml: Replace all non-returning strlcpy with strscpy Azeem Shaikh
2023-05-30 16:40 ` Azeem Shaikh
2023-05-30 23:21 ` Kees Cook [this message]
2023-05-31  3:18 ` kernel test robot
2023-05-31  3:18   ` kernel test robot
2023-05-31  4:41   ` Kees Cook
2023-05-31  4:41     ` Kees Cook
2023-05-31  6:18     ` Johannes Berg
2023-05-31  6:18       ` Johannes Berg
2023-05-31  6:26       ` Richard Weinberger
2023-05-31  6:26         ` Richard Weinberger
2023-05-31  6:23     ` Richard Weinberger
2023-05-31  6:23       ` Richard Weinberger
2023-05-31  8:05       ` Geert Uytterhoeven
2023-05-31  8:05         ` Geert Uytterhoeven
2023-05-31 14:48         ` Azeem Shaikh
2023-05-31 14:48           ` Azeem Shaikh
2023-06-05 20:07           ` Richard Weinberger
2023-06-05 20:07             ` Richard Weinberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202305301621.239F666@keescook \
    --to=keescook@chromium.org \
    --cc=anton.ivanov@cambridgegreys.com \
    --cc=azeemshaikh38@gmail.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-um@lists.infradead.org \
    --cc=maxk@qti.qualcomm.com \
    --cc=richard@nod.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.