From: Johannes Berg <johannes@sipsolutions.net> To: Kees Cook <kees@kernel.org>, kernel test robot <lkp@intel.com>, Azeem Shaikh <azeemshaikh38@gmail.com>, Maxim Krasnyansky <maxk@qti.qualcomm.com> Cc: oe-kbuild-all@lists.linux.dev, linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org, Richard Weinberger <richard@nod.at>, Anton Ivanov <anton.ivanov@cambridgegreys.com>, linux-um@lists.infradead.org Subject: Re: [PATCH] uml: Replace all non-returning strlcpy with strscpy Date: Wed, 31 May 2023 08:18:00 +0200 [thread overview] Message-ID: <8033fb8f9677cf9aae411e97eb554d251ca03011.camel@sipsolutions.net> (raw) In-Reply-To: <09A0C6FA-669F-4B73-9620-43AEA17E5D0C@kernel.org> > - strlcpy(ifr.ifr_name, pri->dev_name, > sizeof(ifr.ifr_name)); > + strscpy(ifr.ifr_name, pri->dev_name, > sizeof(ifr.ifr_name)); > > > arch/um/os-Linux/drivers/tuntap_user.c: In function 'tuntap_open': > > > > arch/um/os-Linux/drivers/tuntap_user.c:149:17: error: implicit declaration of function 'strscpy'; did you mean 'strncpy'? [-Werror=implicit-function-declaration] > > 149 | strscpy(ifr.ifr_name, pri->dev_name, sizeof(ifr.ifr_name)); > > | ^~~~~~~ > > | strncpy > > cc1: some warnings being treated as errors > > Ah, yeah, this is another "not actually in the kernel" cases. Let's ignore this strlcpy for now. > Well, strlcpy() isn't part of libc either, so all this would need is to add it to user.h just like strlcpy() is now? johannes
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Berg <johannes@sipsolutions.net> To: Kees Cook <kees@kernel.org>, kernel test robot <lkp@intel.com>, Azeem Shaikh <azeemshaikh38@gmail.com>, Maxim Krasnyansky <maxk@qti.qualcomm.com> Cc: oe-kbuild-all@lists.linux.dev, linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org, Richard Weinberger <richard@nod.at>, Anton Ivanov <anton.ivanov@cambridgegreys.com>, linux-um@lists.infradead.org Subject: Re: [PATCH] uml: Replace all non-returning strlcpy with strscpy Date: Wed, 31 May 2023 08:18:00 +0200 [thread overview] Message-ID: <8033fb8f9677cf9aae411e97eb554d251ca03011.camel@sipsolutions.net> (raw) In-Reply-To: <09A0C6FA-669F-4B73-9620-43AEA17E5D0C@kernel.org> > - strlcpy(ifr.ifr_name, pri->dev_name, > sizeof(ifr.ifr_name)); > + strscpy(ifr.ifr_name, pri->dev_name, > sizeof(ifr.ifr_name)); > > > arch/um/os-Linux/drivers/tuntap_user.c: In function 'tuntap_open': > > > > arch/um/os-Linux/drivers/tuntap_user.c:149:17: error: implicit declaration of function 'strscpy'; did you mean 'strncpy'? [-Werror=implicit-function-declaration] > > 149 | strscpy(ifr.ifr_name, pri->dev_name, sizeof(ifr.ifr_name)); > > | ^~~~~~~ > > | strncpy > > cc1: some warnings being treated as errors > > Ah, yeah, this is another "not actually in the kernel" cases. Let's ignore this strlcpy for now. > Well, strlcpy() isn't part of libc either, so all this would need is to add it to user.h just like strlcpy() is now? johannes _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um
next prev parent reply other threads:[~2023-05-31 6:40 UTC|newest] Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-05-30 16:40 [PATCH] uml: Replace all non-returning strlcpy with strscpy Azeem Shaikh 2023-05-30 16:40 ` Azeem Shaikh 2023-05-30 23:21 ` Kees Cook 2023-05-31 3:18 ` kernel test robot 2023-05-31 3:18 ` kernel test robot 2023-05-31 4:41 ` Kees Cook 2023-05-31 4:41 ` Kees Cook 2023-05-31 6:18 ` Johannes Berg [this message] 2023-05-31 6:18 ` Johannes Berg 2023-05-31 6:26 ` Richard Weinberger 2023-05-31 6:26 ` Richard Weinberger 2023-05-31 6:23 ` Richard Weinberger 2023-05-31 6:23 ` Richard Weinberger 2023-05-31 8:05 ` Geert Uytterhoeven 2023-05-31 8:05 ` Geert Uytterhoeven 2023-05-31 14:48 ` Azeem Shaikh 2023-05-31 14:48 ` Azeem Shaikh 2023-06-05 20:07 ` Richard Weinberger 2023-06-05 20:07 ` Richard Weinberger
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=8033fb8f9677cf9aae411e97eb554d251ca03011.camel@sipsolutions.net \ --to=johannes@sipsolutions.net \ --cc=anton.ivanov@cambridgegreys.com \ --cc=azeemshaikh38@gmail.com \ --cc=kees@kernel.org \ --cc=linux-hardening@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-um@lists.infradead.org \ --cc=lkp@intel.com \ --cc=maxk@qti.qualcomm.com \ --cc=oe-kbuild-all@lists.linux.dev \ --cc=richard@nod.at \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.