* [PATCH] of/flattree: Replace all non-returning strlcpy with strscpy
@ 2023-05-30 16:22 Azeem Shaikh
2023-05-30 23:20 ` Kees Cook
2023-06-14 18:35 ` Kees Cook
0 siblings, 2 replies; 3+ messages in thread
From: Azeem Shaikh @ 2023-05-30 16:22 UTC (permalink / raw)
To: Michal Simek; +Cc: linux-hardening, Azeem Shaikh, linux-kernel
strlcpy() reads the entire source buffer first.
This read may exceed the destination size limit.
This is both inefficient and can lead to linear read
overflows if a source string is not NUL-terminated [1].
In an effort to remove strlcpy() completely [2], replace
strlcpy() here with strscpy().
No return values were used, so direct replacement is safe.
[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
[2] https://github.com/KSPP/linux/issues/89
Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
---
arch/microblaze/kernel/prom.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/microblaze/kernel/prom.c b/arch/microblaze/kernel/prom.c
index c5c6186a7e8b..e424c796e297 100644
--- a/arch/microblaze/kernel/prom.c
+++ b/arch/microblaze/kernel/prom.c
@@ -20,7 +20,7 @@ void __init early_init_devtree(void *params)
early_init_dt_scan(params);
if (!strlen(boot_command_line))
- strlcpy(boot_command_line, cmd_line, COMMAND_LINE_SIZE);
+ strscpy(boot_command_line, cmd_line, COMMAND_LINE_SIZE);
memblock_allow_resize();
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] of/flattree: Replace all non-returning strlcpy with strscpy
2023-05-30 16:22 [PATCH] of/flattree: Replace all non-returning strlcpy with strscpy Azeem Shaikh
@ 2023-05-30 23:20 ` Kees Cook
2023-06-14 18:35 ` Kees Cook
1 sibling, 0 replies; 3+ messages in thread
From: Kees Cook @ 2023-05-30 23:20 UTC (permalink / raw)
To: Azeem Shaikh; +Cc: Michal Simek, linux-hardening, linux-kernel
On Tue, May 30, 2023 at 04:22:02PM +0000, Azeem Shaikh wrote:
> strlcpy() reads the entire source buffer first.
> This read may exceed the destination size limit.
> This is both inefficient and can lead to linear read
> overflows if a source string is not NUL-terminated [1].
> In an effort to remove strlcpy() completely [2], replace
> strlcpy() here with strscpy().
> No return values were used, so direct replacement is safe.
>
> [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
> [2] https://github.com/KSPP/linux/issues/89
>
> Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] of/flattree: Replace all non-returning strlcpy with strscpy
2023-05-30 16:22 [PATCH] of/flattree: Replace all non-returning strlcpy with strscpy Azeem Shaikh
2023-05-30 23:20 ` Kees Cook
@ 2023-06-14 18:35 ` Kees Cook
1 sibling, 0 replies; 3+ messages in thread
From: Kees Cook @ 2023-06-14 18:35 UTC (permalink / raw)
To: monstr, azeemshaikh38; +Cc: Kees Cook, linux-hardening, linux-kernel
On Tue, 30 May 2023 16:22:02 +0000, Azeem Shaikh wrote:
> strlcpy() reads the entire source buffer first.
> This read may exceed the destination size limit.
> This is both inefficient and can lead to linear read
> overflows if a source string is not NUL-terminated [1].
> In an effort to remove strlcpy() completely [2], replace
> strlcpy() here with strscpy().
> No return values were used, so direct replacement is safe.
>
> [...]
Build tested defconfig with GCC 13.1 from:
https://mirrors.edge.kernel.org/pub/tools/crosstool/files/bin/x86_64/13.1.0/
Applied to for-next/hardening, thanks!
[1/1] of/flattree: Replace all non-returning strlcpy with strscpy
https://git.kernel.org/kees/c/a7969f58df35
--
Kees Cook
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-06-14 18:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-30 16:22 [PATCH] of/flattree: Replace all non-returning strlcpy with strscpy Azeem Shaikh
2023-05-30 23:20 ` Kees Cook
2023-06-14 18:35 ` Kees Cook
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.