From: Rob Herring <robh@kernel.org> To: Miquel Raynal <miquel.raynal@bootlin.com> Cc: Frank Rowand <frowand.list@gmail.com>, Thomas Petazzoni <thomas.petazzoni@bootlin.com>, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, dri-devel@lists.freedesktop.org, Thierry Reding <thierry.reding@gmail.com>, David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, Mikko Perttunen <mperttunen@nvidia.com> Subject: Re: [PATCH 0/5] of: More 'device' vs. 'module' cleanups Date: Thu, 8 Jun 2023 12:49:03 -0600 [thread overview] Message-ID: <20230608184903.GA3200973-robh@kernel.org> (raw) In-Reply-To: <20230510154803.189096-1-miquel.raynal@bootlin.com> On Wed, May 10, 2023 at 05:47:58PM +0200, Miquel Raynal wrote: > Hello, > > As part of a previous series, Rob suggested that keeping too much logic > in of/device.c was backward and would benefit from a gradual cleanup > with the hope some day to move the remaining helpers into inline > functions wrapping the proper of_*() methods. Where I'm at on device.c is it should be functions that bus implementations need. I have a ton of tree wide changes to disentangle of_device.h and of_platform.h. Some of that landed in 6.4. uevents are pretty much tied to struct device and the bus, so I don't think moving these parts to module.c makes sense unless there is a need for the functionality without a struct device. Also, perhaps we want to make module.c configurable?: obj-$(CONFIG_MODULE) += module.o The uevent stuff is certainly independent of module support. > Link: https://lore.kernel.org/lkml/CAL_JsqJE43qfYzHUuCJsbaPPBTbYX05Q7FFmPTjPFZ3Dmz_mXg@mail.gmail.com/ > > A few of these "conversions" happened in the series I was originally > working on. At this time I actually wrote a few other changes, > completely unrelated to my original series, but still following Rob's > cleanup idea: here they are. > > Link: https://lore.kernel.org/lkml/20230307165359.225361-1-miquel.raynal@bootlin.com/ > > The last step of this series is to actually remove a copy of one of > these helpers which I think is not needed. This drivers/gpu/ patch > depends on the previous changes. > > Thanks, Miquèl > > Miquel Raynal (5): > of: module: Mutate of_device_modalias() into two helpers > of: module: Mutate of_device_uevent() into two helpers > of: module: Mutate of_device_uevent_modalias() into two helpers > of: module: Export of_uevent() > gpu: host1x: Stop open-coding of_device_uevent() This last patch is certainly worthwhile doing. Rob
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org> To: Miquel Raynal <miquel.raynal@bootlin.com> Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Mikko Perttunen <mperttunen@nvidia.com>, Thierry Reding <thierry.reding@gmail.com>, Thomas Petazzoni <thomas.petazzoni@bootlin.com>, linux-tegra@vger.kernel.org, Frank Rowand <frowand.list@gmail.com> Subject: Re: [PATCH 0/5] of: More 'device' vs. 'module' cleanups Date: Thu, 8 Jun 2023 12:49:03 -0600 [thread overview] Message-ID: <20230608184903.GA3200973-robh@kernel.org> (raw) In-Reply-To: <20230510154803.189096-1-miquel.raynal@bootlin.com> On Wed, May 10, 2023 at 05:47:58PM +0200, Miquel Raynal wrote: > Hello, > > As part of a previous series, Rob suggested that keeping too much logic > in of/device.c was backward and would benefit from a gradual cleanup > with the hope some day to move the remaining helpers into inline > functions wrapping the proper of_*() methods. Where I'm at on device.c is it should be functions that bus implementations need. I have a ton of tree wide changes to disentangle of_device.h and of_platform.h. Some of that landed in 6.4. uevents are pretty much tied to struct device and the bus, so I don't think moving these parts to module.c makes sense unless there is a need for the functionality without a struct device. Also, perhaps we want to make module.c configurable?: obj-$(CONFIG_MODULE) += module.o The uevent stuff is certainly independent of module support. > Link: https://lore.kernel.org/lkml/CAL_JsqJE43qfYzHUuCJsbaPPBTbYX05Q7FFmPTjPFZ3Dmz_mXg@mail.gmail.com/ > > A few of these "conversions" happened in the series I was originally > working on. At this time I actually wrote a few other changes, > completely unrelated to my original series, but still following Rob's > cleanup idea: here they are. > > Link: https://lore.kernel.org/lkml/20230307165359.225361-1-miquel.raynal@bootlin.com/ > > The last step of this series is to actually remove a copy of one of > these helpers which I think is not needed. This drivers/gpu/ patch > depends on the previous changes. > > Thanks, Miquèl > > Miquel Raynal (5): > of: module: Mutate of_device_modalias() into two helpers > of: module: Mutate of_device_uevent() into two helpers > of: module: Mutate of_device_uevent_modalias() into two helpers > of: module: Export of_uevent() > gpu: host1x: Stop open-coding of_device_uevent() This last patch is certainly worthwhile doing. Rob
next prev parent reply other threads:[~2023-06-08 18:49 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-05-10 15:47 [PATCH 0/5] of: More 'device' vs. 'module' cleanups Miquel Raynal 2023-05-10 15:47 ` Miquel Raynal 2023-05-10 15:47 ` [PATCH 1/5] of: module: Mutate of_device_modalias() into two helpers Miquel Raynal 2023-05-10 15:47 ` Miquel Raynal 2023-05-10 15:48 ` [PATCH 2/5] of: module: Mutate of_device_uevent() " Miquel Raynal 2023-05-10 15:48 ` Miquel Raynal 2023-05-10 15:48 ` [PATCH 3/5] of: module: Mutate of_device_uevent_modalias() " Miquel Raynal 2023-05-10 15:48 ` Miquel Raynal 2023-05-10 15:48 ` [PATCH 4/5] of: module: Export of_uevent() Miquel Raynal 2023-05-10 15:48 ` Miquel Raynal 2023-05-10 15:48 ` [PATCH 5/5] gpu: host1x: Stop open-coding of_device_uevent() Miquel Raynal 2023-05-10 15:48 ` Miquel Raynal 2023-06-08 18:49 ` Rob Herring [this message] 2023-06-08 18:49 ` [PATCH 0/5] of: More 'device' vs. 'module' cleanups Rob Herring
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230608184903.GA3200973-robh@kernel.org \ --to=robh@kernel.org \ --cc=airlied@gmail.com \ --cc=daniel@ffwll.ch \ --cc=devicetree@vger.kernel.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=frowand.list@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-tegra@vger.kernel.org \ --cc=miquel.raynal@bootlin.com \ --cc=mperttunen@nvidia.com \ --cc=thierry.reding@gmail.com \ --cc=thomas.petazzoni@bootlin.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.