Re: [PATCH 00/15] PCI: Convert to platform remove callback returning void

From: "Pali Rohár" <pali@kernel.org>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
	"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
	"Krzysztof Wilczyński" <kw@linux.com>,
	"Joyce Ooi" <joyce.ooi@intel.com>,
	"Florian Fainelli" <f.fainelli@gmail.com>,
	"Jim Quinlan" <jim2101024@gmail.com>,
	"Nicolas Saenz Julienne" <nsaenz@kernel.org>,
	"Vignesh Raghavendra" <vigneshr@ti.com>,
	"Tom Joseph" <tjoseph@cadence.com>,
	"Shawn Guo" <shawn.guo@linaro.org>,
	"Rahul Tanwar" <rtanwar@maxlinear.com>,
	"Manivannan Sadhasivam" <mani@kernel.org>,
	"Thierry Reding" <thierry.reding@gmail.com>,
	"Jonathan Hunter" <jonathanh@nvidia.com>,
	"Serge Semin" <Sergey.Semin@baikalelectronics.ru>,
	"Vidya Sagar" <vidyas@nvidia.com>,
	"Jisheng Zhang" <jszhang@kernel.org>,
	"Miaoqian Lin" <linmq006@gmail.com>,
	"Ray Jui" <rjui@broadcom.com>,
	"Scott Branden" <sbranden@broadcom.com>,
	"Ryder Lee" <ryder.lee@mediatek.com>,
	"Jianjun Wang" <jianjun.wang@mediatek.com>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	"Sergio Paracuellos" <sergio.paracuellos@gmail.com>,
	"Shawn Lin" <shawn.lin@rock-chips.com>,
	"Heiko Stuebner" <heiko@sntech.de>,
	"Toan Le" <toan@os.amperecomputing.com>,
	"Rob Herring" <robh@kernel.org>,
	linux-pci@vger.kernel.org, linux-rockchip@lists.infradead.org,
	"Broadcom internal kernel review list"
	<bcm-kernel-feedback-list@broadcom.com>,
	linux-rpi-kernel@lists.infradead.org, kernel@pengutronix.de,
	linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org,
	linux-mediatek@lists.infradead.org, linux-omap@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	"AngeloGioacchino Del Regno"
	<angelogioacchino.delregno@collabora.com>
Subject: Re: [PATCH 00/15] PCI: Convert to platform remove callback returning void
Date: Mon, 12 Jun 2023 20:17:26 +0200	[thread overview]
Message-ID: <20230612181726.itcctpkq57tfmdmo@pali> (raw)
In-Reply-To: <20230612161927.GA1335109@bhelgaas>

On Monday 12 June 2023 11:19:27 Bjorn Helgaas wrote:
> On Sun, Jun 11, 2023 at 03:24:23PM +0200, Pali Rohár wrote:
> > On Friday 02 June 2023 16:37:34 Bjorn Helgaas wrote:
> > > On Tue, May 30, 2023 at 04:07:42PM +0200, Uwe Kleine-König wrote:
> > > > On Tue, Mar 21, 2023 at 08:31:53PM +0100, Uwe Kleine-König wrote:
> > > > > this series adapts the platform drivers below drivers/pci to
> > > > > use the .remove_new() callback. Compared to the traditional
> > > > > .remove() callback .remove_new() returns no value. This is a
> > > > > good thing because the driver core doesn't (and cannot) cope
> > > > > for errors during remove. The only effect of a non-zero return
> > > > > value in .remove() is that the driver core emits a warning.
> > > > > The device is removed anyhow and an early return from
> > > > > .remove() usually yields a resource leak.
> > ...
> 
> > Hello Bjorn, it should be expected that other changes for PCIe drivers
> > sent by other people which were sent to the list before this patch
> > series and are still waiting for the review (because are without
> > comments), would be processed before and patches sent later.
> 
> I don't think it's necessary to delay simple, easily-reviewed changes
> behind more complicated ones.
> 
> > Also I would like to point out that in past I have sent fixes for PCIe
> > mvebu driver, which is currently in the broken state. And this is also
> > on waiting on the list.
> 
> Thanks for this reminder.  Would you mind reposting them?  I poked
> around in patchwork and I must be doing something wrong because I
> can't find *any* patches from you, though obviously there are many.
> 
> If you repost them at least we'll know unambiguously what is on the
> table.
> 
> Bjorn

Well, my patches I reposted more times. And some were also reposted by
other people. I do not know if they are in patchwork, but they are in
email archive. For example last repost of aardvark patches are here:
https://lore.kernel.org/linux-pci/20220927141926.8895-1-kabel@kernel.org/
And some other aardvark are also here:
https://lore.kernel.org/linux-pci/20220711120626.11492-1-pali@kernel.org/