* [PATCH] net/mediatek: strlcpy withreturn
@ 2023-06-13 0:34 ` Azeem Shaikh
0 siblings, 0 replies; 10+ messages in thread
From: Azeem Shaikh @ 2023-06-13 0:34 UTC (permalink / raw)
To: Jakub Kicinski
Cc: linux-hardening, Azeem Shaikh, linux-wireless, linux-kernel,
Kalle Valo, Matthias Brugger, AngeloGioacchino Del Regno,
linux-arm-kernel, linux-mediatek
strlcpy() reads the entire source buffer first.
This read may exceed the destination size limit.
This is both inefficient and can lead to linear read
overflows if a source string is not NUL-terminated [1].
In an effort to remove strlcpy() completely [2], replace
strlcpy() here with strscpy().
Direct replacement is safe here since DEV_ASSIGN is only used by
TRACE macros and the return values are ignored.
[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
[2] https://github.com/KSPP/linux/issues/89
Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
---
drivers/net/wireless/mediatek/mt7601u/trace.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/mediatek/mt7601u/trace.h b/drivers/net/wireless/mediatek/mt7601u/trace.h
index 5a6ba015085f..07696b672161 100644
--- a/drivers/net/wireless/mediatek/mt7601u/trace.h
+++ b/drivers/net/wireless/mediatek/mt7601u/trace.h
@@ -16,7 +16,7 @@
#define MAXNAME 32
#define DEV_ENTRY __array(char, wiphy_name, 32)
-#define DEV_ASSIGN strlcpy(__entry->wiphy_name, \
+#define DEV_ASSIGN strscpy(__entry->wiphy_name, \
wiphy_name(dev->hw->wiphy), MAXNAME)
#define DEV_PR_FMT "%s "
#define DEV_PR_ARG __entry->wiphy_name
--
2.41.0.162.gfafddb0af9-goog
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH] net/mediatek: strlcpy withreturn
@ 2023-06-13 0:34 ` Azeem Shaikh
0 siblings, 0 replies; 10+ messages in thread
From: Azeem Shaikh @ 2023-06-13 0:34 UTC (permalink / raw)
To: Jakub Kicinski
Cc: linux-hardening, Azeem Shaikh, linux-wireless, linux-kernel,
Kalle Valo, Matthias Brugger, AngeloGioacchino Del Regno,
linux-arm-kernel, linux-mediatek
strlcpy() reads the entire source buffer first.
This read may exceed the destination size limit.
This is both inefficient and can lead to linear read
overflows if a source string is not NUL-terminated [1].
In an effort to remove strlcpy() completely [2], replace
strlcpy() here with strscpy().
Direct replacement is safe here since DEV_ASSIGN is only used by
TRACE macros and the return values are ignored.
[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
[2] https://github.com/KSPP/linux/issues/89
Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
---
drivers/net/wireless/mediatek/mt7601u/trace.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/mediatek/mt7601u/trace.h b/drivers/net/wireless/mediatek/mt7601u/trace.h
index 5a6ba015085f..07696b672161 100644
--- a/drivers/net/wireless/mediatek/mt7601u/trace.h
+++ b/drivers/net/wireless/mediatek/mt7601u/trace.h
@@ -16,7 +16,7 @@
#define MAXNAME 32
#define DEV_ENTRY __array(char, wiphy_name, 32)
-#define DEV_ASSIGN strlcpy(__entry->wiphy_name, \
+#define DEV_ASSIGN strscpy(__entry->wiphy_name, \
wiphy_name(dev->hw->wiphy), MAXNAME)
#define DEV_PR_FMT "%s "
#define DEV_PR_ARG __entry->wiphy_name
--
2.41.0.162.gfafddb0af9-goog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] net/mediatek: strlcpy withreturn
2023-06-13 0:34 ` Azeem Shaikh
@ 2023-06-13 8:35 ` Kalle Valo
-1 siblings, 0 replies; 10+ messages in thread
From: Kalle Valo @ 2023-06-13 8:35 UTC (permalink / raw)
To: Azeem Shaikh
Cc: Jakub Kicinski, linux-hardening, Azeem Shaikh, linux-wireless,
linux-kernel, Matthias Brugger, AngeloGioacchino Del Regno,
linux-arm-kernel, linux-mediatek
Azeem Shaikh <azeemshaikh38@gmail.com> wrote:
> strlcpy() reads the entire source buffer first.
> This read may exceed the destination size limit.
> This is both inefficient and can lead to linear read
> overflows if a source string is not NUL-terminated [1].
> In an effort to remove strlcpy() completely [2], replace
> strlcpy() here with strscpy().
>
> Direct replacement is safe here since DEV_ASSIGN is only used by
> TRACE macros and the return values are ignored.
>
> [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
> [2] https://github.com/KSPP/linux/issues/89
>
> Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
The title should be:
wifi: mt7601u: replace strlcpy() with strscpy()
I can fix that, no need to resend because of this.
--
https://patchwork.kernel.org/project/linux-wireless/patch/20230613003458.3538812-1-azeemshaikh38@gmail.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] net/mediatek: strlcpy withreturn
@ 2023-06-13 8:35 ` Kalle Valo
0 siblings, 0 replies; 10+ messages in thread
From: Kalle Valo @ 2023-06-13 8:35 UTC (permalink / raw)
To: Azeem Shaikh
Cc: Jakub Kicinski, linux-hardening, Azeem Shaikh, linux-wireless,
linux-kernel, Matthias Brugger, AngeloGioacchino Del Regno,
linux-arm-kernel, linux-mediatek
Azeem Shaikh <azeemshaikh38@gmail.com> wrote:
> strlcpy() reads the entire source buffer first.
> This read may exceed the destination size limit.
> This is both inefficient and can lead to linear read
> overflows if a source string is not NUL-terminated [1].
> In an effort to remove strlcpy() completely [2], replace
> strlcpy() here with strscpy().
>
> Direct replacement is safe here since DEV_ASSIGN is only used by
> TRACE macros and the return values are ignored.
>
> [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
> [2] https://github.com/KSPP/linux/issues/89
>
> Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
The title should be:
wifi: mt7601u: replace strlcpy() with strscpy()
I can fix that, no need to resend because of this.
--
https://patchwork.kernel.org/project/linux-wireless/patch/20230613003458.3538812-1-azeemshaikh38@gmail.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] net/mediatek: strlcpy withreturn
2023-06-13 8:35 ` Kalle Valo
@ 2023-06-13 14:11 ` Azeem Shaikh
-1 siblings, 0 replies; 10+ messages in thread
From: Azeem Shaikh @ 2023-06-13 14:11 UTC (permalink / raw)
To: Kalle Valo
Cc: Jakub Kicinski, linux-hardening, linux-wireless, linux-kernel,
Matthias Brugger, AngeloGioacchino Del Regno, linux-arm-kernel,
linux-mediatek
On Tue, Jun 13, 2023 at 4:35 AM Kalle Valo <kvalo@kernel.org> wrote:
>
> Azeem Shaikh <azeemshaikh38@gmail.com> wrote:
>
> > strlcpy() reads the entire source buffer first.
> > This read may exceed the destination size limit.
> > This is both inefficient and can lead to linear read
> > overflows if a source string is not NUL-terminated [1].
> > In an effort to remove strlcpy() completely [2], replace
> > strlcpy() here with strscpy().
> >
> > Direct replacement is safe here since DEV_ASSIGN is only used by
> > TRACE macros and the return values are ignored.
> >
> > [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
> > [2] https://github.com/KSPP/linux/issues/89
> >
> > Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
>
> The title should be:
>
> wifi: mt7601u: replace strlcpy() with strscpy()
>
> I can fix that, no need to resend because of this.
>
Thanks Kalle!
> --
> https://patchwork.kernel.org/project/linux-wireless/patch/20230613003458.3538812-1-azeemshaikh38@gmail.com/
>
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] net/mediatek: strlcpy withreturn
@ 2023-06-13 14:11 ` Azeem Shaikh
0 siblings, 0 replies; 10+ messages in thread
From: Azeem Shaikh @ 2023-06-13 14:11 UTC (permalink / raw)
To: Kalle Valo
Cc: Jakub Kicinski, linux-hardening, linux-wireless, linux-kernel,
Matthias Brugger, AngeloGioacchino Del Regno, linux-arm-kernel,
linux-mediatek
On Tue, Jun 13, 2023 at 4:35 AM Kalle Valo <kvalo@kernel.org> wrote:
>
> Azeem Shaikh <azeemshaikh38@gmail.com> wrote:
>
> > strlcpy() reads the entire source buffer first.
> > This read may exceed the destination size limit.
> > This is both inefficient and can lead to linear read
> > overflows if a source string is not NUL-terminated [1].
> > In an effort to remove strlcpy() completely [2], replace
> > strlcpy() here with strscpy().
> >
> > Direct replacement is safe here since DEV_ASSIGN is only used by
> > TRACE macros and the return values are ignored.
> >
> > [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
> > [2] https://github.com/KSPP/linux/issues/89
> >
> > Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
>
> The title should be:
>
> wifi: mt7601u: replace strlcpy() with strscpy()
>
> I can fix that, no need to resend because of this.
>
Thanks Kalle!
> --
> https://patchwork.kernel.org/project/linux-wireless/patch/20230613003458.3538812-1-azeemshaikh38@gmail.com/
>
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] net/mediatek: strlcpy withreturn
2023-06-13 0:34 ` Azeem Shaikh
@ 2023-06-13 19:23 ` Kees Cook
-1 siblings, 0 replies; 10+ messages in thread
From: Kees Cook @ 2023-06-13 19:23 UTC (permalink / raw)
To: Azeem Shaikh
Cc: Jakub Kicinski, linux-hardening, linux-wireless, linux-kernel,
Kalle Valo, Matthias Brugger, AngeloGioacchino Del Regno,
linux-arm-kernel, linux-mediatek
On Tue, Jun 13, 2023 at 12:34:57AM +0000, Azeem Shaikh wrote:
> strlcpy() reads the entire source buffer first.
> This read may exceed the destination size limit.
> This is both inefficient and can lead to linear read
> overflows if a source string is not NUL-terminated [1].
> In an effort to remove strlcpy() completely [2], replace
> strlcpy() here with strscpy().
>
> Direct replacement is safe here since DEV_ASSIGN is only used by
> TRACE macros and the return values are ignored.
>
> [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
> [2] https://github.com/KSPP/linux/issues/89
>
> Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
Yup double-checked the users of the macros. Looks good to me.
Reviewed-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] net/mediatek: strlcpy withreturn
@ 2023-06-13 19:23 ` Kees Cook
0 siblings, 0 replies; 10+ messages in thread
From: Kees Cook @ 2023-06-13 19:23 UTC (permalink / raw)
To: Azeem Shaikh
Cc: Jakub Kicinski, linux-hardening, linux-wireless, linux-kernel,
Kalle Valo, Matthias Brugger, AngeloGioacchino Del Regno,
linux-arm-kernel, linux-mediatek
On Tue, Jun 13, 2023 at 12:34:57AM +0000, Azeem Shaikh wrote:
> strlcpy() reads the entire source buffer first.
> This read may exceed the destination size limit.
> This is both inefficient and can lead to linear read
> overflows if a source string is not NUL-terminated [1].
> In an effort to remove strlcpy() completely [2], replace
> strlcpy() here with strscpy().
>
> Direct replacement is safe here since DEV_ASSIGN is only used by
> TRACE macros and the return values are ignored.
>
> [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
> [2] https://github.com/KSPP/linux/issues/89
>
> Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
Yup double-checked the users of the macros. Looks good to me.
Reviewed-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: wifi: mt7601u: replace strlcpy() with strscpy()
2023-06-13 0:34 ` Azeem Shaikh
@ 2023-06-15 7:46 ` Kalle Valo
-1 siblings, 0 replies; 10+ messages in thread
From: Kalle Valo @ 2023-06-15 7:46 UTC (permalink / raw)
To: Azeem Shaikh
Cc: Jakub Kicinski, linux-hardening, Azeem Shaikh, linux-wireless,
linux-kernel, Matthias Brugger, AngeloGioacchino Del Regno,
linux-arm-kernel, linux-mediatek
Azeem Shaikh <azeemshaikh38@gmail.com> wrote:
> strlcpy() reads the entire source buffer first.
> This read may exceed the destination size limit.
> This is both inefficient and can lead to linear read
> overflows if a source string is not NUL-terminated [1].
> In an effort to remove strlcpy() completely [2], replace
> strlcpy() here with strscpy().
>
> Direct replacement is safe here since DEV_ASSIGN is only used by
> TRACE macros and the return values are ignored.
>
> [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
> [2] https://github.com/KSPP/linux/issues/89
>
> Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
> Reviewed-by: Kees Cook <keescook@chromium.org>
Patch applied to wireless-next.git, thanks.
7edbd53a58a8 wifi: mt7601u: replace strlcpy() with strscpy()
--
https://patchwork.kernel.org/project/linux-wireless/patch/20230613003458.3538812-1-azeemshaikh38@gmail.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: wifi: mt7601u: replace strlcpy() with strscpy()
@ 2023-06-15 7:46 ` Kalle Valo
0 siblings, 0 replies; 10+ messages in thread
From: Kalle Valo @ 2023-06-15 7:46 UTC (permalink / raw)
To: Azeem Shaikh
Cc: Jakub Kicinski, linux-hardening, Azeem Shaikh, linux-wireless,
linux-kernel, Matthias Brugger, AngeloGioacchino Del Regno,
linux-arm-kernel, linux-mediatek
Azeem Shaikh <azeemshaikh38@gmail.com> wrote:
> strlcpy() reads the entire source buffer first.
> This read may exceed the destination size limit.
> This is both inefficient and can lead to linear read
> overflows if a source string is not NUL-terminated [1].
> In an effort to remove strlcpy() completely [2], replace
> strlcpy() here with strscpy().
>
> Direct replacement is safe here since DEV_ASSIGN is only used by
> TRACE macros and the return values are ignored.
>
> [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
> [2] https://github.com/KSPP/linux/issues/89
>
> Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
> Reviewed-by: Kees Cook <keescook@chromium.org>
Patch applied to wireless-next.git, thanks.
7edbd53a58a8 wifi: mt7601u: replace strlcpy() with strscpy()
--
https://patchwork.kernel.org/project/linux-wireless/patch/20230613003458.3538812-1-azeemshaikh38@gmail.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2023-06-15 7:47 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-13 0:34 [PATCH] net/mediatek: strlcpy withreturn Azeem Shaikh
2023-06-13 0:34 ` Azeem Shaikh
2023-06-13 8:35 ` Kalle Valo
2023-06-13 8:35 ` Kalle Valo
2023-06-13 14:11 ` Azeem Shaikh
2023-06-13 14:11 ` Azeem Shaikh
2023-06-13 19:23 ` Kees Cook
2023-06-13 19:23 ` Kees Cook
2023-06-15 7:46 ` wifi: mt7601u: replace strlcpy() with strscpy() Kalle Valo
2023-06-15 7:46 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.