* [igt-dev] [PATCH i-g-t] i915/kms_busy: reduce heartbeat intervals only if neccessary
@ 2023-06-13 19:52 Andrzej Hajda
2023-06-13 20:49 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Andrzej Hajda @ 2023-06-13 19:52 UTC (permalink / raw)
To: igt-dev; +Cc: Nirmoy Das
Reducing heartbeat intervals may downgrade individual engine resets
to full GPU resets. The latter is not desirable, especially
on simulations, which do not support GPU reset. Only tests with
reset flag enabled need reduced hearbeat intervals.
Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
---
tests/i915/kms_busy.c | 19 ++++++++++++-------
1 file changed, 12 insertions(+), 7 deletions(-)
diff --git a/tests/i915/kms_busy.c b/tests/i915/kms_busy.c
index 20d3058fb6f..ccabc38fd3f 100644
--- a/tests/i915/kms_busy.c
+++ b/tests/i915/kms_busy.c
@@ -390,8 +390,6 @@ igt_main_args("e", NULL, help_str, opt_handler, NULL)
{ "extended-modeset-hang-oldfb-with-reset", true, false, true },
{ "extended-modeset-hang-newfb-with-reset", true, true, true },
};
- struct gem_engine_properties saved_gpu_timeouts[GEM_MAX_ENGINES];
- int num_engines;
int fd;
igt_fixture {
@@ -409,8 +407,6 @@ igt_main_args("e", NULL, help_str, opt_handler, NULL)
for_each_pipe(&display, pipe)
active_pipes[last_pipe++] = pipe;
last_pipe--;
-
- gpu_engines_init_timeouts(fd, ARRAY_SIZE(saved_gpu_timeouts), &num_engines, saved_gpu_timeouts);
}
/* XXX Extend to cover atomic rendering tests to all planes + legacy */
@@ -488,14 +484,24 @@ igt_main_args("e", NULL, help_str, opt_handler, NULL)
continue;
igt_dynamic_f("pipe-%s", kmstest_pipe_name(pipe)) {
- if (tests[i].reset)
+ struct gem_engine_properties saved_gpu_timeouts[GEM_MAX_ENGINES];
+ int num_engines;
+
+ if (tests[i].reset) {
+ gpu_engines_init_timeouts(display.drm_fd,
+ ARRAY_SIZE(saved_gpu_timeouts),
+ &num_engines, saved_gpu_timeouts);
igt_set_module_param_int(display.drm_fd, "force_reset_modeset_test", 1);
+ }
test_hang(&display, pipe, output,
tests[i].modeset, tests[i].hang_newfb);
- if (tests[i].reset)
+ if (tests[i].reset) {
igt_set_module_param_int(display.drm_fd, "force_reset_modeset_test", 0);
+ gpu_engines_restore_timeouts(display.drm_fd, num_engines,
+ saved_gpu_timeouts);
+ }
}
}
@@ -504,7 +510,6 @@ igt_main_args("e", NULL, help_str, opt_handler, NULL)
}
igt_fixture {
- gpu_engines_restore_timeouts(fd, num_engines, saved_gpu_timeouts);
igt_display_fini(&display);
close(display.drm_fd);
}
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for i915/kms_busy: reduce heartbeat intervals only if neccessary
2023-06-13 19:52 [igt-dev] [PATCH i-g-t] i915/kms_busy: reduce heartbeat intervals only if neccessary Andrzej Hajda
@ 2023-06-13 20:49 ` Patchwork
2023-06-13 23:25 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2023-06-13 20:49 UTC (permalink / raw)
To: Andrzej Hajda; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 7291 bytes --]
== Series Details ==
Series: i915/kms_busy: reduce heartbeat intervals only if neccessary
URL : https://patchwork.freedesktop.org/series/119295/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13267 -> IGTPW_9162
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/index.html
Participating hosts (39 -> 39)
------------------------------
Additional (1): fi-kbl-soraka
Missing (1): fi-snb-2520m
Known issues
------------
Here are the changes found in IGTPW_9162 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_suspend@basic-s0@lmem0:
- bat-dg2-11: NOTRUN -> [FAIL][1] ([fdo#103375] / [i915#8011]) +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/bat-dg2-11/igt@gem_exec_suspend@basic-s0@lmem0.html
* igt@gem_huc_copy@huc-copy:
- fi-kbl-soraka: NOTRUN -> [SKIP][2] ([fdo#109271] / [i915#2190])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/fi-kbl-soraka/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@basic:
- fi-kbl-soraka: NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#4613]) +3 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/fi-kbl-soraka/igt@gem_lmem_swapping@basic.html
* igt@i915_selftest@live@execlists:
- fi-bsw-n3050: [PASS][4] -> [ABORT][5] ([i915#7911] / [i915#7913])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13267/fi-bsw-n3050/igt@i915_selftest@live@execlists.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/fi-bsw-n3050/igt@i915_selftest@live@execlists.html
* igt@i915_selftest@live@gt_mocs:
- bat-mtlp-6: [PASS][6] -> [DMESG-FAIL][7] ([i915#7059])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13267/bat-mtlp-6/igt@i915_selftest@live@gt_mocs.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/bat-mtlp-6/igt@i915_selftest@live@gt_mocs.html
* igt@i915_selftest@live@gt_pm:
- fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][8] ([i915#1886] / [i915#7913])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html
* igt@i915_selftest@live@reset:
- bat-rpls-1: NOTRUN -> [ABORT][9] ([i915#4983] / [i915#7461] / [i915#8347] / [i915#8384])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/bat-rpls-1/igt@i915_selftest@live@reset.html
* igt@i915_selftest@live@slpc:
- bat-mtlp-6: [PASS][10] -> [DMESG-WARN][11] ([i915#6367])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13267/bat-mtlp-6/igt@i915_selftest@live@slpc.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/bat-mtlp-6/igt@i915_selftest@live@slpc.html
* igt@kms_chamelium_frames@hdmi-crc-fast:
- fi-kbl-soraka: NOTRUN -> [SKIP][12] ([fdo#109271]) +14 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/fi-kbl-soraka/igt@kms_chamelium_frames@hdmi-crc-fast.html
* igt@kms_chamelium_hpd@common-hpd-after-suspend:
- bat-dg2-11: NOTRUN -> [SKIP][13] ([i915#7828])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/bat-dg2-11/igt@kms_chamelium_hpd@common-hpd-after-suspend.html
* igt@kms_pipe_crc_basic@suspend-read-crc@pipe-b-hdmi-a-3:
- bat-dg2-11: NOTRUN -> [FAIL][14] ([fdo#103375]) +5 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/bat-dg2-11/igt@kms_pipe_crc_basic@suspend-read-crc@pipe-b-hdmi-a-3.html
* igt@kms_setmode@basic-clone-single-crtc:
- fi-kbl-soraka: NOTRUN -> [SKIP][15] ([fdo#109271] / [i915#4579])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/fi-kbl-soraka/igt@kms_setmode@basic-clone-single-crtc.html
#### Possible fixes ####
* igt@i915_selftest@live@hangcheck:
- bat-dg2-11: [ABORT][16] ([i915#7913] / [i915#7979]) -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13267/bat-dg2-11/igt@i915_selftest@live@hangcheck.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/bat-dg2-11/igt@i915_selftest@live@hangcheck.html
* igt@i915_selftest@live@requests:
- bat-rpls-1: [ABORT][18] ([i915#7911] / [i915#7920]) -> [PASS][19]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13267/bat-rpls-1/igt@i915_selftest@live@requests.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/bat-rpls-1/igt@i915_selftest@live@requests.html
* igt@kms_pipe_crc_basic@nonblocking-crc@pipe-c-dp-1:
- bat-dg2-8: [FAIL][20] ([i915#7932]) -> [PASS][21]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13267/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc@pipe-c-dp-1.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc@pipe-c-dp-1.html
#### Warnings ####
* igt@core_auth@basic-auth:
- bat-adlp-11: [ABORT][22] ([i915#8011]) -> [ABORT][23] ([i915#4423] / [i915#8011])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13267/bat-adlp-11/igt@core_auth@basic-auth.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/bat-adlp-11/igt@core_auth@basic-auth.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#4423]: https://gitlab.freedesktop.org/drm/intel/issues/4423
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#7059]: https://gitlab.freedesktop.org/drm/intel/issues/7059
[i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7911]: https://gitlab.freedesktop.org/drm/intel/issues/7911
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#7920]: https://gitlab.freedesktop.org/drm/intel/issues/7920
[i915#7932]: https://gitlab.freedesktop.org/drm/intel/issues/7932
[i915#7979]: https://gitlab.freedesktop.org/drm/intel/issues/7979
[i915#8011]: https://gitlab.freedesktop.org/drm/intel/issues/8011
[i915#8347]: https://gitlab.freedesktop.org/drm/intel/issues/8347
[i915#8384]: https://gitlab.freedesktop.org/drm/intel/issues/8384
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7327 -> IGTPW_9162
CI-20190529: 20190529
CI_DRM_13267: f289de77157f83b6846850bca9e03d6d6576ab3c @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_9162: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/index.html
IGT_7327: 34e48b7d6402c3d7af19a40d8951eae017cf64df @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/index.html
[-- Attachment #2: Type: text/html, Size: 8870 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for i915/kms_busy: reduce heartbeat intervals only if neccessary
2023-06-13 19:52 [igt-dev] [PATCH i-g-t] i915/kms_busy: reduce heartbeat intervals only if neccessary Andrzej Hajda
2023-06-13 20:49 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2023-06-13 23:25 ` Patchwork
2023-06-14 15:01 ` [igt-dev] [PATCH i-g-t] " Nirmoy Das
2023-06-14 15:32 ` Kamil Konieczny
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2023-06-13 23:25 UTC (permalink / raw)
To: Andrzej Hajda; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 24616 bytes --]
== Series Details ==
Series: i915/kms_busy: reduce heartbeat intervals only if neccessary
URL : https://patchwork.freedesktop.org/series/119295/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13267_full -> IGTPW_9162_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/index.html
Participating hosts (7 -> 7)
------------------------------
No changes in participating hosts
Known issues
------------
Here are the changes found in IGTPW_9162_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@debugfs_test@basic-hwmon:
- shard-tglu: NOTRUN -> [SKIP][1] ([i915#7456])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/shard-tglu-3/igt@debugfs_test@basic-hwmon.html
* igt@drm_fdinfo@most-busy-idle-check-all@rcs0:
- shard-rkl: [PASS][2] -> [FAIL][3] ([i915#7742])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13267/shard-rkl-6/igt@drm_fdinfo@most-busy-idle-check-all@rcs0.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/shard-rkl-2/igt@drm_fdinfo@most-busy-idle-check-all@rcs0.html
* igt@gem_barrier_race@remote-request@rcs0:
- shard-glk: [PASS][4] -> [ABORT][5] ([i915#7461] / [i915#8190])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13267/shard-glk3/igt@gem_barrier_race@remote-request@rcs0.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/shard-glk4/igt@gem_barrier_race@remote-request@rcs0.html
* igt@gem_ccs@block-multicopy-compressed:
- shard-tglu: NOTRUN -> [SKIP][6] ([i915#4579] / [i915#5325])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/shard-tglu-10/igt@gem_ccs@block-multicopy-compressed.html
* igt@gem_ctx_exec@basic-nohangcheck:
- shard-rkl: [PASS][7] -> [FAIL][8] ([i915#6268])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13267/shard-rkl-7/igt@gem_ctx_exec@basic-nohangcheck.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/shard-rkl-7/igt@gem_ctx_exec@basic-nohangcheck.html
* igt@gem_exec_fair@basic-deadline:
- shard-glk: [PASS][9] -> [FAIL][10] ([i915#2846])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13267/shard-glk1/igt@gem_exec_fair@basic-deadline.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/shard-glk1/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-tglu: [PASS][11] -> [FAIL][12] ([i915#2842])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13267/shard-tglu-5/igt@gem_exec_fair@basic-pace-share@rcs0.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/shard-tglu-9/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-apl: [PASS][13] -> [FAIL][14] ([i915#2842])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13267/shard-apl4/igt@gem_exec_fair@basic-pace-solo@rcs0.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/shard-apl1/igt@gem_exec_fair@basic-pace-solo@rcs0.html
* igt@gem_exec_suspend@basic-s3-devices@smem:
- shard-snb: [PASS][15] -> [INCOMPLETE][16] ([i915#7793] / [i915#8294])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13267/shard-snb7/igt@gem_exec_suspend@basic-s3-devices@smem.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/shard-snb4/igt@gem_exec_suspend@basic-s3-devices@smem.html
* igt@gem_lmem_swapping@basic:
- shard-apl: NOTRUN -> [SKIP][17] ([fdo#109271] / [i915#4613])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/shard-apl3/igt@gem_lmem_swapping@basic.html
* igt@gem_lmem_swapping@parallel-random-verify:
- shard-rkl: NOTRUN -> [SKIP][18] ([i915#4613])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/shard-rkl-7/igt@gem_lmem_swapping@parallel-random-verify.html
* igt@gem_userptr_blits@coherency-sync:
- shard-tglu: NOTRUN -> [SKIP][19] ([fdo#110542])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/shard-tglu-3/igt@gem_userptr_blits@coherency-sync.html
* igt@gen7_exec_parse@basic-allowed:
- shard-apl: NOTRUN -> [SKIP][20] ([fdo#109271]) +32 similar issues
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/shard-apl2/igt@gen7_exec_parse@basic-allowed.html
* igt@gen7_exec_parse@load-register-reg:
- shard-tglu: NOTRUN -> [SKIP][21] ([fdo#109289])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/shard-tglu-7/igt@gen7_exec_parse@load-register-reg.html
* igt@gen9_exec_parse@bb-chained:
- shard-tglu: NOTRUN -> [SKIP][22] ([i915#2527] / [i915#2856])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/shard-tglu-2/igt@gen9_exec_parse@bb-chained.html
* igt@i915_pm_dc@dc9-dpms:
- shard-apl: [PASS][23] -> [SKIP][24] ([fdo#109271])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13267/shard-apl4/igt@i915_pm_dc@dc9-dpms.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/shard-apl7/igt@i915_pm_dc@dc9-dpms.html
* igt@i915_pm_rpm@dpms-mode-unset-lpsp:
- shard-rkl: [PASS][25] -> [SKIP][26] ([i915#1397]) +1 similar issue
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13267/shard-rkl-7/igt@i915_pm_rpm@dpms-mode-unset-lpsp.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/shard-rkl-6/igt@i915_pm_rpm@dpms-mode-unset-lpsp.html
* igt@i915_pm_rps@reset:
- shard-snb: [PASS][27] -> [INCOMPLETE][28] ([i915#7790])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13267/shard-snb5/igt@i915_pm_rps@reset.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/shard-snb2/igt@i915_pm_rps@reset.html
* igt@i915_power@sanity:
- shard-rkl: NOTRUN -> [SKIP][29] ([i915#7984])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/shard-rkl-2/igt@i915_power@sanity.html
* igt@i915_suspend@basic-s3-without-i915:
- shard-rkl: [PASS][30] -> [FAIL][31] ([fdo#103375])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13267/shard-rkl-2/igt@i915_suspend@basic-s3-without-i915.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/shard-rkl-6/igt@i915_suspend@basic-s3-without-i915.html
* igt@kms_big_fb@yf-tiled-16bpp-rotate-0:
- shard-tglu: NOTRUN -> [SKIP][32] ([fdo#111615])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/shard-tglu-8/igt@kms_big_fb@yf-tiled-16bpp-rotate-0.html
* igt@kms_big_joiner@basic:
- shard-rkl: NOTRUN -> [SKIP][33] ([i915#2705])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/shard-rkl-7/igt@kms_big_joiner@basic.html
* igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_mc_ccs:
- shard-tglu: NOTRUN -> [SKIP][34] ([i915#3689] / [i915#3886] / [i915#5354] / [i915#6095])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/shard-tglu-8/igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-a-crc-sprite-planes-basic-4_tiled_dg2_mc_ccs:
- shard-tglu: NOTRUN -> [SKIP][35] ([i915#3689] / [i915#5354] / [i915#6095])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/shard-tglu-7/igt@kms_ccs@pipe-a-crc-sprite-planes-basic-4_tiled_dg2_mc_ccs.html
* igt@kms_ccs@pipe-d-crc-sprite-planes-basic-4_tiled_dg2_rc_ccs:
- shard-tglu: NOTRUN -> [SKIP][36] ([i915#5354] / [i915#6095]) +1 similar issue
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/shard-tglu-10/igt@kms_ccs@pipe-d-crc-sprite-planes-basic-4_tiled_dg2_rc_ccs.html
* igt@kms_chamelium_color@ctm-max:
- shard-tglu: NOTRUN -> [SKIP][37] ([fdo#111827])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/shard-tglu-6/igt@kms_chamelium_color@ctm-max.html
* igt@kms_chamelium_hpd@hdmi-hpd-for-each-pipe:
- shard-tglu: NOTRUN -> [SKIP][38] ([i915#7828])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/shard-tglu-2/igt@kms_chamelium_hpd@hdmi-hpd-for-each-pipe.html
* igt@kms_cursor_legacy@cursora-vs-flipb-atomic-transitions-varying-size:
- shard-tglu: NOTRUN -> [SKIP][39] ([fdo#109274])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/shard-tglu-6/igt@kms_cursor_legacy@cursora-vs-flipb-atomic-transitions-varying-size.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-glk: [PASS][40] -> [FAIL][41] ([i915#2346]) +1 similar issue
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13267/shard-glk6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/shard-glk9/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
* igt@kms_cursor_legacy@single-bo@pipe-b:
- shard-rkl: [PASS][42] -> [INCOMPLETE][43] ([i915#8011]) +1 similar issue
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13267/shard-rkl-6/igt@kms_cursor_legacy@single-bo@pipe-b.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/shard-rkl-7/igt@kms_cursor_legacy@single-bo@pipe-b.html
* igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-32bpp-yftileccs-upscaling@pipe-a-valid-mode:
- shard-tglu: NOTRUN -> [SKIP][44] ([i915#2587] / [i915#2672] / [i915#4579])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/shard-tglu-3/igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-32bpp-yftileccs-upscaling@pipe-a-valid-mode.html
* igt@kms_frontbuffer_tracking@fbc-2p-rte:
- shard-rkl: NOTRUN -> [SKIP][45] ([fdo#111825] / [i915#1825])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/shard-rkl-1/igt@kms_frontbuffer_tracking@fbc-2p-rte.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-shrfb-plflip-blt:
- shard-tglu: NOTRUN -> [SKIP][46] ([fdo#109280]) +3 similar issues
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/shard-tglu-5/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-shrfb-plflip-blt.html
* igt@kms_frontbuffer_tracking@psr-shrfb-scaledprimary:
- shard-tglu: NOTRUN -> [SKIP][47] ([fdo#110189]) +4 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/shard-tglu-6/igt@kms_frontbuffer_tracking@psr-shrfb-scaledprimary.html
* igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-25@pipe-a-hdmi-a-2:
- shard-rkl: NOTRUN -> [SKIP][48] ([i915#5176]) +1 similar issue
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/shard-rkl-3/igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-25@pipe-a-hdmi-a-2.html
* igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-5@pipe-b-hdmi-a-1:
- shard-snb: NOTRUN -> [SKIP][49] ([fdo#109271] / [i915#4579]) +10 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/shard-snb1/igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-5@pipe-b-hdmi-a-1.html
* igt@kms_plane_scaling@plane-upscale-with-rotation-factor-0-25@pipe-b-hdmi-a-1:
- shard-rkl: NOTRUN -> [SKIP][50] ([i915#4579] / [i915#5176]) +1 similar issue
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/shard-rkl-7/igt@kms_plane_scaling@plane-upscale-with-rotation-factor-0-25@pipe-b-hdmi-a-1.html
* igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-25@pipe-a-hdmi-a-2:
- shard-rkl: NOTRUN -> [SKIP][51] ([i915#5235]) +1 similar issue
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/shard-rkl-6/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-25@pipe-a-hdmi-a-2.html
* igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-25@pipe-b-hdmi-a-2:
- shard-rkl: NOTRUN -> [SKIP][52] ([i915#4579] / [i915#5235]) +1 similar issue
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/shard-rkl-6/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-25@pipe-b-hdmi-a-2.html
* igt@kms_psr@sprite_mmap_gtt:
- shard-rkl: NOTRUN -> [SKIP][53] ([i915#1072])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/shard-rkl-1/igt@kms_psr@sprite_mmap_gtt.html
* igt@kms_setmode@invalid-clone-single-crtc-stealing:
- shard-tglu: NOTRUN -> [SKIP][54] ([i915#3555] / [i915#4579])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/shard-tglu-9/igt@kms_setmode@invalid-clone-single-crtc-stealing.html
* igt@kms_tiled_display@basic-test-pattern-with-chamelium:
- shard-tglu: NOTRUN -> [SKIP][55] ([i915#8623])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/shard-tglu-3/igt@kms_tiled_display@basic-test-pattern-with-chamelium.html
* igt@kms_universal_plane@universal-plane-pipe-d-functional:
- shard-rkl: NOTRUN -> [SKIP][56] ([i915#4070] / [i915#533] / [i915#6768])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/shard-rkl-6/igt@kms_universal_plane@universal-plane-pipe-d-functional.html
* igt@kms_vblank@pipe-c-wait-forked-busy-hang:
- shard-rkl: NOTRUN -> [SKIP][57] ([i915#4070] / [i915#6768])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/shard-rkl-3/igt@kms_vblank@pipe-c-wait-forked-busy-hang.html
* igt@kms_vrr@flip-basic:
- shard-apl: NOTRUN -> [SKIP][58] ([fdo#109271] / [i915#4579])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/shard-apl4/igt@kms_vrr@flip-basic.html
* igt@v3d/v3d_submit_csd@single-out-sync:
- shard-rkl: NOTRUN -> [SKIP][59] ([fdo#109315])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/shard-rkl-1/igt@v3d/v3d_submit_csd@single-out-sync.html
* igt@v3d/v3d_wait_bo@unused-bo-1ns:
- shard-snb: NOTRUN -> [SKIP][60] ([fdo#109271]) +29 similar issues
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/shard-snb7/igt@v3d/v3d_wait_bo@unused-bo-1ns.html
#### Possible fixes ####
* igt@drm_fdinfo@most-busy-check-all@rcs0:
- shard-rkl: [FAIL][61] ([i915#7742]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13267/shard-rkl-6/igt@drm_fdinfo@most-busy-check-all@rcs0.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/shard-rkl-4/igt@drm_fdinfo@most-busy-check-all@rcs0.html
* igt@gem_barrier_race@remote-request@rcs0:
- {shard-dg1}: [ABORT][63] ([i915#7461] / [i915#8234]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13267/shard-dg1-12/igt@gem_barrier_race@remote-request@rcs0.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/shard-dg1-18/igt@gem_barrier_race@remote-request@rcs0.html
* igt@gem_eio@reset-stress:
- {shard-dg1}: [FAIL][65] ([i915#5784]) -> [PASS][66] +1 similar issue
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13267/shard-dg1-13/igt@gem_eio@reset-stress.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/shard-dg1-16/igt@gem_eio@reset-stress.html
* igt@gem_exec_fair@basic-none@vcs0:
- shard-rkl: [FAIL][67] ([i915#2842]) -> [PASS][68] +1 similar issue
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13267/shard-rkl-3/igt@gem_exec_fair@basic-none@vcs0.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/shard-rkl-2/igt@gem_exec_fair@basic-none@vcs0.html
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-glk: [FAIL][69] ([i915#2842]) -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13267/shard-glk2/igt@gem_exec_fair@basic-pace-solo@rcs0.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/shard-glk8/igt@gem_exec_fair@basic-pace-solo@rcs0.html
* igt@gem_lmem_swapping@smem-oom@lmem0:
- {shard-dg1}: [TIMEOUT][71] ([i915#5493]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13267/shard-dg1-12/igt@gem_lmem_swapping@smem-oom@lmem0.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/shard-dg1-17/igt@gem_lmem_swapping@smem-oom@lmem0.html
* igt@i915_pm_rpm@dpms-non-lpsp:
- shard-rkl: [SKIP][73] ([i915#1397]) -> [PASS][74] +2 similar issues
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13267/shard-rkl-7/igt@i915_pm_rpm@dpms-non-lpsp.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/shard-rkl-2/igt@i915_pm_rpm@dpms-non-lpsp.html
* igt@i915_pm_rpm@i2c:
- shard-glk: [FAIL][75] ([i915#5466]) -> [PASS][76]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13267/shard-glk1/igt@i915_pm_rpm@i2c.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/shard-glk8/igt@i915_pm_rpm@i2c.html
* igt@i915_pm_rpm@modeset-lpsp-stress:
- {shard-dg1}: [SKIP][77] ([i915#1397]) -> [PASS][78] +2 similar issues
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13267/shard-dg1-18/igt@i915_pm_rpm@modeset-lpsp-stress.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/shard-dg1-19/igt@i915_pm_rpm@modeset-lpsp-stress.html
* igt@kms_cursor_legacy@single-move@pipe-b:
- shard-rkl: [INCOMPLETE][79] ([i915#8011]) -> [PASS][80]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13267/shard-rkl-7/igt@kms_cursor_legacy@single-move@pipe-b.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/shard-rkl-2/igt@kms_cursor_legacy@single-move@pipe-b.html
* igt@kms_flip@flip-vs-suspend@c-dp1:
- shard-apl: [ABORT][81] ([i915#180]) -> [PASS][82]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13267/shard-apl3/igt@kms_flip@flip-vs-suspend@c-dp1.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/shard-apl4/igt@kms_flip@flip-vs-suspend@c-dp1.html
* igt@perf_pmu@most-busy-idle-check-all@rcs0:
- shard-rkl: [FAIL][83] ([i915#4349]) -> [PASS][84]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13267/shard-rkl-7/igt@perf_pmu@most-busy-idle-check-all@rcs0.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/shard-rkl-4/igt@perf_pmu@most-busy-idle-check-all@rcs0.html
#### Warnings ####
* igt@i915_pm_rc6_residency@rc6-idle@vecs0:
- shard-tglu: [FAIL][85] ([i915#2681] / [i915#3591]) -> [WARN][86] ([i915#2681])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13267/shard-tglu-3/igt@i915_pm_rc6_residency@rc6-idle@vecs0.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/shard-tglu-8/igt@i915_pm_rc6_residency@rc6-idle@vecs0.html
* igt@kms_fbcon_fbt@psr:
- shard-rkl: [SKIP][87] ([i915#3955]) -> [SKIP][88] ([fdo#110189] / [i915#3955])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13267/shard-rkl-7/igt@kms_fbcon_fbt@psr.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/shard-rkl-2/igt@kms_fbcon_fbt@psr.html
* igt@kms_multipipe_modeset@basic-max-pipe-crc-check:
- shard-rkl: [SKIP][89] ([i915#4816]) -> [SKIP][90] ([i915#4070] / [i915#4816])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13267/shard-rkl-7/igt@kms_multipipe_modeset@basic-max-pipe-crc-check.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/shard-rkl-2/igt@kms_multipipe_modeset@basic-max-pipe-crc-check.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[IGT#2]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/2
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110542]: https://bugs.freedesktop.org/show_bug.cgi?id=110542
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4816]: https://gitlab.freedesktop.org/drm/intel/issues/4816
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#5466]: https://gitlab.freedesktop.org/drm/intel/issues/5466
[i915#5493]: https://gitlab.freedesktop.org/drm/intel/issues/5493
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6493]: https://gitlab.freedesktop.org/drm/intel/issues/6493
[i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
[i915#7456]: https://gitlab.freedesktop.org/drm/intel/issues/7456
[i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#7790]: https://gitlab.freedesktop.org/drm/intel/issues/7790
[i915#7793]: https://gitlab.freedesktop.org/drm/intel/issues/7793
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7984]: https://gitlab.freedesktop.org/drm/intel/issues/7984
[i915#8011]: https://gitlab.freedesktop.org/drm/intel/issues/8011
[i915#8190]: https://gitlab.freedesktop.org/drm/intel/issues/8190
[i915#8234]: https://gitlab.freedesktop.org/drm/intel/issues/8234
[i915#8247]: https://gitlab.freedesktop.org/drm/intel/issues/8247
[i915#8292]: https://gitlab.freedesktop.org/drm/intel/issues/8292
[i915#8294]: https://gitlab.freedesktop.org/drm/intel/issues/8294
[i915#8347]: https://gitlab.freedesktop.org/drm/intel/issues/8347
[i915#8502]: https://gitlab.freedesktop.org/drm/intel/issues/8502
[i915#8623]: https://gitlab.freedesktop.org/drm/intel/issues/8623
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7327 -> IGTPW_9162
* Piglit: piglit_4509 -> None
CI-20190529: 20190529
CI_DRM_13267: f289de77157f83b6846850bca9e03d6d6576ab3c @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_9162: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/index.html
IGT_7327: 34e48b7d6402c3d7af19a40d8951eae017cf64df @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9162/index.html
[-- Attachment #2: Type: text/html, Size: 28349 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] i915/kms_busy: reduce heartbeat intervals only if neccessary
2023-06-13 19:52 [igt-dev] [PATCH i-g-t] i915/kms_busy: reduce heartbeat intervals only if neccessary Andrzej Hajda
2023-06-13 20:49 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2023-06-13 23:25 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
@ 2023-06-14 15:01 ` Nirmoy Das
2023-06-14 15:32 ` Kamil Konieczny
3 siblings, 0 replies; 6+ messages in thread
From: Nirmoy Das @ 2023-06-14 15:01 UTC (permalink / raw)
To: Andrzej Hajda, igt-dev; +Cc: Nirmoy Das
On 6/13/2023 9:52 PM, Andrzej Hajda wrote:
> Reducing heartbeat intervals may downgrade individual engine resets
> to full GPU resets. The latter is not desirable, especially
> on simulations, which do not support GPU reset. Only tests with
> reset flag enabled need reduced hearbeat intervals.
>
> Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
LGTM
Reviewed-by: Nirmoy Das <nirmoy.das@intel.com>
> ---
> tests/i915/kms_busy.c | 19 ++++++++++++-------
> 1 file changed, 12 insertions(+), 7 deletions(-)
>
> diff --git a/tests/i915/kms_busy.c b/tests/i915/kms_busy.c
> index 20d3058fb6f..ccabc38fd3f 100644
> --- a/tests/i915/kms_busy.c
> +++ b/tests/i915/kms_busy.c
> @@ -390,8 +390,6 @@ igt_main_args("e", NULL, help_str, opt_handler, NULL)
> { "extended-modeset-hang-oldfb-with-reset", true, false, true },
> { "extended-modeset-hang-newfb-with-reset", true, true, true },
> };
> - struct gem_engine_properties saved_gpu_timeouts[GEM_MAX_ENGINES];
> - int num_engines;
> int fd;
>
> igt_fixture {
> @@ -409,8 +407,6 @@ igt_main_args("e", NULL, help_str, opt_handler, NULL)
> for_each_pipe(&display, pipe)
> active_pipes[last_pipe++] = pipe;
> last_pipe--;
> -
> - gpu_engines_init_timeouts(fd, ARRAY_SIZE(saved_gpu_timeouts), &num_engines, saved_gpu_timeouts);
> }
>
> /* XXX Extend to cover atomic rendering tests to all planes + legacy */
> @@ -488,14 +484,24 @@ igt_main_args("e", NULL, help_str, opt_handler, NULL)
> continue;
>
> igt_dynamic_f("pipe-%s", kmstest_pipe_name(pipe)) {
> - if (tests[i].reset)
> + struct gem_engine_properties saved_gpu_timeouts[GEM_MAX_ENGINES];
> + int num_engines;
> +
> + if (tests[i].reset) {
> + gpu_engines_init_timeouts(display.drm_fd,
> + ARRAY_SIZE(saved_gpu_timeouts),
> + &num_engines, saved_gpu_timeouts);
> igt_set_module_param_int(display.drm_fd, "force_reset_modeset_test", 1);
> + }
>
> test_hang(&display, pipe, output,
> tests[i].modeset, tests[i].hang_newfb);
>
> - if (tests[i].reset)
> + if (tests[i].reset) {
> igt_set_module_param_int(display.drm_fd, "force_reset_modeset_test", 0);
> + gpu_engines_restore_timeouts(display.drm_fd, num_engines,
> + saved_gpu_timeouts);
> + }
> }
> }
>
> @@ -504,7 +510,6 @@ igt_main_args("e", NULL, help_str, opt_handler, NULL)
> }
>
> igt_fixture {
> - gpu_engines_restore_timeouts(fd, num_engines, saved_gpu_timeouts);
> igt_display_fini(&display);
> close(display.drm_fd);
> }
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] i915/kms_busy: reduce heartbeat intervals only if neccessary
2023-06-13 19:52 [igt-dev] [PATCH i-g-t] i915/kms_busy: reduce heartbeat intervals only if neccessary Andrzej Hajda
` (2 preceding siblings ...)
2023-06-14 15:01 ` [igt-dev] [PATCH i-g-t] " Nirmoy Das
@ 2023-06-14 15:32 ` Kamil Konieczny
2023-06-15 11:41 ` Andrzej Hajda
3 siblings, 1 reply; 6+ messages in thread
From: Kamil Konieczny @ 2023-06-14 15:32 UTC (permalink / raw)
To: igt-dev; +Cc: Nirmoy Das
Hi Andrzej,
On 2023-06-13 at 21:52:41 +0200, Andrzej Hajda wrote:
> Reducing heartbeat intervals may downgrade individual engine resets
> to full GPU resets. The latter is not desirable, especially
> on simulations, which do not support GPU reset. Only tests with
> reset flag enabled need reduced hearbeat intervals.
>
> Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
> ---
> tests/i915/kms_busy.c | 19 ++++++++++++-------
> 1 file changed, 12 insertions(+), 7 deletions(-)
>
> diff --git a/tests/i915/kms_busy.c b/tests/i915/kms_busy.c
> index 20d3058fb6f..ccabc38fd3f 100644
> --- a/tests/i915/kms_busy.c
> +++ b/tests/i915/kms_busy.c
> @@ -390,8 +390,6 @@ igt_main_args("e", NULL, help_str, opt_handler, NULL)
> { "extended-modeset-hang-oldfb-with-reset", true, false, true },
> { "extended-modeset-hang-newfb-with-reset", true, true, true },
> };
> - struct gem_engine_properties saved_gpu_timeouts[GEM_MAX_ENGINES];
> - int num_engines;
> int fd;
>
> igt_fixture {
> @@ -409,8 +407,6 @@ igt_main_args("e", NULL, help_str, opt_handler, NULL)
> for_each_pipe(&display, pipe)
> active_pipes[last_pipe++] = pipe;
> last_pipe--;
> -
> - gpu_engines_init_timeouts(fd, ARRAY_SIZE(saved_gpu_timeouts), &num_engines, saved_gpu_timeouts);
Restoration of intervals is needed after test fails so maybe we
need separate functionality into reading timeouts (starting
fixup), set new one and restore ?
> }
>
> /* XXX Extend to cover atomic rendering tests to all planes + legacy */
> @@ -488,14 +484,24 @@ igt_main_args("e", NULL, help_str, opt_handler, NULL)
> continue;
>
> igt_dynamic_f("pipe-%s", kmstest_pipe_name(pipe)) {
> - if (tests[i].reset)
> + struct gem_engine_properties saved_gpu_timeouts[GEM_MAX_ENGINES];
> + int num_engines;
> +
> + if (tests[i].reset) {
> + gpu_engines_init_timeouts(display.drm_fd,
> + ARRAY_SIZE(saved_gpu_timeouts),
> + &num_engines, saved_gpu_timeouts);
> igt_set_module_param_int(display.drm_fd, "force_reset_modeset_test", 1);
> + }
>
> test_hang(&display, pipe, output,
> tests[i].modeset, tests[i].hang_newfb);
>
> - if (tests[i].reset)
> + if (tests[i].reset) {
> igt_set_module_param_int(display.drm_fd, "force_reset_modeset_test", 0);
> + gpu_engines_restore_timeouts(display.drm_fd, num_engines,
> + saved_gpu_timeouts);
If test fails this will not be run. Other way to ensure it will
be run would be to use atexit function, it may be set at first
init. Look at igt_install_exit_handler in igt_core.
Regards,
Kamil
> + }
> }
> }
>
> @@ -504,7 +510,6 @@ igt_main_args("e", NULL, help_str, opt_handler, NULL)
> }
>
> igt_fixture {
> - gpu_engines_restore_timeouts(fd, num_engines, saved_gpu_timeouts);
> igt_display_fini(&display);
> close(display.drm_fd);
> }
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] i915/kms_busy: reduce heartbeat intervals only if neccessary
2023-06-14 15:32 ` Kamil Konieczny
@ 2023-06-15 11:41 ` Andrzej Hajda
0 siblings, 0 replies; 6+ messages in thread
From: Andrzej Hajda @ 2023-06-15 11:41 UTC (permalink / raw)
To: Kamil Konieczny, igt-dev, Nirmoy Das, Andi Shyti, Imre Deak,
Pallavi Mishra, Swati Sharma
On 14.06.2023 17:32, Kamil Konieczny wrote:
> Hi Andrzej,
>
> On 2023-06-13 at 21:52:41 +0200, Andrzej Hajda wrote:
>> Reducing heartbeat intervals may downgrade individual engine resets
>> to full GPU resets. The latter is not desirable, especially
>> on simulations, which do not support GPU reset. Only tests with
>> reset flag enabled need reduced hearbeat intervals.
>>
>> Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
>> ---
>> tests/i915/kms_busy.c | 19 ++++++++++++-------
>> 1 file changed, 12 insertions(+), 7 deletions(-)
>>
>> diff --git a/tests/i915/kms_busy.c b/tests/i915/kms_busy.c
>> index 20d3058fb6f..ccabc38fd3f 100644
>> --- a/tests/i915/kms_busy.c
>> +++ b/tests/i915/kms_busy.c
>> @@ -390,8 +390,6 @@ igt_main_args("e", NULL, help_str, opt_handler, NULL)
>> { "extended-modeset-hang-oldfb-with-reset", true, false, true },
>> { "extended-modeset-hang-newfb-with-reset", true, true, true },
>> };
>> - struct gem_engine_properties saved_gpu_timeouts[GEM_MAX_ENGINES];
>> - int num_engines;
>> int fd;
>>
>> igt_fixture {
>> @@ -409,8 +407,6 @@ igt_main_args("e", NULL, help_str, opt_handler, NULL)
>> for_each_pipe(&display, pipe)
>> active_pipes[last_pipe++] = pipe;
>> last_pipe--;
>> -
>> - gpu_engines_init_timeouts(fd, ARRAY_SIZE(saved_gpu_timeouts), &num_engines, saved_gpu_timeouts);
> Restoration of intervals is needed after test fails so maybe we
> need separate functionality into reading timeouts (starting
> fixup), set new one and restore ?
I've forgot that test failure causes longjmp. Thx for pointing it out.
>
>> }
>>
>> /* XXX Extend to cover atomic rendering tests to all planes + legacy */
>> @@ -488,14 +484,24 @@ igt_main_args("e", NULL, help_str, opt_handler, NULL)
>> continue;
>>
>> igt_dynamic_f("pipe-%s", kmstest_pipe_name(pipe)) {
>> - if (tests[i].reset)
>> + struct gem_engine_properties saved_gpu_timeouts[GEM_MAX_ENGINES];
>> + int num_engines;
>> +
>> + if (tests[i].reset) {
>> + gpu_engines_init_timeouts(display.drm_fd,
>> + ARRAY_SIZE(saved_gpu_timeouts),
>> + &num_engines, saved_gpu_timeouts);
>> igt_set_module_param_int(display.drm_fd, "force_reset_modeset_test", 1);
>> + }
>>
>> test_hang(&display, pipe, output,
>> tests[i].modeset, tests[i].hang_newfb);
>>
>> - if (tests[i].reset)
>> + if (tests[i].reset) {
>> igt_set_module_param_int(display.drm_fd, "force_reset_modeset_test", 0);
>> + gpu_engines_restore_timeouts(display.drm_fd, num_engines,
>> + saved_gpu_timeouts);
> If test fails this will not be run. Other way to ensure it will
> be run would be to use atexit function, it may be set at first
> init. Look at igt_install_exit_handler in igt_core.
OK, but in atexit it will be run only at exit of the process, with
subsequent tests having wrong timeouts.
Maybe I can put them into fixtures in tests[] loop, restore will be then
called even if test fails.
Regards
Andrzej
>
> Regards,
> Kamil
>
>> + }
>> }
>> }
>>
>> @@ -504,7 +510,6 @@ igt_main_args("e", NULL, help_str, opt_handler, NULL)
>> }
>>
>> igt_fixture {
>> - gpu_engines_restore_timeouts(fd, num_engines, saved_gpu_timeouts);
>> igt_display_fini(&display);
>> close(display.drm_fd);
>> }
>> --
>> 2.34.1
>>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-06-15 11:44 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-13 19:52 [igt-dev] [PATCH i-g-t] i915/kms_busy: reduce heartbeat intervals only if neccessary Andrzej Hajda
2023-06-13 20:49 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2023-06-13 23:25 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2023-06-14 15:01 ` [igt-dev] [PATCH i-g-t] " Nirmoy Das
2023-06-14 15:32 ` Kamil Konieczny
2023-06-15 11:41 ` Andrzej Hajda
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.